Re: [Qemu-devel] [for-2.10 PATCH v2] 9pfs: local: fix fchmodat_nofollow() limitations

On Wed, 9 Aug 2017 10:59:46 -0500 Eric Blake wrote: > On 08/09/2017 10:22 AM, Greg Kurz wrote: > > >>> > >>> The solution is to use O_PATH: openat() now succeeds in both cases, and we > >>> can ensure the path isn't a symlink with fstat(). The associated entry in > >>>

Re: [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS

Am 08.08.2017 um 19:57 hat John Snow geschrieben: > From: Kevin Wolf > > This allows us to detect errors in cache flushing (ENOMEDIUM) > without choking on a null dereference because we assume that > blk_bs(bb) is always defined. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [for-2.10 PATCH v3] 9pfs: local: fix fchmodat_nofollow() limitations

On 08/09/2017 11:00 AM, Greg Kurz wrote: > This function has to ensure it doesn't follow a symlink that could be used > to escape the virtfs directory. This could be easily achieved if fchmodat() > on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but > it doesn't. There was a

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

Marcel, The findings are pretty consistent with what I identified. Although it looks like SeaBIOS fairs better than UEFI. Thanks for the headsup, will reply on the thread itself. Ray K -Original Message- From: Marcel Apfelbaum [mailto:mar...@redhat.com] Sent: Wednesday, August 9, 2017

Re: [Qemu-devel] No video for Windows 2000 guest

On 09/08/2017 16:56, Programmingkid wrote: > The default vga card not longer works with a Windows 2000 guest. All I see is > a black screen after a the Windows splash screen. > > This is the command-line I used: > > qemu-system-i386 -hda Windows2000HD.qcow2 -boot c -m 512 > > When using the

Re: [Qemu-devel] [PATCH v4 19/22] libqtest: Add qmp_args_dict() helper

On 08/09/2017 10:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Leaving interpolation into JSON to qobject_from_jsonf() is more >> robust than building QMP input manually; however, we have a few >> places where code is already creating a QDict to interpolate >>

Re: [Qemu-devel] [PATCH v5 10/17] migration: Create ram_multifd_page

On 08/08/2017 21:14, Dr. David Alan Gilbert wrote: >> There is no barrier there that I can see. I know that it probably work >> on x86, but in others? I think that it *** HERE we need that >> memory barrier that we don't have. > Yes, I think that's smp_mb_release() - and you have to do an >

Re: [Qemu-devel] [PATCH RFC 0/6] QEMU: kvm: cleanup kvm_slot handling

On 09/08/2017 15:33, David Hildenbrand wrote: > If I am not missing something important here, we can heavily simplify > the kvm_slot code. Flatview will make sure that we don't have to deal > with overlapping slots. E.g. when a memory section is resized, we are > first notified about the removal

Re: [Qemu-devel] [PATCH v2 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

I only had time for a quick look. More review when you repost after release. On Thu, Aug 10, 2017 at 06:12:29PM +0800, Changpeng Liu wrote: > This commit introduces a new vhost-user device for block, it uses a > chardev to connect with the backend, same with Qemu virito-blk device, > Guest OS

Re: [Qemu-devel] [PATCH v2 for 2.10] iotests: fix 185

On 08/09/2017 10:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2017 18:17, Vladimir Sementsov-Ogievskiy wrote: >> 185 can sometimes produce wrong output like this: >> >> >> This is because quite happens before first mirror request is done > > s/quite/quit/ > >> (and, in specified case,

Re: [Qemu-devel] [PATCH v4 15/22] libqtest: Delete qtest_qmp() wrappers

Eric Blake writes: > None of our tests were directly using qtest_qmp() and friends; > even tests like postcopy-test.c that manage multiple connections > get along just fine changing global_qtest as needed (other than > one callsite where it forgot to use the inlined form).

Re: [Qemu-devel] [PATCH v4 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-09 13:18 GMT+03:00 Laszlo Ersek : > On 08/08/17 21:21, Aleksandr Bezzubikov wrote: >> 2017-08-08 18:11 GMT+03:00 Laszlo Ersek : >>> one comment below >>> >>> On 08/05/17 22:27, Aleksandr Bezzubikov wrote: >>> +Capability layout (defined in

Re: [Qemu-devel] [PATCH v2 0/4] *** Introduce a new vhost-user-blk host device to Qemu ***

On Thu, Aug 10, 2017 at 06:12:27PM +0800, Changpeng Liu wrote: > Althrough virtio scsi specification was designed as a replacement for > virtio_blk, > there are still many users using virtio_blk. Qemu 2.9 introduced a new device > vhost user scsi which can process I/O in user space for

Re: [Qemu-devel] Qemu and 32 PCIe devices

On Wed, Aug 09, 2017 at 09:26:11AM +0200, Paolo Bonzini wrote: > On 09/08/2017 03:06, Laszlo Ersek wrote: > >> 20.14% qemu-system-x86_64 [.] render_memory_region > >> 17.14% qemu-system-x86_64 [.] subpage_register > >> 10.31% qemu-system-x86_64

Re: [Qemu-devel] [PATCH v4 5/5] docs: update documentation considering PCIE-PCI bridge

On 08/09/17 18:52, Aleksandr Bezzubikov wrote: > 2017-08-09 13:18 GMT+03:00 Laszlo Ersek : >> On 08/08/17 21:21, Aleksandr Bezzubikov wrote: >>> 2017-08-08 18:11 GMT+03:00 Laszlo Ersek : one comment below On 08/05/17 22:27, Aleksandr Bezzubikov

Re: [Qemu-devel] No video for Windows 2000 guest

On Wed, Aug 09, 2017 at 01:54:23PM -0400, Programmingkid wrote: > > > On Aug 9, 2017, at 1:18 PM, Michael S. Tsirkin wrote: > > > > On Wed, Aug 09, 2017 at 06:37:12PM +0200, Paolo Bonzini wrote: > >> On 09/08/2017 16:56, Programmingkid wrote: > >>> The default vga card not

Re: [Qemu-devel] No video for Windows 2000 guest

> On Aug 9, 2017, at 12:37 PM, Paolo Bonzini wrote: > > On 09/08/2017 16:56, Programmingkid wrote: >> The default vga card not longer works with a Windows 2000 guest. All I see >> is a black screen after a the Windows splash screen. >> >> This is the command-line I used:

Re: [Qemu-devel] [PATCH v2 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

Hi - Original Message - > This commit introcudes a vhost-user-blk backend device, it uses UNIX > domain socket to communicate with Qemu. The vhost-user-blk sample > application should be used with Qemu vhost-user-blk-pci device. > > To use it, complie with: > make vhost-user-blk > > and

Re: [Qemu-devel] [PATCH v2 3/4] contrib/libvhost-user: enable virtio config space messages

Hi - Original Message - > Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD > messages in libvhost-user library, users can implement their own I/O target > based on the library. This enable the virtio config space delivered between > Qemu host device and the I/O

[Qemu-devel] [Bug 904308] Re: x86: BT/BTS/BTR/BTC: ZF flag is unaffected

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/904308 Title: x86:

Re: [Qemu-devel] No video for Windows 2000 guest

On 09.08.2017 20:12, Programmingkid wrote: > >> On Aug 9, 2017, at 12:37 PM, Paolo Bonzini wrote: >> >> On 09/08/2017 16:56, Programmingkid wrote: >>> The default vga card not longer works with a Windows 2000 guest. All I see >>> is a black screen after a the Windows splash

Re: [Qemu-devel] [RFC PATCH 27/56] block/dirty-bitmap: Clean up signed vs. unsigned dirty counts

Eric Blake writes: > On 08/07/2017 09:45 AM, Markus Armbruster wrote: >> hbitmap_count() returns uint64_t. >> >> Clean up test-hbitmap.c to check its value with g_assert_cmpuint() >> instead of g_assert_cmpint(). >> >> bdrv_get_dirty_count() and bdrv_get_meta_dirty_count()

Re: [Qemu-devel] [RFC PATCH 10/56] hmp: Make balloon's argument unsigned

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The previous commit made it unsigned in QMP. Switch HMP's args_type >> from 'M' to 'o'. Loses support for expressions (QEMU pocket >> calculator), gains support for units other than

[Qemu-devel] [PATCH for 2.11 v2 0/2] wdt_aspeed: Support reset width patterns

Hello, These two patches add support for the reset width configuration register in the Aspeed watchdog. Initially this was just one patch[1], but I've reworked it as two to explicitly support the varying capabilities between Aspeed SoC versions. Andrew [1]

[Qemu-devel] [PATCH for 2.11 v2 2/2] aspeed_soc: Propagate silicon-rev to watchdog

This is required to configure differences in behaviour between the AST2400 and AST2500 watchdog IPs. Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index

Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

Ugh, disregard this one; I changed the subject and reissued `git format-patch`, which naturally doesn't overwrite any existing patch in the output directory and so the old one got sent as well. Andrew On Wed, 2017-08-09 at 15:58 +0930, Andrew Jeffery wrote: > This is required to configure

[Qemu-devel] [PULL 2/6] ppc: fix double-free in cpu_post_load()

From: Greg Kurz When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes because of "double free or corruption (!prev)". The crash happens because error_report_err() has already called error_free(). Signed-off-by: Greg Kurz Reviewed-by: Eric

[Qemu-devel] [PULL 3/6] target/ppc: Implement TIDR

This adds a trivial implementation of the TIDR register added in POWER9. This isn't particularly important to qemu directly - it's used by accelerator modules that we don't emulate. However, since qemu isn't aware of it, its state is not synchronized with KVM and therefore not migrated, which

[Qemu-devel] [PULL 4/6] target/ppc: Add stub implementation of the PSSCR

The PSSCR register added in POWER9 controls certain power saving mode behaviours. Mostly, it's not relevant to TCG, however because qemu doesn't know about it yet, it doesn't synchronize the state with KVM, and thus it doesn't get migrated. To fix that, this adds a minimal stub implementation of

[Qemu-devel] [PULL 6/6] spapr: Fix bug in h_signal_sys_reset()

From: Sam Bobroff The unicast case in h_signal_sys_reset() seems to be broken: rather than selecting the target CPU, it looks like it will pick either the first CPU or fail to find one at all. Fix it by using the search function rather than open coding the search. This

Re: [Qemu-devel] [PATCH v4 04/22] tests: Add assertion for no qmp("")

Eric Blake writes: > Now that the previous patches have fixed all callers to avoid an > empty message, we can tweak qmp_fd_sendv() to assert that we > don't introduce new callers, and reindent accordingly. The > additional assertions will also help verify that later

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

On Wed, Aug 09, 2017 at 10:05:19AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > >> Peter Xu wrote: > >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > >> > > >> > [...]

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 10:23:04 +0200 Thomas Huth wrote: > On 09.08.2017 09:17, Cornelia Huck wrote: > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > > device. > > > > Let's

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On 09.08.2017 09:17, Cornelia Huck wrote: > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > on CONFIG_VIRTFS and on the presence of an appropriate virtio transport > device. > > Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for > CONFIG_VIRTFS &&

Re: [Qemu-devel] [RFC PATCH 03/56] monitor: Rewrite comment describing HMP .args_type

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> Signed-off-by: Markus Armbruster >> >> --- >> >>

Re: [Qemu-devel] [RFC PATCH 32/56] hmp: Make block_set_io_throttle's arguments unsigned

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The previous commit made them unsigned in QMP. Switch HMP's args_type >> from 'l' to 'o'. Loses support for expressions (QEMU pocket >> calculator), gains support for unit suffixes.

[Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09

The following changes since commit 54affb3a3623b1d36c95e34faa722a5831323a74: Update version for v2.10.0-rc2 release (2017-08-08 19:07:46 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170809 for you to fetch changes up

[Qemu-devel] [PULL 1/6] booke206: fix MAS update on tlb miss

From: KONRAD Frederic When a tlb instruction miss happen, rw is set to 0 at the bottom of cpu_ppc_handle_mmu_fault which cause the MAS update function to miss the SAS and TS bit in MAS6, MAS1 in booke206_update_mas_tlb_miss. Just calling booke206_update_mas_tlb_miss

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: > > > > [...] > > > >> static int multifd_send_page(uint8_t *address) > >> { > >> -int i; > >> +int i, j; > >>

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

On Tue, Aug 08, 2017 at 11:19:35AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > > > > [...] > > > >> int multifd_load_setup(void) > >> { > >> int thread_count; > >> -uint8_t i; > >> > >> if

Re: [Qemu-devel] [RFC PATCH 09/56] balloon: Make balloon size unsigned in QAPI/QMP

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Sizes should use QAPI type 'size' (uint64_t). balloon parameter >> @value is 'int' (int64_t). qmp_balloon() implicitly converts to >> ram_addr_t, i.e. uint64_t. BALLOON_CHANGE parameter

[Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

The reset width register controls how the pulse on the SoC's WDTRST{1,2} pins behaves. A pulse is emitted if the external reset bit is set in WDT_CTRL. On the AST2500 WDT_RESET_WIDTH can consume magic bit patterns to configure push-pull/open-drain and active-high/active-low behaviours and thus

[Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

This is required to configure differences in behaviour between the AST2400 and AST2500 watchdog IPs. Signed-off-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 09/08/2017 03:06, Laszlo Ersek wrote: >> 20.14% qemu-system-x86_64 [.] render_memory_region >> 17.14% qemu-system-x86_64 [.] subpage_register >> 10.31% qemu-system-x86_64 [.] int128_add >>7.86% qemu-system-x86_64

Re: [Qemu-devel] [PATCH v4 05/22] qobject: Simplify qobject_from_jsonv()

Eric Blake writes: > qobject_from_jsonv() was unusual in that it took a va_list*, instead > of the more typical va_list; this was so that callers could pass > NULL to avoid % interpolation. While this works under the hood, it > is awkward for callers, so move the magic into

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

Peter Xu wrote: > On Tue, Aug 08, 2017 at 06:06:04PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: >> > >> > [...] >> > >> >> static int multifd_send_page(uint8_t *address) >> >> { >> >>

Re: [Qemu-devel] [PATCH] 9pfs: fix dependencies

On Wed, 9 Aug 2017 07:12:51 +0200 Thomas Huth wrote: > On 08.08.2017 18:26, Greg Kurz wrote: > > On Tue, 8 Aug 2017 17:38:27 +0200 > > Cornelia Huck wrote: > > > >> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > >> on

[Qemu-devel] [Bug 1357175] Re: qemu fails to build on powerpc64

OK, thanks for checking! ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1357175 Title: qemu fails to build on powerpc64 Status in

[Qemu-devel] [PULL 5/6] spapr_drc: abort if object_property_add_child() fails

From: Greg Kurz object_property_add_child() can only fail in two cases: - the child already has a parent, which shouldn't happen since the DRC was allocated a few lines above - the parent already has a child with the same name, which would mean the caller tries to create a

[Qemu-devel] [PATCH v2] 9pfs: fix dependencies

Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend on CONFIG_VIRTFS and on the presence of an appropriate virtio transport device. Let's introduce CONFIG_VIRTIO_CCW to cover s390x and check for CONFIG_VIRTFS && (CONFIG_VIRTIO_PCI || CONFIG_VIRTIO_CCW). Signed-off-by: Cornelia

Re: [Qemu-devel] [PATCH for-2.11 0/4] ppc64: add e6500

On Mon, Aug 07, 2017 at 05:50:44PM +0200, KONRAD Frederic wrote: > Hi, > > Those are some patches to add basic e6500 support for the moment e5500 with a > correct MMU configuration and supported instructions. > Some (maybe a lot of) things are missing (ie: the thread support) but it is > enough

Re: [Qemu-devel] [PATCH v3 1/1] ppc: spapr: Make VCPU ID handling private to SPAPR

On Wed, Aug 09, 2017 at 03:38:56PM +1000, Sam Bobroff wrote: > The concept of a VCPU ID that differs from the CPU's index > (cpu->cpu_index) exists only within SPAPR machines so, move the > functions ppc_get_vcpu_id() and ppc_get_cpu_by_vcpu_id() into spapr.c > and rename them appropriately. > >

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

On Tue, 8 Aug 2017 14:14:18 -0500 Eric Blake wrote: > On 08/08/2017 12:28 PM, Greg Kurz wrote: > > This function has to ensure it doesn't follow a symlink that could be used > > to escape the virtfs directory. This could be easily achieved if fchmodat() > > on linux honored

Re: [Qemu-devel] [PATCH v5 10/17] migration: Create ram_multifd_page

On Tue, Aug 08, 2017 at 06:04:54PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jul 19, 2017 at 08:02:39PM +0100, Dr. David Alan Gilbert wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > > >> > struct MultiFDSendParams { > >> > +/* not changed */ >

Re: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

On Wed, Aug 09, 2017 at 04:17:05AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 08, 2017 at 04:59:02PM -0700, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably

Re: [Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

Eric Blake writes: > We want -Wformat to catch blatant programming errors in format > strings that we pass to qobject_from_jsonf(). But if someone > were to pass a JSON string "'%s'" as the format string, gcc would > insist that it be paired with a char* argument, even though

Re: [Qemu-devel] [PATCH v4 07/22] numa-test: Use hmp()

Eric Blake writes: > Don't open-code something that has a convenient helper available. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 11:07:38 +0200 Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

On Tue, Aug 08, 2017 at 05:39:31PM -0300, Eduardo Habkost wrote: > It makes command-line parsing and generation of help text much > simpler. > > The optparse module is deprecated since Python 2.7, but argparse > is not available in Python 2.6 (the minimum Python version > required for building

Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver

On Tue, Aug 08, 2017 at 05:04:48PM +0200, Alberto Garcia wrote: On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote: So basically if we have anonymous groups, we accept limits in the driver options but only without a group-name. In the commit message you do however have limits and

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 10:24:13 +0100 "Daniel P. Berrange" wrote: > On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > > On 09.08.2017 10:27, Cornelia Huck wrote: > > > On Wed, 9 Aug 2017 10:23:04 +0200 > > > Thomas Huth wrote: > > > > > >> On

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 10:27:37 +0200 Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > > > On 09.08.2017 09:17, Cornelia Huck wrote: > > > Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend > > > on

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > virtio-mmio seems to work different. As far as I can see, there are no > dedicated

[Qemu-devel] [PATCH v2 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

This commit introduces a new vhost-user device for block, it uses a chardev to connect with the backend, same with Qemu virito-blk device, Guest OS still uses the virtio-blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev

[Qemu-devel] [PATCH v2 1/4] vhost-user: add new vhost user messages to support virtio config space

Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration for vhost user devices, also vhost user devices can benifit from the messages to get/set virtio config space from/to the I/O target besides Qemu. For the purpose to support virtio config space change,

[Qemu-devel] [PATCH v2 0/4] *** Introduce a new vhost-user-blk host device to Qemu ***

Althrough virtio scsi specification was designed as a replacement for virtio_blk, there are still many users using virtio_blk. Qemu 2.9 introduced a new device vhost user scsi which can process I/O in user space for virtio_scsi, this commit introduces a new vhost user block host device, which can

[Qemu-devel] [PATCH v2 3/4] contrib/libvhost-user: enable virtio config space messages

Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD messages in libvhost-user library, users can implement their own I/O target based on the library. This enable the virtio config space delivered between Qemu host device and the I/O target, also event notifier is added in

[Qemu-devel] [PATCH v4 0/7] add throttle block driver filter

This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex

[Qemu-devel] [PATCH v4 2/7] block: add aio_context field in ThrottleGroupMember

timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia

[Qemu-devel] [PATCH v4 5/7] block: add throttle block filter driver

block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2, \

Re: [Qemu-devel] [PATCH v4 5/5] docs: update documentation considering PCIE-PCI bridge

On 08/08/17 21:21, Aleksandr Bezzubikov wrote: > 2017-08-08 18:11 GMT+03:00 Laszlo Ersek : >> one comment below >> >> On 08/05/17 22:27, Aleksandr Bezzubikov wrote: >> >>> +Capability layout (defined in include/hw/pci/pci_bridge.h): >>> + >>> +uint8_t id; Standard PCI

Re: [Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

On Wed, Aug 9, 2017, at 18:28, Cédric Le Goater wrote: > On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > > The reset width register controls how the pulse on the SoC's WDTRST{1,2} > > pins behaves. A pulse is emitted if the external reset bit is set in > > WDT_CTRL. On the AST2500

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On Tue, Aug 08, 2017 at 04:52:25PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Aug 08, 2017 at 10:06:04AM +0200, Markus Armbruster wrote: > >> Stefan Hajnoczi writes: > >> > >> > On Wed, Jul 26, 2017 at 02:24:02PM -0400,

Re: [Qemu-devel] [PATCH for 2.11 v2 2/2] ARM: aspeed_soc: Propagate silicon-rev to watchdog

On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > This is required to configure differences in behaviour between the > AST2400 and AST2500 watchdog IPs. > > Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater > --- > hw/arm/aspeed_soc.c | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On 09.08.2017 10:27, Cornelia Huck wrote: > On Wed, 9 Aug 2017 10:23:04 +0200 > Thomas Huth wrote: > >> On 09.08.2017 09:17, Cornelia Huck wrote: >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend >>> on CONFIG_VIRTFS and on the presence of an appropriate

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

On Tue, Aug 08, 2017 at 05:39:34PM -0300, Eduardo Habkost wrote: > This is useful for testing QMP commands in scripts. > > Example usage, combined with 'jq' for filtering the results: > > $ ./scripts/qmp/qmp-shell /tmp/qmp qom-list path=/ | jq -r .return[].name > machine > type >

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

On 09.08.2017 11:05, Cornelia Huck wrote: > On Wed, 9 Aug 2017 06:59:37 +0200 > Thomas Huth wrote: > >> Re-using the boot_sector code buffer from x86 for other architectures >> is not very nice, especially if we add more architectures later. It's >> also ugly that the test

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

On Wed, 9 Aug 2017 11:18:33 +0200 Thomas Huth wrote: > On 09.08.2017 11:05, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 06:59:37 +0200 > > Thomas Huth wrote: > >> @@ -80,16 +81,26 @@ int boot_sector_init(char *fname) > >> return 1; > >> } > >>

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] IDE: Do not flush empty CDROM drives

On Tue, Aug 08, 2017 at 01:57:08PM -0400, John Snow wrote: > The block backend changed in a way that flushing empty CDROM drives > is now an error. Amend IDE to avoid doing so until the root problem > can be addressed for 2.11. > > Reported-by: Kieron Shorrock >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, 9 Aug 2017 10:47:18 +0100 Peter Maydell wrote: > On 9 August 2017 at 10:07, Thomas Huth wrote: > > While virtio-pci and virtio-ccw seem to require separate dedicated > > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, > >

[Qemu-devel] [PATCH v2 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s

[Qemu-devel] [PATCH v4 1/7] block: move ThrottleGroup membership to ThrottleGroupMember

This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This

[Qemu-devel] [PATCH v4 6/7] block: add BlockDevOptionsThrottle to QAPI

This is needed to configure throttle filter driver nodes with QAPI. Signed-off-by: Manos Pitsidianakis --- qapi/block-core.json | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index

[Qemu-devel] [PATCH v4 7/7] block: add throttle block filter driver interface tests

Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 310 + tests/qemu-iotests/184.out | 422 + tests/qemu-iotests/group | 1 + 3 files changed, 733 insertions(+) create mode

[Qemu-devel] [PATCH v4 4/7] block: convert ThrottleGroup to object with QOM

ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP.

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 09/08/2017 12:00, Laszlo Ersek wrote: > On 08/09/17 09:26, Paolo Bonzini wrote: >> On 09/08/2017 03:06, Laszlo Ersek wrote: 20.14% qemu-system-x86_64 [.] render_memory_region 17.14% qemu-system-x86_64 [.] subpage_register 10.31%

Re: [Qemu-devel] [PATCH for 2.11 v2 1/2] watchdog: wdt_aspeed: Add support for the reset width register

On 08/09/2017 08:28 AM, Andrew Jeffery wrote: > The reset width register controls how the pulse on the SoC's WDTRST{1,2} > pins behaves. A pulse is emitted if the external reset bit is set in > WDT_CTRL. On the AST2500 WDT_RESET_WIDTH can consume magic bit patterns > to configure

Re: [Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

On Wed, 9 Aug 2017 06:59:37 +0200 Thomas Huth wrote: > Re-using the boot_sector code buffer from x86 for other architectures > is not very nice, especially if we add more architectures later. It's > also ugly that the test uses a huge pre-initialized array - the size > of the

Re: [Qemu-devel] [PATCH 2/2] tests/pxe: Check virtio-net-ccw on s390x

On Wed, 9 Aug 2017 06:59:38 +0200 Thomas Huth wrote: > Now that we've got a firmware that can do TFTP booting on s390x (i.e. > the pc-bios/s390-netboot.img), we can enable the PXE tester for this > architecture, too. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On Wed, Aug 09, 2017 at 11:07:38AM +0200, Thomas Huth wrote: > On 09.08.2017 10:27, Cornelia Huck wrote: > > On Wed, 9 Aug 2017 10:23:04 +0200 > > Thomas Huth wrote: > > > >> On 09.08.2017 09:17, Cornelia Huck wrote: > >>> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] IDE: test flush on empty CDROM

On Tue, Aug 08, 2017 at 01:57:09PM -0400, John Snow wrote: > From: Kevin Wolf > > Signed-off-by: Kevin Wolf > Signed-off-by: John Snow > --- > tests/ide-test.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote: > Both the throttling limits set with the throttling.iops-* and > throttling.bps-* options and their QMP equivalents defined in the > BlockIOThrottle struct are integer values. > > Those limits are also reported in the

Re: [Qemu-devel] [PATCH v2] 9pfs: fix dependencies

On 9 August 2017 at 10:07, Thomas Huth wrote: > While virtio-pci and virtio-ccw seem to require separate dedicated > devices (e.g. virtio-9p-pci and virtio-9p-ccw) for everything, You don't *have* to use the dedicated virtio-foo-pci device; if you like you can manually plug

Re: [Qemu-devel] Qemu and 32 PCIe devices

On 08/09/17 09:26, Paolo Bonzini wrote: > On 09/08/2017 03:06, Laszlo Ersek wrote: >>> 20.14% qemu-system-x86_64 [.] render_memory_region >>> 17.14% qemu-system-x86_64 [.] subpage_register >>> 10.31% qemu-system-x86_64 [.] int128_add >>>

[Qemu-devel] [PATCH v4 3/7] block: tidy ThrottleGroupMember initializations

Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos

[Qemu-devel] Making QEMU build with Python 3

Ross created a bug to track Python 3 support: https://bugs.launchpad.net/qemu/+bug/1708462 Currently most Python code in QEMU is for Python 2.6+ only. There have only been a few patches adding Python 3 support to certain scripts so far. In this email I want to highlight the most important

Re: [Qemu-devel] [PATCH v4 10/22] libqtest: Skip round-trip through QObject

Eric Blake writes: > When we don't have to do any % interpolation in qmp() and friends, > there is no point wasting time allocating a QObject from the format > string only to then format it back into the string we send over > the wire. True, but there's also no point in

Re: [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes

On Tue, Aug 08, 2017 at 02:56:47PM +0200, Lukáš Doktor wrote: > Dne 8.8.2017 v 14:38 Stefan Hajnoczi napsal(a): > > On Wed, Jul 26, 2017 at 04:42:17PM +0200, Lukáš Doktor wrote: > >> def command(self, cmd, conv_keys=True, **args): > >> +''' > >> +Invoke a QMP command and on

Re: [Qemu-devel] [PATCH] target/i386: set rip_offset for further SSE instructions

On 09/08/2017 01:51, Joseph Myers wrote: > It turns out that my recent fix to set rip_offset when emulating some > SSE4.1 instructions needs generalizing to cover a wider class of > instructions. Specifically, every instruction in the sse_op_table7 > table, coming from various instruction set

Re: [Qemu-devel] [PATCH] target/i386: fix pmovsx/pmovzx in-place operations

On 08/08/2017 22:21, Joseph Myers wrote: > The SSE4.1 pmovsx* and pmovzx* instructions take packed 1-byte, 2-byte > or 4-byte inputs and sign-extend or zero-extend them to a wider vector > output. The associated helpers for these instructions do the > extension on each element in turn, starting

  1   2   3   >