[Qemu-devel] [PATCH] virtio: fix descriptor counting in virtqueue_pop

While changing the s/g list allocation, commit 3b3b0628 also changed the descriptor counting to count iovec entries as split by cpu_physical_memory_map(). Previously only the actual descriptor entries were counted and the split into the iovec happened afterwards in virtqueue_map(). Count the

Re: [Qemu-devel] What is the best commit for record-replay?

> From: Alex Bennée [mailto:alex.ben...@linaro.org] > > > >>> > > > > Hope you've already found the solution (as the last post was on 2 May) > > and it's just got missed the mailing list. > >>> > >>> As I know, RR is still broken in the current version. > >>> It was caused by the

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: > On 20/09/17 05:29, David Gibson wrote: > > > On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: > >> Signed-off-by: Mark Cave-Ayland > > > > This didn't apply for me. Can you

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: > On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich > wrote: > > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > >>

[Qemu-devel] [PATCH 1/2] ppc/ide/macio: Add missing registers

From: Benjamin Herrenschmidt The timing register exists on all variants of MacIO IDE, we just store and return its value. The interrupts register only exists on KeyLargo but it doesn't hurt to have it. The lack of this register causes MacOS X to hangs under some

[Qemu-devel] [PATCH 2/2] macio: convert pmac_ide_ops from old_mmio

Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 181 +++- 1 file changed, 75 insertions(+), 106 deletions(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index db5db39..18ae952 100644 --- a/hw/ide/macio.c

[Qemu-devel] [PATCH 0/2] macio patches

Here are the macio patches taken from my previous "ppc: more Mac-related fixups" patchset with the v2 pmac_ide_ops conversion changes as requested. Signed-off-by: Mark Cave-Ayland Benjamin Herrenschmidt (1): ppc/ide/macio: Add missing registers Mark

Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store reload value

On 09/19/2017 07:15 PM, Richard Henderson wrote: > On 09/19/2017 06:17 AM, Cédric Le Goater wrote: >> +uint64_t reload; >> >> if (pclk) { >> reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND, >>s->pclk_freq); >> } else { >> -

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Fri, Sep 15, 2017 at 02:39:16PM

[Qemu-devel] [PATCH] linux_user: fix TARGET_SOL_SOCKET for sparc

Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/socket.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket.h index 129f9b4713..1db1a184b9 100644 --- a/linux-user/socket.h +++ b/linux-user/socket.h @@

[Qemu-devel] [PATCH v2] watchdog/aspeed: fix variable type to store reload value

Initially from Anton D. Kachalov" but the SoB was missing. Signed-off-by: Cédric Le Goater [clg: change commit log and subject replace UL suffix by ULL ] Signed-off-by: Cédric Le Goater --- hw/watchdog/wdt_aspeed.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

Nikunj A Dadhania writes: >> >> >>> >> I think the current approach is the simplest and less intrusive, as we >>> >> are handling a case where user has not bothered to provide a detailed >>> >> topology, the best we can do is create single threaded cores equal to >>>

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

On Wed, Sep 20, 2017 at 07:28:27AM +0100, Mark Cave-Ayland wrote: > On 20/09/17 07:00, David Gibson wrote: > > > On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: > >> On 20/09/17 05:29, David Gibson wrote: > >> > >>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland

[Qemu-devel] [PATCH v2 4/6] aspeed: Add EEPROM I2C devices

The Aspeed boards have at least one EEPROM to hold the Vital Product Data (VPD). Signed-off-by: Cédric Le Goater --- Changes since v1: - fixed palmetto EEPROM size - used smbus_eeprom_init_one() hw/arm/aspeed.c | 13 + 1 file changed, 13 insertions(+) diff --git

[Qemu-devel] [PATCH v2 6/6] aspeed: add the pc9552 chips to the witherspoon machine

The pca9552 LED blinkers on the Witherspoon machine are used for leds but also as GPIOs to control fans and GPUs. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index

Re: [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

On 19/09/2017 23:34, Eduardo Habkost wrote: On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote: Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the

Re: [Qemu-devel] [PULL v2 00/38] various s390x patches (+some fixes)

On Tue, 19 Sep 2017 19:03:13 +0200 Christian Borntraeger wrote: > On 09/19/2017 06:42 PM, Cornelia Huck wrote: > > The following changes since commit 7ec6a364916c0d1eba01128481e503a550a2b466: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On Tue, 19 Sep 2017 20:27:45 +0200 Halil Pasic wrote: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does not bother with any kind of > prefetching. We simply step through the IDAL on demand. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

* Halil Pasic [2017-09-19 14:04:03 +0200]: I have no problem with the rest parts of the discussion in this thread. > > > On 09/19/2017 12:57 PM, Cornelia Huck wrote: > > +static inline int ida_read_next_idaw(CcwDataStream *cds) > > +{ > > +union

Re: [Qemu-devel] [RFC PATCH v2 11/21] ppc/xive: push the EQ data in OS event queue

On Tue, Sep 19, 2017 at 09:36:08PM +0200, Cédric Le Goater wrote: > On 09/19/2017 09:45 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:25PM +0200, Cédric Le Goater wrote: > >> If a triggered event is let through, the Event Queue data defined in > >> the associated IVE is pushed in the

Re: [Qemu-devel] [PATCH 0/2] macio patches

On Wed, Sep 20, 2017 at 07:19:59AM +0100, Mark Cave-Ayland wrote: > Here are the macio patches taken from my previous "ppc: more Mac-related > fixups" > patchset with the v2 pmac_ide_ops conversion changes as requested. > > Signed-off-by: Mark Cave-Ayland Applied

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED blinker model

On 09/19/2017 03:27 PM, Philippe Mathieu-Daudé wrote: > On 09/19/2017 08:26 AM, Cédric Le Goater wrote: >> Specs are available here : >> >>    https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf >> >> This is a simple model supporting the basic registers for led and GPIO >> mode. The device also

[Qemu-devel] [PATCH v2 2/6] aspeed: add an I2C RTC device to all machines

The AST2500 EVB does not have an RTC but we can pretend that one is plugged on the I2C bus header. The romulus and witherspoon boards expects an Epson RX8900 I2C RTC but a ds1338 is good enough for the basic features we need. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c |

[Qemu-devel] [PATCH v2 5/6] misc: add pca9552 LED blinker model

Specs are available here : https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf This is a simple model supporting the basic registers for led and GPIO mode. The device also supports two blinking rates but not the model yet. Signed-off-by: Cédric Le Goater ---

[Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc machine

Hello, This series adds a new Aspeed machine to emulate the BMC of a Witherspoon system. It also extends the other Aspeed machines with I2C devices and adds a simple model for the pca9552 LED blinker present on the witherspoon board. Thanks, C. Changes since v1: - introduced

[Qemu-devel] [PATCH v2 3/6] smbus: add a smbus_eeprom_init_one() routine

This is an helper routine to add a single EEPROM on an I2C bus. It can be directly used by smbus_eeprom_init() which adds a certain number of EEPROMs on mips and x86 machines. Signed-off-by: Cédric Le Goater --- hw/i2c/smbus_eeprom.c | 16 +++- include/hw/i2c/smbus.h

Re: [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27

On 20.09.2017 02:45, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.10.1: > > https://github.com/mdroth/qemu/commits/stable-2.10-staging > > The release is planned for 2017-10-02: > > https://wiki.qemu.org/Planning/2.10 > > Please respond

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

* Halil Pasic [2017-09-19 20:27:44 +0200]: > The architecture mandates the addresses to be accessed on the first > indirection level (that is, the data addresses without IDA, and the > (M)IDAW addresses with (M)IDA) to be checked against an CCW format > dependent limit

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

On Thu, Sep 14, 2017 at 03:50:22PM +0800, Peter Xu wrote: > This is not a problem if we are only having one single loop thread like > before. However, after per-monitor thread is introduced, this is not > true any more, and the race can happen. > > The race can be triggered with "make check -j8"

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

On Tue, 19 Sep 2017 20:27:43 +0200 Halil Pasic wrote: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic

Re: [Qemu-devel] [PATCH] throttle-groups: update tg->any_timer_armed[] on detach

On Tue 19 Sep 2017 05:50:25 PM CEST, Stefan Hajnoczi wrote: > Clear tg->any_timer_armed[] when throttling timers are destroy during > AioContext attach/detach. Failure to do so causes throttling to hang > because we believe the timer is already scheduled! > > The following was broken at least

Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking

On Tue, 19 Sep 2017 20:27:44 +0200 Halil Pasic wrote: > The architecture mandates the addresses to be accessed on the first > indirection level (that is, the data addresses without IDA, and the > (M)IDAW addresses with (M)IDA) to be checked against an CCW format >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/20/2017 09:18 AM, Nikunj A Dadhania wrote: > David Gibson writes: > >> On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

* Halil Pasic [2017-09-19 20:27:43 +0200]: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic >

Re: [Qemu-devel] [RFC 07/15] monitor: unify global init

On Tue, Sep 19, 2017 at 04:48:35PM -0500, Eric Blake wrote: > On 09/19/2017 04:35 PM, Eric Blake wrote: > > On 09/14/2017 02:50 AM, Peter Xu wrote: > >> There are many places for monitor init its globals, at least: > >> > > > Are we sure that this new function is called sooner than any access to

Re: [Qemu-devel] RFC: Reducing the size of entries in the qcow2 L2 cache

Am 19.09.2017 um 17:07 hat Alberto Garcia geschrieben: > Hi everyone, > > over the past few weeks I have been testing the effects of reducing > the size of the entries in the qcow2 L2 cache. This was briefly > mentioned by Denis in the same thread where we discussed subcluster > allocation back

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

* Halil Pasic [2017-09-19 20:27:45 +0200]: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does not bother with any kind of > prefetching. We simply step through the IDAL on demand. > > Signed-off-by: Halil Pasic

Re: [Qemu-devel] [PATCH] net: Mark the 'hubport' netdev as deprecated

On 24.05.2017 10:04, Thomas Huth wrote: > The 'hubport' netdev is closely tied to the 'vlan' concept which > has been marked as deprecated in commit a2dbe1356faff3cb6 already. > Thus we should also mark the hubport netdevs as deprecated to make > the remaining users aware that they should not use

Re: [Qemu-devel] [PATCH v8 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

Am 19.09.2017 um 21:42 hat Eric Blake geschrieben: > However... > > >> -sbc = limit >> BDRV_SECTOR_BITS; > >> assert(DIV_ROUND_UP(bm_size, limit) == tb_size); > >> > >> -while ((sector = bdrv_dirty_iter_next(dbi) >> BDRV_SECTOR_BITS) >= 0) > >> { > >> -uint64_t cluster =

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

On 20/09/17 07:00, David Gibson wrote: > On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: >> On 20/09/17 05:29, David Gibson wrote: >> >>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland >>>

Re: [Qemu-devel] [PATCH v3 1/5] s390x/css: introduce css data stream

* Halil Pasic [2017-09-19 20:27:41 +0200]: [...] > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h > index 0653d3c9be..078356e94c 100644 > --- a/include/hw/s390x/css.h > +++ b/include/hw/s390x/css.h > @@ -75,6 +75,29 @@ typedef struct CMBE { >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 09:50:24AM

[Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

The Witherspoon boards are OpenPOWER system hosting POWER9 Processors. Let's add support for their BMC including a couple of I2C devices as found on real HW. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 49 + 1 file

Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

Hi Laszlo, On 20/09/2017 1:15, Laszlo Ersek wrote: Hi Marcel, On 09/06/17 16:26, Marcel Apfelbaum wrote: For most cases the devices attached to PCIe Root Ports do not need IO ports range, add an 'enable-io-fwd' property making it false by default, but keeping it true for older machines.

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

Hi Thomas, On 19/09/2017 11:55, Thomas Huth wrote: Historically we've marked all devices as hotpluggable by default. However, most devices are not hotpluggable, and you also need a HotplugHandler to support these devices. So if the user tries to "device_add" or "device_del" such a

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

Ping? On Thu, 7 Sep 2017, Anthony PERARD wrote: > On Mon, Aug 21, 2017 at 04:12:27PM -0700, Stefano Stabellini wrote: > > Anthony, > > > > The code looks good. I tested this patch with Linux guests and seems to > > work OK, can you also confirm? > > I've tested with Linux as well, an HVM guess,

Re: [Qemu-devel] [PATCH v10 01/10] userfault: update kernel header for UFFD_FEATURE_*

* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This commit adds modification for UFFD_FEATURE_SIGBUS and > UFFD_FEATURE_THREAD_ID. > > Signed-off-by: Alexey Perevalov This should be replaced with just running the scripts/update-linux-headers.sh against a

[Qemu-devel] SunOS support

Hi, To introduce myself: I'm a member of the illumos community (the successor to OpenSolaris, to those unfamiliar with us), and I maintain my own illumos distribution. Having seen the scary 'SUPPORT FOR THIS HOST OS WILL GO AWAY' message, I'm reaching out to see what needs to be done so that

Re: [Qemu-devel] [RFC PATCH v2 14/21] ppc/xive: add support for the SET_OS_PENDING command

On 09/19/2017 09:55 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:28PM +0200, Cédric Le Goater wrote: >> Adjusting the Interrupt Pending Buffer for the O/S would allow a CPU >> to process event queues of other priorities during one physical >> interrupt cycle. This is not currently used

Re: [Qemu-devel] [RFC PATCH v2 15/21] spapr: modify spapr_populate_pci_dt() to use a 'nr_irqs' argument

On 09/19/2017 09:56 AM, David Gibson wrote: > On Mon, Sep 11, 2017 at 07:12:29PM +0200, Cédric Le Goater wrote: >> This adds some flexibility in the definition of the number of >> available IRQS used in a sPAPR machine. >> >> Signed-off-by: Cédric Le Goater > > This doesn't seem

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On Wed, 20 Sep 2017 13:13:01 +0200 Halil Pasic wrote: > On 09/20/2017 10:33 AM, Cornelia Huck wrote: > > On Wed, 20 Sep 2017 15:42:38 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-09-19 20:27:45

[Qemu-devel] [PATCH v2] throttle-groups: update tg->any_timer_armed[] on detach

Clear tg->any_timer_armed[] when throttling timers are destroyed during AioContext attach/detach. Failure to do so causes throttling to hang because we believe the timer is already scheduled! The following was broken at least since QEMU 2.10.0 with -drive iops=100: $ dd if=/dev/zero

[Qemu-devel] [PATCH] qemu-iotests/195: Change multiple nodes in one run

This additional check for change-backing-file makes sure that actions on one part of the graph don't interfere with later actions elsewhere. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/195 | 17

[Qemu-devel] [PATCH qemu v4 01/18] exec: Explicitly export target AS from address_space_translate_internal

This adds an AS** parameter to address_space_do_translate() to make it easier for the next patch to share FlatViews. This should cause no behavioural change. Signed-off-by: Alexey Kardashevskiy --- exec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] kvm_set_phys_mem: assertion failed

On 20.09.2017 15:24, Gerd Hoffmann wrote: > Hi, > > git master crashes: > > ERROR:/home/kraxel/projects/qemu/accel/kvm/kvm- > all.c:756:kvm_set_phys_mem: assertion failed: > (!memory_region_is_ram(mr) && !writeable && !mr->romd_mode) > > bisect blames: > > commit

[Qemu-devel] [PATCH qemu v4 14/18] memory: Add flat views to HMP "info mtree"

This adds a new "-d" switch to "info mtree" to print dispatch tree internals. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * reimplemented as there is no more global FlatView list --- Example: QEMU 2.10.50 monitor - type 'help' for more information (qemu) info mtree -f

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On 09/20/2017 10:33 AM, Cornelia Huck wrote: > On Wed, 20 Sep 2017 15:42:38 +0800 > Dong Jia Shi wrote: > >> * Halil Pasic [2017-09-19 20:27:45 +0200]: >> >>> Let's add indirect data addressing support for our virtual channel >>>

[Qemu-devel] [PATCH qemu v4 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView

As we are going to share FlatView's between AddressSpace's, and AddressSpaceDispatch is a structure to perform quick lookup in FlatView, this moves ASD to FlatView. After previosly open coded ASD rendering, we can also remove as->next_dispatch as the new FlatView pointer is stored on a stack and

Re: [Qemu-devel] [Qemu-block] [PATCH 15/18] block/mirror: Add active mirroring

On Tue, Sep 19, 2017 at 10:57:50AM +0100, Daniel P. Berrange wrote: > On Tue, Sep 19, 2017 at 10:44:16AM +0100, Stefan Hajnoczi wrote: > > On Mon, Sep 18, 2017 at 06:26:51PM +0200, Max Reitz wrote: > > > On 2017-09-18 12:06, Stefan Hajnoczi wrote: > > > > On Sat, Sep 16, 2017 at 03:58:01PM +0200,

[Qemu-devel] [PATCH qemu v4 15/18] memory: Share special empty FlatView

This shares an cached empty FlatView among address spaces. The empty FV is used every time when a root MR renders into a FV without memory sections which happens when MR or its children are not enabled or zero-sized. The empty_view is not NULL to keep the rest of memory API intact; it also has a

Re: [Qemu-devel] [PATCH] qemu-iotests/195: Change multiple nodes in one run

On 09/20/2017 07:15 AM, Kevin Wolf wrote: > This additional check for change-backing-file makes sure that actions on > one part of the graph don't interfere with later actions elsewhere. > > Suggested-by: Eric Blake > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

On 09/20/2017 10:11 AM, Cornelia Huck wrote: > On Tue, 19 Sep 2017 20:27:45 +0200 > Halil Pasic wrote: > >> Let's add indirect data addressing support for our virtual channel >> subsystem. This implementation does not bother with any kind of >> prefetching. We simply

Re: [Qemu-devel] block ais migration for machines <= 2.9

* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > Something like the following seems to do the tricks. > Needs proper patch description, review, full test with different kernel > versions. Without knowing anything about 'ais' - will this break migration from 2.10 -> 2.10+this fix?

Re: [Qemu-devel] [PATCH qemu v4 09/18] memory: Store physical root MR in FlatView

On 20/09/2017 13:46, Alexey Kardashevskiy wrote: > Address spaces get to keep a root MR (alias or not) but FlatView stores > the actual MR as this is going to be used later on to decide whether to > share a particular FlatView or not. > > Signed-off-by: Alexey Kardashevskiy > ---

Re: [Qemu-devel] qemu-arm SIGSEGV for self-modifying code

Thanks for your reply, Peter. [I fixed my typo in the Subject: field of the header.] [Moving here from https://bugzilla.redhat.com/show_bug.cgi?id=1493304 ] qemu-arm from qemu-user-2.10.0-1.fc27.x86_64 (thus emulating 32-bit ARM on x86_64) generates SIGSEGV when code modifies a

Re: [Qemu-devel] [PATCH v3 0/3] nbd client refactoring and fixing

On 09/20/2017 07:45 AM, Vladimir Sementsov-Ogievskiy wrote: > v3: dropped all controversial things. I'll try to implement minimal > structured reply and block status over this small residue. > > Vladimir Sementsov-Ogievskiy (3): > block/nbd-client: refactor nbd_co_receive_reply >

Re: [Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

On Wed, Sep 20, 2017 at 1:39 AM, Laurent Vivier wrote: > > Why did you remove "optname = SO_LINGER" and "if (optlen != > sizeof(struct target_linger))"? > the optname assignment is not really needed, since it is only used for the setsockopt call and that call is clearer using

Re: [Qemu-devel] [PATCH 16/19] target/arm: Handle banking in negative-execution-priority check in cpu_mmu_index()

On 09/12/2017 01:14 PM, Peter Maydell wrote: > Now that we have a banked FAULTMASK register and banked exceptions, > we can implement the correct check in cpu_mmu_index() for whether > the MPU_CTRL.HFNMIENA bit's effect should apply. This bit causes > handlers which have requested a negative

Re: [Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions

On 19.09.2017 23:36, John Snow wrote: > Following commit aef77960, remove now-unused definitions from > cpu-models.h. > > Signed-off-by: John Snow > --- > target/ppc/cpu-models.h | 32 > 1 file changed, 32 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

Le 20/09/2017 à 19:29, Carlo Arenas a écrit : > On Wed, Sep 20, 2017 at 1:39 AM, Laurent Vivier > wrote: > > Why did you remove "optname = SO_LINGER" and "if (optlen != > sizeof(struct target_linger))"? > > > the optname assignment is not

Re: [Qemu-devel] [PATCH qemu v4 12/18] memory: Share FlatView's and dispatch trees between address spaces

On 20/09/2017 13:46, Alexey Kardashevskiy wrote: > +QTAILQ_FOREACH(as, _spaces, address_spaces_link) { > +MemoryRegion *physmr = memory_region_get_flatview_root(as->root); > +FlatView *new_view = g_hash_table_lookup(flat_views, physmr); > + > +if (new_view) { > +

Re: [Qemu-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

Ping? On Wed, 6 Sep 2017, Anthony PERARD wrote: > On Wed, Aug 23, 2017 at 02:25:05PM +0100, Ross Lagerwall wrote: > > When the guest writes to the RTC, Xen emulates it and broadcasts a > > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP event to all QMP monitors when > > this happens rather than

Re: [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView directly

On 20/09/2017 13:46, Alexey Kardashevskiy wrote: > +static void flatview_update_topology_single(AddressSpace *as) address_space_update_topology? Thanks, Paolo > +{ > +MemoryRegion *physmr = memory_region_get_flatview_root(as->root); > +FlatView *new_view; > + > +flatviews_init(); >

Re: [Qemu-devel] [PATCH 17/19] nvic: Make ICSR banked for v8M

On 09/12/2017 01:14 PM, Peter Maydell wrote: > The ICSR NVIC register is banked for v8M. This doesn't > require any new state, but it does mean that some bits > are controlled by BFHNFNMINS and some bits must work > with the correct banked exception. There is also a new > in v8M PENDNMICLR bit. >

Re: [Qemu-devel] [PULL 00/11] Ide patches

On 09/20/2017 01:02 PM, Mark Cave-Ayland wrote: > On 18/09/17 19:14, Peter Maydell wrote: > >> On 18 September 2017 at 19:00, Peter Maydell >> wrote: >>> On 18 September 2017 at 18:55, John Snow wrote: On 09/16/2017 10:34 AM, Peter Maydell

Re: [Qemu-devel] qemu-arm SIGSEGV for self-modifying code

On 20 September 2017 at 18:05, John Reiser wrote: > Yes, the SEGV occurs on the store, "long" before the re-written > instruction ever is executed OK, I've identified the immediate cause for this SEGV. (1) when the guest initially mmap()s at 0xf700 and above we pass

Re: [Qemu-devel] [PULL 00/12] Machine/CPU/NUMA queue, 2017-09-19

On 19 September 2017 at 21:18, Eduardo Habkost wrote: > The following changes since commit a9158a5cba955b79d580a252cc58ff44d154e370: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20170918-pull-request' into staging (2017-09-18 > 12:40:54 +0100) > > are

Re: [Qemu-devel] [PATCH 18/19] nvic: Make SHCSR banked for v8M

On 09/12/2017 01:14 PM, Peter Maydell wrote: > Handle banking of SHCSR: some register bits are banked between > Secure and Non-Secure, and some are only accessible to Secure. > > Signed-off-by: Peter Maydell > --- > hw/intc/armv7m_nvic.c | 221 >

Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint

On 20/09/2017 13:46, Alexey Kardashevskiy wrote: > This extends memory_region_transaction_commit() to receive a MR as > if it is a root MR or its topmost parent is, then we can only rebuild > its FlatView and update it for address spaces sharing it. > > The optimization gets disabled though if

[Qemu-devel] [PATCH 0/2] 3270 improvements

Jason found some problems with 3270 which he traced down to insufficient output buffer size. I've looked into the underlying issue (and the relevant code) and I saw strange things. Among others an unreasonable assert requiring the payload of a ccw being less than some more or less arbitrary limit

[Qemu-devel] [PATCH 2/2] s390x/3270: handle writes of arbitrary length

The problem is, that the current implementation places unrealistic and arbitrary constraints on the length of writes to the device (that is the outbound requests), by asserting ccw.count being such that that even the worst case escaped payload will fit an more or less arbitrary sized buffer.

[Qemu-devel] [PATCH] virtio/vhost: reset dev->log after syncing

vhost_log_put() is called to decomission the dirty log between qemu and a vhost device when stopping the device. Such a call can happen from migration_completion(). Present code sets dev->log_size to zero too early in vhost_log_put(), causing the sync check to always return false. As a

Re: [Qemu-devel] [PATCH qemu v4 15/18] memory: Share special empty FlatView

On 20/09/2017 13:46, Alexey Kardashevskiy wrote: > This shares an cached empty FlatView among address spaces. The empty > FV is used every time when a root MR renders into a FV without memory > sections which happens when MR or its children are not enabled or > zero-sized. The empty_view is not

Re: [Qemu-devel] [PATCH 19/19] nvic: Support banked exceptions in acknowledge and complete

On 09/12/2017 01:14 PM, Peter Maydell wrote: > Update armv7m_nvic_acknowledge_irq() and armv7m_nvic_complete_irq() > to handle banked exceptions: > * acknowledge needs to use the correct vector, which may be >in sec_vectors[] > * acknowledge needs to return to its caller whether the >

Re: [Qemu-devel] [PULL 00/11] Ide patches

On 18/09/17 19:14, Peter Maydell wrote: > On 18 September 2017 at 19:00, Peter Maydell wrote: >> On 18 September 2017 at 18:55, John Snow wrote: >>> On 09/16/2017 10:34 AM, Peter Maydell wrote: Hi; I'm afraid this doesn't build with clang:

Re: [Qemu-devel] [PATCH 15/19] nvic: Handle v8M changes in nvic_exec_prio()

On 09/12/2017 01:14 PM, Peter Maydell wrote: > Update nvic_exec_prio() to support the v8M changes: > * BASEPRI, FAULTMASK and PRIMASK are all banked > * AIRCR.PRIS can affect NS priorities > * AIRCR.BFHFNMINS affects FAULTMASK behaviour > > These changes mean that it's no longer possible to >

[Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream

Let us convert the 3270 code so it uses the recently introduced CcwDataStream abstraction instead of blindly assuming direct data access. This patch does not change behavior beyond introducing IDA support: for direct data access CCWs everything stays as-is. (If there are bugs, they are also

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_co_drain_end callback

On Wed, Sep 20, 2017 at 03:26:32PM +0100, Stefan Hajnoczi wrote: On Wed, Sep 20, 2017 at 01:23:09PM +0300, Manos Pitsidianakis wrote: @@ -188,7 +194,7 @@ static bool bdrv_drain_recurse(BlockDriverState *bs) waited = BDRV_POLL_WHILE(bs, atomic_read(>in_flight) > 0); /* Ensure any

[Qemu-devel] [Bug 1715700] Re: Windows 7 guest won't boot on qemu 2.10 (works on 2.9)

edk2 commit range: b68c793144e8..947f3737abf6. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715700 Title: Windows 7 guest won't boot on

Re: [Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions

On 19.09.2017 23:36, John Snow wrote: > Remove *all* unused CPU definitions as indicated by compile-time > `#if 0` constructs. > > Signed-off-by: John Snow > --- > target/ppc/cpu-models.h | 223 > > 1 file changed, 223

Re: [Qemu-devel] [PULL 00/11] Ide patches

On 20/09/17 18:55, John Snow wrote: > Guh. From which distro does your GCC 4.7 hail? > > Regardless, I suppose I will revert to Eric's workaround, though I like > the way it reads an awful lot less. Thanks John - it's just a standard Debian Wheezy installation on amd64. ATB, Mark.

Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm: Remove out of date ARM ARM section references in A64 decoder

Alistair Francis writes: > On Fri, Sep 15, 2017 at 8:08 AM, Peter Maydell > wrote: >> In the A64 decoder, we have a lot of references to section numbers >> from version A.a of the v8A ARM ARM (DDI0487). This version of the >> document is now

Re: [Qemu-devel] need to resurrect no-lock option?

On Wed, 09/20 11:26, Christian Ehrhardt wrote: > Hi, > this might have been discussed in the wake of the lock changes that took > place in 2.10 but I can't find anything clear enough to follow in the > current case. > There was an old submission [1] by Fam to make it possible to no-lock > qemu-img

[Qemu-devel] [PATCH v3 1/3] block/nbd-client: refactor nbd_co_receive_reply

"NBDReply *reply" parameter of nbd_co_receive_reply is used only to pass return value for nbd_co_request (reply.error). Remove it and use function return value instead. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake ---

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote: This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by:

Re: [Qemu-devel] RFC: Reducing the size of entries in the qcow2 L2 cache

On Wed 20 Sep 2017 09:06:20 AM CEST, Kevin Wolf wrote: >> |---+--+-+---+--| >> | Disk size | Cluster size | L2 cache| Standard QEMU | Patched QEMU | >> |---+--+-+---+--| >> | 16 GB

Re: [Qemu-devel] [PATCH 1/2] block/block-backend.c: add blk_check_byte_request call to blk_pread/blk_pwrite

Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben: > blk_check_byte_request() is called from the blk_co_pwritev/blk_co_preadv to > check if the request offset and request bytes parameters are valid for the > given Blockbackend. Let's do that in blk_pread/blk_pwrite too. > >

Re: [Qemu-devel] [PATCH v3 03/20] file-posix: Switch to .bdrv_co_block_status()

On 09/20/2017 04:57 AM, Fam Zheng wrote: > On Thu, 09/14 09:40, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Update the file protocol driver accordingly. In mapping >> mode, note that the entire file is reported as allocated, so we can >>

  1   2   3   4   >