Re: [Qemu-devel] [PATCH] target-i386: adds PV_TLB_FLUSH CPUID feature bit

2017-11-10 15:45 GMT+08:00 Wanpeng Li : > From: Wanpeng Li > > Adds PV_TLB_FLUSH CPUID feature bit. > > Cc: Paolo Bonzini > Cc: Radim Krčmář > Cc: Richard Henderson > Cc: Eduardo Habkost

[Qemu-devel] [PATCH] target-i386: adds PV_TLB_FLUSH CPUID feature bit

From: Wanpeng Li Adds PV_TLB_FLUSH CPUID feature bit. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Wanpeng Li ---

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later. Type: series Message-id: 20171108225340.10194-1-lep...@google.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PULL 0/1] slirp update

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/1] slirp update Type: series Message-id: 20171109180142.13923-1-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface Type: series Message-id: alpine.DEB.2.10.1711061412330.30448@sstabellini-ThinkPad-X260 === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PULL, 08/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

On Wed, Nov 08, 2017 at 09:52:12AM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 19:42, Laurent Vivier wrote: > > On 05/07/2016 07:31, David Gibson wrote: > >> From: Alexey Kardashevskiy > >> > >> This adds support for Dynamic DMA Windows (DDW) option defined by > >> the SPAPR

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

On 2017年11月08日 19:22, Jason Wang wrote: On 2017年11月08日 18:46, Paolo Bonzini wrote: On 08/11/2017 09:21, Jason Wang wrote: On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote: Am 08.11.2017 um 08:54 schrieb Jason Wang: On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote: Hi

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

On Thu, 11/09 17:26, Alberto Garcia wrote: > On Wed 08 Nov 2017 03:45:38 PM CET, Alberto Garcia wrote: > > > I'm thinking that perhaps we should add the pause point directly to > > block_job_defer_to_main_loop(), to prevent any block job from running > > the exit function when it's paused. > > I

Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS

On Thu, 11/09 21:43, Max Reitz wrote: > Draining a BDS may lead to graph modifications, which in turn may result > in it and other BDS being stripped of their current references. If > bdrv_drain_all_begin() and bdrv_drain_all_end() do not keep strong > references themselves, the BDS they are

Re: [Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

On Thu, 11/09 20:31, Max Reitz wrote: > On 2017-11-09 16:30, Fam Zheng wrote: > > On Thu, 11/09 16:14, Max Reitz wrote: > >> On 2017-11-09 05:21, Fam Zheng wrote: > >>> On Thu, 11/09 01:48, Max Reitz wrote: > Hi, > > More exciting news from the bdrv_drain() front! > > I've

Re: [Qemu-devel] [PATCH v2 1/1] Makefile: Capstone: Add support for cross compile ranlib

On Thu, Nov 9, 2017 at 3:09 AM, Peter Maydell wrote: > On 8 November 2017 at 15:10, Alistair Francis > wrote: >> When cross compiling QEMU for Windows we need to specify the cross >> version of ranlib to avoid build errors when building

Re: [Qemu-devel] [PATCH v8 01/14] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()

On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > Enabling bitmap successor is necessary to enable successors of bitmaps > being migrated before target vm start. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/dirty-bitmap.h | 1 + >

[Qemu-devel] [PATCH] thread-posix: fix qemu_rec_mutex_trylock macro

We never noticed because it has no users. Signed-off-by: Emilio G. Cota --- include/qemu/thread-posix.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h index f4296d3..f3f47e4 100644 ---

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2

On 11/09/2017 08:55 PM, Peter Maydell wrote: > On 9 November 2017 at 21:46, Philippe Mathieu-Daudé wrote: >> Hi Subbaraya, >> >> On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: >>> add voluntarily myself as maintainer for Smartfusion2 >> >> You need to share your GnuPG key

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2

On 9 November 2017 at 21:46, Philippe Mathieu-Daudé wrote: > Hi Subbaraya, > > On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: >> add voluntarily myself as maintainer for Smartfusion2 > > You need to share your GnuPG key signed, I couldn't find it using >

Re: [Qemu-devel] [PATCH for-2.11] iotests: Use new-style NBD connections

On 2017-11-09 23:12, Eric Blake wrote: > Old-style NBD is deprecated upstream (it is documented, but no > longer implemented in the reference implementation), and it is > severely limited (it cannot support structured replies, which > means it cannot support efficient handling of zeroes), when >

[Qemu-devel] [Bug 1731347] [NEW] VFIO Passthrough of SAS2008-based HBA card fails on E3-1225v3 due to failed DMA mapping (-14)

Public bug reported: There is a bug preventing multiple people with my combination of hardware from using PCI passthrough. I am not actually sure whether the bug is in kernel/kvm, vfio or qemu, however, as qemu is the highest- level of these, I am reporting the bug here as you will likely know

Re: [Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky

On 2017-11-09 21:30, Max Reitz wrote: > There are a couple of tests that fail (on my machine) from time to > time (and by that I mean that recently I've rarely ever had a test run > with both 083 and 136 working on first try). > This series should fix most (at least the issues I am aware of).

[Qemu-devel] [PATCH for-2.11] iotests: Use new-style NBD connections

Old-style NBD is deprecated upstream (it is documented, but no longer implemented in the reference implementation), and it is severely limited (it cannot support structured replies, which means it cannot support efficient handling of zeroes), when compared to new-style NBD. We are better off

[Qemu-devel] [PATCH for 2.11 v2 2/2] xlnx-zcu102: Add an info message deprecating the EP108

The EP108 was an early access development board that is no longer used. Add an info message to convert any users to the ZCU102 instead. On QEMU they are both identical. This patch also updated the qemu-doc.texi file to indicate that the EP108 has been deprecated. Signed-off-by: Alistair Francis

[Qemu-devel] [PATCH for 2.11 v2 0/2] Xilinx ZCU102 fixes for 2.11

These are two small fixes for 2.11. V2: - Update qemu-doc.texi Alistair Francis (2): xlnx-zynqmp: Properly support the smp command line option xlnx-zcu102: Add an info message deprecating the EP108 hw/arm/xlnx-zcu102.c | 6 +- hw/arm/xlnx-zynqmp.c | 26 --

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2

Hi Subbaraya, On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: > add voluntarily myself as maintainer for Smartfusion2 You need to share your GnuPG key signed, I couldn't find it using http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep from

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

On 11/09/2017 09:16 AM, Vladimir Sementsov-Ogievskiy wrote: > What was the reason to abandon non-root nodes? Eric had it correct: we were never convinced it work would properly, so we went with a smaller set.

Re: [Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS

On 11/09/2017 02:43 PM, Max Reitz wrote: > Draining a BDS may lead to graph modifications, which in turn may result > in it and other BDS being stripped of their current references. If > bdrv_drain_all_begin() and bdrv_drain_all_end() do not keep strong > references themselves, the BDS they are

Re: [Qemu-devel] [PATCH v2 4/5] iotests: Make 083 less flaky

On 2017-11-09 21:58, Eric Blake wrote: > On 11/09/2017 02:30 PM, Max Reitz wrote: >> 083 has (at least) two issues: >> >> 1. By launching the nbd-fault-injector in background, it may not be >>scheduled until the first grep on its output file is executed. >>However, until then, that file

Re: [Qemu-devel] [PATCH v2 4/5] iotests: Make 083 less flaky

On 11/09/2017 02:30 PM, Max Reitz wrote: > 083 has (at least) two issues: > > 1. By launching the nbd-fault-injector in background, it may not be >scheduled until the first grep on its output file is executed. >However, until then, that file may not have been created yet -- so it >

[Qemu-devel] [PATCH for-2.11] block: Keep strong reference when draining all BDS

Draining a BDS may lead to graph modifications, which in turn may result in it and other BDS being stripped of their current references. If bdrv_drain_all_begin() and bdrv_drain_all_end() do not keep strong references themselves, the BDS they are trying to drain (or undrain) may disappear right

[Qemu-devel] [PATCH v2 5/5] iotests: Make 136 less flaky

136 executes some AIO requests without a final aio_flush; then it advances the virtual clock and thus expects the last access time of the device to be less than the current time when queried (i.e. idle_time_ns to be greater than 0). However, without the aio_flush, some requests may be settled

[Qemu-devel] [PATCH v2 4/5] iotests: Make 083 less flaky

083 has (at least) two issues: 1. By launching the nbd-fault-injector in background, it may not be scheduled until the first grep on its output file is executed. However, until then, that file may not have been created yet -- so it either does not exist yet (thus making the grep emit an

[Qemu-devel] [PATCH v2 3/5] iotests: Make 055 less flaky

First of all, test 055 does a valiant job of invoking pause_drive() sometimes, but that is worth nothing without blkdebug. So the first thing to do is to sprinkle a couple of "blkdebug::" in there -- with the exception of the transaction tests, because the blkdebug break points make the

[Qemu-devel] [PATCH v2 2/5] iotests: Add missing 'blkdebug::' in 040

040 tries to invoke pause_drive() on a drive that does not use blkdebug. Good idea, but let's use blkdebug to make it actually work. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH v2 1/5] iotests: Make 030 less flaky

This patch fixes two race conditions in 030: 1. The first is in TestENOSPC.test_enospc(). After resuming the job, querying it to confirm it is no longer paused may fail because in the meantime it might have completed already. The same was fixed in TestEIO.test_ignore() already (in

[Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky

There are a couple of tests that fail (on my machine) from time to time (and by that I mean that recently I've rarely ever had a test run with both 083 and 136 working on first try). This series should fix most (at least the issues I am aware of). Notes: - 083 might have another issue, but if so

Re: [Qemu-devel] [PATCH 4/5] iotests: Make 083 less flaky

On 2017-11-09 15:11, Eric Blake wrote: > On 11/08/2017 07:38 PM, Max Reitz wrote: >> 083 has (at least) two issues: > > I think I hit one of them intermittently yesterday; thanks for > diagnosing these (and like you say, there may be more lurking, but we'll > whack them separately if we can

Re: [Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

On Thu, Nov 09, 2017 at 05:58:03PM +1100, David Gibson wrote: > On Tue, Nov 07, 2017 at 04:04:04PM +0100, Cornelia Huck wrote: > > On Mon, 6 Nov 2017 16:02:16 -0200 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 31, 2017 at 03:01:14PM +0100, Igor Mammedov wrote: > > > > On

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2

On Thu, Nov 9, 2017 at 4:02 AM, Subbaraya Sundeep wrote: > add voluntarily myself as maintainer for Smartfusion2 This should be: Voluntarily add myself as maintainer for Smartfusion2. > > Signed-off-by: Subbaraya Sundeep With the commit message

Re: [Qemu-devel] [PATCH] smbios: support setting OEM strings table

On Thu, Nov 09, 2017 at 02:40:05PM +, Daniel P. Berrange wrote: > Ping, any thoughts on this ? (not expecting it in this 2.11 release of course) I queued this up. > On Sat, Oct 28, 2017 at 09:51:36PM +0100, Daniel P. Berrange wrote: > > The cloud-init program currently allows fetching of its

Re: [Qemu-devel] [PATCH V3] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

On Thu, Nov 09, 2017 at 12:02:10PM +0100, Laszlo Ersek wrote: [...] > (3) An idea for the property defaults: you remove > DEFAULT_PCI_HOLE64_SIZE, which is cool. How about introducing (in the > proper header files) > > #define DEFAULT_I440FX_PCI_HOLE64_SIZE (1ULL << 31) > #define

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.12 v2 00/12] spapr: introduce an IRQ allocator at the machine level

David, On 11/09/2017 10:14 AM, Cédric Le Goater wrote: > Hello, > > Currently, the ICSState 'ics' object of the sPAPR machine acts as the > global interrupt source handler and also as the IRQ number allocator > for the machine. Some IRQ numbers are allocated very early in the > machine

Re: [Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

On 2017-11-09 16:30, Fam Zheng wrote: > On Thu, 11/09 16:14, Max Reitz wrote: >> On 2017-11-09 05:21, Fam Zheng wrote: >>> On Thu, 11/09 01:48, Max Reitz wrote: Hi, More exciting news from the bdrv_drain() front! I've noticed in the past that iotest 194 sometimes hangs. I

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

On Tue, 7 Nov 2017 18:24:38 +0100 Pierre Morel wrote: > Let's move the memory region write from pcistg into a dedicated > function. > This allows us to prepare a later patch searching for subregions > inside of the memory region. OK, so here is the memory region

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

On Thu, 9 Nov 2017 15:55:46 -0300 Philippe Mathieu-Daudé wrote: > On 11/09/2017 01:38 PM, Cornelia Huck wrote: > > On Tue, 7 Nov 2017 18:24:33 +0100 > > Pierre Morel wrote: > > > >> There are two places where the same endianness conversion > >> is

[Qemu-devel] KVM Forum BoF session notes: QEMU configuration/command-line/QMP

Hi, Below are the notes I collected during the BoF session about QEMU configuration, command-line and QMP. Sorry for taking so long to send them. All inaccuracies and mistakes below are my own fault. (I learned the hard way that trying to take notes while participating in the discussion at the

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

On 11/09/2017 01:38 PM, Cornelia Huck wrote: > On Tue, 7 Nov 2017 18:24:33 +0100 > Pierre Morel wrote: > >> There are two places where the same endianness conversion >> is done. >> Let's factor this out into a static function. >> >> Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Tao Wu(吴涛@Eng), on jeu. 09 nov. 2017 10:48:27 -0800, wrote: > Thanks. Actually this is a follow up with my previous effort to fix this bug. > I was busy on something else and then got lost in that old thread. Now I just > checked some my local patch > to see if they've merged to upstream and then

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Thanks. Actually this is a follow up with my previous effort to fix this bug. I was busy on something else and then got lost in that old thread. Now I just checked some my local patch to see if they've merged to upstream and then found it out. This is old thread about this:

Re: [Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

Thanks. Sent out a new version add comments to say that we rely on pixman create_bits to fail. On Thu, Nov 9, 2017 at 2:34 AM, Marc-André Lureau wrote: > Hi > > - Original Message - >> The old code treats bits as bytes when calculating host memory usage. >>

Re: [Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

On Thu, Nov 9, 2017 at 7:17 PM, Tao Wu via Qemu-devel wrote: > The old code treats bits as bytes when calculating host memory usage. > Change it to be consistent with allocation logic in pixman library. > > Signed-off-by: Tao Wu Reviewed-by: Marc-André

[Qemu-devel] [PATCH] virtio-gpu: fix bug in host memory calculation.

The old code treats bits as bytes when calculating host memory usage. Change it to be consistent with allocation logic in pixman library. Signed-off-by: Tao Wu --- hw/display/virtio-gpu.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 0/1] slirp update

warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at:

[Qemu-devel] [PULL 1/1] slirp: don't zero the whole ti_i when m == NULL

From: Tao Wu 98c63057d2144fb81681580cd84c13c93794c96e ('slirp: Factorizing tcpiphdr structure with an union') introduced a memset call to clear possibly-undefined fields in ti. This however overwrites src/dst/pr which are used below. So let us clear only the unused fields.

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Hello, Tao Wu, on mer. 08 nov. 2017 14:53:40 -0800, wrote: > The current code looks buggy, we zero ti_i while we access > ti_dst/ti_src later. Mmm, indeed, looking again at how it was introduced, it was too much. Samuel

Re: [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

Am 09.11.2017 um 17:33 hat Eric Blake geschrieben: > On 11/09/2017 08:16 AM, Vladimir Sementsov-Ogievskiy wrote: > > This is needed to implement image-fleecing scheme, when we create > > a temporary node, mark our active node to be backing for the temp, > > and start backup(sync=none) from active

[Qemu-devel] [PATCH V4] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is too small to hotplug PCI devices with large BARs. Fix it by reserving 2G for I4400FX chipset in order to comply

Re: [Qemu-devel] [Qemu-block] [PATCH v2] throttle: fix a qemu crash problem when calling blk_delete

On Tue, Oct 24, 2017 at 11:33:51AM +0800, sochin jiang wrote: > commit 7ca7f0 moves the throttling related part of the BDS life cycle > management to BlockBackend, adds call to > throttle_timers_detach_aio_context in blk_remove_bs. commit 1606e > remove a block device from its throttle group in

[Qemu-devel] [PULL 8/8] nbd/server: Fix structured read of length 0

The NBD spec was recently clarified to state that a read of length 0 should not be attempted by a compliant client; but that a server must still handle it correctly in an unspecified manner (that is, either a successful no-op or an error reply, but not a crash) [1]. However, it also implies that

[Qemu-devel] [PULL 5/8] nbd: Fix struct name for structured reads

A closer read of the NBD spec shows that a structured reply chunk for a hole is not quite identical to the prefix of a data chunk, because the hole has to also send a 32-bit size field. Although we do not yet send holes, we should fix the misleading information in our header and make it easier

[Qemu-devel] [PULL 6/8] nbd-client: Short-circuit 0-length operations

The NBD spec was recently clarified to state that clients should not send 0-length requests to the server, as the server behavior is undefined [1]. We know that qemu-nbd's behavior is a successful no-op (once it has filtered for read-only exports), but other NBD implementations might return an

[Qemu-devel] [PULL 4/8] nbd/client: Nicer trace of structured reply

It's useful to know which structured reply chunk is being processed. Missed in commit d2febedb. Signed-off-by: Eric Blake Message-Id: <20171108215703.9295-4-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 4 +++-

[Qemu-devel] [PULL 1/8] nbd/server: fix nbd_negotiate_handle_info

From: Vladimir Sementsov-Ogievskiy namelen should be here, length is unrelated, and always 0 at this point. Broken in introduction in commit f37708f6, but mostly harmless (replying with '' as the name does not violate protocol, and does not confuse qemu as the nbd

[Qemu-devel] [PULL 7/8] nbd-client: Stricter enforcing of structured reply spec

Ensure that the server is not sending unexpected chunk lengths for either the NONE or the OFFSET_DATA chunk, nor unexpected hole length for OFFSET_HOLE. This will flag any server as broken that responds to a zero-length read with an OFFSET_DATA (what our server currently does, but that's about to

[Qemu-devel] [PULL 3/8] nbd-client: Refuse read-only client with BDRV_O_RDWR

The NBD spec says that clients should not try to write/trim to an export advertised as read-only by the server. But we failed to check that, and would allow the block layer to use NBD with BDRV_O_RDWR even when the server is read-only, which meant we were depending on the server sending a proper

[Qemu-devel] [PULL 0/8] NBD patches for 2.11-rc1

The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-11-09 for you to fetch changes up to

[Qemu-devel] [PULL 2/8] nbd-client: Fix error message typos

Provide missing spaces that are required when using string concatenation to break error messages across source lines. Introduced in commit f140e300. Signed-off-by: Eric Blake Message-Id: <20171108215703.9295-2-ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [Qemu-block] [PATCH] block: all I/O should be completed before removing throttle timers.

On Sat, Oct 21, 2017 at 01:34:00PM +0800, Zhengui Li wrote: > From: Zhengui > > In blk_remove_bs, all I/O should be completed before removing throttle > timers. If there has inflight I/O, removing throttle timers here will > cause the inflight I/O never return. > This patch

Re: [Qemu-devel] [PATCH 3/7] s390x/pci: rework PCI LOAD

On Tue, 7 Nov 2017 18:24:35 +0100 Pierre Morel wrote: > Enhance the fault detection, correction of the fault reporting. Basically the same comments as for the previous patch (but looks good in general). > > Signed-off-by: Pierre Morel >

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

On Tue, 7 Nov 2017 18:24:34 +0100 Pierre Morel wrote: > Enhance the fault detection, correction of the fault reporting. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > --- >

Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM

Hi Marcel, Cc'ing Paul and Yongbok Since I'm not sure their Boston board could also use it. On 11/09/2017 12:46 PM, Marcel Apfelbaum wrote: > The PCIE-PCI bridge is specific to "pure" PCIe systems > (on QEMU we have X86 and ARM), it does not make sense to > have it in other archs. > >

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: > There are two places where the same endianness conversion > is done. > Let's factor this out into a static function. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao

Re: [Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM

On 09.11.2017 16:46, Marcel Apfelbaum wrote: > The PCIE-PCI bridge is specific to "pure" PCIe systems > (on QEMU we have X86 and ARM), it does not make sense to > have it in other archs. > > Reported-by: Thomas Huth > Signed-off-by: Marcel Apfelbaum > --- >

Re: [Qemu-devel] [PATCH] blockdev-backup: enable non-root nodes for backup

On 11/09/2017 08:16 AM, Vladimir Sementsov-Ogievskiy wrote: > This is needed to implement image-fleecing scheme, when we create > a temporary node, mark our active node to be backing for the temp, > and start backup(sync=none) from active node to the temp node. > Temp node then represents a kind

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

On Wed 08 Nov 2017 03:45:38 PM CET, Alberto Garcia wrote: > I'm thinking that perhaps we should add the pause point directly to > block_job_defer_to_main_loop(), to prevent any block job from running > the exit function when it's paused. I was trying this and unfortunately this breaks the mirror

Re: [Qemu-devel] [Qemu-block] Drainage in bdrv_replace_child_noperm()

Am 08.11.2017 um 21:16 hat Max Reitz geschrieben: > On 2017-11-07 15:22, Kevin Wolf wrote: > > I think the issue is much simpler, even though it still has two parts. > > It's the old story of bdrv_drain mixing two separate concepts: > > > > 1. Wait synchronously for the completion of all my

Re: [Qemu-devel] [PATCH v4 0/4] Don't write headers if BDS is INACTIVE

On 11/07/2017 04:10 PM, Jeff Cody wrote: > Changes from v3->v4: > > Patch 3: Add migrate_del_blocker and error_free (Thanks Stefan) > > > git-backport-diff -r qemu/master.. -u ba11b69 > > 001/4:[] [--] 'block/vhdx.c: Don't blindly update the header' > 002/4:[] [--] 'block/parallels: Do not

Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] iotests: Make some tests less flaky

On Thu, Nov 09, 2017 at 02:37:59AM +0100, Max Reitz wrote: > There are a couple of tests that fail (on my machine) from time to > time (and by that I mean that recently I've rarely ever had a test run > with both 083 and 136 working on first try). > This series should fix most (at least the issues

Re: [Qemu-devel] [PATCH] AMD Processor Topology Information

Hi Philippe, Most of the code for 'case 0x801E:' is a copy of 'case 4:' of the same procedure in both cpu.c and kvm.c Values were changes for AMD Zen architecture. The only new code is 'case 0x801D:' which defines core topology. Hope this info helps wit review. On 2017-11-08 13:44,

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

On Thu, Nov 09, 2017 at 02:54:35PM +0100, Markus Armbruster wrote: > Max Reitz writes: > > > On 2017-11-02 13:02, Daniel P. Berrange wrote: > > [...] > >> One alternative approach to doing this would be to suggest that we should > >> instead just spawn qemu-system-x86_64 with

Re: [Qemu-devel] [Qemu-block] [PATCH] coroutine: simplify co_aio_sleep_ns() prototype

On Thu, Nov 09, 2017 at 10:26:52AM +, Stefan Hajnoczi wrote: > The AioContext pointer argument to co_aio_sleep_ns() is only used for > the sleep timer. It does not affect where the caller coroutine is > resumed. > > Due to changes to coroutine and AIO APIs it is now possible to drop the >

Re: [Qemu-devel] [PATCH 0/2] add qmp nbd-server-remove

On 11/09/2017 09:40 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command to remove nbd export, pair to nbd-server-add. > The whole thing and description are in patch 02. > > Vladimir Sementsov-Ogievskiy (2): > nbd/server: add additional assert to nbd_export_put > qmp: add nbd-server-remove >

Re: [Qemu-devel] [PATCH 2/2] qmp: add nbd-server-remove

On 11/09/2017 09:40 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should

Re: [Qemu-devel] [PATCH] Add missing parameters to mon option documentation

Hi On Thu, Nov 9, 2017 at 1:19 PM, Vicente Jimenez Aguilar wrote: > Documentation missed 'mon' option's 'pretty' and 'default' parameters > > Signed-off-by: Vicente Jimenez Aguilar > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH V5] hw/pcie-pci-bridge: restrict to X86 and ARM

The PCIE-PCI bridge is specific to "pure" PCIe systems (on QEMU we have X86 and ARM), it does not make sense to have it in other archs. Reported-by: Thomas Huth Signed-off-by: Marcel Apfelbaum --- V4 -> V5 - Since all other tries failed, conditioned the

[Qemu-devel] [PATCH 1/2] nbd/server: add additional assert to nbd_export_put

This place is not obvious, nbd_export_close may theoretically reduce refcount to 0. It may happen if someone calls nbd_export_put on named export not through nbd_export_set_name when refcount is 1. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 1 + 1

[Qemu-devel] [PATCH 0/2] add qmp nbd-server-remove

Add command to remove nbd export, pair to nbd-server-add. The whole thing and description are in patch 02. Vladimir Sementsov-Ogievskiy (2): nbd/server: add additional assert to nbd_export_put qmp: add nbd-server-remove qapi/block.json | 20 blockdev-nbd.c | 27

[Qemu-devel] [PATCH 2/2] qmp: add nbd-server-remove

Add command for export removing. It is needed for cases when we don't want to keep export after the operation on it was completed. The other example is temporary node, created with blockdev-add. If we want to delete it we should firstly remove corresponding NBD export. Signed-off-by: Vladimir

[Qemu-devel] [PULL for-2.11 2/2] target/s390x: Finish implementing RISBGN

From: Richard Henderson We added the entry to insn-data.def, but failed to update op_risbg to match. No need to special-case the imask inversion, since that is already ~0 for RISBG (and now RISBGN). Fixes: 375ee58bedcda359011fe7fa99e0647f66f9ffa0 Fixes:

[Qemu-devel] [PULL for-2.11 0/2] s390x changes for 2.11-rc1

The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20171109 for you to fetch changes up

[Qemu-devel] [PULL for-2.11 1/2] s390x/pci: let pci devices start in configured mode

From: Christian Borntraeger Currently, to enable a pci device in the guest, the user has to issue echo 1 > /sys/bus/pci/slots//power. This is not what people expect. On an LPAR, the user can put a PCI device in configured or deconfigured state via IOCDS. The

Re: [Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

On Thu, 11/09 16:14, Max Reitz wrote: > On 2017-11-09 05:21, Fam Zheng wrote: > > On Thu, 11/09 01:48, Max Reitz wrote: > >> Hi, > >> > >> More exciting news from the bdrv_drain() front! > >> > >> I've noticed in the past that iotest 194 sometimes hangs. I usually run > >> the tests on tmpfs, but

Re: [Qemu-devel] [PATCH V4] hw/pcie-pci-bridge: restrict to X86 and ARM

On 09/11/2017 16:37, Fam Zheng wrote: On Thu, 11/09 16:08, Marcel Apfelbaum wrote: make[1]: *** No rule to make target `../hw/pci-bridge/pcie_pci_bridge.o', needed by `qemu-system-aarch64'. Stop. make[1]: *** Waiting for unfinished jobs/tmp/qemu-test/src/target/arm/translate-a64.c: In

[Qemu-devel] [Bug 1731277] Re: Provide target specific qemu man pages

I'm kind of hoping that moving to Sphinx for our docs toolchain will allow us to for instance have the board specific information in doc comments in each board source file, which could then be automatically assembled into the right documentation. The current manpages are autobuilt from the

Re: [Qemu-devel] [PATCH V4] hw/pcie-pci-bridge: restrict to X86 and ARM

On 09/11/2017 16:29, Philippe Mathieu-Daudé wrote: Hi Marcel, On 11/09/2017 11:10 AM, Marcel Apfelbaum wrote: On 09/11/2017 16:03, Thomas Huth wrote: On 09.11.2017 14:04, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their

Re: [Qemu-devel] Intermittent hang of iotest 194 (bdrv_drain_all after non-shared storage migration)

On 2017-11-09 05:21, Fam Zheng wrote: > On Thu, 11/09 01:48, Max Reitz wrote: >> Hi, >> >> More exciting news from the bdrv_drain() front! >> >> I've noticed in the past that iotest 194 sometimes hangs. I usually run >> the tests on tmpfs, but I've just now verified that it happens on my SSD >>

Re: [Qemu-devel] [PATCH] Add missing parameters to mon option documentation

On Thu, Nov 09, 2017 at 01:19:03PM +0100, Vicente Jimenez Aguilar wrote: > Documentation missed 'mon' option's 'pretty' and 'default' parameters > > Signed-off-by: Vicente Jimenez Aguilar > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH V3] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

On Wed, Nov 08, 2017 at 04:48:09PM +0200, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with

[Qemu-devel] [PATCH 2/2] Add mon default parameter to help documentation

Spotted after reading mon_init_func from vl.c Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2692a48f63..12192a20e4 100644 --- a/qemu-options.hx +++

[Qemu-devel] [PATCH 1/2] Add mon pretty parameter to help documentation

Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..2692a48f63 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3477,7 +3477,7 @@ Like -qmp but

[Qemu-devel] [PATCH] Add missing parameters to mon option documentation

Documentation missed 'mon' option's 'pretty' and 'default' parameters Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..72cf48a8e5 100644 ---

[Qemu-devel] [PATCH] Add mon pretty parameter to help documentation

Signed-off-by: Vicente Jimenez Aguilar --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..2692a48f63 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3477,7 +3477,7 @@ Like -qmp but

Re: [Qemu-devel] [RISU PATCH 07/10] risugen: add --sve support

Dave Martin writes: > On Tue, Nov 07, 2017 at 03:05:55PM +, Alex Bennée wrote: >> This is similar to the approach used by the FP/simd data in so far as >> we generate a block of random data and then load into it. As there are >> no post-index SVE operations we need to

  1   2   >