[Qemu-devel] [PATCH 15/24] sdl: hook up to display registry

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 19 --- ui/sdl.c | 24 +--- ui/sdl2.c| 17 +++-- vl.c | 15 +-- 4 files changed, 29 insertions(+), 46 deletions(-) diff

[Qemu-devel] [PATCH 11/24] vl: drop full_screen variable

2017-11-17 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann --- vl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vl.c b/vl.c index 7d7e4ba9a1..85c41953b3 100644 --- a/vl.c +++ b/vl.c @@ -150,7 +150,6 @@ static int rtc_utc = 1; static int rtc_date_offset = -1; /* -1

[Qemu-devel] [PATCH v4] SDL2 various fixes

2017-11-17 Thread Jindrich Makovicka
Hi, here is a respin of the three remaining patches, with checkpatch errors corrected. Also added the Fixes: line for "sdl2 uses surface relative coordinates", and an explaining comment to "sdl2: Ignore UI hotkeys". Regards, Jindrich

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-17 Thread Wei Wang
On 11/16/2017 09:27 PM, Wei Wang wrote: On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote: On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote: Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to the host via

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-17 Thread Wei Wang
On 11/17/2017 07:35 PM, Wei Wang wrote: On 11/16/2017 09:27 PM, Wei Wang wrote: On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote: On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote: Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of

Re: [Qemu-devel] [PULL 0/5] Ui 20171117 patches

2017-11-17 Thread Peter Maydell
git://git.kraxel.org/qemu tags/ui-20171117-pull-request > > for you to fetch changes up to bcf43cdc178ffbd06d0533b6c54e92640817c9c7: > > sdl2: Fix broken display updating after the window is hidden (2017-11-16 > 09:57:47 +0100) > > --

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-17 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:23:35 +0100 Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:05:23 +0100 > David Hildenbrand wrote: > > > First one also applies to KVM SIGP handling. The other two only > > apply to TCG (allowing to IPL from disk with more than 1 VCPU-

[Qemu-devel] [PATCH] Don't ignore O_DIRECT flag in the 9pfs server

2017-11-17 Thread jiangyiwen
Now v9fs in linux has already supported O_DIRECT(v9fs_direct_IO), when guest user open file with O_DIRECT flag and return success, so user hopes data doesn't pass through page cache, but 9pfs in qemu ignore direct disk access and use host page cache, it is not match to DIRECT_IO semantic, so we

[Qemu-devel] [Bug 1732679] Re: Cisco NX-OSv 9k crashes during boot with qemu 2.10.1(Debian 1:2.10.0+dfsg-2)

2017-11-17 Thread jean-christophe manciot
Actually, this issue is solved with a fresher ovmf package than the one shipped by default with Ubuntu 17.04 (0~20161202.7bbe0b3e-1). This issue should be closed. ** Summary changed: - Cisco NX-OSv 9k crashes during boot with qemu 2.10.1(Debian 1:2.10.0+dfsg-2) + Cisco NX-OSv 9k crashes during

[Qemu-devel] [PULL 5/5] sdl2: Fix broken display updating after the window is hidden

2017-11-17 Thread Gerd Hoffmann
From: Jindrich Makovicka With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN blocks all subsequent display updates. Instead of trying to override the change, just update the scon->hidden flag. Signed-off-by: Jindrich Makovicka

[Qemu-devel] [PATCH 12/24] vl: drop display_type variable

2017-11-17 Thread Gerd Hoffmann
Switch over all leftover users to qapi DisplayType. The delete the unused display_type variable. Signed-off-by: Gerd Hoffmann --- vl.c | 52 +--- 1 file changed, 13 insertions(+), 39 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Darren Kenny
On Fri, Nov 17, 2017 at 11:30:41AM +0100, Gerd Hoffmann wrote: Using the new registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Yu Ning
On 11/15/2017 22:18, Paolo Bonzini wrote: On 15/11/2017 09:25, Yu Ning wrote: On 11/15/2017 3:13, John Snow wrote: On 11/14/2017 06:09 AM, Thomas Huth wrote: That's great news! I hope this all will help to promote QEMU on Windows and macOS quite a bit! However, during the past months, I

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Yu Ning
On 11/17/2017 16:30, Thomas Huth wrote: On 17.11.2017 09:17, Yu Ning wrote: [...] Is there a preferred document format for the QEMU blog, e.g. Markdown? Yes, we're using markdown of Jekyll (https://jekyllrb.com/docs/posts/). Please clone the qemu-web repository (see

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qapi: block-core: Clarify events emitted by 'block-job-cancel'

2017-11-17 Thread Kashyap Chamarthy
On Fri, Nov 17, 2017 at 11:49:05AM +0100, Kevin Wolf wrote: > Am 16.11.2017 um 10:14 hat Kashyap Chamarthy geschrieben: > > On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote: [...] > > > It's an interesting gotcha that I wasn't really acutely aware of myself, > > > so having it in the

[Qemu-devel] [PATCH 2/3] sdl2 uses surface relative coordinates

2017-11-17 Thread Jindrich Makovicka
This patch fixes mouse positioning with -device usb-tablet and fullscreen or resized window. Fixes: 46522a82236ea0cf9011b89896d2d8f8ddaf2443 Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 30 -- 1 file changed, 4 insertions(+), 26 deletions(-)

[Qemu-devel] [PATCH 1/4] [testing] update bios, add vgabios-ramfb

2017-11-17 Thread Gerd Hoffmann
source code: https://www.kraxe.org/cgit/seabios/log/?h=ramfb --- pc-bios/bios-256k.bin | Bin 262144 -> 262144 bytes pc-bios/vgabios-ramfb.bin | Bin 0 -> 28160 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 pc-bios/vgabios-ramfb.bin diff --git

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-17 Thread Michael S. Tsirkin
On Fri, Nov 17, 2017 at 07:35:03PM +0800, Wei Wang wrote: > On 11/16/2017 09:27 PM, Wei Wang wrote: > > On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote: > > > On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote: > > > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the >

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Denis V. Lunev
On 11/17/2017 03:30 PM, Kevin Wolf wrote: > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Snapshot-switch actually changes active state of disk so it should >> reflect on dirty bitmaps. Otherwise next incremental backup using >> these bitmaps will be invalid. >> >>

[Qemu-devel] [PATCH for-2.11] spapr: reset DRCs after devices

2017-11-17 Thread Greg Kurz
A DRC with a pending unplug request releases its associated device at machine reset time. In the case of LMB, when all DRCs for a DIMM device have been reset, the DIMM gets unplugged, causing guest memory to disappear. This may be very confusing for anything still using this memory. This is

Re: [Qemu-devel] [PATCH] hax-interface: Add BSD license

2017-11-17 Thread Yu Ning
On 11/17/2017 2:00, Eduardo Habkost wrote: On Thu, Nov 16, 2017 at 07:47:44AM +0100, Stefan Weil wrote: Am 16.11.2017 um 07:50 schrieb yu.n...@linux.intel.com: From: Yu Ning hax-interface.h defines the interface between the HAXM kernel module and the HAXM QEMU

Re: [Qemu-devel] [PULL 0/9] pc, pci, virtio: fixes for rc1

2017-11-17 Thread Peter Maydell
On 16 November 2017 at 16:40, Michael S. Tsirkin wrote: > The following changes since commit 6a7cb8c3d674815cab08d884740d203fded12249: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171115' into > staging (2017-11-16 12:45:14 +) > > are available in the git

[Qemu-devel] [PATCH 04/24] vl: rename DisplayType to LegacyDisplayType

2017-11-17 Thread Gerd Hoffmann
qapi DisplayType will replace the current enum. For the transition both will coexist though, so rename it so we don't have a name clash. Signed-off-by: Gerd Hoffmann --- vl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] [PATCH 07/24] vl: drop no_quit variable

2017-11-17 Thread Gerd Hoffmann
Not used any more, delete it. Signed-off-by: Gerd Hoffmann --- vl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index b34fbf1a09..d461800f13 100644 --- a/vl.c +++ b/vl.c @@ -152,7 +152,6 @@ QEMUClockType rtc_clock; int

[Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support

2017-11-17 Thread Gerd Hoffmann
SDL2 doesn't support this any more, the SDL_NOFRAME window flag is gone. Drop the code, print a notice when the option is still used. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 5 ++--- ui/sdl.c | 8 +--- ui/sdl2.c| 7 +-- vl.c

[Qemu-devel] [PATCH 18/24] egl-headless: hook up to display registry

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 --- ui/egl-headless.c| 20 +++- vl.c | 12 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index

[Qemu-devel] [PATCH v2 (for-2.11)] qcow2: fix image corruption after committing qcow2 image into base

2017-11-17 Thread Daniel P. Berrange
After committing the qcow2 image contents into the base image, qemu-img will call bdrv_make_empty to drop the payload in the layered image. When this is done for qcow2 images, it blows away the LUKS encryption header, making the resulting image unusable. There are two codepaths for emptying a

[Qemu-devel] [PATCH 4/4] add ramfb-testdev

2017-11-17 Thread Gerd Hoffmann
--- hw/display/ramfb-testdev.c | 87 ++ hw/display/Makefile.objs | 1 + 2 files changed, 88 insertions(+) create mode 100644 hw/display/ramfb-testdev.c diff --git a/hw/display/ramfb-testdev.c b/hw/display/ramfb-testdev.c new file mode 100644 index

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Kamil Rytarowski
On 14.11.2017 09:54, Yu Ning wrote: > Hello, > > As some of you may have noticed, since QEMU 2.9.0, an accelerator known > as “hax” has been available for Windows and macOS builds of QEMU, thanks > to the hard work of Vincent Palatin and help from this community (Paolo > Bonzini, Stefan Weil, et

[Qemu-devel] [PATCH 05/24] gtk: add and use DisplayOptions + DisplayGTK

2017-11-17 Thread Gerd Hoffmann
Add QAPI DisplayType enum, DisplayOptions union and DisplayGTK struct. Switch gtk configuration to use the qapi type. Some bookkeeping (fullscreen for example) is done twice now, this is temporary until more/all UIs are switched over to qapi configuration. FIXME: more elegant solution than

[Qemu-devel] [PATCH 06/24] sdl: use DisplayOptions

2017-11-17 Thread Gerd Hoffmann
Switch sdl ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 8 ui/sdl.c | 19 +-- ui/sdl2.c| 33 +++-- vl.c | 13 +++--

[Qemu-devel] [PATCH 21/24] sdl: build as module

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure| 2 +- Makefile.objs| 1 + ui/Makefile.objs | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0e856bbc04..7d1e9b187d 100755 --- a/configure +++ b/configure @@ -5754,7

[Qemu-devel] [PATCH 2/4] ramfb: simple boot framebuffer living in guest ram

2017-11-17 Thread Gerd Hoffmann
--- include/hw/display/ramfb.h | 8 hw/display/ramfb.c | 94 ++ hw/display/Makefile.objs | 2 + 3 files changed, 104 insertions(+) create mode 100644 include/hw/display/ramfb.h create mode 100644 hw/display/ramfb.c diff --git

[Qemu-devel] [PATCH 3/4] add virtio-ramfb

2017-11-17 Thread Gerd Hoffmann
--- hw/display/virtio-ramfb.c | 149 ++ hw/display/Makefile.objs | 2 +- 2 files changed, 150 insertions(+), 1 deletion(-) create mode 100644 hw/display/virtio-ramfb.c diff --git a/hw/display/virtio-ramfb.c b/hw/display/virtio-ramfb.c new file mode

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Thomas Huth
On 17.11.2017 09:17, Yu Ning wrote: [...] > Is there a preferred document format for the QEMU blog, e.g. Markdown? Yes, we're using markdown of Jekyll (https://jekyllrb.com/docs/posts/). Please clone the qemu-web repository (see https://git.qemu.org/?p=qemu-web.git), and have a look in the

[Qemu-devel] [PATCH 10/24] cocoa: use DisplayOptions

2017-11-17 Thread Gerd Hoffmann
Switch cocoa ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- vl.c | 3 ++- qapi/ui.json | 6 -- ui/cocoa.m | 4 ++-- 4 files changed, 10 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support

2017-11-17 Thread Gerd Hoffmann
With absolute pointer devices such as usb-tablet being widely used mouse grabs (for relative pointing devices) should be rarely needed these days. So the benefit of the options to configure the hotkey modifiers for grab (and other actions) seems questionable. Which is expecially true for the

[Qemu-devel] [PATCH 20/24] console: add ui module loading support

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/module.h | 1 + ui/console.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index 56dd218205..9fea75aaeb 100644 --- a/include/qemu/module.h +++

[Qemu-devel] [PATCH 03/24] sdl: use ctrl-alt-g as grab hotkey

2017-11-17 Thread Gerd Hoffmann
Be consistent with gtk and cocoa. Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 26 +++--- ui/sdl2.c | 22 +- 2 files changed, 20 insertions(+), 28 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 2c85482b5e..6ce67eeb5a 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qapi: block-core: Clarify events emitted by 'block-job-cancel'

2017-11-17 Thread Kevin Wolf
Am 16.11.2017 um 10:14 hat Kashyap Chamarthy geschrieben: > On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote: > > > > > > On 11/15/2017 04:54 PM, Kashyap Chamarthy wrote: > > > On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote: > > [...] > > > >> is it covered sufficiently in

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Kamil Rytarowski
On 17.11.2017 11:30, Yu Ning wrote: > > > On 11/17/2017 16:53, Kamil Rytarowski wrote: >> On 14.11.2017 09:54, Yu Ning wrote: >>> Hello, >>> >>> As some of you may have noticed, since QEMU 2.9.0, an accelerator known >>> as “hax” has been available for Windows and macOS builds of QEMU, thanks

Re: [Qemu-devel] [PATCH 00/24] RfC: rework display initialization

2017-11-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/24] RfC: rework display initialization Type: series Message-id: 20171117103046.15943-1-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH 0/4] ramfb: simple boot framebuffer, no legacy vga

2017-11-17 Thread Gerd Hoffmann
Hi, Ok folks, here is a experimental patch series for a legacy free boot framebuffer. If you want play with it I recommend getting the bits from https://www.kraxel.org/cgit/qemu/log/?h=sirius/ramfb because they come with an updated seabios and a new vgabios rom. The boot framebuffer

Re: [Qemu-devel] [PATCH v2 (for-2.11)] qcow2: fix image corruption after committing qcow2 image into base

2017-11-17 Thread Kevin Wolf
Am 17.11.2017 um 12:29 hat Daniel P. Berrange geschrieben: > After committing the qcow2 image contents into the base image, qemu-img > will call bdrv_make_empty to drop the payload in the layered image. > > When this is done for qcow2 images, it blows away the LUKS encryption > header, making the

Re: [Qemu-devel] [PATCH 1/2] virtio: Add queue interface to restore avail index from vring used index

2017-11-17 Thread Jens Freimann
On Thu, Nov 16, 2017 at 06:48:34PM +, Maxime Coquelin wrote: In case of backend crash, it is not possible to restore internal avail index from the backend value as vhost_get_vring_base callback fails. This patch provides a new interface to restore internal avail index from the vring used

[Qemu-devel] [PATCH 00/24] RfC: rework display initialization

2017-11-17 Thread Gerd Hoffmann
Hi, This series reworks the qemu display initialization. Changes: * Create a QAPI DisplayOptions type for display configuration. * Switch all display initialization calls to accept DisplayOptions instead of a bunch of bools. * Add a registry for displays, and remove alot of #ifdefs

[Qemu-devel] [PATCH 14/24] console: add qemu display registry, add gtk

2017-11-17 Thread Gerd Hoffmann
Add a registry for user interfaces. Add qemu_display_init and qemu_display_early_init helper functions for display initialization. Hook up gtk ui as first user. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 32 ui/console.c

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2017 06:10, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three

Re: [Qemu-devel] [PATCH v1 for-2.11 0/3] s390x: fixes for SIGP and DIAG 308

2017-11-17 Thread Christian Borntraeger
On 11/17/2017 09:10 AM, Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:23:35 +0100 > Cornelia Huck wrote: > >> On Thu, 16 Nov 2017 18:05:23 +0100 >> David Hildenbrand wrote: >> >>> First one also applies to KVM SIGP handling. The other two only >>> apply to

Re: [Qemu-devel] [PATCH 2/2] vhost: restore avail index from vring used index on disconnection

2017-11-17 Thread Jens Freimann
On Thu, Nov 16, 2017 at 06:48:35PM +, Maxime Coquelin wrote: vhost_virtqueue_stop() gets avail index value from the backend, except if the backend is not responding. It happens when the backend crashes, and in this case, internal state of the virtio queue is inconsistent, making packets to

[Qemu-devel] [PATCH] ps2: simplify ps2_common_post_load()

2017-11-17 Thread Gerd Hoffmann
It's broken right now, due to q->data and tmp_data data types not being the same. So, with that being unnoticed for years I guess the queue backward compatibility handling (for old qemu versions with a larger queue) can't be that important. So, in case we find any queue data we can't accept just

[Qemu-devel] [PULL 1/5] sdl2: Do not quit the emulator when an auxilliary window is closed

2017-11-17 Thread Gerd Hoffmann
From: Jindrich Makovicka Signed-off-by: Jindrich Makovicka Message-Id: <20171112193032.9724-3-makov...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 13/24] vl: drop request_opengl variable

2017-11-17 Thread Gerd Hoffmann
Switch over the one leftover user to qapi DisplayType. The delete the unused request_opengl variable. Signed-off-by: Gerd Hoffmann --- vl.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/vl.c b/vl.c index 36eec0d1e0..c04cef83da 100644 --- a/vl.c

Re: [Qemu-devel] HAXM is now open source

2017-11-17 Thread Yu Ning
On 11/17/2017 16:53, Kamil Rytarowski wrote: On 14.11.2017 09:54, Yu Ning wrote: Hello, As some of you may have noticed, since QEMU 2.9.0, an accelerator known as “hax” has been available for Windows and macOS builds of QEMU, thanks to the hard work of Vincent Palatin and help from this

[Qemu-devel] [PATCH 08/24] egl-headless: use DisplayOptions

2017-11-17 Thread Gerd Hoffmann
Switch egl-headless ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- ui/egl-headless.c| 2 +- vl.c | 3 ++- qapi/ui.json | 5 +++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Gerd Hoffmann
Using the new registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 17/24] curses: hook up to display registry

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 ui/curses.c | 14 +- vl.c | 17 ++--- 3 files changed, 15 insertions(+), 28 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index

[Qemu-devel] [PATCH 09/24] curses: use DisplayOptions

2017-11-17 Thread Gerd Hoffmann
Switch curses ui to use qapi DisplayOptions for configuration. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 ++-- ui/curses.c | 2 +- vl.c | 4 +++- qapi/ui.json | 5 +++-- 4 files changed, 9 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 16/24] cocoa: hook up to display registry

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 vl.c | 3 --- ui/cocoa.m | 14 +- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index

[Qemu-devel] [PATCH 22/24] gtk: build as module

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure| 5 ++--- ui/Makefile.objs | 16 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 7d1e9b187d..91c9323a50 100755 --- a/configure +++ b/configure @@ -2470,7 +2470,6

[Qemu-devel] [PATCH 1/3] sdl2: Do not hide the cursor on auxilliary windows

2017-11-17 Thread Jindrich Makovicka
Signed-off-by: Jindrich Makovicka --- ui/sdl2.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 53dd447fd2..290b57b1b3 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -463,6 +463,10 @@ static void handle_mousemotion(SDL_Event *ev)

[Qemu-devel] [PATCH 3/3] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

2017-11-17 Thread Jindrich Makovicka
When SDL2 windows change focus while a key is held, the window that receives the focus also receives a new KeyDown event, without an autorepeat flag. This means that if a WM places the qemu console over the main window after Ctrl-Alt-2, the console closes immediately after opening. Then, the main

[Qemu-devel] [Bug 1724570] Re: qemu-system-x86_64 generates ACPI tables with broken endianess when run on big-endian hosts

2017-11-17 Thread Thomas Huth
Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=3831c07b89ab1f7aa1427 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1724570

Re: [Qemu-devel] [PATCH v2 for-2.11] migration, xen: Fix block image lock issue on live migration

2017-11-17 Thread Kevin Wolf
Am 16.11.2017 um 16:14 hat Anthony PERARD geschrieben: > When doing a live migration of a Xen guest with libxl, the images for > block devices are locked by the original QEMU process, and this prevent > the QEMU at the destination to take the lock and the migration fail. > > From QEMU point of

Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load routine

2017-11-17 Thread Gerd Hoffmann
> > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > index f388a23c8e..de171a28dd 100644 > > --- a/hw/input/ps2.c > > +++ b/hw/input/ps2.c > > @@ -1225,24 +1225,21 @@ static void ps2_common_reset(PS2State *s) > > static void ps2_common_post_load(PS2State *s) > > { > > PS2Queue *q = >queue;

Re: [Qemu-devel] [PATCH v2 for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too

2017-11-17 Thread Jason Wang
On 2017年11月14日 19:20, Thomas Huth wrote: Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the pxe-tester, too (when running "make check SPEED=slow"). This now revealed that the code is not working there if the host is a big endian machine (for example ppc64 or s390x) - "make

[Qemu-devel] [PULL 2/5] sdl2: Use the same pointer show/hide logic for absolute and relative mode

2017-11-17 Thread Gerd Hoffmann
From: Jindrich Makovicka Also use a proper enum parameter for SDL_ShowCursor Signed-off-by: Jindrich Makovicka Message-Id: <20171112193032.9724-4-makov...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 24

[Qemu-devel] [PULL 0/5] Ui 20171117 patches

2017-11-17 Thread Gerd Hoffmann
The following changes since commit 1fa0f627d03cd0d0755924247cafeb42969016bf: Update version for v2.11.0-rc1 release (2017-11-14 18:37:49 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20171117-pull-request for you to fetch changes up

[Qemu-devel] [PULL 3/5] sdl2: Fix dead keyboard after fullsceen

2017-11-17 Thread Gerd Hoffmann
From: Jindrich Makovicka Signed-off-by: Jindrich Makovicka Message-Id: <20171112193032.9724-7-makov...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c

[Qemu-devel] [PULL 4/5] sdl2: Do not leave grab when fullscreen

2017-11-17 Thread Gerd Hoffmann
From: Jindrich Makovicka Prevents displaying of a doubled mouse pointer when moving the pointer to the screen edges when fullscreen. Signed-off-by: Jindrich Makovicka Message-Id: <20171112193032.9724-8-makov...@gmail.com> Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 23/24] curses: build as module

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure| 6 +++--- ui/Makefile.objs | 6 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 91c9323a50..67a8c2e83a 100755 --- a/configure +++ b/configure @@ -3190,8 +3190,6 @@ EOF

[Qemu-devel] [PATCH 24/24] build: opengl should not need X11

2017-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 67a8c2e83a..e344c0d08e 100755 --- a/configure +++ b/configure @@ -3685,8 +3685,8 @@ libs_softmmu="$libs_softmmu $fdt_libs" if test

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Kevin Wolf
Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Gerd Hoffmann
Hi, > > -dpy.type = DISPLAY_TYPE_NONE; > > +if (!qemu_display_find_default()) { > > +dpy.type = DISPLAY_TYPE_NONE; > > +#if defined(CONFIG_VNC) > > +vnc_parse("localhost:0,to=99,id=default", _abort); > > #endif > > Mostly some questions on this: > > -

Re: [Qemu-devel] [PATCH v3 1/3] i386/msi: Correct mask of destination ID in MSI address

2017-11-17 Thread Michael S. Tsirkin
On Fri, Nov 17, 2017 at 02:24:23PM +0800, Chao Gao wrote: > According to SDM 10.11.1, only [19:12] bits of MSI address are > Destination ID, change the mask to avoid ambiguity for VT-d spec > has used the bit 4 to indicate a remappable interrupt request. > > Signed-off-by: Chao Gao

[Qemu-devel] [PATCH 07/15] apb: return APBState from pci_apb_init() rather then PCIBus

2017-11-17 Thread Mark Cave-Ayland
This is a first step towards removing pci_apb_init() completely. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/apb.c |8 hw/sparc64/sun4u.c|6 -- include/hw/pci-host/apb.h |6 +++--- 3 files changed, 11 insertions(+), 9

[Qemu-devel] [PATCH 00/15] sun4u: tidy-up CPU, APB and ebus

2017-11-17 Thread Mark Cave-Ayland
This patchset for 2.12 continues with tidying up the sun4u CPU, APB and ebus devices by encapsulating the ebus ISA bus within the ebus QOM device, allowing APB and ebus devices to be instantiated directly via QOM, and formally wiring up the device IRQs using qdev GPIOs rather than passing around

[Qemu-devel] [PATCH 13/15] apb: replace OBIO interrupt numbers in pci_pbmA_map_irq() with constants

2017-11-17 Thread Mark Cave-Ayland
Following on from the previous commit, we can also do the same with with legacy OBIO interrupts in pci_pbmA_map_irq(). Signed-off-by: Mark Cave-Ayland --- hw/pci-host/apb.c |4 ++-- include/hw/pci-host/apb.h |2 ++ 2 files changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH v5 24/29] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()

2017-11-17 Thread Mark Cave-Ayland
On 13/11/17 22:35, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N;

Re: [Qemu-devel] [PATCH 12/15] ebus: wire up OBIO interrupts to APB pbm via qdev GPIOs

2017-11-17 Thread Artyom Tarasenko
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: > This enables us to remove the static array mapping in the ISA IRQ > handler (and the embedded reference to the APB device) by formalising > the interrupt wiring via the qdev GPIO API. > > For more clarity we

[Qemu-devel] [PULL 0/4] NBD patches for 2.11-rc2

2017-11-17 Thread Eric Blake
The following changes since commit fec035a53fa15c4c8c4e62bfef56a35df4161e38: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20171117-pull-request' into staging (2017-11-17 10:18:41 +) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-11-17

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-17 Thread Michael S. Tsirkin
On Thu, Nov 16, 2017 at 09:27:24PM +0800, Wei Wang wrote: > On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote: > > On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote: > > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the > > > support of reporting hints of guest free

Re: [Qemu-devel] [PATCH v3 2/2] tests/qemu-iotests: adding savevm/loadvm with postcopy flag test

2017-11-17 Thread Daniel Henrique Barboza
On 11/17/2017 11:24 AM, Cleber Rosa wrote: On 11/16/2017 05:35 PM, Daniel Henrique Barboza wrote: This patch implements a test case for the scenario that was failing prior to the patch "migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END". This new test file 198 was

[Qemu-devel] [PATCH 15/15] sun4u: switch from EBUS_DPRINTF() macro to trace-events

2017-11-17 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/sparc64/sun4u.c | 12 ++-- hw/sparc64/trace-events |3 +++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index da386d3..50ccf75 100644 ---

[Qemu-devel] [PATCH 06/15] apb: APB QOMify tidy-up

2017-11-17 Thread Mark Cave-Ayland
Use DeviceClass rather than SysBusDeviceClass in pbm_host_class_init() and adjust pci_pbm_init_device() accordingly. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/apb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 01/15] apb: move QOM macros and typedefs from apb.c to apb.h

2017-11-17 Thread Artyom Tarasenko
Hi Mark, On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: > This also includes the related IOMMUState typedef and defines. > > Signed-off-by: Mark Cave-Ayland > --- > hw/pci-host/apb.c | 85

Re: [Qemu-devel] [PATCH 14/15] sparc64: introduce trace-events for hw/sparc64

2017-11-17 Thread Artyom Tarasenko
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: > This is in preparation for switching code in hw/sparc64 from DPRINTF over to > trace events. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Artyom Tarasenko

Re: [Qemu-devel] [PATCH v2 (for-2.11)] qcow2: fix image corruption after committing qcow2 image into base

2017-11-17 Thread Kevin Wolf
Am 17.11.2017 um 15:32 hat Eric Blake geschrieben: > On 11/17/2017 05:29 AM, Daniel P. Berrange wrote: > > After committing the qcow2 image contents into the base image, qemu-img > > will call bdrv_make_empty to drop the payload in the layered image. > > > > When this is done for qcow2 images, it

Re: [Qemu-devel] [PATCH v2 for-2.11] nbd/server: Fix error reporting for bad requests

2017-11-17 Thread Eric Blake
On 11/16/2017 02:52 AM, Vladimir Sementsov-Ogievskiy wrote: >>   if (request->type == NBD_CMD_READ || request->type == >> NBD_CMD_WRITE) { >>   if (request->len > NBD_MAX_BUFFER_SIZE) { >>   error_setg(errp, "len (%" PRIu32" ) is larger than max >> len (%u)", > > related

[Qemu-devel] [PULL 4/4] nbd/server: Fix error reporting for bad requests

2017-11-17 Thread Eric Blake
The NBD spec says an attempt to NBD_CMD_TRIM on a read-only export should fail with EPERM, as a trim has the potential to change disk contents, but we were relying on the block layer to catch that for us, which might not always give the right error (and even if it does, it does not let us pass

[Qemu-devel] [PULL 3/4] nbd/client: Don't hard-disconnect on ESHUTDOWN from server

2017-11-17 Thread Eric Blake
The NBD spec says that a server may fail any transmission request with ESHUTDOWN when it is apparent that no further request from the client can be successfully honored. The client is supposed to then initiate a soft shutdown (wait for all remaining in-flight requests to be answered, then send

Re: [Qemu-devel] [PATCH 01/24] sdl: remove -no-frame support

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 02:59:54PM +, Daniel P. Berrange wrote: > On Fri, Nov 17, 2017 at 03:49:06PM +0100, Gerd Hoffmann wrote: > > On Fri, Nov 17, 2017 at 02:21:30PM +, Daniel P. Berrange wrote: > > > On Fri, Nov 17, 2017 at 11:30:23AM +0100, Gerd Hoffmann wrote: > > > > SDL2 doesn't

[Qemu-devel] [PATCH for-2.11 2/2] iotests: test clearing unknown autoclear_features by qcow2

2017-11-17 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Test clearing unknown autoclear_features by qcow2 on incoming migration. [ kwolf: Fixed wait for destination VM startup ] Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Darren Kenny
On Fri, Nov 17, 2017 at 04:03:28PM +0100, Gerd Hoffmann wrote: Hi, OK, so the odd thing then is the check for !remote_display earlier on in the function (missing from the quote above) which seems to end up initializing VNC (albeit with localhost) when CONFIG_VNC is defined, but no other local

Re: [Qemu-devel] [PATCH for-2.11 1/2] block: Fix permissions in image activation

2017-11-17 Thread Max Reitz
On 2017-11-17 16:47, Kevin Wolf wrote: > Inactive images generally request less permissions for their image files > than they would if they were active (in particular, write permissions). > Activating the image involves extending the permissions, therefore. > > drv->bdrv_invalidate_cache() can

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-17 Thread Cleber Rosa
On 11/17/2017 02:19 AM, Paolo Bonzini wrote: > On 16/11/2017 18:38, Cleber Rosa wrote: >> This variables has no real use. To avoid pretending it does, while >> still keeping the information, let's turn it into a comment. >> >> The format chosen is the one already being used on tests 149 and

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Kevin Wolf
Am 17.11.2017 um 13:58 hat Denis V. Lunev geschrieben: > On 11/17/2017 03:30 PM, Kevin Wolf wrote: > > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Snapshot-switch actually changes active state of disk so it should > >> reflect on dirty bitmaps. Otherwise next

[Qemu-devel] [PATCH 08/15] apb: use gpios to wire up the apb device to the SPARC CPU IRQs

2017-11-17 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/pci-host/apb.c |6 ++ hw/sparc64/sparc64.c |2 ++ hw/sparc64/sun4u.c | 12 include/hw/pci-host/apb.h |6 -- include/hw/sparc/sparc64.h |2 ++ 5 files changed, 18

Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 11:30:24AM +0100, Gerd Hoffmann wrote: > With absolute pointer devices such as usb-tablet being widely used > mouse grabs (for relative pointing devices) should be rarely needed > these days. So the benefit of the options to configure the hotkey > modifiers for grab (and

Re: [Qemu-devel] [PATCH 10/15] apb: remove pci_apb_init() and instantiate APB device using qdev

2017-11-17 Thread Artyom Tarasenko
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland wrote: > By making the special_base and mem_base values qdev properties, we can move > the remaining parts of pci_apb_init() into the pbm init() and realize() > functions. > > This finally allows us to instantiate

  1   2   3   >