[Qemu-devel] [PATCH v4 33/46] windbg: implemented kd_api_write_breakpoint and kd_api_restore_breakpoint

2017-12-11 Thread Mihail Abakumov
Added supporting of windbg breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + windbgstub-utils.c | 62

[Qemu-devel] [PATCH v4 41/46] windbg: implemented kd_api_fill_memory

2017-12-11 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 39 +++

[Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread David Hildenbrand
Use s390_cpu_virt_mem_write() so we can actually revert what we did (re-inject the dequeued IO interrupt). Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 1 + target/s390x/misc_helper.c | 53

[Qemu-devel] [PATCH v1 for-2-12 07/15] s390x/tcg: tolerate wrong wakeups due to floating interrupts

2017-12-11 Thread David Hildenbrand
This is a preparation for floating interrupt support and only applies to MTTCG, single threaded TCG works just fine. If a floating interrupt wakes up a VCPU and the CPU thinks it can run (clearing cs->halted), at the point where the interrupt would be delivered, already another VCPU might have

[Qemu-devel] [PATCH v1 for-2-12 08/15] s390x/flic: make floating interrupts on TCG actually floating

2017-12-11 Thread David Hildenbrand
Move floating interrupt handling into the flic. Floating interrupts will now be considered by all CPUs, not just CPU #0. While at it, convert I/O interrupts to use a list and make sure we properly consider I/O sub-classes in s390_cpu_has_io_int(). Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Eduardo Habkost
On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: > > > On 12/07/2017 10:58 PM, Eduardo Habkost wrote: > > On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: > > > * according to Eduardo Habkost's commit > > >fd3b02c8896d597dd8b9e053dec579cf0386aee1 > >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-11 Thread Wang, Wei W
On Monday, December 11, 2017 7:12 PM, Stefan Hajnoczi wrote: > On Sat, Dec 09, 2017 at 04:23:17PM +, Wang, Wei W wrote: > > On Friday, December 8, 2017 4:34 PM, Stefan Hajnoczi wrote: > > > On Fri, Dec 8, 2017 at 6:43 AM, Wei Wang > wrote: > > > > On 12/08/2017 07:54 AM,

Re: [Qemu-devel] [RFC v2 0/8] Rework vhost memory region updates

2017-12-11 Thread Igor Mammedov
On Fri, 8 Dec 2017 20:32:49 + "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is an experimental set that reworks the way the vhost > code handles changes in physical address space layout that > came from a

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
On Fri, 12/08 09:54, Stefan Hajnoczi wrote: > On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > > +@item --force-share (-U) > > + > > +If specified, @code{qemu-img} will open the image with shared permissions, > > +which makes it less likely to conflict with a running guest's

Re: [Qemu-devel] [PATCH v9 11/12] migration: Flush receive queue

2017-12-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> +/* We are getting low on pages flags, so we start using combinations >> + When we need to flush a page, we sent it as >> + RAM_SAVE_FLAG_MULTIFD_PAGE | RAM_SAVE_FLAG_COMPRESS_PAGE >> +

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-12-11 Thread Denis V. Lunev
On 11/28/2017 03:10 PM, Denis V. Lunev wrote: > There are 2 cases I have spotted so far: > 1) IDE ATAPI read processing. Actually this was reported from field > 2) QEMU IO hmp command (found during evaluation of (1)) > > SCSI code checks during access that blk_is_available(). These patches add >

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Kevin Wolf
Am 09.12.2017 um 01:57 hat John Snow geschrieben: > Here's an idea of what this API might look like without revealing > explicit merge/split primitives. > > A new bitmap property that lets us set retention: > > :: block-dirty-bitmap-set-retention bitmap=foo slices=10 > > Or something similar,

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
11.12.2017 14:15, Kevin Wolf wrote: Am 09.12.2017 um 01:57 hat John Snow geschrieben: Here's an idea of what this API might look like without revealing explicit merge/split primitives. A new bitmap property that lets us set retention: :: block-dirty-bitmap-set-retention bitmap=foo slices=10

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > * Warner Losh (i...@bsdimp.com) wrote: > > unknown keycodes `empty+aliases(qwerty)', please report to > > qemu-devel@nongnu.org > > > > My X server is Mac XQuartz 2.7.11. I saw this question raised several years > > ago in

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Denis V. Lunev
On 12/09/2017 03:57 AM, John Snow wrote: > This is going to be a long one. Maybe go get a cup of coffee. > > On 12/07/2017 04:39 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.12.2017 03:38, John Snow wrote: >>> I'm sorry, I don't think I understand. >>> >>> "customers needs a possibility to create

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function

[Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi

Re: [Qemu-devel] [PATCH v9 12/12] migration: Add multifd test

2017-12-11 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We set the x-multifd-page-count and x-multifd-channels. >> >> Signed-off-by: Juan Quintela > > > We *must* find a way to share all the boiler plate I've snipped > out;

Re: [Qemu-devel] [PATCH v3 for-2.12 00/14] s390x/tcg: CCW hotplug, facilities, instructions

2017-12-11 Thread Cornelia Huck
On Fri, 8 Dec 2017 17:01:53 +0100 David Hildenbrand wrote: > Both series in one piece as (most probably) most reviewing is done. > > Wire up some io instructions and implement new facilitites. Make sure > to take care of MTTCG when it comes to atomic operations. Make CCW >

Re: [Qemu-devel] [virtio-dev] [PATCH v3 0/7] Vhost-pci for inter-VM communication

2017-12-11 Thread Stefan Hajnoczi
On Sat, Dec 09, 2017 at 04:23:17PM +, Wang, Wei W wrote: > On Friday, December 8, 2017 4:34 PM, Stefan Hajnoczi wrote: > > On Fri, Dec 8, 2017 at 6:43 AM, Wei Wang wrote: > > > On 12/08/2017 07:54 AM, Michael S. Tsirkin wrote: > > >> > > >> On Thu, Dec 07, 2017 at

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/11/2017 12:41 PM, Fam Zheng wrote: > On Thu, 12/07 13:10, Michal Privoznik wrote: >> Dear list, >> >> I've encountered the following problem. I have two disks: >> >> /var/lib/libvirt/images/fedora.qcow2 (which contains OS) >> /dev/sde (iSCSI dummy disk just for testing) >> >> Now, when

[Qemu-devel] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Christian Borntraeger
KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically limiting the memory per slot to 8TB-4k. As memory slots on s390/kvm must be a multiple of 1MB we need start a new memory region if we cross 8TB-1M. With that (and optimistic overcommitment in the kernel) I was able to start a

Re: [Qemu-devel] [PATCH 2/5] lock-guard: add scoped lock implementation

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 06:56:12PM +0100, Paolo Bonzini wrote: > On 08/12/2017 16:30, Stefan Hajnoczi wrote: > > On Fri, Dec 08, 2017 at 11:55:50AM +0100, Paolo Bonzini wrote: > > > > The implementation is somewhat complex. Please structure the header > > file so the public interfaces are clear

Re: [Qemu-devel] [PATCH v3 26/50] qapi: add 'if' on union variants

2017-12-11 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 15 ++- > tests/qapi-schema/qapi-schema-test.json | 7 ++- > tests/qapi-schema/qapi-schema-test.out | 8

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread David Hildenbrand
[resending as I noticed that I dropped the ccs when I sent this last week] On 07.12.2017 15:58, Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. Lets start a new memory region > if we cross that boundary.

Re: [Qemu-devel] [PATCH] tests: virtio-9p: fix ISR dependence

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 03:26:13PM +0100, Greg Kurz wrote: > Like other virtio tests, use the used ring APIs instead of assuming ISR > being set means the request has completed. > > Signed-off-by: Greg Kurz > --- > tests/virtio-9p-test.c | 30 +++--- >

Re: [Qemu-devel] qemu process crash: Assertion failed: QLIST_EMPTY(>tracked_requests)

2017-12-11 Thread Stefan Hajnoczi
On Thu, Dec 07, 2017 at 10:18:52AM +, Fernando Casas Schössow wrote: > Hi there, > > > Last night while doing a backup of a guest using the live snapshot mechanism > the qemu process for the guest seem to had crashed. > > The snapshot succeeded then the backup of the VM disk had place and

Re: [Qemu-devel] [PATCH v2] qemu-img: Document --force-share / -U

2017-12-11 Thread Kashyap Chamarthy
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > > --- > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Kashyap Chamarthy

Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Kevin Wolf
Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > > --- > > v3: Document that the option is not allowed for read-write. [Stefan] > > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 + > 1 file

Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 02:02:32PM -0600, Eric Blake wrote: > On 12/08/2017 12:12 PM, Paolo Bonzini wrote: > > On 08/12/2017 16:13, Stefan Hajnoczi wrote: > >>> -qemu_mutex_lock(>lock); > >>> +QEMU_LOCK_GUARD(QemuMutex, pool_guard, >lock); > >>> if (pool->idle_threads == 0 &&

[Qemu-devel] [PATCH] display: check irq handler index before access

2017-12-11 Thread P J P
From: Prasad J Pandit The ctz32() routine could return value greater than TC6393XB_GPIOS=16. This could lead to an OOB array access. Add check to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit ---

Re: [Qemu-devel] [PATCH] display: check irq handler index before access

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 10:55, P J P wrote: > From: Prasad J Pandit > > The ctz32() routine could return value greater than > TC6393XB_GPIOS=16. This could lead to an OOB array access. > Add check to avoid it. > > Reported-by: Moguofang

Re: [Qemu-devel] [PATCH 12/12] WIP ucontext: annotate coroutine stack for ASAN

2017-12-11 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Dec 08, 2017 at 01:58:25AM +0100, Marc-André Lureau wrote: > > Not strictly necessary, but it may help ASAN and remove some false > > positives. > > > > Sadly, this annotation produces an ASAN error: > > > > $ tests/test-coroutine -p /basic/lifecycle >

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Fam Zheng
On Thu, 12/07 13:10, Michal Privoznik wrote: > Dear list, > > I've encountered the following problem. I have two disks: > > /var/lib/libvirt/images/fedora.qcow2 (which contains OS) > /dev/sde (iSCSI dummy disk just for testing) > > Now, when I configure QEMU to start with both of them,

Re: [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/07/2017 01:10 PM, Michal Privoznik wrote: > Dear list, > Ping. Is there anything I can help you with to have this sorted out? Michal

Re: [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Stefan Hajnoczi
On Fri, Dec 08, 2017 at 09:57:25AM -0600, Mark Kanda wrote: > v2: add check for maximum queue size [Stefan] > > This series is for two minor virtio-blk changes. The first patch > makes the virtio-blk queue size user configurable. The second patch > rejects logical block size > physical block

Re: [Qemu-devel] [PATCH v3] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
On Mon, 12/11 10:50, Kevin Wolf wrote: > Am 11.12.2017 um 10:33 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > > > --- > > > > v3: Document that the option is not allowed for read-write. [Stefan] > > > > v2: - "code{qemu-img}". [Kashyap, Eric] > > - "etc.." ->

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Peter Maydell
On 8 December 2017 at 19:40, Eric Blake wrote: > On 12/08/2017 04:55 AM, Paolo Bonzini wrote: >> Likewise, >> >> QEMU_WITH_LOCK(QemuMutex, guard_name, _mutex) { >> ... >> } >> >> is the same as >> >> qemu_mutex_lock(_mutex); >> ... >>

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Igor Mammedov
On Fri, 8 Dec 2017 17:51:56 + "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Thu, 7 Dec 2017 18:17:51 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > >

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Fri, 8 Dec 2017 17:51:56 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Thu, 7 Dec 2017 18:17:51 + > > > "Dr. David Alan Gilbert" wrote: > > >

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread Cornelia Huck
On Thu, 7 Dec 2017 15:58:16 +0100 Christian Borntraeger wrote: > KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > limiting the memory per slot to 8TB-4k. Lets start a new memory region s/Lets/Let's/ :) > if we cross that boundary. > > With that

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-11 Thread gengdongjiu
Hi maintainer, This patch set seems pending about one month, could you help review for them? Thanks. In this series, except the three patches in [1] are dependent on KVM implementation. Other patches does not depend on KVM/host, because KVM/host has already supported them, According to

Re: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES

2017-12-11 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171207145816.87347-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH/RFC v2] s390x: start a new memory region if the old one exceeds KVM_MEM_MAX_NR_PAGES Type: series === TEST

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Dr. David Alan Gilbert
* Warner Losh (i...@bsdimp.com) wrote: > unknown keycodes `empty+aliases(qwerty)', please report to > qemu-devel@nongnu.org > > My X server is Mac XQuartz 2.7.11. I saw this question raised several years > ago in the archives, with promises of patches, but couldn't find anything > relevant in the

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Warner Losh
On Mon, Dec 11, 2017 at 5:29 AM, Dr. David Alan Gilbert wrote: > * Warner Losh (i...@bsdimp.com) wrote: > > unknown keycodes `empty+aliases(qwerty)', please report to > > qemu-devel@nongnu.org > > > > My X server is Mac XQuartz 2.7.11. I saw this question raised several >

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/1] s390-ccw-virtio: allow for systems larger that 7.999TB

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 15:04:13 +0100 Christian Borntraeger wrote: > On 12/11/2017 02:55 PM, David Hildenbrand wrote: > > On 11.12.2017 13:21, Christian Borntraeger wrote: > >> KVM does not allow memory regions > KVM_MEM_MAX_NR_PAGES, basically > >> limiting the memory per

Re: [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/11/2017 04:19 PM, Eduardo Habkost wrote: On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit

[Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
The refactoring of commit 296e5a0a6c3935 has a nasty bug: it accidentally dropped the generation of code to raise the UNDEF exception when disas_thumb2_insn() returns nonzero. This means that 32-bit Thumb2 instruction patterns that ought to UNDEF just act like nops instead. This is likely to break

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread Paolo Bonzini
On 29/11/2017 20:13, David Hildenbrand wrote: > The conditional memory barrier not only looks strange but actually is > wrong. > > On s390x, I can reproduce interrupts via cpu_interrupt() not leading to > a proper kick out of emulation every now and then. cpu_interrupt() is > especially used for

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 11:31 AM, Max Reitz wrote: > On 2017-12-08 18:09, John Snow wrote: >> >> >> On 12/08/2017 09:30 AM, Max Reitz wrote: >>> On 2017-12-05 01:48, John Snow wrote: On 12/04/2017 05:21 PM, Max Reitz wrote: > On 2017-12-04 23:15, John Snow wrote: >> >> >> On

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Warner Losh
On Mon, Dec 11, 2017 at 5:33 AM, Daniel P. Berrange wrote: > On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > > * Warner Losh (i...@bsdimp.com) wrote: > > > unknown keycodes `empty+aliases(qwerty)', please report to > > > qemu-devel@nongnu.org > > >

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 08:06:47AM -0700, Warner Losh wrote: > On Mon, Dec 11, 2017 at 5:29 AM, Dr. David Alan Gilbert > wrote: > > > * Warner Losh (i...@bsdimp.com) wrote: > > > unknown keycodes `empty+aliases(qwerty)', please report to > > > qemu-devel@nongnu.org > > > >

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function

Re: [Qemu-devel] [RFC] vhost: check if ring mapping is still valid when building memmap

2017-12-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 11 Dec 2017 11:03:00 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Fri, 8 Dec 2017 17:51:56 + > > > "Dr. David Alan Gilbert" wrote: > > >

Re: [Qemu-devel] [PATCH] scsi: check current request object before use

2017-12-11 Thread Paolo Bonzini
On 06/12/2017 12:34, Darren Kenny wrote: > Are both tests for NULL necessary, the second one would seem to > suffice - but also the first check changes whether esp_dma_done() > would get called or not here: > >  276 if (s->async_len == 0) { >  277 scsi_req_continue(s->current_req); >  

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread Paolo Bonzini
On 29/11/2017 20:12, David Hildenbrand wrote: > pause_all_cpus() is sometimes called from a VCPU thread (e.g. s390x > during special reset). It cannot deal with multiple VCPUs per Thread > (single threaded TCG) yet. > > Booting an s390x guest with -smp 2 and single threaded TCG from disk >

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int vm_stop(RunState state) > * FIXME: should not return to device code in case > * vm_stop() has been requested. > */ > -cpu_stop_current(); > +

Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] scsi: store unmap offset and nb_sectors in request struct

2017-12-11 Thread Alberto Garcia
On Mon 20 Nov 2017 05:51:00 PM CET, Anton Nefedov wrote: > it allows to report it in the error handler > > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Mark Kanda
v2: add check for maximum queue size [Stefan] This series is for two minor virtio-blk changes. The first patch makes the virtio-blk queue size user configurable. The second patch rejects logical block size > physical block configurations (similar to a recent change in virtio-scsi). Mark Kanda

Re: [Qemu-devel] [PULL 08/13] target/arm: Pull Thumb insn word loads up to top level

2017-12-11 Thread Peter Maydell
On 10 December 2017 at 18:24, Peter Maydell wrote: > On 8 December 2017 at 23:09, Emilio G. Cota wrote: >> On Thu, Oct 12, 2017 at 17:03:31 +0100, Peter Maydell wrote: >>> Refactor the Thumb decode to do the loads of the instruction words at >>> the top

Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes

2017-12-11 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Type: series Message-id: 20171208005825.14587-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH v7 for-2.12 05/25] block: Respect backing bs in bdrv_refresh_filename

2017-12-11 Thread Alberto Garcia
On Mon 20 Nov 2017 09:09:44 PM CET, Max Reitz wrote: > Basically, bdrv_refresh_filename() should respect all children of a > BlockDriverState. However, generally those children are driver-specific, > so this function cannot handle the general case. On the other hand, > there are only few drivers

Re: [Qemu-devel] It told me to report this...

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 08:05:29AM -0700, Warner Losh wrote: > On Mon, Dec 11, 2017 at 5:33 AM, Daniel P. Berrange > wrote: > > > On Mon, Dec 11, 2017 at 12:29:36PM +, Dr. David Alan Gilbert wrote: > > > * Warner Losh (i...@bsdimp.com) wrote: > > > > unknown keycodes

[Qemu-devel] [PATCH v2 1/2] virtio-blk: make queue size configurable

2017-12-11 Thread Mark Kanda
Depending on the configuration, it can be beneficial to adjust the virtio-blk queue size to something other than the current default of 128. Add a new property to make the queue size configurable. Signed-off-by: Mark Kanda Reviewed-by: Karl Heubaum

[Qemu-devel] [PATCH v2 2/2] virtio-blk: reject configs with logical block size > physical block size

2017-12-11 Thread Mark Kanda
virtio-blk logical block size should never be larger than physical block size because it doesn't make sense to have such configurations. QEMU doesn't have a way to effectively express this condition; the best it can do is report the physical block exponent as 0 - indicating the logical block size

Re: [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions

2017-12-11 Thread Alex Bennée
no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: FWIW these are either: - misidentified "spaces prohibited around that ':' (ctx:WxW)" for bitfields - existing softfloat code that has moved - two lines

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 03:09 PM, Michael S. Tsirkin wrote: > On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: >> * I assume one request is supposed to correspond to one descriptor chain. >> Right? If yes, could you tell me, where is this expressed in the spec. >> >> Halil > > That's always

Re: [Qemu-devel] [PATCH 0/3] hyperv: hv msr initialization fixes

2017-12-11 Thread Paolo Bonzini
On 22/11/2017 19:14, Roman Kagan wrote: > These patches fix problems with hyperv msr initialization. > > Evgeny Yakovlev (1): > hyperv: set partition-wide MSRs only on first vcpu > > Roman Kagan (2): > hyperv: ensure SINTx msrs are reset properly > hyperv: make SynIC version msr constant >

Re: [Qemu-devel] [PATCH] x86/cpu: Enable new SSE/AVX/AVX512 cpu features

2017-12-11 Thread Paolo Bonzini
On 22/11/2017 08:27, Yang Zhong wrote: > Intel IceLake cpu has added new cpu features,AVX512_VBMI2/GFNI/ > VAES/VPCLMULQDQ/AVX512_VNNI/AVX512_BITALG. Those new cpu features > need expose to guest VM. > > The bit definition: > CPUID.(EAX=7,ECX=0):ECX[bit 06] AVX512_VBMI2 >

[Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v2 0/2] virtio-blk: miscellaneous changes

2017-12-11 Thread Mark Kanda
On 12/11/2017 4:30 AM, Stefan Hajnoczi wrote: Hi Mark, Please resend as a top level email thread so the continuous integration and patch management tools will detect your patch series. Apologies. I've just resent the series. Thanks, -Mark

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-12-11 Thread Corey Bryant
Regression testing has passed successfully. zesty-ocata-proposed with stable charms: == Totals == Ran: 102 tests in 1897.0150 sec. - Passed: 93 - Skipped: 9 - Expected Fail: 0 - Unexpected Success: 0 - Failed: 0 Sum of execute time for each test: 1011.5607 sec. zesty-ocata-proposed

Re: [Qemu-devel] [PATCH] target/i386: add CPU model "Skylake-Server-clflushopt"

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 09:33, Haozhong Zhang wrote: > The only difference from the existing CPU model "Skylake-Server" is > the add of CPUID_7_0_EBX_CLFLUSHOPT, which is missed in "Skylake-Server". > > Signed-off-by: Haozhong Zhang If all Skylake-Server CPUs have it, maybe we

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-12-11 Thread Paolo Bonzini
On 07/12/2017 16:06, Yang Zhong wrote: > Which show trim cost time less than 1ms and call_rcu_thread() do 10 times > batch free, the trim also 10 times. > > I also did below changes: > delta=1000, and > next_trim_time = qemu_clock_get_ns(QEMU_CLOCK_HOST) + delta * > last_trim_time

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread Max Reitz
On 2017-12-08 18:09, John Snow wrote: > > > On 12/08/2017 09:30 AM, Max Reitz wrote: >> On 2017-12-05 01:48, John Snow wrote: >>> >>> >>> On 12/04/2017 05:21 PM, Max Reitz wrote: On 2017-12-04 23:15, John Snow wrote: > > > On 12/01/2017 02:41 PM, Max Reitz wrote: >> ((By the

Re: [Qemu-devel] [PATCH for 2.12] target/i386: Fix compiler warnings

2017-12-11 Thread Paolo Bonzini
On 13/11/2017 07:48, Stefan Weil wrote: > These gcc warnings are fixed: > > target/i386/translate.c:4461:12: warning: > variable ‘prefixes’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered] > target/i386/translate.c:4466:9: warning: > variable ‘rex_w’ might be clobbered by ‘longjmp’ or

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> -void cpu_stop_current(void) > -{ > -if (current_cpu) { > -qemu_cpu_stop(current_cpu, true); > -} > -} Btw. this does not compile as this is used also in vl.c > - > int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
> atomic_mb_set can be a little faster on x86, so: > > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index dfba5ebd29..4452cd9856 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -528,12 +528,10 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, > >

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Richard Henderson
On 12/11/2017 07:42 AM, Peter Maydell wrote: > The refactoring of commit 296e5a0a6c3935 has a nasty bug: > it accidentally dropped the generation of code to raise > the UNDEF exception when disas_thumb2_insn() returns nonzero. > This means that 32-bit Thumb2 instruction patterns that > ought to

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 12:05 PM, Max Reitz wrote: > On 2017-12-11 17:47, John Snow wrote: >> On 12/11/2017 11:31 AM, Max Reitz wrote: >>> On 2017-12-08 18:09, John Snow wrote: On 12/08/2017 09:30 AM, Max Reitz wrote: > On 2017-12-05 01:48, John Snow wrote: >> >> I would say that a bitmap

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 17:00, Richard Henderson wrote: > On 12/11/2017 07:42 AM, Peter Maydell wrote: >> The refactoring of commit 296e5a0a6c3935 has a nasty bug: >> it accidentally dropped the generation of code to raise >> the UNDEF exception when disas_thumb2_insn() returns

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:45, George Kennedy wrote: > The LSI 53c895a code does not handle the PPR Extended Message. Add > support to handle PPR Extended Message like SDTR and WDTR are handled. > That is, to skip past the message bytes and ignore the message. > > --- >  hw/scsi/lsi53c895a.c | 4 >  1

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread Max Reitz
On 2017-12-11 17:47, John Snow wrote: > > > On 12/11/2017 11:31 AM, Max Reitz wrote: >> On 2017-12-08 18:09, John Snow wrote: >>> >>> >>> On 12/08/2017 09:30 AM, Max Reitz wrote: On 2017-12-05 01:48, John Snow wrote: > > > On 12/04/2017 05:21 PM, Max Reitz wrote: >> On

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:29 +0100 David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand > --- > hw/intc/s390_flic.c | 9 +++-- > hw/intc/s390_flic_kvm.c | 12

Re: [Qemu-devel] [PATCH-2.12 v2 2/3] xilinx_spips: Set all of the reset values

2017-12-11 Thread Alistair Francis
On Wed, Dec 6, 2017 at 3:39 PM, francisco iglesias wrote: > Hi Alistair, > > On 6 December 2017 at 23:22, Alistair Francis > wrote: >> >> Following the ZynqMP register spec let's ensure that all reset values >> are set. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:25PM +0800, Chao Gao wrote: > According to VT-d spec Interrupt Remapping and Interrupt Posting -> > Interrupt Remapping -> Interrupt Request Formats On Intel 64 > Platforms, fields of MSI data register have changed. This patch > avoids wrongly regarding a remappable

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-12-11 Thread Peter Maydell
On 26 November 2017 at 21:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. > > Signed-off-by: Brad Smith > > > diff --git

Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-12-11 Thread Anthony PERARD
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. > > Changes: > * use keycodedb to generate qcode to linux input

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
Thank you Paolo, "Signed-off-by: George Kennedy" George On 12/11/2017 11:55 AM, Paolo Bonzini wrote: On 11/12/2017 17:45, George Kennedy wrote: The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread Max Reitz
On 2017-12-09 02:36, John Snow wrote: > > > On 11/30/2017 08:23 AM, Max Reitz wrote: >> On 2017-11-30 04:18, Fam Zheng wrote: >>> On Thu, 11/23 03:08, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread John Snow
On 12/11/2017 12:17 PM, Max Reitz wrote: > On 2017-12-09 02:36, John Snow wrote: >> >> >> On 11/30/2017 08:23 AM, Max Reitz wrote: >>> On 2017-11-30 04:18, Fam Zheng wrote: On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- >

Re: [Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:24PM +0800, Chao Gao wrote: > Previously, some fields (reserved or unalterable) are filtered by > Qemu. This fields are useless for the legacy interrupt format. > However, these fields are may meaningful (for intel platform) > for the interrupt of remapping format. It

Re: [Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:34 +0100 David Hildenbrand wrote: > Use s390_cpu_virt_mem_write() so we can actually revert what we did > (re-inject the dequeued IO interrupt). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 1 + >

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:44, David Hildenbrand wrote: >> -void cpu_stop_current(void) >> -{ >> -if (current_cpu) { >> -qemu_cpu_stop(current_cpu, true); >> -} >> -} > Btw. this does not compile as this is used also in vl.c > Doh, then I'm applying your patch untouched. Paolo

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-12-11 Thread John Snow
On 12/11/2017 05:24 AM, Denis V. Lunev wrote: > On 11/28/2017 03:10 PM, Denis V. Lunev wrote: >> There are 2 cases I have spotted so far: >> 1) IDE ATAPI read processing. Actually this was reported from field >> 2) QEMU IO hmp command (found during evaluation of (1)) >> >> SCSI code checks

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread John Snow
On 12/11/2017 06:15 AM, Kevin Wolf wrote: > Am 09.12.2017 um 01:57 hat John Snow geschrieben: >> Here's an idea of what this API might look like without revealing >> explicit merge/split primitives. >> >> A new bitmap property that lets us set retention: >> >> :: block-dirty-bitmap-set-retention

Re: [Qemu-devel] [PATCH v4 4/4] ivshmem: Disable irqfd on device reset

2017-12-11 Thread Markus Armbruster
Ladi Prosek writes: > The effects of ivshmem_enable_irqfd() was not undone on device reset. > > This manifested as: > ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed. > > when irqfd was enabled before reset and then enabled again after reset, making

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Emilio G. Cota
On Mon, Dec 11, 2017 at 17:32:48 +, Peter Maydell wrote: > Thanks. I think I have come down on the side of putting this into > 2.11, so rolling an rc5 today, and delaying the final release > a day to Wednesday. Glad to see it's in -rc5 -- thanks for fixing this so quickly! Again, apologies

<    1   2   3   >