Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling

2018-02-02 Thread Claudio Imbrenda
On Fri, 2 Feb 2018 09:42:41 + Christian Borntraeger wrote: > commit 67915de9f038 ("s390x/event-facility: variable-length event > masks") switches the sclp receive/send mask. This broke the sclp > lm console. Reviewed-by: Claudio Imbrenda > Signed-off-by: Christian Borntraeger > Fixes: c

[Qemu-devel] [PATCH RFC 08/21] qapi: Touch generated files only when they change

2018-02-02 Thread Markus Armbruster
A massive number of objects depends on QAPI-generated headers. In my "build everything" tree, it's roughly 4500 out of 4800. This is particularly annoying when only some of the generated files change, say for a doc fix. Improve qapi-gen.py to touch its output files only if they actually change.

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2018-02-02 Thread Max Reitz
On 2018-02-02 13:07, Vladimir Sementsov-Ogievskiy wrote: > 29.01.2018 18:34, Max Reitz wrote: >> On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>   block/qcow2.h  |  7 +-- >>>   block/qcow2-refcount.c | 12

Re: [Qemu-devel] [PULL 0/2] Block patches

2018-02-02 Thread Peter Maydell
On 1 February 2018 at 04:06, Jeff Cody wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the git repository at: > > git://

[Qemu-devel] [PULL 3/3] ui: correctly advance output buffer when writing SASL data

2018-02-02 Thread Gerd Hoffmann
From: Daniel P. Berrangé In this previous commit: commit 8f61f1c5a6bc06438a1172efa80bc7606594fa07 Author: Daniel P. Berrange Date: Mon Dec 18 19:12:20 2017 + ui: track how much decoded data we consumed when doing SASL encoding I attempted to fix a flaw with tracking how much d

[Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h

2018-02-02 Thread Markus Armbruster
In my "build everything" tree, a change to the types in qapi-schema.json triggers a recompile of about 4500 out of 4800 objects. The previous commit split up the generated qapi-types.h. Replace includes of qapi-types.h (i.e. all types) by includes of parts where possible. To illustrate the benef

Re: [Qemu-devel] [PATCH v3 05/12] sdl: use DisplayOptions

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch sdl ui to use qapi DisplayOptions for configuration. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 8 > ui/sdl.c | 19 +-- > ui/sdl2.c| 33 +++-- >

Re: [Qemu-devel] [PATCH 2/2] tpm: wrap stX_be_p in tpm_cmd_set_XYZ functions

2018-02-02 Thread Marc-Andre Lureau
Hi On Fri, Feb 2, 2018 at 12:23 AM, Stefan Berger wrote: > Wrap the calls to stl_be_p and stw_be_p in tpm_cmd_set_XYZ functions > that are similar to existing getters. why not, Reviewed-by: Marc-André Lureau > > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_util.c | 6 +++--- > hw/tpm/t

Re: [Qemu-devel] [PATCH v3 06/12] vl: drop no_quit variable

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Not used any more, delete it. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/vl.c b/vl.c > @@ -4368,7 +4364,8 @@ int main(int argc, char **argv, char **envp) >

Re: [Qemu-devel] [PATCH v3 11/12] vl: drop request_opengl variable

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch over the one leftover user to qapi DisplayType. > The delete the unused request_opengl variable. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > > -if (request_opengl ==

[Qemu-devel] [PATCH RFC 15/21] qapi: Record 'include' directives in intermediate representation

2018-02-02 Thread Markus Armbruster
The include directive permits modular QAPI schemata, but the generated code is monolithic all the same. To permit generating modular code, the front end needs to pass more information on inclusions to the back ends. The commit before last added the necessary information to the parse tree. This c

Re: [Qemu-devel] [PATCH v3 07/12] egl-headless: use DisplayOptions

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch egl-headless ui to use qapi DisplayOptions for configuration. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 2 +- > ui/egl-headless.c| 2 +- > vl.c | 3 ++- > qapi/ui.json | 5 +++-- > 4 files cha

Re: [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2018-02-02 Thread Max Reitz
On 2018-02-02 14:37, Max Reitz wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a/qemu-img

[Qemu-devel] [PATCH RFC 11/21] qapi: Lift error reporting from QAPISchema.__init__() to callers

2018-02-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi-gen.py| 8 ++-- scripts/qapi/common.py | 23 +-- tests/qapi-schema/test-qapi.py | 8 +++- 3 files changed, 22 insertions(+), 17 deletions(-) diff --git a/scripts/qapi-gen.py b/scripts/qapi-gen.py

[Qemu-devel] [PULL 2/3] ui: convert VNC server to QIONetListener

2018-02-02 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC server already has the ability to listen on multiple sockets. Converting it to use the QIONetListener APIs though, will reduce the amount of code in the VNC server and improve the clarity of what is left. Signed-off-by: Daniel P. Berrange Message-id: 201802011

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Marcel Apfelbaum
On 02/02/2018 11:56, Peter Xu wrote: > On Thu, Feb 01, 2018 at 07:51:31PM +, Dr. David Alan Gilbert wrote: >> * Peter Xu (pet...@redhat.com) wrote: >>> In the past, we prioritized IOMMU migration so that we have such a >>> priority order: >>> >>> IOMMU > PCI Devices >>> >>> When migrating a

[Qemu-devel] [PULL 0/1] Vga 20180202 patches

2018-02-02 Thread Gerd Hoffmann
The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20180202-pull-reques

[Qemu-devel] [PATCH RFC 17/21] qapi/types qapi/visit: Generate built-in stuff into separate files

2018-02-02 Thread Markus Armbruster
Linking code from multiple separate QAPI schemata into the same program is possible, but involves some weirdness around built-in types: * We generate code for built-in types into .c only with option --builtins. The user is responsible to generate code for exactly one QAPI schema per program w

Re: [Qemu-devel] [PATCH v1] ui: correctly advance output buffer when writing SASL data

2018-02-02 Thread Gerd Hoffmann
On Thu, Feb 01, 2018 at 10:03:23AM -0600, Eric Blake wrote: > On 02/01/2018 09:58 AM, Daniel P. Berrangé wrote: > > In this previous commit: > > > > commit 8f61f1c5a6bc06438a1172efa80bc7606594fa07 > > Author: Daniel P. Berrange > > Date: Mon Dec 18 19:12:20 2017 + > > > > ui: tra

[Qemu-devel] [PULL 0/3] Ui 20180202 patches

2018-02-02 Thread Gerd Hoffmann
The following changes since commit 11ed801d3df3c6e46b2f1f97dcfbf4ca3a2a2f4f: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2018-01-30 09:47:51 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180202-pu

Re: [Qemu-devel] [PATCH v6 13/23] hmp: display memory encryption support in 'info kvm'

2018-02-02 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 08:04:43PM +, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.si...@amd.com) wrote: > > > > > > On 2/1/18 11:58 AM, Dr. David Alan Gilbert wrote: > > > * Brijesh Singh (brijesh.si...@amd.com) wrote: > > >> update 'info kvm' to display the memory encryption sup

[Qemu-devel] [PATCH RFC 18/21] qapi/common: Fix guardname() for funny filenames

2018-02-02 Thread Markus Armbruster
guardname() fails to return a valid C identifier for arguments containing anything but [A-Za-z0-9_.-']. Fix that. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index

[Qemu-devel] [PULL v2 09/10] tests: virtio-9p: add FLUSH operation test

2018-02-02 Thread Greg Kurz
The idea is to send a victim request that will possibly block in the server and to send a flush request to cancel the victim request. This patch adds two test to verifiy that: - the server does not reply to a victim request that was actually cancelled - the server replies to the flush request af

Re: [Qemu-devel] [PATCH v3 04/12] gtk: add and use DisplayOptions + DisplayGTK

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Add QAPI DisplayType enum, DisplayOptions union and DisplayGTK struct. > Switch gtk configuration to use the qapi type. > > Some bookkeeping (fullscreen for example) is done twice now, this is > temporary until more/all UIs are switched over to qapi c

Re: [Qemu-devel] [PATCH v2] tap: close fd conditionally when error occured

2018-02-02 Thread Jay Zhou
Hi Jason, On 2018/2/2 14:56, Jason Wang wrote: On 2018年02月02日 11:53, Jay Zhou wrote: Hi Jason, On 2018/2/2 11:11, Jason Wang wrote: On 2018年01月26日 11:08, Jay Zhou wrote: If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=

[Qemu-devel] [PULL v2 07/10] tests: virtio-9p: add WRITE operation test

2018-02-02 Thread Greg Kurz
Trivial test of a successful write. Signed-off-by: Greg Kurz (groug, handle potential overflow when computing request size, add missing g_free(buf), backend handles one written byte at a time to validate the server doesn't do short-reads) Reviewed-by: Stefan Hajnoczi ---

Re: [Qemu-devel] Qemu Trace

2018-02-02 Thread Peter Maydell
On 2 February 2018 at 10:08, Stefan Hajnoczi wrote: > On Thu, Feb 01, 2018 at 04:30:10PM +0100, Nesrine Zouari wrote: >> I am a computer engineering student and I am actually working on my >> graduation project at Lauterbach company. The project is about Qemu Trace >> and as a future I would like

[Qemu-devel] [PATCH RFC 16/21] qapi/types qapi/visit: Make visitors use QAPIGen more

2018-02-02 Thread Markus Armbruster
The conversion is rather shallow so far: most of the output accumulation is not converted. Take the next step: convert output accumulation in QAPISchemaGenTypeVisitor and QAPISchemaGenVisitVisitor. Helper functions outside these classes are not converted. Signed-off-by: Markus Armbruster --- s

[Qemu-devel] [PULL v2 02/10] 9pfs: Correctly handle cancelled requests

2018-02-02 Thread Greg Kurz
From: Keno Fischer # Background I was investigating spurious non-deterministic EINTR returns from various 9p file system operations in a Linux guest served from the qemu 9p server. ## EINTR, ERESTARTSYS and the linux kernel When a signal arrives that the Linux kernel needs to deliver to user-

Re: [Qemu-devel] Qemu Trace

2018-02-02 Thread Nesrine Zouari
Hello Mr. Stefan, Thank you for your response. To answer your question : the trace solution should be architecture independent.This is the best for us. We aim to test it at least for ARM/ARM64 , x86 and x64 architectures. But even if there will be some differences , we can accept it. Regards, O

[Qemu-devel] [PULL v2 06/10] tests: virtio-9p: add LOPEN operation test

2018-02-02 Thread Greg Kurz
Trivial test of a successful open. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi --- hw/9pfs/9p-synth.c | 5 + hw/9pfs/9p-synth.h | 1 + tests/virtio-9p-test.c | 47 +++ 3 files changed, 53 insertions(+) diff --git a/hw/9pfs/9p-

[Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules

2018-02-02 Thread Markus Armbruster
The next commit will introduce a common driver program for all generators. The generators need to be modules for that. qapi2texi.py already is. Make the other generators follow suit. The changes are actually trivial. Obvious in the diffs once you view them with whitespace changes ignored. Sig

Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > These classes encapsulate accumulating and writing output. > > Convert C code generation to QAPIGenC and QAPIGenH. The conversion is > rather shallow: most of the output accumulation is not converted. > Left for later. > > The indentation machin

Re: [Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Each generator carries a copyright notice for the generator itself, > and another one for the files it generates. Only the former have been > updated along the way, the latter have not, and are all out of date. > > Fix by copying the generator's

[Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs

2018-02-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 6c6962a364..78e960d07c 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -1457,13 +1457,1

Re: [Qemu-devel] [PATCH v2] tap: close fd conditionally when error occured

2018-02-02 Thread Jason Wang
On 2018年02月02日 11:53, Jay Zhou wrote: Hi Jason, On 2018/2/2 11:11, Jason Wang wrote: On 2018年01月26日 11:08, Jay Zhou wrote: If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=net0 will fail too, prints:    TUNSETOFFLOAD ioc

Re: [Qemu-devel] [PATCH v3 09/12] cocoa: use DisplayOptions

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch cocoa ui to use qapi DisplayOptions for configuration. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 4 ++-- > vl.c | 3 ++- > qapi/ui.json | 6 -- > ui/cocoa.m | 4 ++-- > 4 files chang

Re: [Qemu-devel] [PATCH v3 08/12] curses: use DisplayOptions

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch curses ui to use qapi DisplayOptions for configuration. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 4 ++-- > ui/curses.c | 2 +- > vl.c | 4 +++- > qapi/ui.json | 5 +++-- > 4 files change

Re: [Qemu-devel] [PATCH v3 12/12] vl: drop display_type variable

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch over all leftover users to qapi DisplayType. > Then delete the unused display_type variable. > > Add 'default' DisplayType, which isn't an actual display type but > a placeholder for "user didn't specify a display". It will be replaced > by th

[Qemu-devel] [Bug 1703795] [PATCH] sdl2: fix mouse grab

2018-02-02 Thread Gerd Hoffmann
When qemu mouse mode changes from relative to absolute we must turn off sdl relative mouse mode too. Fixes: https://bugs.launchpad.net/qemu/+bug/1703795 Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 812c315891..858e04d7

[Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
To maintain load/store disabled bitmap there is new approach: - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored - store enabled bitmaps as "auto" to qcow2 - store disabled bitmaps without "auto" flag to qcow2 - on qcow2 open load "auto" bitmaps as enabled and others as d

[Qemu-devel] [PATCH v2] vnc: use stubs for CONFIG_VNC=n dummy functions

2018-02-02 Thread Gerd Hoffmann
Cc: Paolo Bonzini Cc: Markus Armbruster Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 21 - ui/vnc-stubs.c | 21 + ui/Makefile.objs | 1 + 3 files changed, 22 insertions(+), 21 deletions(-) create mode 100644 ui/vnc-stubs.c diff --g

[Qemu-devel] [Bug 1703795] Re: Unable to release mouse in SDL2 mode

2018-02-02 Thread Gerd Hoffmann
workaround: don't click into the guest window before the tablet driver loads. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1703795 Title: Unable to release mouse in SDL2 mode Status in QEMU: Ne

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > Hi Peter, > > On 01/02/2018 13:20, Peter Xu wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pc

[Qemu-devel] [Bug 1746943] [NEW] qemu-aarch64-static: qemu: uncaught target signal 11 for ps/top cmd

2018-02-02 Thread cee1
Public bug reported: In a docker container created from an aarch64 image, injects qemu-aarch64-static (in /usr/bin) run ps/top cmd inside this container reports "qemu: uncaught target signal 11 (Segmentation fault)" Tried qemu-aarch64-static from fedora 27 / ubuntu artful / debian unstable

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
22.01.2018 22:56, John Snow wrote: On 01/22/2018 02:51 PM, Eric Blake wrote: On 01/22/2018 03:09 AM, Vladimir Sementsov-Ogievskiy wrote: I have to admit exposing this interface still makes me nervous, but :) Mechanically correct, and with suggesting phrasing changes: Reviewed-by: John Snow

[Qemu-devel] [PULL v2 08/10] libqos/virtio: return length written into used descriptor

2018-02-02 Thread Greg Kurz
When a 9p request is flushed (ie, cancelled) by the guest, the device is expected to simply mark the request as used, without sending a 9p reply (ie, without writing anything into the used buffer). To be able to test this, we need access to the length written by the device into the used descriptor

[Qemu-devel] [PULL v2 04/10] tests: virtio-9p: wait for completion in the test code

2018-02-02 Thread Greg Kurz
In order to test request cancellation, we will need to send multiple requests and wait for the associated replies. Since we poll the ISR to know if a request completed, we may have several replies to parse when we detect ISR was set to 1. This patch moves the waiting out of the reply parsing path,

Re: [Qemu-devel] [PULL 17/51] readline: add a free function

2018-02-02 Thread Greg Kurz
On Thu, 1 Feb 2018 19:10:06 -0500 Paolo Bonzini wrote: > On 01/02/2018 19:00, Alex Williamson wrote: > > On Tue, 16 Jan 2018 15:16:59 +0100 > > Paolo Bonzini wrote: > > > >> From: Marc-André Lureau > >> > >> Fixes leaks such as: > >> > >> Direct leak of 2 byte(s) in 1 object(s) allocated fro

Re: [Qemu-devel] [PATCH RFC 04/21] qapi: Reduce use of global variables in generators some

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > In preparation of the next commit, which will turn the generators into > modules. These global variables will become local to main() then. > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software En

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-02 Thread Eric Blake
On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: > To maintain load/store disabled bitmap there is new approach: > > - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored > - store enabled bitmaps as "auto" to qcow2 > - store disabled bitmaps without "auto" flag to qc

Re: [Qemu-devel] [PATCH v3 10/12] vl: drop full_screen variable

2018-02-02 Thread Eric Blake
On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Not used any more, delete it. > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu

Re: [Qemu-devel] [PULL 0/2] Audio 20180202 patches

2018-02-02 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/audio-20180202-pull-request > > for you to fetch changes up to 8ec660b80ed511fa333679e38bf0cf714799d6fa: > > hw/audio/sb16.c: change dolog() to qemu_log_mask() (2018-02-02 08:19:47 > +0100) > > -

Re: [Qemu-devel] [PATCH 1/2] qcow2: add overlap check for bitmap directory

2018-02-02 Thread Max Reitz
On 2018-02-02 14:48, Vladimir Sementsov-Ogievskiy wrote: > 02.02.2018 16:00, Max Reitz wrote: >> On 2018-02-02 13:07, Vladimir Sementsov-Ogievskiy wrote: >>> 29.01.2018 18:34, Max Reitz wrote: On 2017-11-30 17:47, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogie

[Qemu-devel] [PULL v2 10/10] tests/virtio-9p: explicitly handle potential integer overflows

2018-02-02 Thread Greg Kurz
Signed-off-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- tests/virtio-9p-test.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c index 0d3334a6ce17..54edcb995542 100644

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

2018-02-02 Thread Fam Zheng
On Thu, Feb 1, 2018 at 6:46 PM, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote: >> Hi >> >> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: >> > git-publish [1] is a convenient tool to send patches and has been >> > popular among QEMU developers. Rec

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-02 Thread Vladimir Sementsov-Ogievskiy
02.02.2018 19:18, Eric Blake wrote: On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: To maintain load/store disabled bitmap there is new approach: - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored - store enabled bitmaps as "auto" to qcow2 - store disabled b

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Eric Blake
On 02/02/2018 09:25 AM, Eduardo Habkost wrote: >>> Markus, Eric: from the QAPI point of view, is it OK to remove >>> fields between QEMU versions, as long as we follow our >>> deprecation policy? >> >> I would expect that to not be OK. A fully backwards compatible way to >> deal with this would j

[Qemu-devel] [PULL 1/1] virtio-gpu: disallow vIOMMU

2018-02-02 Thread Gerd Hoffmann
From: Peter Xu virtio-gpu has special code path that bypassed vIOMMU protection. So for now let's disable iommu_platform for the device until we fully support that (if needed). After the patch, both virtio-vga and virtio-gpu won't allow to boot with iommu_platform parameter set. CC: Gerd Hoffm

[Qemu-devel] [PULL v2 01/10] 9pfs: drop v9fs_register_transport()

2018-02-02 Thread Greg Kurz
No good reasons to do this outside of v9fs_device_realize_common(). Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini --- hw/9pfs/9p.c | 6 +- hw/9pfs/9p.h | 10 ++ hw/9pfs/virtio-9p-device.c | 8 ++-- hw/9pfs/xen-9p-backend.c | 3 +-- 4 f

[Qemu-devel] [PATCH v3 0/1] respin of s390 crash information

2018-02-02 Thread Christian Borntraeger
This patch - originally from Jing Liu - was still on my disk and somehow dropped of my attention. Here is a fixed up version. It probably still needs some review and polish. One open aspect is migration. Right now QEMU switches from crashed back into running state after migration (even without thi

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-02 Thread Max Reitz
On 2018-02-02 17:18, Eric Blake wrote: > On 02/02/2018 10:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> To maintain load/store disabled bitmap there is new approach: >> >> - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored >> - store enabled bitmaps as "auto" to qcow2 >> - sto

Re: [Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input

2018-02-02 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 06:46:46PM -0200, Eduardo Habkost wrote: > On Tue, Jan 16, 2018 at 01:42:14PM +, Daniel P. Berrange wrote: > > From: Miika S > > > > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > > > Signed-off-by: Miika S > > Oops, this conflicts with:

Re: [Qemu-devel] [PULL v2 00/10] 9p patches for 2.12 20180202

2018-02-02 Thread Peter Maydell
On 2 February 2018 at 16:19, Greg Kurz wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the git repository at: > > https:

[Qemu-devel] [PULL v2 00/10] 9p patches for 2.12 20180202

2018-02-02 Thread Greg Kurz
The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you to fe

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > (CCing qemu-devel) > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > On Fri, 2 Feb 2018 14:19:38 + > > Daniel P. Berrangé wrote: > > > On Fri, Feb 02, 2018 at 12:15:54PM -0200, Eduardo Habkost wrote: > [...] > > > > It wo

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

2018-02-02 Thread Daniel P . Berrangé
On Fri, Feb 02, 2018 at 02:03:15PM +0100, Markus Armbruster wrote: > Our qapi-schema.json is composed of modules connected by include > directives, but the generated code is monolithic all the same: one > qapi-types.h with all the types, one qapi-visit.h with all the > visitors, and so forth. Thes

Re: [Qemu-devel] [PATCH] tests/migration: Add source to PC boot block

2018-02-02 Thread Wei Huang
On 01/31/2018 02:16 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The boot block used in the migration test is currently only > shipped as a hex (with the source in the git commit message), > change this to actually include the source. > > A makefile rule is adde

[Qemu-devel] [PATCH v3 1/1] s390x/cpu: expose the guest crash information

2018-02-02 Thread Christian Borntraeger
This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the most important one, since this is used by all s390 guests

Re: [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules

2018-02-02 Thread Eric Blake
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > The next commit will introduce a common driver program for all > generators. The generators need to be modules for that. qapi2texi.py > already is. Make the other generators follow suit. > > The changes are actually trivial. Obvious in the dif

Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2018-02-02 Thread Max Reitz
On 2017-12-04 19:25, Max Reitz wrote: > On 2017-12-04 17:37, Alberto Garcia wrote: >> On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: >>> -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) >>> +static void blkdebug_refresh_filename(BlockDriverState *bs) >>> { >>>

[Qemu-devel] [PATCH v3] tap: close fd conditionally when error occured

2018-02-02 Thread Jay Zhou
If netdev_add tap,id=net0,...,vhost=on failed in net_init_tap_one(), the followed up device_add virtio-net-pci,netdev=net0 will fail too, prints: TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLOAD ioctl() failed: Bad file descriptor The reason is that the fd of tap is closed wh

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

2018-02-02 Thread Fam Zheng
On Wed, Jan 31, 2018 at 6:06 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: >> git-publish [1] is a convenient tool to send patches and has been >> popular among QEMU developers. Recently it has been made available in >> Fedora official repo thanks to Ste

[Qemu-devel] [PULL v2 03/10] tests: virtio-9p: move request tag to the test functions

2018-02-02 Thread Greg Kurz
It doesn't really makes sense to hide the request tag from the test functions. It prevents to test the 9p server behavior when passed a wrong tag (ie, still in use or different from P9_NOTAG for a version request). Also the spec says that a tag is reusable as soon as the corresponding request was r

Re: [Qemu-devel] [PATCH 4/6] target/arm: Add "-cpu max" support

2018-02-02 Thread Peter Maydell
On 26 January 2018 at 15:44, Philippe Mathieu-Daudé wrote: > On 01/26/2018 11:33 AM, Peter Maydell wrote: >> On 26 January 2018 at 14:29, Philippe Mathieu-Daudé wrote: >>> Why not use arm_any_initfn() here? >> >> That function (and the 'any' cpu) are deliberately only >> included in the linux-use

[Qemu-devel] rate limiting issues

2018-02-02 Thread Wolfgang Bumiller
Summary: Rate limit is effectively halved when the size of written chunks adds up to exceeding the quota of a slice only slightly. This is surprisingly reliable. Explanation: The ratelimiting code in include/qemu/ratelimit.h currently uses slices with quotas. Finishing up the quota for one slice m

Re: [Qemu-devel] [PATCH v5 1/6] machine: Convert the valid cpu types to use cpu_model

2018-02-02 Thread Eduardo Habkost
On Thu, Feb 01, 2018 at 04:42:05PM -0800, Alistair Francis wrote: > As cpu_type is not a user visible string let's convert the > valid_cpu_types to compare against cpu_model instead. This way we have a > user friendly string to report back. > > Once we have a cpu_type to cpu_model conversion this

[Qemu-devel] [PULL v2 05/10] tests: virtio-9p: use the synth backend

2018-02-02 Thread Greg Kurz
The purpose of virtio-9p-test is to test the virtio-9p device, especially the 9p server state machine. We don't really care what fsdev backend we're using. Moreover, if we want to be able to test the flush request or a device reset with in-flights I/O, it is close to impossible to achieve with a ph

Re: [Qemu-devel] [PULL 0/3] Ui 20180202 patches

2018-02-02 Thread Daniel P . Berrangé
t' > > into staging (2018-01-30 09:47:51 +) > > > > are available in the git repository at: > > > > git://git.kraxel.org/qemu tags/ui-20180202-pull-request > > > > for you to fetch changes up to 627ebec208a8809818589e17f4fce55a59420ad2: > >

[Qemu-devel] [PATCH v7 06/15] hw/moxie: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [Bug 1747056] [NEW] FreeDOS / MS-Dos / Windows 3.11 cannot perform reboot with 'isapc' machine

2018-02-02 Thread Daniel Berrange
Public bug reported: I was installing MS-Dos 6.22 + Windows 3.11 in preparation for running Microsoft Bob, and noticed that when they try to perform a reboot, they just get stuck. The console cursor stays flashing on/off, but the DOS prompt no longer responds to input. It is fairly easy to reprod

[Qemu-devel] [PATCH v7 00/15] Remove some of the fprintf(stderr, "*

2018-02-02 Thread Markus Armbruster
This is my attempt to salvage a good part of Alistair's error reporting cleanup series [PATCH v6 00/29] Remove some of the fprintf(stderr, "* Continue on improving QEMUs logging/error messages by removing more fprintf()'s. Unfortunatley my Coccinelle skills aren't that great so

[Qemu-devel] [PATCH v7 04/15] hw/lm32: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 14/15] tcg: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code

2018-02-02 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180202130336.24719-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH RFC 00/21] Modulariz

Re: [Qemu-devel] [RFC] kvm: x86: export vCPU halted state to sysfs

2018-02-02 Thread Eduardo Habkost
On Fri, Feb 02, 2018 at 05:23:59PM +, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > (CCing qemu-devel) > > > > On Fri, Feb 02, 2018 at 09:21:59AM -0500, Luiz Capitulino wrote: > > > On Fri, 2 Feb 2018 14:19:38 + > > > Daniel P. Berrangé wrote: > > > >

[Qemu-devel] [PATCH v7 12/15] hw/timer: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 01/15] audio: Replace AUDIO_FUNC with __func__

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Apparently we don't use __MSC_VER as a compiler anymore and we always require a C99 compiler (which means we always have __func__) so we don't need a special AUDIO_FUNC macro. We can just replace AUDIO_FUNC with __func__ instead. Checkpatch failures were manually fixed. S

[Qemu-devel] [PATCH v7 07/15] hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 05/15] hw/mips: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

Re: [Qemu-devel] [PULL 0/3] Ui 20180202 patches

2018-02-02 Thread Eric Blake
ble in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20180202-pull-request > > for you to fetch changes up to 627ebec208a8809818589e17f4fce55a59420ad2: > > ui: correctly advance output buffer when w

[Qemu-devel] [PATCH v7 08/15] hw/pci*: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 15/15] target: Use qemu_log() instead of fprintf(stderr, ...)

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Convert fprintf(stderr, ...) to use qemu_log(). Double prints in target/ppc/translate.c were manually remove. A fprintf() in target/sh4/translate.c was kept as it's inside a #if 0. The #if 0 and fflush() was removed around the unimplemented log in target/sh4/translate.c as

Re: [Qemu-devel] [PULL 0/1] Vga 20180202 patches

2018-02-02 Thread Peter Maydell
ble in the git repository at: > > git://git.kraxel.org/qemu tags/vga-20180202-pull-request > > for you to fetch changes up to 34e304e97576a9e17680c868c00ff524a981007b: > > virtio-gpu: disallow vIOMMU (2018-02-02 08:53:22 +0100) > > --

[Qemu-devel] [PATCH] mailmap: set preferred spelling for Daniel Berrangé

2018-02-02 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .mailmap | 4 1 file changed, 4 insertions(+) diff --git a/.mailmap b/.mailmap index ee81ac801e..cf689b9ec9 100644 --- a/.mailmap +++ b/.mailmap @@ -18,3 +18,7 @@ malc malc # There is also a: #(no author) <(no author)@c046a42c-6fe2-441c-8c8c-71

[Qemu-devel] [PATCH v7 09/15] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 11/15] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 10/15] hw/sd: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 13/15] hw/xen*: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[Qemu-devel] [PATCH v7 03/15] hw/dma: Replace fprintf(stderr, "*\n" with error_report()

2018-02-02 Thread Markus Armbruster
From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

<    1   2   3   >