[Qemu-devel] [PATCH v3 07/16] block/mirror: Wait for in-flight op conflicts

2018-02-28 Thread Max Reitz
This patch makes the mirror code differentiate between simply waiting for any operation to complete (mirror_wait_for_free_in_flight_slot()) and specifically waiting for all operations touching a certain range of the virtual disk to complete (mirror_wait_on_conflicts()). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v3 08/16] block/mirror: Use source as a BdrvChild

2018-02-28 Thread Max Reitz
With this, the mirror_top_bs is no longer just a technically required node in the BDS graph but actually represents the block job operation. Also, drop MirrorBlockJob.source, as we can reach it through mirror_top_bs->backing. Signed-off-by: Max Reitz --- block/mirror.c | 14

[Qemu-devel] [PATCH v3 15/16] block/mirror: Add copy mode QAPI interface

2018-02-28 Thread Max Reitz
This patch allows the user to specify whether to use active or only background mode for mirror block jobs. Currently, this setting will remain constant for the duration of the entire block job. Signed-off-by: Max Reitz --- qapi/block-core.json | 11 +--

Re: [Qemu-devel] [PATCH v2 1/5] target/i386: Fix a minor typo found while reviwing

2018-02-28 Thread Eric Blake
On 02/28/2018 11:38 AM, Radim Krčmář wrote: 2018-02-23 21:30-0500, Babu Moger: In the subject line: s/reviwing/reviewing/ [It's never a good sign when a fix claiming to fix a typo introduces a typo ;) ] Or go for a shorter subject: target/i386: Fix a minor typo Changed

Re: [Qemu-devel] [Qemu-block] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-28 Thread Eric Blake
On 02/28/2018 01:20 PM, John Snow wrote: +if (!backup->has_manual) { +backup->manual = false; +} I think this is unnecessary these days, NULL/0/false is the default value for QMP/QAPI. That's what I get for cargo cult. Eric, confirm/deny? Should I remove the other

[Qemu-devel] [PATCH v3 08/16] target/arm: Decode aa32 armv8.1 two reg and a scalar

2018-02-28 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/translate.c | 46 ++ 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/target/arm/translate.c

[Qemu-devel] [PATCH v3 16/16] target/arm: Enable ARM_FEATURE_V8_FCMA

2018-02-28 Thread Richard Henderson
Enable it for the "any" CPU used by *-linux-user. Signed-off-by: Richard Henderson --- target/arm/cpu.c | 1 + target/arm/cpu64.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index ca5fb1162a..452bc32f10 100644 ---

[Qemu-devel] [PATCH v3 15/16] target/arm: Decode t32 simd 3reg and 2reg_scalar extension

2018-02-28 Thread Richard Henderson
Happily, the bits are in the same places compared to a32. Signed-off-by: Richard Henderson --- target/arm/translate.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCHv3 08/12] openpic: move KVM-specific declarations into separate openpic_kvm.h file

2018-02-28 Thread Mark Cave-Ayland
This is needed before the next patch because the target-dependent kvm stub uses the existing kvm_openpic_connect_vcpu() declaration, making it impossible to move the device-specific declarations into the same file without breaking ppc-linux-user compilation. Signed-off-by: Mark Cave-Ayland

[Qemu-devel] [PATCH 4/5] vfio: Update linux header

2018-02-28 Thread Alex Williamson
Update with proposed ioeventfd API. Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index

[Qemu-devel] [PATCH 2/5] vfio/quirks: Add quirk reset callback

2018-02-28 Thread Alex Williamson
Quirks can be self modifying, provide a hook to allow them to cleanup on device reset if desired. Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 15 +++ hw/vfio/pci.c|2 ++ hw/vfio/pci.h|2 ++ 3 files changed, 19

Re: [Qemu-devel] [PATCH 03/16] tcg: track TBs with per-region BST's

2018-02-28 Thread Richard Henderson
On 02/26/2018 09:39 PM, Emilio G. Cota wrote: > This paves the way for enabling scalable parallel generation of TCG code. > > Instead of tracking TBs with a single binary search tree (BST), use a > BST for each TCG region, protecting it with a lock. This is as scalable > as it gets, since each

[Qemu-devel] [PATCH v3 11/16] test-hbitmap: Add non-advancing iter_next tests

2018-02-28 Thread Max Reitz
Add a function that wraps hbitmap_iter_next() and always calls it in non-advancing mode first, and in advancing mode next. The result should always be the same. By using this function everywhere we called hbitmap_iter_next() before, we should get good test coverage for non-advancing

[Qemu-devel] [PATCH v3 14/16] block/mirror: Add active mirroring

2018-02-28 Thread Max Reitz
This patch implements active synchronous mirroring. In active mode, the passive mechanism will still be in place and is used to copy all initially dirty clusters off the source disk; but every write request will write data both to the source and the target disk, so the source cannot be dirtied

Re: [Qemu-devel] [PATCH 02/16] qht: return existing entry when qht_insert fails

2018-02-28 Thread Richard Henderson
On 02/26/2018 09:39 PM, Emilio G. Cota wrote: > The meaning of "existing" is now changed to "matches in hash and > ht->cmp result". This is saner than just checking the pointer value. > > Note that we now return NULL on insertion success, or the existing > pointer on failure. We can do this

[Qemu-devel] [PATCH v3 04/16] target/arm: Decode aa64 armv8.1 scalar three same extra

2018-02-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.h| 4 ++ target/arm/translate-a64.c | 84 ++ target/arm/vec_helper.c| 109

[Qemu-devel] [PATCH v3 05/16] target/arm: Decode aa64 armv8.1 three same extra

2018-02-28 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.h| 9 + target/arm/translate-a64.c | 83 ++ target/arm/vec_helper.c| 74

[Qemu-devel] [PATCH v3 03/16] target/arm: Refactor disas_simd_indexed size checks

2018-02-28 Thread Richard Henderson
The integer size check was already outside of the opcode switch; move the floating-point size check outside as well. Unify the size vs index adjustment between fp and integer paths. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 65

Re: [Qemu-devel] [PATCH v3 01/29] migrate: Update ram_block_discard_range for shared

2018-02-28 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Feb 16, 2018 at 01:15:57PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The choice of call to discard a block is getting more complicated > > for other cases. We use fallocate

Re: [Qemu-devel] [RFC] qemu-img: Drop BLK_ZERO from convert

2018-02-28 Thread Max Reitz
On 2018-02-28 21:11, Max Reitz wrote: > On 2018-02-28 19:08, Max Reitz wrote: [...] > In any case it's interesting to see that even the current qemu-img > convert takes longer to read sparsely allocated qcow2/raw files from xfs > than fully allocated images... (That's because I didn't drop the

[Qemu-devel] [PATCHv3 04/12] heathrow: convert to trace-events

2018-02-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/intc/heathrow_pic.c | 32 +++- hw/intc/trace-events | 5 + 2 files changed, 16 insertions(+), 21 deletions(-) diff --git a/hw/intc/heathrow_pic.c b/hw/intc/heathrow_pic.c index

[Qemu-devel] [PATCHv3 03/12] heathrow: QOMify heathrow PIC

2018-02-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/intc/heathrow_pic.c | 126 +++-- include/hw/intc/heathrow_pic.h | 49 2 files changed, 119 insertions(+), 56 deletions(-) create mode 100644

[Qemu-devel] [PATCHv3 06/12] macio: move macio related structures and defines into separate macio.h file

2018-02-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/macio/macio.c | 43 + hw/ppc/mac.h | 3 --

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission

2018-02-28 Thread Michael Clark
On Thu, Mar 1, 2018 at 12:53 AM, Peter Maydell wrote: > On 28 February 2018 at 00:09, Michael Clark wrote: > > I've just talked to SiFive about this. They have agreed that we can > remove > > the sifive_e300 and sifive_u500 boards from the patch series

[Qemu-devel] [PATCHv3 12/12] macio: remove macio_init() function

2018-02-28 Thread Mark Cave-Ayland
Move the remaining comment into macio.c for reference, then remove the macio_init() function and instantiate the macio devices for both Old World and New World machines via qdev_init_nofail() directly. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 11

[Qemu-devel] [PATCH 1/5] vfio/quirks: Add common quirk alloc helper

2018-02-28 Thread Alex Williamson
This will later be used to include list initialization. Reviewed-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 48 +--- 1 file changed, 21 insertions(+), 27 deletions(-)

[Qemu-devel] [PATCH 07/11] linux-user: fix target_mprotect/target_munmap error return values

2018-02-28 Thread Max Filippov
target_mprotect/target_munmap return value goes through get_errno at the call site, thus the functions must either set errno to host error code and return -1 or return negative guest error code. Do the latter. Cc: qemu-sta...@nongnu.org Cc: Riku Voipio Cc: Laurent Vivier

[Qemu-devel] tcg/i386: Add vector operations patch does not compile on Mac OS 10.6

2018-02-28 Thread Programmingkid
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04321.html This patch causes problems with Mac OS 10.6. It stops compilation. This is the error I see when I try to compile the code: tcg/i386/tcg-target.inc.c:3495:no such instruction: `xgetbv` This is the code that causes the problem:

[Qemu-devel] [PATCH v3 16/16] iotests: Add test for active mirroring

2018-02-28 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/151 | 120 + tests/qemu-iotests/151.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 126 insertions(+) create mode 100755 tests/qemu-iotests/151 create mode

[Qemu-devel] [PATCH v2 3/4] virtio-scsi: fix race between .ioeventfd_stop() and vq handler

2018-02-28 Thread Stefan Hajnoczi
If the main loop thread invokes .ioeventfd_stop() just as the vq handler function begins in the IOThread then the handler may lose the race for the AioContext lock. By the time the vq handler is able to acquire the AioContext lock the ioeventfd has already been removed and the handler isn't

[Qemu-devel] [Bug 1751494] Re: tcg-target.inc.c:3495:no such instruction: `xgetbv'

2018-02-28 Thread John Arbuckle
** Summary changed: - tag-target.inc.c:3495:no such instruction: `xgetbv' + tcg-target.inc.c:3495:no such instruction: `xgetbv' -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1751494 Title:

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-28 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Expose the "manual" property via QAPI for the backup-related jobs. > As of this commit, this allows the management API to request the > "concluded" and "dismiss" semantics for backup jobs. > > Signed-off-by: John Snow > --- >

Re: [Qemu-devel] [RFC v4 21/21] blockjobs: add manual_mgmt option to transactions

2018-02-28 Thread Kevin Wolf
Am 27.02.2018 um 21:24 hat Eric Blake geschrieben: > On 02/23/2018 05:51 PM, John Snow wrote: > > This allows us to easily force the option for all jobs belonging > > to a transaction to ensure consistency with how all those jobs > > will be handled. > > > > This is purely a convenience. > > > >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2018-02-28 Thread Eric Blake
On 02/28/2018 07:08 AM, Wouter Verhelst wrote: Or, we can revert the change in commit 56c77720, and keep NBD_REPLY_TYPE_BLOCK_STATUS at 5 (it leaves a hole in the NBD_REPLY_TYPE numbering, where 3 and 4 might be filled in by other future extensions, or permanently skipped). This works IF there

Re: [Qemu-devel] [RFC v4 11/21] blockjobs: add block_job_dismiss

2018-02-28 Thread John Snow
On 02/28/2018 10:53 AM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> For jobs that have reached their CONCLUDED state, prior to having their >> last reference put down (meaning jobs that have completed successfully, >> unsuccessfully, or have been canceled), allow the

[Qemu-devel] [PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-28 Thread Alex Williamson
With vfio ioeventfd support, we can program vfio-pci to perform a specified BAR write when an eventfd is triggered. This allows the KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding userspace handling for these events. On the same micro-benchmark where the ioeventfd got us to

[Qemu-devel] [Bug 1738283] Re: 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC

2018-02-28 Thread Cole Robinson
FYI this seems to be fixed with qemu.git master, I didn't track down the specific commit but there were several keymap related changes. so qemu 2.12 will be fixed ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [PATCH v3 12/16] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

2018-02-28 Thread Max Reitz
This new function allows to look for a consecutively dirty area in a dirty bitmap. Signed-off-by: Max Reitz --- include/block/dirty-bitmap.h | 2 ++ block/dirty-bitmap.c | 55 2 files changed, 57 insertions(+) diff --git

Re: [Qemu-devel] [RFC] qemu-img: Drop BLK_ZERO from convert

2018-02-28 Thread Max Reitz
On 2018-02-27 17:17, Stefan Hajnoczi wrote: > On Mon, Feb 26, 2018 at 06:03:13PM +0100, Max Reitz wrote: >> There are filesystems (among which is tmpfs) that have a hard time >> reporting allocation status. That is definitely a bug in them. >> >> However, there is no good reason why qemu-img

[Qemu-devel] [PATCH v2 1/4] block: add aio_wait_bh_oneshot()

2018-02-28 Thread Stefan Hajnoczi
Sometimes it's necessary for the main loop thread to run a BH in an IOThread and wait for its completion. This primitive is useful during startup/shutdown to synchronize and avoid race conditions. Signed-off-by: Stefan Hajnoczi --- include/block/aio-wait.h | 13

Re: [Qemu-devel] [RFC v4 00/21] blockjobs: add explicit job management

2018-02-28 Thread Kevin Wolf
Am 27.02.2018 um 22:01 hat John Snow geschrieben: > All false positives unless someone really would like to advocate for me > to change the format of the table. Agreed, this isn't going to stop the series. Changing the format of the table would make it much harder to read. Kevin

Re: [Qemu-devel] [PATCH v2] crypto: ensure we use a predictable TLS priority setting

2018-02-28 Thread Eric Blake
On 02/28/2018 12:49 PM, Daniel P. Berrangé wrote: The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the

Re: [Qemu-devel] [RFC v4 09/21] blockjobs: add CONCLUDED state

2018-02-28 Thread John Snow
On 02/28/2018 10:37 AM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> add a new state "CONCLUDED" that identifies a job that has ceased all >> operations. The wording was chosen to avoid any phrasing that might >> imply success, error, or cancellation. The task has

[Qemu-devel] [PATCH v3 13/16] target/arm: Decode aa32 armv8.3 3-same

2018-02-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9169b6b367..45513c9d86 100644 ---

[Qemu-devel] [PATCH v3 00/16] ARM v8.1 simd + v8.3 complex insns

2018-02-28 Thread Richard Henderson
I believe I've incorporated all of Peter's feedback from v2. This is based on target-arm.next, which now contains Alex's fp16 work. Re-tested our standard aarch64 risu tests with -cpu cortex-a57, and against the new risu tests I posted this morning for aa64 and aa32. r~ Richard Henderson

[Qemu-devel] [PATCH v3 06/16] target/arm: Decode aa64 armv8.1 scalar/vector x indexed element

2018-02-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 29 + 1 file changed, 29 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

[Qemu-devel] [PATCH v3 14/16] target/arm: Decode aa32 armv8.3 2-reg-index

2018-02-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index 45513c9d86..3ad8b4031c 100644 ---

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2018-02-28 Thread Eric Blake
On 02/28/2018 02:26 PM, Eric Blake wrote: Okay, I've gone ahead and reverted the renumbering; NBD_INFO_BLOCK_SIZE is back to 5 It helps if I don't copy-and-paste the wrong thing. NBD_INFO_BLOCK_SIZE remains 3 (as it has always been), NBD_REPLY_TYPE_BLOCK_STATUS is reverted back to 5

[Qemu-devel] [PATCHv3 09/12] openpic: move OpenPIC state and related definitions to openpic.h

2018-02-28 Thread Mark Cave-Ayland
This is to faciliate access to OpenPICState when wiring up the PIC to the macio controller. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson --- hw/intc/openpic.c| 157 --

[Qemu-devel] [PATCH 04/11] target/xtensa: support MTTCG

2018-02-28 Thread Max Filippov
- emit TCG barriers for MEMW, EXTW, S32RI and L32AI; - do atomic_cmpxchg_i32 for S32C1I. Cc: Emilio G. Cota Signed-off-by: Max Filippov --- configure | 1 + target/xtensa/cpu.h | 3 +++ target/xtensa/translate.c | 46

[Qemu-devel] [PATCH 02/11] target/xtensa: mark register windows in the dump

2018-02-28 Thread Max Filippov
Add arrows that mark beginning of register windows and position of the current window in the windowed register file. Signed-off-by: Max Filippov --- target/xtensa/translate.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v10 00/29] x86: Secure Encrypted Virtualization (AMD)

2018-02-28 Thread Brijesh Singh
This patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be

[Qemu-devel] [PATCH v10 01/28] memattrs: add debug attribute

2018-02-28 Thread Brijesh Singh
Extend the MemTxAttrs to include 'debug' flag. The flag can be used as general indicator that operation was triggered by the debugger. Later in the patch series we set the debug=1 when issuing a memory access from the gdbstub or HMP commands. This patch is prerequisite to support debugging the

[Qemu-devel] [PATCH 06/11] linux-user: fix assertion in shmdt

2018-02-28 Thread Max Filippov
shmdt fails to call mmap_lock/mmap_unlock around page_set_flags, resulting in the following assertion: page_set_flags: Assertion `have_mmap_lock()' failed. Wrap shmdt internals into mmap_lock/mmap_unlock. Cc: qemu-sta...@nongnu.org Cc: Riku Voipio Cc: Laurent Vivier

[Qemu-devel] [PATCH v3 13/16] block/mirror: Add MirrorBDSOpaque

2018-02-28 Thread Max Reitz
This will allow us to access the block job data when the mirror block driver becomes more complex. Signed-off-by: Max Reitz --- block/mirror.c | 12 1 file changed, 12 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index addfdff4dd..d7bd1d3195 100644

Re: [Qemu-devel] [RFC v4 18/21] blockjobs: add block-job-finalize

2018-02-28 Thread Kevin Wolf
Am 24.02.2018 um 00:51 hat John Snow geschrieben: > Instead of automatically transitioning from PENDING to CONCLUDED, gate > the .prepare() and .commit() phases behind an explicit acknowledgement > provided by the QMP monitor if manual completion mode has been requested. > > This allows us to

[Qemu-devel] [PATCH v2 4/4] vl: introduce vm_shutdown()

2018-02-28 Thread Stefan Hajnoczi
Commit 00d09fdbbae5f7864ce754913efc84c12fdf9f1a ("vl: pause vcpus before stopping iothreads") and commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") tried to work around the fact that emulation was still active during termination by stopping iothreads.

[Qemu-devel] [PATCH v2 0/4] vl: introduce vm_shutdown()

2018-02-28 Thread Stefan Hajnoczi
v2: * Tackle the .ioeventfd_stop() vs vq handler race by removing the ioeventfd from a BH in the IOThread [Fam] There are several race conditions in virtio-blk/virtio-scsi dataplane code. This patch series addresses them, see the commit description for details on the individual cases. Stefan

[Qemu-devel] [PATCH v3 01/16] target/arm: Add ARM_FEATURE_V8_RDM

2018-02-28 Thread Richard Henderson
Not enabled anywhere yet. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + linux-user/elfload.c | 1 + 2 files changed, 2 insertions(+) diff

Re: [Qemu-devel] [PATCH v4 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-28 Thread Christian Borntraeger
h On 02/26/2018 05:57 PM, Cornelia Huck wrote: > On Fri, 23 Feb 2018 18:42:58 +0100 > Claudio Imbrenda wrote: > >> Extend the SCLP event masks to 64 bits. >> >> Notice that using any of the new bits results in a state that cannot be >> migrated to an older version.

[Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear

2018-02-28 Thread Christian Borntraeger
When a guests reboots with diagnose 308 subcode 3 it requests the memory to be cleared. We did not do it so far. This does not only violate the architecture, it also misses the chance to free up that memory on reboot, which would help on host memory over commitment. By using

Re: [Qemu-devel] [RFC v4 10/21] blockjobs: add NULL state

2018-02-28 Thread John Snow
On 02/28/2018 10:42 AM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> Add a new state that specifically demarcates when we begin to permanently >> demolish a job after it has performed all work. This makes the transition >> explicit in the STM table and highlights

Re: [Qemu-devel] [RFC] qemu-img: Drop BLK_ZERO from convert

2018-02-28 Thread Max Reitz
On 2018-02-28 19:08, Max Reitz wrote: > On 2018-02-27 17:17, Stefan Hajnoczi wrote: >> On Mon, Feb 26, 2018 at 06:03:13PM +0100, Max Reitz wrote: >>> There are filesystems (among which is tmpfs) that have a hard time >>> reporting allocation status. That is definitely a bug in them. >>> >>>

[Qemu-devel] [PATCHv3 00/12] macio: remove legacy macio_init() function

2018-02-28 Thread Mark Cave-Ayland
This patchset eliminates the legacy macio_init() function used to setup the ESCC and PIC memory regions and instead allows the macio device to be instantiated directly via qdev, wiring up the ESCC internally using sysbus MMIO memory regions and the PIC via QOM object links. The biggest surprise

[Qemu-devel] [PATCHv3 01/12] macio: embed DBDMA device directly within macio

2018-02-28 Thread Mark Cave-Ayland
The current recommendation is to embed subdevices directly within their container device, so do this for the DBDMA device. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCHv3 05/12] heathrow: change heathrow_pic_init() to return the heathrow device

2018-02-28 Thread Mark Cave-Ayland
This enables the device to be made available during the setup of the Old World machine. In order to pass back the previous set of IRQs we temporarily introduce a new pic_irqs parameter until it can be removed. An additional benefit of this change is that it is also possible to remove the pic_mem

[Qemu-devel] [PATCH v3 01/16] block: BDS deletion during bdrv_drain_recurse

2018-02-28 Thread Max Reitz
Draining a BDS child may lead to other children of the same parent being detached and/or deleted. We should prepare for the former case (by copying the children list before iterating through it) and prevent the latter (by bdrv_ref()'ing all nodes if we are in the main loop). Signed-off-by: Max

[Qemu-devel] [PATCH v3 00/16] block/mirror: Add active-sync mirroring

2018-02-28 Thread Max Reitz
This series implements an active and synchronous mirroring mode. Currently, the mirror block job is passive an asynchronous: Depending on your start conditions, some part of the source disk starts as "dirty". Then, the block job will (as a background operation) continuously copy dirty parts to

Re: [Qemu-devel] [PATCH v3 15/29] vhost+postcopy: Send address back to qemu

2018-02-28 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Feb 27, 2018 at 07:54:18PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Feb 16, 2018 at 01:16:11PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

Re: [Qemu-devel] [PATCH v2 2/5] target/i386: Populate AMD Processor Cache Information

2018-02-28 Thread Radim Krčmář
2018-02-23 21:30-0500, Babu Moger: > From: Stanislav Lanci > > Adds information about cache size and topology from cpuid 0x801D leaf > for different cache types on AMD processors. > > Signed-off-by: Stanislav Lanci > Signed-off-by: Babu Moger

Re: [Qemu-devel] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X)

2018-02-28 Thread Max Reitz
On 2018-02-27 15:47, Eric Blake wrote: > On 02/26/2018 06:01 AM, Max Reitz wrote: > +++ b/block.c @@ -1457,7 +1457,7 @@ static QDict *parse_json_filename(const char *filename, Error **errp)    return NULL;    }    -    options =

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-28 Thread Kevin Wolf
Am 27.02.2018 um 22:57 hat John Snow geschrieben: > > > On 02/27/2018 03:16 PM, Eric Blake wrote: > > On 02/23/2018 05:51 PM, John Snow wrote: > >> Expose the "manual" property via QAPI for the backup-related jobs. > >> As of this commit, this allows the management API to request the > >>

[Qemu-devel] [PATCH v2] crypto: ensure we use a predictable TLS priority setting

2018-02-28 Thread Daniel P . Berrangé
The TLS test cert generation relies on a fixed set of algorithms that are only usable under GNUTLS' default priority setting. When building QEMU with a custom distro specific priority setting, this can cause the TLS tests to fail. By forcing the tests to always use "NORMAL" priority we can make

Re: [Qemu-devel] [RFC v4 21/21] blockjobs: add manual_mgmt option to transactions

2018-02-28 Thread John Snow
On 02/28/2018 01:29 PM, Kevin Wolf wrote: > Am 27.02.2018 um 21:24 hat Eric Blake geschrieben: >> On 02/23/2018 05:51 PM, John Snow wrote: >>> This allows us to easily force the option for all jobs belonging >>> to a transaction to ensure consistency with how all those jobs >>> will be handled.

Re: [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-02-28 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 14, 2018 at 06:56:59PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Feb 13, 2018 at 08:11:00PM +, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > It pauses

[Qemu-devel] [PATCH 0/3] vfio/pci: ioeventfd support

2018-02-28 Thread Alex Williamson
A vfio ioeventfd will perform the pre-specified device write on triggering of an eventfd. When coupled with KVM ioeventfds, this feature allows a VM to trap a device page for virtualization, while also registering targeted ioeventfds to maintain performance of high frequency register writes

[Qemu-devel] [PATCHv3 07/12] mac_oldworld: use object link to pass heathrow PIC object to macio

2018-02-28 Thread Mark Cave-Ayland
Also switch macio_oldworld_realize() over to use it rather than using the pic_mem memory region directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson --- hw/misc/macio/macio.c | 14 ++

[Qemu-devel] [PATCH 3/5] vfio/quirks: ioeventfd quirk acceleration

2018-02-28 Thread Alex Williamson
The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found in device MMIO space. Normally PCI config space is considered a slow path and further optimization is unnecessary, however NVIDIA uses a register here to enable the MSI interrupt to re-trigger. Exiting to QEMU for this MSI-ACK

Re: [Qemu-devel] [PATCHv3 00/12] macio: remove legacy macio_init() function

2018-02-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180228203243.1413-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCHv3 00/12] macio: remove legacy macio_init() function === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

2018-02-28 Thread Max Filippov
In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when mmap, munmap, mprotect, mremap or shmat is called for an address outside the guest address space. mmap and mprotect should return ENOMEM in such case.

[Qemu-devel] [PATCH v3 06/16] block/mirror: Use CoQueue to wait on in-flight ops

2018-02-28 Thread Max Reitz
Attach a CoQueue to each in-flight operation so if we need to wait for any we can use it to wait instead of just blindly yielding and hoping for some operation to wake us. A later patch will use this infrastructure to allow requests accessing the same area of the virtual disk to specifically wait

[Qemu-devel] [PATCH v3 03/16] tests: Add bdrv-drain test for node deletion

2018-02-28 Thread Max Reitz
This patch adds two bdrv-drain tests for what happens if some BDS goes away during the drainage. The basic idea is that you have a parent BDS with some child nodes. Then, you drain one of the children. Because of that, the party who actually owns the parent decides to (A) delete it, or (B)

[Qemu-devel] [PATCH V7 4/4] tests: Add migration test for aarch64

2018-02-28 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-28 Thread John Snow
On 02/28/2018 01:25 PM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> Expose the "manual" property via QAPI for the backup-related jobs. >> As of this commit, this allows the management API to request the >> "concluded" and "dismiss" semantics for backup jobs. >> >>

Re: [Qemu-devel] [RFC v4 08/21] blockjobs: add ABORTING state

2018-02-28 Thread John Snow
On 02/28/2018 09:54 AM, Kevin Wolf wrote: > Am 24.02.2018 um 00:51 hat John Snow geschrieben: >> Add a new state ABORTING. >> >> This makes transitions from normative states to error states explicit >> in the STM, and serves as a disambiguation for which states may complete >> normally when

[Qemu-devel] [PATCH v3 12/16] target/arm: Decode aa64 armv8.3 fcmla

2018-02-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper.h| 11 target/arm/translate-a64.c | 94 +--- target/arm/vec_helper.c| 149 + 3 files changed, 246 insertions(+), 8

[Qemu-devel] [PATCH v3 10/16] target/arm: Add ARM_FEATURE_V8_FCMA

2018-02-28 Thread Richard Henderson
Not enabled anywhere yet. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + linux-user/elfload.c | 1 + 2 files changed, 2 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index

[Qemu-devel] [PATCH v3 11/16] target/arm: Decode aa64 armv8.3 fcadd

2018-02-28 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.h| 7 target/arm/translate-a64.c | 48 ++- target/arm/vec_helper.c| 97 ++ 3

[Qemu-devel] [PATCH 03/11] target/xtensa: use correct number of registers in gdbstub

2018-02-28 Thread Max Filippov
System emulation should provide access to all registers, userspace emulation should only provide access to unprivileged registers. Record register flags from GDB register map definition, calculate both num_regs and num_core_regs if either is zero. Use num_regs in system emulation, num_core_regs in

[Qemu-devel] [PATCH 00/11] linux-user support for target/xtensa

2018-02-28 Thread Max Filippov
Hello, this series adds linux-user support for target/xtensa. It starts with a small cleanup for xtensa registers dumping. It adds support for debugging linux-user process with xtensa-linux-gdb (as opposed to xtensa-elf-gdb), which can only access unprivileged registers. It then enables MTTCG for

[Qemu-devel] [PATCH 01/11] target/xtensa: dump correct physical registers

2018-02-28 Thread Max Filippov
xtensa_cpu_dump_state outputs CPU physical registers as is, without synchronization from current window. That may result in different values printed for the current window and corresponding physical registers. Synchronize physical registers from window before dumping. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH v3 04/16] block/mirror: Pull out mirror_perform()

2018-02-28 Thread Max Reitz
When converting mirror's I/O to coroutines, we are going to need a point where these coroutines are created. mirror_perform() is going to be that point. Signed-off-by: Max Reitz Reviewed-by: Fam Zheng Reviewed-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH v3 05/16] block/mirror: Convert to coroutines

2018-02-28 Thread Max Reitz
In order to talk to the source BDS (and maybe in the future to the target BDS as well) directly, we need to convert our existing AIO requests into coroutine I/O requests. Signed-off-by: Max Reitz --- block/mirror.c | 152

Re: [Qemu-devel] [PATCH v3 00/29] postcopy+vhost-user/shared ram

2018-02-28 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Feb 27, 2018 at 08:05:25PM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Feb 16, 2018 at 01:15:56PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

Re: [Qemu-devel] [PATCH 2/2] vhost: fix incorrect check in vhost_verify_ring_mappings

2018-02-28 Thread Dr. David Alan Gilbert
* Jia He (hejia...@gmail.com) wrote: > In commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks"), > it checks the virtqueue desc mapping for 3 times. > > Fixed: commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks") > Signed-off-by: Jia He Oops, well

Re: [Qemu-devel] [RFC v4 19/21] blockjobs: Expose manual property

2018-02-28 Thread John Snow
On 02/28/2018 01:23 PM, Kevin Wolf wrote: > But given how often I already said that and people still don't consider > it as an option, this doesn't appear to have been very convincing. So > whatever... *shrug* > Sorry, I didn't mean to give that impression. I initially *did* use two (or

[Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

2018-02-28 Thread Alex Williamson
The ioeventfd here is actually irqfd handling of an ioeventfd such as supported in KVM. A user is able to pre-program a device write to occur when the eventfd triggers. This is yet another instance of eventfd-irqfd triggering between KVM and vfio. The impetus for this is high frequency writes

[Qemu-devel] [PATCH 2/3] vfio/pci: Use endian neutral helpers

2018-02-28 Thread Alex Williamson
The iowriteXX/ioreadXX functions assume little endian hardware and convert to little endian on a write and from little endian on a read. We currently do our own explicit conversion to negate this. Instead, add some endian dependent defines to avoid all byte swaps. There should be no functional

[Qemu-devel] [PATCHv3 02/12] macio: move ESCC device within the macio device

2018-02-28 Thread Mark Cave-Ayland
Now that the ESCC device is instantiated directly via qdev, move it to within the macio device and wire up the IRQs and memory regions using the sysbus API. This enables to remove the now-obsolete escc_mem parameter to the macio_init() function. (Note this patch also contains small touch-ups to

[Qemu-devel] [PATCHv3 11/12] macio: move setting of CUDA timebase frequency to macio_common_realize()

2018-02-28 Thread Mark Cave-Ayland
This removes the last of the functionality from macio_init() in preparation for its subsequent removal. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson --- hw/misc/macio/macio.c | 7 ++- 1 file changed, 2 insertions(+),

  1   2   3   4   >