Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Hervé Poussineau
Le 07/03/2018 à 10:08, Thomas Huth a écrit : The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the 40p machine you now get: $ ppc64-softmmu/qemu-system-ppc64 -M 40p -cdrom x.iso

[Qemu-devel] [PULL 6/8] ui/gtk: use GtkGlArea on wayland only

2018-03-08 Thread Gerd Hoffmann
For dma-buf support we need a egl context. The gtk x11 backend uses glx contexts though. We can't use the GtkGlArea widget on x11 because of that, so use our own gtk-egl code instead. wayland continues to use the GtkGlArea widget. Signed-off-by: Gerd Hoffmann Message-id:

Re: [Qemu-devel] block migration and dirty bitmap reset

2018-03-08 Thread Peter Lieven
> Am 08.03.2018 um 02:28 schrieb Fam Zheng : > >> On Wed, 03/07 09:06, Peter Lieven wrote: >> Hi, >> >> while looking at the code I wonder if the blk_aio_preadv and the >> bdrv_reset_dirty_bitmap order must >> be swapped in mig_save_device_bulk: >> >>

[Qemu-devel] [PATCH v3 3/3] spice: add cursor_dmabuf support

2018-03-08 Thread Gerd Hoffmann
Add support for cursor dmabufs. qemu has to render the cursor for that, so in case a cursor is present qemu allocates a new dmabuf, blits the scanout, blends in the pointer and passes on the new dmabuf to spice-server. Without cursor qemu continues to simply pass on the scanout dmabuf as-is.

[Qemu-devel] [PATCH v3 2/3] spice: add scanout_dmabuf support

2018-03-08 Thread Gerd Hoffmann
Add support for scanout dmabufs. Just pass them through to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index 79ea4df02c..4c33c92ae5 100644 ---

[Qemu-devel] [PATCH v3 0/3] spice: add support for dmabufs

2018-03-08 Thread Gerd Hoffmann
v3: rebase, handle surface == NULL in tracepoint (Marc-André). v2: rebase, fix codestyle issues. Gerd Hoffmann (3): spice: drop dprint() debug logging spice: add scanout_dmabuf support spice: add cursor_dmabuf support include/ui/spice-display.h | 9 +++ ui/spice-display.c | 194

[Qemu-devel] [PATCH v3 1/3] spice: drop dprint() debug logging

2018-03-08 Thread Gerd Hoffmann
Some calls are deleted, some are converted into tracepoints. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 75 -- ui/trace-events| 9 +++ 2 files changed, 31 insertions(+), 53 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 12/12] intel_iommu: bind device to PASID tagged AddressSpace

2018-03-08 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, March 6, 2018 7:44 PM > Subject: Re: [PATCH v3 12/12] intel_iommu: bind device to PASID tagged > AddressSpace > > On Thu, Mar 01, 2018 at 06:33:35PM +0800, Liu, Yi L wrote: > > This patch shows the idea of how a device is binded to a

[Qemu-devel] [PULL 8/8] ui/gtk-egl: add cursor_dmabuf support

2018-03-08 Thread Gerd Hoffmann
Add support for cursor dmabufs to gtk-egl. Just blend in the cursor (if we have one) when rendering the dmabuf. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-7-kra...@redhat.com --- include/ui/gtk.h | 8 ui/gtk-egl.c | 40

[Qemu-devel] [PULL 0/8] Ui 20180308 patches

2018-03-08 Thread Gerd Hoffmann
The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b: misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180308-pull-request for you to fetch changes up

[Qemu-devel] [PULL 2/8] sdl: workaround bug in sdl 2.0.8 headers

2018-03-08 Thread Gerd Hoffmann
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892087 Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Message-id: 20180307154258.9313-1-kra...@redhat.com --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure

Re: [Qemu-devel] [PATCH v5 1/1] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-08 Thread Claudio Imbrenda
On Thu, 8 Mar 2018 08:41:47 +0100 Christian Borntraeger wrote: > On 03/07/2018 04:10 PM, Claudio Imbrenda wrote: > > Extend the SCLP event masks to 64 bits. > > > > Notice that using any of the new bits results in a state that > > cannot be migrated to an older version.

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

2018-03-08 Thread Peter Maydell
On 6 March 2018 at 19:46, Michael Clark wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b: > > misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +) > > are available

Re: [Qemu-devel] [PATCH] vga: fix region calculation

2018-03-08 Thread P J P
+-- On Thu, 8 Mar 2018, Gerd Hoffmann wrote --+ | Typically the scanline length and the line offset are identical. | But case But in case ... | Cc: Ross Lagerwall s/Cc:/Reported-by: Ross Lagerwall ... | Signed-off-by: Gerd Hoffmann | --- |

Re: [Qemu-devel] [PATCH v3 0/3] spice: add support for dmabufs

2018-03-08 Thread Marc-André Lureau
On Thu, Mar 8, 2018 at 10:06 AM, Gerd Hoffmann wrote: > v3: rebase, handle surface == NULL in tracepoint (Marc-André). > v2: rebase, fix codestyle issues. > > Gerd Hoffmann (3): > spice: drop dprint() debug logging > spice: add scanout_dmabuf support > spice: add

Re: [Qemu-devel] [PATCH 2/3] net: allow using any PCI NICs in -net or -nic

2018-03-08 Thread Thomas Huth
On 06.03.2018 20:45, Paolo Bonzini wrote: > Remove the hard-coded list of PCI NIC names; instead, fill an array > using all PCI devices listed under DEVICE_CATEGORY_NETWORK. Keep > the old shortcut "virtio" for virtio-net-pci. > > Suggested-by: Thomas Huth > Cc: Jason Wang

Re: [Qemu-devel] [PATCH v4 1/5] pc-dimm: make qmp_pc_dimm_device_list() sort devices by address

2018-03-08 Thread David Gibson
On Thu, Mar 08, 2018 at 10:33:33AM +0800, Haozhong Zhang wrote: > Make qmp_pc_dimm_device_list() return sorted by start address > list of devices so that it could be reused in places that > would need sorted list*. Reuse existing pc_dimm_built_list() > to get sorted list. > > While at it hide

Re: [Qemu-devel] [PATCH] ppc440_pcix: Add dummy implementation of BRDGOPT registers

2018-03-08 Thread David Gibson
On Wed, Mar 07, 2018 at 09:43:59PM +0100, BALATON Zoltan wrote: > I don't know what should be the correct implementation for these so > these are just stored and returned as is without doing anything for > now only to silence warnings when u-boot accesses these registers. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/mips/jazz: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Hervé Poussineau
Le 07/03/2018 à 10:24, Thomas Huth a écrit : The global hack for creating SCSI devices has recently been removed, but this apparently broke SCSI devices on some boards that were not ready for this change yet. For the pica61 machine you now get: $ mips64-softmmu/qemu-system-mips64 -M pica61

[Qemu-devel] [PATCH 1/2] modules: use gmodule-export

2018-03-08 Thread Gerd Hoffmann
As we want qemu symbols be exported to modules we should use the gmodule-export-2.0 pkg-config instead of gmodule-2.0. Cc: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH] vga: fix region calculation

2018-03-08 Thread Ross Lagerwall
On 03/08/2018 07:31 AM, Gerd Hoffmann wrote: Typically the scanline length and the line offset are identical. But case they are not our calculation for region_end is incorrect. Using line_offset is fine for all scanlines, except the last one where we have to use the actual scanline length.

Re: [Qemu-devel] [PATCH v7 0/9] vfio: add display support

2018-03-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180306095135.21285-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH v7 0/9] vfio: add display support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PULL 5/8] ui/opengl: Makefile cleanup

2018-03-08 Thread Gerd Hoffmann
With gtk.mo bits moved away we don't need the ifeq any more. Also add missing opengl libs for some objects. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-4-kra...@redhat.com --- ui/Makefile.objs | 12 ++-- 1 file changed, 6 insertions(+), 6

[Qemu-devel] [PULL 4/8] ui/gtk: group gtk.mo declarations in Makefile

2018-03-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-3-kra...@redhat.com --- ui/Makefile.objs | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index d1203bb80a..b560ee12c3 100644 ---

[Qemu-devel] [PULL 1/8] make: switch language file build to be gtk module aware

2018-03-08 Thread Gerd Hoffmann
From: Bruce Rogers Now that gtk support builds as a module, CONFIG_GTK changed from y to m. Adjust Makefile correspondingly. Signed-off-by: Bruce Rogers Message-id: 20180307155517.32570-1-brog...@suse.com Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PULL 7/8] ui/gtk-egl: add scanout_dmabuf support

2018-03-08 Thread Gerd Hoffmann
Add support for dmabuf scanouts to gtk-egl. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-6-kra...@redhat.com --- include/ui/gtk.h | 4 ui/gtk-egl.c | 23 +++ ui/gtk.c | 2 ++ 3 files changed, 29 insertions(+) diff --git

[Qemu-devel] [PULL 3/8] ui/gtk: make GtkGlArea usage a runtime option

2018-03-08 Thread Gerd Hoffmann
Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime instead of compile time which opengl variant we want use. Signed-off-by: Gerd Hoffmann Message-id: 20180306090951.22932-2-kra...@redhat.com --- include/ui/gtk.h | 2 ++ ui/gtk.c | 53

[Qemu-devel] [PATCH 0/2] modules: two fixes

2018-03-08 Thread Gerd Hoffmann
Gerd Hoffmann (2): modules: use gmodule-export modules: workaround buggy glib builds configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.9.3

[Qemu-devel] [PATCH 2/2] modules: workaround buggy glib builds

2018-03-08 Thread Gerd Hoffmann
https://bugzilla.gnome.org/show_bug.cgi?id=794123 Cc: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index eb612532aa..34e4bb419e 100755 --- a/configure

Re: [Qemu-devel] block migration and dirty bitmap reset

2018-03-08 Thread Fam Zheng
On Thu, Mar 8, 2018 at 4:57 PM, Peter Lieven wrote: > > >> Am 08.03.2018 um 02:28 schrieb Fam Zheng : >> >>> On Wed, 03/07 09:06, Peter Lieven wrote: >>> Hi, >>> >>> while looking at the code I wonder if the blk_aio_preadv and the >>> bdrv_reset_dirty_bitmap order

Re: [Qemu-devel] [PATCH v3 00/12] Introduce new iommu notifier framework for virt-SVA

2018-03-08 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Wednesday, March 7, 2018 1:38 PM > To: Liu, Yi L > Cc: Liu, Yi L ; qemu-devel@nongnu.org; > m...@redhat.com; > da...@gibson.dropbear.id.au; pbonz...@redhat.com; alex.william...@redhat.com; >

Re: [Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob"

2018-03-08 Thread Igor Mammedov
On Wed, 24 Jan 2018 13:39:51 +0800 Peter Xu wrote: > Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means > the command allows out-of-band execution. > > The "oob" idea is proposed by Markus Armbruster in following thread: > >

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Peter Maydell
On 8 March 2018 at 07:09, Thomas Huth wrote: > It's the third case. The "generic" code was just removed with commit > 1454509726719e0933 since it was considered as a big hack. The generic > code should not have to guess to which SCSI adapter a SCSI drive should > be attached to.

Re: [Qemu-devel] [PATCH v5 1/1] s390x/sclp: extend SCLP event masks to 64 bits

2018-03-08 Thread Christian Borntraeger
On 03/08/2018 11:02 AM, Claudio Imbrenda wrote: > On Thu, 8 Mar 2018 08:41:47 +0100 > Christian Borntraeger wrote: > >> On 03/07/2018 04:10 PM, Claudio Imbrenda wrote: >>> Extend the SCLP event masks to 64 bits. >>> >>> Notice that using any of the new bits results in a

[Qemu-devel] qemu crashes with vnc and multiple outputs + console redirection

2018-03-08 Thread Christian Borntraeger
Gerd, I am playing with the virtio-gpu support on s390 and for that I also wanted to multiplex the existing consoles. So I basically used the max_outputs=2 of virtio gpu to be able to switch with ctrl+alt+1 and 3 between the virtio gpu and the sclplm console. -chardev pty,id=charconsole0

[Qemu-devel] [PATCH v12 00/28] x86: Secure Encrypted Virtualization (AMD)

2018-03-08 Thread Brijesh Singh
This patch series provides support for AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. The SEV feature allows the memory contents of a virtual machine (VM) to be

Re: [Qemu-devel] [PATCH 4/5] migration/block: limit the number of parallel I/O requests

2018-03-08 Thread Juan Quintela
Peter Lieven wrote: > the current implementation submits up to 512 I/O requests in parallel > which is much to high especially for a background task. > This patch adds a maximum limit of 16 I/O requests that can > be submitted in parallel to avoid monopolizing the I/O device. > >

[Qemu-devel] [PATCH v12 06/28] kvm: update kvm.h to include memory encryption ioctls

2018-03-08 Thread Brijesh Singh
Updates kmv.h to include memory encryption ioctls and SEV commands. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Brijesh Singh --- linux-headers/linux/kvm.h | 90

[Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker

2018-03-08 Thread Brijesh Singh
SEV guest migration is not implemented yet. Signed-off-by: Brijesh Singh Reviewed-by: Dr. David Alan Gilbert --- target/i386/sev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index

[Qemu-devel] [PATCH v12 25/28] cpu/i386: populate CPUID 0x8000_001F when SEV is active

2018-03-08 Thread Brijesh Singh
When SEV is enabled, CPUID 0x8000_001F should provide additional information regarding the feature (such as which page table bit is used to mark the pages as encrypted etc). The details for memory encryption CPUID is available in AMD APM (https://support.amd.com/TechDocs/24594.pdf) Section E.4.17

[Qemu-devel] [PATCH v12 26/28] qmp: add query-sev-capabilities command

2018-03-08 Thread Brijesh Singh
The command can be used by libvirt to query the SEV capabilities. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Signed-off-by: Brijesh Singh --- monitor.c | 7

[Qemu-devel] [PATCH v3 4/6] target/arm: Make 'any' CPU just an alias for 'max'

2018-03-08 Thread Peter Maydell
Now we have a working '-cpu max', the linux-user-only 'any' CPU is pretty much the same thing, so implement it that way. For the moment we don't add any of the extra feature bits to the system-emulation "max", because we don't set the ID register bits we would need to to advertise those features

[Qemu-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

2018-03-08 Thread Igor Druzhinin
This should help to avoid problems with accessing the device after migration/resume without PV drivers. Older systems will acquire the new record when migrated which should not change their state for worse. Signed-off-by: Igor Druzhinin --- hw/i386/xen/xen_pvdevice.c

[Qemu-devel] [PATCH v3 1/6] target/arm: Query host CPU features on-demand at instance init

2018-03-08 Thread Peter Maydell
Currently we query the host CPU features in the class init function for the TYPE_ARM_HOST_CPU class, so that we can later copy them from the class object into the instance object in the object instance init function. This is awkward for implementing "-cpu max", which should work like "-cpu host"

Re: [Qemu-devel] [PULL 0/6] Qio next patches

2018-03-08 Thread Peter Maydell
On 7 March 2018 at 11:25, Daniel P. Berrangé wrote: > The following changes since commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-05 16:41:20 +) > > are available in

Re: [Qemu-devel] [PATCH v4] migration: change blocktime type to uint32_t

2018-03-08 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Initially int64_t was used, but on PowerPC architecture, > clang doesn't have atomic_*_8 function, so it produces > link time error. > > QEMU is working with time as with 64bit value, but by > fact 32 bit is enough with CLOCK_REALTIME. In this

[Qemu-devel] [PATCH v3 2/6] target/arm: Move definition of 'host' cpu type into cpu.c

2018-03-08 Thread Peter Maydell
Move the definition of the 'host' cpu type into cpu.c, where all the other CPU types are defined. We can do this now we've decoupled it from the KVM-specific host feature probing. This means we now create the type unconditionally (assuming we were built with KVM support at all), but if you try

[Qemu-devel] [PATCH v2.1 9/9] chardev: tcp: postpone TLS work until machine done

2018-03-08 Thread Peter Xu
From: "Daniel P. Berrange" TLS handshake may create background GSource tasks, while we won't know the correct GMainContext until the whole chardev (including frontend) inited. Let's postpone the initial TLS handshake until machine done. For dynamically created tcp chardev,

Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-08 Thread Yan Vugenfirer
> On 6 Mar 2018, at 20:13, Michael S. Tsirkin wrote: > > On Tue, Mar 06, 2018 at 01:02:06PM -0500, Jason Baron wrote: >> >> >> On 03/04/2018 08:05 AM, Yan Vugenfirer wrote: >>> >>> On 2 Mar 2018, at 22:19, Michael S. Tsirkin

[Qemu-devel] [PATCH v12 04/28] monitor/i386: use debug APIs when accessing guest memory

2018-03-08 Thread Brijesh Singh
Updates HMP commands to use the debug version of APIs when accessing the guest memory. Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster

[Qemu-devel] [PATCH v12 01/28] memattrs: add debug attribute

2018-03-08 Thread Brijesh Singh
Extend the MemTxAttrs to include 'debug' flag. The flag can be used as general indicator that operation was triggered by the debugger. Later in the patch series we set the debug=1 when issuing a memory access from the gdbstub or HMP commands. This patch is prerequisite to support debugging the

[Qemu-devel] [PATCH v12 02/28] exec: add ram_debug_ops support

2018-03-08 Thread Brijesh Singh
Currently, the guest memory access for the debug purpose is performed using the memcpy(). Lets extend the 'struct MemoryRegion' to include ram_debug_ops callbacks. The ram_debug_ops can be used to override memcpy() with something else. The feature can be used by encrypted guest -- which can

[Qemu-devel] [PATCH v12 09/28] qmp: add query-sev command

2018-03-08 Thread Brijesh Singh
The QMP query command can used to retrieve the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster

[Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

2018-03-08 Thread Brijesh Singh
Add a new memory encryption object 'sev-guest'. The object will be used to create enrypted VMs on AMD EPYC CPU. The object provides the properties to pass guest owner's public Diffie-hellman key, guest policy and session information required to create the memory encryption context within the SEV

[Qemu-devel] [PATCH v12 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled

2018-03-08 Thread Brijesh Singh
When memory encryption is enabled, the guest RAM and boot flash ROM will contain the encrypted data. By setting the debug ops allow us to invoke encryption APIs when accessing the memory for the debug purposes. Cc: Paolo Bonzini Cc: Richard Henderson Cc:

[Qemu-devel] [PATCH v12 19/28] sev/i386: finalize the SEV guest launch flow

2018-03-08 Thread Brijesh Singh
SEV launch flow requires us to issue LAUNCH_FINISH command before guest is ready to run. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh --- target/i386/sev.c|

[Qemu-devel] [PATCH v12 10/28] include: add psp-sev.h header file

2018-03-08 Thread Brijesh Singh
The header file provide the ioctl command and structure to communicate with /dev/sev device. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v12 22/28] target/i386: clear C-bit when walking SEV guest page table

2018-03-08 Thread Brijesh Singh
In SEV-enabled guest the pte entry will have C-bit set, we need to clear the C-bit when walking the page table. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v12 21/28] sev/i386: add debug encrypt and decrypt commands

2018-03-08 Thread Brijesh Singh
KVM_SEV_DBG_DECRYPT and KVM_SEV_DBG_ENCRYPT commands are used for decrypting and encrypting guest memory region. The command works only if the guest policy allows the debugging. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PATCH v12 12/28] sev/i386: register the guest memory range which may contain encrypted data

2018-03-08 Thread Brijesh Singh
When SEV is enabled, the hardware encryption engine uses a tweak such that the two identical plaintext at different location will have a different ciphertexts. So swapping or moving a ciphertexts of two guest pages will not result in plaintexts being swapped. Hence relocating a physical backing

[Qemu-devel] [PATCH v12 11/28] sev/i386: add command to initialize the memory encryption context

2018-03-08 Thread Brijesh Singh
When memory encryption is enabled, KVM_SEV_INIT command is used to initialize the platform. The command loads the SEV related persistent data from non-volatile storage and initializes the platform context. This command should be first issued before invoking any other guest commands provided by the

[Qemu-devel] [PATCH v12 15/28] sev/i386: add command to create launch memory encryption context

2018-03-08 Thread Brijesh Singh
The KVM_SEV_LAUNCH_START command creates a new VM encryption key (VEK). The encryption key created with the command will be used for encrypting the bootstrap images (such as guest bios). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost

[Qemu-devel] [PATCH v12 27/28] sev/i386: add sev_get_capabilities()

2018-03-08 Thread Brijesh Singh
The function can be used to get the current SEV capabilities. The capabilities include platform diffie-hellman key (pdh) and certificate chain. The key can be provided to the external entities which wants to establish a trusted channel between SEV firmware and guest owner. Cc: Paolo Bonzini

[Qemu-devel] [PATCH v3 5/6] hw/arm/virt: Add "max" to the list of CPU types "virt" supports

2018-03-08 Thread Peter Maydell
Allow the virt board to support '-cpu max' in the same way it already handles '-cpu host'. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index dbb3c8036a..cda4b83586 100644 ---

[Qemu-devel] [PATCH v3 3/6] target/arm: Add "-cpu max" support

2018-03-08 Thread Peter Maydell
Add support for "-cpu max" for ARM guests. This CPU type behaves like "-cpu host" when KVM is enabled, and like a system CPU with the maximum possible feature set otherwise. (Note that this means it won't be migratable across versions, as we will likely add features to it in future.)

Re: [Qemu-devel] [PATCH] log-for-trace.h: Split out parts of log.h used by trace.h

2018-03-08 Thread Peter Maydell
On 23 February 2018 at 16:33, Stefan Hajnoczi wrote: > On Tue, Feb 13, 2018 at 02:00:29PM +, Peter Maydell wrote: >> A persistent build problem we see is where a source file >> accidentally omits the #include of log.h. This slips through >> local developer testing because

[Qemu-devel] [Bug 1754295] [NEW] Incorrect en-us keymap in QEMU 2.11

2018-03-08 Thread Evangelos Foutras via Qemu-devel
Public bug reported: I'm using the latest Arch Linux installation ISO as a live system and start QEMU with the following command: $ qemu-system-x86_64 -enable-kvm -boot d -cdrom ~/isos/archlinux-2018.03.01-x86_64.iso -m 512 -vnc :0 -k en-us Then I use Vinagre to connect to the guest system,

Re: [Qemu-devel] [PATCH 4/5] migration/block: limit the number of parallel I/O requests

2018-03-08 Thread Peter Lieven
Am 08.03.2018 um 13:50 schrieb Juan Quintela: Peter Lieven wrote: the current implementation submits up to 512 I/O requests in parallel which is much to high especially for a background task. This patch adds a maximum limit of 16 I/O requests that can be submitted in parallel to

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/03/07

2018-03-08 Thread Peter Maydell
On 7 March 2018 at 12:51, Stefan Berger wrote: > This series of patches converts the TPM code to use trace-events rather than > debug #define's. > > Stefan > > The following changes since commit 8cb340c613ee3e626b070e0429c589f8a60ac657: > > Merge remote-tracking

Re: [Qemu-devel] [edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

2018-03-08 Thread Marc-André Lureau
Hi On Thu, Mar 8, 2018 at 1:31 PM, Shi, Steven wrote: > Hi Marcandre, >> I test with qemu & swtpm/libtpms (tpm2 branches, swtpm_setup.sh --tpm2 >> --tpm-state tpmstatedir) >> $ swtpm socket --tpmstate tpmstatedir --ctrl type=unixio,path=tpmsock >> --tpm2 & > > Where is

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

2018-03-08 Thread Tony Krowiak
On 03/07/2018 09:41 AM, Cornelia Huck wrote: On Wed, 7 Mar 2018 11:09:46 +0100 Pierre Morel wrote: What I mean is the reverse implication ECA_APIE => ap=on But you can have ap = on and ECA_APIE = off This is interception or emulation. and the second thing is that

Re: [Qemu-devel] block migration and dirty bitmap reset

2018-03-08 Thread Peter Lieven
Am 08.03.2018 um 10:01 schrieb Fam Zheng: On Thu, Mar 8, 2018 at 4:57 PM, Peter Lieven wrote: Am 08.03.2018 um 02:28 schrieb Fam Zheng : On Wed, 03/07 09:06, Peter Lieven wrote: Hi, while looking at the code I wonder if the blk_aio_preadv and the

Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices

2018-03-08 Thread Peter Maydell
On 8 March 2018 at 10:26, Thomas Huth wrote: > On 08.03.2018 11:07, Peter Maydell wrote: >> Are we sure this is the entire list of machines that use this? > > Yes. The problem only occurs for boards that are using > block_default_type = IF_SCSI. > > $ grep -rl IF_SCSI hw/ >

Re: [Qemu-devel] [PATCH] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)

2018-03-08 Thread Thomas Huth
On 08.03.2018 12:08, BALATON Zoltan wrote: > Using log unimp is more appropriate for these messages and this also > silences them by default so they won't clobber make check output when > tests are added for this board. > > Signed-off-by: BALATON Zoltan > --- >

[Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS

2018-03-08 Thread Peter Lieven
this actually limits (as the original commit mesage suggests) the number of I/O buffers that can be allocated and not the number of parallel (inflight) I/O requests. Signed-off-by: Peter Lieven --- migration/block.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 0/5] block migration fixes

2018-03-08 Thread Peter Lieven
Peter Lieven (5): migration: do not transfer ram during bulk storage migration migration/block: reset dirty bitmap before read in bulk phase migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS migration/block: limit the number of parallel I/O requests migration/block: compare only

Re: [Qemu-devel] [PULL 0/4] Multiboot patches

2018-03-08 Thread Peter Maydell
On 7 March 2018 at 11:18, Kevin Wolf wrote: > The following changes since commit f32408f3b472a088467474ab152be3b6285b2d7b: > > misc: don't use hwaddr as a type in trace events (2018-03-06 14:24:30 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 2/5] migration/block: reset dirty bitmap before read in bulk phase

2018-03-08 Thread Juan Quintela
Peter Lieven wrote: > Reset the dirty bitmap before reading to make sure we don't miss > any new data. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter Lieven Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 11:18:30AM +, Michael Clark wrote: > On Fri, 9 Mar 2018 at 12:10 AM, Michael Clark wrote: > > > On Thu, 8 Mar 2018 at 11:02 PM, Peter Maydell > > wrote: > > > >> On 6 March 2018 at 19:46, Michael Clark

Re: [Qemu-devel] [PULL] RISC-V QEMU Port Submission v8.2

2018-03-08 Thread Paolo Bonzini
On 08/03/2018 12:18, Michael Clark wrote: >> There are multiple sign-offs in all >> 23 commits. The tag is riscv-qemu-upstream-v8.2 Except your cover letter lists 45 commits and, as Daniel has already confirmed, Peter is right: these commits listed in the cover letter have no sign-off and have

Re: [Qemu-devel] [PATCH] nbd/server: fix space read

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
05.03.2018 22:47, Eric Blake wrote: On 03/05/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: In case of io error in nbd_co_send_sparse_read we should not "goto reply:", as it is fatal error and common behavior is disconnect in this case. We should not try to send client an error reply,

Re: [Qemu-devel] [edk2] [PATCH v2 3/8] MdeModulePkg: fix REGISITER -> REGISTER

2018-03-08 Thread Zeng, Star
I agree with Laszlo's suggestion. And it is good observation. Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, March 8, 2018 7:59 PM To: marcandre.lur...@redhat.com; edk2-de...@lists.01.org Cc:

Re: [Qemu-devel] [edk2] [PATCH v2 0/8] RFC: ovmf: preliminary TPM2 support

2018-03-08 Thread Shi, Steven
Hi Marcandre, > I test with qemu & swtpm/libtpms (tpm2 branches, swtpm_setup.sh --tpm2 > --tpm-state tpmstatedir) > $ swtpm socket --tpmstate tpmstatedir --ctrl type=unixio,path=tpmsock --tpm2 > & Where is the swtpm_setup.sh? And could you tell how to build & install the swtpm? Thanks Steven

[Qemu-devel] [PATCH v12 07/28] docs: add AMD Secure Encrypted Virtualization (SEV)

2018-03-08 Thread Brijesh Singh
Create a documentation entry to describe the AMD Secure Encrypted Virtualization (SEV) feature. Cc: Paolo Bonzini Signed-off-by: Brijesh Singh --- docs/amd-memory-encryption.txt | 92 ++ 1 file changed, 92

[Qemu-devel] [PATCH v12 14/28] hmp: add 'info sev' command

2018-03-08 Thread Brijesh Singh
The command can be used to show the SEV information when memory encryption is enabled on AMD platform. Cc: Eric Blake Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus Armbruster Reviewed-by: "Dr.

[Qemu-devel] [PATCH v12 03/28] exec: add debug version of physical memory read and write API

2018-03-08 Thread Brijesh Singh
Adds the following new APIs - cpu_physical_memory_read_debug - cpu_physical_memory_write_debug - cpu_physical_memory_rw_debug - ldl_phys_debug - ldq_phys_debug Cc: Paolo Bonzini Cc: Peter Crosthwaite Cc: Richard Henderson

[Qemu-devel] [PATCH v12 16/28] sev/i386: add command to encrypt guest memory region

2018-03-08 Thread Brijesh Singh
The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory region using the VM Encryption Key created using LAUNCH_START. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh

[Qemu-devel] [PATCH v12 18/28] sev/i386: add support to LAUNCH_MEASURE command

2018-03-08 Thread Brijesh Singh
During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be used to retrieve the measurement of the encrypted memory region. This measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the memory was encrypted

[Qemu-devel] [PATCH v12 17/28] target/i386: encrypt bios rom

2018-03-08 Thread Brijesh Singh
SEV requires that guest bios must be encrypted before booting the guest. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v12 05/28] machine: add -memory-encryption property

2018-03-08 Thread Brijesh Singh
When CPU supports memory encryption feature, the property can be used to specify the encryption object to use when launching an encrypted guest. Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state

2018-03-08 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 08 March 2018 12:53 > To: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org > Cc: sstabell...@kernel.org; Paul Durrant ; Anthony > Perard ;

[Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands

2018-03-08 Thread Brijesh Singh
Blacklist the following commands to fix the 'make check' failure. query-sev-launch-measure: it returns meaninful data only when we launch SEV guest otherwise the command returns an error. query-sev: it return an error when SEV is not available on host (e.g non X86 platform or KVM is disabled at

[Qemu-devel] [PATCH v12 13/28] kvm: introduce memory encryption APIs

2018-03-08 Thread Brijesh Singh
Inorder to integerate the Secure Encryption Virtualization (SEV) support add few high-level memory encryption APIs which can be used for encrypting the guest memory region. Cc: Paolo Bonzini Cc: k...@vger.kernel.org Signed-off-by: Brijesh Singh ---

[Qemu-devel] [PATCH v3 0/6] arm: support -cpu max (and gic-version=max)

2018-03-08 Thread Peter Maydell
This patchset adds support for '-cpu max' to Arm, along the lines of the existing support we have for x86 targets: * under KVM, -cpu max is the same as -cpu host * under TCG, -cpu max means "emulate with as many features as possible" -cpu max is supported for both usermode and system

[Qemu-devel] [PATCH v12 23/28] qmp: add query-sev-launch-measure command

2018-03-08 Thread Brijesh Singh
The command can be used by libvirt to retrieve the measurement of SEV guest. This measurement is a signature of the memory contents that was encrypted through the LAUNCH_UPDATE_DATA. Cc: "Daniel P. Berrangé" Cc: "Dr. David Alan Gilbert" Cc: Markus

[Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support -machine gic-version=max

2018-03-08 Thread Peter Maydell
Add support for passing 'max' to -machine gic-version. By analogy with the -cpu max option, this picks the "best available" GIC version whether you're using KVM or TCG, so it behaves like 'host' when using KVM, and gives you GICv3 when using TCG. Also like '-cpu host', using -machine

Re: [Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 07:42:13PM +0800, Peter Xu wrote: > On Thu, Mar 08, 2018 at 10:13:59AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 11:44:09AM +0800, Peter Xu wrote: > > > On Wed, Mar 07, 2018 at 12:36:50PM +, Daniel P. Berrangé wrote: > > > > > > [...] > > > > > > >

Re: [Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done

2018-03-08 Thread Peter Xu
On Thu, Mar 08, 2018 at 01:31:43PM +, Daniel P. Berrangé wrote: > On Thu, Mar 08, 2018 at 07:42:13PM +0800, Peter Xu wrote: > > On Thu, Mar 08, 2018 at 10:13:59AM +, Daniel P. Berrangé wrote: > > > On Thu, Mar 08, 2018 at 11:44:09AM +0800, Peter Xu wrote: > > > > On Wed, Mar 07, 2018 at

Re: [Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 11:44:09AM +0800, Peter Xu wrote: > On Wed, Mar 07, 2018 at 12:36:50PM +, Daniel P. Berrangé wrote: > > [...] > > > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > > > index bd40864f87..997c70dd7d 100644 > > > --- a/chardev/char-socket.c > > > +++

Re: [Qemu-devel] [PATCH v4 00/37] x-blockdev-create for protocols and qcow2

2018-03-08 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 07:59:09PM +0100, Kevin Wolf wrote: > This series implements a minimal QMP command that allows to create an > image file on the protocol level or an image format on a given block > node. > > Eventually, the interface is going to change to some kind of an async > command

  1   2   3   4   5   >