[Qemu-devel] [PATCH 2/5] block/quorum: Remove protocol-related fields

2018-03-09 Thread Fabiano Rosas
The quorum driver is not a protocol so it should implement bdrv_open instead of bdrv_file_open and not provide a protocol_name. Attempts to invoke this driver using protocol syntax (i.e. quorum:) will now fail gracefully: $ qemu-img info quorum:foo qemu-img: Could not open 'quorum:foo':

Re: [Qemu-devel] [PATCH 7/9] iotests.py: tiny refactor: move system imports up

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
16.02.2018 23:44, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   tests/qemu-iotests/iotests.py | 5 +++--   1 file changed, 3 insertions(+), 2 deletions(-) What breaks if they aren't

Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-09 Thread Eric Blake
On 03/09/2018 11:41 AM, Thomas Huth wrote: On 09.03.2018 15:36, Eric Blake wrote: On 03/09/2018 12:13 AM, Thomas Huth wrote: "-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it

Re: [Qemu-devel] [PATCH v4 1/2] i386: Add Intel Processor Trace feature support

2018-03-09 Thread Eduardo Habkost
On Mon, Mar 05, 2018 at 12:48:35AM +0800, Luwei Kang wrote: > From: Chao Peng > > Expose Intel Processor Trace feature to guest. > > To make Intel PT live migration safe and get same CPUID information > with same CPU model on diffrent host. CPUID[14] is constant in

Re: [Qemu-devel] [PATCH v2 2/5] nbd/server: fix sparse read

2018-03-09 Thread Eric Blake
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: In case of io error in nbd_co_send_sparse_read we should not "goto reply:", as it is fatal error and common behavior is disconnect in this case. We should not try to send client an s/send/send the/ error reply, representing

Re: [Qemu-devel] [PATCH v2 06/11] linux-user: fix assertion in shmdt

2018-03-09 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > shmdt fails to call mmap_lock/mmap_unlock around page_set_flags, > resulting in the following assertion: > page_set_flags: Assertion `have_mmap_lock()' failed. > > Wrap shmdt internals into mmap_lock/mmap_unlock. > > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-devel] [PATCH v4] linux-user: Support f_flags in statfs when available.

2018-03-09 Thread Laurent Vivier
Le 01/03/2018 à 12:15, Shea Levy a écrit : > Signed-off-by: Shea Levy > --- > linux-user/syscall.c | 5 + > linux-user/syscall_defs.h | 41 +++-- > 2 files changed, 24 insertions(+), 22 deletions(-) Applied to my

Re: [Qemu-devel] [PATCH v2 08/11] linux-user: drop unused target_msync function

2018-03-09 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > target_msync is not used, remove its declaration and implementation. > > Cc: Riku Voipio > Cc: Laurent Vivier > Signed-off-by: Max Filippov > --- > linux-user/mmap.c | 17

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Michael Clark
On Sat, Mar 10, 2018 at 5:49 AM, Peter Maydell wrote: > On 9 March 2018 at 14:28, Peter Maydell wrote: > > NB: there was a test failure on OpenBSD host: > > > > TEST: tests/qom-test... (pid=64016) > > /riscv32/qom/spike_v1.9.1:

Re: [Qemu-devel] [PATCH v8 03/23] qobject: introduce qobject_get_try_str()

2018-03-09 Thread Eric Blake
On 03/09/2018 02:59 AM, Peter Xu wrote: A quick way to fetch string from qobject when it's a QString. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 +

[Qemu-devel] [PATCH 1/8] device-crash-test: Refactor loglevel configuration code

2018-03-09 Thread Eduardo Habkost
Use action='store_const', dest='loglevel' to represent the effect of each option more clearly. This will also make the last option in the command-line override the previous ones (e.g.: "-d -q"). Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 22

Re: [Qemu-devel] [PATCH 04/10] linux-user: init_guest_space: Correctly handle guest_start in commpage initialization

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > init_guest_commpage needs to check if the mapped space, which ends at > real_start+real_size overlaps with where it needs to put the commpage, > which is (assuming sane qemu_host_page_size) guest_base

Re: [Qemu-devel] [PATCH] RISC-V: Fix isa string logic bug, use popcount to count bits

2018-03-09 Thread Eric Blake
On 03/09/2018 02:20 PM, Michael Clark wrote: Cc: Palmer Dabbelt Cc: Peter Maydell Signed-off-by: Michael Clark --- target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu.c

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 18:20, Guenter Roeck wrote: > On Fri, Mar 09, 2018 at 05:47:16PM +, Peter Maydell wrote: >> Thanks for that really useful writeup. So if I understand correctly >> we have several choices here: >> >> (1) we could implement a model of the IOMUX block that

Re: [Qemu-devel] [PATCH 3/6] luks: Support .bdrv_co_create

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to luks, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 17 - block/crypto.c | 34 ++

[Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
So, we're back to that time when we need to add new known crashes to device-crash-test, because we haven't been running it in a while and new bugs were introduced. To help prevent this from happening again, this series adds new rules to validate devices against the default machine-type on "make

Re: [Qemu-devel] [PATCH 3/5] nbd/server: fix: check client->closing before reply sending

2018-03-09 Thread Eric Blake
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- It's like an RFC. I'm not sure, but this place looks like a bug. Shouldn't we chack client-closing even before nbd_client_receive_next_request() call?

Re: [Qemu-devel] [PATCH 4/7] qed: Support .bdrv_co_create

2018-03-09 Thread Eric Blake
On 03/09/2018 03:46 PM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to qed, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 25 ++- block/qed.c | 204

Re: [Qemu-devel] [edk2] [PATCH v3 0/7] ovmf: preliminary TPM2 support

2018-03-09 Thread Laszlo Ersek
Hi Marc-André, On 03/09/18 14:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM2 support for OVMF-on-QEMU (I > haven't tested TPM1, for lack of interest). It links with the modules > to initializes the

Re: [Qemu-devel] [PATCH 0/9] nbd block status base:allocation

2018-03-09 Thread Eric Blake
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is minimal realization of base:allocation context of NBD block-status extension, which allows to get block status through NBD. Vladimir Sementsov-Ogievskiy (9): nbd/server: add nbd_opt_invalid helper nbd: change

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: The crypto driver used to create the image file in a callback from the crypto subsystem. If we want to implement .bdrv_co_create, this needs to go away because that callback will get a reference to an already existing block node. Move the image file

[Qemu-devel] [PATCH 4/8] device-crash-test: New known crashes

2018-03-09 Thread Eduardo Habkost
We are not running the script on "make check" yet, and additional bugs were introduced recently in the tree. Whitelist the new crashes while we investigate, to allow us to run device-crash-test on "make check" as soon as possible to prevent new bugs. Cc: Pavel Pisa Cc:

[Qemu-devel] [PATCH 2/8] device-crash-test: Add examples to script documentation

2018-03-09 Thread Eduardo Habkost
Add simple examples for common use cases. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 19 +++ 1 file changed, 19 insertions(+) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index c6a7875357..364c779cdb 100755 ---

Re: [Qemu-devel] [PULL] RISC-V: Fix riscv_isa_string g_new0 size calculation

2018-03-09 Thread Michael Clark
Apologies for jumping the gun again with a PR before a review. It was most likely because I thought it was a critical bug fix. I'm incorporating Eric Blake's feedback. On Sat, Mar 10, 2018 at 9:29 AM, Michael Clark wrote: > The following changes since commit

[Qemu-devel] [PATCH 7/7] vpc: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vpc, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 33 ++- block/vpc.c | 152 ++- 2 files changed, 147

Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent

2018-03-09 Thread Thomas Huth
On 09.03.2018 20:00, Eric Blake wrote: > On 03/09/2018 11:41 AM, Thomas Huth wrote: >> On 09.03.2018 15:36, Eric Blake wrote: >>> On 03/09/2018 12:13 AM, Thomas Huth wrote: "-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many

Re: [Qemu-devel] [PATCH v9 09/14] hw/arm/smmuv3: Implement translate callback

2018-03-09 Thread Peter Maydell
On 17 February 2018 at 18:46, Eric Auger wrote: > This patch implements the IOMMU Memory Region translate() > callback. Most of the code relates to the translation > configuration decoding and check (STE, CD). > > Signed-off-by: Eric Auger > > --- >

[Qemu-devel] [PATCH 5/8] device-crash-test: Remove runnable-machine check

2018-03-09 Thread Eduardo Habkost
This optimization to skip tests if the machine is not runnable is unreliable and makes the script ignore actual QEMU crashes, so we're safer simply removing it. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 31 +-- 1 file

[Qemu-devel] [PATCH 7/8] device-crash-test: Don't print warnings in quiet mode

2018-03-09 Thread Eduardo Habkost
This will be useful for hiding known crashes on "make check". Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index ed9a552fa1..36194e4347

Re: [Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180309202827.12085-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH 0/8] tests: Run

[Qemu-devel] [PATCH v2] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Guenter Roeck
The sabrelite machine model used by qemu-system-arm is based on the Freescale/NXP i.MX6Q processor. This SoC has an on-board ethernet controller which is supported in QEMU using the imx_fec.c module (actually called imx.enet for this model.) The include/hw/arm/fsm-imx6.h file defines the

[Qemu-devel] [PATCH 1/7] parallels: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to parallels, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 18 - block/parallels.c| 199 ++- 2 files changed, 168

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Guenter Roeck had to walk into mine at 10:20 on Friday 09 March 2018 and say: > On Fri, Mar 09, 2018 at 05:47:16PM +, Peter Maydell wrote: > > On 8 March 2018 at 18:28, Bill Paul wrote: > > > Anyway, this means

Re: [Qemu-devel] [PATCH 0/5] nbd server fixing and refactoring before BLOCK_STATUS

2018-03-09 Thread Eric Blake
On 03/09/2018 10:41 AM, Eric Blake wrote: On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: 01 and 02 are splitted and updated "[PATCH] nbd/server: fix space read", others are new. Vladimir Sementsov-Ogievskiy (5):    nbd/server: move nbd_co_send_structured_error up    nbd/server:

Re: [Qemu-devel] [PATCH] linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh

2018-03-09 Thread Laurent Vivier
Le 08/03/2018 à 11:48, Laurent Vivier a écrit : > qemu-binfmt-conf.sh when it is used with systemd > needs to know for which CPU the systemd-binfmt.service > file must be created (i.e. "--systemd ppc"). > > But sometime, for instance for test purpose, we need to > create an entry for all known

Re: [Qemu-devel] [PATCH v6 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat

2018-03-09 Thread Laurent Vivier
Le 07/03/2018 à 22:50, Max Filippov a écrit : > In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger > than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when > mmap, munmap, mprotect, mremap or shmat is called for an address outside > the guest address space. mmap

Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic()

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: Everything that refers to the protocol layer or QemuOpts is moved out of block_crypto_create_generic(), so that the remaining function is suitable to be called by a .bdrv_co_create implementation. LUKS is the only driver that actually implements the old

Re: [Qemu-devel] [PATCH 6/6] qemu-iotests: Test luks QMP image creation

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/208 | 211 +++ tests/qemu-iotests/208.out | 136 tests/qemu-iotests/common.rc | 2 +-

Re: [Qemu-devel] [PATCH 02/10] linux-user: Rename validate_guest_space => init_guest_commpage

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > init_guest_commpage is a much more honest description of what the function > does. validate_guest_space not only suggests that the function has no > side-effects, but also introduces confusion as to

Re: [Qemu-devel] [PATCH] RISC-V: Fix isa string logic bug, use popcount to count bits

2018-03-09 Thread Eric Blake
[resend, this time with proper cc's] On 03/09/2018 02:20 PM, Michael Clark wrote: Cc: Palmer Dabbelt Cc: Peter Maydell Signed-off-by: Michael Clark --- target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v2] RISC-V: Fix riscv_isa_string, use popcount to count bits

2018-03-09 Thread Michael Clark
Logic bug caused the string size calculation for the RISC-V format ISA string to be small. This fix allows slack for rv128. Cc: Palmer Dabbelt Cc: Peter Maydell Cc: Eric Blake Signed-off-by: Michael Clark ---

[Qemu-devel] [PATCH 4/7] qed: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qed, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 25 ++- block/qed.c | 204 ++- 2 files changed, 162 insertions(+), 67

[Qemu-devel] [Bug 1726733] Re: ‘qemu-img info replication:’ causes segfault

2018-03-09 Thread Fabiano Rosas
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1726733 Title: ‘qemu-img info replication:’ causes segfault Status in QEMU: In Progress Bug

Re: [Qemu-devel] [PATCH v4 00/29] postcopy+vhost-user/shared ram

2018-03-09 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > This set enables postcopy migration with shared memory to a vhost user > process. > It's based off current head. > > Testing is mostly performed with dpdk, with

Re: [Qemu-devel] [PATCH 5/6] luks: Catch integer overflow for huge sizes

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: When you request an image size close to UINT64_MAX, the addition of the crypto header may cause an integer overflow. Catch it instead of silently truncating the image size. Signed-off-by: Kevin Wolf --- block/crypto.c | 5 + 1

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Michael Clark
On Sat, Mar 10, 2018 at 9:11 AM, Michael Clark wrote: > > > On Sat, Mar 10, 2018 at 5:49 AM, Peter Maydell > wrote: > >> On 9 March 2018 at 14:28, Peter Maydell wrote: >> > NB: there was a test failure on OpenBSD host: >> >

[Qemu-devel] [PATCH] RISC-V: Fix isa string logic bug, use popcount to count bits

2018-03-09 Thread Michael Clark
Cc: Palmer Dabbelt Cc: Peter Maydell Signed-off-by: Michael Clark --- target/riscv/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 4851890..f0d6d1d 100644 ---

Re: [Qemu-devel] [PATCH] RISC-V: Fix isa string logic bug, use popcount to count bits

2018-03-09 Thread Michael Clark
On Sat, Mar 10, 2018 at 9:33 AM, Eric Blake wrote: > [resend, this time with proper cc's] > > On 03/09/2018 02:20 PM, Michael Clark wrote: > >> Cc: Palmer Dabbelt >> Cc: Peter Maydell >> Signed-off-by: Michael Clark

Re: [Qemu-devel] [PATCH v2 10/11] qemu-binfmt-conf.sh: add qemu-xtensa

2018-03-09 Thread Max Filippov
Hi Laurent, On Fri, Mar 9, 2018 at 11:58 AM, Laurent Vivier wrote: > Le 28/02/2018 à 23:16, Max Filippov a écrit : >> Register qemu-xtensa and qemu-xtensaeb for transparent linux userspace >> emulation. >> >> Cc: Riku Voipio >> Cc: Laurent Vivier

Re: [Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
On Fri, Mar 09, 2018 at 12:48:42PM -0800, no-re...@patchew.org wrote: [...] > /tmp/qemu-test/src/scripts/device-crash-test -q -t machine=DEFAULT accel=tcg > -- x86_64-softmmu/qemu-system-x86_64 aarch64-softmmu/qemu-system-aarch64 > /usr/bin/env: python2.7: No such file or directory > make: ***

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Guenter Roeck
On Fri, Mar 09, 2018 at 10:53:43AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Guenter Roeck had to > walk into mine at 10:20 on Friday 09 March 2018 and say: > > > On Fri, Mar 09, 2018 at 05:47:16PM +, Peter Maydell wrote: > > > On 8 March 2018 at

[Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qcow, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 21 +- block/qcow.c | 196 ++- 2 files changed, 150 insertions(+), 67

Re: [Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create

2018-03-09 Thread Eric Blake
On 03/09/2018 03:46 PM, Kevin Wolf wrote: This adds the .bdrv_co_create driver callback to qcow, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 21 +- block/qcow.c | 196

Re: [Qemu-devel] [PULL 0/7] Block patches

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 13:19, Stefan Hajnoczi wrote: > The following changes since commit 0ab4537f08e09b13788db67efd760592fb7db769: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2018-03-07-1' into staging (2018-03-08 > 12:56:39 +) > > are

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Bill Paul had to walk into mine at 10:53 on Friday 09 March 2018 and say: > Of all the gin joints in all the towns in all the world, Guenter Roeck had > to > > walk into mine at 10:20 on Friday 09 March 2018 and say: > > On Fri, Mar 09,

Re: [Qemu-devel] [PATCH 2/2] linux-user: Remove the unused "not implemented" signal handling stubs

2018-03-09 Thread Laurent Vivier
Le 08/03/2018 à 15:47, Peter Maydell a écrit : > Now we've dropped unicore32, all of the architectures we support > for linux-user implement the signal handling routines. The > dummy "just print a message" versions are unimplemented, so we > can drop them entirely. > > Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 1/2] linux-user: Drop unicore32 code

2018-03-09 Thread Laurent Vivier
Le 08/03/2018 à 15:47, Peter Maydell a écrit : > We dropped the unicore32-linux-user target in commit 5e2b40f7271cf9 > in 2016. Nobody has made any attempt to fix the issues that > caused us to drop it, so remove the associated code. > (The system emulation parts of unicore32 remain.) > >

Re: [Qemu-devel] [PATCH v2 07/11] linux-user: fix target_mprotect/target_munmap error return values

2018-03-09 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > target_mprotect/target_munmap return value goes through get_errno at the > call site, thus the functions must either set errno to host error code > and return -1 or return negative guest error code. Do the latter. > > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-devel] [PATCH v2 10/11] qemu-binfmt-conf.sh: add qemu-xtensa

2018-03-09 Thread Laurent Vivier
Le 28/02/2018 à 23:16, Max Filippov a écrit : > Register qemu-xtensa and qemu-xtensaeb for transparent linux userspace > emulation. > > Cc: Riku Voipio > Cc: Laurent Vivier > Signed-off-by: Max Filippov > --- >

Re: [Qemu-devel] [PATCH] fsl-imx6: Swap Ethernet interrupt defines

2018-03-09 Thread Guenter Roeck
On Fri, Mar 09, 2018 at 06:48:43PM +, Peter Maydell wrote: > On 9 March 2018 at 18:20, Guenter Roeck wrote: > > On Fri, Mar 09, 2018 at 05:47:16PM +, Peter Maydell wrote: > >> Thanks for that really useful writeup. So if I understand correctly > >> we have several

Re: [Qemu-devel] [PATCH 4/6] luks: Turn invalid assertion into check

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: The .bdrv_getlength implementation of the crypto block driver asserted that the payload offset isn't after EOF. This is an invalid assertion to make as the image file could be corrupted. Instead, check it and return -EIO if the file is too small for the

Re: [Qemu-devel] [PATCH 06/10] linux-user: init_guest_commpage: Add a comment about size check

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > Signed-off-by: Luke Shumaker > --- > linux-user/elfload.c | 5 + > 1 file changed, 5 insertions(+) Applied to my 'linux-user-for-2.12' branch. Thanks, Laurent

[Qemu-devel] [PATCH 6/8] device-crash-test: Use WARN for known crashes

2018-03-09 Thread Eduardo Habkost
We're going to run device-crash-test on "make check", so it's better to make the script less noisy on known errors. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 44 ++-- 1 file changed, 22 insertions(+), 22

[Qemu-devel] [PATCH 3/8] device-crash-test: Accept machine=DEFAULT to test the default machine

2018-03-09 Thread Eduardo Habkost
This will be useful for running a smaller test set on "make check", instead of testing every single machine-type/device combination. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 29 +++-- 1 file changed, 27 insertions(+), 2

Re: [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > Instead of doing > > if (check1) { > if (check2) { >success; > } > } > > retry; > > Do a clearer > > if (!check1) { >

[Qemu-devel] [Bug 1754295] Re: Incorrect en-us keymap in QEMU 2.11

2018-03-09 Thread Evangelos Foutras via Qemu-devel
*** This bug is a duplicate of bug 1738283 *** https://bugs.launchpad.net/bugs/1738283 ** This bug has been marked a duplicate of bug 1738283 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH 4/6] luks: Turn invalid assertion into check

2018-03-09 Thread Kevin Wolf
Am 09.03.2018 um 21:19 hat Eric Blake geschrieben: > On 03/09/2018 11:27 AM, Kevin Wolf wrote: > > The .bdrv_getlength implementation of the crypto block driver asserted > > that the payload offset isn't after EOF. This is an invalid assertion to > > make as the image file could be corrupted.

Re: [Qemu-devel] [PATCH 4/5] nbd/server: refactor nbd_trip: cmd_read and generic reply

2018-03-09 Thread Eric Blake
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: nbd_trip has difficult logic of sending reply: it tries to use one code path for all replies. It is ok for simple replies, but is not comfortable for structured replies. Also, two types of error (and corresponding message in local_err)

Re: [Qemu-devel] [PATCH 6/9] nbd: BLOCK_STATUS for standard get_block_status function: client part

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
16.02.2018 23:40, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. [...] +    memcpy(extent, payload, sizeof(*extent)); +   

[Qemu-devel] [Bug 1738691] Re: Guest kernel crashes with kvm_pr on POWER8

2018-03-09 Thread Murilo Opsfelder Araújo
Hi, Timothy. I tried to reproduce this issue on a POWER8 box and couldn't reproduce it. Whatever the issue was, it seems to be fixed on kernel v4.16-rc4 with qemu 2.11.50. I downloaded vmlinux/initrd.gz from Ubuntu 18.04 to boot guest. It booted fine up to the installer initial screen. Please

Re: [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS

2018-03-09 Thread Peter Lieven
Am 09.03.2018 um 15:58 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >> this actually limits (as the original commit mesage suggests) the >> number of I/O buffers that can be allocated and not the number >> of parallel (inflight) I/O requests. >> >> Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v3 0/7] block: Handle null backing link

2018-03-09 Thread Eric Blake
On 02/24/2018 09:40 AM, Max Reitz wrote: Currently, we try to rewrite every occurrence of "backing": null into "backing": "" in qmp_blockdev_add(). However, that breaks using the same "backing": null construction in json:{} file names (which do not go through qmp_blockdev_add()). Currently,

Re: [Qemu-devel] [PATCH 03/10] linux-user: init_guest_space: Clean up if we can't initialize the commpage

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > We'll just exit with an error anyway, so it doesn't really matter, but it > is cleaned up in all of the other places were we error out. > > Signed-off-by: Luke Shumaker > --- >

Re: [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > There are 3 parts to this change: > - Add a comment showing the relative sizes and positions of the blocks of >memory > - introduce and use new aligned_{start,size} instead of adjusting >

Re: [Qemu-devel] [PATCH 02/25] hw/dma/i8257: Rename DMA_init() to i8257_dma_init()

2018-03-09 Thread Artyom Tarasenko
On Fri, Mar 9, 2018 at 1:19 PM, Mark Cave-Ayland wrote: > On 09/03/18 10:43, Philippe Mathieu-Daudé wrote: >> >> Hi Mark, >> >> On 03/09/2018 11:32 AM, Mark Cave-Ayland wrote: >>> >>> On 08/03/18 22:39, Philippe Mathieu-Daudé wrote: >>> - Move the header from

[Qemu-devel] [PATCH 6/7] vhdx: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vhdx, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 37 ++- block/vhdx.c | 174 ++- 2 files changed, 167

Re: [Qemu-devel] [PATCH 0/9] nbd block status base:allocation

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
09.03.2018 22:08, Eric Blake wrote: On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is minimal realization of base:allocation context of NBD block-status extension, which allows to get block status through NBD. Vladimir Sementsov-Ogievskiy (9):    nbd/server: add

Re: [Qemu-devel] [PATCH 01/10] linux-user: Use #if to only call validate_guest_space for 32-bit ARM target

2018-03-09 Thread Laurent Vivier
Le 28/12/2017 à 19:08, Luke Shumaker a écrit : > From: Luke Shumaker > > Instead of defining a bogus validate_guest_space that always returns 1 on > targets other than 32-bit ARM, use #if blocks to only call it on 32-bit ARM > targets. This makes the "normal" flow control

[Qemu-devel] [PULL] RISC-V: Fix riscv_isa_string g_new0 size calculation

2018-03-09 Thread Michael Clark
The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-03-09 17:28:16 +) are available in the git repository at: https://github.com/michaeljclark/riscv-qemu.git

[Qemu-devel] [PATCH 8/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
Run a subset of tests using device-crash-test on "make check", to help us catch device crashes earlier. This also add a "check-device-crash-test-full" rule, that will check all machine/device combinations. Signed-off-by: Eduardo Habkost --- tests/Makefile.include | 13

[Qemu-devel] [PATCH 2/7] qemu-iotests: Enable write tests for parallels

2018-03-09 Thread Kevin Wolf
Originally we added parallels as a read-only format to qemu-iotests where we did just some tests with a binary image. Since then, write and image creation support has been added to the driver, so we can now enable it in _supported_fmt generic. The driver doesn't support migration yet, though, so

[Qemu-devel] [PATCH 0/7] block: .bdrv_co_create for format drivers

2018-03-09 Thread Kevin Wolf
This series adds a .bdrv_co_create implementation to almost all format drivers that support creating images where its still missing. The only exception is VMDK because its support for extents will make the QAPI design a bit more complicated. The other format driver not covered in this series are

Re: [Qemu-devel] Apparently fpu/softfloat.c:1374 is reachable

2018-03-09 Thread Emilio G. Cota
On Fri, Mar 09, 2018 at 11:34:56 +, Michael Clark wrote: > BTW how does one hide signed-off-by or cc email addresses with the > git-send-email workflow? You just don't. > Seems like editing the patch after git format-patch is likely the only way > around for contributors whose wishes I might

[Qemu-devel] [PATCH 5/7] vdi: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vdi, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 21 ++- block/vdi.c | 169 ++- 2 files changed, 148 insertions(+), 42

[Qemu-devel] [PULL 3/6] migration/block: reset dirty bitmap before read in bulk phase

2018-03-09 Thread Dr. David Alan Gilbert (git)
From: Peter Lieven Reset the dirty bitmap before reading to make sure we don't miss any new data. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Message-Id: <1520507908-16743-3-git-send-email...@kamp.de> Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v9 10/14] hw/arm/smmuv3: Abort on vfio or vhost case

2018-03-09 Thread Auger Eric
Hi Peter, On 08/03/18 20:06, Peter Maydell wrote: > On 17 February 2018 at 18:46, Eric Auger wrote: >> At the moment, the SMMUv3 does not support notification on >> TLB invalidation. So let's abort as soon as such notifier gets >> enabled. >> >> Signed-off-by: Eric Auger

[Qemu-devel] [PULL 19/25] hw/arm/virt: Support -machine gic-version=max

2018-03-09 Thread Peter Maydell
Add support for passing 'max' to -machine gic-version. By analogy with the -cpu max option, this picks the "best available" GIC version whether you're using KVM or TCG, so it behaves like 'host' when using KVM, and gives you GICv3 when using TCG. Also like '-cpu host', using -machine

[Qemu-devel] [PULL 14/25] target/arm: Query host CPU features on-demand at instance init

2018-03-09 Thread Peter Maydell
Currently we query the host CPU features in the class init function for the TYPE_ARM_HOST_CPU class, so that we can later copy them from the class object into the instance object in the object instance init function. This is awkward for implementing "-cpu max", which should work like "-cpu host"

[Qemu-devel] [PULL 0/6] migration queue

2018-03-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44: memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09 15:55:20 +) are available in the Git repository at:

[Qemu-devel] [PULL 04/25] i.MX: Add i.MX7 SOC implementation.

2018-03-09 Thread Peter Maydell
From: Andrey Smirnov The following interfaces are partially or fully emulated: * up to 2 Cortex A9 cores (SMP works with PSCI) * A7 MPCORE (identical to A15 MPCORE) * 4 GPTs modules * 7 GPIO controllers * 2 IOMUXC controllers * 1 CCM module

[Qemu-devel] [PULL 1/6] migration: fix minor finalize leak

2018-03-09 Thread Dr. David Alan Gilbert (git)
From: Marc-André Lureau Spotted thanks to ASAN: QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/migration-test -p /x86_64/migration/bad_dest ==30302==ERROR: LeakSanitizer: detected memory leaks Direct leak of 48 byte(s) in 1 object(s) allocated from:

[Qemu-devel] [PULL 07/25] aarch64-linux-user: Split out helpers for guest signal handling

2018-03-09 Thread Peter Maydell
From: Richard Henderson Split out helpers from target_setup_frame and target_restore_sigframe for dealing with general registers, fpsimd registers, and the end record. When we add support for sve registers, the relative positions of these will change. Reviewed-by:

[Qemu-devel] [PULL 16/25] target/arm: Add "-cpu max" support

2018-03-09 Thread Peter Maydell
Add support for "-cpu max" for ARM guests. This CPU type behaves like "-cpu host" when KVM is enabled, and like a system CPU with the maximum possible feature set otherwise. (Note that this means it won't be migratable across versions, as we will likely add features to it in future.)

[Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-09 Thread Kevin Wolf
The crypto driver used to create the image file in a callback from the crypto subsystem. If we want to implement .bdrv_co_create, this needs to go away because that callback will get a reference to an already existing block node. Move the image file creation to block_crypto_create_generic().

[Qemu-devel] [PULL 02/25] hw/arm: Set the core count for Xilinx's ZynqMP

2018-03-09 Thread Peter Maydell
From: Alistair Francis Set the ARM CPU core count property for the A53's attached to the Xilnx ZynqMP machine. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Message-id:

[Qemu-devel] [PATCH 0/6] luks: Implement .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This series implements the .bdrv_co_create callback for luks, adds an image creation test for it and contains some bonus fixes for bugs that the test triggered. Kevin Wolf (6): luks: Separate image file creation from formatting luks: Create block_crypto_co_create_generic() luks: Support

[Qemu-devel] [PULL 05/25] Implement support for i.MX7 Sabre board

2018-03-09 Thread Peter Maydell
From: Andrey Smirnov Implement code needed to set up emulation of MCIMX7SABRE board from NXP. For more info about the HW see:

[Qemu-devel] [PULL 4/6] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS

2018-03-09 Thread Dr. David Alan Gilbert (git)
From: Peter Lieven this actually limits (as the original commit mesage suggests) the number of I/O buffers that can be allocated and not the number of parallel (inflight) I/O requests. Signed-off-by: Peter Lieven Message-Id:

[Qemu-devel] [PULL 25/25] MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)

2018-03-09 Thread Peter Maydell
From: Philippe Mathieu-Daudé After spending months studying all the different SD Specifications from the SD Association, voluntarily add myself as maintainer for the SD code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v9 10/14] hw/arm/smmuv3: Abort on vfio or vhost case

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 17:53, Auger Eric wrote: > Hi Peter, > On 08/03/18 20:06, Peter Maydell wrote: >> On 17 February 2018 at 18:46, Eric Auger wrote: >>> At the moment, the SMMUv3 does not support notification on >>> TLB invalidation. So let's abort

  1   2   3   4   5   >