[Qemu-devel] [PULL 20/56] qcow2: Use BlockdevRef in qcow2_co_create()

2018-03-09 Thread Kevin Wolf
Instead of passing a separate BlockDriverState* into qcow2_co_create(), make use of the BlockdevRef that is included in BlockdevCreateOptions. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz ---

[Qemu-devel] [PULL 53/56] iotests: Mark all tests executable

2018-03-09 Thread Kevin Wolf
From: Eric Blake The majority of our iotests have the executable bit set; fix the few outliers for consistency. Signed-off-by: Eric Blake Message-id: 20180305161824.7188-1-ebl...@redhat.com Signed-off-by: Max Reitz ---

[Qemu-devel] [PULL 38/56] rbd: Assign s->snap/image_name in qemu_rbd_open()

2018-03-09 Thread Kevin Wolf
Now that the options are already available in qemu_rbd_open() and not only parsed in qemu_rbd_connect(), we can assign s->snap and s->image_name there instead of passing the fields by reference to qemu_rbd_connect(). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz

[Qemu-devel] [PULL 37/56] rbd: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to rbd, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 19 ++- block/rbd.c | 150

[Qemu-devel] [PULL 22/56] qcow2: Handle full/falloc preallocation in qcow2_co_create()

2018-03-09 Thread Kevin Wolf
Once qcow2_co_create() can be called directly on an already existing node, we must provide the 'full' and 'falloc' preallocation modes outside of creating the image on the protocol layer. Fortunately, we have preallocated truncate now which can provide this functionality. Signed-off-by: Kevin

[Qemu-devel] [PULL 45/56] ssh: QAPIfy host-key-check option

2018-03-09 Thread Kevin Wolf
This makes the host-key-check option available in blockdev-add. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 63 +++-- block/ssh.c | 88

[Qemu-devel] [PULL 36/56] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect()

2018-03-09 Thread Kevin Wolf
With the conversion to a QAPI options object, the function is now prepared to be used in a .bdrv_co_create implementation. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/rbd.c | 115 +--- 1

[Qemu-devel] [PULL 35/56] rbd: Remove non-schema options from runtime_opts

2018-03-09 Thread Kevin Wolf
Instead of the QemuOpts in qemu_rbd_connect(), we want to use QAPI objects. As a preparation, fetch those options directly from the QDict that .bdrv_open() supports in the rbd driver and that are not in the schema. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz

[Qemu-devel] [PULL 16/56] block/qapi: Add qcow2 create options to schema

2018-03-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- qapi/block-core.json | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json

[Qemu-devel] [PULL 39/56] rbd: Use qemu_rbd_connect() in qemu_rbd_do_create()

2018-03-09 Thread Kevin Wolf
This is almost exactly the same code. The differences are that qemu_rbd_connect() supports BlockdevOptionsRbd.server and that the cache mode is set explicitly. Supporting 'server' is a welcome new feature for image creation. Caching is disabled by default, so leave it that way. Signed-off-by:

[Qemu-devel] [PULL 42/56] sheepdog: QAPIfy "redundancy" create option

2018-03-09 Thread Kevin Wolf
The "redundancy" option for Sheepdog image creation is currently a string that can encode one or two integers depending on its format, which at the same time implicitly selects a mode. This patch turns it into a QAPI union and converts the string into such a QAPI object before interpreting the

[Qemu-devel] [PULL 27/56] qcow2: Use visitor for options in qcow2_create()

2018-03-09 Thread Kevin Wolf
Instead of manually creating the BlockdevCreateOptions object, use a visitor to parse the given options into the QAPI object. This involves translation from the old command line syntax to the syntax mandated by the QAPI schema. Option names are still checked against qcow2_create_opts, so only the

[Qemu-devel] [PULL 06/56] block: convert bdrv_invalidate_cache callback to coroutine_fn

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini QED's bdrv_invalidate_cache implementation would like to reuse functions that acquire/release the metadata locks. Call it from coroutine context to simplify the logic. Signed-off-by: Paolo Bonzini Message-Id:

[Qemu-devel] [PULL 33/56] rbd: Fix use after free in qemu_rbd_set_keypairs() error path

2018-03-09 Thread Kevin Wolf
If we want to include the invalid option name in the error message, we can't free the string earlier than that. Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/rbd.c | 3 ++-

[Qemu-devel] [PULL 40/56] nfs: Use QAPI options in nfs_client_open()

2018-03-09 Thread Kevin Wolf
Using the QAPI visitor to turn all options into QAPI BlockdevOptionsNfs simplifies the code a lot. It will also be useful for implementing the QAPI based .bdrv_co_create callback. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/nfs.c | 176

[Qemu-devel] [PULL 30/56] file-posix: Support .bdrv_co_create

2018-03-09 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to file, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- qapi/block-core.json | 20 - block/file-posix.c | 79

[Qemu-devel] [PULL 14/56] qcow2: Make qemu-img check detect corrupted L1 tables in snapshots

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia 'qemu-img check' cannot detect if a snapshot's L1 table is corrupted. This patch checks the table's offset and size and reports corruption if the values are not valid. This patch doesn't add code to fix that corruption yet, only to detect and report it.

[Qemu-devel] [PULL 05/56] qed: make bdrv_qed_do_open a coroutine_fn

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini It is called from qed_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini Message-Id:

[Qemu-devel] [PULL 23/56] util: Add qemu_opts_to_qdict_filtered()

2018-03-09 Thread Kevin Wolf
This allows, given a QemuOpts for a QemuOptsList that was merged from multiple QemuOptsList, to only consider those options that exist in one specific list. Block drivers need this to separate format-layer create options from protocol-level options. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 10/56] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia This function iterates over all snapshots of a qcow2 file in order to expand all zero clusters, but it does not validate the snapshots' L1 tables first. We now have a function to take care of this, so let's use it. We can also take the opportunity to

[Qemu-devel] [PULL 34/56] rbd: Factor out qemu_rbd_connect()

2018-03-09 Thread Kevin Wolf
The code to establish an RBD connection is duplicated between open and create. In order to be able to share the code, factor out the code from qemu_rbd_open() as a first step. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/rbd.c | 100

Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements

2018-03-09 Thread Ian Jackson
I have folded in the comments so far and made a prototype v7 series, which is here: http://xenbits.xen.org/gitweb/?p=people/iwj/qemu.git;a=summary https://xenbits.xen.org/git-http/people/iwj/qemu.git git://xenbits.xen.org/people/iwj/qemu.git In the branch master..xen-restrict-v7.0 I

[Qemu-devel] [PULL 24/56] test-qemu-opts: Test qemu_opts_append()

2018-03-09 Thread Kevin Wolf
Basic test for merging two QemuOptsLists. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- tests/test-qemu-opts.c | 128 + 1 file changed, 128 insertions(+)

[Qemu-devel] [PULL 17/56] qcow2: Rename qcow2_co_create2() to qcow2_co_create()

2018-03-09 Thread Kevin Wolf
The functions originally known as qcow2_create() and qcow2_create2() are now called qcow2_co_create_opts() and qcow2_co_create(), which matches the names of the BlockDriver callbacks that they will implement at the end of this patch series. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 13/56] qcow2: Check snapshot L1 table in qcow2_snapshot_delete()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia This function deletes a snapshot from disk, removing its entry from the snapshot table, freeing its L1 table and decreasing the refcounts of all clusters. The L1 table offset and size are however not validated. If we use invalid values in this function

[Qemu-devel] [PULL 25/56] test-qemu-opts: Test qemu_opts_to_qdict_filtered()

2018-03-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- tests/test-qemu-opts.c | 125 + 1 file changed, 125 insertions(+) diff --git a/tests/test-qemu-opts.c

[Qemu-devel] [PULL 19/56] qcow2: Pass BlockdevCreateOptions to qcow2_co_create()

2018-03-09 Thread Kevin Wolf
All of the simple options are now passed to qcow2_co_create() in a BlockdevCreateOptions object. Still missing: node-name and the encryption options. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake ---

[Qemu-devel] [PULL 12/56] qcow2: Check snapshot L1 table in qcow2_snapshot_goto()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia This function copies a snapshot's L1 table into the active one without validating it first. We now have a function to take care of this, so let's use it. Cc: Eric Blake Signed-off-by: Alberto Garcia Reviewed-by: Eric

[Qemu-devel] [PULL 11/56] qcow2: Check snapshot L1 tables in qcow2_check_metadata_overlap()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia The inactive-l2 overlap check iterates uses the L1 tables from all snapshots, but it does not validate them first. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake

[Qemu-devel] [PULL 26/56] qdict: Introduce qdict_rename_keys()

2018-03-09 Thread Kevin Wolf
A few block drivers will need to rename .bdrv_create options for their QAPIfication, so let's have a helper function for that. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- include/qapi/qmp/qdict.h | 6

[Qemu-devel] [PULL 03/56] qcow2: fix flushing after dirty bitmap metadata writes

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini update_header_sync itself does not need to flush the caches to disk. The only paths that allocate clusters are: - bitmap_list_store with in_place=false, called by update_ext_header_and_dir - store_bitmap_data, called by store_bitmap - store_bitmap,

[Qemu-devel] [PULL 15/56] block/qapi: Introduce BlockdevCreateOptions

2018-03-09 Thread Kevin Wolf
This creates a BlockdevCreateOptions union type that will contain all of the options for image creation. We'll start out with an empty struct type BlockdevCreateNotSupported for all drivers. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max

[Qemu-devel] [PULL 09/56] qcow2: Check L1 table offset in qcow2_snapshot_load_tmp()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia This function checks that the size of a snapshot's L1 table is not too large, but it doesn't validate the offset. We now have a function to take care of this, so let's use it. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake

[Qemu-devel] [PULL 04/56] qcow2: make qcow2_do_open a coroutine_fn

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini It is called from qcow2_invalidate_cache in coroutine context (incoming migration runs in a coroutine), so it's cleaner if metadata is always loaded from a coroutine. Signed-off-by: Paolo Bonzini Message-Id:

[Qemu-devel] [PULL 01/56] block: implement the bdrv_reopen_prepare helper for LUKS driver

2018-03-09 Thread Kevin Wolf
From: "Daniel P. Berrange" If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit command fails to re-open the base layer after committing changes into it. Provide a no-op implementation for the LUKS driver, since there is not any custom work that needs doing

[Qemu-devel] [PULL 07/56] block: convert bdrv_check callback to coroutine_fn

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-8-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 02/56] qcow2: introduce qcow2_write_caches and qcow2_flush_caches

2018-03-09 Thread Kevin Wolf
From: Paolo Bonzini They will be used to avoid recursively taking s->lock during bdrv_open or bdrv_check. Signed-off-by: Paolo Bonzini Message-Id: <1516279431-30424-7-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 08/56] qcow2: Generalize validate_table_offset() into qcow2_validate_table()

2018-03-09 Thread Kevin Wolf
From: Alberto Garcia This function checks that the offset and size of a table are valid. While the offset checks are fine, the size check is too generic, since it only verifies that the total size in bytes fits in a 64-bit integer. In practice all tables used in qcow2 have

[Qemu-devel] [PULL 00/56] Block layer patches

2018-03-09 Thread Kevin Wolf
The following changes since commit d9bbfea646e86426d549bd612cd9f91e49aa50c2: Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-upstream-v8.2' into staging (2018-03-09 10:58:57 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

Re: [Qemu-devel] [PATCH v5 0/2] block latency histogram

2018-03-09 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180309160224.78821-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v5 0/2]

Re: [Qemu-devel] [PATCH v5 0/2] block latency histogram

2018-03-09 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180309160224.78821-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v5 0/2]

Re: [Qemu-devel] [PATCH v5 0/2] block latency histogram

2018-03-09 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180309160224.78821-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v5 0/2]

Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory

2018-03-09 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"): > Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for > mapping VGA memory"): > > This patch seems to remove the last users of > > xen_xc_domain_add_to_physmap(). Can it be remove

Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory

2018-03-09 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"): > This patch seems to remove the last users of > xen_xc_domain_add_to_physmap(). Can it be remove from xen_common.h? > > With that: > Acked-by: Anthony PERARD Have added a

Re: [Qemu-devel] [PATCH v3 3/6] target/arm: Add "-cpu max" support

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/08/2018 02:06 PM, Peter Maydell wrote: > Add support for "-cpu max" for ARM guests. This CPU type behaves > like "-cpu host" when KVM is enabled, and like a system CPU with > the maximum possible feature set otherwise. (Note that this means > it won't be migratable across versions, as we

Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-09 Thread Eric Blake
On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: This test case adds an NBD server export and then invokes blockdev-snapshot-sync, which changes the BlockDriverState node that the Do we want to test 'blockdev-snapshot' instead (or in addition), given the subthread discussion about

Re: [Qemu-devel] [PATCH v3 1/7] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-09 Thread Laszlo Ersek
On 03/09/18 14:09, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The module doesn't use read-only variable. > > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v5 0/2] block latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
v5: Revert to v3 and just add qapi-types.h header. v4: Move block_latency_histogram_set from block/accounting.c to blockdev.c, as it uses qapi type uint64List and this fact breaks build. v3: - semantics, naming and wording changed a lot - x prefixes added to new qapi names - bug fixed about

[Qemu-devel] [PATCH v5 2/2] qapi: add block latency histogram interface

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 111 ++- block/qapi.c

[Qemu-devel] [PATCH v5 1/2] block/accounting: introduce latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Introduce latency histogram statics for block devices. For each accounted operation type latency region [0, +inf) is divided into subregions by several points. Then, calculate hits for each subregion. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH 1/2] block: let blk_add/remove_aio_context_notifier() tolerate BDS changes

2018-03-09 Thread Eric Blake
On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: Commit 2019ba0a0197 ("block: Add AioContextNotifier functions to BB") added blk_add/remove_aio_context_notifier() and implemented them by passing through the bdrv_*() equivalent. This doesn't work across bdrv_append(), which detaches child->bs and

Re: [Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing CMD/ACMD

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: > The SDBus will reuse these functions, so we put them in a new source file. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdmmc-internal.h | 20 ++ > hw/sd/sd.c | 13

Re: [Qemu-devel] [PATCH 11/12] xen: Expect xenstore write to fail when restricted

2018-03-09 Thread Anthony PERARD
On Thu, Mar 08, 2018 at 07:03:06PM +, Ian Jackson wrote: > From: Ross Lagerwall > > Saving the current state to xenstore may fail when running restricted > (in particular, after a migration). Therefore, don't report the error or > exit when running restricted.

Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory

2018-03-09 Thread Anthony PERARD
On Thu, Mar 08, 2018 at 07:03:05PM +, Ian Jackson wrote: > From: Ross Lagerwall > > Xen unstable (to be in 4.11) has two new dmops, relocate_memory and > pin_memory_cacheattr. Use these to set up the VGA memory, replacing the > previous calls to libxc. This allows

Re: [Qemu-devel] [PATCH v2] build: try improve handling of clang warnings

2018-03-09 Thread Philippe Mathieu-Daudé
On 03/09/2018 02:59 PM, Gerd Hoffmann wrote: > This patch disables the pragma diagnostic -Wunused-but-set-variable for > clang in util/coroutine-ucontext.c. > > This in turn allows us to remove it from the configure check, so the > CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang. > >

Re: [Qemu-devel] [PATCH 8/8] MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: > After spending months studying all the different SD Specifications > from the SD Association, voluntarily add myself as maintainer > for the SD code. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v4 0/2] block latency histogram

2018-03-09 Thread Eric Blake
On 03/09/2018 09:33 AM, Vladimir Sementsov-Ogievskiy wrote: v4: Move block_latency_histogram_set from block/accounting.c to blockdev.c, as it uses qapi type uint64List and this fact breaks build. Was the cross file motion necessary, or could you just fix the #includes according to the recent

Re: [Qemu-devel] [PATCH 1/8] sdcard: Do not trace CMD55, except when we already expect an ACMD

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Acked-by: Alistair Francis > --- > hw/sd/sd.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 0/2] block latency histogram

2018-03-09 Thread Eric Blake
On 03/09/2018 09:07 AM, no-re...@patchew.org wrote: Hi, This series failed build test on ppcbe host. Please find the details below. Type: series Message-id: 20180309144918.44975-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 0/2] block latency histogram In file included from

Re: [Qemu-devel] [PATCH 7/8] sdhci: Fix a typo in comment

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 15:36, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index 97b4a473c8..1b828b104d

[Qemu-devel] [PATCH 4/8] sdcard: Add the Tuning Command (CMD19)

2018-03-09 Thread Philippe Mathieu-Daudé
>From the "Physical Layer Simplified Specification Version 3.01": A known data block ("Tuning block") can be used to tune sampling point for tuning required hosts. [...] This procedure gives the system optimal timing for each specific host and card combination and compensates for static

[Qemu-devel] [PATCH 7/8] sdhci: Fix a typo in comment

2018-03-09 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 97b4a473c8..1b828b104d 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -433,13 +433,13 @@ static void

[Qemu-devel] [PATCH 3/8] sdcard: Display which protocol is used when tracing (SD or SPI)

2018-03-09 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/sd/sd.c | 14 ++ hw/sd/trace-events | 8 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

[Qemu-devel] [PATCH 6/8] sdcard: Add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit

2018-03-09 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index b907d62aef..611094447c 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -93,6 +93,7

[Qemu-devel] [PATCH 8/8] MAINTAINERS: Add entries for SD (SDHCI, SDBus, SDCard)

2018-03-09 Thread Philippe Mathieu-Daudé
After spending months studying all the different SD Specifications from the SD Association, voluntarily add myself as maintainer for the SD code. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS

[Qemu-devel] [PATCH 2/8] sdcard: Display command name when tracing CMD/ACMD

2018-03-09 Thread Philippe Mathieu-Daudé
The SDBus will reuse these functions, so we put them in a new source file. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdmmc-internal.h | 20 ++ hw/sd/sd.c | 13 + hw/sd/sdmmc-internal.c | 72 ++

[Qemu-devel] [PATCH 1/8] sdcard: Do not trace CMD55, except when we already expect an ACMD

2018-03-09 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- hw/sd/sd.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 933890e86f..4a9520e38e 100644 --- a/hw/sd/sd.c +++

[Qemu-devel] [PATCH 0/8] SDCard: improve tracing, support UHS-I

2018-03-09 Thread Philippe Mathieu-Daudé
This series contains the leftover patches from these 2 series: - SDCard: housekeeping, add tracing (part 4) - SDCard: bugfixes, support UHS-I (part 5) with Peter Maydell comments addressed. I misunderstood the 2.12 train deadline, but better to have the series standing in the list rather than

[Qemu-devel] [PATCH 5/8] sdcard: Implement the UHS-I SWITCH_FUNCTION entries (Spec v3)

2018-03-09 Thread Philippe Mathieu-Daudé
[based on a patch from Alistair Francis from qemu/xilinx tag xilinx-v2015.2] Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 148 + hw/sd/trace-events | 1 + 2 files changed, 127

[Qemu-devel] [PATCH v4 2/2] qapi: add block latency histogram interface

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 111 ++- block/qapi.c

[Qemu-devel] [PATCH v4 1/2] block/accounting: introduce latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
Introduce latency histogram statics for block devices. For each accounted operation type latency region [0, +inf) is divided into subregions by several points. Then, calculate hits for each subregion. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH v4 0/2] block latency histogram

2018-03-09 Thread Vladimir Sementsov-Ogievskiy
v4: Move block_latency_histogram_set from block/accounting.c to blockdev.c, as it uses qapi type uint64List and this fact breaks build. v3: - semantics, naming and wording changed a lot - x prefixes added to new qapi names - bug fixed about calculation of new_size (new_nbins now) - drop

Re: [Qemu-devel] [PATCH v3 0/2] block latency histogram

2018-03-09 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180309144918.44975-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 0/2]

[Qemu-devel] Chance to have fsfreeze-hook for WIndows?

2018-03-09 Thread Gianluca Cecchi
Hello, currently I'm not a subscriber. I tried but I got " The form is too old. Please GET it again. " Comparing commands-posix.c and commands-win32.c on master at https://github.com/qemu/qemu/tree/master/qga it seems to me that freeze-hook functionality is not present on Windows OS. Could you

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 15:15, Alex Bennée wrote: > > Michael Clark writes: > > >> >> BTW - I've integrated the following 3 branches into the riscv tree: >> >> - https://github.com/riscv/riscv-qemu/tree/softfloat-snan-abort-fix >> -

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-03-09 Thread Laszlo Ersek
On 03/09/18 15:27, Gerd Hoffmann wrote: > Hi, > >> For OVMF (x86), I guess the initial set of properties should come from >> the "-D FOO[=BAR]" build flags that OVMF currently supports. (The list >> might grow or change incompatibly over time, so this is just a raw >> starter idea.) > >> (0)

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Alex Bennée
Michael Clark writes: > > BTW - I've integrated the following 3 branches into the riscv tree: > > - https://github.com/riscv/riscv-qemu/tree/softfloat-snan-abort-fix > - https://github.com/riscv/riscv-qemu/tree/riscv-qemu-upstream-v8.2 > -

Re: [Qemu-devel] [PATCH] tests: Silence migration-test 'bad' test

2018-03-09 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > In 2c9bb29703c I added a migration test that purposely fails; > unfortunately it prints a copy of the failure message to stderr > which makes the output a bit messy. > > Hide

Re: [Qemu-devel] Deprecate tilegx ?

2018-03-09 Thread Alex Bennée
Bastian Koppelmann writes: > On 02/28/2018 07:11 AM, Thomas Huth wrote: >> On 27.02.2018 12:51, Peter Maydell wrote: >>> I propose that we deprecate and plan to remove the unicore32 code: >> [...] > [...] >> >> Sounds reasonable to me, but let's wait a week or

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-03-09 Thread Laszlo Ersek
On 03/09/18 12:27, Kashyap Chamarthy wrote: > On Thu, Mar 08, 2018 at 09:47:27PM +0100, Laszlo Ersek wrote: >> On 03/08/18 16:47, Daniel P. Berrangé wrote: >>> On Thu, Mar 08, 2018 at 12:10:30PM +0100, Laszlo Ersek wrote: > > [...] > For OVMF (x86), I guess the initial set of properties

Re: [Qemu-devel] [PATCH v3 0/2] block latency histogram

2018-03-09 Thread no-reply
Hi, This series failed build test on ppcbe host. Please find the details below. Type: series Message-id: 20180309144918.44975-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 0/2] block latency histogram === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

Re: [Qemu-devel] [PATCH v8 00/23] RISC-V QEMU Port Submission

2018-03-09 Thread Michael Clark
On Mon, Mar 5, 2018 at 9:41 PM, Richard W.M. Jones wrote: > > The attached patch is also needed to avoid crashes during various > math-heavy test suites. > Thanks. I missed your email. I've integrated this and the other outstanding patches into the `riscv-all` branch in the

Re: [Qemu-devel] [PATCH] migration: fix applying wrong capabilities

2018-03-09 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > When setting migration capabilities via QMP/HMP, we'll apply them even > if the capability check failed. Fix it. > > Fixes: 4a84214ebe ("migration: provide migrate_caps_check()", 2017-07-18) > Signed-off-by: Peter Xu Queued > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qemu-iotests: skip test 205 for unsupported formats

2018-03-09 Thread Eric Blake
On 03/09/2018 04:41 AM, Amador Pahim wrote: Using bochs or cloop, qemu-img will fail with: Format driver 'bochs' does not support image creation Signed-off-by: Amador Pahim --- tests/qemu-iotests/205 | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake

[Qemu-devel] [PULL v2 7/8] target/m68k: implement ftwotox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_twotox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-8-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 ++

Re: [Qemu-devel] [PATCH 3/5] migration/block: rename MAX_INFLIGHT_IO to MAX_IO_BUFFERS

2018-03-09 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > this actually limits (as the original commit mesage suggests) the > number of I/O buffers that can be allocated and not the number > of parallel (inflight) I/O requests. > > Signed-off-by: Peter Lieven I've queued 1-3 (which have Juan's R-b).

Re: [Qemu-devel] [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-09 Thread Laszlo Ersek
On 03/09/18 14:05, Marc-André Lureau wrote: > Hi > > On Thu, Mar 8, 2018 at 1:36 AM, Zhang, Chao B wrote: >> Hi Lureau: >>I think we can remove same dependency in TcgPei. >> > > Thanks, feel free to explore that as a separate patch. This is out of > scope to me. > >

[Qemu-devel] [PULL v2 3/8] target/m68k: implement flogn

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_logn() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-4-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 ++ target/m68k/helper.h |

[Qemu-devel] [PULL v2 5/8] target/m68k: implement flog2

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_log2() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-6-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h |

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: set exec permission for tests lacking it

2018-03-09 Thread Eric Blake
On 03/09/2018 04:41 AM, Amador Pahim wrote: Some tests are not executables. This patch sets the executable permission for those tests lacking that. Signed-off-by: Amador Pahim --- Duplicate of a patch already on Max's tree:

[Qemu-devel] [PULL v2 2/8] target/m68k: implement flognp1

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_lognp1() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-3-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 +

[Qemu-devel] [PULL v2 1/8] target/m68k: define floatx80_move()

2018-03-09 Thread Laurent Vivier
This functions is needed by upcoming m68k softfloat functions. Source code copied for WinUAE (tag 3500) (The WinUAE file has been copied from QEMU and has the QEMU licensing notice) Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-2-laur...@vivier.eu> ---

[Qemu-devel] [PULL v2 6/8] target/m68k: implement fetox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_etox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-7-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 +

[Qemu-devel] [PULL v2 4/8] target/m68k: implement flog10

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_log10() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-5-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h

[Qemu-devel] [PULL v2 8/8] target/m68k: implement ftentox

2018-03-09 Thread Laurent Vivier
Using a local m68k floatx80_tentox() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180305203910.10391-9-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 ++ target/m68k/helper.h |

[Qemu-devel] [PULL v2 0/8] M68k for 2.12 patches

2018-03-09 Thread Laurent Vivier
The following changes since commit e1ee9ee139ed7091c2c592d5b784fbb7227bfc0d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.12-20180306' into staging (2018-03-06 10:21:35 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git

Re: [Qemu-devel] [patches] Re: [PULL] RISC-V QEMU Port Submission v8.2

2018-03-09 Thread Michael Clark
On Sat, Mar 10, 2018 at 3:28 AM, Peter Maydell wrote: > On 8 March 2018 at 19:53, Michael Clark wrote: > > I re-iterate Palmer's apology. > > > > I shouldn't be polling git.qemu.org/qemu.git and answering emails near > to > > 3am in the morning after 4

Re: [Qemu-devel] [PATCH v4 08/11] sdcard: display command name when tracing CMD/ACMD

2018-03-09 Thread Philippe Mathieu-Daudé
Hi Peter, On 02/22/2018 01:59 PM, Peter Maydell wrote: > On 15 February 2018 at 22:05, Philippe Mathieu-Daudé wrote: >> put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c >> > > As a general note, your commit messages are generally a bit > shorter than

Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 14:45, wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > Checking PATCH 2/8: target/m68k: implement flognp1... > ERROR: do not set execute permissions for source files > #281: FILE:

Re: [Qemu-devel] [PULL 0/8] M68k for 2.12 patches

2018-03-09 Thread Laurent Vivier
Le 09/03/2018 à 15:50, Peter Maydell a écrit : > On 9 March 2018 at 14:45, wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > >> Checking PATCH 2/8: target/m68k: implement flognp1... >> ERROR: do not set

<    1   2   3   4   5   >