Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze

2018-03-13 Thread Peter Xu
On Tue, Mar 13, 2018 at 09:17:36AM -0500, Eric Blake wrote: > On 03/13/2018 09:02 AM, Peter Maydell wrote: > > On 12 March 2018 at 18:35, Eric Blake wrote: > > > The following changes since commit > > > 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > > >Merge

[Qemu-devel] [PATCH 3/9] hw/arm/boot: If booting a kernel in EL2, set SCR_EL3.HCE

2018-03-13 Thread Peter Maydell
If we're directly booting a Linux kernel and the CPU supports both EL3 and EL2, we start the kernel in EL2, as it expects. We must also set the SCR_EL3.HCE bit in this situation, so that the HVC instruction is enabled rather than UNDEFing. Otherwise at least some kernels will panic when trying to

[Qemu-devel] [PATCH 0/9] raspi3: various fixes for Linux booting

2018-03-13 Thread Peter Maydell
I had a go at booting Debian's Linux kernel on our raspi3 model. These patches fix a variety of bugs that were stopping that working: * the board was trying to boot in secure mode, which isn't right for AArch64 Linux kernels * the hw/arm/boot.c code didn't set SCR_EL3.HCE, which meant that

[Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-13 Thread Peter Maydell
Now we have separate types for BCM2386 and BCM2387, we might as well just hard-code the CPU type they use rather than having it passed through as an object property. This then lets us put the initialization of the CPU object in init rather than realize. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2018 at 3:25 PM, nee wrote: > On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: >> On Mon, 12 Mar 2018 13:08:29 + >> Daniel P. Berrangé wrote: >> >>> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >>> >

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 13.03.2018 13:30, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > 12.03.2018 18:30, Dr. David Alan Gilbert wrote: > > > > * Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 08/11] target/m68k: implement fatanh

2018-03-13 Thread Laurent Vivier
Using a local m68k floatx80_atanh() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-9-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h |

[Qemu-devel] [PULL 07/11] target/m68k: implement facos

2018-03-13 Thread Laurent Vivier
Using a local m68k floatx80_acos() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-8-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h |

Re: [Qemu-devel] [PATCH v3 0/2] block: Fix permission during reopen

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 15:20 hat Fam Zheng geschrieben: > v3: Fix test case. [Max] > > v2: Use update_flags_from_options. [Kevin] > > We write open the whole backing chain during reopen. It is not necessary and > will cause image locking problems if the backing image is shared. Thanks, applied to the

[Qemu-devel] [PATCH v1 5/6] migration: add blocktime calculation into migration-test

2018-03-13 Thread Alexey Perevalov
This patch just requests blocktime calculation, and check it in case when UFFD_FEATURE_THREAD_ID feature is set on the host. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH v1 2/6] migration: add postcopy blocktime ctx into MigrationIncomingState

2018-03-13 Thread Alexey Perevalov
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case this feature is provided by kernel. PostcopyBlocktimeContext is encapsulated inside postcopy-ram.c, due to it being a postcopy-only feature. Also it defines PostcopyBlocktimeContext's instance live time. Information from

[Qemu-devel] [PATCH v1 3/6] migration: calculate vCPU blocktime on dst side

2018-03-13 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted

[Qemu-devel] [PATCH v1 1/6] migration: introduce postcopy-blocktime capability

2018-03-13 Thread Alexey Perevalov
Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH 2/2] docs: Document the new default sizes of the qcow2 caches

2018-03-13 Thread Alberto Garcia
We have just reduced the refcount cache size to the minimum unless the user explicitly requests a larger one, so we have to update the documentation to reflect this change. Signed-off-by: Alberto Garcia --- docs/qcow2-cache.txt | 31 ++- 1 file

[Qemu-devel] [PATCH 1/2] qcow2: Give the refcount cache the minimum possible size by default

2018-03-13 Thread Alberto Garcia
The L2 and refcount caches have default sizes that can be overriden using the l2-cache-size and refcount-cache-size (an additional parameter named cache-size sets the combined size of both caches). Unless forced by one of the aforementioned parameters, QEMU will set the unspecified sizes so that

Re: [Qemu-devel] [PATCH v2 8/8] vpc: Require aligned size in .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > Perform the rounding to match a CHS geometry only in the legacy code > path in .bdrv_co_create_opts. QMP now requires that the user already > passes a CHS aligned image size, unless force-size=true is given. > > CHS alignment is required to make the image

Re: [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types

2018-03-13 Thread Paolo Bonzini
On 08/03/2018 20:02, Ian Jackson wrote: > This avoids checkpatch misparsing (as statements) long function > definitions or declarations, which sometimes start with constructs > like this: > > static inline int xendevicemodel_relocate_memory( > xendevicemodel_handle *dmod, domid_t domid,

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread nee
On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > On Mon, 12 Mar 2018 13:08:29 + > Daniel P. Berrangé wrote: > >> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >> > On Mon, 12 Mar 2018 07:12:52 -0500 >> > Eric Blake

[Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

2018-03-13 Thread Alex Bennée
The tools are already built elsewhere so we might as well not build it here as we just need to test the modules build of QEMU itself. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml

[Qemu-devel] [PATCH v1 2/4] .travis.yml: split default config into system and user

2018-03-13 Thread Alex Bennée
As the build times have risen we keep timing out. Split the default config into system and user builds. Signed-off-by: Alex Bennée --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 92c343a1ef..75e5b408d0

[Qemu-devel] [PATCH v1 0/4] Travis Build Speed-ups

2018-03-13 Thread Alex Bennée
Hi, As QEMU has grown it has started to hit the Travis timeouts a lot more. These patches try and address that by selectively adding --disable-user and --disable-system to the place (and adding a new matrix entry). : patch 0001/.travis.yml drop setting default log output.patch needs review :

[Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

2018-03-13 Thread Alex Bennée
As all the disabled features only affect system emulation we might as well disable user mode to save compile time. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[Qemu-devel] [PATCH 9/9] hw/arm/raspi: Provide spin-loop code for AArch64 CPUs

2018-03-13 Thread Peter Maydell
The raspi3 has AArch64 CPUs, which means that our smpboot code for keeping the secondary CPUs in a pen needs to have a version for A64 as well as A32. Without this, the secondary CPUs go into an infinite loop of taking undefined instruction exceptions. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-13 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is minimal realization of base:allocation context of NBD block-status extension, which allows to get block status through NBD. v2 changes are in each patch after "---" line. Vladimir Sementsov-Ogievskiy (8):

Re: [Qemu-devel] [PATCH 1/1] hw/scsi: support SCSI-2 passthrough without PI

2018-03-13 Thread Paolo Bonzini
On 13/03/2018 15:26, Daniel Henrique Barboza wrote: > QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK > works in the protocol, denying support for PI (Protection > Information) in case the guest OS requests it. However, in SCSI versions 2 > and older, there is no PI concept in

[Qemu-devel] [PATCH v2 5/8] vdi: Make comments consistent with other drivers

2018-03-13 Thread Kevin Wolf
This makes the .bdrv_co_create(_opts) implementation of vdi look more like the other recently converted block drivers. Signed-off-by: Kevin Wolf --- block/vdi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index

[Qemu-devel] [PATCH v2 3/8] qcow: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qcow, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 21 +- block/qcow.c | 196

[Qemu-devel] [PATCH v2 1/8] parallels: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to parallels, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 18 - block/parallels.c| 199

Re: [Qemu-devel] [PATCH v2 6/8] vhdx: Support .bdrv_co_create

2018-03-13 Thread Max Reitz
On 2018-03-13 15:47, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vhdx, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 40 +- > block/vhdx.c | 216 >

Re: [Qemu-devel] [PATCH v1 1/4] .travis.yml: drop setting default log output

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:07PM +, Alex Bennée wrote: > The log backend is the default one, we don't need to explicitly set it. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml

Re: [Qemu-devel] [PATCH v1 3/4] .travis.yml: add --disable-user with the rest of the disables

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:09PM +, Alex Bennée wrote: > As all the disabled features only affect system emulation we might as > well disable user mode to save compile time. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1

[Qemu-devel] [PATCH v1 1/4] .travis.yml: drop setting default log output

2018-03-13 Thread Alex Bennée
The log backend is the default one, we don't need to explicitly set it. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 79377c8de0..92c343a1ef 100644 --- a/.travis.yml +++

[Qemu-devel] [PATCH 2/9] hw/arm/boot: assert that secure_boot and secure_board_setup are false for AArch64

2018-03-13 Thread Peter Maydell
Add some assertions that if we're about to boot an AArch64 kernel, the board code has not mistakenly set either secure_boot or secure_board_setup. It doesn't make sense to set secure_boot, because all AArch64 kernels must be booted in non-secure mode. It might in theory make sense to set

Re: [Qemu-devel] [PATCH v2 5/8] nbd: BLOCK_STATUS for standard get_block_status function: client part

2018-03-13 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: - drop iotests changes, as

[Qemu-devel] [PATCH 6/9] hw/arm/bcm2836: Create proper bcm2837 device

2018-03-13 Thread Peter Maydell
The bcm2837 is pretty similar to the bcm2836, but it does have some differences. Notably, the MPIDR affinity aff1 values it sets for the CPUs are 0x0, rather than the 0xf that the bcm2836 uses, and if this is wrong Linux will not boot. Rather than trying to have one device with properties that

[Qemu-devel] [PATCH v1 4/6] migration: postcopy_blocktime documentation

2018-03-13 Thread Alexey Perevalov
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- docs/devel/migration.rst | 14 ++ 1 file changed, 14

[Qemu-devel] [PATCH v1 6/6] migration: add postcopy total blocktime into query-migrate

2018-03-13 Thread Alexey Perevalov
Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migrate command will show

Re: [Qemu-devel] [PATCH v2 0/8] block: .bdrv_co_create for format drivers

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 15:47 hat Kevin Wolf geschrieben: > This series adds a .bdrv_co_create implementation to almost all format > drivers that support creating images where its still missing. The only > exception is VMDK because its support for extents will make the QAPI > design a bit more

[Qemu-devel] [PATCH 7/9] hw/arm/bcm2836: Use correct affinity values for BCM2837

2018-03-13 Thread Peter Maydell
The BCM2837 sets the Aff1 field of the MPIDR affinity values for the CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it is required for Linux to boot. Signed-off-by: Peter Maydell --- hw/arm/bcm2836.c | 7 ++- 1 file changed, 6 insertions(+), 1

[Qemu-devel] [PATCH 1/9] hw/arm/raspi: Don't do board-setup or secure-boot for raspi3

2018-03-13 Thread Peter Maydell
For the rpi1 and 2 we want to boot the Linux kernel via some custom setup code that makes sure that the SMC instruction acts as a no-op, because it's used for cache maintenance. The rpi3 boots AArch64 kernels, which don't need SMC for cache maintenance and always expect to be booted non-secure.

[Qemu-devel] [PATCH 5/9] hw/arm/bcm2836: Rename bcm2836 type/struct to bcm283x

2018-03-13 Thread Peter Maydell
Our BCM2836 type is really a generic one that can be any of the bcm283x family. Rename it accordingly. We change only the names which are visible via the header file to the rest of the QEMU code, leaving private function names in bcm2836.c as they are. This is a preliminary to making bcm283x be

Re: [Qemu-devel] [PATCH v2 7/8] iotests: add file_path helper

2018-03-13 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Simple way to have auto generated filenames with auto cleanup. Like FilePath but without using 'with' statement and without additional indentation of the whole test. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 1/1] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-13 Thread Kevin Wolf
Am 13.03.2018 um 13:12 hat Jeff Cody geschrieben: > From: Liang Li > > When doing drive mirror to a low speed shared storage, if there was heavy > BLK IO write workload in VM after the 'ready' event, drive mirror block job > can't be canceled immediately, it would

[Qemu-devel] [PATCH 1/1] hw/scsi: support SCSI-2 passthrough without PI

2018-03-13 Thread Daniel Henrique Barboza
QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK works in the protocol, denying support for PI (Protection Information) in case the guest OS requests it. However, in SCSI versions 2 and older, there is no PI concept in the protocol. This means that when dealing with such devices:

[Qemu-devel] [PATCH v2 7/8] vpc: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vpc, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 33 ++- block/vpc.c | 152 ++- 2 files changed, 147

[Qemu-devel] [PATCH v2 0/8] block: .bdrv_co_create for format drivers

2018-03-13 Thread Kevin Wolf
This series adds a .bdrv_co_create implementation to almost all format drivers that support creating images where its still missing. The only exception is VMDK because its support for extents will make the QAPI design a bit more complicated. The other format driver not covered in this series are

[Qemu-devel] [PATCH v2 2/8] qemu-iotests: Enable write tests for parallels

2018-03-13 Thread Kevin Wolf
Originally we added parallels as a read-only format to qemu-iotests where we did just some tests with a binary image. Since then, write and image creation support has been added to the driver, so we can now enable it in _supported_fmt generic. The driver doesn't support migration yet, though, so

[Qemu-devel] [PATCH v2 4/8] qed: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qed, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 25 ++- block/qed.c | 204

[Qemu-devel] [PATCH v1 0/6] postcopy block time calculation + ppc32 build fix

2018-03-13 Thread Alexey Perevalov
This patch set includes patches which were reverted by commit ee86981bd, due to build problem on 32 powerpc/arm architecture. Also it includes patch to fix build ([PATCH v4] migration: change blocktime type to uint32_t), but that patch was merged into: migration: add postcopy blocktime ctx into

[Qemu-devel] [PATCH v2 6/8] vhdx: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vhdx, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 40 +- block/vhdx.c | 216 ++- 2 files changed, 203

Re: [Qemu-devel] [PULL 0/3] x86 queue, 2018-03-12

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 20:00, Eduardo Habkost wrote: > The following changes since commit b16a54da0696efc5d91b6c3597a37a317abb5de7: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180312-pull-request' > into staging (2018-03-12 14:06:23 +) > > are available in

Re: [Qemu-devel] [PATCH v1 2/4] .travis.yml: split default config into system and user

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:08PM +, Alex Bennée wrote: > As the build times have risen we keep timing out. Split the default > config into system and user builds. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 3 ++- > 1 file changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 4/9] hw/arm/bcm2386: Fix parent type of bcm2386

2018-03-13 Thread Peter Maydell
The TypeInfo and state struct for bcm2386 disagree about what the parent class is -- the TypeInfo says it's TYPE_SYS_BUS_DEVICE, but the BCM2386State struct only defines the parent_obj field as DeviceState. This would have caused problems if anything actually tried to treat the object as a

Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

2018-03-13 Thread Daniel P . Berrangé
On Tue, Mar 13, 2018 at 03:32:10PM +, Alex Bennée wrote: > The tools are already built elsewhere so we might as well not build it > here as we just need to test the modules build of QEMU itself. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file

[Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-03-13 Thread Gerd Hoffmann
A driver to let userspace turn iovecs into dma-bufs. Use case: Allows qemu pass around dmabufs for the guest framebuffer. https://www.kraxel.org/cgit/qemu/log/?h=sirius/udmabuf has an experimental patch. Also allows qemu to export guest virtio-gpu resources as host dmabufs. Should be possible

Re: [Qemu-devel] [PATCH v2 8/8] iotests: new test 209 for NBD BLOCK_STATUS

2018-03-13 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- + +iotests.verify_image_format(supported_fmts=['qcow2']) Interesting that './check -nbd' doesn't run 209 (because that defaults to format -raw, but we

Re: [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause

2018-03-13 Thread Peter Xu
On Tue, Mar 13, 2018 at 12:35:56PM +, Dr. David Alan Gilbert wrote: [...] > > Yes I think if without OOB we should be fine since even the cleanup is > > running with the BQL. > > > > Now I don't have good idea to solve this problem except introducing a > > lock. How about I add a patch to

[Qemu-devel] [PULL 00/11] M68k for 2.12 patches

2018-03-13 Thread Laurent Vivier
The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-03-13 14:02:47 +) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git

[Qemu-devel] [PULL 04/11] target/m68k: implement fsincos

2018-03-13 Thread Laurent Vivier
using floatx80_sin() and floatx80_cos() Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-5-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 11 +++ target/m68k/helper.h | 1 + target/m68k/translate.c | 8 3 files changed, 20

[Qemu-devel] [PULL 09/11] target/m68k: implement ftanh

2018-03-13 Thread Laurent Vivier
Using local m68k floatx80_tanh() and floatx80_etoxm1() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-10-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 +

[Qemu-devel] [PULL 05/11] target/m68k: implement fatan

2018-03-13 Thread Laurent Vivier
Using a local m68k floatx80_atan() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-6-laur...@vivier.eu> --- target/m68k/fpu_helper.c| 5 +

[Qemu-devel] [PULL 00/41] Block layer patches

2018-03-13 Thread Kevin Wolf
The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-03-13 11:42:45 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH] iotests: Update output of 051 and 186 after commit 1454509726719e0933c

2018-03-13 Thread Kevin Wolf
Am 06.03.2018 um 17:52 hat Thomas Huth geschrieben: > On 06.03.2018 17:45, Alberto Garcia wrote: > > Signed-off-by: Alberto Garcia > > --- > > tests/qemu-iotests/051.pc.out | 20 > > tests/qemu-iotests/186.out| 22 +++--- > > 2 files

[Qemu-devel] [PULL 04/41] blockjobs: add status enum

2018-03-13 Thread Kevin Wolf
From: John Snow We're about to add several new states, and booleans are becoming unwieldly and difficult to reason about. It would help to have a more explicit bookkeeping of the state of blockjobs. To this end, add a new "status" field and add our existing states in a

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread John Snow
On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote: > > Hmm, I agree, it is the simplest thing we can do for now, and I'll > rethink later, > how (and is it worth doing) to go to postcopy automatically in case of > only-dirty-bitmaps. > Should I respin? Please do. I already staged

Re: [Qemu-devel] [PULL 1/1] vga: fix region calculation

2018-03-13 Thread Mark Kanda
On 3/12/2018 5:59 AM, Gerd Hoffmann wrote: Typically the scanline length and the line offset are identical. But in case they are not our calculation for region_end is incorrect. Using line_offset is fine for all scanlines, except the last one where we have to use the actual scanline length.

[Qemu-devel] [PULL 01/41] blockjobs: fix set-speed kick

2018-03-13 Thread Kevin Wolf
From: John Snow If speed is '0' it's not actually "less than" the previous speed. Kick the job in this case too. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 07/41] blockjobs: add block_job_verb permission table

2018-03-13 Thread Kevin Wolf
From: John Snow Which commands ("verbs") are appropriate for jobs in which state is also somewhat burdensome to keep track of. As of this commit, it looks rather useless, but begins to look more interesting the more states we add to the STM table. A recurring theme is that no

[Qemu-devel] [PULL 06/41] iotests: add pause_wait

2018-03-13 Thread Kevin Wolf
From: John Snow Split out the pause command into the actual pause and the wait. Not every usage presently needs to resubmit a pause request. The intent with the next commit will be to explicitly disallow redundant or meaningless pause/resume requests, so the tests need to

[Qemu-devel] [PULL 05/41] blockjobs: add state transition table

2018-03-13 Thread Kevin Wolf
From: John Snow The state transition table has mostly been implied. We're about to make it a bit more complex, so let's make the STM explicit instead. Perform state transitions with a function that for now just asserts the transition is appropriate. Transitions: Undefined ->

[Qemu-devel] [PULL 21/41] tests/test-blockjob: test cancellations

2018-03-13 Thread Kevin Wolf
From: John Snow Whatever the state a blockjob is in, it should be able to be canceled by the block layer. Signed-off-by: John Snow Signed-off-by: Kevin Wolf --- tests/test-blockjob.c | 233

[Qemu-devel] [PULL 24/41] luks: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to luks, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Daniel P. Berrangé --- qapi/block-core.json | 17 - block/crypto.c | 34

[Qemu-devel] [PULL 10/41] blockjobs: add NULL state

2018-03-13 Thread Kevin Wolf
From: John Snow Add a new state that specifically demarcates when we begin to permanently demolish a job after it has performed all work. This makes the transition explicit in the STM table and highlights conditions under which a job may be demolished. Alongside this state,

Re: [Qemu-devel] [PATCH] iotests: Update output of 051 and 186 after commit 1454509726719e0933c

2018-03-13 Thread Thomas Huth
On 13.03.2018 17:08, Kevin Wolf wrote: > Am 06.03.2018 um 17:52 hat Thomas Huth geschrieben: >> On 06.03.2018 17:45, Alberto Garcia wrote: >>> Signed-off-by: Alberto Garcia >>> --- >>> tests/qemu-iotests/051.pc.out | 20 >>> tests/qemu-iotests/186.out|

[Qemu-devel] [PULL 13/41] blockjobs: add commit, abort, clean helpers

2018-03-13 Thread Kevin Wolf
From: John Snow The completed_single function is getting a little mucked up with checking to see which callbacks exist, so let's factor them out. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL 29/41] vdi: Move file creation to vdi_co_create_opts

2018-03-13 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/vdi.c | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index

[Qemu-devel] [PULL 36/41] qed: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to qed, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 25 ++- block/qed.c | 204

[Qemu-devel] [PULL 16/41] blockjobs: add waiting status

2018-03-13 Thread Kevin Wolf
From: John Snow For jobs that are stuck waiting on others in a transaction, it would be nice to know that they are no longer "running" in that sense, but instead are waiting on other jobs in the transaction. Jobs that are "waiting" in this sense cannot be meaningfully altered

[Qemu-devel] [PULL 27/41] qemu-iotests: Test luks QMP image creation

2018-03-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Daniel P. Berrangé --- tests/qemu-iotests/209 | 210 +++ tests/qemu-iotests/209.out | 136 tests/qemu-iotests/common.rc | 2 +-

[Qemu-devel] [PATCH v2 1/1] hw/scsi: support SCSI-2 passthrough without PI

2018-03-13 Thread Daniel Henrique Barboza
QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK works in the protocol, denying support for PI (Protection Information) in case the guest OS requests it. However, in SCSI versions 2 and older, there is no PI concept in the protocol. This means that when dealing with such devices:

[Qemu-devel] [PULL 40/41] vpc: Require aligned size in .bdrv_co_create

2018-03-13 Thread Kevin Wolf
Perform the rounding to match a CHS geometry only in the legacy code path in .bdrv_co_create_opts. QMP now requires that the user already passes a CHS aligned image size, unless force-size=true is given. CHS alignment is required to make the image compatible with Virtual PC, but not for use with

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2018 19:16, John Snow wrote: On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote: Hmm, I agree, it is the simplest thing we can do for now, and I'll rethink later, how (and is it worth doing) to go to postcopy automatically in case of only-dirty-bitmaps. Should I respin? Please

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2018 18:55, Eric Blake wrote: On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is minimal realization of base:allocation context of NBD block-status extension, which allows to get block status through NBD. v2 changes are in each patch after "---" line. Vladimir

[Qemu-devel] [PULL 34/41] qemu-iotests: Enable write tests for parallels

2018-03-13 Thread Kevin Wolf
Originally we added parallels as a read-only format to qemu-iotests where we did just some tests with a binary image. Since then, write and image creation support has been added to the driver, so we can now enable it in _supported_fmt generic. The driver doesn't support migration yet, though, so

[Qemu-devel] [PULL 18/41] blockjobs: add block-job-finalize

2018-03-13 Thread Kevin Wolf
From: John Snow Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if auto_finalize = false has been requested. This allows us to perform graph changes in

[Qemu-devel] [PULL 14/41] blockjobs: add block_job_txn_apply function

2018-03-13 Thread Kevin Wolf
From: John Snow Simply apply a function transaction-wide. A few more uses of this in forthcoming patches. Signed-off-by: John Snow Signed-off-by: Kevin Wolf --- blockjob.c | 25 - 1 file changed, 16 insertions(+),

[Qemu-devel] [PULL 33/41] parallels: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to parallels, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- qapi/block-core.json | 18 - block/parallels.c| 199

[Qemu-devel] [PULL 28/41] vdi: Pull option parsing from vdi_co_create

2018-03-13 Thread Kevin Wolf
From: Max Reitz In preparation of QAPI-fying VDI image creation, we have to create a BlockdevCreateOptionsVdi type which is received by a (future) vdi_co_create(). vdi_co_create_opts() now converts the QemuOpts object into such a BlockdevCreateOptionsVdi object. The

[Qemu-devel] [PULL 25/41] luks: Turn invalid assertion into check

2018-03-13 Thread Kevin Wolf
The .bdrv_getlength implementation of the crypto block driver asserted that the payload offset isn't after EOF. This is an invalid assertion to make as the image file could be corrupted. Instead, check it and return -EIO if the file is too small for the payload offset. Zero length images are

[Qemu-devel] [PULL 12/41] blockjobs: ensure abort is called for cancelled jobs

2018-03-13 Thread Kevin Wolf
From: John Snow Presently, even if a job is canceled post-completion as a result of a failing peer in a transaction, it will still call .commit because nothing has updated or changed its return code. The reason why this does not cause problems currently is because backup's

[Qemu-devel] [PULL 31/41] block: Fix flags in reopen queue

2018-03-13 Thread Kevin Wolf
From: Fam Zheng Reopen flags are not synchronized according to the bdrv_reopen_queue_child precedence until bdrv_reopen_prepare. It is a bit too late: we already check the consistency in bdrv_check_perm before that. This fixes the bug that when bdrv_reopen a RO node as RW, the

[Qemu-devel] [PULL 38/41] vhdx: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vhdx, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 40 +- block/vhdx.c | 216

[Qemu-devel] [PULL 0/3] Reduce Travis timeouts

2018-03-13 Thread Alex Bennée
The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-03-13 11:42:45 +) are available in the Git repository at: https://github.com/stsquad/qemu.git

[Qemu-devel] [PULL 39/41] vpc: Support .bdrv_co_create

2018-03-13 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to vpc, which enables image creation over QMP. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qapi/block-core.json | 33 ++- block/vpc.c | 152

Re: [Qemu-devel] [PATCH 7/9] hw/arm/bcm2836: Use correct affinity values for BCM2837

2018-03-13 Thread Andrew Baumann via Qemu-devel
> From: Peter Maydell > Sent: Tuesday, 13 March 2018 08:35 > > The BCM2837 sets the Aff1 field of the MPIDR affinity values for the > CPUs to 0, whereas the BCM2836 uses 0xf. Set this correctly, as it > is required for Linux to boot. > > Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PULL 0/9] Socket next patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 20:12, Daniel P. Berrangé wrote: > The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 > 13:21:53 +) > > are

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread Greg Kurz
On Tue, 13 Mar 2018 15:52:41 + Stefan Hajnoczi wrote: > On Tue, Mar 13, 2018 at 3:25 PM, nee wrote: > > On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > >> On Mon, 12 Mar 2018 13:08:29 + > >> Daniel P. Berrangé

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread Eric Blake
On 03/12/2018 11:49 PM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- checkpatch.pl complains on every single changed line as it keeps using tabs - do I need to post 's/\t//g'? No. checkpatch.pl is guidance, but even stronger is 'be consistent to

[Qemu-devel] [PULL 10/11] target/m68k: implement fsinh

2018-03-13 Thread Laurent Vivier
Using a local m68k floatx80_sinh() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-11-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 +++ target/m68k/helper.h |

[Qemu-devel] [PULL 03/11] target/m68k: implement fcos

2018-03-13 Thread Laurent Vivier
Using a local m68k floatx80_cos() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier Message-Id: <20180312202728.23790-4-laur...@vivier.eu> --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h | 1

<    1   2   3   4   5   6   >