Re: [Qemu-devel] [PULL 0/9] Socket next patches

On Tue, Mar 13, 2018 at 04:27:08PM +, Daniel P. Berrangé wrote: > On Tue, Mar 13, 2018 at 04:20:19PM +, Peter Maydell wrote: > > On 12 March 2018 at 20:12, Daniel P. Berrangé wrote: > > > The following changes since commit > > >

Re: [Qemu-devel] [PATCH v12 08/28] target/i386: add Secure Encrypted Virtulization (SEV) object

On Tue, Mar 13, 2018 at 09:42:51AM +0100, Paolo Bonzini wrote: > On 08/03/2018 23:44, Eduardo Habkost wrote: > >> I think doing so will be an issue for the migration. Consider your above > >> use case, a SEV guest is running on EPYC with cbitpos=47 and if we > >> migrate to some $NEXT AMD CPU

[Qemu-devel] [PATCH v11 04/13] dirty-bitmap: add locked state

Add special state, when qmp operations on the bitmap are disabled. It is needed during bitmap migration. "Frozen" state is not appropriate here, because it looks like bitmap is unchanged. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v11 11/13] migration: add postcopy migration of dirty bitmaps

13.03.2018 21:22, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap (for the

Re: [Qemu-devel] [PATCH 1/2] qcow2: Give the refcount cache the minimum possible size by default

On 03/13/2018 10:02 AM, Alberto Garcia wrote: The L2 and refcount caches have default sizes that can be overriden using the l2-cache-size and refcount-cache-size (an additional parameter named cache-size sets the combined size of both caches). Unless forced by one of the aforementioned

Re: [Qemu-devel] [PULL 18/41] blockjobs: add block-job-finalize

On 03/13/2018 11:17 AM, Kevin Wolf wrote: From: John Snow Instead of automatically transitioning from PENDING to CONCLUDED, gate the .prepare() and .commit() phases behind an explicit acknowledgement provided by the QMP monitor if auto_finalize = false has been requested.

[Qemu-devel] [PATCH v11 10/13] migration: allow qmp command migrate-start-postcopy for any postcopy

Allow migrate-start-postcopy for any postcopy type Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 094196c236..59b4fe6090

Re: [Qemu-devel] [PULL 0/9] Socket next patches

On 13 March 2018 at 18:23, Daniel P. Berrangé wrote: > On Tue, Mar 13, 2018 at 04:27:08PM +, Daniel P. Berrangé wrote: >> This feels unrelated to the series, so possibly a non-deterministic >> failure > > Looking at the test source code, it has a 60 second wait for the >

[Qemu-devel] [PULL v2 8/9] char: refactor parsing of socket address information

From: "Daniel P. Berrange" To prepare for handling more address types, refactor the parsing of socket address information to make it more robust and extensible. Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH v11 08/13] migration/qemu-file: add qemu_put_counted_string()

Add function opposite to qemu_get_counted_string. qemu_put_counted_string puts one-byte length of the string (string should not be longer than 255 characters), and then it puts the string, without last zero byte. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

[Qemu-devel] [PULL v2 6/9] sockets: check that the named file descriptor is a socket

From: "Daniel P. Berrange" The SocketAddress struct has an "fd" type, which references the name of a file descriptor passed over the monitor using the "getfd" command. We currently blindly assume the FD is a socket, which can lead to hard to diagnose errors later. This adds

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

Yes, it looks like we accidentally broke icount. This patch from the mailing list fixes it: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg06595.html though it hasn't been code-reviewed yet. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v11 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20180207155837.92351-4-vsement...@virtuozzo.com Signed-off-by: John Snow --- include/block/dirty-bitmap.h | 3 +++ block/dirty-bitmap.c | 28

Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12

On Tue, Mar 13, 2018 at 06:29:10PM +, Peter Maydell wrote: > On 12 March 2018 at 22:34, Eduardo Habkost wrote: > > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > Merge remote-tracking branch > >

[Qemu-devel] [PULL v2 4/9] sockets: strengthen test suite IP protocol availability checks

From: "Daniel P. Berrange" Instead of just checking whether it is possible to bind() on a socket, also check that we can successfully connect() to the socket we bound to. This more closely replicates the level of functionality that tests will actually use. Reviewed-by: Eric

[Qemu-devel] [PULL 13/18] linux-user: init_guest_space: Correctly handle guest_start in commpage initialization

From: Luke Shumaker init_guest_commpage needs to check if the mapped space, which ends at real_start+real_size overlaps with where it needs to put the commpage, which is (assuming sane qemu_host_page_size) guest_base + 0x000, where guest_base is real_start -

[Qemu-devel] [PULL v2 3/9] sockets: pull code for testing IP availability out of specific test

From: "Daniel P. Berrange" The test-io-channel-socket.c file has some useful helper functions for checking if a specific IP protocol is available. Other tests need to perform similar kinds of checks to avoid running tests that will fail due to missing IP protocols.

Re: [Qemu-devel] [PATCH 2/2] docs: Document the new default sizes of the qcow2 caches

On 03/13/2018 10:02 AM, Alberto Garcia wrote: We have just reduced the refcount cache size to the minimum unless the user explicitly requests a larger one, so we have to update the documentation to reflect this change. Signed-off-by: Alberto Garcia --- docs/qcow2-cache.txt

[Qemu-devel] [PULL 18/18] linux-user: init_guest_space: Add a comment about search strategy

From: Luke Shumaker Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-10-luke...@lukeshu.com> Reviewed-by: Peter Maydell Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 4 1 file

Re: [Qemu-devel] [PATCH v11 11/13] migration: add postcopy migration of dirty bitmaps

* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated. > > If destination qemu is already containing a dirty bitmap with the same name > as a migrated bitmap (for the same node), then, if their granularities

Re: [Qemu-devel] [PATCH v11 05/13] migration: introduce postcopy-only pending

* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > There would be savevm states (dirty-bitmap) which can migrate only in > postcopy stage. The corresponding pending is introduced here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr.

[Qemu-devel] [PULL 16/18] linux-user: init_guest_space: Clean up control flow a bit

From: Luke Shumaker Instead of doing if (check1) { if (check2) { success; } } retry; Do a clearer if (!check1) { goto try_again; } if (!check2) { goto try_again;

Re: [Qemu-devel] [PULL 0/4] Python queue, 2018-03-12

On 12 March 2018 at 22:11, Eduardo Habkost wrote: > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 > 16:14:37 +) > > are

[Qemu-devel] [PULL 17/18] linux-user: init_guest_space: Don't try to align if we'll reject it

From: Luke Shumaker If the ensure-alignment code gets triggered, then the "if (host_start && real_start != current_start)" check will always trigger, so save 2 syscalls and put that check first. Note that we can't just switch to using MAP_FIXED for that check, because then

[Qemu-devel] [PULL 07/18] linux-user: fix target_mprotect/target_munmap error return values

From: Max Filippov target_mprotect/target_munmap return value goes through get_errno at the call site, thus the functions must either set errno to host error code and return -1 or return negative guest error code. Do the latter. Cc: qemu-sta...@nongnu.org Cc: Riku Voipio

[Qemu-devel] [PULL v2 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled

From: "Daniel P. Berrange" Even if common tn3270 implementations do not support TLS, it is trivial to have them proxied over a proxy like stunnel which adds TLS at the sockets layer. We should thus not silently skip tn3270 protocol initialization when TLS is enabled.

[Qemu-devel] [PATCH v11 11/13] migration: add postcopy migration of dirty bitmaps

Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap (for the same node), then, if their granularities are the same the migration will be done, otherwise the error will be

[Qemu-devel] [PULL 14/18] linux-user: init_guest_space: Clarify page alignment logic

From: Luke Shumaker There are 3 parts to this change: - Add a comment showing the relative sizes and positions of the blocks of memory - introduce and use new aligned_{start,size} instead of adjusting real_{start_size} - When we clean up (on failure),

[Qemu-devel] [PULL 03/18] linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh

qemu-binfmt-conf.sh when it is used with systemd needs to know for which CPU the systemd-binfmt.service file must be created (i.e. "--systemd ppc"). But sometime, for instance for test purpose, we need to create an entry for all known architectures. This patch entroduce the "ALL" parameter for

[Qemu-devel] [PATCH v11 12/13] iotests: add dirty bitmap migration test

The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/169 | 156

[Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44: memory: fix flatview_access_valid RCU read lock/unlock imbalance (2018-03-09 15:55:20 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-2.12-pull-request for you

[Qemu-devel] [PATCH v11 09/13] migration: add is_active_iterate handler

Only-postcopy savevm states (dirty-bitmap) don't need live iteration, so to disable them and stop transporting empty sections there is a new savevm handler. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: John

[Qemu-devel] [PULL 11/18] linux-user: Rename validate_guest_space => init_guest_commpage

From: Luke Shumaker init_guest_commpage is a much more honest description of what the function does. validate_guest_space not only suggests that the function has no side-effects, but also introduces confusion as to why it is only needed on 32-bit ARM targets.

[Qemu-devel] [PATCH v11 07/13] migration: include migrate_dirty_bitmaps in migrate_postcopy

Enable postcopy if dirty bitmap migration is enabled. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela Reviewed-by: John Snow Reviewed-by: Fam Zheng --- migration/migration.c | 2 +- 1

[Qemu-devel] [PATCH v11 05/13] migration: introduce postcopy-only pending

There would be savevm states (dirty-bitmap) which can migrate only in postcopy stage. The corresponding pending is introduced here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/register.h | 17 +++-- migration/savevm.h | 5

[Qemu-devel] [PULL 02/18] linux-user: Remove the unused "not implemented" signal handling stubs

From: Peter Maydell Now we've dropped unicore32, all of the architectures we support for linux-user implement the signal handling routines. The dummy "just print a message" versions are unimplemented, so we can drop them entirely. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PULL 00/41] Block layer patches

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180313161803.1814-1-kw...@redhat.com Subject: [Qemu-devel] [PULL 00/41] Block layer patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration

Hi all! There is a new version of dirty bitmap postcopy migration series. Patches 01-04 are directly from John's branch https://github.com/jnsnow/qemu/tree/bitmaps , they are included only for patchew. v11 clone: tag postcopy-v11 from https://src.openvz.org/scm/~vsementsov/qemu.git online:

[Qemu-devel] [PATCH v11 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()

Enabling bitmap successor is necessary to enable successors of bitmaps being migrated before target vm start. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Fam Zheng Message-id:

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

On 03/13/2018 08:18 PM, John Snow wrote: > > On 11/28/2017 07:10 AM, Denis V. Lunev wrote: >> There are 2 cases I have spotted so far: >> 1) IDE ATAPI read processing. Actually this was reported from field >> 2) QEMU IO hmp command (found during evaluation of (1)) >> >> SCSI code checks during

[Qemu-devel] [PATCH v11 13/13] iotests: add dirty bitmap postcopy test

Test - start two vms (vm_a, vm_b) - in a - do writes from set A - do writes from set B - fix bitmap sha256 - clear bitmap - do writes from set A - start migration - than, in b - wait vm start (postcopy should start) - do writes from set B - check bitmap sha256

[Qemu-devel] [PULL 14/17] nbd: BLOCK_STATUS for standard get_block_status function: client part

From: Vladimir Sementsov-Ogievskiy Minimal realization: only one extent in server answer is supported. Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:

[Qemu-devel] [PATCH v11 02/13] block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap

Like other setters here these functions should take a lock. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng Reviewed-by: John Snow Message-id: 20180207155837.92351-3-vsement...@virtuozzo.com Signed-off-by: John

[Qemu-devel] [PULL 13/17] block/nbd-client: save first fatal error in nbd_iter_error

From: Vladimir Sementsov-Ogievskiy It is ok, that fatal error hides previous not fatal, but hiding first fatal error is a bad feature. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id:

Re: [Qemu-devel] Deprecate tilegx ?

On 13 March 2018 at 17:18, Bastian Koppelmann wrote: > On 03/09/2018 04:13 PM, Alex Bennée wrote: >> >> Bastian Koppelmann writes: > > [...] >>> >>> I always saw it as a big plus that QEMU supports nearly any >>> architecture, no

Re: [Qemu-devel] [PATCH v10 10/12] migration: add postcopy migration of dirty bitmaps

* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 12.03.2018 19:09, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > Postcopy migration of dirty bitmaps. Only named dirty bitmaps are > > > migrated. > > > > > > + > > > +

[Qemu-devel] [PULL 15/17] iotests.py: tiny refactor: move system imports up

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20180312152126.286890-7-vsement...@virtuozzo.com> Signed-off-by: Eric Blake ---

[Qemu-devel] [PULL 10/17] nbd/server: add nbd_opt_invalid helper

From: Vladimir Sementsov-Ogievskiy NBD_REP_ERR_INVALID is often parameter to nbd_opt_drop and it would be used more in following patches. So, let's add a helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[Qemu-devel] [PULL 15/18] linux-user: init_guest_commpage: Add a comment about size check

From: Luke Shumaker Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-7-luke...@lukeshu.com> Reviewed-by: Peter Maydell Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 5 + 1 file

[Qemu-devel] [PULL 16/17] iotests: add file_path helper

From: Vladimir Sementsov-Ogievskiy Simple way to have auto generated filenames with auto cleanup. Like FilePath but without using 'with' statement and without additional indentation of the whole test. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 06/17] nbd/server: refactor nbd_trip: split out nbd_handle_request

From: Vladimir Sementsov-Ogievskiy Split out request handling logic. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180308184636.178534-6-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: touch up

[Qemu-devel] [PULL 12/18] linux-user: init_guest_space: Clean up if we can't initialize the commpage

From: Luke Shumaker We'll just exit with an error anyway, so it doesn't really matter, but it is cleaned up in all of the other places were we error out. Signed-off-by: Luke Shumaker Message-Id: <20171228180814.9749-4-luke...@lukeshu.com> Reviewed-by:

[Qemu-devel] [PULL 10/18] linux-user: Use #if to only call validate_guest_space for 32-bit ARM target

From: Luke Shumaker Instead of defining a bogus validate_guest_space that always returns 1 on targets other than 32-bit ARM, use #if blocks to only call it on 32-bit ARM targets. This makes the "normal" flow control clearer. Signed-off-by: Luke Shumaker

[Qemu-devel] [PULL 17/17] iotests: new test 209 for NBD BLOCK_STATUS

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180312152126.286890-9-vsement...@virtuozzo.com> Signed-off-by: Eric Blake --- tests/qemu-iotests/209 | 34

[Qemu-devel] [PULL 08/18] linux-user: drop unused target_msync function

From: Max Filippov target_msync is not used, remove its declaration and implementation. Cc: Riku Voipio Cc: Laurent Vivier Signed-off-by: Max Filippov Reviewed-by: Laurent Vivier Message-Id:

[Qemu-devel] [PULL 08/17] block: let blk_add/remove_aio_context_notifier() tolerate BDS changes

From: Stefan Hajnoczi Commit 2019ba0a0197 ("block: Add AioContextNotifier functions to BB") added blk_add/remove_aio_context_notifier() and implemented them by passing through the bdrv_*() equivalent. This doesn't work across bdrv_append(), which detaches child->bs and

[Qemu-devel] [PULL 09/17] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

From: Stefan Hajnoczi This test case adds an NBD server export and then invokes blockdev-snapshot-sync, which changes the BlockDriverState node that the NBD server's BlockBackend points to. This is an interesting scenario to test and exercises the code path fixed by the

[Qemu-devel] [PULL 01/18] linux-user: Drop unicore32 code

From: Peter Maydell We dropped the unicore32-linux-user target in commit 5e2b40f7271cf9 in 2016. Nobody has made any attempt to fix the issues that caused us to drop it, so remove the associated code. (The system emulation parts of unicore32 remain.) Signed-off-by:

[Qemu-devel] [PULL 02/17] nbd/server: move nbd_co_send_structured_error up

From: Vladimir Sementsov-Ogievskiy To be reused in nbd_co_send_sparse_read() in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180308184636.178534-2-vsement...@virtuozzo.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL 09/18] qemu-binfmt-conf.sh: add qemu-xtensa

From: Max Filippov Register qemu-xtensa and qemu-xtensaeb for transparent linux userspace emulation. Cc: Riku Voipio Cc: Laurent Vivier Signed-off-by: Max Filippov Reviewed-by: Laurent Vivier

[Qemu-devel] [PULL 01/17] iotests: Fix stuck NBD process on 33

Commit afe35cde6 added additional actions to test 33, but forgot to reset the image between tests. As a result, './check -nbd 33' fails because the qemu-nbd process from the first half is still occupying the port, preventing the second half from starting a new qemu-nbd process. Worse, the

[Qemu-devel] [PULL 05/18] linux-user: fix mmap/munmap/mprotect/mremap/shmat

From: Max Filippov In linux-user QEMU that runs for a target with TARGET_ABI_BITS bigger than L1_MAP_ADDR_SPACE_BITS an assertion in page_set_flags fires when mmap, munmap, mprotect, mremap or shmat is called for an address outside the guest address space. mmap and mprotect

[Qemu-devel] [PULL 04/18] linux-user: Support f_flags in statfs when available.

From: Shea Levy Signed-off-by: Shea Levy Reviewed-by: Laurent Vivier Message-Id: <2018030500.15717-1-s...@shealevy.com> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 5 +

[Qemu-devel] [PULL 03/17] nbd/server: fix sparse read

From: Vladimir Sementsov-Ogievskiy In case of io error in nbd_co_send_sparse_read we should not "goto reply:", as it was a fatal error and the common behavior is to disconnect in this case. We should not try to send the client an additional error reply, since we already

[Qemu-devel] [PULL 00/17] NBD patches for 2018-03-13 (2.12 softfreeze)

The following changes since commit 59667bb167f773965ce6547352f312eff0d4d523: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-03-13 14:02:47 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-03-13

[Qemu-devel] [PULL 06/18] linux-user: fix assertion in shmdt

From: Max Filippov shmdt fails to call mmap_lock/mmap_unlock around page_set_flags, resulting in the following assertion: page_set_flags: Assertion `have_mmap_lock()' failed. Wrap shmdt internals into mmap_lock/mmap_unlock. Cc: qemu-sta...@nongnu.org Cc: Riku Voipio

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

Hi Alex, On 13/03/18 17:56, Alex Williamson wrote: > [Cc +Eric] > > On Tue, 13 Mar 2018 15:53:19 +1100 > Alexey Kardashevskiy wrote: > >> On 7/3/18 1:17 pm, Alexey Kardashevskiy wrote: >>> On 26/02/18 19:36, Alexey Kardashevskiy wrote: On 19/02/18 13:46, Alexey

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

On 03/13/2018 12:33 PM, Vladimir Sementsov-Ogievskiy wrote: > 13.03.2018 19:16, John Snow wrote: >> >> On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hmm, I agree, it is the simplest thing we can do for now, and I'll >>> rethink later, >>> how (and is it worth doing) to go to

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

On 01/19/2018 06:03 PM, Eric Blake wrote: > On 01/19/2018 04:47 PM, John Snow wrote: >> Adjust each caller of raw_open_common to specify if they are expecting >> host and character devices or not. Tighten expectations of file types upon >> open in the common code and refuse types that are not

Re: [Qemu-devel] Deprecate tilegx ?

On 03/09/2018 04:13 PM, Alex Bennée wrote: Bastian Koppelmann writes: [...] I always saw it as a big plus that QEMU supports nearly any architecture, no matter how obscure it is. So I'm a bit more hesitant on dropping architectures quickly. All things being

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

On 13 March 2018 at 16:55, Andrew Baumann wrote: >> From: Qemu-devel > bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter >> Maydell >> Sent: Tuesday, 13 March 2018 08:35 >> >> Now we have separate types for BCM2386 and BCM2387, we might as well >>

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

On 11/28/2017 07:10 AM, Denis V. Lunev wrote: > There are 2 cases I have spotted so far: > 1) IDE ATAPI read processing. Actually this was reported from field > 2) QEMU IO hmp command (found during evaluation of (1)) > > SCSI code checks during access that blk_is_available(). These patches add

[Qemu-devel] [PULL 07/17] nbd/server: Honor FUA request on NBD_CMD_TRIM

The NBD spec states that since trim requests can affect disk contents, then they should allow for FUA semantics just like writes for ensuring the disk has settled before returning. As bdrv_[co_]pdiscard() does not support a flags argument, we can't pass FUA down the block layer stack, and must

Re: [Qemu-devel] [PATCH v4 4/4] target/arm: Add arm_gdb_set_sysreg() callback

On 12 March 2018 at 10:31, Abdallah Bouassida wrote: > This is a callback to set the cp-regs registered by the dynamic XML. > > Signed-off-by: Abdallah Bouassida > --- >>> Adding to that our customers may need this write

[Qemu-devel] [PULL 04/17] nbd/server: fix: check client->closing before sending reply

From: Vladimir Sementsov-Ogievskiy Since the unchanged code has just set client->recv_coroutine to NULL before calling nbd_client_receive_next_request(), we are spawning a new coroutine unconditionally, but the first thing that coroutine will do is check for

[Qemu-devel] [PULL 12/17] nbd: BLOCK_STATUS for standard get_block_status function: server part

From: Vladimir Sementsov-Ogievskiy Minimal realization: only one extent in server answer is supported. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180312152126.286890-4-vsement...@virtuozzo.com> Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

[Cc +Eric] On Tue, 13 Mar 2018 15:53:19 +1100 Alexey Kardashevskiy wrote: > On 7/3/18 1:17 pm, Alexey Kardashevskiy wrote: > > On 26/02/18 19:36, Alexey Kardashevskiy wrote: > >> On 19/02/18 13:46, Alexey Kardashevskiy wrote: > >>> On 16/02/18 16:28, David Gibson wrote: >

[Qemu-devel] [PULL 11/17] nbd/server: add nbd_read_opt_name helper

From: Vladimir Sementsov-Ogievskiy Add helper to read name in format: uint32 len (<= NBD_MAX_NAME_SIZE) len bytes string (not 0-terminated) The helper will be reused in following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter > Maydell > Sent: Tuesday, 13 March 2018 08:35 > > Now we have separate types for BCM2386 and BCM2387, we might as well > just hard-code the CPU type they use rather than having it passed > through as an

[Qemu-devel] [PULL 05/17] nbd/server: refactor nbd_trip: cmd_read and generic reply

From: Vladimir Sementsov-Ogievskiy nbd_trip has difficult logic when sending replies: it tries to use one code path for all replies. It is ok for simple replies, but is not comfortable for structured replies. Also, two types of error (and corresponding messages in

[Qemu-devel] [PULL 1/3] .travis.yml: drop setting default log output

The log backend is the default one, we don't need to explicitly set it. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé diff --git a/.travis.yml b/.travis.yml index 79377c8de0..92c343a1ef 100644 --- a/.travis.yml +++ b/.travis.yml @@

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: Add the XML dynamic generation

On 12 March 2018 at 10:31, Abdallah Bouassida wrote: > Generate an XML description for the cp-regs. > Register these regs with the gdb_register_coprocessor(). > Add arm_gdb_get_sysreg() to use it as a callback to read those regs. > Add a dummy

Re: [Qemu-devel] [PATCH v10 08/24] migration: Add multifd test

* Juan Quintela (quint...@redhat.com) wrote: > We set the x-multifd-page-count and x-multifd-channels. > > Signed-off-by: Juan Quintela This should probably go nearer the end of the series; we've also got the problem that things are a bit delicate with TCG so adding more

Re: [Qemu-devel] [PATCH 7/9] hw/arm/bcm2836: Use correct affinity values for BCM2837

On 13 March 2018 at 16:48, Andrew Baumann wrote: >> From: Peter Maydell >> Sent: Tuesday, 13 March 2018 08:35 >> >> The BCM2837 sets the Aff1 field of the MPIDR affinity values for the >> CPUs to 0, whereas the BCM2836 uses 0xf. Set this

Re: [Qemu-devel] [PATCH 5/9] hw/arm/bcm2836: Rename bcm2836 type/struct to bcm283x

> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter > Maydell > Sent: Tuesday, 13 March 2018 08:35 > > Our BCM2836 type is really a generic one that can be any of > the bcm283x family. Rename it accordingly. We change only > the names which are visible via the

[Qemu-devel] [PULL 2/3] .travis.yml: split default config into system and user

As the build times have risen we keep timing out. Split the default config into system and user builds. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé diff --git a/.travis.yml b/.travis.yml index 92c343a1ef..75e5b408d0 100644 ---

Re: [Qemu-devel] [PATCH v1 4/4] .travis.yml: add --disable-tools to the modules build

Daniel P. Berrangé writes: > On Tue, Mar 13, 2018 at 03:32:10PM +, Alex Bennée wrote: >> The tools are already built elsewhere so we might as well not build it >> here as we just need to test the modules build of QEMU itself. >> >> Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH 6/9] hw/arm/bcm2836: Create proper bcm2837 device

> From: Peter Maydell > Sent: Tuesday, 13 March 2018 08:35 > > The bcm2837 is pretty similar to the bcm2836, but it does have > some differences. Notably, the MPIDR affinity aff1 values it > sets for the CPUs are 0x0, rather than the 0xf that the bcm2836 > uses, and if

Re: [Qemu-devel] [PATCH 4/9] hw/arm/bcm2386: Fix parent type of bcm2386

> From: Qemu-devel bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter > Maydell > Sent: Tuesday, 13 March 2018 08:35 > > The TypeInfo and state struct for bcm2386 disagree about what the > parent class is -- the TypeInfo says it's TYPE_SYS_BUS_DEVICE, > but the BCM2386State

[Qemu-devel] [PULL 3/3] .travis.yml: add --disable-user with the rest of the disables

As all the disabled features only affect system emulation we might as well disable user mode to save compile time. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé diff --git a/.travis.yml b/.travis.yml index 75e5b408d0..c1e99237b2 100644

Re: [Qemu-devel] [PATCH v10 10/12] migration: add postcopy migration of dirty bitmaps

12.03.2018 19:09, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: Postcopy migration of dirty bitmaps. Only named dirty bitmaps are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap (for the

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

13.03.2018 19:16, John Snow wrote: On 03/13/2018 12:14 PM, Vladimir Sementsov-Ogievskiy wrote: Hmm, I agree, it is the simplest thing we can do for now, and I'll rethink later, how (and is it worth doing) to go to postcopy automatically in case of only-dirty-bitmaps. Should I respin? Please

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

On 03/12/2018 11:49 PM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- checkpatch.pl complains on every single changed line as it keeps using tabs - do I need to post 's/\t//g'? No. checkpatch.pl is guidance, but even stronger is 'be consistent to

Re: [Qemu-devel] [PULL 0/9] Socket next patches

On 12 March 2018 at 20:12, Daniel P. Berrangé wrote: > The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 > 13:21:53 +) > > are

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

On Tue, 13 Mar 2018 15:52:41 + Stefan Hajnoczi wrote: > On Tue, Mar 13, 2018 at 3:25 PM, nee wrote: > > On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > >> On Mon, 12 Mar 2018 13:08:29 + > >> Daniel P. Berrangé

[Qemu-devel] [PULL v2 00/22] KVM patches for QEMU 2.12 soft freeze

The following changes since commit fb5fff15881ba7a002924b967eb211c002897983: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180312-pull-request' into staging (2018-03-12 18:35:37 +) are available in the git repository at: git://github.com/bonzini/qemu.git

[Qemu-devel] [PULL 41/41] block/mirror: change the semantic of 'force' of block-job-cancel

From: Liang Li When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the

[Qemu-devel] [PULL 26/41] luks: Catch integer overflow for huge sizes

When you request an image size close to UINT64_MAX, the addition of the crypto header may cause an integer overflow. Catch it instead of silently truncating the image size. Signed-off-by: Kevin Wolf Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 5

Re: [Qemu-devel] [PATCH] iotests: Update output of 051 and 186 after commit 1454509726719e0933c

Am 13.03.2018 um 17:22 hat Thomas Huth geschrieben: > On 13.03.2018 17:08, Kevin Wolf wrote: > > Am 06.03.2018 um 17:52 hat Thomas Huth geschrieben: > >> On 06.03.2018 17:45, Alberto Garcia wrote: > >>> Signed-off-by: Alberto Garcia > >>> --- > >>> tests/qemu-iotests/051.pc.out

[Qemu-devel] [PULL 40/41] vpc: Require aligned size in .bdrv_co_create

Perform the rounding to match a CHS geometry only in the legacy code path in .bdrv_co_create_opts. QMP now requires that the user already passes a CHS aligned image size, unless force-size=true is given. CHS alignment is required to make the image compatible with Virtual PC, but not for use with

<    1   2   3   4   5   6   >