[Qemu-devel] [PULL 00/12] target-arm queue

2018-04-10 Thread Peter Maydell
ble in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180410 for you to fetch changes up to bd49e6027cbc207c87633c7add3ebd7d3474cd35: fpu: Fix rounding mode for floatN_to_uintM_round_to_zero (2018-04-10 13:02

[Qemu-devel] [PULL 03/12] target-arm: Check undefined opcodes for SWP in A32 decoder

2018-04-10 Thread Peter Maydell
From: Onur Sahin Make sure we are not treating architecturally Undefined instructions as a SWP, by verifying the opcodes as per section A8.8.229 of ARMv7-A specification. Bits [21:20] must be zero for this to be a SWP or SWPB. We also choose to UNDEF for the architecturally UNPREDICTABLE case of

[Qemu-devel] [PULL 02/12] hw/arm/integratorcp: Don't do things that could be fatal in the instance_init

2018-04-10 Thread Peter Maydell
From: Thomas Huth An instance_init function must not fail - and might be called multiple times, e.g. during device introspection with the 'device-list-properties' QMP command. Since the integratorcm device ignores this rule, QEMU currently aborts in this case (though it really should not): echo

[Qemu-devel] [PULL 01/12] hw/arm: Allow manually specified /psci node

2018-04-10 Thread Peter Maydell
From: Andrey Smirnov Change the code to avoid exiting QEMU if user provided DTB contains manually specified /psci node and skip any /psci related fixups instead. Fixes: 4cbca7d9b4 ("hw/arm: Move virt's PSCI DT fixup code to arm/boot.c") Signed-off-by: Andrey Smirnov Reported-by: Marc Zyngier

[Qemu-devel] [PULL 06/12] hw/arm/allwinner-a10: Do not use nd_table in instance_init function

2018-04-10 Thread Peter Maydell
From: Thomas Huth The instance_init function of a device can be called at any time, even if the device is not going to be used (i.e. not going to be realized). So a instance_init function must not do things that could cause QEMU to exit, like calling qemu_check_nic_model(&nd_table[0], ...) for ex

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Kevin Wolf
Am 10.04.2018 um 12:40 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 10.04.2018 um 10:45 hat Dr. David Alan Gilbert geschrieben: > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > Am 10.04.2018 um 09:36 hat Jiri Denemark geschrieben: > > > > > On Mon, Apr

Re: [Qemu-devel] [PATCH] qemu-iotests: Remove _supported_fmt dmg

2018-04-10 Thread Eric Blake
On 04/10/2018 03:42 AM, Kevin Wolf wrote: > qemu-iotests doesn't support dmg, and the dmg block driver doesn't > support image creation. Two test cases declare dmg as supported, but > that's obviously wrong for both reasons. Remove the declaration. > > Signed-off-by: Kevin Wolf > --- > tests/qem

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Gerd Hoffmann
> -if (dpy.has_gl && dpy.gl && display_opengl == 0) { > +if (dpy.has_gl && !dpy.gl == DISPLAYGL_MODE_OFF && display_opengl == 0) { That should be "... && !(dpy.gl == DISPLAYGL_MODE_OFF) && ..." to work correctly. Or just "dpy.gl != DISPLAYGL_MODE_OFF" ... cheers, Gerd

Re: [Qemu-devel] [PATCH v2 2/2] sdl: Allow OpenGL ES context creation

2018-04-10 Thread Gerd Hoffmann
On Tue, Apr 10, 2018 at 01:02:22PM +0100, Elie Tournier wrote: > Signed-off-by: Elie Tournier > --- > include/ui/sdl2.h | 1 + > qemu-options.hx | 2 +- > ui/sdl2-gl.c | 17 +++-- > ui/sdl2.c | 1 + > vl.c | 4 > 5 files changed, 22 insertions(+),

Re: [Qemu-devel] [PATCH for-2.12 v2] monitor: bind dispatch bh to iohandler context

2018-04-10 Thread Eric Blake
On 04/10/2018 12:01 AM, Stefan Hajnoczi wrote: > On Tue, Apr 10, 2018 at 12:49:42PM +0800, Peter Xu wrote: >> Eric Auger reported the problem days ago that OOB broke ARM when running >> with libvirt: >> >> http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html >> >> The problem was that

[Qemu-devel] [PATCH 1/2] qemu-thread: always keep the posix wrapper layer

2018-04-10 Thread Peter Xu
We will conditionally have a wrapper layer depending on whether the host has the PTHREAD_SETNAME capability. It complicates stuff. Let's just keep the wrapper there, meanwhile we opt out the pthread_setname_np() call only. The layer can be helpful in future patches to pass data from the parent t

[Qemu-devel] [PATCH 0/2] qemu-thread: allow cur_mon be per thread

2018-04-10 Thread Peter Xu
This should be for 2.13. But I'd like to get early review comments too if there is any. Now cur_mon is still only be accessed by the main thread. So we don't even need per-thread cur_mon. However after more commands become OOB compatible, cur_mon can be accessed by more than main thread now. T

[Qemu-devel] [PULL 1/7] target/ppc: Initialize lazy_tlb_flush correctly

2018-04-10 Thread David Gibson
ppc_tr_init_disas_context() correctly sets lazy_tlb_flush to true on certain CPU models. However, it leaves it uninitialized, instead of setting it to false on all others. It wasn't caught before now because we didn't have examples in the tests that exercised this path. However it can now be cau

[Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Peter Xu
cur_mon was only used in main loop so we don't really need that to be per-thread variable. Now it's possible that we have more than one thread to operate on it. Let's start to let it be per-thread variable. In case we'll create threads within a valid cur_mon setup, we'd better let the child thre

[Qemu-devel] [PULL 6/7] sam460ex: Fix timer frequency and clock multipliers

2018-04-10 Thread David Gibson
From: BALATON Zoltan We only emulate timer running at CPU frequency which is what most guests expect so set the frequency to match real hardware. This also allows setting clock multipliers which caused slowdown previously due to wrong timer frequency. Signed-off-by: BALATON Zoltan Signed-off-by

[Qemu-devel] [PULL 0/7] ppc-for-2.12 queue 20180410

2018-04-10 Thread David Gibson
The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-04-09 17:29:10 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.12-201

[Qemu-devel] [PULL 2/7] hw/misc/macio: Fix crash when listing device properties of macio device

2018-04-10 Thread David Gibson
From: Thomas Huth The macio-newworld device can currently be used to abort QEMU unexpectedly: $ ppc-softmmu/qemu-system-ppc -S -M ref405ep,accel=qtest -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 11, "major": 2}, "package": "build-all"}, "capabilities": []}} { 'execute': 'qmp_

Re: [Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Ensure AArch64 signal frame isn't too small

2018-04-10 Thread Peter Maydell
On 9 April 2018 at 23:05, Richard Henderson wrote: > On 04/10/2018 12:07 AM, Peter Maydell wrote: >> In particular the dash shell >> would segfault if the frame wasn't as big enough. > > Ah, that was the critical difference in my failure to replicate -- the fedora > sysroot doesn't have dash. As

Re: [Qemu-devel] [PATCH for-2.12] commit/stream: Reset delay_ns

2018-04-10 Thread Eric Blake
On 04/10/2018 03:58 AM, Kevin Wolf wrote: > Streaming and the commit block job only want to apply throttling when > they actually copied data instead of skipping it, so they made the > calculation of delay_ns conditional. However, delay_ns isn't reset when > skipping some sectors, so instead of not

[Qemu-devel] [PULL 4/7] spapr: Initialize reserved areas list in FDT in H_CAS handler

2018-04-10 Thread David Gibson
From: Alexey Kardashevskiy At the moment the device tree produced by the H_CAS handler has no reserved map initialized at all which is not correct as at least one empty record is required to be present as a marker of the end. This does not cause problems now as the only consumer is SLOF which doe

[Qemu-devel] [PULL 3/7] target/ppc: Fix backwards migration of msr_mask

2018-04-10 Thread David Gibson
21b786f "PowerPC: Add TS bits into msr_mask" added the transaction states to msr_mask for recent POWER CPUs to allow correct migration of machines that are in certain interim transactional memory states. This was correct, but unfortunately breaks backwards of pseries-2.7 and earlier machine types

Re: [Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 11:24:37 +1000, Richard Henderson wrote: > On 04/07/2018 04:20 AM, Emilio G. Cota wrote: > > +next_page = (ctx->base.pc_first & TARGET_PAGE_MASK) + > > TARGET_PAGE_SIZE; > > +if (ctx->base.pc_next >= next_page) { > > This fails for the last page of the addr

[Qemu-devel] [PULL 7/7] roms/u-boot-sam460ex: Change to qemu git mirror and update

2018-04-10 Thread David Gibson
From: BALATON Zoltan Now that we have a mirror of this repo on git.qemu.org change the submodule to use that and update it to latest commit which fixes a dangling symlink and removes two big binaries that are not needed. Signed-off-by: BALATON Zoltan Signed-off-by: David Gibson --- .gitmodule

Re: [Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410120222.31845-1-tournier.e...@gmail.com Subject: [Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer. === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: > On 04/10/2018 02:11 AM, Emilio G. Cota wrote: > > On Mon, Apr 09, 2018 at 16:01:36 +0200, Bastian Koppelmann wrote: > >> Thanks for doing this grunt work. Me and a colleague were planning to do > >> this as well after converting the

[Qemu-devel] [PULL 5/7] tests/boot-serial: Test the sam460ex board

2018-04-10 Thread David Gibson
From: Thomas Huth We've got a U-Boot firmware for this board in our repository, and the firmware prints some output to the serial console, so we can check this board in the boot-serial tester, too. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- tests/boot-serial-test.c | 2 ++ 1 f

Re: [Qemu-devel] [PATCH for-2.12] fpu: Fix rounding mode for floatN_to_uintM_round_to_zero

2018-04-10 Thread Alex Bennée
Richard Henderson writes: > We incorrectly passed in the current rounding mode > instead of float_round_to_zero. > > Signed-off-by: Richard Henderson Oops, Reviewed-by: Alex Bennée > --- > > Found while runnning SVE RISU tests; it should be visible with the > right set of inputs to AdvSIMD

Re: [Qemu-devel] [PULL 0/6] Net patches

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 04:39, Jason Wang wrote: > The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-04-09 17:29:10 +0100) > > are available in the git repository at: > > https://g

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Eric Blake
On 04/10/2018 07:02 AM, Elie Tournier wrote: > Signed-off-by: Elie Tournier > --- > qapi/ui.json | 21 - > vl.c | 10 +- > 2 files changed, 25 insertions(+), 6 deletions(-) > > diff --git a/qapi/ui.json b/qapi/ui.json > index 5d01ad4304..c8005867e5 100644 > --

[Qemu-devel] [PATCH] timer: fix record/replay timerlist probe

2018-04-10 Thread Pavel Dovgalyuk
Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. Probing of the timerlists' clock instead of using them for the deadlines calculation is critical for the replay. Howeve

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Bastian Koppelmann
On 04/10/2018 03:03 PM, Emilio G. Cota wrote: > On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: >> On 04/10/2018 02:11 AM, Emilio G. Cota wrote: >>> On Mon, Apr 09, 2018 at 16:01:36 +0200, Bastian Koppelmann wrote: Thanks for doing this grunt work. Me and a colleague were plan

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

2018-04-10 Thread Tony Krowiak
On 04/06/2018 10:51 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilit

[Qemu-devel] [PULL 2/3] iothread: workaround glib bug which hangs qmp-test

2018-04-10 Thread Eric Blake
From: Peter Xu Free the AIO context earlier than the GMainContext (if we have) to workaround a glib2 bug that GSource context pointer is not cleared even if the context has already been destroyed (while it should). The patch itself only changed the order to destroy the objects, no functional cha

[Qemu-devel] [PULL 0/3] QAPI patches for 2018-04-10, 2.12-rc3

2018-04-10 Thread Eric Blake
The following changes since commit fb4fe32d5b6290deabe752b51cc1cc2a9e8573db: Merge remote-tracking branch 'remotes/xtensa/tags/20180409-xtensa' into staging (2018-04-10 10:22:45 +0100) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-qapi-2018-04-10 for you

[Qemu-devel] [PULL 3/3] monitor: bind dispatch bh to iohandler context

2018-04-10 Thread Eric Blake
From: Peter Xu Eric Auger reported the problem days ago that OOB broke ARM when running with libvirt: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The problem was that the monitor dispatcher bottom half was bound to qemu_aio_context now, which could be polled unexpectedly

[Qemu-devel] [PULL 1/3] iotests: fix wait_until_completed()

2018-04-10 Thread Eric Blake
From: Peter Xu If there are more than one events, wait_until_completed() might return the 2nd event even if the 1st event is JOB_COMPLETED, since the for loop will continue to run even if completed is set to True. It never happened before, but it can be triggered when OOB is enabled due to the R

[Qemu-devel] [Bug 1761027] Re: Unexpected error: "AioContext polling is not implemented on Windows"

2018-04-10 Thread Peter Maydell
** Summary changed: - Unexpected error + Unexpected error: "AioContext polling is not implemented on Windows" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761027 Title: Unexpected error: "AioCon

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Gerd Hoffmann
> # @off: Disable OpenGL (default). > > > + # 'on'Use OpenGL, pick context type automatically. > > + # Would better be named 'auto' but is called 'on' for backward > > + # compatibility with bool type. > > See below... > DisplayOptions was added in 2.12. This is a backwards-

Re: [Qemu-devel] [PATCH 1/2] qemu-thread: always keep the posix wrapper layer

2018-04-10 Thread Eric Blake
On 04/10/2018 07:49 AM, Peter Xu wrote: > We will conditionally have a wrapper layer depending on whether the host > has the PTHREAD_SETNAME capability. It complicates stuff. Let's just > keep the wrapper there, meanwhile we opt out the pthread_setname_np() > call only. The layer can be helpful

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 15:16:19 +0200, Bastian Koppelmann wrote: > On 04/10/2018 03:03 PM, Emilio G. Cota wrote: > > On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: > >> On 04/10/2018 02:11 AM, Emilio G. Cota wrote: > >>> On Mon, Apr 09, 2018 at 16:01:36 +0200, Bastian Koppelmann

[Qemu-devel] [PATCH for-2.12] hw/char/cmsdk-apb-uart.c: Correctly clear INTSTATUS bits on writes

2018-04-10 Thread Peter Maydell
The CMSDK APB UART INTSTATUS register bits are all write-one-to-clear. We were getting this correct for the TXO and RXO bits (which need special casing because their state lives in the STATE register), but had forgotten to handle the normal bits for RX and TX which we do store in our s->intstatus f

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-10 Thread Bastian Koppelmann
On 04/10/2018 03:40 PM, Emilio G. Cota wrote: > On Tue, Apr 10, 2018 at 15:16:19 +0200, Bastian Koppelmann wrote: >> On 04/10/2018 03:03 PM, Emilio G. Cota wrote: >>> On Tue, Apr 10, 2018 at 14:24:23 +1000, Richard Henderson wrote: On 04/10/2018 02:11 AM, Emilio G. Cota wrote: > On Mon, Ap

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Elie Tournier
On Tue, Apr 10, 2018 at 08:13:00AM -0500, Eric Blake wrote: > On 04/10/2018 07:02 AM, Elie Tournier wrote: > > Signed-off-by: Elie Tournier > > --- > > qapi/ui.json | 21 - > > vl.c | 10 +- > > 2 files changed, 25 insertions(+), 6 deletions(-) > > > > diff --

[Qemu-devel] QEMU - DOS - simulate DPR-RAM

2018-04-10 Thread Thomas.Schlitz
Hello, i have old DOS 6.22 Systems with a DPR (dual ported ram) at Adress d000:0 with 4kB size. Now i want to emulate this system with QEMU in Windows and want to read/write data to this DPR memoryblock from my Windows System. Can i do that? is there an option to emulate a Memoryblock at the ma

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-04-10 Thread Peter Maydell
On 15 March 2018 at 15:25, Laurent Vivier wrote: > Le 15/03/2018 à 16:13, James Cowgill a écrit : >> Add support for the two currently defined HWCAP bits on MIPS - R6 and >> MSA. >> >> Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 >> Signed-off-by: James Cowgill >> --- >> v2 changes: >>

Re: [Qemu-devel] [PATCH 2/2] qemu-thread: let cur_mon be per-thread

2018-04-10 Thread Eric Blake
On 04/10/2018 07:49 AM, Peter Xu wrote: > cur_mon was only used in main loop so we don't really need that to be > per-thread variable. Now it's possible that we have more than one > thread to operate on it. Let's start to let it be per-thread variable. > > In case we'll create threads within a v

[Qemu-devel] [Bug 1756519] Re: qemu linux-user crash in QOM path canonicalization during do_fork() call to cpu_create

2018-04-10 Thread Peter Maydell
Should be fixed by 73a988d957b9142e0 (which is the patch jcmvbkbc mentions in comment #4), now in master and will be in 2.12.0. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1760262] Re: cmsdk-apb-uart doesn't appear to clear interrupt flags

2018-04-10 Thread Peter Maydell
Thanks for the bug report; I've submitted this patch (which is similar to but not quite the same as your fix): https://patchwork.ozlabs.org/patch/896715/ Hopefully this will get into 2.12, but we're quite close to release now so it will depend on whether we need to spin an extra release candidate

[Qemu-devel] [Bug 1755479] Re: Cortex M:qemu abort with optimized code and icount

2018-04-10 Thread Peter Maydell
This is now fixed in master (and will be in 2.12.0) with commits 0790f8686107 and 87f963be66a32453e001. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-10 Thread Eric Blake
On 04/10/2018 07:59 AM, Emilio G. Cota wrote: > On Tue, Apr 10, 2018 at 11:24:37 +1000, Richard Henderson wrote: >> On 04/07/2018 04:20 AM, Emilio G. Cota wrote: >>> +next_page = (ctx->base.pc_first & TARGET_PAGE_MASK) + >>> TARGET_PAGE_SIZE; >>> +if (ctx->base.pc_next >= next_page

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-04-10 Thread Peter Maydell
Now fixed in master in commit a2e2d7fc46fd8be, so will be in 2.12.0. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1748434 Title: P

Re: [Qemu-devel] [PULL 0/4] Ui 20180410 patches

2018-04-10 Thread Peter Maydell
git repository at: > > git://git.kraxel.org/qemu tags/ui-20180410-pull-request > > for you to fetch changes up to c6093a05d6a84d2144bb6462cf20e907eddf8aeb: > > configure: don't warn SDL abi if disabled (2018-04-10 11:22:03 +0200) > > --

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-10 Thread Gerd Hoffmann
Hi, > Generally we try to cache mappings as much as possible. And wrt finding a > slot: Create a sufficiently sized BAR on the virgl device, just for that? Well. virtio has no concept of "bars" ... The most common virtio transport layer happens to be pci, which actually has bars. But we also

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 10.04.2018 um 12:40 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 10.04.2018 um 10:45 hat Dr. David Alan Gilbert geschrieben: > > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > > Am 10.04.2018 um 09:36 hat

Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 13:56:25 +1000, Richard Henderson wrote: > Ok, well, there are existing bugs within the MIPS translation here, and we > might as well fix them within this patch set. > > (1) The description for BS_STOP says we want to stop, but (what will become) > mips_tr_tb_stop calls got

Re: [Qemu-devel] [PATCH for-2.12] make-release: add skiboot .version file

2018-04-10 Thread Michael Roth
Quoting Peter Maydell (2018-04-10 02:31:04) > On 10 April 2018 at 01:57, Michael Roth wrote: > > This is needed to build skiboot from tarball-distributed sources > > since the git data the make_release.sh script relies on to generate > > it is not available. > > > > Cc: qemu-sta...@nongnu.org > >

[Qemu-devel] [Bug 1762707] Re: VFIO device gets DMA failures when virtio-balloon leak from highmem to lowmem

2018-04-10 Thread Alex Williamson
Ballooning is currently incompatible with device assignment. When the balloon is inflated (memory removed from the VM), the pages are zapped from the process without actually removing them from the vfio DMA mapping. The pages are still pinned from the previous mapping, making the balloon inflatio

Re: [Qemu-devel] [PATCH for-2.12] make-release: add skiboot .version file

2018-04-10 Thread Peter Maydell
On 10 April 2018 at 15:23, Michael Roth wrote: > Quoting Peter Maydell (2018-04-10 02:31:04) >> On 10 April 2018 at 01:57, Michael Roth wrote: >> > # FIXME: The following line is a workaround for avoiding filename >> > collisions >> > # when unpacking u-boot sources on case-insensitive filesys

Re: [Qemu-devel] [PATCH for-2.12 v2] qemu-iotests: update 185 output

2018-04-10 Thread Kevin Wolf
Am 10.04.2018 um 10:11 hat Stefan Hajnoczi geschrieben: > On Wed, Apr 04, 2018 at 06:16:12PM +0200, Max Reitz wrote: > > On 2018-04-04 17:01, Stefan Hajnoczi wrote: > > === Start mirror job and exit qemu === > > > > This seems to be independent of whether there is actually data on > > TEST_IMG (t

Re: [Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 09:05:06 -0500, Eric Blake wrote: > On 04/10/2018 07:59 AM, Emilio G. Cota wrote: > > On Tue, Apr 10, 2018 at 11:24:37 +1000, Richard Henderson wrote: > >> On 04/07/2018 04:20 AM, Emilio G. Cota wrote: > >>> +next_page = (ctx->base.pc_first & TARGET_PAGE_MASK) + > >

Re: [Qemu-devel] [PATCH] migration: Don't activate block devices if using -S

2018-04-10 Thread Kevin Wolf
Am 10.04.2018 um 16:22 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 10.04.2018 um 12:40 hat Dr. David Alan Gilbert geschrieben: > > > Hmm; having chatted to Jiri I'm OK with reverting it, on the condition > > > that I actually understand how this alternati

[Qemu-devel] [PATCH 0/4] Small fixes for s390x QEMU boot menu

2018-04-10 Thread Collin Walling
These patches fix the following: - The QEMU zIPL boot menu does not allow accurate selection of non-sequential entries. - The QEMU zIPL boot menu does not have all the capabilities of the real zIPL menu (such as commandline args). We should print a different banner

[Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix non-sequential boot entries (eckd)

2018-04-10 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 zIPL boot menu. Since this boot menu is actually an imitation and is not completely capable of everything the real zIPL menu can do, let's also print a different banner to the user. Signed-off-by: Collin Wallin

[Qemu-devel] [PATCH 2/4] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-04-10 Thread Collin Walling
Rename the loadparm char array in main.c to loadparm_str and increase the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. Also allow the boot menu to be enabled when loadparm is set to an empty string or a series of spaces. Signed-off-b

[Qemu-devel] [PATCH 1/4] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES

2018-04-10 Thread Collin Walling
The MAX_TABLE_ENTRIES constant has a name that is too generic. As we want to declare a limit for boot menu entries, let's rename it to a more fitting MAX_BOOT_ENTRIES and set its value to 31 (30 boot entries and 1 default entry). Also we move it from bootmap.h to s390-ccw.h to make it available for

[Qemu-devel] [PULL 1/1] Revert "migration: Don't activate block devices if using -S"

2018-04-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This reverts commit 0746a92612276aee69e66dfe6782b0f882d221d5. Discussion with kwolf suggests this is actually an API change that we need to gate on a capability. Push to 2.13. Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 22 +++--

[Qemu-devel] [PATCH 4/4] pc-bios/s390-ccw: fix non-sequential boot entries (enum)

2018-04-10 Thread Collin Walling
zIPL boot menu entries can be non-sequential. Let's account for this issue for the s390 enumerated boot menu. Since we can no longer print a range of available entries to the user, we have to present a list of each available entry. An example of this menu: s390-ccw Enumerated Boot Menu. [0]

[Qemu-devel] [PULL 0/1] migration queue

2018-04-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' into staging (2018-04-10 14:04:27 +0100) are available in the Git repository at: gi

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-04-10 Thread Laurent Vivier
Le 10/04/2018 à 15:53, Peter Maydell a écrit : > On 15 March 2018 at 15:25, Laurent Vivier wrote: >> Le 15/03/2018 à 16:13, James Cowgill a écrit : >>> Add support for the two currently defined HWCAP bits on MIPS - R6 and >>> MSA. >>> >>> Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 >>> S

[Qemu-devel] [PULL 1/7] iotests.py: support unsupported_fmts in main()

2018-04-10 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index b5d7945af8..16

[Qemu-devel] [PULL 3/7] iotests.py: improve verify_image_format helper

2018-04-10 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Support "generic" formats like in bash tests with their _supported_fmt generic The test, supporting "generic" formats will run if IMGFMT_GENERIC = true, which is default, except for bochs and cloop. However, you can use verify_image_format(['generic', 'bochs'

[Qemu-devel] [PULL 4/7] iotests: blacklist bochs and cloop for 205 and 208

2018-04-10 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Blacklist these formats, as they don't support image creation, as they say: > ./qemu-img create -f bochs x 1m qemu-img: x: Format driver 'bochs' does not support image creation > ./qemu-img create -f cloop x 1m qemu-img: x: Format driver 'cloop'

[Qemu-devel] [PULL 2/7] hw/block/pflash_cfi: fix off-by-one error

2018-04-10 Thread Kevin Wolf
From: Philippe Mathieu-Daudé ASAN reported: hw/block/pflash_cfi02.c:245:33: runtime error: index 82 out of bounds for type 'uint8_t [82]' Since the 'cfi_len' member is not used, remove it to keep the code safer. Cc: qemu-sta...@nongnu.org Reported-by: AddressSanitizer Signed-off-by: Phili

[Qemu-devel] [PULL 6/7] commit/stream: Reset delay_ns

2018-04-10 Thread Kevin Wolf
Streaming and the commit block job only want to apply throttling when they actually copied data instead of skipping it, so they made the calculation of delay_ns conditional. However, delay_ns isn't reset when skipping some sectors, so instead of not waiting, the old delay is applied again. Properl

[Qemu-devel] [PULL 7/7] qemu-iotests: update 185 output

2018-04-10 Thread Kevin Wolf
From: Stefan Hajnoczi Commit 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce vm_shutdown()") added a bdrv_drain_all() call. As a side-effect of the drain operation the block job iterates one more time than before. The 185 output no longer matches and the test is failing now. It may be

[Qemu-devel] [PULL 0/7] Block layer patches for 2.12.0-rc3

2018-04-10 Thread Kevin Wolf
The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' into staging (2018-04-10 14:04:27 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-ups

[Qemu-devel] [PULL 5/7] qemu-iotests: Remove _supported_fmt dmg

2018-04-10 Thread Kevin Wolf
qemu-iotests doesn't support dmg, and the dmg block driver doesn't support image creation. Two test cases declare dmg as supported, but that's obviously wrong for both reasons. Remove the declaration. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/183 | 2 +- tests/qem

Re: [Qemu-devel] [PULL 00/12] target-arm queue

2018-04-10 Thread Peter Maydell
remotes/xtensa/tags/20180409-xtensa' into > staging (2018-04-10 10:22:45 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20180410 > > for you to fetch changes up to bd49e6027c

[Qemu-devel] [PULL v2 3/3] linux-user: implement HWCAP bits on MIPS

2018-04-10 Thread Laurent Vivier
From: James Cowgill Add support for the two currently defined HWCAP bits on MIPS - R6 and MSA. Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 Signed-off-by: James Cowgill Reviewed-by: Laurent Vivier Message-Id: <20180315151348.6451-1-james.cowg...@mips.com> Signed-off-by: Laurent Vivier

[Qemu-devel] [PULL v2 2/3] linux-user: add microblaze/microblazeel magic numbers in qemu-binfmt-conf.sh

2018-04-10 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Message-Id: <20180409115212.875-2-laur...@vivier.eu> --- scripts/qemu-binfmt-conf.sh | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index f39ad344fc..7ab7435fbd 100755 --- a/

[Qemu-devel] [Bug 1761535] Re: qemu-aarch64-static docker arm64v8/openjdk coredump

2018-04-10 Thread Peter Maydell
Now fixed in master, commit 7f0f4208b3a96, and will be in 2.12.0. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761535 Title: qemu

[Qemu-devel] [PATCH 0/2] Minor fixes about compressed clusters with OFLAG_COPIED

2018-04-10 Thread Alberto Garcia
Hi, while reviewing one previous patch about data corruption and compressed clusters we discussed that the documentation doesn't clarify that L2 entries for compressed clusters are not supposed to have the OFLAG_COPIED bit set. Here's a patch to update the documentation and another one to fix the

[Qemu-devel] [Bug 1761401] Re: ARM/Neon: vcvt rounding error

2018-04-10 Thread Peter Maydell
Hi Christophe -- we think that commit bd49e6027cbc207c, now in master, should have fixed this bug. Could you retry your testcase with a QEMU build including that fix? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[Qemu-devel] [PULL v2 1/3] linux-user: fix microblaze get_sp_from_cpustate()

2018-04-10 Thread Laurent Vivier
get_sigframe() uses regs[1] and this is actual SP. Signed-off-by: Laurent Vivier Message-Id: <20180409115212.875-1-laur...@vivier.eu> --- linux-user/microblaze/target_signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/microblaze/target_signal.h b/linux-user/

[Qemu-devel] [Bug 1754038] Re: ARM M: Systick first wrap delayed (qemu-timers/icount prb?)

2018-04-10 Thread Peter Maydell
Now fixed in master, commit c52e7132d7c885, and will be in 2.12.0. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1754038 Title: ARM M: Systi

[Qemu-devel] [PATCH 1/2] Fix error message about compressed clusters with OFLAG_COPIED

2018-04-10 Thread Alberto Garcia
Compressed clusters are not supposed to have the COPIED bit set. "qemu-img check" detects that and prints an error message reporting the number of the affected host cluster. This doesn't make much sense because compressed clusters are not aligned to host clusters, so it would be better to report th

[Qemu-devel] [PULL v2 0/3] linux-user fixes for -rc3

2018-04-10 Thread Laurent Vivier
The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' into staging (2018-04-10 14:04:27 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linu

[Qemu-devel] [PATCH 2/2] specs/qcow2: Clarify that compressed clusters have the COPIED bit reset

2018-04-10 Thread Alberto Garcia
Compressed clusters are not supposed to have the COPIED bit set, but this is not made explicit in the specs, so let's document it. Signed-off-by: Alberto Garcia --- docs/interop/qcow2.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/interop/qcow2.txt b/docs/in

Re: [Qemu-devel] [PULL v2 0/3] linux-user fixes for -rc3

2018-04-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180410160142.21096-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL v2 0/3] linux-user fixes for -rc3 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --

Re: [Qemu-devel] [PATCH 1/2] Fix error message about compressed clusters with OFLAG_COPIED

2018-04-10 Thread Eric Blake
On 04/10/2018 11:05 AM, Alberto Garcia wrote: > Compressed clusters are not supposed to have the COPIED bit set. > "qemu-img check" detects that and prints an error message reporting > the number of the affected host cluster. This doesn't make much sense > because compressed clusters are not aligne

[Qemu-devel] [PATCH 06/10] target/tilegx: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Signed-off-by: Emilio G. Cota --- target/tilegx/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/tilegx/translate.c b/target/tilegx/translate.c index d63bf5b..6c5

[Qemu-devel] [PATCH 04/10] target/xtensa: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Max Filippov Signed-off-by: Emilio G. Cota --- target/xtensa/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/transla

[Qemu-devel] [PATCH 03/10] target/lm32: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Michael Walle Signed-off-by: Emilio G. Cota --- target/lm32/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/lm32/translate.c b/target/lm32/translate.c ind

[Qemu-devel] [PATCH 00/10] Avoid integer overflow in next_page_start

2018-04-10 Thread Emilio G. Cota
Richard pointed out in another thread that when computing next_page_start we can break checks for the last page in the address space due to integer overflow. This affects several targets; the appended fixes them. You can fetch the patches from: https://github.com/cota/qemu/tree/next_page_overflo

[Qemu-devel] [PATCH 01/10] target/riscv: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Reported-by: Richard Henderson Suggested-by: Richard Henderson Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Emilio G. Cota --- target/riscv/transla

[Qemu-devel] [PATCH 02/10] target/cris: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/cris/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate

[Qemu-devel] [PATCH 09/10] target/s390x: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Cornelia Huck Cc: Alexander Graf Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Signed-off-by: Emilio G. Cota --- target/s390x/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[Qemu-devel] [PATCH 07/10] target/microblaze: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/microblaze/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/mi

[Qemu-devel] [PATCH 05/10] target/unicore32: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Guan Xuetao Signed-off-by: Emilio G. Cota --- target/unicore32/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/unicore32/translate.c b/target/unicore32/tr

[Qemu-devel] [PATCH 08/10] target/arm: avoid integer overflow in next_page PC check

2018-04-10 Thread Emilio G. Cota
If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Peter Maydell Signed-off-by: Emilio G. Cota --- target/arm/translate.h | 2 +- target/arm/translate.c | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/target/arm/tran

<    1   2   3   >