[Qemu-devel] [PATCH v11 01/17] hw/arm/smmu-common: smmu base device and datatypes

The patch introduces the smmu base device and class for the ARM smmu. Devices for specific versions will be derived from this base device. We also introduce some important datatypes. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa

[Qemu-devel] [PATCH v11 16/17] hw/arm/smmuv3: IOTLB emulation

We emulate a TLB cache of size SMMU_IOTLB_MAX_SIZE=256. It is implemented as a hash table whose key is a combination of the 16b asid and 48b IOVA. Entries are invalidated on TLB invalidation commands, either globally, or per asid, or per asid/iova. One peculiarity is the NH_VA invalidation

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 04/12/2018 07:08 AM, David Gibson wrote: > On Thu, Dec 21, 2017 at 11:12:06AM +1100, Benjamin Herrenschmidt wrote: >> On Wed, 2017-12-20 at 16:09 +1100, David Gibson wrote: >>> >>> As you've suggested in yourself, I think we might need to more >>> explicitly model the different components of

Re: [Qemu-devel] [PATCH 2/5] migration: add the interface to set get_return_path

On Wed, Apr 11, 2018 at 06:18:18PM +0100, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: > > The default get_return_path function of iochannel does not work for > > RDMA live migration. So add the interface to set get_return_path. > > > > Signed-off-by: Lidong Chen

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 04/12/2018 07:16 AM, David Gibson wrote: > On Mon, Feb 12, 2018 at 09:55:17AM +1100, Benjamin Herrenschmidt wrote: >> On Sun, 2018-02-11 at 19:08 +1100, David Gibson wrote: >>> On Thu, Jan 18, 2018 at 08:27:52AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2018-01-17 at 15:39 +0100, Cédric

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 04/12/2018 07:10 AM, David Gibson wrote: > On Wed, Jan 17, 2018 at 10:18:43AM +0100, Cédric Le Goater wrote: > Also, have we decided how the process of switching between XICS and > XIVE will work vs. CAS ? That's how it is described in the architecture. The current choice is

Re: [Qemu-devel] [PATCH 10/19] block: Drain recursively with a single BDRV_POLL_WHILE()

On 11/04/2018 18:39, Kevin Wolf wrote: > +if (atomic_read(>in_flight)) { > +return true; > +} > + > +if (recursive) { > +QLIST_FOREACH_SAFE(child, >children, next, next) { QLIST_FOREACH_SAFE is only safe if child disappears, but not if e.g. next disappears. So this

Re: [Qemu-devel] [PATCH] iotests: fix 169

12.04.2018 11:34, Vladimir Sementsov-Ogievskiy wrote: 11.04.2018 19:11, Max Reitz wrote: On 2018-04-11 15:05, Vladimir Sementsov-Ogievskiy wrote: [...] Hmm, first type? I'm now not sure about, did I really see sha256 mismatch, or something like this (should be error, but found bitmap): ---

Re: [Qemu-devel] [PATCH v1 22/24] tests/tcg/Makefile: update to be called from Makefile.target

On Thu, 04/12 09:47, Alex Bennée wrote: > > Fam Zheng writes: > >> +testthread: LDFLAGS=-lpthread > > > > I'm a bit curious why only testthread is left in this file but others > > are gone. > > testthread is the only one that needs additional flags. However I could > put those

[Qemu-devel] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state()

We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). Let's remove the ones that are no longer needed. Remaining places (for s390x) are in - target/s390x/sigp.c, on the target CPU - target/s390x/cpu.c:s390_cpu_get_crash_info() While at it, use kvm_cpu_synchronize_state()

[Qemu-devel] [PATCH v11 04/17] hw/arm/smmuv3: Skeleton

From: Prem Mallappa This patch implements a skeleton for the smmuv3 device. Datatypes and register definitions are introduced. The MMIO region, the interrupts and the queue are initialized. Only the MMIO read operation is implemented here. Signed-off-by: Prem

[Qemu-devel] [PATCH v11 12/17] hw/arm/virt: Add SMMUv3 to the virt board

From: Prem Mallappa Add code to instantiate an smmuv3 in virt machine. A new iommu integer member is introduced in VirtMachineState to store the type of the iommu in use. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v11 05/17] hw/arm/smmuv3: Wired IRQ and GERROR helpers

We introduce some helpers to handle wired IRQs and especially GERROR interrupt. SMMU writes GERROR register on GERROR event and SW acks GERROR interrupts by setting GERRORn. The Wired interrupts are edge sensitive hence the pulse usage. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v11 09/17] hw/arm/smmuv3: Implement translate callback

This patch implements the IOMMU Memory Region translate() callback. Most of the code relates to the translation configuration decoding and check (STE, CD). Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v10 -> v11: - in case of

Re: [Qemu-devel] [PATCH v2] qemu-thread: always keep the posix wrapper layer

On Thu, 04/12 13:34, Peter Xu wrote: > We will conditionally have a wrapper layer depending on whether the host > has the PTHREAD_SETNAME capability. It complicates stuff. Let's keep > the wrapper there; we opt out the pthread_setname_np() call only. > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v1 07/24] docker: allow "cc" command to run in user context

On Tue, 04/10 20:39, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > tests/docker/docker.py | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index 9444f4bea4..f79213044d 100755 > ---

Re: [Qemu-devel] [PATCH v1 22/24] tests/tcg/Makefile: update to be called from Makefile.target

On Tue, 04/10 20:39, Alex Bennée wrote: > This make is now invoked from each individual target make with the > appropriate CC and ARCH set for each guest. It includes all the > multiarch tests by default as well as any tests from > tests/tcg/$(ARCH). > > As there may be subtle additional

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

On 11/04/2018 18:39, Kevin Wolf wrote: > +bool bdrv_drain_poll(BlockDriverState *bs, bool top_level) > { > /* Execute pending BHs first and check everything else only after the BHs > * have executed. */ > -while (aio_poll(bs->aio_context, false)); > +if (top_level) { > +

Re: [Qemu-devel] [RFC PATCH] migration: discard RAMBlocks of type ram_device

On 12 April 2018 at 08:02, Cédric Le Goater wrote: > On 04/11/2018 09:21 PM, Dr. David Alan Gilbert wrote: >> Interestingly, your patch comes less than 2 weeks after Lai Jiangshan's >> 'add capability to bypass the shared memory' >>

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

On 29/03/2018 05:21, Alexey Kardashevskiy wrote: > +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, TYPE_DEVICE); > +const char *id = object_property_print(obj, "id", true, NULL); I learnt now about commit e1ff3c67e8544f41f1bea76ba76385faee0d2bb7 and I find it a mistake. The

Re: [Qemu-devel] [PATCH 4/5] migration: fix qemu carsh when RDMA live migration

On Thu, Apr 12, 2018 at 12:43 AM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> After postcopy, the destination qemu work in the dedicated >> thread, so only invoke yield_until_fd_readable before postcopy >> migration. > > The subject line

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

On 4 April 2018 at 13:26, Alex Bennée wrote: > > Abdallah Bouassida writes: > >> Generate an XML description for the cp-regs. >> Register these regs with the gdb_register_coprocessor(). >> Add arm_gdb_get_sysreg() to use it as a callback

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

On 2018年04月12日 11:41, Michael S. Tsirkin wrote: On Thu, Apr 12, 2018 at 11:37:35AM +0800, Jason Wang wrote: On 2018年04月12日 09:57, Michael S. Tsirkin wrote: On Thu, Apr 12, 2018 at 09:39:43AM +0800, Tiwei Bie wrote: On Thu, Apr 12, 2018 at 04:29:29AM +0300, Michael S. Tsirkin wrote: On

[Qemu-devel] [PATCH v11 03/17] hw/arm/smmu-common: VMSAv8-64 page table walk

This patch implements the page table walk for VMSAv8-64. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v9 -> v10: - Add 64b single-copy atomicity comment related to PTE fetch - remove checks in get_block_pte_address and use

[Qemu-devel] [PATCH v11 00/17] ARM SMMUv3 Emulation Support

This series implements the emulation code for ARM SMMUv3. SMMUv3 gets instantiated by adding ",iommu=smmuv3" to the virt machine option. Only stage 1 and AArch64 PTW are supported. [1 - 14] bring the core emulation code. [15, 16] bring optimizations and 17 brings the vhost integration. Main

[Qemu-devel] [PATCH v11 02/17] hw/arm/smmu-common: IOMMU memory region and address space setup

We set up the infrastructure to enumerate all the PCI devices attached to the SMMU and create an associated IOMMU memory region and address space. Those info are stored in SMMUDevice objects. The devices are grouped according to the PCIBus they belong to. A hash table indexed by the PCIBus

[Qemu-devel] [PATCH v11 08/17] hw/arm/smmuv3: Event queue recording helper

Let's introduce a helper function aiming at recording an event in the event queue. Signed-off-by: Eric Auger --- v9 -> v10: - rework SMMU_EVENT_STRING - trigger a GERROR EVENTQ_ABT_ERR in case of eventq write failure v8 -> v9: - add SMMU_EVENT_STRING v7 -> v8: - use

Re: [Qemu-devel] [RFC PATCH] migration: discard RAMBlocks of type ram_device

* Cédric Le Goater (c...@kaod.org) wrote: > On 04/11/2018 09:21 PM, Dr. David Alan Gilbert wrote: > > * Cédric Le Goater (c...@kaod.org) wrote: > >> Here is some context for this strange change request. > >> > >> On the POWER9 processor, the XIVE interrupt controller can control > >> interrupt

Re: [Qemu-devel] [PATCH 1/1] mach-virt: Change default cpu and gic-version setting to "max"

On Wed, Apr 11, 2018 at 05:35:55PM +0200, Andrea Bolognani wrote: > On Tue, 2018-04-10 at 09:52 +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 10, 2018 at 09:41:33AM +0200, Andrea Bolognani wrote: > > > I figure the people not explicitly specifying a CPU model on the > > > command line will

Re: [Qemu-devel] [PATCH 18/19] block: Allow graph changes in bdrv_drain_all_begin/end sections

On 11/04/2018 18:39, Kevin Wolf wrote: > The much easier and more obviously correct way is to fundamentally > change the way the functions work: Iterate over all BlockDriverStates, > no matter who owns them, and drain them individually. Compensation is > only necessary when a new BDS is created

Re: [Qemu-devel] [PATCH v1 22/24] tests/tcg/Makefile: update to be called from Makefile.target

Fam Zheng writes: > On Tue, 04/10 20:39, Alex Bennée wrote: >> This make is now invoked from each individual target make with the >> appropriate CC and ARCH set for each guest. It includes all the >> multiarch tests by default as well as any tests from >> tests/tcg/$(ARCH). >>

Re: [Qemu-devel] [PATCH v2] qemu-thread: always keep the posix wrapper layer

On 12/04/2018 09:55, Fam Zheng wrote: > Reviewed-by: Fam Zheng Queued, thanks Fam and Peter. Paolo

[Qemu-devel] [PATCH v1 3/3] pc-dimm: factor out address space logic into MemoryDevice code

To be able to reuse MemoryDevice logic from other devices besides pc-dimm, factor the relevant stuff out into the MemoryDevice code. As we don't care about slots for memory devices that are not pc-dimm, don't factor that part out. Most of this patch just moves checks and logic around. While at

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

Am 12.04.2018 um 10:37 hat Paolo Bonzini geschrieben: > On 11/04/2018 18:39, Kevin Wolf wrote: > > +bool bdrv_drain_poll(BlockDriverState *bs, bool top_level) > > { > > /* Execute pending BHs first and check everything else only after the > > BHs > > * have executed. */ > > -while

[Qemu-devel] [PATCH v11 07/17] hw/arm/smmuv3: Implement MMIO write operations

Now we have relevant helpers for queue and irq management, let's implement MMIO write operations. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v9 -> v10: - s/hwaddr/uint64_t in trace-events - added SMMU_FEATURE_2LVL_STE in this

[Qemu-devel] [PATCH v11 11/17] target/arm/kvm: Translate the MSI doorbell in kvm_arch_fixup_msi_route

In case the MSI is translated by an IOMMU we need to fixup the MSI route with the translated address. Signed-off-by: Eric Auger Signed-off-by: Bharat Bhushan --- v9 -> v10: - use address_space_translate v5 -> v6: - use IOMMUMemoryRegionClass API

[Qemu-devel] [PATCH v11 15/17] hw/arm/smmuv3: Cache/invalidate config data

Let's cache config data to avoid fetching and parsing STE/CD structures on each translation. We invalidate them on data structure invalidation commands. Signed-off-by: Eric Auger --- hw/arm/smmu-common.c | 24 +++- hw/arm/smmuv3.c | 129

[Qemu-devel] [PATCH v11 17/17] hw/arm/smmuv3: Add notifications on invalidation

On TLB invalidation commands, let's call registered IOMMU notifiers. Those can only be UNMAP notifiers. SMMUv3 does not support notification on MAP (VFIO). This patch allows vhost use case where IOTLB API is notified on each guest IOTLB invalidation. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v11 14/17] hw/arm/virt: Introduce the iommu option

ARM virt machine now exposes a new "iommu" option. The SMMUv3 IOMMU is instantiated using -machine virt,iommu=smmuv3. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v9 -> v10: - remove no_iommu v7 -> v8: - Revert to machine

Re: [Qemu-devel] [PATCH v1 06/24] docker: extend "cc" command to accept compiler

On Tue, 04/10 20:39, Alex Bennée wrote: > When calling our cross-compilation images we want to call something > other than the default cc. Makes sense to me! > > Signed-off-by: Alex Bennée > --- > tests/docker/docker.py | 18 +++--- > 1 file changed, 15

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

On Thu, Apr 12, 2018 at 03:38:50PM +0800, Jason Wang wrote: > On 2018年04月12日 09:44, Tiwei Bie wrote: > > On Wed, Apr 11, 2018 at 08:37:17PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Apr 11, 2018 at 04:38:53PM +0800, Tiwei Bie wrote: > > > > On Wed, Apr 11, 2018 at 04:01:19PM +0800, Jason Wang

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 04/12/2018 07:07 AM, David Gibson wrote: > On Wed, Dec 20, 2017 at 08:38:41AM +0100, Cédric Le Goater wrote: >> On 12/20/2017 06:09 AM, David Gibson wrote: >>> On Sat, Dec 09, 2017 at 09:43:21AM +0100, Cédric Le Goater wrote: With the POWER9 processor comes a new interrupt controller

Re: [Qemu-devel] [PATCH 08/19] block: Remove bdrv_drain_recurse()

On 11/04/2018 18:39, Kevin Wolf wrote: > For bdrv_drain(), recursively waiting for child node requests is > pointless because we didn't quiesce their parents, so new requests could > come in anyway. Letting the function work only on a single node makes it > more consistent. > > For subtree drains

Re: [Qemu-devel] [PATCH v2 02/19] spapr: introduce a skeleton for the XIVE interrupt controller

On 04/12/2018 07:15 AM, David Gibson wrote: > On Wed, Jan 17, 2018 at 03:39:46PM +0100, Cédric Le Goater wrote: >> On 01/17/2018 12:10 PM, Benjamin Herrenschmidt wrote: >>> On Wed, 2018-01-17 at 10:18 +0100, Cédric Le Goater wrote: >>> Also, have we decided how the process of switching between

Re: [Qemu-devel] Debugging on HAXM

Sorry for the very late response.  I completely forgot to check this mailbox...  Adding my usual corporate email to the cc. On 4/2/2018 10:20, Paolo Bonzini wrote: On 01/04/2018 17:35, Alexandro Sanchez Bach wrote: I've noticed that `gdb_breakpoint_insert` only considers KVM so far. My

[Qemu-devel] [PATCH v1 2/3] machine: make MemoryHotplugState accessible via the machine

Let's allow to query the MemoryHotplugState from the machine. This allows us to generically detect if a certain machine has support for memory devices, and to generically manage it (find free address range, plug/unplug a memory region). Signed-off-by: David Hildenbrand ---

[Qemu-devel] [PATCH v1 0/3] pc-dimm: factor out MemoryDevice

Right now we can only map PCDIMM/NVDIMM into guest address space. In the future, we might want to do the same for virtio devices - e.g. virtio-pmem or virtio-mem. Especially, they should be able to live side by side to each other. E.g. the virto based memory devices regions will not be exposed

[Qemu-devel] [PATCH v11 10/17] hw/arm/smmuv3: Abort on vfio or vhost case

At the moment, the SMMUv3 does not support notification on TLB invalidation. So let's log an error as soon as such notifier gets enabled. Signed-off-by: Eric Auger --- hw/arm/smmuv3.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/smmuv3.c

[Qemu-devel] [PATCH v11 13/17] hw/arm/virt-acpi-build: Add smmuv3 node in IORT table

From: Prem Mallappa This patch builds the smmuv3 node in the ACPI IORT table. The RID space of the root complex, which spans 0x0-0x1 maps to streamid space 0x0-0x1 in smmuv3, which in turn maps to deviceid space 0x0-0x1 in the ITS group. The guest must

[Qemu-devel] [PATCH v11 06/17] hw/arm/smmuv3: Queue helpers

We introduce helpers to read/write into the command and event circular queues. smmuv3_write_eventq and smmuv3_cmq_consume will become static in subsequent patches. Invalidation commands are not yet dealt with. We do not cache data that need to be invalidated. This will change with vhost

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

On 2018年04月12日 09:44, Tiwei Bie wrote: On Wed, Apr 11, 2018 at 08:37:17PM +0300, Michael S. Tsirkin wrote: On Wed, Apr 11, 2018 at 04:38:53PM +0800, Tiwei Bie wrote: On Wed, Apr 11, 2018 at 04:01:19PM +0800, Jason Wang wrote: On 2018年04月11日 15:20, Tiwei Bie wrote: This patch introduces

Re: [Qemu-devel] [PATCH] iotests: fix 169

11.04.2018 19:11, Max Reitz wrote: On 2018-04-11 15:05, Vladimir Sementsov-Ogievskiy wrote: [...] Hmm, first type? I'm now not sure about, did I really see sha256 mismatch, or something like this (should be error, but found bitmap): --- /work/src/qemu/up-169/tests/qemu-iotests/169.out   

Re: [Qemu-devel] [PATCH 16/19] block: Allow AIO_WAIT_WHILE with NULL ctx

On 11/04/2018 18:39, Kevin Wolf wrote: > bdrv_drain_all() wants to have a single polling loop for draining the > in-flight requests of all nodes. This means that the AIO_WAIT_WHILE() > condition relies on activity in multiple AioContexts, which is polled > from the mainloop context. We must

[Qemu-devel] [PATCH v1 1/3] pc-dimm: factor out MemoryDevice interface

On the qmp level, we already have the concept of memory devices: "query-memory-devices" Right now, we only support NVDIMM and PCDIMM. We want to map other devices later into the address space of the guest. Such device could e.g. be virtio devices. These devices will have a guest memory range

Re: [Qemu-devel] [RFC] vhost-user: introduce F_NEED_ALL_IOTLB protocol feature

On 2018年04月12日 16:10, Tiwei Bie wrote: On Thu, Apr 12, 2018 at 03:38:50PM +0800, Jason Wang wrote: On 2018年04月12日 09:44, Tiwei Bie wrote: On Wed, Apr 11, 2018 at 08:37:17PM +0300, Michael S. Tsirkin wrote: On Wed, Apr 11, 2018 at 04:38:53PM +0800, Tiwei Bie wrote: On Wed, Apr 11, 2018 at

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

On 12/04/2018 11:51, Kevin Wolf wrote: > Am 12.04.2018 um 10:37 hat Paolo Bonzini geschrieben: >> On 11/04/2018 18:39, Kevin Wolf wrote: >>> +bool bdrv_drain_poll(BlockDriverState *bs, bool top_level) >>> { >>> /* Execute pending BHs first and check everything else only after the >>> BHs

[Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On the POWER9 processor, the XIVE interrupt controller can control interrupt sources using MMIO to trigger events, to EOI or to turn off the sources. Priority management and interrupt acknowledgment is also controlled by MMIO in the presenter sub-engine. These MMIO regions are exposed to guests

[Qemu-devel] [PATCH] block/gluster: defend on legacy ftruncate api use

Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 15 +-- configure | 8 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 4adc1a875b..2474580ad6 100644 --- a/block/gluster.c

[Qemu-devel] [Bug Report] vm paused after succeeding to migrate

Hi, all I encounterd a bug when I try to migrate a windows vm. Enviroment information: host A: cpu E5620(model WestmereEP without flag xsave) host B: cpu E5-2643(model SandyBridgeEP with xsave) The reproduce steps is : 1. Start a windows 2008 vm with -cpu host(which means host-passthrough). 2.

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On 12 April 2018 at 11:18, Cédric Le Goater wrote: > On the POWER9 processor, the XIVE interrupt controller can control > interrupt sources using MMIO to trigger events, to EOI or to turn off > the sources. Priority management and interrupt acknowledgment is also > controlled by

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

Am 12.04.2018 um 12:12 hat Paolo Bonzini geschrieben: > On 12/04/2018 11:51, Kevin Wolf wrote: > > Am 12.04.2018 um 10:37 hat Paolo Bonzini geschrieben: > >> On 11/04/2018 18:39, Kevin Wolf wrote: > >>> +bool bdrv_drain_poll(BlockDriverState *bs, bool top_level) > >>> { > >>> /* Execute

Re: [Qemu-devel] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state()

On Thu, 12 Apr 2018 11:35:21 +0200 David Hildenbrand wrote: > We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). > > Let's remove the ones that are no longer needed. > > Remaining places (for s390x) are in > - target/s390x/sigp.c, on the target CPU > -

Re: [Qemu-devel] [PATCH v1] s390x/kvm: cleanup calls to cpu_synchronize_state()

On 04/12/2018 11:35 AM, David Hildenbrand wrote: > We have a call to cpu_synchronize_state() on every kvm_arch_handle_exit(). > > Let's remove the ones that are no longer needed. > > Remaining places (for s390x) are in > - target/s390x/sigp.c, on the target CPU > -

[Qemu-devel] [PATCH v1 1/2] softfloat: fix {min, max}nummag for same-abs-value inputs

From: "Emilio G. Cota" Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21), we used to return +Zero for maxnummag(-Zero,+Zero); after that commit, we return -Zero. Fix it by making {min,max}nummag consistent with {min,max}num, deferring to the latter when the absolute

[Qemu-devel] [PATCH v1 0/2] Softfloat Fixes for 2.12

Hi, I'd hope to include fixes for our longstanding fcvt bugs but I ran out of time. The fixes in this series are purely regression fixes from the softfloat re-factor. On the plus side I have a very good test case of fcvt now ;-) Only my patch is not reviewed. Alex Bennée (1): fpu/softfloat:

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On 12 April 2018 at 12:53, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> David suggested on IRC that we would want a flag on the ramblock >> for "not migratable", because there are other uses for "don't >> migrate this" than just "is

[Qemu-devel] [Bug 1734792] Re: qemu-x86_64 fails with unsupported syscall 319

Not only qemu-x86_64, but also: qemu-aarch64 => qemu: Unsupported syscall: 279 qemu-arm => qemu: Unsupported syscall: 385 qemu-mips => qemu: Unsupported syscall: 4354 qemu-mips64 => qemu: Unsupported syscall: 5314 qemu-powerpc => qemu: Unsupported syscall: 360 qemu-powerpc64 => qemu: Unsupported

Re: [Qemu-devel] [PATCH 2/5] migration: add the interface to set get_return_path

On Thu, Apr 12, 2018 at 4:28 PM, Daniel P. Berrangé wrote: > On Wed, Apr 11, 2018 at 06:18:18PM +0100, Dr. David Alan Gilbert wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >> > The default get_return_path function of iochannel does not work for >> > RDMA live

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

Hi David, > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Thursday, April 12, 2018 10:36 AM > On Tue, Mar 06, 2018 at 06:33:52PM +0800, Liu, Yi L wrote: > > On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > > > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 12 April 2018 at 11:18, Cédric Le Goater wrote: > > On the POWER9 processor, the XIVE interrupt controller can control > > interrupt sources using MMIO to trigger events, to EOI or to turn off > > the sources. Priority

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

Am 12.04.2018 um 13:30 hat Paolo Bonzini geschrieben: > On 12/04/2018 13:11, Kevin Wolf wrote: > >> Well, there is one gotcha: bdrv_ref protects against disappearance, but > >> bdrv_ref/bdrv_unref are not thread-safe. Am I missing something else? > > > > Apart from the above, if we do an extra

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

On 6 April 2018 at 18:28, Abdallah Bouassida wrote: > Alex wrote: >> There is something odd going on here because if I run a simple little >> features binary >> (https://github.com/stsquad/testcases/blob/master/aarch64/features.c) I >> get: >> >>

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

On 12/04/2018 13:11, Kevin Wolf wrote: >> Well, there is one gotcha: bdrv_ref protects against disappearance, but >> bdrv_ref/bdrv_unref are not thread-safe. Am I missing something else? > > Apart from the above, if we do an extra bdrv_ref/unref we'd also have > to keep track of all the nodes

[Qemu-devel] [PATCH v1 2/2] fpu/softfloat: raise float_invalid for NaN in float_to_int

Fixes https://bugs.launchpad.net/qemu/+bug/1759264 Signed-off-by: Alex Bennée Cc: Bastian Koppelmann --- fpu/softfloat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9b99aa6ec8..ddc77c273c

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

On 12/04/2018 13:53, Kevin Wolf wrote: >> The problem I have is that there is a direction through which I/O flows >> (parent-to-child), so why can't draining follow that natural direction. >> Having to check for the parents' I/O, while draining the child, seems >> wrong. Perhaps we can't help it,

Re: [Qemu-devel] [PATCH v1 2/2] fpu/softfloat: raise float_invalid for NaN in float_to_int

On 12 April 2018 at 12:58, Alex Bennée wrote: > Fixes https://bugs.launchpad.net/qemu/+bug/1759264 > > Signed-off-by: Alex Bennée > Cc: Bastian Koppelmann > --- > fpu/softfloat.c | 1 + > 1 file changed, 1

[Qemu-devel] [PATCH for-2.12] linux-user/signal.c: Put AArch64 frame record in the right place

AArch64 stack frames include a 'frame record' which holds a pointer to the next frame record in the chain and the LR on entry to the function. The procedure calling standard doesn't mandate where exactly this frame record is in the stack frame, but for signal frames the kernel puts it right at the

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

Hello, On Tue, Apr 10, 2018 at 03:33:35PM +0200, Gerd Hoffmann wrote: > > # @off: Disable OpenGL (default). Just to be sure, I have to add @ in front of all parameter, right? > > > > > + # 'on'Use OpenGL, pick context type automatically. > > > + # Would better be named 'auto' but

[Qemu-devel] buffer sharing across VMs - xen-zcopy and hyper_dmabuf discussion

(changed subject and decoupling from udmabuf thread) On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: > On 04/10/2018 08:26 PM, Dongwon Kim wrote: > >On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: > >>On 04/06/2018 09:57 PM, Dongwon Kim wrote: >

[Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface

On the qmp level, we already have the concept of memory devices: "query-memory-devices" Right now, we only support NVDIMM and PCDIMM. We want to map other devices later into the address space of the guest. Such device could e.g. be virtio devices. These devices will have a guest memory range

[Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice

Right now we can only map PCDIMM/NVDIMM into guest address space. In the future, we might want to do the same for virtio devices - e.g. virtio-pmem or virtio-mem. Especially, they should be able to live side by side to each other. E.g. the virto based memory devices regions will not be exposed

Re: [Qemu-devel] [PATCH v3 35/38] console: make screendump asynchronous

* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Make screendump asynchronous to provide correct screendumps. > > HMP doesn't have async support, so it has to remain synchronous and > potentially incorrect to avoid potential races. > > Fixes: >

[Qemu-devel] [PATCH qemu v3] device_tree: Increase FDT_MAX_SIZE to 1 MiB

It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE Hence increase the limit to 1 MiB, like on PPC. For reference, the largest arm64 DTB created

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On 12/04/2018 15:51, Peter Maydell wrote: > Paolo may have an opinion what the API here should be, but > at the MemoryRegion level we already have a mix of functions > memory_region_init_foo_nomigrate() and memory_region_init_foo(), > which at the moment just control whether we call >

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

Am 12.04.2018 um 15:42 hat Paolo Bonzini geschrieben: > On 12/04/2018 15:27, Kevin Wolf wrote: > > Not sure I follow. Let's look at an example. Say, we have a block job > > BlockBackend as the root (because that uses proper layering, unlike > > devices which use aio_disable_external()), connected

Re: [Qemu-devel] [PATCH v1 04/24] Makefile: Rename TARGET_DIRS to TARGET_LIST

On 04/10/2018 04:38 PM, Alex Bennée wrote: > From: Fam Zheng > > To be more accurate on its purpose and make code that looks for a certain > target out of this variable more readable. > > Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v2 3/3] pc-dimm: factor out address space logic into MemoryDevice code

To be able to reuse MemoryDevice logic from other devices besides pc-dimm, factor the relevant stuff out into the MemoryDevice code. As we don't care about slots for memory devices that are not pc-dimm, don't factor that part out. Most of this patch just moves checks and logic around. While at

[Qemu-devel] [PATCH v2 2/3] machine: make MemoryHotplugState accessible via the machine

Let's allow to query the MemoryHotplugState from the machine. This allows us to generically detect if a certain machine has support for memory devices, and to generically manage it (find free address range, plug/unplug a memory region). Signed-off-by: David Hildenbrand ---

Re: [Qemu-devel] [PATCH] qmp: add pmemload command

On Wed, Apr 11, 2018 at 08:02:58AM -0500, Eric Blake wrote: > You could always add qemu_fopen/qemu_fclose to match the existing > qemu_open/qemu_close. But you do have a point that you can't call > qemu_close/fclose (because fclose would be left with a stale fd that > might spuriously close

[Qemu-devel] [PATCH v2 2/5] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open

qemu_open() allow passing file descriptors to qemu which is used in restricted environments like libvirt where open() is prohibited. Suggested-by: Eric Blake Signed-off-by: Simon Ruderich --- cpus.c | 20 ++-- 1 file changed, 10

Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter

* Juan Quintela (quint...@redhat.com) wrote: > It will be used to store the uri parameters. We want this only for > tcp, so we don't set it for other uris. We need it to know what port > is migration running. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri

Re: [Qemu-devel] [PATCH v1 2/2] fpu/softfloat: raise float_invalid for NaN in float_to_int

Peter Maydell writes: > On 12 April 2018 at 12:58, Alex Bennée wrote: >> Fixes https://bugs.launchpad.net/qemu/+bug/1759264 >> >> Signed-off-by: Alex Bennée >> Cc: Bastian Koppelmann >>

Re: [Qemu-devel] [PATCH 07/19] block: Really pause block jobs on drain

Am 12.04.2018 um 14:02 hat Paolo Bonzini geschrieben: > On 12/04/2018 13:53, Kevin Wolf wrote: > >> The problem I have is that there is a direction through which I/O flows > >> (parent-to-child), so why can't draining follow that natural direction. > >> Having to check for the parents' I/O, while

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On 04/12/2018 02:08 PM, Peter Maydell wrote: > On 12 April 2018 at 12:53, Dr. David Alan Gilbert wrote: >> * Peter Maydell (peter.mayd...@linaro.org) wrote: >>> David suggested on IRC that we would want a flag on the ramblock >>> for "not migratable", because there are other

Re: [Qemu-devel] [Bug Report] vm paused after succeeding to migrate

* linzhecheng (linzhech...@huawei.com) wrote: > Hi, all > I encounterd a bug when I try to migrate a windows vm. > > Enviroment information: > host A: cpu E5620(model WestmereEP without flag xsave) > host B: cpu E5-2643(model SandyBridgeEP with xsave) > > The reproduce steps is : > 1. Start a

Re: [Qemu-devel] [PATCH/RFC 3/5] hw/arm/virt: Allow dynamic sysbus devices again

Hi Eric, On Wed, Feb 14, 2018 at 11:37 AM, Auger Eric wrote: > On 09/02/18 16:17, Geert Uytterhoeven wrote: >> Allow the instantation of generic dynamic sysbus devices again, without >> the need to create a new device-specific vfio type. >> >> This is a partial revert of

[Qemu-devel] [PATCH v2 3/5] cpus: use size_t in qmp_memsave/qmp_pmemsave

It's the natural type for object sizes and matches the return value of sizeof(buf). Signed-off-by: Simon Ruderich --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 292d5b94b1..d256d8e9b4 100644 --- a/cpus.c +++ b/cpus.c

[Qemu-devel] [PATCH v2 4/5] hmp: don't truncate size in hmp_memsave/hmp_pmemsave

The called function takes an uint64_t as size parameter and qdict_get_int() returns an uint64_t. Don't truncate it needlessly to an uint32_t. Signed-off-by: Simon Ruderich --- hmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index

Re: [Qemu-devel] [PATCH] block/gluster: defend on legacy ftruncate api use

This change looks good to me, but a commit message would have been helpful. I suggest something like this: Gluster 4.0 changed the signature of glfs_ftruncate(). The function now has two additional arguments, namely prestat and poststat. These provide not benefit for QEMU, so ignoring them

Re: [Qemu-devel] [PATCH] migration: discard RAMBlocks of type ram_device

On 12 April 2018 at 14:41, Cédric Le Goater wrote: > On 04/12/2018 02:08 PM, Peter Maydell wrote: >> On 12 April 2018 at 12:53, Dr. David Alan Gilbert >> wrote: >>> * Peter Maydell (peter.mayd...@linaro.org) wrote: David suggested on IRC that we would

  1   2   >