Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

On Apr 17 16:00, Peter Maydell wrote: > On 17 April 2018 at 15:23, Aaron Lindsay wrote: > > On Apr 12 18:17, Peter Maydell wrote: > >> What's the difference between this and ARM_FEATURE_EL2 ? > > > > I use ARM_FEATURE_V7VE in a later patch to guard against implementing >

Re: [Qemu-devel] [RFC PATCH 03/33] blockjob: Implement block_job_set_speed() centrally

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > All block job drivers support .set_speed and all of them duplicate the > same code to implement it. Move that code to blockjob.c and remove the > now useless callback. > > Signed-off-by: Kevin Wolf > --- > +++

Re: [Qemu-devel] [RFC PATCH 05/33] blockjob: Add block_job_driver()

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > The backup block job directly accesses the driver field in BlockJob. Add > a wrapper for getting it. > > Signed-off-by: Kevin Wolf > --- > include/block/blockjob.h | 7 +++ > block/backup.c | 8 +--- > blockjob.c

[Qemu-devel] [RFC PATCH 25/33] job: Convert block_job_cancel_async() to Job

block_job_cancel_async() did two things that were still block job specific: * Setting job->force. This field makes sense on the Job level, so we can just move it. While at it, rename it to job->force_cancel to make its purpose more obvious. * Resetting the I/O status. This can't be moved

[Qemu-devel] [PATCH v3 41/46] tests/tcg: enable building for sparc64

As before, using Debian SID compilers. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 1 + tests/docker/dockerfiles/debian-sparc64-cross.docker | 12 tests/tcg/sparc64/Makefile.include | 2 ++ 3

[Qemu-devel] [RFC PATCH 29/33] job: Switch transactions to JobTxn

This doesn't actually move any transaction code to Job yet, but it renames the type for transactions from BlockJobTxn to JobTxn and makes them contain Jobs rather than BlockJobs Signed-off-by: Kevin Wolf --- include/block/block_int.h| 2 +- include/block/blockjob.h |

Re: [Qemu-devel] [PATCH v5 2/4] qemu-thread: introduce qemu-thread-common.h

On Tue, Apr 24, 2018 at 12:51:10 +0800, Peter Xu wrote: > Introduce some hooks for the shared part of qemu thread between POSIX > and Windows implementations. Note that in qemu_mutex_unlock_impl() we > moved the call before unlock operation which should make more sense. > And we don't need

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based callbacks > in the null-co and null-aio drivers. > > Note that since the null driver does nothing on writes, it

[Qemu-devel] [PATCH v3 32/46] tests/tcg/mips: include common mips hello-mips

Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.target | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 tests/tcg/mips/Makefile.target diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target new file mode 100644

Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

Philippe Mathieu-Daudé writes: > On 04/19/2018 01:45 PM, Ian Jackson wrote: >> perror() is defined to fprintf(stderr,...). HACKING says >> fprintf(stderr,...) is wrong. So perror() is too. >> >> Signed-off-by: Ian Jackson >> CC: Paolo Bonzini

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

On 04/24/2018 10:52 AM, Kevin Wolf wrote: > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Make the change for the last few sector-based callbacks >> in the null-co and null-aio drivers. >> >> Note that since

[Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post

We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so

[Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all

And insist that it works. Drop individual use of xendevicemodel_restrict and xenforeignmemory_restrict. These are not actually effective in this version of qemu, because qemu has a large number of fds open onto various Xen control devices. The restriction arrangements are still not right,

Re: [Qemu-devel] [PATCH] linux-user: set minimum uname for RISC-V

On 24 April 2018 at 17:40, Palmer Dabbelt wrote: > On Tue, 24 Apr 2018 09:03:29 PDT (-0700), alex.ben...@linaro.org wrote: >> >> As support was merged into the mainline kernel at 4.15 it is unlikely >> 3.8.0 is the correct value. Indeed when I testing binaries created by >> the

[Qemu-devel] [PATCH for 2.13 v4 01/20] linux-user: create a dummy per arch signal.c

Create a signal-common.h for future use by these new files and use it in the existing signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson --- linux-user/Makefile.objs | 2

[Qemu-devel] [PATCH for 2.13 v4 12/20] linux-user: move tilegx signal.c parts to tilegx directory

No code change, only move code from signal.c to tilegx/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by:

[Qemu-devel] [PATCH for 2.13 v4 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

Instead of calling setup_frame() conditionally to a list of known targets, define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function and call it only if the macro is defined. Move declarations of setup_frame() and setup_rt_frame() to linux-user/signal-common.h Signed-off-by: Laurent

[Qemu-devel] [PATCH v2 4/6] rbd: Switch to byte-based callbacks

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based callbacks in the rbd driver. Note that the driver was already using byte-based calls for performing actual I/O, so this just gets rid of a round trip of scaling; however,

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/6] rbd: Switch to byte-based callbacks

On Tue, Apr 24, 2018 at 3:25 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based callbacks > in the rbd driver. > > Note that the driver was already using byte-based calls for >

Re: [Qemu-devel] [RFC PATCH 01/33] blockjob: Wrappers for progress counter access

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > Block job drivers are not expected to mess with the internal of the s/internal/internals/ > BlockJob object, so provide wrapper functions for one of the cases where > they still do it: Updating the progress counter. > > Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication

@CpuInfo and @CpuInfoFast duplicate the following four fields: @qom-path, @thread-id, @props and @arch. From these, extract the first three to a common structure called @CpuInfoCommon. (More on @arch later.) Introduce two new mid-layer structures, @CpuInfoBase and @CpuInfoFastBase, to soak up the

Re: [Qemu-devel] [PATCH v2 1/2] ipmi: Use proper struct reference for KCS vmstate

On 04/24/2018 10:32 AM, Dr. David Alan Gilbert wrote: * Corey Minyard (miny...@acm.org) wrote: On 03/05/2018 08:09 AM, Dr. David Alan Gilbert wrote: * miny...@acm.org (miny...@acm.org) wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs

[Qemu-devel] [PATCH 6/6] qapi: discriminate CpuInfo[Fast] on SysEmuTarget, not CpuInfoArch

Add a new field @target (of type @SysEmuTarget) to the outputs of the @query-cpus and @query-cpus-fast commands, which provides more information about the emulation target than the field @arch (of type @CpuInfoArch). Keep @arch for compatibility. Make @target the new discriminator for the

[Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast

Commit 25fa194b7b11 added the @riscv enum constant to @CpuInfoArch (used in both @CpuInfo and @CpuInfoFast -- the return types of the @query-cpus and @query-cpus-fast commands, respectively), and assigned, in both return structures, the @CpuInfoRISCV sub-structure to the new enum value. However,

Re: [Qemu-devel] [RFC PATCH 10/33] job: Add job_delete()

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > This moves freeing the Job object and its fields from block_job_unref() > to job_delete(). > > Signed-off-by: Kevin Wolf > --- > +++ b/job.c > @@ -56,3 +56,9 @@ void *job_create(const char *job_id, const JobDriver > *driver, Error

Re: [Qemu-devel] [Xen-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

On Tue, Apr 24, 2018 at 10:58 AM, Ian Jackson wrote: > perror() is defined to fprintf(stderr,...). HACKING says > fprintf(stderr,...) is wrong. So perror() is too. > > Signed-off-by: Ian Jackson > CC: Paolo Bonzini >

Re: [Qemu-devel] [RFC PATCH 02/33] blockjob: Move RateLimit to BlockJob

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > Every block job has a RateLimit, and they all do the exact same thing > with it, so it should be common infrastructure. Move the struct field > for a start. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v2 6/6] block: Drop last of the sector-based aio callbacks

We are gradually moving away from sector-based interfaces, towards byte-based. Now that all drivers with aio callbacks are using the byte-based interfaces, we can remove the sector-based versions. Signed-off-by: Eric Blake --- v2: rearrange conditionals to put byte-based

Re: [Qemu-devel] [RFC PATCH 00/33] Generic background jobs

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180424152515.25664-1-kw...@redhat.com Subject: [Qemu-devel] [RFC PATCH 00/33] Generic background jobs === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

With QEMU from tag v2.12.0-rc4 on Fedora 27 x86_64, it works too. muriloo@laptop$ docker run --rm -it qemutest /go # qemu-ppc64le-static --version qemu-ppc64le version 2.11.94 (v2.12.0-rc4) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers /go # go version go version

Re: [Qemu-devel] [PATCH] linux-user: set minimum uname for RISC-V

On Tue, 24 Apr 2018 12:07:43 PDT (-0700), peter.mayd...@linaro.org wrote: On 24 April 2018 at 17:40, Palmer Dabbelt wrote: On Tue, 24 Apr 2018 09:03:29 PDT (-0700), alex.ben...@linaro.org wrote: As support was merged into the mainline kernel at 4.15 it is unlikely 3.8.0 is

Re: [Qemu-devel] [PATCH v3 1/2] bswap.h: Fix ldl_he_p() signedness

On 04/23/2018 01:56 PM, Peter Maydell wrote: > On 23 April 2018 at 17:25, Philippe Mathieu-Daudé wrote: >> As per the "Load and Store APIs" documentation (docs/devel/loads-stores.rst), >> "No signed load operations are provided." > > That phrase is used in the documentation

[Qemu-devel] [PATCH 4/6] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

Now that we have @SysEmuTarget, it makes sense to restict @TargetInfo.@arch to valid sysemu targets at the schema level. Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Kashyap

Re: [Qemu-devel] [RFC PATCH 04/33] blockjob: Introduce block_job_ratelimit_get_delay()

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > This gets us rid of more direct accesses to BlockJob fields from the > job drivers. > > Signed-off-by: Kevin Wolf > --- > +++ b/include/block/blockjob_int.h > @@ -166,6 +166,14 @@ void block_job_sleep_ns(BlockJob *job, int64_t ns); >

[Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json"

We'll soon need an enumeration type that lists all the softmmu targets that QEMU (the project) supports. Introduce @SysEmuTarget to "common.json". Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann

[Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration

This patch set adds the @SysEmuTarget enum type, and rebases a few other types to it. Here's the "anatomy" of the series: - Patches #1 and #2 fix QAPI bugs that have crept in in the 2.12 development cycle. I noticed the bugs while working on patch #6; i.e. patch #6 depends on #1 and #2. The

[Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast

Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X was not defined. The updated @query-cpus-fast example in "qapi-schema.json" showed "arch":"x86" only because qmp_query_cpus_fast() calls g_malloc0() to

[Qemu-devel] [ANNOUNCE] QEMU 2.12.0 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 2.12.0 release. This release contains 2700+ commits from 204 authors. You can grab the tarball from our download page here: https://www.qemu.org/download/#source The full list of changes are available at:

[Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

We have too many driver callback interfaces; simplify the mess somewhat by merging the flags parameter of .bdrv_co_writev_flags() into .bdrv_co_writev_flags(). Note that as long as a driver doesn't set .supported_write_flags, the flags argument will be 0 and behavior is identical. Also note that

Re: [Qemu-devel] [RFC PATCH 08/33] job: Rename BlockJobType into JobType

On 04/24/2018 10:24 AM, Kevin Wolf wrote: > QAPI types aren't externally visible, so we can rename them without > causing problems. Before we add a job type to Job, rename the enum > so it can be used for more than just block jobs. > > Signed-off-by: Kevin Wolf > ---

[Qemu-devel] [PATCH v4] loader: Fix misaligned member access

The libfdt does not guarantee than fdt_getprop() returns a pointer aligned to the property size. Assuming the base of the fdt is aligned, a 32-bit property returns a 32-bit aligned pointer. This is however not guaranteed for 64-bit properties, where 64-bit loads might trigger unaligned access.

[Qemu-devel] [PATCH v3 28/46] tests/tcg/aarch64: add Makefile.target

Nothing much here yet. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 5 + 1 file changed, 5 insertions(+) create mode 100644 tests/tcg/aarch64/Makefile.target diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target

Re: [Qemu-devel] [RFC for-2.13 0/7] spapr: Clean up pagesize handling

On Fri, 2018-04-20 at 20:21 +1000, David Gibson wrote: > On Fri, Apr 20, 2018 at 11:31:10AM +0200, Andrea Bolognani wrote: > > I'll have to look into it to be sure, but I think it should be > > possible for libvirt to convert a generic > > > > > > > > > > > > to a more specific > > >

[Qemu-devel] [PATCH v3 26/46] tests/tcg: move ARM specific tests into subdir

These only need to be built for ARM guests. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 3/4] QemuMutex: support --enable-debug-mutex

On Tue, Apr 24, 2018 at 12:51:11 +0800, Peter Xu wrote: > We have had some tracing tools for mutex but it's not easy to use them > for e.g. dead locks. Let's provide "--enable-debug-mutex" parameter > when configure to allow QemuMutex to store the last owner that took > specific lock. It will be

[Qemu-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory

From: Ross Lagerwall Xen unstable (to be in 4.11) has two new dmops, relocate_memory and pin_memory_cacheattr. Use these to set up the VGA memory, replacing the previous calls to libxc. This allows the VGA console to work properly when QEMU is running restricted

[Qemu-devel] [PATCH v8 00/16] xen: xen-domid-restrict improvements

This series provides necessary support for running qemu as a Xen device model without power equivalent to root. In particular, it makes -xen-domid-restrict effective. Compared to v8, it addresses review comments. 01/16 checkpatch: Add xendevicemodel_handle to the list of r 02/16

[Qemu-devel] [PATCH 10/16] os-posix: Provide new -runas : facility

This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

[Qemu-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap

The last user was just removed; remove this function, accordingly. Signed-off-by: Ian Jackson Acked-by: Anthony PERARD --- include/hw/xen/xen_common.h | 22 -- 1 file changed, 22 deletions(-) diff --git

[Qemu-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson

Re: [Qemu-devel] [PATCH v3 36/46] tests/tcg/alpha: add Alpha specific tests

On 04/24/2018 05:23 AM, Alex Bennée wrote: > These tests are a little strange as they use their own crt.o stub > instead of the system supplied one. We also disable the multiarch > testthread test as that requires a dynamically linked build. > > Signed-off-by: Alex Bennée

Re: [Qemu-devel] [Qemu-block] [PATCH] blockjob: drop block_job_pause/resume_all()

On 04/24/2018 04:52 AM, Stefan Hajnoczi wrote: > Commit 8119334918e86f45877cfc139192d54f2449a239 ("block: Don't > block_job_pause_all() in bdrv_drain_all()") removed the only callers of > block_job_pause/resume_all(). > > Pausing and resuming now happens in child_job_drained_begin/end() so >

[Qemu-devel] [PATCH for 2.13 v4 03/20] linux-user: move arm signal.c parts to arm directory

No code change, only move code from signal.c to arm/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH for 2.13 v4 17/20] linux-user: move sparc/sparc64 signal.c parts to sparc directory

No code change, only move code from signal.c to sparc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). sparc64/signal.c includes sparc/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by:

[Qemu-devel] [PATCH for 2.13 v4 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

No code change, only move code from signal.c to mips/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). mips64/signal.c includes mips/signal.c Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex

[Qemu-devel] [RFC PATCH 21/33] job: Move BlockJobCreateFlags to Job

This renames the BlockJobCreateFlags constants, moves a few JOB_INTERNAL checks to job_create() and the auto_{finalize,dismiss} fields from BlockJob to Job. Signed-off-by: Kevin Wolf --- include/block/blockjob.h | 17 - include/block/blockjob_int.h | 3 +--

[Qemu-devel] [PATCH v3 22/46] tests/tcg/i386: disable i386 version of test-i386-ssse

It doesn't build for i386 easily and we probably need a better more methodical test for SSE et all in QEMU. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/i386/Makefile.target

[Qemu-devel] [PATCH v3 35/46] tests/tcg: enable building for Alpha

We can't use our normal Debian based compilers as Alpha isn't an officially supported architecture. However it is available as a port and fortunately cross compilers for all these targets are included in Debian Sid, the perpetual rolling/unstable/testing version of Debian. Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v1 2/2] riscv: htif: increase the priority of the htif subregion

On 04/20/2018 02:57 AM, Michael Clark wrote: On Wed, Apr 18, 2018 at 10:16 PM, KONRAD Frederic < frederic.kon...@adacore.com> wrote: The htif device is supposed to be mapped over an other subregion. So increase its priority to one to avoid any conflict. Here is the output of info mtree:

Re: [Qemu-devel] [PATCH v2 0/9] block: Add COR filter driver

Am 21.04.2018 um 15:29 hat Max Reitz geschrieben: > This series adds a copy-on-read block filter driver which works by > simply setting the BDRV_REQ_COPY_ON_READ flag on write requests (and > otherwise just passing everything through). Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180424152405.10304-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v3 00/46] fix building of tests/tcg === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] block/mirror: honor ratelimit again

Am 24.04.2018 um 14:35 hat Stefan Hajnoczi geschrieben: > Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 ("block/mirror: change > the semantic of 'force' of block-job-cancel") accidentally removed the > ratelimit in the mirror job. > > Reintroduce the ratelimit but keep the block-job-cancel

Re: [Qemu-devel] [PATCH] block/mirror: honor ratelimit again

On Tue, Apr 24, 2018 at 01:35:27PM +0100, Stefan Hajnoczi wrote: > Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 ("block/mirror: change > the semantic of 'force' of block-job-cancel") accidentally removed the > ratelimit in the mirror job. > > Reintroduce the ratelimit but keep the

Re: [Qemu-devel] [RFC PATCH] hw/s390x: Allow to configure the consoles with the "-serial" parameter

On 24.04.2018 13:44, Thomas Huth wrote: > The consoles ("sclpconsole" and "sclplmconsole") can only be configured > with "-device" and "-chardev" so far. Other machines use the convenience > option "-serial" to configure the default consoles, too, even for virtual > consoles like spapr-vty on the

[Qemu-devel] [PATCH for 2.13 v4 06/20] linux-user: move cris signal.c parts to cris directory

No code change, only move code from signal.c to cris/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v2 1/6] block: Support byte-based aio callbacks

We are gradually moving away from sector-based interfaces, towards byte-based. Add new sector-based aio callbacks for read and write, to match the fact that bdrv_aio_pdiscard is already byte-based. Ideally, drivers should be converted to use coroutine callbacks rather than aio; but that is not

[Qemu-devel] [RFC PATCH 07/33] job: Create Job, JobDriver and job_create()

This is the first step towards creating an infrastructure for generic background jobs that aren't tied to a block device. For now, Job only stores its ID and JobDriver, the rest stays in BlockJob. The following patches will move over more parts of BlockJob to Job if they are meaningful outside

Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

On 04/24/2018 10:40 AM, Eric Blake wrote: > On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote: > >>> - static void vreport(report_type type, const char *fmt, va_list ap) >>> + static void vreport(report_type type, int errnoval, const char *fmt, >>> va_list ap) >>> ... >>> + if (errnoval >=

[Qemu-devel] [PATCH v3 38/46] tests/tcg: enable building for HPPA

Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-hppa-cross.docker | 12 tests/tcg/hppa/Makefile.include | 2 ++ 3 files changed, 15 insertions(+) create mode 100644

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

On 04/24/2018 12:19 PM, Kevin Wolf wrote: +static void null_refresh_limits(BlockDriverState *bs, Error **errp) +{ +bs->bl.request_alignment = 1; +} >>> >>> I would rather modify bdrv_refresh_limits() so that it defaults to 1 for >>> drivers supporting either

[Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted

From: Ross Lagerwall Saving the current state to xenstore may fail when running restricted (in particular, after a migration). Therefore, don't report the error or exit when running restricted. Toolstacks that want to allow running QEMU restricted should instead make

[Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types

This avoids checkpatch misparsing (as statements) long function definitions or declarations, which sometimes start with constructs like this: static inline int xendevicemodel_relocate_memory( xendevicemodel_handle *dmod, domid_t domid, ... The type xendevicemodel_handle does not conform

[Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites

Signed-off-by: Ian Jackson CC: Paolo Bonzini CC: Markus Armbruster CC: Daniel P. Berrange CC: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé --- v8: Remove one

[Qemu-devel] [PATCH for 2.13 v4 14/20] linux-user: move hppa signal.c parts to hppa directory

No code change, only move code from signal.c to hppa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard

[Qemu-devel] [PATCH v2 2/6] file-win32: Switch to byte-based callbacks

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based callbacks in the file-win32 driver. Note that the driver was already using byte-based calls for performing actual I/O, so this just gets rid of a round trip of scaling;

[Qemu-devel] [PATCH v2 3/6] null: Switch to byte-based read/write

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based callbacks in the null-co and null-aio drivers. Note that since the null driver does nothing on writes, it trivially supports the BDRV_REQ_FUA flag (all writes have already

[Qemu-devel] [PATCH v3 15/46] tests/tcg/multiarch: move most output to stdout

The default test run outputs to stdout so it can be re-directed. Errors are still reported to stderr. Signed-off-by: Alex Bennée --- tests/tcg/multiarch/test-mmap.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote: >> - static void vreport(report_type type, const char *fmt, va_list ap) >> + static void vreport(report_type type, int errnoval, const char *fmt, >> va_list ap) >> ... >> + if (errnoval >= 0) { >> + error_printf(": %s",

[Qemu-devel] [PATCH v3 36/46] tests/tcg/alpha: add Alpha specific tests

These tests are a little strange as they use their own crt.o stub instead of the system supplied one. We also disable the multiarch testthread test as that requires a dynamically linked build. Signed-off-by: Alex Bennée --- tests/tcg/alpha/Makefile | 35

[Qemu-devel] [PATCH v3 39/46] tests/tcg: enable building for m68k

As before, using Debian SID compilers. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-m68k-cross.docker | 12 tests/tcg/m68k/Makefile.include | 2 ++ 3 files

[Qemu-devel] [PATCH v3 18/46] tests/tcg: enable building for i386

While you can construct a compile command that does work using the x86_64 host compiler that most people use this is flakey. Different distros handle this is different ways so we default to using a known good i386 compiler via docker. Signed-off-by: Alex Bennée --- v3

Re: [Qemu-devel] [PATCH v2 9/9] iotests: Add test for COR across nodes

Am 21.04.2018 um 15:29 hat Max Reitz geschrieben: > COR across nodes (that is, you have some filter node between the > actually COR target and the node that performs the COR) cannot reliably > work together with the permission system when there is no explicit COR > node that can request the

Re: [Qemu-devel] [PATCH 1/6] block: Support byte-based aio callbacks

Am 24.04.2018 um 19:06 hat Eric Blake geschrieben: > On 04/24/2018 10:40 AM, Kevin Wolf wrote: > > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: > >> We are gradually moving away from sector-based interfaces, towards > >> byte-based. Add new sector-based aio callbacks for read and write, >

Re: [Qemu-devel] [PATCH] migration/fd: abort migration if receive POLLHUP event

* Wang Xin (wangxinxin.w...@huawei.com) wrote: > If the fd socket peer closed shortly, ppoll may receive a POLLHUP > event before the expected POLLIN event, and qemu will do nothing > but goes into an infinite loop of the POLLHUP event. > > So, abort the migration if we receive a POLLHUP event.

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, April 24, 2018 10:43 AM > To: Igor Mammedov > Cc: Schmauss, Erik ; qemu-devel@nongnu.org; Xiao > Guangrong ; Williams,

Re: [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid

On 24 April 2018 at 18:58, Ian Jackson wrote: > I'm going to be editing this function and it makes sense to clean up > this style problem in advance. > > Signed-off-by: Ian Jackson > CC: Paolo Bonzini > CC: Markus

[Qemu-devel] [PATCH for 2.13 v4 05/20] linux-user: move microblaze signal.c parts to microblaze directory

No code change, only move code from signal.c to microblaze/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH for 2.13 v4 10/20] linux-user: move m68k signal.c parts to m68k directory

No code change, only move code from signal.c to m68k/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH for 2.13 v4 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory

No code change, only move code from signal.c to ppc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v2 5/6] vxhs: Switch to byte-based callbacks

We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based callbacks in the vxhs driver. Note that the driver was already using byte-based calls for performing actual I/O, so this just gets rid of a round trip of scaling; however,

[Qemu-devel] [PATCH for 2.13 v4 13/20] linux-user: move riscv signal.c parts to riscv directory

No code change, only move code from signal.c to riscv/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Richard

Re: [Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

On Thu, Apr 19, 2018 at 09:06:30AM +, Shameerali Kolothum Thodi wrote: > > From: Andrew Jones [mailto:drjo...@redhat.com] > > Instead of using memory region aliases, it would be best if each RAM > > region was modeled with pc-dimms, as that would move us towards supporting > > memory hotplug

[Qemu-devel] [RFC PATCH 15/33] job: Add Job.aio_context

When block jobs need an AioContext, they just take it from their main block node. Generic jobs don't have a main block node, so we need to assign them an AioContext explicitly. Signed-off-by: Kevin Wolf --- include/qemu/job.h | 7 ++- blockjob.c | 5 - job.c

[Qemu-devel] [PATCH v3 29/46] tests/tcg/aarch64: add fcvt test cases for AArch64

This runs through the usual float to float conversions and crucially also runs with ARM Alternative Half Precision Format. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target |8 + tests/tcg/aarch64/fcvt.c | 260 ++

[Qemu-devel] [PATCH v3 13/46] tests/tcg/multiarch: Build fix for linux-test

From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex

[Qemu-devel] [PATCH v3 19/46] tests/tcg/i386: Build fix for hello-i386

From: Fam Zheng We have -Werror=missing-prototype, add a dummy prototype to avoid that warning. Signed-off-by: Fam Zheng Reviewed-by: Thomas Huth --- tests/tcg/i386/hello-i386.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v3 24/46] tests/tcg/i386/test-i386: use modern vector_size attributes

The compiler complains about the old __mode__ style attributes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/tcg/i386/test-i386.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH] linux-user: set minimum uname for RISC-V

As support was merged into the mainline kernel at 4.15 it is unlikely 3.8.0 is the correct value. Indeed when I testing binaries created by the current Debian SID compiler the tests failed with: FATAL: kernel too old Signed-off-by: Alex Bennée ---

Re: [Qemu-devel] [PATCH 1/6] block: Support byte-based aio callbacks

On 04/24/2018 10:40 AM, Kevin Wolf wrote: > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. Add new sector-based aio callbacks for read and write, >> to match the fact that bdrv_aio_pdiscard is already

Re: [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write

Am 24.04.2018 um 19:00 hat Eric Blake geschrieben: > On 04/24/2018 10:52 AM, Kevin Wolf wrote: > > Am 15.02.2018 um 20:28 hat Eric Blake geschrieben: > >> We are gradually moving away from sector-based interfaces, towards > >> byte-based. Make the change for the last few sector-based callbacks >

  1   2   3   4   >