Re: [Qemu-devel] [PATCH] usb-host: insert usb device into hostdevs to be scaned

2018-08-17 Thread gerd hoffmann
> > Why live-migrate to localhost? That is rather tricky due to both source > > and target qemu accessing host resources at the same time, and I guess > > this is the reason you are seeing the problems here. > Thanks for your reply, but I'm still confused about these issues: > 1. If local live

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

2018-08-17 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814100010.2546-1-yuval.sh...@oracle.com Subject: [Qemu-devel] [PATCH] hw/rdma:

Re: [Qemu-devel] [PATCH v3 4/6] hw/riscv/virt: Connect a VGA PCIe device

2018-08-17 Thread Gerd Hoffmann
Hi, > +pci_bus = PCI_HOST_BRIDGE(dev)->bus; > + > +pci_vga_init(pci_bus); I'd suggest to use "-device bochs-display" instead, unless you need all the legacy vga cruft (text mode, ...). The bochs-drm kms driver can handle this one just fine too, it is much smaller (in terms of code

[Qemu-devel] Qemu and Spectre_V4 + l1tf + IBRS_FW

2018-08-17 Thread Stefan Priebe - Profihost AG
Hello, i haven't found anything on the web regarding qemu and mentioned variants. While my host says: l1tf:Mitigation: PTE Inversion; VMX: SMT vulnerable, L1D conditional cache flushes meltdown:Mitigation: PTI spec_store_bypass:Mitigation: Speculative Store Bypass disabled via prctl and seccomp

Re: [Qemu-devel] Bugs when cross-compiling qemu for Windows with mingw 8.1, executable doesn't run

2018-08-17 Thread Howard Spoelstra
On Fri, Aug 17, 2018 at 9:32 AM, David Hildenbrand wrote: > On 18.07.2018 08:33, Howard Spoelstra wrote: >> Hi all, >> >> I have two issues when cross compiling current master for Windows with >> mingw 8.1. Host is Fedora29. See further below for gcc and mingw >> versions. >> >> Reproduce with:

Re: [Qemu-devel] How do you do when write more than 16TB data to qcow2 on ext4?

2018-08-17 Thread lampahome
Really? How to mount a blk device to /dev/nbdN? I always find tips to mount from file-like image to /dev/nbdN 2018-08-16 19:46 GMT+08:00 Eric Blake : > On 08/16/2018 03:22 AM, Daniel P. Berrangé wrote: > >> On Thu, Aug 16, 2018 at 09:35:52AM +0800, lampahome wrote: >> >>> We all know there's a

[Qemu-devel] [PATCH 1/2] linux-headers: update to mainline 5c60a7389d79

2018-08-17 Thread Jason Wang
Sync linux headers to 5c60a7389d79 ("Merge tag 'for-linus-4.19-ofs1' of git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux"). Signed-off-by: Jason Wang --- include/standard-headers/drm/drm_fourcc.h | 176 + include/standard-headers/linux/ethtool.h |

Re: [Qemu-devel] Pipe key broken on US keyboards

2018-08-17 Thread Daniel P . Berrangé
On Thu, Aug 16, 2018 at 03:44:54PM -0400, Phillip Susi wrote: > On 8/16/2018 1:27 PM, Daniel P. Berrangé wrote: > > Did you actually 'git bisect' to that commit, or is that just a guess ? > > No, I haven't actually tried to build it from sources myself yet so I > just found the source file that

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Gerd Hoffmann
Hi, > b) Rather than a "legacy-only" model for virtio-0.9, it would be more > useful to have "transitional". This way the config would work for older > OSes that don't support virtio-1.0, and when/if the OS was upgraded such > that it supported virtio-1.0, that would be automatically used

[Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Thomas Huth
While adding the object_initialize_child() function, Paolo suggested to rename the similar object_new_with_props() function accordingly: http://marc.info/?i=e034610d-9a1d-a8a5-ee92-b2e3f0ba2...@redhat.com This way it is more obvious that this function creates a new object as a child of another

Re: [Qemu-devel] [PATCH v3 2/4] kvm: Use inhibit to prevent ballooning without synchronous mmu

2018-08-17 Thread Paolo Bonzini
On 16/08/2018 20:15, Alex Williamson wrote: > On Tue, 7 Aug 2018 13:31:23 -0600 > Alex Williamson wrote: > >> Remove KVM specific tests in balloon_page(), instead marking >> ballooning as inhibited without KVM_CAP_SYNC_MMU support. >> >> Reviewed-by: David Hildenbrand >> Reviewed-by: Peter Xu

Re: [Qemu-devel] [PATCH 55/56] json: Clean up headers

2018-08-17 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:03 AM, Markus Armbruster wrote: >> The JSON parser has three public headers, json-lexer.h, json-parser.h, >> json-streamer.h. They all contain stuff that is of no interest >> outside qobject/json-*.c. >> >> Collect the public interface in

Re: [Qemu-devel] [PULL v2 00/15] MIPS queue for QEMU upstream, August 16, 2018

2018-08-17 Thread Peter Maydell
On 16 August 2018 at 18:48, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit c542a9f9794ec8e0bc3fcf5956d3cc8bce667789: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-tests-2018-08-16' > into staging (2018-08-16 09:50:54 +0100) > > are

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-17 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/10/2018 10:48 AM, Eric Blake wrote: >>> On 08/08/2018 07:03 AM, Markus Armbruster wrote: This is consistent with qobject_to_json(). See commit e2ec3f97680. >>> >>> Side note: that commit mentions that on output, ASCII DEL (0x7f) is

Re: [Qemu-devel] Bugs when cross-compiling qemu for Windows with mingw 8.1, executable doesn't run

2018-08-17 Thread David Hildenbrand
On 18.07.2018 08:33, Howard Spoelstra wrote: > Hi all, > > I have two issues when cross compiling current master for Windows with > mingw 8.1. Host is Fedora29. See further below for gcc and mingw > versions. > > Reproduce with: > ./configure --cross-prefix=x86_64-w64-mingw32- >

Re: [Qemu-devel] [PATCH v4 6/7] qmp: add pmemload command

2018-08-17 Thread Simon Ruderich
On Thu, Aug 16, 2018 at 03:01:31PM -0500, Eric Blake wrote: >> +} >> +if (!has_size) { >> +struct stat s; >> +if (fstat(fd, )) { >> +error_setg_errno(errp, errno, "could not fstat fd to get size"); >> +goto exit; >> +} >> +size =

[Qemu-devel] [PATCH 2/2] vhost: switch to use IOTLB v2 format

2018-08-17 Thread Jason Wang
This patch tries to switch to use new kernel IOTLB format V2. Previous version may have inconsistent ABI between 32bit and 64bit machines because of the hole after type field. Refer kernel commit ("429711aec282 vhost: switch to use new message format") for more information. To enable this

Re: [Qemu-devel] [PATCH 56/56] docs/interop/qmp-spec: How to force known good parser state

2018-08-17 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:03 AM, Markus Armbruster wrote: >> Section "QGA Synchronization" specifies that sending "a raw 0xFF >> sentinel byte" makes the server "reset its state and discard all >> pending data prior to the sentinel." What actually happens there is a >> lexical

Re: [Qemu-devel] nbd oldstyle negotiation

2018-08-17 Thread Daniel P . Berrangé
On Thu, Aug 16, 2018 at 02:56:10PM -0500, Eric Blake wrote: > On 08/16/2018 02:02 PM, Vladimir Sementsov-Ogievskiy wrote: > > Hi Eric! > > > > There is a small problem with our qemu-nbd cmdline interface: people > > forget to use option -x or don't know about it and face into problems > > with

Re: [Qemu-devel] [PATCH v2 1/8] tests/migration-test: Silence the kvm_hv message by default

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > When running "make check" on a non-POWER host, the output is quite > distorted like this: > > [...] > GTESTER check-qtest-nios2 > GTESTER check-qtest-or1k > GTESTER check-qtest-ppc64 > Skipping test: kvm_hv not available Skipping test: kvm_hv not available > Skipping

[Qemu-devel] vm-tests images disks filling up?

2018-08-17 Thread Peter Maydell
I just ran into a build failure using the tests/vm/ BSD build tests, because the NetBSD build image's disk filled up. Looking more closely there seemed to be 9 stale build trees in the VM's /var/tmp/qemu-test.* , which is why the disk was full (they'd used up about 18GB between them). The other

Re: [Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > mc146818rtc.c still contains some TABs. Replace them with spaces. > And while we're at it, also delete trailing whitespace in this file. > > Reviewed-by: Markus Armbruster > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 4/8] hw/timer/mc146818rtc: Fix introspection problem

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > There is currently a funny problem with the "mc146818rtc" device: > 1) Start QEMU like this: >qemu-system-ppc64 -M pseries -S > 2) At the HMP monitor, enter "info qom-tree". Note that there is an >entry for "/rtc (spapr-rtc)". > 3) Introspect the mc146818rtc device

Re: [Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > The tests that check something for all machine types currently spend > a lot of time checking old machine types (like "pc-i440fx-2.0" for > example). The chances that we find something new there in addition > to checking the latest version of a machine type are pretty low, so

Re: [Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix

2018-08-17 Thread Paolo Bonzini
On 16/08/2018 13:35, Thomas Huth wrote: > The basic idea for this patch series are the two patches that improve > the device-inrospection test: We now check that the qom-tree and the > qtree do not change during introspection, and the we also turn on the > device introspection test with all

Re: [Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > Introspection should not change the qom-tree / qtree, so we should check > this in the device-introspect-test, too. This patch helped to find lots > of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the > last two months. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v2 0/9] synchronization profiler

2018-08-17 Thread Paolo Bonzini
On 17/08/2018 07:18, Emilio G. Cota wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02186.html > > Changes since v1: > > - Rebase on current master. > - Update copyright to 2018. > - Add -m option to the HMP info command to sort by average wait time, > as suggested by

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Andrea Bolognani
On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote: > > 5) Some guest OSes that we still want to support (and which would > > otherwise work okay on a Q35 virtual machine) have virtio drivers too > > old to support virtio-1.0

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: > On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote: > > > 5) Some guest OSes that we still want to support (and which would > > > otherwise work okay on a

Re: [Qemu-devel] vm-tests images disks filling up?

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 11:26:39AM +0100, Peter Maydell wrote: > I just ran into a build failure using the tests/vm/ BSD build tests, > because the NetBSD build image's disk filled up. > > Looking more closely there seemed to be 9 stale build trees in > the VM's /var/tmp/qemu-test.* , which is

Re: [Qemu-devel] [PATCH 8/9] hmp-commands: add sync-profile

2018-08-17 Thread Dr. David Alan Gilbert
* Emilio G. Cota (c...@braap.org) wrote: > The command introduced here is just for developers. This means that: > > - the interface implemented here could change in the future > - the command is only meant to be used from HMP, not from QMP > > Signed-off-by: Emilio G. Cota > --- > hmp.h

Re: [Qemu-devel] [PATCH 9/9] hmp-commands-info: add sync-profile

2018-08-17 Thread Dr. David Alan Gilbert
* Emilio G. Cota (c...@braap.org) wrote: > The command introduced here is just for developers. This means that: > > - the info displayed and the output format could change in the future > - the command is only meant to be used from HMP, not from QMP > > Sample output: > > (qemu) sync-profile >

[Qemu-devel] [PATCH correct] checkpatch: allow space in more places before a bracket

2018-08-17 Thread Paolo Bonzini
From: Heinrich Schuchardt Allow a space between a colon and subsequent opening bracket. This sequence may occur in inline assembler statements like asm( "ldr %[out], [%[in]]\n\t" : [out] "=r" (ret) : [in] "r" (addr) ); Allow a

Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Paolo Bonzini
On 17/08/2018 12:04, Daniel P. Berrangé wrote: > On Fri, Aug 17, 2018 at 10:59:44AM +0100, Daniel P. Berrangé wrote: >> On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote: >>> On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote: On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth

Re: [Qemu-devel] vm-tests images disks filling up?

2018-08-17 Thread Peter Maydell
On 17 August 2018 at 11:47, Daniel P. Berrangé wrote: > I'd prefer to see the test process honouring the build directory instead > of putting stuff in /var/tmp, so that a developer's normal approach to > cleaning up build artifacts works. That's tricky because the build directory is outside the

Re: [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none"

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > Certain device introspection crashes used to only happen if you were > using a certain machine, e.g. if the machine was using serial_hd() or > nd_table[], and a device was trying to use these in its instance_init > function, too. > > To be able to catch these problems, let's

Re: [Qemu-devel] [PATCH v2 8/8] MAINTAINERS: add maintainers for qtest

2018-08-17 Thread Juan Quintela
Thomas Huth wrote: > From: Paolo Bonzini > > Thomas has been doing a lot of work on qom-test and device-introspection-test, > and Laurent has ported libqos to sPAPR and co-mentored Emanuele on the > upcoming qtest device framework. They deserve recognition. :) > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] vm-tests images disks filling up?

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 11:47:06AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 17, 2018 at 11:26:39AM +0100, Peter Maydell wrote: > > I just ran into a build failure using the tests/vm/ BSD build tests, > > because the NetBSD build image's disk filled up. > > > > Looking more closely there

Re: [Qemu-devel] [PATCH V11 05/20] COLO: Add block replication into colo process

2018-08-17 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > Make sure master start block replication after slave's block > replication started. > > Besides, we need to activate VM's blocks before goes into > COLO state. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Zhang Chen

Re: [Qemu-devel] [PATCH V10 05/20] COLO: Add block replication into colo process

2018-08-17 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > On Tue, Aug 7, 2018 at 10:30 PM Dr. David Alan Gilbert > wrote: > > > * Zhang Chen (zhangc...@gmail.com) wrote: > > > Make sure master start block replication after slave's block > > > replication started. > > > > > > Besides, we need to activate VM's

Re: [Qemu-devel] [PATCH 56/56] docs/interop/qmp-spec: How to force known good parser state

2018-08-17 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:03 AM, Markus Armbruster wrote: >> Section "QGA Synchronization" specifies that sending "a raw 0xFF >> sentinel byte" makes the server "reset its state and discard all >> pending data prior to the sentinel." What actually happens there is a >> lexical

Re: [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Daniel P . Berrangé
On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote: > Summary of the problem: > > 1) We want to persuade libvirt+QEMU users to move away from the i440fx > machinetype in favor of Q35. (NB: Someday this *might* lead to the > ability to deprecate and even remove the 440fx machinetype, but

Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote: > While adding the object_initialize_child() function, Paolo suggested > to rename the similar object_new_with_props() function accordingly: > > http://marc.info/?i=e034610d-9a1d-a8a5-ee92-b2e3f0ba2...@redhat.com > > This way it is

Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 10:59:44AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote: > > On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote: > > > On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote: > > >> While adding the

Re: [Qemu-devel] [Qemu-arm] [PATCH 00/10] target/arm: Some pieces of support for 32-bit Hyp mode

2018-08-17 Thread Peter Maydell
On 14 August 2018 at 13:42, Peter Maydell wrote: > Now we have virtualization support in the GICv2 emulation, > I thought I'd have a look at how much we were still missing > for being able to enable EL2 support for AArch32. > This set of patches fixes some minor missing pieces: > * various small

Re: [Qemu-devel] Qemu and Spectre_V4 + l1tf + IBRS_FW

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 08:44:38AM +0200, Stefan Priebe - Profihost AG wrote: > Hello, > > i haven't found anything on the web regarding qemu and mentioned variants. > > While my host says: > l1tf:Mitigation: PTE Inversion; VMX: SMT vulnerable, L1D conditional > cache flushes >

Re: [Qemu-devel] [PATCH] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1534422540-18815-1-git-send-email-hans-erik.flo...@rt-labs.com Subject: [Qemu-devel] [PATCH] sdhci: add i.MX SD Stable Clock bit === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Thomas Huth
On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote: > On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote: >> While adding the object_initialize_child() function, Paolo suggested >> to rename the similar object_new_with_props() function accordingly: >> >>

Re: [Qemu-devel] [RFC PATCH] qom: Rename object_new_with_props to object_new_child

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote: > On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote: > >> While adding the object_initialize_child() function, Paolo suggested > >> to rename the similar

Re: [Qemu-devel] [PATCH 3/4] scripts/qemu: add render_block_graph method for QEMUMachine

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
17.08.2018 04:54, Eduardo Habkost wrote: On Thu, Aug 16, 2018 at 08:20:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: Render block nodes graph with help of graphviz Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks for your patch. Comments below: --- scripts/qemu.py | 53

[Qemu-devel] [PATCH 3/3] hw/misc: Remove mmio_interface device

2018-08-17 Thread Peter Maydell
The mmio_interface device was a purely internal artifact of the implementation of the memory subsystem's request_ptr APIs. Now that we have removed those APIs, we can remove the mmio_interface device too. Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs| 1 -

[Qemu-devel] [PATCH 1/3] hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code

2018-08-17 Thread Peter Maydell
We now support direct execution from MMIO regions in the core memory subsystem. This means that we don't need to have device-specific support for it, and we can remove the request_ptr handling from the Xilinx SPIPS device. (It was broken anyway due to race conditions, and disabled by default.)

[Qemu-devel] [PATCH 2/3] memory: Remove MMIO request_ptr APIs

2018-08-17 Thread Peter Maydell
Remove the obsolete MMIO request_ptr APIs; they have no users now. Signed-off-by: Peter Maydell --- include/exec/memory.h | 35 -- memory.c | 110 -- 2 files changed, 145 deletions(-) diff --git a/include/exec/memory.h

[Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

2018-08-17 Thread Peter Maydell
Now that support has hit master for direct execution from arbitrary MMIO regions, we can remove the MMIO request_ptr API, which required special case support in each device that wanted to handle it, and also had bad race conditions that resulted in crashes if you tried to use it heavily. This API

Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-08-16

2018-08-17 Thread Peter Maydell
On 17 August 2018 at 02:33, Eduardo Habkost wrote: > The following changes since commit bb16c0412a572c2c9cd44496deb3ad430bc49c1a: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180816' into staging (2018-08-16 > 14:35:50 +0100) > > are available in the Git

Re: [Qemu-devel] vm-tests images disks filling up?

2018-08-17 Thread Fam Zheng
On Fri, 08/17 11:26, Peter Maydell wrote: > I just ran into a build failure using the tests/vm/ BSD build tests, > because the NetBSD build image's disk filled up. > > Looking more closely there seemed to be 9 stale build trees in > the VM's /var/tmp/qemu-test.* , which is why the disk was full >

[Qemu-devel] [PATCH v2] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread Hans-Erik Floryd
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH v3] sdhci: add i.MX SD Stable Clock bit

2018-08-17 Thread Hans-Erik Floryd
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE. Freescale recommends checking this bit when changing clock frequency. Signed-off-by: Hans-Erik Floryd --- hw/sd/sdhci-internal.h | 2 ++ hw/sd/sdhci.c | 8 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] what should we do to make it easier for new contributors to get started on QEMU?

2018-08-17 Thread Peter Maydell
Hi; this is something of a survey question. I'm particularly interested in answers from people who've recently had to go through the process of getting up to speed with working on QEMU, so I've cc'd our current Outreachy and GSoC students, but input from anybody is welcome. * If we did one thing

[Qemu-devel] [PATCH v2 3/7] block/qcow2-refcount: check_refcounts_l2: refactor compressed case

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Separate offset and size of compressed cluster. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 566c19fbfa..0ea01e3ee2 100644 ---

[Qemu-devel] [PATCH 0/7] qcow2 check improvements

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Hi all! v2: 02, 06: check bdrv_getlength error return code v1: We've faced the following problem: after host fs corruption, vm images becomes invalid. And which is interesting, starting qemu-img check on them led to allocating of the whole RAM and then killing qemu-img by OOM Killer. This was

[Qemu-devel] [PATCH v2 5/7] block/qcow2-refcount: check_refcounts_l2: split fix_l2_entry_to_zero

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Split entry repairing to separate function, to be reused later. Note: entry in in-memory l2 table (local variable in check_refcounts_l2) is not updated after this patch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 147

[Qemu-devel] [PATCH v2 2/7] block/qcow2-refcount: avoid eating RAM

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
qcow2_inc_refcounts_imrt() (through realloc_refcount_array()) can eat an unpredictable amount of memory on corrupted table entries, which are referencing regions far beyond the end of file. Prevent this, by skipping such regions from further processing. Signed-off-by: Vladimir

[Qemu-devel] [PATCH v2 1/7] block/qcow2-refcount: fix check_oflag_copied

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Increase corruptions_fixed only after successful fix. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 3c539f02e5..615847eb09 100644 ---

[Qemu-devel] [PATCH v2 7/7] block/qcow2-refcount: fix out-of-file L2 entries to be read-as-zero

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Rewrite corrupted L2 table entry, which reference space out of underlying file. Make this L2 table entry read-as-all-zeros without any allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 32 1 file changed, 32 insertions(+)

[Qemu-devel] [PATCH v2 4/7] block/qcow2-refcount: check_refcounts_l2: reduce ignored overlaps

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Reduce number of structures ignored in overlap check: when checking active table ignore active tables, when checking inactive table ignore inactive ones. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

2018-08-17 Thread Paolo Bonzini
On 17/08/2018 13:46, Peter Maydell wrote: > Now that support has hit master for direct execution from > arbitrary MMIO regions, we can remove the MMIO request_ptr > API, which required special case support in each device that > wanted to handle it, and also had bad race conditions that > resulted

[Qemu-devel] [PATCH v2 6/7] block/qcow2-refcount: fix out-of-file L1 entries to be zero

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
Zero out corrupted L1 table entry, which reference L2 table out of underlying file. Zero L1 table entry means that "the L2 table and all clusters described by this L2 table are unallocated." Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 44

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote: >> > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote: >> > > 5) Some guest OSes that we still want to support (and which

Re: [Qemu-devel] Pipe key broken on US keyboards

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 09:10:54AM -0400, Phillip Susi wrote: > On 8/17/2018 8:58 AM, Daniel P. Berrangé wrote: > > Actually for QEMU there is no default localized keymap. This is desirable > > because it allows VNC to activate its raw scancode extension which is more > > reliable than passing

Re: [Qemu-devel] [PATCH 2/4] nbd/server: Advertise actual minimum block size

2018-08-17 Thread Vladimir Sementsov-Ogievskiy
02.08.2018 17:48, Eric Blake wrote: Both NBD_CMD_BLOCK_STATUS and structured NBD_CMD_READ will split their reply according to bdrv_block_status() boundaries. If the block device has a request_alignment smaller than 512, but we advertise a block alignment of 512 to the client, then this can

Re: [Qemu-devel] [PATCH v9 40/84] target/mips: Fix pre-nanoMIPS MT ASE instructions availability control

2018-08-17 Thread Aleksandar Markovic
> > I think some of the previously-implemented similar cases involving > > read-only bits were handled the same way, and we just built on that. What > > would you suggest as a more appropriate solution in such cases (of > > accessing "preset by hardware" bits)? > > Well, ctx->insn_flags and

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-17 Thread Andrea Bolognani
On Fri, 2018-08-17 at 11:43 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote: > > If we decide we want to explicitly spell out the options instead > > of relying on QEMU changing behavior based on the slot type, which > > is probably a good idea

[Qemu-devel] [PATCH v10 10/65] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions

2018-08-17 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of LWXS16, LB16, SB16, LBU16, LH16, SH16, LHU16, LW16, LWSP16, LW4X4, SW4X4, LWGP16, SWSP16, SW16, and SWGP16 instructions. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic Reviewed-by: Aleksandar Markovic ---

[Qemu-devel] [PATCH v10 03/65] target/mips: Add nanoMIPS DSP ASE opcodes

2018-08-17 Thread Aleksandar Markovic
From: Stefan Markovic Add nanoMIPS opcodes for DSP ASE instruction pools and instructions. Reviewed-by: Richard Henderson Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 215 1 file changed, 215

[Qemu-devel] [PATCH v10 17/65] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)

2018-08-17 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of nanoMIPS instructions that are situated in pool32a0. Reviewed-by: Richard Henderson Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 185

[Qemu-devel] [PATCH v10 21/65] target/mips: Implement emulation of nanoMIPS EXTW instruction

2018-08-17 Thread Aleksandar Markovic
From: James Hogan Implement emulation of nanoMIPS EXTW instruction. EXTW instruction is similar to the MIPS r6 ALIGN instruction, except that it counts the other way and in bits instead of bytes. We therefore generalise gen_align() function into a new gen_align_bits() function (which counts in

[Qemu-devel] [PATCH v10 25/65] target/mips: Fix pre-nanoMIPS MT ASE instructions availability control

2018-08-17 Thread Aleksandar Markovic
From: Aleksandar Rikalo Use bits from configuration registers for availability control of MT ASE instructions, rather than only ISA_MT bit in insn_flags. This is done by adding a field in hflags for MT bit, and adding functions check_mt() and check_cp0_mt(). Reviewed-by: Aleksandar Markovic

[Qemu-devel] [PATCH v10 27/65] target/mips: Add emulation of DSP ASE for nanoMIPS - part 1

2018-08-17 Thread Aleksandar Markovic
From: Stefan Markovic Add emulation of DSP ASE instructions for nanoMIPS - part 1. Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 554 1 file changed, 554

Re: [Qemu-devel] [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6

2018-08-17 Thread Aleksandar Markovic
> From: Richard Henderson > Sent: Thursday, August 16, 2018 7:38 PM > > Subject: Re: [PATCH v9 47/84] target/mips: Add emulation of DSP ASE for > nanoMIPS - part 6 > > On 08/16/2018 07:57 AM, Aleksandar Markovic wrote: > > From: Stefan Markovic > > > > Add emulation of DSP ASE instructions

Re: [Qemu-devel] [RFC PATCH 1/6] hw/arm/virt: Add virt-3.1 machine type

2018-08-17 Thread Peter Maydell
On 23 July 2018 at 13:22, Igor Mammedov wrote: > On Wed, 4 Jul 2018 14:49:18 +0200 > Andrew Jones wrote: > >> Signed-off-by: Andrew Jones > > Reviewed-by: Igor Mammedov We're going to want a virt-3.1 machine anyway, so I'm going to take just this patch from this series and apply it to

[Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

2018-08-17 Thread Markus Armbruster
JSON is such a simple language, so writing a parser should be easy, shouldn't it? Well, the evidence is in, and it's a lot of patches. Summary of fixes: * Reject ASCII control characters in strings as RFC 7159 specifies * Reject all invalid UTF-8 sequences, not just some * Reject invalid

[Qemu-devel] [PATCH v10 64/65] gdbstub: Add XML support for GDB for nanoMIPS

2018-08-17 Thread Aleksandar Markovic
From: Stefan Markovic Add XML support files for GDB for nanoMIPS. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- MAINTAINERS| 3 ++- gdb-xml/nanomips-cp0.xml | 13 + gdb-xml/nanomips-cpu.xml | 44

Re: [Qemu-devel] [PATCH 2/4] nbd/server: Advertise actual minimum block size

2018-08-17 Thread Eric Blake
On 08/17/2018 08:49 AM, Vladimir Sementsov-Ogievskiy wrote: BDRV_SECTOR_SIZE : 1; +    /* minimum - 1 for back-compat, or actual if client will obey it. */ +    if (client->opt == NBD_OPT_INFO || blocksize) { +    sizes[0] = blk_get_request_alignment(exp->blk); +    } else { +   

[Qemu-devel] [PATCH v2 15/60] check-qjson: Cover interpolation more thoroughly

2018-08-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 166 +++- 1 file changed, 102 insertions(+), 64 deletions(-) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index 1581fbf170..4fb43e4d5d 100644 --- a/tests/check-qjson.c +++

[Qemu-devel] [PATCH v2 35/60] json: Don't create JSON_ERROR tokens that won't be used

2018-08-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qobject/json-streamer.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c index 0c33186e8e..fa595a8761 100644 --- a/qobject/json-streamer.c +++

Re: [Qemu-devel] Pipe key broken on US keyboards

2018-08-17 Thread Daniel P . Berrangé
On Fri, Aug 17, 2018 at 08:44:36AM -0400, Phillip Susi wrote: > On 8/17/2018 4:56 AM, Daniel P. Berrangé wrote: > > Oh one other thing, is whether your QEMU process has an explicit keymap > > configured (this is the -k arg to QEMU), as when that it set, it > > completely changes the way keyboard

Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl

2018-08-17 Thread Eduardo Habkost
Thanks for the patch, comments below: On Fri, Aug 10, 2018 at 10:06:28PM +0800, Robert Hoo wrote: > Add kvm_get_supported_feature_msrs() to get supported MSR feature index list. > Add kvm_arch_get_supported_msr_feature() to get each MSR features value. > > kvm_get_supported_feature_msrs() is

Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

2018-08-17 Thread Edgar E. Iglesias
On Fri, Aug 17, 2018 at 12:46:16PM +0100, Peter Maydell wrote: > Now that support has hit master for direct execution from > arbitrary MMIO regions, we can remove the MMIO request_ptr > API, which required special case support in each device that > wanted to handle it, and also had bad race

Re: [Qemu-devel] [PATCH v3 3/3] Change other funcitons referring to feature_word_info[]

2018-08-17 Thread Eduardo Habkost
On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote: > Add an util function feature_word_description(), which help construct the > string > describing the feature word (both CPUID and MSR types). > > report_unavailable_features(): add MSR_FEATURE_WORD type support. >

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type

2018-08-17 Thread Peter Maydell
On 25 July 2018 at 06:30, Hongbo Zhang wrote: > For the Aarch64, there is one machine 'virt', it is primarily meant to > run on KVM and execute virtualization workloads, but we need an > environment as faithful as possible to physical hardware, for supporting > firmware and OS development for

[Qemu-devel] [PATCH 4/4] test-char: add socket reconnect test

2018-08-17 Thread Marc-André Lureau
This test exhibits a regression fixed by the previous reverts. Signed-off-by: Marc-André Lureau --- tests/test-char.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-char.c b/tests/test-char.c index 5905d31441..d99742d86d 100644 ---

[Qemu-devel] [PATCH 0/4] Fix socket chardev regression

2018-08-17 Thread Marc-André Lureau
Hi, In commit 25679e5d58e "chardev: tcp: postpone async connection setup" (and its follow up 99f2f54174a59), Peter moved chardev socket connection to machine_done event. However, chardev created later will no longer attempt to connect, and chardev created in tests do not have machine_done event

[Qemu-devel] [PATCH 1/4] Revert "chardev: tcp: postpone TLS work until machine done"

2018-08-17 Thread Marc-André Lureau
This reverts commit 99f2f54174a595e3ada6e4332fcd2b37ebb0d55d. See next commit reverting 25679e5d58e258e9950685ffbd0cae4cd40d9cc2 as well for rationale. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[Qemu-devel] [PATCH 3/4] char-socket: update all ioc handlers when changing context

2018-08-17 Thread Marc-André Lureau
So far, tcp_chr_update_read_handler() only updated the read handler. Let's also update the hup handler. Factorize the code while at it. (note that s->ioc != NULL when s->connected) Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 59 --- 1

[Qemu-devel] [PATCH v10 18/65] target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)

2018-08-17 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of misc nanoMIPS instructions situated in pool32axf. Reviewed-by: Richard Henderson Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 89

[Qemu-devel] [PATCH v10 14/65] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV

2018-08-17 Thread Aleksandar Markovic
From: Yongbok Kim Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV. Reviewed-by: Richard Henderson Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate.c | 33 - 1 file changed, 32

[Qemu-devel] [PATCH v10 56/65] linux-user: Add support for nanoMIPS signal trampoline

2018-08-17 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add signal trampoline support for nanoMIPS. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/mips/signal.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v10 36/65] elf: Add EM_NANOMIPS value as a valid one for e_machine field

2018-08-17 Thread Aleksandar Markovic
From: Aleksandar Rikalo Value 249 is registered as valid for usage for nanoMIPS executables. Reviewed-by: Richard Henderson Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff

[Qemu-devel] [PATCH v10 38/65] elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for MIPS

2018-08-17 Thread Aleksandar Markovic
From: Aleksandar Rikalo Modify load_elf32()/load_elf64() to treat EM_NANOMIPS as legal as EM_MIPS is. Reviewed-by: Richard Henderson Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- include/hw/elf_ops.h | 8 1 file changed, 8

  1   2   3   4   5   >