Re: [Qemu-devel] [PATCH 2/3] usb: ehci: Add support for Allwinner A10

2018-10-30 Thread Gerd Hoffmann
On Mon, Oct 29, 2018 at 11:32:06PM +0100, Philippe Mathieu-Daudé wrote: > From: Guenter Roeck > > Signed-off-by: Guenter Roeck > Signed-off-by: Philippe Mathieu-Daudé > --- > Gerd: You already review this code here: > https://lists.gnu.org/archive/html/qemu-arm/2017-01/msg00345.html > Can we

Re: [Qemu-devel] [PATCH v1] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
+-- On Mon, 29 Oct 2018, Paolo Bonzini wrote --+ | On 29/10/2018 18:56, Paolo Bonzini wrote: | > On 26/10/2018 22:55, Peter Maydell wrote: | >>> +assert(len <= LSI_MAX_MSGIN_LEN); | >>> pci_dma_write(PCI_DEVICE(s), s->dnad, s->msg, len); | >>> /* Linux drivers rely on the last byte

Re: [Qemu-devel] [PATCH v5 08/11] hw/m68k: add Nubus support for macfb video card

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21 + 2 files

Re: [Qemu-devel] [PATCH 3/3] arm: allwinner: Enable USB EHCI

2018-10-30 Thread Gerd Hoffmann
On Mon, Oct 29, 2018 at 11:32:07PM +0100, Philippe Mathieu-Daudé wrote: > From: Guenter Roeck > > Signed-off-by: Guenter Roeck > Reviewed-by: Philippe Mathieu-Daudé > [PMD: Intented tabs -> space] > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/allwinner-a10.c | 2 ++ > 1 file

Re: [Qemu-devel] [PATCH v5 10/11] dp8393x: manage big endian bus

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH v5 02/11] hw/m68k: implement ADB bus support for via

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++

Re: [Qemu-devel] [PATCH RFC v6 5/7] migration: fix the multifd code when receiving less channels

2018-10-30 Thread Peter Xu
On Mon, Oct 29, 2018 at 08:58:16PM +0800, Fei Li wrote: > In our current code, when multifd is used during migration, if there > is an error before the destination receives all new channels, the > source keeps running, however the destination does not exit but keeps > waiting until the source is

[Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
From: Prasad J Pandit While writing a message in 'lsi_do_msgin', message length value in 'msg_len' could be invalid. Add check to avoid OOB access issue. Signed-off-by: Prasad J Pandit --- hw/scsi/lsi53c895a.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) Update

Re: [Qemu-devel] [PATCH v5 01/11] hw/m68k: add via support

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 666 ++

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier This is broken as the linux driver seems broken too... Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/audio/Makefile.objs | 1 + hw/audio/asc.c | 446

Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch

Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 415

Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/scsi/esp.c | 292 +- include/hw/scsi/esp.h | 7 ++ 2

Re: [Qemu-devel] [PATCH v5 04/11] hw/m68k: add macfb video card

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- arch_init.c| 4 + hw/display/Makefile.objs | 1 + hw/display/macfb.c | 419

Re: [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support

2018-10-30 Thread Hervé Poussineau
Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/nubus/Makefile.objs | 4 +

Re: [Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node

2018-10-30 Thread Tomáš Golembiovský
On Mon, 29 Oct 2018 22:27:45 -0500 Michael Roth wrote: > Quoting Tomáš Golembiovský (2018-10-23 06:23:09) > > Note that PCI controller reporting on Windows was and still is broken. > > Unfortunately I don't know how to fix it at the momemnt. See commit message > > and > > code comment. If

Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/scsi/esp.c | 292 >>

Re: [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/Makefile.objs    |   1 + >>  

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:46, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> This is broken as the linux driver seems broken too... >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >>

Re: [Qemu-devel] [PATCH v2 2/2] tests: fw_cfg: add reboot_timeout test case

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 05:28, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > tests/fw_cfg-test.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index 1c5103fe1c..aeabd17ec0 100644 > --- a/tests/fw_cfg-test.c > +++ b/tests/fw_cfg-test.c

Re: [Qemu-devel] [PATCH RFC v6 5/7] migration: fix the multifd code when receiving less channels

2018-10-30 Thread Fei Li
On 10/30/2018 02:05 PM, Peter Xu wrote: On Mon, Oct 29, 2018 at 08:58:16PM +0800, Fei Li wrote: In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, however the destination does not exit

Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:48, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/block/Makefile.objs  |   1 + >>   hw/block/swim.c 

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 15:19, Stefan Berger wrote: > From: Stefan Berger > > This pull request fixes a couple of TPM support related issues, > such as full initialization of a variable to quiet down valgrind, > a possible race in the TPM related test cases and marking test > cases as skipped if

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:14, Marc-André Lureau wrote: > Hi Peter > > On Tue, Oct 30, 2018 at 2:45 PM Peter Maydell > wrote: >> Hi; this gives some test failures (all hosts): >> >> TEST: tests/tpm-crb-swtpm-test... (pid=305) >> /i386/tpm/crb-swtpm/test:

Re: [Qemu-devel] [PATCH v2] strongarm: mask off high[32:28] bits from dir and state registers

2018-10-30 Thread P J P
+-- On Mon, 29 Oct 2018, Peter Maydell wrote --+ | > switch (offset) { | > case GPDR:/* GPIO Pin-Direction registers */ | > -s->dir = value; | > +s->dir = value & 0x3f; | | The commit message says it's masking [31:28], but the | code is masking [31:22]. The

Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Misc changes in comments and strings for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 14 +++--- target/mips/translate_init.inc.c | 12 2 files changed, 7

Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 12:50, Peter Maydell wrote: > This patchset fixes a problem with our build infrastructure > that meant that MST's recent 'pci, pc, virtio' pullreq failed > tests. > > Currently our configure script has a wildcard loop that creates > symlinks for every data file in

Re: [Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 13:35, Aleksandar Markovic wrote: > Perhaps checkpatch.pl should make sure the commit messages do not contain > "address@hidden" and "Reviewed-off-by"? > > $ git log | grep address@hidden > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Ronald Hecht >

[Qemu-devel] [PULL v2 0/6] target-arm queue

2018-10-30 Thread Peter Maydell
) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181030 for you to fetch changes up to 1f5a65a188210509bfb0c025fc91635c8436b98a: tests/boot-serial-test: Add microbit board testcase (2018-10-30 13:20:18 +

Re: [Qemu-devel] [PATCH v4 4/4] hw/arm: versal: Add a virtual Xilinx Versal board

2018-10-30 Thread Peter Maydell
On 22 October 2018 at 18:35, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add a virtual Xilinx Versal board. > > This board is based on the Xilinx Versal SoC. The exact > details of what peripherals are attached to this board > will remain in control of QEMU. QEMU will generate an >

Re: [Qemu-devel] [PATCH v2 0/7] qga: add support for re-opening channel on error

2018-10-30 Thread Michael Roth
Quoting Bishara AbuHattoum (2018-10-07 06:02:16) > Changes from v1: > [1/7] qga: group agent init/cleanup init separate routines > Fixed typo in the commit message and dropped the unnecessary message > ID > [2/7] qga: hang GAConfig/socket_activation off of GAState global >

[Qemu-devel] [PULL 20/24] qga: move w32 service handling out of run_agent()

2018-10-30 Thread Michael Roth
Eventually we want a w32 service to be able to restart the qga main loop from within service_main(). To allow for this we move service handling out of run_agent() such that service_main() calls run_agent() instead of the reverse. Signed-off-by: Michael Roth Signed-off-by: Bishara AbuHattoum

[Qemu-devel] [PULL 22/24] qga-win: install service with --retry-path set by default

2018-10-30 Thread Michael Roth
It's nicer from a management perspective that the agent can survive hotplug/unplug of the channel device, or be started prior to the installation of the channel device's driver without and still be able to resume normal function afterward. On linux there are alternatives like systemd to support

[Qemu-devel] [PULL 08/24] qga-win: fsinfo: pci-info: allow partial info

2018-10-30 Thread Michael Roth
From: Sameeh Jubran The call to SetupDiGetDeviceRegistryProperty might fail because the value doesn't exist in the registry, in this case we shouldn't exit from the loop but instead continue to look for other available values in the registry and set this value as unavailable (-1).

[Qemu-devel] [PULL 14/24] qga-win: handle multi-disk volumes

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Probe the volume for disk extents and return list of all disks. Originally only first disk of composite volume was returned. Note that the patch changes get_pci_info() from one state of brokenness into a different state of brokenness. In other words it still does not do

[Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- hw/arm/xilinx_zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index f1496d2927..57497b0c4d 100644 ---

[Qemu-devel] [PATCH] This patch fixes processing of rfi instructions in icount mode.

2018-10-30 Thread Pavel Dovgalyuk
From: Maria Klimushenkova In this mode writing to interrupt/peripheral state is controlled by can_do_io flag. This flag must be set explicitly before helper function invocation. Signed-off-by: Maria Klimushenkova Signed-off-by: Pavel Dovgalyuk --- target/ppc/translate.c | 12

Re: [Qemu-devel] [PATCH v2 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related masks. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Stefan Markovic >

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related functions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Stefan

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:28, Philippe Mathieu-Daudé wrote: > On 30/10/18 10:36, Peter Maydell wrote: >> >> On 29 October 2018 at 23:20, Philippe Mathieu-Daudé >> wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> MAINTAINERS| 1 + >>> hw/arm/xilinx_zynq.c | 18

[Qemu-devel] [PATCH 1/3] configure: Rename FILES variable to LINKS

2018-10-30 Thread Peter Maydell
The FILES variable is used to accumulate a list of things to symlink from the source tree into the build tree. These don't have to be individual files; symlinking an entire directory of data files is also fine. Rename it to something less confusing before we add a few directories to it.

Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:47, Philippe Mathieu-Daudé wrote: On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Misc changes in comments and strings for R5900. Signed-off-by: Aleksandar Markovic ---   target/mips/translate.c  | 14 +++---  

Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:47, Philippe Mathieu-Daudé wrote: On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Misc changes in comments and strings for R5900. Signed-off-by: Aleksandar Markovic ---   target/mips/translate.c  | 14 +++---  

Re: [Qemu-devel] [PULL v2 0/6] target-arm queue

2018-10-30 Thread Peter Maydell
vic/tags/mips-queue-october-2018-part-4' into staging > (2018-10-30 10:45:49 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20181030 > > for you to fetch changes up to 1f5a65a188210509bfb

Re: [Qemu-devel] [PATCH v2 2/2] tests: fw_cfg: add reboot_timeout test case

2018-10-30 Thread Li Qiang
Hi Paolo, Paolo Bonzini 于2018年10月30日周二 下午6:52写道: > On 30/10/2018 05:28, Li Qiang wrote: > > Signed-off-by: Li Qiang > > --- > > tests/fw_cfg-test.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > > index

[Qemu-devel] [PULL 12/24] qga-win: report disk serial number

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Signed-off-by: Tomáš Golembiovský *coding style fix-ups (declarations at beginning of block) *improve readability for user-visible errors *cover additional edge-cases with debug statements Signed-off-by: Michael Roth --- qga/commands-win32.c | 30

[Qemu-devel] [PULL 15/24] qga-win: return disk device in guest-get-fsinfo

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Report device UNC of the disk. It is reported as "\\.\PhysicalDriveX". Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth --- qga/commands-win32.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PULL 00/24] qemu-ga patch queue for soft-freeze

2018-10-30 Thread Michael Roth
The following changes since commit 62b658db1df7c6fa574caae038144f24bf6ca495: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2018-10-29 17:03:27 +) are available in the Git repository at: git://github.com/mdroth/qemu.git

[Qemu-devel] [PULL 09/24] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be

[Qemu-devel] [PULL 07/24] qga-win: prevent crash when executing fsinfo command

2018-10-30 Thread Michael Roth
From: Sameeh Jubran The fsinfo command is currently implemented for Windows only and it's disk parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga code. When enabled and executed the qemu-ga crashed with the following message:

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-30 Thread Samuel Ortiz
Hi Philippe, On Mon, Oct 29, 2018 at 08:29:38PM +0100, Philippe Mathieu-Daudé wrote: > On 29/10/18 20:23, Philippe Mathieu-Daudé wrote: > > On 29/10/18 18:01, Samuel Ortiz wrote: > > > From: Yang Zhong > > > > > > The AML build routines for the PCI host bridge and the corresponding > > > DSDT

[Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals()

2018-10-30 Thread Marc-André Lureau
Handle calls of object_property_set_globals() with any object type, but only apply globals to TYPE_DEVICE & TYPE_USER_CREATABLE. Signed-off-by: Marc-André Lureau --- qom/globals.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/qom/globals.c

[Qemu-devel] [PULL 05/24] qga: linux: report disk serial number

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Add reporting of disk serial number on Linux guests. The feature depends on libudev. Example: { "name": "dm-2", "mountpoint": "/", ... "disk": [ { "serial": "SAMSUNG_MZ7LN512HCHP-000L1_S1ZKNXAG822493", ...

[Qemu-devel] [PATCH v3] strongarm: mask off high[31:28] bits from dir and state registers

2018-10-30 Thread P J P
From: Prasad J Pandit The high[31:28] bits of 'direction' and 'state' registers of SA-1100/SA-1110 device are reserved. Setting them may lead to OOB 's->handler[]' array access issue. Mask off [31:28] bits to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit ---

[Qemu-devel] [PATCH v3 3/3] docs: Document vCPU hotplug procedure

2018-10-30 Thread Kashyap Chamarthy
Signed-off-by: Kashyap Chamarthy --- docs/cpu-hotplug.rst | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 docs/cpu-hotplug.rst diff --git a/docs/cpu-hotplug.rst b/docs/cpu-hotplug.rst new file mode 100644 index 00..1c268e00b4 ---

[Qemu-devel] [PATCH 2/3] configure: Symlink entire test directories rather than individual files

2018-10-30 Thread Peter Maydell
Instead of symlinking every individual file inside the data directories used by some tests, just symlink the entire directory. This avoids a problem where if a new data file is added to the source tree, nothing results in configure being rerun to create the symlink, and so test runs in the build

[Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files

2018-10-30 Thread Peter Maydell
This patchset fixes a problem with our build infrastructure that meant that MST's recent 'pci, pc, virtio' pullreq failed tests. Currently our configure script has a wildcard loop that creates symlinks for every data file in tests/acpi-test-data from the source tree to the build tree. However, if

Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 13:21, Alex Bennée wrote: > > Paolo Bonzini writes: > >> This is a race that can happen when migrating TCG guests under load. >> It was introduced by the change to run vCPUs outside the big QEMU >> lock. > > Did this ever get re-spun? No, the issue is that *without MTTCG* all

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 15:07, Peter Maydell wrote: On 30 October 2018 at 11:40, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- hw/arm/xilinx_zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] MAINTAINERS: PPC: Remove myself

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 09:35, Alexander Graf wrote: > I haven't really been maintaining any PowerPC code for quite a while now, > so let's reflect reality: David does all the work and embedded PPC is in > "Odd Fixes" state rather than supported now. It was a pleasure working with you, but of course life

[Qemu-devel] [PULL 24/24] qga-win: changing --retry-path option behavior

2018-10-30 Thread Michael Roth
From: Bishara AbuHattoum Currently whenever the qemu-ga's service doesn't find the virtio-serial the run_agent() loops in a QGA_RETRY_INTERVAL (default 5 seconds) intervals and try to restart the qemu-ga which causes a synchronous loop. Changed to wait and listen for the serial events by

[Qemu-devel] [PULL 13/24] qga-win: refactor disk info

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Refactor building of disk info into a function that builds the list and a function that returns infor for single disk. This will be used in future commit that will handle multi-disk volumes. Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth ---

[Qemu-devel] [PULL 11/24] qga-win: refactor disk properties (bus)

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Refactor code that queries bus type to be more generic. The function get_disk_bus_type() has been renamed to build_guest_disk_info(). Following commit(s) will extend this function. Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth --- qga/commands-win32.c

[Qemu-devel] [PULL 16/24] qga-win: demystify namespace stripping

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský It was not obvious what exactly the cryptic string copying does to the GUID. This change makes the intent clearer. Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth --- qga/commands-win32.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 19/24] qga: hang GAConfig/socket_activation off of GAState global

2018-10-30 Thread Michael Roth
For w32 services we rely on the global GAState to access resources associated with the agent within service_main(). Currently this is sufficient for starting the agent since we open the channel once prior to calling service_main(), and simply start the GMainLoop to start the agent from within

[Qemu-devel] [PATCH v2 04/10] qom/globals: move qdev globals to qom

2018-10-30 Thread Marc-André Lureau
Move the global properties handling to QOM. For now, this is just a simple moving & renaming and the globals are only applied to TYPE_DEVICE. The following patches will generalize the global handling to other object types. Signed-off-by: Marc-André Lureau --- include/hw/qdev-core.h | 20

[Qemu-devel] [PATCH v2 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Enable MIPS 032 user mode for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 4 1 file changed, 4 insertions(+) diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.inc.c index cab2003..d84c58e 100644 ---

Re: [Qemu-devel] [PATCH 5/9] qom/globals: generalize object_property_set_globals()

2018-10-30 Thread Marc-André Lureau
Hi On Mon, Oct 29, 2018 at 5:11 PM Igor Mammedov wrote: > > On Wed, 12 Sep 2018 16:55:27 +0400 > Marc-André Lureau wrote: > > > Handle calls of object_property_set_globals() with any object type, > > but only apply globals to TYPE_DEVICE & TYPE_USER_CREATABLE. > > > > Signed-off-by: Marc-André

Re: [Qemu-devel] [RFC v4 04/71] cpu: make qemu_work_cond per-cpu

2018-10-30 Thread Alex Bennée
Emilio G. Cota writes: > This eliminates the need to use the BQL to queue CPU work. > > While at it, give the per-cpu field a generic name ("cond") since > it will soon be used for more than just queueing CPU work. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- >

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 12:10, wj193102 wrote: > That is my fault. I don't run the *.sh file. I copy the file "/bin/ls" from > the Linux on x86 CPUs to the Linux on non X86 CPUs. I put the file in the > new created directory, such as "/home/admin/user/test/". > Then I run the executable file,using

Re: [Qemu-devel] [PATCH v3 0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug

2018-10-30 Thread Kashyap Chamarthy
[Cc: libvir-list] On Tue, Oct 30, 2018 at 01:35:23PM +0100, Kashyap Chamarthy wrote: > The first patch deprecates the QMP `cpu-add`, the second its HMP > equivalent, and the third documents vCPU hotplug procedure using QMP > `device_add` et al. > > v2:

Re: [Qemu-devel] [PATCH] MAINTAINERS: Remove bouncing email in ARM ACPI

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 19:59, Philippe Mathieu-Daudé wrote: > Shannon Zhao's email at Huawei is bouncing: remove it. > > X-Failed-Recipients: zhaoshengl...@huawei.com > ** Address not found ** > Your message wasn't delivered to zhaoshengl...@huawei.com because the > address couldn't

Re: [Qemu-devel] [PATCH v3] strongarm: mask off high[31:28] bits from dir and state registers

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:46, P J P wrote: > From: Prasad J Pandit > > The high[31:28] bits of 'direction' and 'state' registers of > SA-1100/SA-1110 device are reserved. Setting them may lead to > OOB 's->handler[]' array access issue. Mask off [31:28] bits to > avoid it. > > Reported-by:

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Gerd Hoffmann
On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 30/10/18 12:13, Gerd Hoffmann wrote: > > Indicates support state for somerhing (device, backend, subsystem, ...) > > "something" Oops, I'll fix. > > +## > > +# @SupportState: > > +# > > +# Indicate

Re: [Qemu-devel] [PATCH RFC 4/4] net/slirp: add ipv6-hostfwd option for user netdev type

2018-10-30 Thread Maxim Samoylov
On 26.10.2018 09:14, Thomas Huth wrote: On 2018-10-26 01:03, Maxim Samoylov wrote: This allows forwarding TCP6 and UDP6 connections down to netdev=user connected guests. Signed-off-by: Maxim Samoylov --- hmp-commands.hx | 31 include/net/slirp.h | 2 + net/slirp.c

Re: [Qemu-devel] [PATCH v3 19/19] hw: i386: Implement the ACPI builder interface for PC

2018-10-30 Thread Samuel Ortiz
Hi Paolo, On Mon, Oct 29, 2018 at 06:28:39PM +0100, Paolo Bonzini wrote: > On 29/10/2018 18:01, Samuel Ortiz wrote: > > @@ -1556,6 +1557,7 @@ void acpi_build(AcpiBuildTables *tables, > > GArray *tables_blob = tables->table_data; > > AcpiSlicOem slic_oem = { .id = NULL, .table_id = NULL

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 15:00, Gerd Hoffmann wrote: On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote: Hi Gerd, On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend, subsystem, ...) "something" Oops, I'll fix. +## +# @SupportState: +#

[Qemu-devel] [PULL 04/24] configure: add test for libudev

2018-10-30 Thread Michael Roth
From: Tomáš Golembiovský Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau *make libudev optional to avoid breaking existing build/test environments Signed-off-by: Michael Roth --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure

[Qemu-devel] [PULL 21/24] qga: add --retry-path option for re-initializing channel on failure

2018-10-30 Thread Michael Roth
This adds an option to instruct the agent to periodically attempt re-opening the communication channel after a channel error has occurred. The main use-case for this is providing an OS-independent way of allowing the agent to survive situations like hotplug/unplug of the communication channel, or

[Qemu-devel] [PULL 17/24] qga: fix an off-by-one issue

2018-10-30 Thread Michael Roth
From: Li Qiang Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Roth --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index a1b7512d46..ef1d7d48d2 100644 ---

[Qemu-devel] [PULL 18/24] qga: group agent init/cleanup init separate routines

2018-10-30 Thread Michael Roth
This patch better separates the init/cleanup routines out into separate functions to make the start-up procedure a bit easier to follow. This will be useful when we eventually break out the actual start/stop of the agent's main loop into separates routines that can be called multiple times after

[Qemu-devel] [PULL 23/24] qga-win: report specific error when failing to open channel

2018-10-30 Thread Michael Roth
Useful in general, but especially now that errors might occur more frequently with --retry-path set. Signed-off-by: Michael Roth Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/channel-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote: > Indicates support state for somerhing (device, backend, subsystem, ...) > in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. > Personally, I would prefer to start with a very simple data model (e.g. a

[Qemu-devel] [PATCH v2 0/5] target/mips: Renaming and limiting modes for R5900

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename some code elements related to R5900, and limit supported modes to O32. v1->v2: - added limiting of supported modes - added more cosmetic changes Aleksandar Markovic (5): target/mips: Rename MMI-related masks target/mips: Rename MMI-related opcodes

[Qemu-devel] [PATCH v2 2/2] arm: exynos4: Add dma support for smdkc210

2018-10-30 Thread Philippe Mathieu-Daudé
From: Guenter Roeck QEMU already supports pl330. Instantiate it for smdkc210. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis [PMD: Do not set default qdev properties] Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4_boards.c | 24

[Qemu-devel] [PATCH v2 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related masks. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 51a5488..e38d50d 100644 ---

[Qemu-devel] [PATCH v2 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related functions. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:42, Peter Maydell wrote: On 30 October 2018 at 11:28, Philippe Mathieu-Daudé wrote: On 30/10/18 10:36, Peter Maydell wrote: On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 +

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Rename MMI-related functions. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 14:12, Mark Cave-Ayland a écrit : > On 30/10/2018 12:49, Laurent Vivier wrote: > >> Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : >>> On 30/10/2018 08:15, Richard Henderson wrote: >>> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: > You can install your own disk using

Re: [Qemu-devel] [PATCH v3 2/3] linux-user: Add support for semtimedop() syscall

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 13:55, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Add support for semtimedop() emulation. It is based on invocation > of safe_semtimedop(). > > Conversion is left out of safe_semtimedop(), since other safe_xxx() > usually don't contain similar conversions. > >

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-10-30 Thread Igor Mammedov
On Tue, 30 Oct 2018 13:26:40 +0400 Marc-André Lureau wrote: > Hi > > On Tue, Oct 30, 2018 at 5:37 AM Eduardo Habkost wrote: > > > > On Mon, Oct 29, 2018 at 10:56:57AM +0100, Igor Mammedov wrote: > > > On Fri, 26 Oct 2018 12:13:21 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon,

Re: [Qemu-devel] [PATCH] MAINTAINERS: s390: Remove myself

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 10:37, Alexander Graf wrote: I haven't realistically maintained s390 related parts for quite a while now, so let's remove my name from the MATINAINERS file to reflect reality. To the s390 maintainer taking this:"MAINTAINERS" Signed-off-by: Alexander Graf --- MAINTAINERS |

Re: [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState

2018-10-30 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 12:13:44PM +0100, Gerd Hoffmann wrote: > Trying to fill the need to be more finegrained on support status ... > > Any hints/patches how to hook that into introspection so we get > machine type / device support status to libvirt are welcome. We have qom-list-types, but it

[Qemu-devel] [PULL 02/24] qga-win: add support for qmp_guest_fsfreeze_freeze_list

2018-10-30 Thread Michael Roth
From: Chen Hanxiao This patch add support for freeze specified fs. The valid mountpoints list member are [1]: The path of a mounted folder, for example, Y:\MountX\ A drive letter, for example, D:\ A volume GUID path of the form \\?\Volume{GUID}\, where GUID identifies the volume

Re: [Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Aleksandar Markovic
> From: Paolo Bonzini > > Sure, both are good ideas. Can you write a patch for it? I would rather not, I prefer to see it as a black box. Aleksandar

[Qemu-devel] [PATCH v2 02/10] accel: register global_props like machine globals

2018-10-30 Thread Marc-André Lureau
global_props is only used for Xen xen_compat_props. It's a static array of GlobalProperty, like machine globals in SET_MACHINE_COMPAT(). Let's register the globals the same way, without extra copy allocation. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov ---

[Qemu-devel] [PATCH v2 07/10] qom/object: add set_globals flags

2018-10-30 Thread Marc-André Lureau
Guard against calling object_property_set_globals() for all objects, check that the class flag set_globals is set before. No need to guard in object_property_set_globals() anymore. Only QDev & user-creatable objects have set_globals set at this point. Suggested-by: Igor Mammedov Signed-off-by:

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Alex Bennée
Paolo Bonzini writes: > On 29/10/2018 22:39, Emilio G. Cota wrote: >> I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. >> Given that now it does not depend on the BQL, it could actually >> work in user-mode if called. If we really wanted to make sure >> that no user-mode

Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG

2018-10-30 Thread Alex Bennée
Paolo Bonzini writes: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU > lock. Did this ever get re-spun? -- Alex Bennée

  1   2   3   4   5   >