Re: [Qemu-devel] [PATCH] linux-user: Remove dead error-checking code

2018-11-12 Thread Peter Maydell
On 12 November 2018 at 14:45, Laurent Vivier wrote: > On 12/11/2018 15:38, Peter Maydell wrote: >> On 19 October 2018 at 17:26, Laurent Vivier wrote: >>> Le 19/10/2018 à 18:17, Peter Maydell a écrit : Remove some dead code spotted by Coverity (CID 1009855, 1390854, 1390847). The

[Qemu-devel] [PULL 4/4] ui/gtk: fix cursor in egl mode

2018-11-12 Thread Gerd Hoffmann
In egl mode the scale_x and scale_y variables are not set, so the scaling logic in the mouse motion event handler does not work. Fix that. Also scale the cursor position in gd_egl_cursor_position(). Reported-by: Chen Zhang Signed-off-by: Gerd Hoffmann Tested-by: Chen Zhang Message-id:

Re: [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()

2018-11-12 Thread Max Reitz
On 12.11.18 11:26, Alberto Garcia wrote: > On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote: >> On 07.11.18 13:59, Alberto Garcia wrote: >>> This function takes three options (cache.direct, cache.no-flush and >>> read-only) from a QemuOpts object and updates the flags accordingly. >> >> and

Re: [Qemu-devel] [PATCH v5 1/9] qapi: group BlockDeviceStats fields

2018-11-12 Thread Alberto Garcia
On Wed 31 Oct 2018 12:34:40 PM CET, Anton Nefedov wrote: > Make the stat fields definition slightly more readable. > Also reorder total_time_ns stats read-write-flush as done elsewhere. > Cosmetic change only. > > Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Philippe Mathieu-Daudé
On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > Python internal representation is signed, so unsigned values > > bigger than 31-bit are interpreted as signed (and printed with > > a '-' signed). > > Mask out to

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Richard Henderson
On 11/12/18 7:52 PM, Philippe Mathieu-Daudé wrote: > So the fix is rather: > > -- >8 -- > diff --git a/scripts/decodetree.py b/scripts/decodetree.py > @@ -916,7 +916,7 @@ class Tree: > > def build_tree(pats, outerbits, outermask): > # Find the intersection of all remaining fixedmask. > -

[Qemu-devel] [PATCH for-3.2 5/7] tests/acpi-utils: Drop dependence on global_qtest

2018-11-12 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Adjust the helper code to use explicit state instead, and update all callers. bios-tables-test no longer depends on

[Qemu-devel] [PATCH v1 for-3.2 0/7] Get rid of global_qtest in some of the qtests

2018-11-12 Thread Thomas Huth
We should avoid global variables like global_qtest in the qtests - they cause trouble in the tests where we operate with multiple QEMU instances, e.g. with migration. Eric Blake already did quite a lot of work towards this goal in the past, but some of his patches never reached the master branch.

[Qemu-devel] [PATCH for-3.2 3/7] ahci-test: Drop dependence on global_qtest

2018-11-12 Thread Thomas Huth
From: Eric Blake Managing parallel connections to two different monitors via the implicit global_qtest makes it hard to copy-and-paste code to tests that are not aware of the implicit state; the management of global_qtest is even harder to follow because it was masked behind set_context().

[Qemu-devel] [PATCH for-3.2 2/7] tests/libqos/pci: Make PCI access functions independent of global_qtest

2018-11-12 Thread Thomas Huth
QPCIBus already tracks QTestState, so use that state instead of an implicit reliance on global_qtest. Based on an earlier patch ("libqos: Use explicit QTestState for pci operations") from Eric Blake. Signed-off-by: Thomas Huth --- tests/libqos/pci-pc.c| 47

[Qemu-devel] [PATCH for-3.2 1/7] tests/pvpanic: Make the pvpanic test independent of global_qtest

2018-11-12 Thread Thomas Huth
We want to get rid of global_qtest in the long run, thus do not use the wrappers like inb() and outb() here anymore. Signed-off-by: Thomas Huth --- tests/pvpanic-test.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/pvpanic-test.c b/tests/pvpanic-test.c

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Richard Henderson
On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > Python internal representation is signed, so unsigned values > bigger than 31-bit are interpreted as signed (and printed with > a '-' signed). > Mask out to force unsigned values. > > Signed-off-by: Philippe Mathieu-Daudé > --- > TODO:

Re: [Qemu-devel] [PATCH] hw/bt: drop bluetooth keyboard emulation.

2018-11-12 Thread Markus Armbruster
Peter Maydell writes: > On 9 November 2018 at 14:14, Gerd Hoffmann wrote: >> Broken (segfaultson first keypress) and appearently unused. >> >> Signed-off-by: Gerd Hoffmann Please show the reproducer in the commit message. Stack backtrace wouldn't hurt. >> --- >> include/hw/bt.h | 3 -

Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree

2018-11-12 Thread Philippe Mathieu-Daudé
On Mon, Nov 12, 2018 at 10:15 AM Richard Henderson wrote: > > On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote: > > +dclz011100 . . . . 100100 @rs_rt_rd > > ?ctx->insn_flags_MIPS64 > > +dclo011100 . . . . 100101 @rs_rt_rd > >

Re: [Qemu-devel] [PATCH v1 3/3] intel-iommu: search iotlb for levels supported by the address width.

2018-11-12 Thread Yu Zhang
On Mon, Nov 12, 2018 at 04:51:22PM +0800, Peter Xu wrote: > On Fri, Nov 09, 2018 at 07:49:47PM +0800, Yu Zhang wrote: > > This patch updates vtd_lookup_iotlb() to search cached mappings only > > for all page levels supported by address width of current vIOMMU. Also, > > to cover 57-bit width, the

Re: [Qemu-devel] [PATCH] 9p: write lock path in v9fs_co_open2()

2018-11-12 Thread Greg Kurz
On Mon, 12 Nov 2018 16:28:28 +0800 zhibin hu wrote: > hi, > > i use this patch with qemu 3.0.0 and it seems not fix completely. > > [root@localhost ~]# ./qemu-system-x86_64 -snapshot -m 1024 -smp 2 > -enable-kvm -net nic,model=e1000 -net > tap,helper=/usr/libexec/qemu-bridge-helper -hda >

[Qemu-devel] [PATCH] bt: Mark the bluetooth subsystem as deprecated

2018-11-12 Thread Thomas Huth
It has been unmaintained since years, and there were only trivial or tree-wide changes to the related files since many years, so the code is likely very bitrotten and broken. For example the following segfaults as soon as as you press a key: qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci

Re: [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub

2018-11-12 Thread Richard Henderson
On 11/12/18 11:04 AM, Aleksandar Markovic wrote: > Hello, Richard. > > I am a little taken aback by your tone. I hope we can communicate in much > friendlier maner, as we used to do. I too was put off by your tone. Beginning with "there is no plan" and continuing with "there is no point" is a

Re: [Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2018-11-12 Thread Dongli Zhang
Hi Marc, When I play with the v3 patch set, the qemu hangs again and I need to kill it with "kill -9". I got below from guest: [ 104.828127] nvme nvme0: I/O 52 QID 1 timeout, aborting [ 104.828470] nvme nvme0: Abort status: 0x4001 nvme abort is not supported by qemu and therefore 0x4001

[Qemu-devel] [Bug 1802150] Re: Guest undefined when destroyed on host after migration

2018-11-12 Thread Dr. David Alan Gilbert
Also, can you please include the libvirt logs for the VM, they're typically in /var/log/libvirt/VMNAME.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802150 Title: Guest undefined when

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Philippe Mathieu-Daudé
> On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > > Python internal representation is signed, so unsigned values > > > bigger than 31-bit are interpreted as signed (and printed with > > > a '-' signed). > > >

[Qemu-devel] [PATCH for-3.2 4/7] ivshmem-test: Drop dependence on global_qtest

2018-11-12 Thread Thomas Huth
From: Eric Blake Managing parallel connections to two different monitors via the implicit global_qtest makes it hard to copy-and-paste code to tests that are not aware of the implicit state. Since we have already fixed qpci to avoid global_qtest, we can now simplify by not using global_qtest

[Qemu-devel] [PATCH for-3.2 6/7] tests/vmgenid: Make test independent of global_qtest

2018-11-12 Thread Thomas Huth
The biggest part has already been done in the previous patch, we now only have to replace some few qmp() and readb() calls with the corresponding qtest_*() functions to get there. Signed-off-by: Thomas Huth --- tests/vmgenid-test.c | 31 +-- 1 file changed, 17

[Qemu-devel] [PATCH for-3.2 7/7] tests/boot-serial: Get rid of global_qtest variable

2018-11-12 Thread Thomas Huth
The test does not use any of the functions that require global_qtest, so we can simply get rid of this global variable here. Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/boot-serial-test.c

Re: [Qemu-devel] [PATCH for-3.2 2/7] tests/libqos/pci: Make PCI access functions independent of global_qtest

2018-11-12 Thread Paolo Bonzini
On 12/11/2018 20:08, Thomas Huth wrote: > QPCIBus already tracks QTestState, so use that state instead of an > implicit reliance on global_qtest. > > Based on an earlier patch ("libqos: Use explicit QTestState for pci > operations") from Eric Blake. > > Signed-off-by: Thomas Huth This will be

Re: [Qemu-devel] [PATCH 3/4] Travis CI: make specified Python versions usable on jobs

2018-11-12 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 03:52:49PM +, Alex Bennée wrote: > > Cleber Rosa writes: > > > For the two Python jobs, which seem to have the goal of making sure > > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > > the specified version is only applicable if a Python

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: qmp interface to set/query io throttle for fsdev devices

2018-11-12 Thread Eric Blake
On 11/11/18 7:12 PM, xiezhide wrote: This patch provide qmp interface to set/query io throttle for fsdev devices. This patch is titled 1/2, but not threaded to a 0/2 or 2/2 patch. Remember that proper threading aids reviewers. This patch include following work: 1. port Pradeep Jagadeesh's

Re: [Qemu-devel] [RFC/PoC PATCH 1/3] i386: set initrd_max to 4G - 1 to allow up to 4G initrd

2018-11-12 Thread H. Peter Anvin
On 11/11/18 10:19 PM, Ingo Molnar wrote: > >> In part as a result of this exchange I have spent some time thinking >> about the boot protocol and its dependencies, and there is, in fact, a >> much more serious problem that needs to be addressed: it is not >> currently possible in a

Re: [Qemu-devel] [PATCH v6 01/11] util: add helper APIs for dealing with inotify in portable manner

2018-11-12 Thread Daniel P . Berrangé
On Wed, Nov 07, 2018 at 10:08:05PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Oct 19, 2018 at 5:41 PM Daniel P. Berrangé > wrote: > > > > The inotify userspace API for reading events is quite horrible, so it is > > useful to wrap it in a more friendly API to avoid duplicating code > >

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-12 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Sun, Nov 04, 2018 at 11:19:57PM +0100, Paolo Bonzini wrote: > > On 02/11/2018 17:54, Daniel P. Berrangé wrote: > > > We have usually followed a rule that new machine types must not > > > affect runability of a VM on a host. IOW new machine

[Qemu-devel] [PULL 02/14] blockdev: handle error on block latency histogram set error

2018-11-12 Thread Kevin Wolf
From: zhenwei pi Function block_latency_histogram_set may return error, but qapi ignore this. This can be reproduced easily by qmp command: virsh qemu-monitor-command INSTANCE '{"execute":"x-block-latency-histogram-set", "arguments":{"device":"drive-virtio-disk1","boundaries":[10,200,40]}}' In

[Qemu-devel] [PULL 16/16] target/arm/cpu: Give Cortex-A15 and -A7 the EL2 feature

2018-11-12 Thread Peter Maydell
The Cortex-A15 and Cortex-A7 both have EL2; now we've implemented it properly we can enable the feature bit. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias Message-id: 20181109173553.22341-3-peter.mayd...@linaro.org --- target/arm/cpu.c | 2 ++

[Qemu-devel] [PULL 12/16] Revert "target/arm: Implement HCR.VI and VF"

2018-11-12 Thread Peter Maydell
This reverts commit 8a0fc3a29fc2315325400c738f807d0d4ae0ab7f. The implementation of HCR.VI and VF in that commit is not correct -- they do not track the overall "is there a pending VIRQ or VFIQ" status, but whether there is a pending interrupt due to "this mechanism", ie the hypervisor having set

[Qemu-devel] [PULL 09/16] tests/guest-debug: fix scoping of failcount

2018-11-12 Thread Peter Maydell
From: Alex Bennée You should declare you are using a global version of a variable before you attempt to modify it in a function. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20181109152119.9242-5-alex.ben...@linaro.org Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 8 November 2018 at 17:58, Corey Minyard wrote: > > On 11/8/18 8:08 AM, Peter Maydell wrote: > >> This doesn't do anything for migration of the actual data contents. > >> The current users of this device (hw/arm/aspeed.c and the > >>

Re: [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups

2018-11-12 Thread Cornelia Huck
On Mon, 5 Nov 2018 12:03:09 +0100 David Hildenbrand wrote: > The hotplug code needs more love, but let's do some obvious cleanups > first. In the future, we want to propery make use of unplug_request() + > unplug(), instead of routing everything (especially two separate but > linked) devices

Re: [Qemu-devel] [PATCH v1 1/4] s390x/zpci: drop msix.available

2018-11-12 Thread Cornelia Huck
On Mon, 5 Nov 2018 12:03:10 +0100 David Hildenbrand wrote: > I fail to see why this is useful as we require MSIX always and > completely fail adding a device. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-pci-bus.c | 2 -- > hw/s390x/s390-pci-bus.h | 1 - > 2 files changed, 3

Re: [Qemu-devel] [PATCH v1 0/4] s390x/zpci: some hotplug handler cleanups

2018-11-12 Thread David Hildenbrand
On 12.11.18 18:14, Cornelia Huck wrote: > On Mon, 5 Nov 2018 12:03:09 +0100 > David Hildenbrand wrote: > >> The hotplug code needs more love, but let's do some obvious cleanups >> first. In the future, we want to propery make use of unplug_request() + >> unplug(), instead of routing everything

Re: [Qemu-devel] [PATCH 4/4] check-help: visual and content improvements

2018-11-12 Thread Wainer dos Santos Moschetta
On 11/09/2018 01:07 PM, Cleber Rosa wrote: The "check" target is not a target that will run all other tests listed, so in order to be accurate it's necessary to list those that will run. The same is true for "check-clean". Then, to give a better visual impression of the differences in the

Re: [Qemu-devel] [PATCH 3/4] Travis CI: make specified Python versions usable on jobs

2018-11-12 Thread Cleber Rosa
On 11/12/18 11:23 AM, Eduardo Habkost wrote: > On Fri, Nov 09, 2018 at 10:07:09AM -0500, Cleber Rosa wrote: >> For the two Python jobs, which seem to have the goal of making sure >> QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, >> the specified version is only

Re: [Qemu-devel] [PULL 0/4] Fixes 31 20181112 patches

2018-11-12 Thread Peter Maydell
the git repository at: > > git://git.kraxel.org/qemu tags/fixes-31-20181112-pull-request > > for you to fetch changes up to f1aba960cc40ab65fa88c8678883bd2201708c55: > > ui/gtk: fix cursor in egl mode (2018-11-12 14:15:54 +0100) > > ---

[Qemu-devel] [PULL 10/14] job: Fix off-by-one assert checks for JobSTT and JobVerbTable

2018-11-12 Thread Kevin Wolf
From: Liam Merwick In the assert checking the array dereference of JobVerbTable[verb] in job_apply_verb() the check of the index, verb, allows an overrun because an index equal to the array size is permitted. Similarly, in the assert check of JobSTT[s0][s1] with index s1 in

[Qemu-devel] [PULL 03/14] blockdev: Consistently use snapshot_node_name in external_snapshot_prepare()

2018-11-12 Thread Kevin Wolf
From: Peter Maydell In the function external_snapshot_prepare() we have a BlockdevSnapshotSync struct, which has the usual combination of has_snapshot_node_name and snapshot_node_name fields for an optional field. We set up a local variable const char *snapshot_node_name =

[Qemu-devel] [PULL 00/14] Block layer patches

2018-11-12 Thread Kevin Wolf
The following changes since commit 5704c36d25ee84e7129722cb0db53df9faefe943: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-31-20181112-pull-request' into staging (2018-11-12 15:55:40 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[Qemu-devel] [PULL 01/14] file-posix: Use error API properly

2018-11-12 Thread Kevin Wolf
From: Fam Zheng Use error_report for situations that affect user operation (i.e. we're actually returning error), and warn_report/warn_report_err when some less critical error happened but the user operation can still carry on. For raw_normalize_devicepath, add Error parameter to propagate to

[Qemu-devel] [PULL 14/14] qcow2: Read outside array bounds in qcow2_pre_write_overlap_check()

2018-11-12 Thread Kevin Wolf
From: Liam Merwick The commit for 0e4e4318eaa5 increments QCOW2_OL_MAX_BITNR but does not add an array entry for QCOW2_OL_BITMAP_DIRECTORY_BITNR to metadata_ol_names[]. As a result, an array dereference of metadata_ol_names[8] in qcow2_pre_write_overlap_check() could result in a read outside of

[Qemu-devel] [PULL 04/16] hw/arm/sysbus-fdt: Only call match_fn callback if the type matches

2018-11-12 Thread Peter Maydell
From: Eric Auger Commit af7d64ede0b9 (hw/arm/sysbus-fdt: Allow device matching with DT compatible value) introduced a match_fn callback which gets called for each registered combo to check whether a sysbus device can be dynamically instantiated. However the callback gets called even if the

[Qemu-devel] [PULL 13/16] target/arm: Track the state of our irq lines from the GIC explicitly

2018-11-12 Thread Peter Maydell
Currently we track the state of the four irq lines from the GIC only via the cs->interrupt_request or KVM irq state. That means that we assume that an interrupt is asserted if and only if the external line is set. This assumption is incorrect for VIRQ and VFIQ, because the HCR_EL2.{VI,VF} bits

[Qemu-devel] [PULL 10/16] arm: use symbolic MDCR_TDE in arm_debug_target_el

2018-11-12 Thread Peter Maydell
From: Alex Bennée We already have this symbol defined so lets use it. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-id: 20181109152119.9242-7-alex.ben...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 07/16] target/arm64: hold BQL when calling do_interrupt()

2018-11-12 Thread Peter Maydell
From: Alex Bennée Fix the assertion failure when running interrupts. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20181109152119.9242-3-alex.ben...@linaro.org Signed-off-by: Peter Maydell --- target/arm/kvm64.c | 2 ++ 1 file changed, 2

[Qemu-devel] [PULL 02/16] target/arm: Remove antique TODO comment

2018-11-12 Thread Peter Maydell
Remove a TODO comment about implementing the vectored interrupt controller. We have had an implementation of that for a decade; it's in hw/intc/pl190.c. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20181106164118.16184-1-peter.mayd...@linaro.org Reviewed-by: Philippe

[Qemu-devel] [Bug 1802684] Re: QEMU gui crashes on macOS Mojave

2018-11-12 Thread inactive
http://lists.nongnu.org/archive/html/qemu-devel/2018-11/msg01941.html thread -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1802684 Title: QEMU gui crashes on macOS Mojave Status in QEMU: New

Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-12 Thread Cleber Rosa
On 11/12/18 11:00 AM, Kevin Wolf wrote: > Am 12.11.2018 um 15:59 hat Cleber Rosa geschrieben: >> >> On 11/12/18 5:49 AM, Kevin Wolf wrote: >>> Am 09.11.2018 um 23:12 hat Cleber Rosa geschrieben: The initial goal of this RFC is to get feedback on tests not specific to the QEMU main

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 9 November 2018 at 17:19, Corey Minyard wrote: > > On 11/9/18 9:02 AM, Peter Maydell wrote: > >> The data provided by the caller is only the initialization > >> data. So I think the device should create its own memory > >> to copy that init

Re: [Qemu-devel] [PATCH 1/3] i2c:pm_smbus: Fix state transfer

2018-11-12 Thread Dr. David Alan Gilbert
* miny...@acm.org (miny...@acm.org) wrote: > From: Corey Minyard > > Transfer the state information for the SMBus registers and > internal data so it will work on a VM transfer. Weren't the comments from August were that we'd prefer to see this in a subsection so we didn't break migration

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Peter Maydell
On 12 November 2018 at 17:38, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> That would require us to support backing it properly with a block >> device, like the pflash flash devices, I think. (This would >> be the long term way to be able to dump the

Re: [Qemu-devel] [PATCH 3/4] Travis CI: make specified Python versions usable on jobs

2018-11-12 Thread Eduardo Habkost
On Fri, Nov 09, 2018 at 10:07:09AM -0500, Cleber Rosa wrote: > For the two Python jobs, which seem to have the goal of making sure > QEMU builds successfully on the 3.0-3.6 spectrum of Python 3 versions, > the specified version is only applicable if a Python virtual > environment is used. To do

Re: [Qemu-devel] [PATCH 00/12] file-posix: Simplify delegation to worker thread

2018-11-12 Thread Kevin Wolf
Am 31.10.2018 um 22:56 hat Kevin Wolf geschrieben: > This series cleans up and simplifies the code that calls worker thread > functions for the various operations in the file-posix driver. This > results in less indirection and better readability as well as reduced > heap allocations because we

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-12 Thread Daniel P . Berrangé
On Mon, Nov 12, 2018 at 04:50:54PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Sun, Nov 04, 2018 at 11:19:57PM +0100, Paolo Bonzini wrote: > > > On 02/11/2018 17:54, Daniel P. Berrangé wrote: > > > > We have usually followed a rule that new

[Qemu-devel] [PULL 11/14] block: Null pointer dereference in blk_root_get_parent_desc()

2018-11-12 Thread Kevin Wolf
From: Liam Merwick The dev_id returned by the call to blk_get_attached_dev_id() in blk_root_get_parent_desc() can be NULL (an internal call to object_get_canonical_path may have returned NULL). Instead of just checking this case before before dereferencing, adjust blk_get_attached_dev_id() to

[Qemu-devel] [PULL 13/14] block: Fix potential Null pointer dereferences in vvfat.c

2018-11-12 Thread Kevin Wolf
From: Liam Merwick The calls to find_mapping_for_cluster() may return NULL but it isn't always checked for before dereferencing the value returned. Additionally, add some asserts to cover cases where NULL can't be returned but which might not be obvious at first glance. Signed-off-by: Liam

[Qemu-devel] [PULL 05/14] nvme: free cmbuf in nvme_exit

2018-11-12 Thread Kevin Wolf
From: Li Qiang This avoid a memory leak in unhotplug nvme device. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Kevin Wolf --- hw/block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 359a06d0ad..09d7c90259

[Qemu-devel] [PULL 06/16] target/arm64: properly handle DBGVR RESS bits

2018-11-12 Thread Peter Maydell
From: Alex Bennée This only fails with some (broken) versions of gdb but we should treat the top bits of DBGBVR as RESS. Properly sign extend QEMU's reference copy of dbgbvr and also update the register descriptions in the comment. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 15/16] target/arm: Hyp mode R14 is shared with User and System

2018-11-12 Thread Peter Maydell
Hyp mode is an exception to the general rule that each AArch32 mode has its own r13, r14 and SPSR -- it has a banked r13 and SPSR but shares its r14 with User and System mode. We were incorrectly implementing it as banked, which meant that on entry to Hyp mode r14 was 0 rather than the USR/SYS

[Qemu-devel] [PULL 03/16] MAINTAINERS: Add an entry for the 'collie' machine

2018-11-12 Thread Peter Maydell
From: Thomas Huth There is no active maintainer, but since Peter is picking up patches via qemu-...@nongnu.org, I think we could at least use "Odd Fixes" as status here. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 11/16] arm: fix aa64_generate_debug_exceptions to work with EL2

2018-11-12 Thread Peter Maydell
From: Alex Bennée The test was incomplete and incorrectly caused debug exceptions to be generated when returning to EL2 after a failed attempt to single-step an EL1 instruction. Fix this while cleaning up the function a little. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 01/16] target/arm: Remove workaround for small SAU regions

2018-11-12 Thread Peter Maydell
Before we supported direct execution from MMIO regions, we implemented workarounds in commit 720424359917887c926a33d2 which let us avoid doing so, even if the SAU or MPU region was less than page-sized. Once we implemented execute-from-MMIO, we removed part of those workarounds in commit

[Qemu-devel] [PULL 05/16] target/arm: Fix typo in tlbi_aa64_vmalle1_write

2018-11-12 Thread Peter Maydell
From: Richard Henderson This would cause an infinite recursion or loop. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-id: 20181110121711.15257-1-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PATCH 2/2] virtio-9p: fix coding style issue

2018-11-12 Thread Greg Kurz
On Mon, 12 Nov 2018 01:12:33 + xiezhide wrote: > fix two coding style issue > These coding style issues seem to come from patch 1... It is weird to introduce coding style nits and to fix them afterwards. Just avoid them in the first place (./scripts/checkpatch.pl is your friend). >

[Qemu-devel] [PATCH v5 02/14] arm: Add header to host common definition for nRF51 SOC peripherals

2018-11-12 Thread Steffen Görtz
Adds a header that provides definitions that are used across nRF51 peripherals Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Maydell --- hw/arm/nrf51_soc.c | 33 ++ include/hw/arm/nrf51.h | 45

[Qemu-devel] [PATCH v5 03/14] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral

2018-11-12 Thread Steffen Görtz
Add a model of the NRF51 random number generator peripheral. This is a simple random generator that continuously generates new random values after startup. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v5 06/14] arm: Instantiate NRF51 special NVM's and NVMC

2018-11-12 Thread Steffen Görtz
Instantiates UICR, FICR, FLASH and NVMC in nRF51 SOC. Signed-off-by: Steffen Görtz --- hw/arm/nrf51_soc.c | 43 +++--- include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/hw/arm/nrf51_soc.c

Re: [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values

2018-11-12 Thread Eduardo Habkost
On Mon, Nov 12, 2018 at 07:52:28PM +0100, Philippe Mathieu-Daudé wrote: > On Mon, Nov 12, 2018 at 6:03 PM Eduardo Habkost wrote: > > On Mon, Nov 12, 2018 at 12:36:16AM +0100, Philippe Mathieu-Daudé wrote: > > > Python internal representation is signed, so unsigned values > > > bigger than 31-bit

[Qemu-devel] [PATCH v5 00/14] arm: nRF51 Devices and Microbit Support

2018-11-12 Thread Steffen Görtz
This series contains additional peripheral devices for the nRF51822 microcontroller. Included devices: - Random Number Generator - Non-volatile Memories - General purpose I/O - Timer - Stub for clock peripheral v5: * Nearly entirely new timer. The old timer had a lot of flaws. Review

[Qemu-devel] [PATCH v5 07/14] tests: Add bbc:microbit / nRF51 test suite

2018-11-12 Thread Steffen Görtz
The microbit-test includes tests for the nRF51 NVMC peripheral and will host future nRF51 peripheral tests and board-level bbc:microbit tests. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- tests/Makefile.include | 2 + tests/microbit-test.c | 133

[Qemu-devel] [PATCH v5 09/14] arm: Instantiate NRF51 general purpose I/O

2018-11-12 Thread Steffen Görtz
Instantiates GPIO peripheral model Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Maydell --- hw/arm/nrf51_soc.c | 16 include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/hw/arm/nrf51_soc.c

[Qemu-devel] [PATCH v5 10/14] tests/microbit-test: Add Tests for nRF51 GPIO

2018-11-12 Thread Steffen Görtz
The test suite for the nRF51 GPIO peripheral for now only tests initial state. Additionally a set of tests testing an implementation detail of the model are included. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- tests/microbit-test.c | 124

[Qemu-devel] [PATCH v5 13/14] tests/microbit-test: Add Tests for nRF51 Timer

2018-11-12 Thread Steffen Görtz
Basic tests for nRF51 Timer Peripheral. Signed-off-by: Steffen Görtz --- tests/microbit-test.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/tests/microbit-test.c b/tests/microbit-test.c index e606221b58..f8731e7c00 100644 ---

[Qemu-devel] [PATCH v5 05/14] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-12 Thread Steffen Görtz
The nRF51 contains three regions of non-volatile memory (NVM): - CODE (R/W): contains code - FICR (R): Factory information like code size, chip id etc. - UICR (R/W): Changeable configuration data. Lock bits, Code protection configuration, Bootloader address, Nordic SoftRadio configuration,

[Qemu-devel] [PATCH v5 01/14] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-11-12 Thread Steffen Görtz
Adds a new qtest command "set_irq_in" which allows to set qemu gpio lines to a given level. Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html which never got merged. Signed-off-by: Steffen Görtz Originally-by: Matthew Ogilvie Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH for-4.0 01/17] tcg/i386: Add constraints for r8 and r9

2018-11-12 Thread Richard Henderson
These are function call arguments for x86_64 we will need soon. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 8 1 file changed, 8 insertions(+) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 436195894b..e4d9be57ff 100644 ---

[Qemu-devel] [PATCH v5 04/14] arm: Instantiate NRF51 random number generator

2018-11-12 Thread Steffen Görtz
Use RNG in SOC. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Maydell --- hw/arm/nrf51_soc.c | 16 include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c index

[Qemu-devel] [PATCH for-4.0 02/17] tcg/i386: Return a base register from tcg_out_tlb_load

2018-11-12 Thread Richard Henderson
We will shortly be asking the hot path not to assume TCG_REG_L1 for the host base address. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 56 --- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c

[Qemu-devel] [PATCH v5 12/14] arm: Instantiate NRF51 Timers

2018-11-12 Thread Steffen Görtz
Instantiates TIMER0 - TIMER2 Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi Reviewed-by: Peter Maydell --- hw/arm/nrf51_soc.c | 27 +++ include/hw/arm/nrf51_soc.h | 4 2 files changed, 31 insertions(+) diff --git a/hw/arm/nrf51_soc.c

[Qemu-devel] [PATCH v5 14/14] arm: Add Clock peripheral stub to NRF51 SOC

2018-11-12 Thread Steffen Görtz
This stubs enables the microbit-micropython firmware to run on the microbit machine. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 27 +++ include/hw/arm/nrf51_soc.h | 1 + 2 files changed, 28 insertions(+) diff --git

[Qemu-devel] [PATCH v5 08/14] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-12 Thread Steffen Görtz
This adds a model of the nRF51 GPIO peripheral. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf The nRF51 series microcontrollers support up to 32 GPIO pins in various configurations. The pins can be used as input pins with pull-ups or pull-down. Furthermore, three

[Qemu-devel] [PATCH for-4.0 03/17] tcg/i386: Change TCG_REG_L[01] to not overlap function arguments

2018-11-12 Thread Richard Henderson
We will shortly be forcing qemu_ld/st arguments into registers that match the function call abi of the host, which means that the temps must be elsewhere. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 28 +++- 1 file changed, 19 insertions(+), 9

[Qemu-devel] [PATCH for-4.0 10/17] tcg/aarch64: Parameterize the temp for tcg_out_goto_long

2018-11-12 Thread Richard Henderson
We cannot use TCG_REG_LR (aka TCG_REG_TMP) for tail calls. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index c0ba9a6d50..ea5fe33fca

[Qemu-devel] [PATCH for-4.0 00/17] tcg: Move softmmu out-of-line

2018-11-12 Thread Richard Henderson
Based on an idea forwarded by Emilio, which suggests a 5-6% speed gain is possible. I have not spent too much time measuring this, as the code size gains are significant. I believe that I posted an x86_64-only patch some time ago, but this now includes i386, aarch64 and arm32. In late testing I

[Qemu-devel] [PATCH v5 11/14] hw/timer/nrf51_timer: Add nRF51 Timer peripheral

2018-11-12 Thread Steffen Görtz
This patch adds the model for the nRF51 timer peripheral. Currently, only the TIMER mode is implemented. Signed-off-by: Steffen Görtz --- hw/timer/Makefile.objs | 1 + hw/timer/nrf51_timer.c | 337 + hw/timer/trace-events | 5 +

[Qemu-devel] [PATCH for-4.0 06/17] tcg: Add TCG_TARGET_NEED_LDST_OOL_LABELS

2018-11-12 Thread Richard Henderson
This variant of tcg-ldst.inc.c allows the entire thunk to be moved out-of-line, with caching across TBs within a region. Signed-off-by: Richard Henderson --- tcg/tcg.h | 4 ++ tcg/tcg-ldst-ool.inc.c | 94 ++ tcg/tcg.c | 20

[Qemu-devel] [PATCH for-4.0 04/17] tcg/i386: Force qemu_ld/st arguments into fixed registers

2018-11-12 Thread Richard Henderson
This is an incremental step toward moving the qemu_ld/st code sequence out of line. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 193 +++--- 1 file changed, 159 insertions(+), 34 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c

[Qemu-devel] [PATCH for-4.0 12/17] tcg/aarch64: Use TCG_TARGET_NEED_LDST_OOL_LABELS

2018-11-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 191 +-- 2 files changed, 93 insertions(+), 100 deletions(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 9aea1d1771..d1bd77c41d

[Qemu-devel] [PATCH for-4.0 08/17] tcg/aarch64: Add constraints for x0, x1, x2

2018-11-12 Thread Richard Henderson
These are function call arguments that we will need soon. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 12 1 file changed, 12 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 30091f6a69..148de0b7f2 100644 ---

[Qemu-devel] [PATCH for-4.0 05/17] tcg: Return success from patch_reloc

2018-11-12 Thread Richard Henderson
This moves the assert for success from inside patch_reloc to outside patch_reloc. This touches all tcg backends. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 44 ++--- tcg/arm/tcg-target.inc.c | 26 +---

[Qemu-devel] [PATCH for-4.0 14/17] tcg/arm: Add constraints for R0-R5

2018-11-12 Thread Richard Henderson
These are function call arguments that we will need soon. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index 414c91c9ea..4339c472e8 100644 ---

[Qemu-devel] [PATCH for-4.0 11/17] tcg/aarch64: Use B not BL for tcg_out_goto_long

2018-11-12 Thread Richard Henderson
This was a typo copying from tcg_out_call, apparently. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index ea5fe33fca..403f5caf14 100644 ---

[Qemu-devel] [PATCH for-4.0 09/17] tcg/aarch64: Parameterize the temps for tcg_out_tlb_read

2018-11-12 Thread Richard Henderson
When moving the qemu_ld/st arguments to the right place for a function call, we'll need to move the temps out of the way. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 74 +++- 1 file changed, 40 insertions(+), 34 deletions(-) diff --git

[Qemu-devel] [PATCH for-4.0 17/17] tcg/arm: Use TCG_TARGET_NEED_LDST_OOL_LABELS

2018-11-12 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.h | 2 +- tcg/arm/tcg-target.inc.c | 302 +++ 2 files changed, 118 insertions(+), 186 deletions(-) diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h index 94b3578c55..02981abdcc 100644 ---

[Qemu-devel] [PATCH for-4.0 13/17] tcg/arm: Parameterize the temps for tcg_out_tlb_read

2018-11-12 Thread Richard Henderson
When moving the qemu_ld/st arguments to the right place for a function call, we'll need to move the temps out of the way. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 89 +--- 1 file changed, 46 insertions(+), 43 deletions(-) diff --git

<    1   2   3   4   >