[Qemu-devel] [PATCH v3 5/6] hw/mips_cpc: kick a VP when putting it into Run statewq

2019-02-11 Thread Aleksandar Markovic
From: Miodrag Dinic While testing mttcg VP0 could get stuck in a loop waiting for other VPs to come up (which never actually happens). To fix this, kick VPs while they are being powered up by Cluster Power Controller in an async task which is triggered once the host thread is being spawned.

Re: [Qemu-devel] [PULL 00/18] Chardev patches

2019-02-11 Thread Peter Maydell
On Mon, 11 Feb 2019 at 16:50, Daniel P. Berrangé wrote: > > On Thu, Feb 07, 2019 at 05:05:59PM +0100, Marc-André Lureau wrote: > > The following changes since commit 632351e0e1a861f2eaf709b053c53f96a1225825: > > > > Merge remote-tracking branch 'remotes/elmarco/tags/dump-pull-request' > > into

[Qemu-devel] [PULL 4/4] cputlb: update TLB entry/index after tlb_fill

2019-02-11 Thread Richard Henderson
From: "Emilio G. Cota" We are failing to take into account that tlb_fill() can cause a TLB resize, which renders prior TLB entry pointers/indices stale. Fix it by re-doing the TLB entry lookups immediately after tlb_fill. Fixes: 86e1eff8bc ("tcg: introduce dynamic TLB sizing", 2019-01-28)

Re: [Qemu-devel] [PATCH] [qemu-web] Put version numbering details in its own doc

2019-02-11 Thread Kashyap Chamarthy
On Mon, Feb 11, 2019 at 04:24:37PM +, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 05:20:52PM +0100, Kashyap Chamarthy wrote: > > Instead of burying the version numbering details under "Download QEMU" > > page, place it in its own document. And highlight its presence in the > > website

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2019 18:52, Alberto Garcia wrote: > On Mon 11 Feb 2019 03:51:33 PM CET, Vladimir Sementsov-Ogievskiy wrote: > I think this was already discussed in the previous version of this > patch: if you insert a copy-on-read filter here then all guest > reads will copy the data from the

Re: [Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 04:58:19PM +, Dr. David Alan Gilbert wrote: > Hi, > Lukáš reported that there's a migration breakage between 3.1 and > current head with virtio-blk; it looks like the io bar changes from 64 > to 128 bytes and my bisect suggests it's: > > commit

Re: [Qemu-devel] [PATCH v3 0/6] vfio-ccw: support hsch/csch (kernel part)

2019-02-11 Thread Eric Farman
On 02/11/2019 11:13 AM, Cornelia Huck wrote: On Fri, 8 Feb 2019 16:19:58 -0500 Eric Farman wrote: FWIW, I've been running with both series for the last week or two, along with some host kernel traces to prove things got executed the way I thought, and it's seemed to be working well. So

Re: [Qemu-devel] [PATCH 20/25] hw/arm: Express dependencies of the MSF2 machine with Kconfig

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Thomas, On 2/9/19 7:39 AM, Thomas Huth wrote: > Add Kconfig dependencies for the emcraft-sf2 machine. > > Signed-off-by: Thomas Huth > --- > default-configs/arm-softmmu.mak | 3 +-- > hw/arm/Kconfig | 4 > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff

[Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-11 Thread Dr. David Alan Gilbert
Note the error here is on stderr of L1's qemu; there's nothing in dmesg on host or L1 and nothing in the libvirt log. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813165 Title: KVM internal

[Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-11 Thread Dr. David Alan Gilbert
Hmm, I've also just hit this in a nest: KVM internal error. Suberror: 1 emulation failure EAX=0001 EBX=000f7874 ECX=0002 EDX=0001 ESI=7ffbdca4 EDI=69f2 EBP=69b2 ESP=000a8000 EIP=000fd099 EFL=00010046 [---Z-P-] CPL=0 II=0 A20=1 SMM=1 HLT=0 ES =0010 00c09300 CS

[Qemu-devel] [PATCH v3 11/16] chardev: use a state machine for socket connection state

2019-02-11 Thread Daniel P . Berrangé
The socket connection state is indicated via the 'bool connected' field in the SocketChardev struct. This variable is somewhat misleading though, as it is only set to true once the connection has completed all required handshakes (eg for TLS, telnet or websockets). IOW there is a period of time in

[Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/kconfig.rst | 284 + 1 file changed, 284 insertions(+) create mode 100644 docs/devel/kconfig.rst diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst new file mode 100644 index 00..b653c43b12

[Qemu-devel] [PATCH] [qemu-web] Put version numbering details in its own doc

2019-02-11 Thread Kashyap Chamarthy
Instead of burying the version numbering details under "Download QEMU" page, place it in its own document. And highlight its presence in the website footer. While at it, add a concrete example of the version numbering scheme. Signed-off-by: Kashyap Chamarthy --- _includes/footer.html | 1 +

[Qemu-devel] [PATCH v3 3/6] hw/mips_int: hold BQL for all interrupt requests

2019-02-11 Thread Aleksandar Markovic
From: Aleksandar Markovic Make sure BQL is held for all interrupt requests. For MTTCG-enabled configurations, handling soft and hard interrupts between vCPUs must be properly locked. By acquiring BQL, make sure all paths triggering an IRQ are synchronized. Signed-off-by: Miodrag Dinic

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-11 Thread Richard Henderson
On 2/11/19 8:19 AM, Peter Maydell wrote: > Thanks. Richard: is this effectively a bugfix for big-endian guest code ? Yes. r~

Re: [Qemu-devel] [PATCH] block/dirty-bitmap: Documentation and Comment fixups

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
02.02.2019 4:01, John Snow wrote: > > > On 1/31/19 3:29 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> About @frozen and @locked, we can also note that they can't be exported >> through NBD. >> We can summarize, that @frozen and @locked means that user can't use them in >> any >> command, and

[Qemu-devel] [PATCH v3 00/16] chardev: refactoring & many bugfixes related tcp_chr_wait_connected

2019-02-11 Thread Daniel P . Berrangé
This is a followup to v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg03344.html v2: http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg05947.html This series comes out of a discussion between myself & Yongji Xie in:

[Qemu-devel] [PATCH v3 04/16] chardev: forbid 'reconnect' option with server sockets

2019-02-11 Thread Daniel P . Berrangé
The 'reconnect' option is used to give the sleep time, in seconds, before a client socket attempts to re-establish a connection to the server. It does not make sense to set this for server sockets, as they will always accept a new client connection immediately after the previous one went away.

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2019 20:54, Kevin Wolf wrote: > Am 21.12.2018 um 17:53 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Move to way of device selecting, however fall back to device name if >> path is not found. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> qapi/block-core.json | 4 ++-- >>

[Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-11 Thread Laszlo Ersek (Red Hat)
This is related to SMM usage in SeaBIOS. The QEMU register dump states SMM=1, plus "<0f> aa" from the dumped code stands for the RSM instruction (0F AA -- RSM—Resume from System Management Mode, see it in the Intel SDM.) In RHEL7 downstream, we disabled SMM usage in SeaBIOS. -

Re: [Qemu-devel] [PULL 00/18] Chardev patches

2019-02-11 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 05:05:59PM +0100, Marc-André Lureau wrote: > The following changes since commit 632351e0e1a861f2eaf709b053c53f96a1225825: > > Merge remote-tracking branch 'remotes/elmarco/tags/dump-pull-request' into > staging (2019-02-07 14:20:46 +) > > are available in the Git

Re: [Qemu-devel] [PATCH 22/25] hw/arm: Express dependencies of nrf51 Kconfig

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Thomas, On 2/9/19 7:39 AM, Thomas Huth wrote: > Add Kconfig dependencies for the NRF51 / microbit machine. > > Signed-off-by: Thomas Huth > --- > hw/arm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index c4b3cd2..aad2dd3 100644 > ---

[Qemu-devel] [PATCH v3 05/16] chardev: forbid 'wait' option with client sockets

2019-02-11 Thread Daniel P . Berrangé
The 'wait'/'nowait' parameter is used to tell server sockets whether to block until a client is accepted during initialization. Client chardevs have always silently ignored this option. Various tests were mistakenly passing this option for their client chardevs. Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH v3 06/16] chardev: remove many local variables in qemu_chr_parse_socket

2019-02-11 Thread Daniel P . Berrangé
Now that all validation is separated off into a separate method, we can directly populate the ChardevSocket struct from the QemuOpts values, avoiding many local variables. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c | 40

Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum

2019-02-11 Thread Eric Blake
On 2/9/19 7:15 AM, Marc-André Lureau wrote: # Display (user interface) type. # +# @default: The default user interface. >>> >>> Any more hints on how this default is determined? Is it a compile-time >>> decision, based on what libraries were linked in? >> >> Basically yes. A

Re: [Qemu-devel] [PULL v2 00/76] misc patches for 2019-02-04

2019-02-11 Thread David Hildenbrand
On 11.02.19 17:33, Peter Maydell wrote: > On Mon, 11 Feb 2019 at 16:29, David Hildenbrand wrote: >> >> On 05.02.19 21:05, Peter Maydell wrote: >>> This part looks like the usual "foo-softmmu/config-devices.mak isn't updated >>> if a file that's #included from default-configs/foo-softmmu.mak is

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-11 Thread Kevin Wolf
Am 11.02.2019 um 18:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > 08.01.2019 16:20, Markus Armbruster wrote: > > Vladimir Sementsov-Ogievskiy writes: > > > >> Move to way of device selecting, however fall back to device name if > >> path is not found. > >> > >> Signed-off-by: Vladimir

[Qemu-devel] [PATCH 1/5] target/hppa: move GETPC to HELPER() functions

2019-02-11 Thread Sven Schnelle
When QEMU is compiled with -O0, these functions are inlined which will cause a wrong restart address generated for the TB. Signed-off-by: Sven Schnelle --- target/hppa/op_helper.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/target/hppa/op_helper.c

[Qemu-devel] [PATCH 5/5] target/hppa: fix dcor instruction

2019-02-11 Thread Sven Schnelle
It looks like the operands where exchanged. HP bootrom tests the following sequence: 0xf0004064: ldil L%-6800,r7 0xf0004068: addi 19f,r7,r7 0xf000406c: addi -1,r0,rp 0xf0004070: addi f,r0,r4 0xf0004074: addi 1,r4,r5 0xf0004078: dcor rp,r6

[Qemu-devel] [PATCH 3/5] target/hppa: fix log conditions

2019-02-11 Thread Sven Schnelle
Now that do_cond() uses sign overflow for some condition matches we need to roll our own version without sign overflow checks. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-11 Thread Sven Schnelle
Now that do_cond() uses sign overflow for some condition matches we need to roll our own version without sign overflow checks. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH v3 03/16] chardev: fix validation of options for QMP created chardevs

2019-02-11 Thread Daniel P . Berrangé
The TLS creds option is not valid with certain address types. The user config was only checked for errors when parsing legacy QemuOpts, thus the user could pass unsupported values via QMP. Pull all code for validating options out into a new method qmp_chardev_validate_socket, that is called from

[Qemu-devel] [PATCH v3 15/16] tests: expand coverage of socket chardev test

2019-02-11 Thread Daniel P . Berrangé
The current socket chardev tests try to exercise the chardev socket driver in both server and client mode at the same time. The chardev API is not very well designed to handle both ends of the connection being in the same process so this approach makes the test case quite unpleasant to deal with.

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-11 Thread liang yan
Hi, Thomas, you are right, I am using 2.9.1, and it does look OK in 2.10. do you mind to point me which part of code fixed it? Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815143 Title:

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2019 20:52, Kevin Wolf wrote: > Am 11.02.2019 um 18:39 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 08.01.2019 16:20, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Move to way of device selecting, however fall back to device name if path is not found.

[Qemu-devel] [PATCH] target/hppa: forward requests to CPU HPA

2019-02-11 Thread Sven Schnelle
HP-UX 10.20 uses busmaster writes to the CPU EIR to signal interrupts from the SCSI constroller. (Similar to what is known as MSI on x86) Signed-off-by: Sven Schnelle --- hw/hppa/dino.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c

[Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-11 Thread Albert Damen
I have bisected the kernel and ended with first bad commit: commit 14c07ad89f4d728a468caaea6a769c018c2b8dd6 Author: Vitaly Kuznetsov Date: Mon Oct 8 21:28:08 2018 +0200 x86/kvm/mmu: introduce guest_mmu When EPT is used for nested guest we need to re-init MMU as shadow EPT MMU

Re: [Qemu-devel] [PULL 00/18] testing updates: travis/cirrus/vm-test/binfmt

2019-02-11 Thread Peter Maydell
On Mon, 11 Feb 2019 at 13:05, Alex Bennée wrote: > > The following changes since commit e47f81b617684c4546af286d307b69014a83538a: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2019-02-07 18:53:25 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Cornelia Huck
On Mon, 11 Feb 2019 17:38:29 +0100 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst > > diff --git a/docs/devel/kconfig.rst

Re: [Qemu-devel] [PATCH 18/25] hw/arm: Express dependencies of canon-a1100 with Kconfig

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/9/19 7:39 AM, Thomas Huth wrote: > Add Kconfig dependencies for the DIGIC / canon-a1100 machine. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé > --- > default-configs/arm-softmmu.mak | 2 +- > hw/arm/Kconfig | 1 + > 2 files changed, 2

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-11 Thread Kevin Wolf
Am 21.12.2018 um 17:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > Move to way of device selecting, however fall back to device name if > path is not found. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 4 ++-- > blockdev.c | 22

Re: [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files.

2019-02-11 Thread Palmer Dabbelt
On Fri, 08 Feb 2019 11:28:48 PST (-0800), alistai...@gmail.com wrote: On Fri, Feb 8, 2019 at 11:09 AM Jim Wilson wrote: On Fri, Feb 8, 2019 at 10:17 AM Alistair Francis wrote: > Can we just write a wrapper function then that sets and unsets the variable? > Something like this: > >

[Qemu-devel] [PATCH v3 13/16] chardev: disallow TLS/telnet/websocket with tcp_chr_wait_connected

2019-02-11 Thread Daniel P . Berrangé
In the previous commit commit 1dc8a6695c731abb7461c637b2512c3670d82be4 Author: Marc-André Lureau Date: Tue Aug 16 12:33:32 2016 +0400 char: fix waiting for TLS and telnet connection the tcp_chr_wait_connected() method was changed to check for a non-NULL 's->ioc' as a sign

Re: [Qemu-devel] [PULL 00/18] Chardev patches

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 05:03:13PM +, Daniel P. Berrangé wrote: > On Fri, Feb 08, 2019 at 11:44:42AM +, Peter Maydell wrote: > > On Thu, 7 Feb 2019 at 16:06, Marc-André Lureau > > wrote: > > > > > > The following changes since commit > > > 632351e0e1a861f2eaf709b053c53f96a1225825: > > >

Re: [Qemu-devel] [qemu-s390x] [PATCH 04/15] s390-bios: Extend find_dev() for non-virtio devices

2019-02-11 Thread Thomas Huth
On 2019-01-29 14:29, Jason J. Herne wrote: > We need a method for finding the subchannel of a dasd device. Let's > modify find_dev to handle this since it mostly does what we need. Up to > this point find_dev has been specific to only virtio devices. > > Signed-off-by: Jason J. Herne > Acked-by:

Re: [Qemu-devel] [PULL 00/18] Chardev patches

2019-02-11 Thread Daniel P . Berrangé
On Fri, Feb 08, 2019 at 11:44:42AM +, Peter Maydell wrote: > On Thu, 7 Feb 2019 at 16:06, Marc-André Lureau > wrote: > > > > The following changes since commit 632351e0e1a861f2eaf709b053c53f96a1225825: > > > > Merge remote-tracking branch 'remotes/elmarco/tags/dump-pull-request' > > into

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-02-11 Thread Julia Suvorova via Qemu-devel
On 11.02.2019 18:51, Daniel P. Berrangé wrote: On Thu, Jan 31, 2019 at 03:03:21PM -0600, Eric Blake wrote: On 1/31/19 2:26 PM, Julia Suvorova via Qemu-devel wrote: The whitelist option allows to run a reduced monitor with a subset of QMP commands. This allows the monitor to run in secure

[Qemu-devel] [PULL 2/4] tcg/i386: fix unsigned vector saturating arithmetic

2019-02-11 Thread Richard Henderson
From: Mark Cave-Ayland Due to a cut/paste error in the original implementation, the unsigned vector saturating arithmetic was erroneously being calculated as signed vector saturating arithmetic. Fixes: 8ffafbcec2 ("tcg/i386: Implement vector saturating arithmetic") Signed-off-by: Mark

[Qemu-devel] [PULL 0/4] tcg queued patches

2019-02-11 Thread Richard Henderson
-20190211 for you to fetch changes up to 6d967cb86d5b4a60ba15b497126b621ce9ca6609: cputlb: update TLB entry/index after tlb_fill (2019-02-11 08:52:44 -0800) Fix dynamic tlb resize Fix x86 host vector saturation Diagnose missing tcg

[Qemu-devel] [PULL 1/4] tcg: Diagnose referenced labels that have not been emitted

2019-02-11 Thread Richard Henderson
Currently, a jump to a label that is not defined anywhere will be emitted not be relocated. This results in a jump to a random jump target. With tcg debugging, print a diagnostic to the -d op file and abort. This could help debug or detect errors like c2d9644e6d ("target/arm: Fix crash on

[Qemu-devel] -device ipmi-bmc-sim attached to -netdev vde

2019-02-11 Thread Robin Jarry
Hi, I have several QEMU VMs connected via a vde_switch (with "-netdev vde" interfaces). I use this to create virtual network topologies without requiring root access (i.e. no tap + bridge on host). Performance is not a concern here. To emulate "real" platforms, I would like one of the VMs to

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
08.01.2019 16:20, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Move to way of device selecting, however fall back to device name if >> path is not found. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> qapi/block-core.json | 4 ++-- >> blockdev.c

[Qemu-devel] [PATCH 2/5] target/hppa: fix '

2019-02-11 Thread Sven Schnelle
These condition include the signed overflow bit. See Page 5-3 of the Parisc 1.1 Architecture Reference manual for details. Signed-off-by: Sven Schnelle --- target/hppa/translate.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v3 10/16] chardev: split up qmp_chardev_open_socket connection code

2019-02-11 Thread Daniel P . Berrangé
In qmp_chardev_open_socket the code for connecting client chardevs is split across two conditionals far apart with some server chardev code in the middle. Split up the method so that code for client connection setup is separate from code for server connection setup. Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH v3 14/16] chardev: fix race with client connections in tcp_chr_wait_connected

2019-02-11 Thread Daniel P . Berrangé
When the 'reconnect' option is given for a client connection, the qmp_chardev_open_socket_client method will run an asynchronous connection attempt. The QIOChannel socket executes this is a single use background thread, so the connection will succeed immediately (assuming the server is listening).

Re: [Qemu-devel] [PATCH v2] block/dirty-bitmap: Documentation and Comment fixups

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
04.02.2019 22:26, John Snow wrote: > > > On 2/4/19 10:00 AM, Eric Blake wrote: >> On 2/1/19 7:10 PM, John Snow wrote: >>> The meaning of the states has changed subtly over time, >>> this should bring the understanding more in-line with the >>> current, actual usages. >>> >>> Reported-by: Eric

Re: [Qemu-devel] [PATCH] monitor: Add whitelist support for QMP commands

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 07:15:58PM +0300, Julia Suvorova wrote: > > > On 11.02.2019 18:51, Daniel P. Berrangé wrote: > > On Thu, Jan 31, 2019 at 03:03:21PM -0600, Eric Blake wrote: > > > On 1/31/19 2:26 PM, Julia Suvorova via Qemu-devel wrote: > > > > The whitelist option allows to run a reduced

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-11 Thread Richard Henderson
On 1/31/19 5:40 PM, Catherine Ho wrote: > The lo,hi order is different from the comments. And in commit > 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes > the original code logic. So just restore the old code logic before this > commit: > do_paired_cmpxchg64_be(): > cmpv

Re: [Qemu-devel] [PATCH v2 0/2] Maintainership changes

2019-02-11 Thread Kevin Wolf
Am 11.02.2019 um 16:03 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi, is there a reason why it's not merged? > > Address jc...@redhat.com is not present anymore, at least it should be dropped > from MAINTAINERS. I don't think there is a reason, so I applied it to the block branch now.

Re: [Qemu-devel] Bug: Lost slirp functionality on qemu-system-ppc build for windows.

2019-02-11 Thread Marc-André Lureau
Hi On Mon, Feb 11, 2019 at 10:52 AM Peter Maydell wrote: > > On Mon, 11 Feb 2019 at 07:57, Thomas Huth wrote: > > > > On 2019-02-10 23:12, Howard Spoelstra wrote: > > > Hi, > > > > > > I just cross compiled Qemu-system-ppc for Windows on Fedora 29 and > > > discovered slirp does not work

[Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Dr. David Alan Gilbert
Hi, Lukáš reported that there's a migration breakage between 3.1 and current head with virtio-blk; it looks like the io bar changes from 64 to 128 bytes and my bisect suggests it's: commit caa1ee43131c060347b32893abd41fe4865eaa2e (HEAD, refs/bisect/bad) Author: Changpeng Liu Date: Wed Jan

[Qemu-devel] [PULL 3/4] exec-all: document that tlb_fill can trigger a TLB resize

2019-02-11 Thread Richard Henderson
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20190209162745.12668-2-c...@braap.org> Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index

Re: [Qemu-devel] [PATCH v3 4/6] target/mips: hold BQL in mips_vpe_wake()

2019-02-11 Thread Alex Bennée
Aleksandar Markovic writes: > From: Goran Ferenc > > Hold BQL whenever mips_vpe_wake() is invoked. > > Without this patch, MIPS MT with MTTCG enabled triggers an abort in > tcg_handle_interrupt() due to an unlocked access to cpu_interrupt(). > This patch makes sure that the BQL is held in

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-02-11 Thread Jason J. Herne
On 2/4/19 5:45 AM, Cornelia Huck wrote: On Tue, 29 Jan 2019 08:29:12 -0500 "Jason J. Herne" wrote: Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. s/cases./cases,/ In one case no boot device is specified and a suitable boot device can not be

[Qemu-devel] [PATCH v3 01/16] io: store reference to thread information in the QIOTask struct

2019-02-11 Thread Daniel P . Berrangé
Currently the struct QIOTaskThreadData is only needed by the worker thread, but a subsequent patch will need to access it from another context. Signed-off-by: Daniel P. Berrangé --- io/task.c | 64 +-- 1 file changed, 34 insertions(+), 30

[Qemu-devel] [PATCH v3 02/16] io: add qio_task_wait_thread to join with a background thread

2019-02-11 Thread Daniel P . Berrangé
Add the ability for a caller to wait for completion of the background thread to synchronously dispatch its result, without needing to wait for the main loop to run the idle callback. This method needs very careful usage to avoid a dangerous race condition with the free'ing of the task. The

[Qemu-devel] [PATCH v3 07/16] chardev: ensure qemu_chr_parse_compat reports missing driver error

2019-02-11 Thread Daniel P . Berrangé
If no valid char driver was identified the qemu_chr_parse_compat method was silent, leaving callers no clue what failed. Signed-off-by: Daniel P. Berrangé --- chardev/char.c| 2 ++ tests/test-char.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/chardev/char.c

[Qemu-devel] [PATCH v3 08/16] chardev: remove unused 'sioc' variable & cleanup paths

2019-02-11 Thread Daniel P . Berrangé
The 'sioc' variable in qmp_chardev_open_socket was unused since commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 Author: Peter Xu Date: Tue Mar 6 13:33:17 2018 +0800 chardev: use chardev's gcontext for async connect Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v3 09/16] chardev: split tcp_chr_wait_connected into two methods

2019-02-11 Thread Daniel P . Berrangé
The tcp_chr_wait_connected method can deal with either server or client chardevs, but some callers only care about one of these possibilities. The tcp_chr_wait_connected method will also need some refactoring to reliably deal with its primary goal of allowing a device frontend to wait for an

[Qemu-devel] [PATCH v3 12/16] chardev: honour the reconnect setting in tcp_chr_wait_connected

2019-02-11 Thread Daniel P . Berrangé
If establishing a client connection fails, the tcp_chr_wait_connected method should sleep for the reconnect timeout and then retry the attempt. This ensures the callers don't immediately abort with an error when the initial connection fails. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel

[Qemu-devel] [PATCH v3 16/16] chardev: ensure termios is fully initialized

2019-02-11 Thread Daniel P . Berrangé
valgrind on the test-char.c code reports that 'struct termios' contains uninitialized memory. Signed-off-by: Daniel P. Berrangé --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index

Re: [Qemu-devel] [PULL 0/4] tcg queued patches

2019-02-11 Thread Peter Maydell
are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20190211 > > for you to fetch changes up to 6d967cb86d5b4a60ba15b497126b621ce9ca6609: > > cputlb: update TLB entry/index

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-11 Thread Stefan Berger
On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: Hi Liam, On 2/11/19 4:03 PM, Liam Merwick wrote: cppcheck reports: [hw/tpm/tpm_tis.c:113]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int' Fix this by using %u instead of %d Liam, Neither gcc

[Qemu-devel] [PULL 3/4] qcow2: Add list of bitmaps to ImageInfoSpecificQCow2

2019-02-11 Thread Eric Blake
From: Andrey Shinkevich In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existing QCOW2 bitmaps will be shown, such as a bitmap name, flags and granularity: image: /vz/vmprivate/VM1/harddisk.hdd file format: qcow2 virtual

Re: [Qemu-devel] [PATCH 3/4] nbd: do qemu_coroutine_yield during tls handshake

2019-02-11 Thread Eric Blake
On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: > We always call qio_channel_tls_handshake in nbd from couroutine. Take > benefit of it and just yield instead of creating personal main loop. > > Mark and rename the function and it's callers correspondingly and > trace-points too. > >

Re: [Qemu-devel] [PATCH 1/2] audio/sdlaudio: Remove the semaphore code

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/5/19 4:08 AM, Thomas Huth wrote: > The semaphore code was only working with SDL1.2 - with SDL2, it causes > a deadlock. Since we've removed support for SDL1.2 recently, we can > now completely remove the semaphore code from sdlaudio.c. > > Signed-off-by: Thomas Huth Reviewed-by: Philippe

Re: [Qemu-devel] security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device)

2019-02-11 Thread Michael S. Tsirkin
On Mon, Feb 11, 2019 at 11:58:15PM +0100, David Hildenbrand wrote: > On 11.02.19 23:29, Dave Chinner wrote: > > On Mon, Feb 11, 2019 at 02:29:46AM -0500, Pankaj Gupta wrote: > >> Hello Dave, > >> Are we okay with this? > > > > Sure. > > > > I'm not sure I agree with all the analysis presented,

[Qemu-devel] [PULL 4/4] qcow2: list of bitmaps new test 242

2019-02-11 Thread Eric Blake
From: Andrey Shinkevich A new test file 242 added to the qemu-iotests set. It checks the format of qcow2 specific information for the new added section that lists details of bitmaps. Signed-off-by: Andrey Shinkevich Message-Id:

[Qemu-devel] [PULL 1/4] nbd/server: Kill pointless shadowed variable

2019-02-11 Thread Eric Blake
lgtm.com pointed out that commit 678ba275 introduced a shadowed declaration of local variable 'bs'; thankfully, the inner 'bs' obtained by 'blk_bs(blk)' matches the outer one given that we had 'blk_insert_bs(blk, bs, errp)' a few lines earlier, and there are no later uses of 'bs' beyond the scope

[Qemu-devel] [PULL 0/4] NBD patches for 2019-02-11

2019-02-11 Thread Eric Blake
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-02-11

Re: [Qemu-devel] [PATCH 4/4] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-02-11 Thread Eric Blake
On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: > Now negotiation is done in coroutine, so to take benefit of it let's > use non-blocking model. > > Note that QIOChannel handle synchronous io calls correctly anyway, so s/handle/handles/ > it's not a problem to send final NBD_CMD_DISC to

Re: [Qemu-devel] [PATCH 1/1] RFC: net/slirp: link with libslirp

2019-02-11 Thread Samuel Thibault
Marc-André Lureau, le lun. 11 févr. 2019 12:34:47 +0100, a ecrit: > On Mon, Feb 11, 2019 at 12:09 PM Daniel P. Berrangé > wrote: > > > > On Fri, Feb 08, 2019 at 07:12:26PM +0100, Marc-André Lureau wrote: > > > Once libslirp has received its first release, we can link with the > > > external

Re: [Qemu-devel] security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device)

2019-02-11 Thread Dave Chinner
On Mon, Feb 11, 2019 at 02:29:46AM -0500, Pankaj Gupta wrote: > Hello Dave, > Are we okay with this? Sure. I'm not sure I agree with all the analysis presented, but, well, I haven't looked any deeper because I'm tired of being shouted at and being called argumentative for daring to ask hard

Re: [Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-11 Thread John Snow
On 2/6/19 12:02 PM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part

[Qemu-devel] [PULL 2/4] bdrv_query_image_info Error parameter added

2019-02-11 Thread Eric Blake
From: Andrey Shinkevich Inform a user in case qcow2_get_specific_info fails to obtain QCOW2 image specific information. This patch is preliminary to the one "qcow2: Add list of bitmaps to ImageInfoSpecificQCow2". Signed-off-by: Andrey Shinkevich Reviewed-by: Eric Blake Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-11 Thread Stefan Berger
On 2/11/19 3:09 PM, Liam Merwick wrote: I'd come up the attached change (but that seems like overkill). I don't think we need tracing for this.

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-11 Thread liang yan
A little bit confused here, I tired to bisect it from 2.10, but it was always good from this branch. then I went back to 2.9.1, it was always crashed. Machine type related? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v3 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-11 Thread Alex Williamson
On Sun, 10 Feb 2019 07:52:59 +0100 Knut Omang wrote: > Add a helper function to add PCIe capability for Access Control Services (ACS) > ACS support in the associated root port is a prerequisite to be able to do > passthrough of individual functions of a device with VFIO > without Alex

[Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-11 Thread Dr. David Alan Gilbert
Thanks for the bisect! I've cc'd in Vitaly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813165 Title: KVM internal error. Suberror: 1 emulation failure Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH v2 3/3] tpm_tis: fix format string specifier in tpm_tis_show_buffer()

2019-02-11 Thread Liam Merwick
On 11/02/2019 19:56, Stefan Berger wrote: On 2/11/19 11:02 AM, Philippe Mathieu-Daudé wrote: Hi Liam, On 2/11/19 4:03 PM, Liam Merwick wrote: cppcheck reports: [hw/tpm/tpm_tis.c:113]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int' Fix this by

Re: [Qemu-devel] [PATCH v2 1/3] tpm_tis: fix loop that cancels any seizure by a lower locality

2019-02-11 Thread Stefan Berger
On 2/11/19 10:03 AM, Liam Merwick wrote: In tpm_tis_mmio_write() if the requesting locality is seizing access, any seizure by a lower locality is cancelled. However the loop doing the seizure had an off-by-one error and the locality immediately preceding the requesting locality was not being

Re: [Qemu-devel] [PATCH 1/4] io/channel: add qio_channel_get_attached_aio_context()

2019-02-11 Thread Eric Blake
On 2/11/19 6:55 AM, Vladimir Sementsov-Ogievskiy wrote: > Expose attached aio context. It will be used in nbd code, to > understand, in which aio context negotiation should be done. s/, in/ in/ > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 9 + >

Re: [Qemu-devel] [PATCH v2] block/dirty-bitmap: Documentation and Comment fixups

2019-02-11 Thread John Snow
On 2/11/19 1:25 PM, Vladimir Sementsov-Ogievskiy wrote: > 04.02.2019 22:26, John Snow wrote: >> >> >> On 2/4/19 10:00 AM, Eric Blake wrote: >>> On 2/1/19 7:10 PM, John Snow wrote: The meaning of the states has changed subtly over time, this should bring the understanding more in-line

Re: [Qemu-devel] [PATCH 2/4] nbd/client: do negotiation in coroutine

2019-02-11 Thread Eric Blake
On 2/11/19 6:55 AM, Vladimir Sementsov-Ogievskiy wrote: > As a first step to non-blocking negotiation, move it to coroutine. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 123 +-- > 1 file changed, 109 insertions(+), 14

Re: [Qemu-devel] security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device)

2019-02-11 Thread David Hildenbrand
On 11.02.19 23:29, Dave Chinner wrote: > On Mon, Feb 11, 2019 at 02:29:46AM -0500, Pankaj Gupta wrote: >> Hello Dave, >> Are we okay with this? > > Sure. > > I'm not sure I agree with all the analysis presented, but, well, I > haven't looked any deeper because I'm tired of being shouted at and >

[Qemu-devel] [PATCH v3 00/28] target/arm: Implement ARMv8.5-MemTag

2019-02-11 Thread Richard Henderson
Based-on: <20190204131228.25949-1-richard.hender...@linaro.org> aka "[PATCH v3 0/4] target/arm: Implement ARMv8.5-BTI". The full tree is available at https://github.org/rth7680/qemu.git tgt-arm-mte Major changes since v2: * LDG, STG, ST2G, LDGM, STGM STZGM instructions updated. The new

[Qemu-devel] [PATCH v3 15/28] target/arm: Implement LDG, STG, ST2G instructions

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Split out allocation_tag_mem. Handle atomicity of stores. v3: Add X[t] input to these insns; require pre-cleaned addresses. --- target/arm/helper-a64.h| 5 ++ target/arm/mte_helper.c| 151 +

[Qemu-devel] [PATCH v3 16/28] target/arm: Implement the STGP instruction

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v3: Handle atomicity, require pre-cleaned address. --- target/arm/translate-a64.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index feed325083..ef3fc3a397

[Qemu-devel] [PATCH v3 07/28] target/arm: Assert no manual change to CACHED_PSTATE_BITS

2019-02-11 Thread Richard Henderson
These bits are stored elsewhere; changing env->pstate has no effect. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/translate.h b/target/arm/translate.h index a24757d3d7..296d1ac72c

[Qemu-devel] [PATCH v3 13/28] target/arm: Implement the SUBP instruction

2019-02-11 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Fix extraction length. --- target/arm/translate-a64.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index

  1   2   3   4   >