[Qemu-devel] [PATCH v3 22/28] tcg: Introduce target-specific page data for user-only

2019-02-11 Thread Richard Henderson
At the same time, remember MAP_SHARED as PAGE_SHARED. When mapping new pages, make sure that old target-specific page data is removed. Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 10 -- accel/tcg/translate-all.c | 28 linux-user/mmap.c

[Qemu-devel] [PATCH v3 10/28] target/arm: Implement the IRG instruction

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Update to 00eac5. Merge choose_random_nonexcluded_tag into helper_irg since that pseudo function no longer exists separately. --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 57 ++

[Qemu-devel] [PATCH v3 28/28] tests/tcg/aarch64: Add mte smoke tests

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/aarch64/mte-1.c | 27 + tests/tcg/aarch64/mte-2.c | 39 +++ tests/tcg/aarch64/Makefile.target | 4 3 files changed, 70 insertions(+) create mode 100644 tests/tcg/aarch64/mte-1.c

[Qemu-devel] [PATCH v3 25/28] target/arm: Add allocation tag storage for user mode

2019-02-11 Thread Richard Henderson
Control this with x-tagged-pages, which is off by default. The limitation to non-shared pages is not part of a future kernel API, but a limitation of linux-user not being able to map virtual pages back to physical pages. Signed-off-by: Richard Henderson --- v2: Add the x-tagged-pages cpu

Re: [Qemu-devel] [PATCH 4/4] mips_fulong2e: Add on-board graphics chip

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/11/19 5:01 AM, BALATON Zoltan wrote: > Add (partial) emulation of the on-board GPU of the machine. This > allows the PMON2000 firmware to run and should also work with Linux > console but probably not with X yet. > > Signed-off-by: BALATON Zoltan > --- > Depends on hw/display: Add basic ATI

[Qemu-devel] [PATCH v3 24/28] target/arm: Create tagged ram when MTE is enabled

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4 hw/arm/virt.c| 33 + target/arm/cpu.c | 21 ++--- 3 files changed, 55 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index ca32939483..2626af4a9c

[Qemu-devel] [PATCH v3 27/28] target/arm: Enable MTE

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.c | 10 ++ target/arm/cpu64.c | 1 + 2 files changed, 11 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index decf95de3e..a5599ae19f 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -206,6 +206,16 @@ static

Re: [Qemu-devel] [PATCH 1/4] hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/11/19 5:01 AM, BALATON Zoltan wrote: > Stop using system memory as PCI memory otherwise devices such as VGA > that have regions mapped to PCI memory clash with RAM. Use a separate > memory region for PCI memory and map it to the correct address in > system memory which allows PCI mem regions

[Qemu-devel] [PATCH 1/5] block/dirty-bitmap: add recording and busy properties

2019-02-11 Thread John Snow
The current API allows us to report a single status, which we've defined as: Frozen: has a successor, treated as qmp_locked, may or may not be enabled. Locked: no successor, qmp_locked. may or may not be enabled. Disabled: Not frozen or locked, disabled. Active: Not frozen, locked, or disabled.

[Qemu-devel] [PATCH 2/5] block/dirty-bitmaps: rename frozen predicate helper

2019-02-11 Thread John Snow
"Frozen" was a good description a long time ago, but it isn't adequate now. Rename the frozen predicate to has_successor to make the semantics of the predicate more clear to outside callers. In the process, remove some calls to frozen() that no longer semantically make sense. For enabled and

Re: [Qemu-devel] [PATCH 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:44PM +0100, Cédric Le Goater wrote: > The activation of the KVM IRQ device depends on the interrupt mode > chosen at CAS time by the machine and some methods used at reset or by > the migration need to be protected. > > Signed-off-by: Cédric Le Goater > --- >

Re: [Qemu-devel] [PATCH 12/13] spapr/xics: ignore the lower 4K in the IRQ number space

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:45PM +0100, Cédric Le Goater wrote: > The IRQ number space of the XIVE and XICS interrupt mode are aligned > when using the dual interrupt mode for the machine. This means that > the ICS offset is set to zero in QEMU and that the KVM XICS device > should be informed

Re: [Qemu-devel] [regression] Clock jump on VM migration

2019-02-11 Thread Stefan Hajnoczi
Hi Neil, I'll return to this issue on Monday. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 01:59:38AM +, Liu, Changpeng wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, February 12, 2019 1:23 AM > > To: Dr. David Alan Gilbert > > Cc: qemu-devel@nongnu.org; Liu, Changpeng ; > >

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 09:38:37AM +, Vladimir Sementsov-Ogievskiy wrote: > 11.02.2019 6:42, Stefan Hajnoczi wrote: > > On Fri, Feb 08, 2019 at 05:11:22PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> Hi all! > >> > >> We have a very frequent pattern of wrapping a coroutine_fn function

[Qemu-devel] [Bug 1815413] Re: compile with vhost-vsock support on osx

2019-02-11 Thread Stefan Hajnoczi
vhost devices are not available on macOS hosts, they are a Linux feature. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815413 Title: compile

[Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Changpeng Liu
Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" introduced extra fields to existing struct virtio_blk_config, when migration was executed from older QEMU version to current head, it will break the migration. While here, set the correct config size when initializing the

Re: [Qemu-devel] [PATCH 5/5] target/hppa: fix dcor instruction

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > It looks like the operands where exchanged. HP bootrom tests the > following sequence: > > 0xf0004064: ldil L%-6800,r7 > 0xf0004068: addi 19f,r7,r7 > 0xf000406c: addi -1,r0,rp > 0xf0004070: addi f,r0,r4 >

Re: [Qemu-devel] [PATCH 3/5] target/hppa: fix log conditions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > switch (cf >> 1) { > -case 4: case 5: case 6: > -cf &= 1; > +case 0: /* never */ > +cond = cond_make_f(); > +break; > +case 1: /* = all bits are zero */ > +cond = cond_make_0(TCG_COND_EQ, res); > +

Re: [Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

2019-02-11 Thread Alistair Francis
On Sun, Feb 10, 2019 at 2:12 PM Lukas Auer wrote: > > Re-add the previous compatible string "riscv-virtio-soc" to the soc > device tree node to allow U-Boot and Linux to bind machine-specific > drivers to it. The current compatible string "simple-bus" is retained. > > This is required by U-Boot

Re: [Qemu-devel] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Mark, On 2/10/19 6:44 PM, Mark Cave-Ayland wrote: > In order to handle a race condition in MacOS 9, a delay was introduced when > raising the VIA SR interrupt inspired by similar code in MacOnLinux. > > During original testing of the MacOS 9 patches it was found that the 30us > delay used in

[Qemu-devel] [PATCH v3 23/28] target/arm: Cache the Tagged bit for a page in MemTxAttrs

2019-02-11 Thread Richard Henderson
This "bit" is a particular value of the page's MemAttr. Signed-off-by: Richard Henderson --- target/arm/helper.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index b979ca0255..e312d62140 100644 ---

[Qemu-devel] [PATCH v3 17/28] target/arm: Implement the LDGM and STGM instructions

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v3: Require pre-cleaned addresses. --- target/arm/helper-a64.h| 3 ++ target/arm/mte_helper.c| 96 ++ target/arm/translate-a64.c | 42 + 3 files changed, 132 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH v3 05/28] target/arm: Extract TCMA with ARMVAParameters

2019-02-11 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/internals.h | 1 + target/arm/helper.c| 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 6c018e773c..2922324f63 100644 ---

[Qemu-devel] [PATCH v3 26/28] target/arm: Add allocation tag storage for system mode

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 96 + 1 file changed, 87 insertions(+), 9 deletions(-) diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c index 09c387e2c7..53c3ed862e 100644 --- a/target/arm/mte_helper.c +++

Re: [Qemu-devel] [PATCH 2/4] mips_fulong2e: Fix bios flash size

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/11/19 5:01 AM, BALATON Zoltan wrote: > According to both the specifications on linux-mips.org referenced in a This link: https://www.linux-mips.org/wiki/Fulong#Front: > comment at the beginning of the file and the flash chip part number > the bios size should be 512k not 1M. > >

Re: [Qemu-devel] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: > The interrupt mode is chosen by the CAS negotiation process and > activated after a reset to take into account the required changes in > the machine. This brings new constraints on how the associated KVM IRQ > device is

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-11 Thread David Gibson
On Fri, Feb 08, 2019 at 08:12:12AM +0100, Cédric Le Goater wrote: > On 2/8/19 6:36 AM, David Gibson wrote: > > On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: > >> When the thread interrupt management state is retrieved from the KVM > >> VCPU, word2 is saved under the QEMU XIVE

Re: [Qemu-devel] [PATCH 10/13] spapr: introduce routines to delete the KVM IRQ device

2019-02-11 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:43PM +0100, Cédric Le Goater wrote: > If a new interrupt mode is chosen by CAS, the machine generates a > reset to reconfigure. At this point, the connection with the previous > KVM device needs to be closed and a new connection needs to opened > with the KVM device

[Qemu-devel] [PULL 0/3] Block patches

2019-02-11 Thread Stefan Hajnoczi
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

[Qemu-devel] [PULL 1/3] iothread: fix iothread hang when stop too soon

2019-02-11 Thread Stefan Hajnoczi
From: Peter Xu Lukas reported an hard to reproduce QMP iothread hang on s390 that QEMU might hang at pthread_join() of the QMP monitor iothread before quitting: Thread 1 #0 0x03ffad10932c in pthread_join #1 0x000109e95750 in qemu_thread_join at

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 05:38:29PM +0100, Paolo Bonzini wrote: > +The Kconfig language > + > + > +Kconfig defines configurable components in files named ``hw/*/Kconfig``. > +Note that configurable components are _not_ visible in C code as > preprocessor symbols; > +they are

[Qemu-devel] [PATCH v3 04/28] target/arm: Add MTE_ACTIVE to tb_flags

2019-02-11 Thread Richard Henderson
When MTE is fully enabled, i.e. access to tags are enabled and tag checks affect the PE, then arrange to perform the check while stripping the TBI. The check is not yet implemented, just the plumbing to that point. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Clean TBI

[Qemu-devel] [PATCH v3 11/28] target/arm: Implement ADDG, SUBG instructions

2019-02-11 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Shift offset in translate; use extract32. --- target/arm/helper-a64.h| 2 ++ target/arm/internals.h | 4 +++ target/arm/mte_helper.c| 32 + target/arm/translate-a64.c | 71

[Qemu-devel] [PATCH v3 21/28] target/arm: Set PSTATE.TCO on exception entry

2019-02-11 Thread Richard Henderson
R0085 specifies that exception handlers begin with tag checks overridden. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Only set if MTE feature present. --- target/arm/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c

[Qemu-devel] [PATCH v3 20/28] target/arm: Implement data cache set allocation tags

2019-02-11 Thread Richard Henderson
This is DC GVA and DC GZVA. Signed-off-by: Richard Henderson --- v2: Use allocation_tag_mem + memset. v3: Require pre-cleaned addresses. --- target/arm/cpu.h | 4 +++- target/arm/helper-a64.h| 1 + target/arm/helper.c| 16 target/arm/mte_helper.c| 28

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-11 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 2/11/19 4:19 AM, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available.

[Qemu-devel] [PATCH 5/5] block/dirty-bitmaps: unify qmp_locked and user_locked calls

2019-02-11 Thread John Snow
These mean the same thing now. Unify them and rename the merged call bdrv_dirty_bitmap_busy to indicate semantically what we are describing, as well as help disambiguate from the various _locked and _unlocked versions of bitmap helpers that refer to mutex locks. --- block/dirty-bitmap.c

[Qemu-devel] [PATCH 3/5] block/dirty-bitmap: change semantics of enabled predicate

2019-02-11 Thread John Snow
Currently, enabled means something like "the status of the bitmap is ACTIVE." After this patch, it should mean exclusively: "This bitmap is recording guest writes, and is allowed to do so." In many places, this is how this predicate was already used. We'll allow users to call user_locked if

[Qemu-devel] [PATCH 4/5] block/dirty-bitmap: explicitly lock bitmaps with successors

2019-02-11 Thread John Snow
Instead of implying a locked status, make it explicit. Now, bitmaps in use by migration, NBD or backup operations are all treated the same way with the same code paths. --- block/dirty-bitmap.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/dirty-bitmap.c

[Qemu-devel] [PATCH v2 2/3] s390x/cpumodel: default enable mepoch for z14 and later

2019-02-11 Thread Collin Walling
Latest systems and host kernels support mepoch, which is a feature that was meant to be supported for z14 GA1 from the get-go. Let's copy it to the z14 GA1 default CPU model. Machines s390-ccw-virtio-3.1 and older will retain the old CPU models and will not provide this bit nor the extended PTFF

Re: [Qemu-devel] [RFC PATCH 3/4] spapr: Add NVDIMM device support

2019-02-11 Thread David Gibson
On Tue, Feb 05, 2019 at 11:26:27PM -0600, Shivaprasad G Bhat wrote: > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm > device interface in QEMU to support virtual NVDIMM devices for Power (May have > to re-look at this later). Create the required DT entries for the >

Re: [Qemu-devel] [PATCH] virtio-blk: set correct config size for the host driver

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 12:25:16PM +0800, Changpeng Liu wrote: > Commit caa1ee43 "vhost-user-blk: add discard/write zeroes features support" > introduced extra fields to existing struct virtio_blk_config, when > migration was executed from older QEMU version to current head, it > will break the

[Qemu-devel] [PATCH v3 03/28] target/arm: Add clear_pstate_bits, share gen_ss_advance

2019-02-11 Thread Richard Henderson
We do not need an out-of-line helper for clearing bits in pstate. While changing things, share the implementation of gen_ss_advance. Signed-off-by: Richard Henderson --- target/arm/helper.h| 2 -- target/arm/translate.h | 19 +++ target/arm/op_helper.c | 5

[Qemu-devel] [PATCH v3 01/28] target/arm: Split out arm_sctlr

2019-02-11 Thread Richard Henderson
Minimize the number of places that will need updating when the virtual host extensions are added. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 26 -- target/arm/helper.c | 8 ++-- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH v3 08/28] target/arm: Add helper_mte_check{1, 2}

2019-02-11 Thread Richard Henderson
Implements the rules of "PE generation of Checked and Unchecked accesses" which aren't already implied by TB_FLAGS_MTE_ACTIVE. Implements the rules of "PE handling of Tag Check Failure". Does not implement tag physical address space, so all operations reduce to unchecked so far. Signed-off-by:

[Qemu-devel] [PATCH v3 09/28] target/arm: Suppress tag check for sp+offset

2019-02-11 Thread Richard Henderson
R0078 specifies that base register, or base register plus immediate offset, is unchecked when the base register is SP. Signed-off-by: Richard Henderson --- v2: Include writeback addresses as checked. --- target/arm/translate-a64.c | 36 ++-- 1 file changed, 18

[Qemu-devel] [PATCH v3 12/28] target/arm: Implement the GMI instruction

2019-02-11 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 6 ++ target/arm/translate-a64.c | 6 ++ 3 files changed, 13 insertions(+) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index

[Qemu-devel] [PATCH v3 14/28] target/arm: Define arm_cpu_do_unaligned_access for CONFIG_USER_ONLY

2019-02-11 Thread Richard Henderson
We will need this to raise unaligned exceptions from user mode. Signed-off-by: Richard Henderson --- target/arm/op_helper.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index

[Qemu-devel] [PATCH v3 06/28] target/arm: Add MTE system registers

2019-02-11 Thread Richard Henderson
This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, RGSR_EL1, GCR_EL1, GMID_EL1, and PSTATE.TCO. Signed-off-by: Richard Henderson --- v3: Add GMID; add access_mte. --- target/arm/cpu.h | 5 +++ target/arm/internals.h | 6 target/arm/translate.h | 11 +++

Re: [Qemu-devel] [Bug 1814418] [NEW] persistent bitmap will be inconsistent when qemu crash,

2019-02-11 Thread John Snow
On 2/4/19 11:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 04.02.2019 17:55, Eric Blake wrote: >> On 2/2/19 11:52 PM, Cheng Chen wrote: >>> Public bug reported: >>> >>> Follow these steps to reappear the bug: >>> >>> 1. start qemu >>> 2. add persistent bitmap: '{ "execute":

[Qemu-devel] [PATCH v2 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

2019-02-11 Thread Collin Walling
The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent on the multiple-epoch facility (mepoch). Let's print a warning if these features are enabled without mepoch. While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down the s390_feature_groups list so it can be properly

[Qemu-devel] [PATCH v2 3/3] s390x/cpumodel: add z14 GA2 model

2019-02-11 Thread Collin Walling
Introduce the z14 GA2 cpu model for QEMU. There are no new features introduced with this model, and will inherit the same feature set as z14 GA1. Signed-off-by: Collin Walling Acked-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_models.c | 1 +

[Qemu-devel] [Bug 1808928] Re: Bitmap Extra data is not supported

2019-02-11 Thread John Snow
Hi, bitmap extensions have a field that allows us to attach extra/arbitrary data to them. It is not currently used by QEMU. If this field is set, it means something corrupted your qcow2. Please make a backup of your qcow2 file first (because attempting to repair a broken qcow2 can sometimes make

Re: [Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-11 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v3: Will you send a v4 based on Eric's comments or do you want to keep the series as it is? Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-11 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 01:24:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a new simple helper for a very often patter > around qemu_iovec_init_external, when we need simple qiov with only > one iov, initialized from external buffer. > > v3: > 01-02: tiny improvements,

[Qemu-devel] [PATCH] hostmem-file: reject invalid pmem file sizes

2019-02-11 Thread Stefan Hajnoczi
Guests started with NVDIMMs larger than the underlying host file produce confusing errors inside the guest. This happens because the guest accesses pages beyond the end of the file. Check the pmem file size on startup and print a clear error message if the size is invalid. Fixes:

Re: [Qemu-devel] [Qemu-block] [PULL 0/9] Block patches

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 11:42:14AM +, Peter Maydell wrote: > On Mon, 11 Feb 2019 at 05:50, Stefan Hajnoczi wrote: > > > > The following changes since commit e47f81b617684c4546af286d307b69014a83538a: > > > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > >

[Qemu-devel] [PULL 3/3] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev

2019-02-11 Thread Stefan Hajnoczi
From: Stefano Garzarella In several part we still using req->dev or VIRTIO_DEVICE(req->dev) when we have already defined s and vdev pointers: VirtIOBlock *s = req->dev; VirtIODevice *vdev = VIRTIO_DEVICE(s); Signed-off-by: Stefano Garzarella Reviewed-by: Liam Merwick Message-id:

Re: [Qemu-devel] [PATCH 4/5] target/hppa: fix sed conditions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > -f = (orig & 4) / 4; > - > -return do_log_cond(c * 2 + f, res); Given that this used to reference do_log_cond, and you've fixed do_log_cond, why is there any reason for a change here? r~

Re: [Qemu-devel] [PATCH 2/5] target/hppa: fix '

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > case 3: /* <= / >(N | Z / !N & !Z) */ > -cond = cond_make_0(TCG_COND_LE, res); > +tmp = tcg_temp_new(); > +tcg_gen_xor_reg(tmp, res, sv); > +cond = cond_make_0(TCG_COND_LE, tmp); > +tcg_temp_free(tmp);

[Qemu-devel] [PATCH v3 19/28] target/arm: Clean address for DC ZVA

2019-02-11 Thread Richard Henderson
This data access was forgotten in the previous patch. Fixes: 3a471103ac1823ba Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index b97af372f0..9e7afa571d

[Qemu-devel] [PATCH v3 02/28] target/arm: Split helper_msr_i_pstate into 3

2019-02-11 Thread Richard Henderson
The EL0+UMA check is unique to DAIF. While SPSel had avoided the check by nature of already checking EL >= 1, the other post v8.0 extensions to MSR (imm) allow EL0 and do not require UMA. Avoid the unconditional write to pc and use raise_exception_ra to unwind. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v3 18/28] target/arm: Implement the access tag cache flushes

2019-02-11 Thread Richard Henderson
Like the regular data cache flushes, these are nops within qemu. Signed-off-by: Richard Henderson --- target/arm/helper.c | 48 + 1 file changed, 48 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index f8e4e6f8ae..ed1b258497

Re: [Qemu-devel] [PATCH 1/5] target/hppa: move GETPC to HELPER() functions

2019-02-11 Thread Richard Henderson
On 2/11/19 10:19 AM, Sven Schnelle wrote: > When QEMU is compiled with -O0, these functions are inlined > which will cause a wrong restart address generated for the TB. > > Signed-off-by: Sven Schnelle > --- > target/hppa/op_helper.c | 16 ++-- > 1 file changed, 6 insertions(+), 10

Re: [Qemu-devel] [PATCH 3/4] mips_fulong2e: Dynamically generate SPD EEPROM data

2019-02-11 Thread Philippe Mathieu-Daudé
On 2/11/19 5:01 AM, BALATON Zoltan wrote: > The machine comes with 256M memory module by default but it's > upgradable so it could have different memory size. There was a TODO > comment to replace static SPD EEPROM data with dynamically generated > one to support this. Now that we have a function

Re: [Qemu-devel] [PATCH v2] pc-dimm: use same mechanism for [get|set]_addr

2019-02-11 Thread Wei Yang
On Mon, Feb 11, 2019 at 03:43:07PM +0100, Igor Mammedov wrote: >On Mon, 11 Feb 2019 14:46:29 +0800 >Wei Yang wrote: > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. >> >> Since we have already set up a property PC_DIMM_ADDR_PROP for this >> field and use this mechanism in

[Qemu-devel] [PATCH 0/5] dirty-bitmaps: deprecate @status field

2019-02-11 Thread John Snow
The current internal meanings of "locked", "user_locked", "qmp_locked", "frozen", "enabled", and "disabled" are all a little muddled. Deprecate the @status field in favor of two new booleans that carry very specific meanings. Then, rename and rework some of the internal semantics to help make the

Re: [Qemu-devel] virtio-blk io bar size changed

2019-02-11 Thread Liu, Changpeng
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, February 12, 2019 1:23 AM > To: Dr. David Alan Gilbert > Cc: qemu-devel@nongnu.org; Liu, Changpeng ; > stefa...@redhat.com; ldok...@redhat.com > Subject: Re: virtio-blk io bar size changed > > On

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: > > As far as I can see currently IOThread offloading is used only for block > > devices and all others are emulated by main thread. > > > > I expect that network

[Qemu-devel] [PULL 2/3] qemugdb/coroutine: fix arch_prctl has unknown return type

2019-02-11 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy qemu coroutine command results in following error output: Python Exception 'arch_prctl' has unknown return type; cast the call to its declared return type: Error occurred in Python command: 'arch_prctl' has unknown return type; cast the call to its declared

Re: [Qemu-devel] [RFC PATCH 4/4] spapr: Add Hcalls to support PAPR NVDIMM device

2019-02-11 Thread David Gibson
On Tue, Feb 05, 2019 at 11:26:41PM -0600, Shivaprasad G Bhat wrote: > This patch implements few of the necessary hcalls for the nvdimm support. > > PAPR semantics is such that each NVDIMM device is comprising of multiple > SCM(Storage Class Memory) blocks. The guest requests the hypervisor to

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 11:55:05AM +0800, Stefan Hajnoczi wrote: > On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: > > > As far as I can see currently IOThread offloading is used only for block > > > devices and

[Qemu-devel] [PULL 21/24] target/hppa: Rearrange log conditions

2019-02-11 Thread Richard Henderson
We will be fixing do_cond vs signed overflow, which requires that do_log_cond not rely on do_cond. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 56 +++-- 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 00/24] target/hppa patch queue

2019-02-11 Thread Richard Henderson
The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging (2019-02-11 17:04:57 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-hppa-20190211

[Qemu-devel] [PULL 02/24] target/hppa: Begin using scripts/decodetree.py

2019-02-11 Thread Richard Henderson
Convert the BREAK instruction to start. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 24 +++- target/hppa/Makefile.objs | 8 target/hppa/insns.decode | 24 3 files

[Qemu-devel] [PULL 05/24] target/hppa: Unify specializations of OR

2019-02-11 Thread Richard Henderson
With decodetree.py, the specializations would conflict so we must have a single entry point for all variants of OR. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 108 ++-- 1 file changed, 59

[Qemu-devel] [PULL 16/24] target/hppa: Convert halt/reset insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 49 target/hppa/insns.decode | 5 2 files changed, 20 insertions(+), 34 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 04/24] target/hppa: Convert remainder of system insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 99 ++-- target/hppa/insns.decode | 12 + 2 files changed, 56 insertions(+), 55 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 18/24] target/hppa: Convert fp operate insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 791 --- target/hppa/insns.decode | 175 + 2 files changed, 507 insertions(+), 459 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PATCH v3 0/2] target/s390x: Implement STCK et al for CONFIG_USER_ONLY

2019-02-11 Thread Richard Henderson
Changes since v2: * Fix botched subject line, include r-b tags. Changes since v1: * Move more of hw/s390x/tod.h to a new header. * Use time2tod. r~ Richard Henderson (2): target/s390x: Split out s390-tod.h target/s390x: Implement STCK et al for CONFIG_USER_ONLY

[Qemu-devel] [PATCH v3 2/2] target/s390x: Implement STCK et al for CONFIG_USER_ONLY

2019-02-11 Thread Richard Henderson
This is a non-privileged instruction that was only implemented for system mode. However, the stck instruction is used by glibc, so this was causing SIGILL for programs run under debian stretch. Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson ---

Re: [Qemu-devel] [RFC v1 2/3] intel_iommu: add 256 bits qi_desc support

2019-02-11 Thread Peter Xu
On Wed, Jan 30, 2019 at 01:09:12PM +0800, Yi Sun wrote: > From: "Liu, Yi L" > > Per Intel(R) VT-d 3.0, the qi_desc is 256 bits in Scalable > Mode. This patch adds emulation of 256bits qi_desc. > > [Yi Sun is co-developer to rebase and refine the patch.] > Signed-off-by: Yi Sun > Signed-off-by:

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/11 下午9:40, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main thread. I expect that network devices can also benefit from processing in separate thread but I couldn't find any recent work in this

Re: [Qemu-devel] [PATCH 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-11 Thread Cédric Le Goater
On 2/12/19 2:01 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:44PM +0100, Cédric Le Goater wrote: >> The activation of the KVM IRQ device depends on the interrupt mode >> chosen at CAS time by the machine and some methods used at reset or by >> the migration need to be protected. >> >>

[Qemu-devel] [PATCH] linux-user: Add AT_PLATFORM for arm

2019-02-11 Thread Richard Henderson
Fixes: https://bugs.launchpad.net/bugs/1813034 Signed-off-by: Richard Henderson --- linux-user/elfload.c | 29 + 1 file changed, 29 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 775a36ccdd..dde640a2ea 100644 --- a/linux-user/elfload.c

[Qemu-devel] [PULL 09/24] target/hppa: Convert fp multiply-add

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 69 +++- target/hppa/insns.decode | 12 +++ 2 files changed, 52 insertions(+), 29 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 06/24] target/hppa: Convert memory management insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 162 --- target/hppa/insns.decode | 38 + 2 files changed, 89 insertions(+), 111 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 07/24] target/hppa: Convert arithmetic/logical insns

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 326 ++- target/hppa/insns.decode | 42 + 2 files changed, 195 insertions(+), 173 deletions(-) diff --git a/target/hppa/translate.c

[Qemu-devel] [PULL 24/24] hw/hppa: forward requests to CPU HPA

2019-02-11 Thread Richard Henderson
From: Sven Schnelle HP-UX 10.20 uses busmaster writes to the CPU EIR to signal interrupts from the SCSI constroller. (Similar to what is known as MSI on x86) Signed-off-by: Sven Schnelle Message-Id: <20190211192039.5457-1-sv...@stackframe.org> Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL 20/24] target/hppa: move GETPC to HELPER() functions

2019-02-11 Thread Richard Henderson
From: Sven Schnelle When QEMU is compiled with -O0, these functions are inlined which will cause a wrong restart address generated for the TB. Signed-off-by: Sven Schnelle Message-Id: <20190211181907.2219-2-sv...@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/op_helper.c |

[Qemu-devel] [PULL 01/24] target/hppa: Use DisasContextBase.is_jmp

2019-02-11 Thread Richard Henderson
Instead of returning DisasJumpType, immediately store it. Return true in preparation for conversion to the decodetree script. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 1011 --- 1 file

[Qemu-devel] [PULL 12/24] target/hppa: Convert direct and indirect branches

2019-02-11 Thread Richard Henderson
Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 131 +-- target/hppa/insns.decode | 34 +- 2 files changed, 63 insertions(+), 102 deletions(-) diff --git a/target/hppa/translate.c

Re: [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi

2019-02-11 Thread Michael S. Tsirkin
On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote: > On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote: > >There are several functions/variable which are not used anymore. > > > >This serials just remove those without functional change. > > > >v3: add ack and repost in a new thread >

Re: [Qemu-devel] [PATCH 03/19] xive: extend the XiveRouter get_tctx() method with the page offset

2019-02-11 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:09AM +0100, Cédric Le Goater wrote: > The PowerNV machine can perform indirect loads and stores on the TIMA > on behalf of another CPU. The PIR of the CPU is controlled by a set of > 4 registers, one per TIMA page. To know which page is being accessed, > we need to

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/11 下午10:52, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main thread. I expect that network devices can also benefit from

Re: [Qemu-devel] Is IOThread for virtio-net a good idea?

2019-02-11 Thread Jason Wang
On 2019/2/12 上午11:55, Stefan Hajnoczi wrote: On Mon, Feb 11, 2019 at 09:52:01AM -0500, Michael S. Tsirkin wrote: On Mon, Feb 11, 2019 at 04:40:44PM +0300, Anton Kuchin wrote: As far as I can see currently IOThread offloading is used only for block devices and all others are emulated by main

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-11 Thread Cédric Le Goater
On 2/12/19 1:22 AM, David Gibson wrote: > On Fri, Feb 08, 2019 at 08:12:12AM +0100, Cédric Le Goater wrote: >> On 2/8/19 6:36 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: When the thread interrupt management state is retrieved from the KVM

Re: [Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist

2019-02-11 Thread Yuval Shaia
On Mon, Feb 11, 2019 at 10:10:56AM +0200, Marcel Apfelbaum wrote: > > > On 2/10/19 12:45 PM, Yuval Shaia wrote: > > To make code more readable move handling of locked list to a generic > > functions. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_backend.c | 20

[Qemu-devel] [PATCH v2 2/2] linux-user: Fix ELF_PLATFORM for aarch64_be-linux-user

2019-02-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/elfload.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index d796d51ec6..5aa0628ae9 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -537,7 +537,11 @@ static

<    1   2   3   4   >