[Qemu-devel] [PATCH v2 06/14] crypto: Change the qcrypto_random_bytes buffer type to void*

2019-03-13 Thread Richard Henderson
Using uint8_t* merely requires useless casts for use with other types to be filled with randomness. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- include/crypto/random.h | 2 +- crypto/random-gcrypt.c | 2 +- crypto/random-gnutls.c | 2 +- crypto/random-platform.c | 4 ++--

[Qemu-devel] [PATCH v2 12/14] linux-user/aarch64: Use qemu_getrandom for arm_init_pauth_key

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand * 3. Cc: Laurent Vivier Cc: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/linux-user/aarch64/cpu_loop.c

[Qemu-devel] [PATCH v2 09/14] util: Use qcrypto_random_bytes for qemu_getrandom

2019-03-13 Thread Richard Henderson
When not requesting deterministic bytes, use our existing crypto. Signed-off-by: Richard Henderson --- util/random.c | 61 --- 1 file changed, 48 insertions(+), 13 deletions(-) diff --git a/util/random.c b/util/random.c index

[Qemu-devel] [PATCH v2 04/14] crypto: Use O_CLOEXEC in qcrypto_random_init

2019-03-13 Thread Richard Henderson
Avoids leaking the /dev/urandom fd into any child processes. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/random-platform.c b/crypto/random-platform.c index

[Qemu-devel] [PATCH v2 08/14] util: Add qemu_getrandom and support functions

2019-03-13 Thread Richard Henderson
Initialize the system from system and linux-user arguments. Propagate deterministic seeds when creating new cpu threads. Signed-off-by: Richard Henderson --- include/qemu/random.h | 58 +++ include/qom/cpu.h | 1 + cpus.c| 9 ++

[Qemu-devel] [PATCH v2 05/14] crypto: Use getrandom for qcrypto_random_bytes

2019-03-13 Thread Richard Henderson
Prefer it to direct use of /dev/urandom. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 21 + configure| 18 +- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/crypto/random-platform.c

[Qemu-devel] [PATCH v2 14/14] target/arm: Implement ARMv8.5-RNG

2019-03-13 Thread Richard Henderson
Cc: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 32 3 files changed, 38 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 5f23c62132..aaa9e02e78 100644

[Qemu-devel] [PATCH v2 01/14] crypto: Merge crypto-obj-y into libqemuutil.a

2019-03-13 Thread Richard Henderson
We will shortly need this in the user-only binaries, so drop the split into system and tools binaries. This also means that crypto-aes-obj-y can be merged back into crypto-obj-y. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- Makefile | 12 +--- Makefile.objs

[Qemu-devel] [PATCH v2 10/14] linux-user: Call qcrypto_init if not using -seed

2019-03-13 Thread Richard Henderson
This is required before using qcrypto_random_bytes by way of qemu_getrandom. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/main.c | 8 1 file changed, 8 insertions(+) diff --git a/linux-user/main.c b/linux-user/main.c index 9682e81610..192bf759b8 100644 ---

[Qemu-devel] [PATCH v2 11/14] linux-user: Use qemu_getrandom for AT_RANDOM

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand * 16. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/elfload.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index c1a26021f8..f33bf4fb85 100644 ---

[Qemu-devel] [PATCH v2 00/14] Add qemu_getrandom and ARMv8.5-RNG

2019-03-13 Thread Richard Henderson
Changes since v1: * Build crypto-obj-y for linux-user as well. * Several patches to tidy crypto/random-platform.c. * Use getrandom(2) in crypto/random-platform.c. * Use qcrypto_random_bytes in ui/vnc.c. * In qemu_getrandom: - Use g_rand_int instead of srand48. - Use

[Qemu-devel] [PATCH v2 13/14] linux-user: Remove srand call

2019-03-13 Thread Richard Henderson
We no longer use rand() within linux-user. Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 192bf759b8..11a37f7f9b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@

[Qemu-devel] [PATCH v2 02/14] crypto: Reverse code blocks in random-platform.c

2019-03-13 Thread Richard Henderson
Use #ifdef _WIN32 instead of #ifndef _WIN32. This will make other tests easier to sequence. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH v2 03/14] crypto: Do not fail for EINTR during qcrypto_random_bytes

2019-03-13 Thread Richard Henderson
We can always get EINTR for read; /dev/urandom is no exception. Clean up return paths and avoid unnecessary goto. Cc: Daniel P. Berrangé Signed-off-by: Richard Henderson --- crypto/random-platform.c | 33 + 1 file changed, 13 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand, plus some useless floating point arithmetic. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is no need for deterministic results for this interface. --- ui/vnc.c | 8

[Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand, plus some useless floating point arithmetic. Signed-off-by: Richard Henderson --- ui/vnc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 1871422e1d..cbdfa37c52 100644 --- a/ui/vnc.c +++

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix SMMUv3 GSIV values

2019-03-13 Thread Shannon Zhao
On 2019/3/12 17:10, Eric Auger wrote: The GSIV numbers of the SPI based interrupts is not correct as ARM_SPI_BASE was not added to the irqmap[VIRT_SMMU] value. So this may collide with VIRTIO_MMIO irq window. Signed-off-by: Eric Auger Reviewed-by: Shannon Zhao ---

Re: [Qemu-devel] [PATCH v13 19/25] replay: add BH oneshot event for block layer

2019-03-13 Thread Pavel Dovgalyuk
Kevin, what about this one? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > Sent: Wednesday, March 06, 2019 5:01 PM > To: 'Kevin Wolf' > Cc: 'Pavel Dovgalyuk'; qemu-devel@nongnu.org; peter.mayd...@linaro.org; > war2jor...@live.com; >

[Qemu-devel] [PATCH for-4.1 1/7] util: Add qemu_getrandom and support functions

2019-03-13 Thread Richard Henderson
Initialize the system from system and linux-user arguments. Propagate deterministic seeds when creating new cpu threads. Signed-off-by: Richard Henderson --- include/qemu/random.h | 58 + include/qom/cpu.h | 1 + cpus.c| 9 +

[Qemu-devel] [PATCH for-4.1 3/7] linux-user: Use qemu_getrandom for AT_RANDOM

2019-03-13 Thread Richard Henderson
Use a better interface for random numbers than rand * 16. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index c1a26021f8..f33bf4fb85 100644 ---

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Cédric Le Goater
On 3/13/19 4:35 AM, David Gibson wrote: > On Tue, Mar 12, 2019 at 06:36:05PM +0100, Markus Armbruster wrote: >> Dear board code maintainers, >> >> This is a (rather late) follow-up to the last QEMU summit. Minutes[*]: >> >> * Deprecating unmaintained features (devices, targets, backends) in QEMU

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Bastian Koppelmann
On 3/12/19 6:36 PM, Markus Armbruster wrote: [snip] = hw/tricore/tricore_testboard.c = Bastian Koppelmann (maintainer:TriCore) I created a patchset for tcg tests for this board (https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05828.html) but somehow it got lost in my

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Markus Armbruster
Palmer Dabbelt writes: > Is "maintainer" a higher level of support than "supporter"? If that's > the case then I'm happy signing up to be a maintainer of these, as > part of by job at SiFive is to make sure these work. Sorry, I'm not > entirely sure how this all works -- from reading the top

[Qemu-devel] [PATCH for-4.1 5/7] linux-user: Remove srand call

2019-03-13 Thread Richard Henderson
We no longer use rand() within linux-user. Signed-off-by: Richard Henderson --- linux-user/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 37300230f5..7a40a14c6a 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -619,8 +619,6 @@

[Qemu-devel] [PATCH for-4.1 7/7] target/arm: Implement ARMv8.5-RNG

2019-03-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h| 5 + target/arm/cpu64.c | 1 + target/arm/helper.c | 32 3 files changed, 38 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 5f23c62132..aaa9e02e78 100644 ---

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190313062630.30568-1-richard.hender...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190313062630.30568-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190313062630.30568-1-richard.hender...@linaro.org Subject: [Qemu-devel]

[Qemu-devel] [PATCH] e1000: Delay flush queue when receive RCTL

2019-03-13 Thread yuchenlin--- via Qemu-devel
From: yuchenlin Due to too early RCT0 interrput, win10x32 may hang on booting. This problem can be reproduced by doing power cycle on win10x32 guest. In our environment, we have 10 win10x32 and stress power cycle. The problem will happen about 20 rounds. Below shows some log with comment: The

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Palmer Dabbelt
On Tue, 12 Mar 2019 10:36:05 PDT (-0700), arm...@redhat.com wrote: Machines with no maintainer, but at least one supporter: [...] = hw/riscv/sifive_e.c = Palmer Dabbelt (supporter:RISC-V) Alistair Francis (supporter:RISC-V) Sagar Karandikar (supporter:RISC-V) Bastian

Re: [Qemu-devel] [PATCH] ppc/pnv: update skiboot to commit 261ca8e779e5.

2019-03-13 Thread Cédric Le Goater
On 3/13/19 5:23 AM, David Gibson wrote: > On Sun, Mar 10, 2019 at 06:53:37PM +0100, Cédric Le Goater wrote: >> It includes better support for POWER9 processor and the QEMU platform. >> DD1.0 workarounds have been removed which simplifies a bit the XIVE >> PowerNV model. >> >> Built from submodule.

[Qemu-devel] [PULL 2/2] curses: add option to specify VGA font encoding

2019-03-13 Thread Gerd Hoffmann
From: Samuel Thibault This uses iconv to convert glyphs from the specified VGA font encoding to unicode, and makes use of cchar_t instead of chtype when using ncursesw, which allows to store all wide char as well as the WACS values. The default charset is made CP437 since that is the charset of

[Qemu-devel] [PULL 1/2] iconv: detect and make curses depend on it

2019-03-13 Thread Gerd Hoffmann
From: Samuel Thibault curses will use it for proper wide output support. Signed-off-by: Samuel Thibault Message-Id: <20190311135127.2229-2-samuel.thiba...@ens-lyon.org> Signed-off-by: Gerd Hoffmann --- configure| 55 vl.c |

Re: [Qemu-devel] [PATCH v3 09/20] Boot Linux Console Test: update the x86_64 kernel

2019-03-13 Thread Gerd Hoffmann
Hi, > > I'd like automate some of the graphics testing. For starters boot > > guest, run test utility to display something, take a screendump, check > > whenever it actually shows what I expect it to show. Maybe later run > > test suites like https://cgit.freedesktop.org/drm/igt-gpu-tools/. >

Re: [Qemu-devel] [PATCH] spapr: Correctly set LPCR[GTSE] in H_REGISTER_PROCESS_TABLE

2019-03-13 Thread Cédric Le Goater
On 3/13/19 4:20 AM, David Gibson wrote: > 176dccee "target/ppc/spapr: Clear partition table entry when allocating > hash table" reworked the H_REGISTER_PROCESS_TABLE hypercall, but > unfortunately due to a small error no longer correctly sets the LPCR[GTSE] > bit which allows the guest to directly

[Qemu-devel] [PULL 0/2] Ui 20190313 patches

2019-03-13 Thread Gerd Hoffmann
The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-03-11 18:26:37 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190313-pull-request for you

Re: [Qemu-devel] [PATCH for-4.1 6/7] ui/vnc: Use qemu_getrandom for make_challenge

2019-03-13 Thread Gerd Hoffmann
On Tue, Mar 12, 2019 at 11:26:29PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > -int i; > - > -srand(time(NULL)+getpid()+getpid()*987654+rand()); > - > -for (i = 0 ; i < sizeof(vs->challenge) ;

Re: [Qemu-devel] [PATCH for-4.1 1/7] util: Add qemu_getrandom and support functions

2019-03-13 Thread Laurent Vivier
On 13/03/2019 07:26, Richard Henderson wrote: Initialize the system from system and linux-user arguments. Propagate deterministic seeds when creating new cpu threads. Signed-off-by: Richard Henderson --- include/qemu/random.h | 58 + include/qom/cpu.h |

[Qemu-devel] [PATCH for-4.1 2/7] util: Use getrandom for qemu_getrandom if available

2019-03-13 Thread Richard Henderson
We only allow access to the "urandom" side of the interface, and using -seed forces the use of the deterministic algorithm. Signed-off-by: Richard Henderson --- util/random.c | 78 ++- configure | 18 +++- 2 files changed, 88

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

2019-03-13 Thread Gerd Hoffmann
> > And why host endianness? Everything else is little endian ... > > Hmm, I am not sure we correctly handle endianness in > virtio_input_get_config(). virtio_input_add_config() do not use LE. > Gerd, have you checked cross-endian scenarios? Sure. BE ppc tcg guest on LE x86 host works fine.

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Paolo Bonzini
On 13/03/19 08:06, Palmer Dabbelt wrote: > > Is "maintainer" a higher level of support than "supporter"?  If that's > the case then I'm happy signing up to be a maintainer of these, as part > of by job at SiFive is to make sure these work.  Sorry, I'm not entirely > sure how this all works --

[Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Recent commit cda4aa9a5a0 moved block backend creation before machine property evaluation. This broke qemu-iotests 055. Turns out we need to create the migration object before block backends, so block backends can add migration blockers. Fix by calling migration_object_init() earlier, right

[Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Recent commit cda4aa9a5a0 moved block backend creation before machine property evaluation. This broke qemu-iotests 055. Turns out we need to create the migration object before block backends, so block backends can add migration blockers. Fix by calling migration_object_init() earlier, right

Re: [Qemu-devel] [PATCH] vl: Fix to create migration object before block backends again

2019-03-13 Thread Markus Armbruster
Butterfingers... Please use Message-Id: <20190313084330.16015-1-arm...@redhat.com> and ignore this one.

[Qemu-devel] [PATCH 1/4] hw/rdma: Fix broken paths to docs/devel/tracing.txt

2019-03-13 Thread Kamal Heib
The tracing.txt file is under "docs/devel" and not "docs". Signed-off-by: Kamal Heib --- hw/rdma/trace-events | 2 +- hw/rdma/vmw/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rdma/trace-events b/hw/rdma/trace-events index 0fad56c88206..12868d8a8737

[Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-13 Thread Daniel P . Berrangé
The Mesa library tries to set process affinity on some of its threads in order to optimize its performance. Currently this results in QEMU being immediately terminated when seccomp is enabled. Mesa doesn't consider failure of the process affinity settings to be fatal to its operation, but our

[Qemu-devel] [PATCH v9 18/29] target/riscv: Convert quadrant 2 of RVXC insns to decodetree

2019-03-13 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v8 -> v9: - _flwsp_ldsp -> _ldsp - _fswsp_sdsp -> _sdsp target/riscv/insn16.decode | 31 target/riscv/insn_trans/trans_rvc.inc.c | 101

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Philippe Mathieu-Daudé
On 3/13/19 11:11 AM, Laszlo Ersek wrote: > On 03/13/19 10:43, Laszlo Ersek wrote: >> On 03/10/19 01:47, Philippe Mathieu-Daudé wrote: >>> The Edk2Crypto object is used to hold configuration values specific >>> to EDK2. >>> >>> The edk2_add_host_crypto_policy() function loads crypto policies >>>

Re: [Qemu-devel] [Qemu-block] [PATCH v3] file-posix: add drop-cache=on|off option

2019-03-13 Thread Stefan Hajnoczi
On Thu, Mar 07, 2019 at 04:49:41PM +, Stefan Hajnoczi wrote: > Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix: > implement bdrv_co_invalidate_cache() on Linux") introduced page cache > invalidation so that cache.direct=off live migration is safe on Linux. > > The

Re: [Qemu-devel] [PATCH v2 08/11] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-03-13 Thread Auger Eric
Hi Shameer, On 3/12/19 5:56 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 12 March 2019 16:48 >> To: Shameerali Kolothum Thodi ; >> Igor Mammedov >> Cc: peter.mayd...@linaro.org; sa...@linux.intel.com;

Re: [Qemu-devel] [PATCH] intel-iommu: optimize nodmar memory regions

2019-03-13 Thread Sergio Lopez
Peter Xu writes: > Previously we have per-device system memory aliases when DMAR is > disabled by the system. It will slow the system down if there are > lots of devices especially when DMAR is disabled, because each of the > aliased system address space will contain O(N) slots, and rendering

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: use PCIE_MMCFG_BUS to retrieve end_bus_number

2019-03-13 Thread Igor Mammedov
On Tue, 12 Mar 2019 15:49:53 +0800 Wei Yang wrote: > This is more proper to use PCIE_MMCFG_BUS to retrieve end_bus_number. > > Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov > --- > hw/arm/virt-acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3] mirror: Confirm we're quiesced only if the job is paused or cancelled

2019-03-13 Thread Kevin Wolf
Am 08.03.2019 um 16:48 hat Sergio Lopez geschrieben: > While child_job_drained_begin() calls to job_pause(), the job doesn't > actually transition between states until it runs again and reaches a > pause point. This means bdrv_drained_begin() may return with some jobs > using the node still having

[Qemu-devel] [PULL 00/10] Migration patches

2019-03-13 Thread Juan Quintela
The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into staging (2019-03-12 21:06:26 +) are available in the Git repository at: https://github.com/juanquintela/qemu.git

[Qemu-devel] [PULL 02/10] multifd: Rename "size" member to pages_alloc

2019-03-13 Thread Juan Quintela
It really indicates what is the number of allocated pages for one packet. Once there rename "used" to "pages_used". Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 23 --- 1 file changed, 12

[Qemu-devel] [PATCH 2/7] coroutine: add x86 specific coroutine backend

2019-03-13 Thread Paolo Bonzini
This backend is faster (100ns vs 150ns per switch on my laptop), but especially it will be possible to add CET support to it. Unlike the ucontext backend, it does not save any register state; all registers are clobbered in the CO_SWITCH asm, and as a result the compiler automatically

[Qemu-devel] [PATCH 7/7] coroutine-x86: add CET shadow stack support

2019-03-13 Thread Paolo Bonzini
Note that the ABI is not yet part of Linux, so this patch is kinda experimental. Signed-off-by: Paolo Bonzini --- configure| 14 util/Makefile.objs | 1 - util/coroutine-x86.c | 80 ++-- 3 files changed, 92 insertions(+), 3

[Qemu-devel] [PATCH 1/7] qemugdb: allow adding support for other coroutine backends

2019-03-13 Thread Paolo Bonzini
Split the jmpbuf access to a separate module and dispatch based on which CoroutineXYZ type is defined. Signed-off-by: Paolo Bonzini --- scripts/qemugdb/coroutine.py | 106 -- scripts/qemugdb/coroutine_ucontext.py | 69 + 2 files changed, 100

[Qemu-devel] [RFC PATCH for-4.1 0/7] CET support

2019-03-13 Thread Paolo Bonzini
These patches add support for control flow protection, and as a bonus while no one actually has machines that support CET, a faster x86-specific coroutine backend. I have tested the first six; I cannot yet test the seventh because my CET machine has an old kernel without ARCH_X86_CET_ALLOC_SHSTK

[Qemu-devel] [PATCH 4/4] hw/pvrdma: Fix zero-initialization of resp in {query/modify}_qp

2019-03-13 Thread Kamal Heib
Make sure to zero-initialize only the pvrdma_cmd_query_qp_resp and not the whole pvrdma_cmd_resp for query_qp, in modify_qp the resp isn't used so remove it. Signed-off-by: Kamal Heib --- hw/rdma/vmw/pvrdma_cmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-13 Thread Cornelia Huck
On Tue, 12 Mar 2019 18:36:05 +0100 Markus Armbruster wrote: (...) > I gathered the machine types, mapped them to source files, which I fed > to get_maintainer.pl. Results are appended. If you're cc'ed, > MAINTAINERS fingers you for at least one machine type's source file. > Please tell us for

Re: [Qemu-devel] [PATCH 1/4] hw/rdma: Fix broken paths to docs/devel/tracing.txt

2019-03-13 Thread Yuval Shaia
On Wed, Mar 13, 2019 at 10:46:45AM +0200, Kamal Heib wrote: > The tracing.txt file is under "docs/devel" and not "docs". > > Signed-off-by: Kamal Heib > --- > hw/rdma/trace-events | 2 +- > hw/rdma/vmw/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Laszlo Ersek
On 03/11/19 19:27, Philippe Mathieu-Daudé wrote: > On 3/11/19 8:26 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> The Edk2Crypto object is used to hold configuration values specific >>> to EDK2. >>> >>> The edk2_add_host_crypto_policy() function loads crypto policies >>>

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-13 Thread Laszlo Ersek
(it's easiest if I follow up under Markus's review) On 03/11/19 08:15, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Add a function to read the full content of file on the host, and add >> a new 'file' name item to the fw_cfg device. >> >> Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field

2019-03-13 Thread Juan Quintela
Eric Blake wrote: > On 3/7/19 6:28 AM, Juan Quintela wrote: >> "Dr. David Alan Gilbert" wrote: >>> * Juan Quintela (quint...@redhat.com) wrote: We need to send this field when we add compression support. As we are still on x- stage, we can do this kind of changes.

Re: [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU

2019-03-13 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 08:30:02PM +0100, Laszlo Ersek wrote: > On 03/12/19 16:59, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2019 at 04:40:45PM +0100, Laszlo Ersek wrote: > >> On 03/11/19 11:35, Daniel P. Berrangé wrote: > >>> On Sun, Mar 10, 2019 at 12:21:55PM +0100, Philippe Mathieu-Daudé

Re: [Qemu-devel] [PULL 00/11] target/hppa patch queue

2019-03-13 Thread Peter Maydell
On Tue, 12 Mar 2019 at 16:19, Richard Henderson wrote: > > The following changes since commit 46316f1dfffc6be72e94e89f7b0e9162e7dcdcf1: > > Merge remote-tracking branch > 'remotes/awilliam/tags/vfio-updates-20190311.0' into staging (2019-03-12 > 13:37:29 +) > > are available in the Git

[Qemu-devel] [PULL 05/10] multifd: Be flexible about packet size

2019-03-13 Thread Juan Quintela
This way we can change the packet size in the future and everything will work. We choose an arbitrary big number (100 times configured size) as a limit about how big we will reallocate. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela ---

Re: [Qemu-devel] [PATCH 4/4] hw/pvrdma: Fix zero-initialization of resp in {query/modify}_qp

2019-03-13 Thread Yuval Shaia
On Wed, Mar 13, 2019 at 10:46:48AM +0200, Kamal Heib wrote: > Make sure to zero-initialize only the pvrdma_cmd_query_qp_resp and not > the whole pvrdma_cmd_resp for query_qp, in modify_qp the resp isn't used > so remove it. > > Signed-off-by: Kamal Heib > --- > hw/rdma/vmw/pvrdma_cmd.c | 4 +---

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

2019-03-13 Thread Marc-André Lureau
Hi On Wed, Mar 13, 2019 at 7:26 AM Gerd Hoffmann wrote: > > > > And why host endianness? Everything else is little endian ... > > > > Hmm, I am not sure we correctly handle endianness in > > virtio_input_get_config(). virtio_input_add_config() do not use LE. > > Gerd, have you checked

Re: [Qemu-devel] [RFC PATCH 1/3] hw/arm/virt-acpi-build: use acpi_get_mcfg() to calculate bus number

2019-03-13 Thread Igor Mammedov
On Wed, 13 Mar 2019 12:42:51 +0800 Wei Yang wrote: > To build MCFG, two information is necessary: > > * bus number > * base address > > Abstract these two information to AcpiMcfgInfo so that build_mcfg and > build_mcfg_q35 will have the same declaration. > > Signed-off-by: Wei Yang >

Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}

2019-03-13 Thread Eric Blake
On 3/13/19 3:46 AM, Kamal Heib wrote: > Signed-off-by: Kamal Heib > --- > hw/rdma/rdma_backend.c | 18 +- > hw/rdma/vmw/pvrdma_cmd.c| 2 +- > hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- > 3 files changed, 11 insertions(+), 11 deletions(-) {0} is standard C (but some versions

[Qemu-devel] [PATCH] slirp: clarify license of slirp as BSD-3

2019-03-13 Thread Marc-André Lureau
In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp/

Re: [Qemu-devel] [PATCH 2/4] hw/rdma: Remove unused parameter from rdma_poll_cq()

2019-03-13 Thread Yuval Shaia
On Wed, Mar 13, 2019 at 10:46:46AM +0200, Kamal Heib wrote: > The 'rdma_dev_res' parameter is not used in rdma_poll_cq(), so remove it. > > Signed-off-by: Kamal Heib > --- > hw/rdma/rdma_backend.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-13 Thread Laszlo Ersek
On 03/13/19 10:29, Laszlo Ersek wrote: > (it's easiest if I follow up under Markus's review) > > On 03/11/19 08:15, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Add a function to read the full content of file on the host, and add >>> a new 'file' name item to the fw_cfg

[Qemu-devel] [PATCH v9 00/29] target/riscv: Convert to decodetree

2019-03-13 Thread Bastian Koppelmann
Hi, this has just a bunch compile fixes caused by patches 17 and 18. So I only resend these patches. full tree is available at https://github.com/bkoppelmann/qemu/tree/riscv-dt-v9 Bastian Koppelmann (29): target/riscv: Activate decodetree and implemnt LUI & AUIPC target/riscv: Convert RVXI

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Laszlo Ersek
On 03/13/19 11:11, Laszlo Ersek wrote: > Again I think this would follow the pattern from vmgenid. And then I'd agree that we should dedicate a separate file (perhaps even a separate directory) to the new class. (I understand I keep mixing up "object" with "device" -- sorry about that. I hope

Re: [Qemu-devel] [PATCH v4 13/15] s390-bios: Use control unit type to determine boot method

2019-03-13 Thread Cornelia Huck
On Mon, 11 Mar 2019 11:21:31 -0400 "Jason J. Herne" wrote: > The boot method is different depending on which device type we are > booting from. Let's examine the control unit type to determine if we're > a virtio device. We'll eventually add a case to check for a real dasd device > here as well.

[Qemu-devel] [PULL 08/10] multifd: Drop x-

2019-03-13 Thread Juan Quintela
We make it supported from now on. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- hmp.c | 10 +- migration/migration.c | 26 +- qapi/migration.json | 34 +- 3

[Qemu-devel] [Bug 1819649] Re: Win10 Preview Build 18351 - no input

2019-03-13 Thread Norbert Federa
Update: Bug is still present with yesterday's released Windows 10 19H1 Insider Preview Build 18356 x64. The x86 version still works fine however. I guess this will soon get urgent since Microsoft will release Windows 1903 sometime in March/April. -- You received this bug notification because

Re: [Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-13 Thread Marc-André Lureau
Hi On Wed, Mar 13, 2019 at 10:49 AM Daniel P. Berrangé wrote: > > The Mesa library tries to set process affinity on some of its threads in > order to optimize its performance. Currently this results in QEMU being > immediately terminated when seccomp is enabled. > > Mesa doesn't consider failure

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-13 Thread Igor Mammedov
On Wed, 13 Mar 2019 12:42:53 +0800 Wei Yang wrote: > Now we have two identical build_mcfg function. > > Extract them to aml-build.c. > > Signed-off-by: Wei Yang > --- > hw/acpi/aml-build.c | 30 ++ > hw/arm/virt-acpi-build.c| 16 >

Re: [Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-13 Thread Marc-André Lureau
Hi On Wed, Mar 13, 2019 at 10:49 AM Daniel P. Berrangé wrote: > > The Mesa library tries to set process affinity on some of its threads in > order to optimize its performance. Currently this results in QEMU being > immediately terminated when seccomp is enabled. > > Mesa doesn't consider failure

Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}

2019-03-13 Thread Kamal Heib
On 3/13/19 2:25 PM, Eric Blake wrote: > On 3/13/19 3:46 AM, Kamal Heib wrote: >> Signed-off-by: Kamal Heib >> --- >> hw/rdma/rdma_backend.c | 18 +- >> hw/rdma/vmw/pvrdma_cmd.c| 2 +- >> hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- >> 3 files changed, 11 insertions(+), 11

[Qemu-devel] [PATCH 3/7] configure: add CET support

2019-03-13 Thread Paolo Bonzini
CET requires object files to note which features are supported. The linker will merge them to the set of features that are supported by all object files. The compiler creates these notes when the -fcf-protection option is passed, but we have to blacklist some object files that only support a

[Qemu-devel] [PATCH 4/7] tcg: add tcg_out_start

2019-03-13 Thread Paolo Bonzini
This function is called at the beginning of any translation block. We will use it to emit ENDBR32 or ENDBR64 annotations for x86 CET. Signed-off-by: Paolo Bonzini --- tcg/aarch64/tcg-target.inc.c | 4 tcg/arm/tcg-target.inc.c | 4 tcg/i386/tcg-target.inc.c| 4

[Qemu-devel] [PATCH 6/7] linux-user: add IBT support to x86 safe-syscall.S

2019-03-13 Thread Paolo Bonzini
Because safe-syscall.S does not go through the C compiler, the .note.gnu.property note has to be added manually. Safe syscalls do not involve any indirect branch or stack unwinding, so they are trivially safe for IBT or shadow stacks. Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] [PULL 05/21] migration: Introduce ignore-shared capability

2019-03-13 Thread Juan Quintela
Markus Armbruster wrote: > "Dr. David Alan Gilbert (git)" writes: > >> From: Yury Kotov >> >> We want to use local migration to update QEMU for running guests. >> In this case we don't need to migrate shared (file backed) RAM. >> So, add a capability to ignore such blocks during live migration.

Re: [Qemu-devel] [PATCH v4 0/4] fw_cfg: Add edk2_add_host_crypto_policy()

2019-03-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi, > > This series consists of: > - add fw_cfg_add_file_from_host() > - add edk2_add_host_crypto_policy() and the Edk2Crypto object > > The Edk2Crypto object is used to hold configuration values specific > to EDK2. > > The edk2_add_host_crypto_policy() function

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Laszlo Ersek
On 03/13/19 10:43, Laszlo Ersek wrote: > On 03/10/19 01:47, Philippe Mathieu-Daudé wrote: >> The Edk2Crypto object is used to hold configuration values specific >> to EDK2. >> >> The edk2_add_host_crypto_policy() function loads crypto policies >> from the host, and register them as fw_cfg named

Re: [Qemu-devel] [PATCH v4 11/15] s390-bios: cio error handling

2019-03-13 Thread Cornelia Huck
On Mon, 11 Mar 2019 11:21:29 -0400 "Jason J. Herne" wrote: > Add verbose error output for when unexpected i/o errors happen. This eases the > burden of debugging and reporting i/o errors. No error information is printed > in the success case, here is an example of what is output on error: > >

Re: [Qemu-devel] [PATCH v4 0/4] fw_cfg: Add edk2_add_host_crypto_policy()

2019-03-13 Thread Laszlo Ersek
On 03/12/19 23:56, Philippe Mathieu-Daudé wrote: > Hi, > > This series consists of: > - add fw_cfg_add_file_from_host() > - add edk2_add_host_crypto_policy() and the Edk2Crypto object > > The Edk2Crypto object is used to hold configuration values specific > to EDK2. > > The

Re: [Qemu-devel] [PATCH 07/10] roms: build edk2 firmware binaries and variable store templates

2019-03-13 Thread Laszlo Ersek
On 03/12/19 22:11, Philippe Mathieu-Daudé wrote: > On 3/12/19 4:15 PM, Laszlo Ersek wrote: >> Phil: can you please test whether SHELL=/bin/bash works for you on >> Ubuntu? (After you install "bash", of course.) > > It indeed worked using: > -- >8 -- > @@ -11,6 +11,8 @@ > # THE PROGRAM IS

Re: [Qemu-devel] [PATCH v2 02/13] spapr/xive: add hcall support when under KVM

2019-03-13 Thread Cédric Le Goater
On 3/12/19 11:26 AM, David Gibson wrote: > On Mon, Mar 11, 2019 at 06:32:05PM +0100, Cédric Le Goater wrote: >> On 2/26/19 12:22 AM, David Gibson wrote: >>> On Fri, Feb 22, 2019 at 02:13:11PM +0100, Cédric Le Goater wrote: > [snip] +void kvmppc_xive_set_source_config(sPAPRXive *xive, uint32_t

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] coroutine: add x86 specific coroutine backend

2019-03-13 Thread Stefan Hajnoczi
On Mon, Mar 11, 2019 at 01:35:04PM +0100, Paolo Bonzini wrote: > This is in preparation for CET support for x86. > > I know this is very late, but if possible I'd like to have this in 4.0 > as an experimental backend. > > Paolo Bonzini (3): > qemugdb: fix licensing > qemugdb: allow adding

[Qemu-devel] [PULL 09/10] tests: Add migration multifd test

2019-03-13 Thread Juan Quintela
We set multifd-channels. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- tests/migration-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/migration-test.c b/tests/migration-test.c index

[Qemu-devel] [PULL 03/10] multifd: Create new next_packet_size field

2019-03-13 Thread Juan Quintela
We need to send this field when we add compression support. As we are still on x- stage, we can do this kind of changes. Signed-off-by: Juan Quintela --- migration/ram.c| 15 +-- migration/trace-events | 4 ++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}

2019-03-13 Thread Kamal Heib
On 3/13/19 11:33 AM, Yuval Shaia wrote: > On Wed, Mar 13, 2019 at 10:46:47AM +0200, Kamal Heib wrote: >> Signed-off-by: Kamal Heib > > To be consist please copy git message as well as header message from > commit 555b3d67bc ("hw/rdma: modify struct initialization"). > OK, I'll fix that in

Re: [Qemu-devel] [PATCH v3 2/4] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy()

2019-03-13 Thread Laszlo Ersek
On 03/10/19 01:47, Philippe Mathieu-Daudé wrote: > The Edk2Crypto object is used to hold configuration values specific > to EDK2. > > The edk2_add_host_crypto_policy() function loads crypto policies > from the host, and register them as fw_cfg named file items. > So far only the 'https' policy is

[Qemu-devel] [PATCH] intel-iommu: optimize nodmar memory regions

2019-03-13 Thread Peter Xu
Previously we have per-device system memory aliases when DMAR is disabled by the system. It will slow the system down if there are lots of devices especially when DMAR is disabled, because each of the aliased system address space will contain O(N) slots, and rendering such N address spaces will

Re: [Qemu-devel] [PULL 0/4] qtest and misc patches

2019-03-13 Thread Peter Maydell
On Tue, 12 Mar 2019 at 09:06, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-03-11 18:26:37 +) > > are available in the git

  1   2   3   4   >