Re: [Qemu-devel] [PATCH] audio: Add missing fall through comments

On Fri, Jul 19, 2019 at 2:12 AM Stefan Weil wrote: > > Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau > --- > audio/audio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/audio/audio.c b/audio/audio.c > index 5fd9a58a80..a7a13e900a 100644 > --- a/audio/audio.c > +++

Re: [Qemu-devel] [PATCH v7 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

Ping for comments :) On 7/16/2019 10:51 PM, Tao Xu wrote: This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related

[Qemu-devel] [PATCH] migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE

Use common helper function to check the state. Signed-off-by: Wei Yang --- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 3036221ee8..0e73e759ca 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -3140,7

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

On 7/18/2019 4:15 PM, Paolo Bonzini wrote: On 18/07/19 06:55, Jing Liu wrote: +    *eax = kvm_arch_get_supported_cpuid(cs->kvm_state, 0x7, +    count, R_EAX); This needs to be firstly checked as follows, otherwise some architectures would

Re: [Qemu-devel] [PATCH v6] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

On 18.07.19 15:06, Laurent Vivier wrote: > From: Daniel P. Berrangé > > The SIOCGSTAMP symbol was previously defined in the > asm-generic/sockios.h header file. QEMU sees that header > indirectly via sys/socket.h > > In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115 > the

Re: [Qemu-devel] [PATCH] audio: Add missing fall through comments

On 7/18/19 9:34 PM, Stefan Weil wrote: > Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > audio/audio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/audio/audio.c b/audio/audio.c > index 5fd9a58a80..a7a13e900a 100644 >

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] qmp: don't emit the RESET event on wakeup

On 19.07.19 01:24, Nicholas Piggin wrote: > Christian Borntraeger's on July 18, 2019 9:27 pm: >> >> >> On 18.07.19 13:06, Paolo Bonzini wrote: >>> On 18/07/19 12:39, Nicholas Piggin wrote: Commit 1405819637f53 ("qmp: don't emit the RESET event on wakeup from S3") changed system wakeup

Re: [Qemu-devel] [PATCH] audio: Add missing fall through comments

On Jul 19, 2019 9:30 AM, "Philippe Mathieu-Daudé" wrote: > > On 7/18/19 9:34 PM, Stefan Weil wrote: > > Signed-off-by: Stefan Weil > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Philippe, how do you test these comments? Yours, Aleksandar > > --- > >

[Qemu-devel] [PULL v2 2/3] linux-user: check valid address in access_ok()

From: Rémi Denis-Courmont Fix a crash with LTP testsuite and aarch64: tst_test.c:1015: INFO: Timeout per run is 0h 05m 00s qemu-aarch64: .../qemu/accel/tcg/translate-all.c:2522: page_check_range: Assertion `start < ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)' failed.

[Qemu-devel] [PULL v2 1/3] linux-user: Fix structure target_ucontext for MIPS

From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link;

[Qemu-devel] [PULL v2 0/3] Linux user for 4.1 patches

The following changes since commit a1a4d49f60d2b899620ee2be4ebb991c4a90a026: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20190716' into staging (2019-07-16 17:02:44 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[Qemu-devel] [PULL v2 3/3] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

From: Daniel P. Berrangé The SIOCGSTAMP symbol was previously defined in the asm-generic/sockios.h header file. QEMU sees that header indirectly via sys/socket.h In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115 the asm-generic/sockios.h header no longer defines SIOCGSTAMP.

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr: Stop providing RTAS blob

On 19/07/2019 03.23, Alexey Kardashevskiy wrote: > > > On 18/07/2019 20:49, Thomas Huth wrote: >> On 18/07/2019 12.40, Greg Kurz wrote: >>> On Thu, 18 Jul 2019 17:55:12 +1000 >>> Alexey Kardashevskiy wrote: >>> On 18/07/2019 17:20, Thomas Huth wrote: > On 16/07/2019 07.35,

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

On 19/07/19 09:20, Jing Liu wrote: >> Then CPUID[7,0].EAX is set automatically to 0 or 1 depending on whether >> BF16 is enabled or not. > > Could I ask why don't we directly check BF16 enabling when > cpu_x86_cpuid(env, 7, 0, ...) during kvm_arch_init_vcpu ? Because the code for setting CPUID

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Allow bit 15 to be set to 1 on slbmfee and slbmfev

Le 7/19/2019 à 3:34 AM, David Gibson a écrit : On Thu, Jul 18, 2019 at 10:15:52PM +0200, Ivan Warren wrote: Le 7/18/2019 à 7:19 PM, Greg Kurz a écrit : We usually mention the subsystem name in the subject, ie. target/ppc: Allow bit 15 to be set to 1 on slbmfee and slbmfev Gotcha ! Still

[Qemu-devel] [PATCH] scsi-generic: Check sense key before request snooping and patching

From: Shin'ichiro Kawasaki When READ CAPACITY command completes, scsi_read_complete() function snoops the command result and updates SCSIDevice members blocksize and max_lba . However, this update is executed even when READ CAPACITY command indicates an error in sense data. This causes

[Qemu-devel] [PATCH v27 2/8] target/avr: Add instruction helpers

From: Sarah Harris Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate

[Qemu-devel] [PATCH v27 3/8] target/avr: Add instruction decoding

This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git

[Qemu-devel] [PATCH v27 0/8] QEMU AVR 8 bit cores

This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[Qemu-devel] [PATCH v27 1/8] target/avr: Add outward facing interfaces and core CPU logic

From: Sarah Harris This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Michael Rolnik Acked-by: Igor Mammedov --- gdb-xml/avr-cpu.xml| 49 target/avr/cpu-param.h | 37 +++ target/avr/cpu.c | 579

[Qemu-devel] [PATCH v27 6/8] target/avr: Add example board configuration

From: Sarah Harris A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. Signed-off-by: Michael Rolnik --- hw/Kconfig | 1 +

[Qemu-devel] [PATCH v27 8/8] target/avr: Add tests

1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which, If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out 2. Boot serial test Prinit out 'T' through serial port Signed-off-by: Michael Rolnik ---

[Qemu-devel] [PATCH v27 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals

From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins).

[Qemu-devel] [PATCH v27 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 ++ arch_init.c | 2 ++ configure | 7 +++ default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6 ++ include/sysemu/arch_init.h | 1 +

[Qemu-devel] [PATCH v27 4/8] target/avr: Add instruction translation

This includes: - TCG translations for each instruction Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2888 1 file changed, 2888 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c

Re: [Qemu-devel] [PATCH v26 0/7] QEMU AVR 8 bit cores

Hi Phil. Thanks for explaining. Tests are added. On Thu, Jul 18, 2019 at 8:19 AM Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 7/17/19 5:46 PM, Michael Rolnik wrote: > > ping. > > QEMU is currently preparing for the next release (4.1) and we entered > the "freezed" period where no new

[Qemu-devel] [PATCH v4] ppc: make idle_timer a per-cpu variable

The current code is broken for more than vcpu as each thread would overwrite idle_timer and there were memory leaks. Make it part of PowerPCCPU so that every thread has a separate one. Avoid using the timer_new_ns which is not the preferred way to create timers. Signed-off-by: Shivaprasad G Bhat

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] ppc: make idle_timer a per-cpu variable

On 07/18/2019 09:47 PM, Greg Kurz wrote: On Thu, 18 Jul 2019 10:21:28 -0500 Shivaprasad G Bhat wrote: +PowerPCCPU *cpu = POWERPC_CPU(cs); + +timer_deinit(>idle_timer); As stated in the timer.h header file, timer_del() should always be called before timer_deinit(). With that fixed:

[Qemu-devel] [PATCH] i386/acpi: show PCI Express bus on pxb-pcie expanders

Show PCIe host bridge PNP id with PCI host bridge as a compatible id when expanding a pcie bus. Signed-off-by: Evgeny Yakovlev --- hw/i386/acpi-build.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index d281ffa..0675952

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- Tony,

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

On Jul 18, 2019 11:55 AM, "Paolo Bonzini" wrote: > > On 18/07/19 08:01, tony.ngu...@bt.com wrote: > > This patch moves the define of target access alignment earlier from > > target/foo/cpu.h to configure. > > > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > >

Re: [Qemu-devel] [PATCH 1/3] qmp: don't emit the RESET event on wakeup

On Fri, 19 Jul 2019 09:24:20 +1000 Nicholas Piggin wrote: > Christian Borntraeger's on July 18, 2019 9:27 pm: > > > > > > On 18.07.19 13:06, Paolo Bonzini wrote: > >> On 18/07/19 12:39, Nicholas Piggin wrote: > >>> Commit 1405819637f53 ("qmp: don't emit the RESET event on wakeup from > >>>

Re: [Qemu-devel] [PATCH] iotests: Set read-zeroes on in null block driver for Valgrind

On 19/07/2019 03:14, John Snow wrote: > > > On 7/15/19 12:06 PM, Andrey Shinkevich wrote: >> The Valgrind tool reports about the uninitialised buffer 'buf' >> instantiated on the stack of the function guess_disk_lchs(). >> Pass 'read-zeroes=on' to the null block driver to make it deterministic.

[Qemu-devel] [PATCH v3 00/10] block: Delay poll when ending drained sections

Hi, This series: (1) Keeps patch 1, as the previous series, and (2) Decides whether all *drained_end* functions should poll or not; as proposed by Kevin, all that should not poll now get a @drained_end_counter pointer, whose pointee they have to increment once for every background

[Qemu-devel] [PATCH v3 02/10] tests: Add job commit by drained_end test

Signed-off-by: Max Reitz --- tests/test-bdrv-drain.c | 119 1 file changed, 119 insertions(+) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 12e2ecf517..3503ce3b69 100644 --- a/tests/test-bdrv-drain.c +++ b/tests/test-bdrv-drain.c

[Qemu-devel] [PATCH v3 01/10] block: Introduce BdrvChild.parent_quiesce_counter

Commit 5cb2737e925042e6c7cd3fb0b01313950b03cddf laid out why bdrv_do_drained_end() must decrement the quiesce_counter after bdrv_drain_invoke(). It did not give a very good reason why it has to happen after bdrv_parent_drained_end(), instead only claiming symmetry to bdrv_do_drained_begin(). It

[Qemu-devel] [PATCH v3 05/10] tests: Lock AioContexts in test-block-iothread

When changing a node's AioContext, the caller must acquire the old AioContext (unless it currently runs in that old context). Therefore, unless the node currently is in the main context, we always have to acquire the old context around calls that may change a node's AioContext. Signed-off-by:

[Qemu-devel] [PATCH v3 06/10] block: Do not poll in bdrv_do_drained_end()

We should never poll anywhere in bdrv_do_drained_end() (including its recursive callees like bdrv_drain_invoke()), because it does not cope well with graph changes. In fact, it has been written based on the postulation that no graph changes will happen in it. Instead, the callers that want to

[Qemu-devel] [PATCH v3 04/10] block: Make bdrv_parent_drained_[^_]*() static

These functions are not used outside of block/io.c, there is no reason why they should be globally available. Signed-off-by: Max Reitz --- include/block/block.h | 18 -- block/io.c| 8 2 files changed, 4 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH v3 10/10] iotests: Test commit with a filter on the chain

Before the previous patches, the first case resulted in a failed assertion (which is noted as qemu receiving a SIGABRT in the test output), and the second usually triggered a segmentation fault. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 40 +-

[Qemu-devel] [PATCH v3 07/10] tests: Extend commit by drained_end test

Signed-off-by: Max Reitz --- tests/test-bdrv-drain.c | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index 3503ce3b69..03fa1142a1 100644 --- a/tests/test-bdrv-drain.c +++

[Qemu-devel] [PATCH v3 03/10] block: Add @drained_end_counter

Callers can now pass a pointer to an integer that bdrv_drain_invoke() (and its recursive callees) will increment for every bdrv_drain_invoke_entry() operation they schedule. bdrv_drain_invoke_entry() in turn will decrement it once it has invoked BlockDriver.bdrv_co_drain_end(). We use atomic

[Qemu-devel] [PATCH v3 08/10] block: Loop unsafely in bdrv*drained_end()

The graph must not change in these loops (or a QLIST_FOREACH_SAFE would not even be enough). We now ensure this by only polling once in the root bdrv_drained_end() call, so we can drop the _SAFE suffix. Doing so makes it clear that the graph must not change. Signed-off-by: Max Reitz ---

[Qemu-devel] [PATCH v3 09/10] iotests: Add @has_quit to vm.shutdown()

If a test has issued a quit command already (which may be useful to do explicitly because the test wants to show its effects), QEMUMachine.shutdown() should not do so again. Otherwise, the VM may well return an ECONNRESET which will lead QEMUMachine.shutdown() to killing it, which then turns into

Re: [Qemu-devel] [PULL v2 0/3] Linux user for 4.1 patches

On Fri, 19 Jul 2019 at 09:07, Laurent Vivier wrote: > > The following changes since commit a1a4d49f60d2b899620ee2be4ebb991c4a90a026: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/pflash-next-20190716' into staging (2019-07-16 > 17:02:44 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- Hi,

[Qemu-devel] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized

In case nbd_co_receive_one_chunk() fails in nbd_reply_chunk_iter_receive(), 'NBDReply reply' parameter is used in the check nbd_reply_is_simple() without being initialized. The iotest 083 does not pass under the Valgrind: $./check -nbd -valgrind 083. The alternative solution is to swap the

[Qemu-devel] [PATCH v4 6/7] iotests: extend sleeping time under Valgrind

To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] What events should be handled in iohandler context?

On Mon, Jul 15, 2019 at 06:19:31PM +0300, Anton Kuchin wrote: > I'm trying to understand contexts and handlers/notifiers and a bit confused > about two contexts living in main loop: qemu_aio_context and iohandler_ctx. > It is mentioned in the iohandler_ctx comment that qemu_aio_context can't be >

[Qemu-devel] [PATCH v4 1/7] iotests: allow Valgrind checking all QEMU processes

With the '-valgrind' option, let all the QEMU processes be run under the Valgrind tool. The Valgrind own parameters may be set with its environment variable VALGRIND_OPTS, e.g. VALGRIND_OPTS="--leak-check=yes" ./check -qcow2 -valgrind or they may be listed in the Valgrind checked file

[Qemu-devel] [PATCH v4 4/7] iotests: Valgrind fails with nonexistent directory

The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/051 | 4 1 file changed,

[Qemu-devel] [PATCH v4 3/7] iotests: Add casenotrun report to bash tests

The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/common.rc | 7 +++ 1 file changed, 7 insertions(+)

[Qemu-devel] [PATCH v4 5/7] iotests: extended timeout under Valgrind

As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/028 | 6 +-

[Qemu-devel] [PATCH v4 2/7] iotests: exclude killed processes from running under Valgrind

The Valgrind tool fails to manage its termination when QEMU raises the signal SIGKILL in the multi-threaded process. The bug has been reported to the Valgrind maintainers and was registered as Bug 409141. Let's exclude such test cases from running under the Valgrind until new release of it

[Qemu-devel] [PATCH v4 0/7] Allow Valgrind checking all QEMU processes

In the current implementation of the QEMU bash iotests, only qemu-io processes may be run under the Valgrind, which is a useful tool for finding memory usage issues. Let's allow the common.rc bash script runing all the QEMU processes, such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the

Re: [Qemu-devel] [Bug 1836855] [NEW] virtio_scsi_ctx_check failed when detach virtio_scsi disk

On Wed, Jul 17, 2019 at 08:20:35AM -, 贞贵李 wrote: > Public bug reported: > > I found a problem that virtio_scsi_ctx_check failed when detaching > virtio_scsi disk. The bt is below: > > (gdb) bt > #0 0xb02e1bd0 in raise () from /lib64/libc.so.6 > #1 0xb02e2f7c in abort ()

Re: [Qemu-devel] [PATCH v1 00/23] s390x/tcg: Vector Instruction Support Part 4

On May 31, 2019 12:48 PM, "David Hildenbrand" wrote: > > This is the final part of vector instruction support for s390x. It is based > on part 2, which is will send a pull-request for to Conny soon. > > Part 1: Vector Support Instructions > Part 2: Vector Integer Instructions > Part 3: Vector

Re: [Qemu-devel] [PATCH v4 0/3] Few bugfixes for userspace nvme driver

On 16.07.19 18:30, Maxim Levitsky wrote: > This is reduced version of patch series for userspace nvme driver, > that only includes the bugfixes I made. > > Best regards, > Maxim Levitsky > > Maxim Levitsky (3): > block/nvme: fix doorbell stride > block/nvme: support larger that 512

Re: [Qemu-devel] [PATCH] virtio-scsi: remove unused argument to virtio_scsi_common_realize

On Wed, Jul 17, 2019 at 11:47:28AM +0200, Paolo Bonzini wrote: > The argument is not used and passing it clutters error propagation in the > callers. So, get rid of it. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/vhost-scsi.c| 2 +- > hw/scsi/vhost-user-scsi.c | 2 +- >

Re: [Qemu-devel] [PATCH v1 00/23] s390x/tcg: Vector Instruction Support Part 4

On 19.07.19 11:51, Aleksandar Markovic wrote: > > On May 31, 2019 12:48 PM, "David Hildenbrand" > wrote: >> >> This is the final part of vector instruction support for s390x. It is > based >> on part 2, which is will send a pull-request for to Conny soon. >> >> Part 1:

[Qemu-devel] [PATCH for-4.1] contrib/elf2dmp: Build download.o with CURL_CFLAGS

contrib/elf2dmp has a source file which uses curl/curl.h; although we link the final executable with CURL_LIBS, we forgot to build this source file with CURL_CFLAGS, so if the curl header is in a place that's not already on the system include path then it will fail to build. Add a line specifying

Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

Well, this patch introduces 3 command line parameters (“lcyls”, “lheads”, “lsecs”) to “scsi-hd” “ide-hd” and “virtio-pci-blk” so this somehow has something to do with block. This patch also adds fw_cfg interface to send these parameters to SeaBIOS. "scripts/get_maintainer.pl -f

Re: [Qemu-devel] BDRV request fragmentation and vitio-blk write submission guarantees

On Thu, Jul 18, 2019 at 04:44:17PM +0300, Евгений Яковлев wrote: > Hi everyone, > > We're currently working on implementing a qemu BDRV format driver which we > are using with virtio-blk devices. > > I have a question concerning BDRV request fragmentation and virtio-blk write > request

Re: [Qemu-devel] [PATCH for-4.1] contrib/elf2dmp: Build download.o with CURL_CFLAGS

Hi On Fri, Jul 19, 2019 at 2:10 PM Peter Maydell wrote: > > contrib/elf2dmp has a source file which uses curl/curl.h; > although we link the final executable with CURL_LIBS, we > forgot to build this source file with CURL_CFLAGS, so if > the curl header is in a place that's not already on the >

Re: [Qemu-devel] [PATCH] audio: Add missing fall through comments

On 7/19/19 9:43 AM, Aleksandar Markovic wrote: > > On Jul 19, 2019 9:30 AM, "Philippe Mathieu-Daudé" > wrote: >> >> On 7/18/19 9:34 PM, Stefan Weil wrote: >> > Signed-off-by: Stefan Weil mailto:s...@weilnetz.de>> >> >> Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v5] LUKS: support preallocation

On 16.07.19 18:19, Maxim Levitsky wrote: > preallocation=off and preallocation=metadata > both allocate luks header only, and preallocation=falloc/full > is passed to underlying file. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1534951 > > Signed-off-by: Maxim Levitsky > --- > >

Re: [Qemu-devel] [PATCH v3 0/4] Introduce the microvm machine type

On Thu, Jul 18, 2019 at 05:21:46PM +0200, Sergio Lopez wrote: > > Stefan Hajnoczi writes: > > > On Tue, Jul 02, 2019 at 02:11:02PM +0200, Sergio Lopez wrote: > >> Microvm is a machine type inspired by both NEMU and Firecracker, and > >> constructed after the machine model implemented by the

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

Paolo Bonzini writes: > On 18/07/19 16:34, Sergio Lopez wrote: >> I've just added support for starting the machine from SeaBIOS (Stefan >> Hajnoczi pointed in another thread that it can be as fast as qboot, and >> given that the latter doesn't support mptables, I just tested this >> one). I

[Qemu-devel] [PATCH] target/i386: sev: fix failed message typos

In these multiline messages, there were typos. Fix them -- add a missing space and remove a superfluous apostrophe. Inspired by Tom's patch. Signed-off-by: Jiri Slaby Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-triv...@nongnu.org Cc: Brijesh Singh Cc: Tom Lendacky

Re: [Qemu-devel] Discussion: redundant process during hotplug and missed process during unplug

On Fri, Jul 19, 2019 at 02:35:14AM +, Zhangbo (Oscar) wrote: > Hi All: > I have 2 questions about (un)hotplug on pcie-root-port. > First Question (hotplug failure because of redundant PCI_EXP_LNKSTA_DLLLA bit > set): > during VM boot, qemu sets PCI_EXP_LNKSTA_DLLLA according to this

Re: [Qemu-devel] BDRV request fragmentation and vitio-blk write submission guarantees

On 19.07.2019 13:17, Stefan Hajnoczi wrote: On Thu, Jul 18, 2019 at 04:44:17PM +0300, Евгений Яковлев wrote: Hi everyone, We're currently working on implementing a qemu BDRV format driver which we are using with virtio-blk devices. I have a question concerning BDRV request fragmentation and

Re: [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2

On Fri, 19 Jul 2019 at 02:58, Palmer Dabbelt wrote: > > The following changes since commit 0b18cfb8f1828c905139b54c8644b0d8f4aad879: > > Update version for v4.1.0-rc1 release (2019-07-16 18:01:28 +0100) > > are available in the Git repository at: > > git://github.com/palmer-dabbelt/qemu.git

Re: [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2

On Fri, 19 Jul 2019 at 12:03, Peter Maydell wrote: > This passes the 'make check' tests but it prints out a lot > of warnings as it does so: > > qemu-system-riscv64: warning: No -bios option specified. Not loading a > firmware. > qemu-system-riscv64: warning: This default will change in QEMU

[Qemu-devel] [PATCH 1/1] i386: indicate that 'pconfig' feature was removed intentionally

pconfig feature was added in 5131dc433df and removed in 712f807e196. This patch mark this feature as known to QEMU and removed by intentinally. This follows the convention of 9ccb9784b57 and f1a23522b03 dealing with 'osxsave' and 'ospke'. Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC:

[Qemu-devel] [PATCH-for-4.1] target/arm: Add missing break statement for Hypervisor Trap Exception

Reported by GCC9 when building with -Wimplicit-fallthrough=2: target/arm/helper.c: In function ‘arm_cpu_do_interrupt_aarch32_hyp’: target/arm/helper.c:7958:14: error: this statement may fall through [-Werror=implicit-fallthrough=] 7958 | addr = 0x14; | ~^~

[Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1()

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: CC target/i386/translate.o target/i386/translate.c: In function ‘gen_shiftd_rm_T1’: target/i386/translate.c:1785:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 1785 | if

Re: [Qemu-devel] [PATCH 1/1] i386: indicate that 'pconfig' feature was removed intentionally

On 19/07/19 13:12, Denis V. Lunev wrote: > pconfig feature was added in 5131dc433df and removed in 712f807e196. > This patch mark this feature as known to QEMU and removed by > intentinally. This follows the convention of 9ccb9784b57 and f1a23522b03 > dealing with 'osxsave' and 'ospke'. > >

Re: [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1()

On 19/07/19 13:23, Philippe Mathieu-Daudé wrote: > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > CC target/i386/translate.o > target/i386/translate.c: In function ‘gen_shiftd_rm_T1’: > target/i386/translate.c:1785:12: error: this statement may fall through

Re: [Qemu-devel] [PATCH] target/i386: sev: fix failed message typos

On 19/07/19 12:41, Jiri Slaby wrote: > In these multiline messages, there were typos. Fix them -- add a missing > space and remove a superfluous apostrophe. > > Inspired by Tom's patch. > > Signed-off-by: Jiri Slaby > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc:

Re: [Qemu-devel] [PATCH-for-4.1] target/arm: Add missing break statement for Hypervisor Trap Exception

On Fri, 19 Jul 2019 at 12:15, Philippe Mathieu-Daudé wrote: > > Reported by GCC9 when building with -Wimplicit-fallthrough=2: > > target/arm/helper.c: In function ‘arm_cpu_do_interrupt_aarch32_hyp’: > target/arm/helper.c:7958:14: error: this statement may fall through >

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386: Introduce the microvm machine type

On 19/07/19 12:30, Sergio Lopez wrote: > If people feel more comfortable keeping QEMU on x86_64 starting on Real > Mode and having the firmware writing mptables, I'm fine with taking this > approach. > > That said, to avoid confusing users, I think it'd be better to drop the > legacy mode for

[Qemu-devel] [PULL for-4.1 0/1] one s390x fix/annotation

The following changes since commit 0b18cfb8f1828c905139b54c8644b0d8f4aad879: Update version for v4.1.0-rc1 release (2019-07-16 18:01:28 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-20190719 for you to fetch changes up

[Qemu-devel] [PULL for-4.1 1/1] s390x/pci: add some fallthrough annotations

According to the comment, the bits are supposed to accumulate. Reported-by: Stefan Weil Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking") Acked-by: Collin Walling Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-inst.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1()

On Fri, 19 Jul 2019 at 12:45, Paolo Bonzini wrote: > > On 19/07/19 13:23, Philippe Mathieu-Daudé wrote: > > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > > > CC target/i386/translate.o > > target/i386/translate.c: In function ‘gen_shiftd_rm_T1’: > >

Re: [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2

On Fri, 19 Jul 2019 at 12:11, Peter Maydell wrote> > Since this pullreq does pass the tests, and rc2 is not far off > now (Tuesday), I think my suggestion is that I'll apply this > as-is, and we should fix up the issues with the warning messages > as a followup patch. I think that's better than

Re: [Qemu-devel] [RFC PATCH-for-4.1] target/i386: Correct misplaced break statement in gen_shiftd_rm_T1()

On 19/07/19 13:51, Peter Maydell wrote: >> I haven't looked closely at the code but I would guess that the >> fallthrough is intended, because the default label has an "ot == MO_16" >> condition. > Yeah, this code is really weird -- if TARGET_X86_64 then > MO_16 falls through into MO_32, but if

Re: [Qemu-devel] [PATCH] i386/acpi: show PCI Express bus on pxb-pcie expanders

On Fri, 19 Jul 2019 11:54:29 +0300 Evgeny Yakovlev wrote: > Show PCIe host bridge PNP id with PCI host bridge as a compatible id > when expanding a pcie bus. > > Signed-off-by: Evgeny Yakovlev Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 5 - > 1 file changed, 4

Re: [Qemu-devel] [PULL for-4.1 0/1] one s390x fix/annotation

m/cohuck/qemu tags/s390x-20190719 > > for you to fetch changes up to efac5ae420ca0644db9360861a1bf02d040afd18: > > s390x/pci: add some fallthrough annotations (2019-07-18 11:29:50 +0200) > >

[Qemu-devel] -rtc base=, migration and time jumps

Hi, I've just spent an unreasonable amount of time debugging an rtc issue and come to the conclusion it's probably more of a documentation problem than actual code - but I wondered if anyone disagrees. (ref: https://bugzilla.redhat.com/show_bug.cgi?id=1714143 ) The question revolves around

Re: [Qemu-devel] [PATCH-for-4.1] target/arm: Add missing break statement for Hypervisor Trap Exception

On 7/19/19 1:47 PM, Peter Maydell wrote: > On Fri, 19 Jul 2019 at 12:15, Philippe Mathieu-Daudé > wrote: >> >> Reported by GCC9 when building with -Wimplicit-fallthrough=2: >> >> target/arm/helper.c: In function ‘arm_cpu_do_interrupt_aarch32_hyp’: >> target/arm/helper.c:7958:14: error: this

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

On 7/18/19 4:52 PM, Paolo Bonzini wrote: > On 18/07/19 15:45, Denis V. Lunev wrote: >> There are the following flags available in libvirt inside cpu_map.xm >> >> >> >> >> >> >> We have faced the problem that QEMU does not start once these flags are >> present in

[Qemu-devel] [PATCH-for-4.1? 0/7] Trivial switch 'fall through' comment fixes for GCC9

Trivial patches, simply rewrite the comment or move it around. Reported by Stefan here: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01970.html Regards, Phil. Philippe Mathieu-Daudé (7): json: Move switch 'fall through' comment to correct place hw/dma/omap_dma: Move switch

[Qemu-devel] [PATCH-for-4.1? 1/7] json: Move switch 'fall through' comment to correct place

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: qobject/json-parser.c: In function ‘parse_literal’: qobject/json-parser.c:492:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 492 | case JSON_INTEGER: { |^

[Qemu-devel] [PATCH-for-4.1? 2/7] hw/dma/omap_dma: Move switch 'fall through' comment to correct place

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: CC hw/dma/omap_dma.o hw/dma/omap_dma.c: In function ‘omap_dma_write’: hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 1532 | if (s->model <= omap_dma_3_1)

[Qemu-devel] [PATCH-for-4.1 3/7] hw/block/pflash_cfi02: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/block/pflash_cfi02.c: In function ‘pflash_write’: hw/block/pflash_cfi02.c:574:16: error: this statement may fall through [-Werror=implicit-fallthrough=] 574 | if (boff == 0x55 && cmd ==

[Qemu-devel] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’: hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 178 | ch |= 0x10; |

[Qemu-devel] [PATCH-for-4.1? 7/7] spapr_events: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: CC ppc64-softmmu/hw/ppc/spapr_rtc.o hw/ppc/spapr_events.c: In function ‘rtas_event_log_to_source’: hw/ppc/spapr_events.c:312:12: error: this statement may fall through [-Werror=implicit-fallthrough=]

[Qemu-devel] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: target/ppc/mmu_helper.c: In function ‘dump_mmu’: target/ppc/mmu_helper.c:1349:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 1349 | if (ppc64_v3_radix(env_archcpu(env)))

[Qemu-devel] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: vl.c: In function ‘qemu_ref_timedate’: vl.c:773:15: error: this statement may fall through [-Werror=implicit-fallthrough=] 773 | value -= rtc_realtime_clock_offset; |

  1   2   3   >