Re: [Qemu-devel] [PATCH v3 1/2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

2019-08-13 Thread Paolo Bonzini
On 13/08/19 12:31, Philippe Mathieu-Daudé wrote: >> | >> | s->istat1 |= LSI_ISTAT1_SRUN; >> | again: >> | -insn_processed++; >> | +if (++insn_processed > LSI_MAX_INSN) { >> | +trace_lsi_execute_script_tc_illegal(); >> | +lsi_script_dma_interrupt(s, LSI_DSTAT_IID);

Re: [Qemu-devel] [PATCH 2/6] tests/libqos: Make virtio-pci code independent from global_qtest

2019-08-13 Thread Eric Blake
On 8/13/19 4:30 AM, Thomas Huth wrote: > The libqos library functions should never depend on global_qtest, > since these functions might be used in tests that track multiple > test states. So let's use the test state of the QPCIDevice instead. > > Signed-off-by: Thomas Huth > --- >

[Qemu-devel] [PATCH v2] ppc: Add support for 'mffsl' instruction

2019-08-13 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffsl'. 'mffsl' is identical to 'mffs', except it only returns mode, status, and enable bits from

[Qemu-devel] [PATCH] ppc: Add support for 'mffsl' instruction

2019-08-13 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffsl'. 'mffsl' is identical to 'mffs', except it only returns mode, status, and enable bits from

[Qemu-devel] [PATCH v3] block: posix: Handle undetectable alignment

2019-08-13 Thread Nir Soffer
In some cases buf_align or request_alignment cannot be detected: 1. With Gluster, buf_align cannot be detected since the actual I/O is done on Gluster server, and qemu buffer alignment does not matter. Since we don't have alignment requirement, buf_align=1 is the best value. 2. With

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Make various formats' block_status recurse again

2019-08-13 Thread Max Reitz
On 12.08.19 23:45, John Snow wrote: > > > On 8/12/19 3:11 PM, Max Reitz wrote: >> On 12.08.19 20:39, John Snow wrote: >>> >>> >>> On 7/25/19 11:55 AM, Max Reitz wrote: Hi, 69f47505ee66afaa513305de0c1895a224e52c45 changed block_status so that it would only go down to the

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Max Reitz
On 13.08.19 16:39, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 17:23, Max Reitz wrote: >> On 13.08.19 16:14, Vladimir Sementsov-Ogievskiy wrote: >>> 12.08.2019 19:37, Vladimir Sementsov-Ogievskiy wrote: 12.08.2019 19:11, Max Reitz wrote: > On 12.08.19 17:47, Vladimir

[Qemu-devel] [PULL 00/29] Header cleanup patches for 2019-08-13

2019-08-13 Thread Markus Armbruster
The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2: Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-include-2019-08-13 for you to fetch changes up to

[Qemu-devel] [PULL 26/29] Clean up inclusion of sysemu/sysemu.h

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing sysemu/sysemu.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Almost a third of its inclusions are actually superfluous. Delete them. Downgrade two more to

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Max Reitz
On 13.08.19 17:41, Kevin Wolf wrote: > Am 13.08.2019 um 16:43 hat Max Reitz geschrieben: >> On 13.08.19 13:04, Kevin Wolf wrote: >>> Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to returned file. But

Re: [Qemu-devel] [PATCH v2] ppc: Add support for 'mffsl' instruction

2019-08-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1565712926-21194-1-git-send-email...@us.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] ppc: Add support for 'mffsl' instruction Message-id:

Re: [Qemu-devel] [PATCH-for-4.2 v1 5/6] s390x/mmu: Better storage key reference and change bit handling

2019-08-13 Thread Cornelia Huck
On Mon, 12 Aug 2019 13:27:36 +0200 David Hildenbrand wrote: > Any access sets the reference bit. In case we have a read-fault, we > should not allow writes to the TLB entry if the change bit was not > already set. > > This is a preparation for proper storage-key reference/change bit handling >

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 17:57, Max Reitz wrote: > On 13.08.19 16:39, Vladimir Sementsov-Ogievskiy wrote: >> 13.08.2019 17:23, Max Reitz wrote: >>> On 13.08.19 16:14, Vladimir Sementsov-Ogievskiy wrote: 12.08.2019 19:37, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 19:11, Max Reitz wrote: >> On

Re: [Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-08-13 Thread Igor Mammedov
On Fri, 9 Aug 2019 14:57:25 +0800 Tao wrote: > From: Tao Xu > > In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), > The initiator represents processor which access to memory. And in 5.2.27.3 > Memory Proximity Domain Attributes Structure, the attached initiator is >

Re: [Qemu-devel] [PATCH 6/6] tests/libqtest: Make qmp_assert_success() independent from global_qtest

2019-08-13 Thread Eric Blake
On 8/13/19 4:30 AM, Thomas Huth wrote: > The normal libqtest library functions should never depend on global_qtest. > Pass in the test state via parameter instead. And while we're at it, > also rename this function to qtest_qmp_assert_success() to make it clear > that it is part of libqtest. > >

[Qemu-devel] [PULL 01/29] include: Make headers more self-contained

2019-08-13 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are

[Qemu-devel] [PULL 03/29] qapi: Split error.json off common.json

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing a type in qapi/common.json triggers a recompile of some 3600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). One common dependency is QapiErrorClass: it's used only in in qapi/error.h, which uses nothing else, and is

[Qemu-devel] [PULL 13/29] Clean up inclusion of exec/cpu-common.h

2019-08-13 Thread Markus Armbruster
migration/qemu-file.h neglects to include it even though it needs ram_addr_t. Fix that. Drop a few superfluous inclusions elsewhere. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-14-arm...@redhat.com>

[Qemu-devel] [PULL 04/29] memory: Fix type of IOMMUMemoryRegionClass member @parent_class

2019-08-13 Thread Markus Armbruster
TYPE_IOMMU_MEMORY_REGION is a direct subtype of TYPE_MEMORY_REGION. Its instance struct is IOMMUMemoryRegion, and its first member is a MemoryRegion. Correct. Its class struct is IOMMUMemoryRegionClass, and its first member is a DeviceClass. Wrong. Messed up when commit 1221a474676 introduced

[Qemu-devel] [PULL 12/29] Include hw/irq.h a lot less

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing hw/irq.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). hw/hw.h supposedly includes it for convenience. Several other headers include it just to get qemu_irq and.or

Re: [Qemu-devel] [PATCH-for-4.2 v1 8/9] s390x/cpumodel: Prepare for changes of QEMU model

2019-08-13 Thread Cornelia Huck
On Mon, 5 Aug 2019 17:29:46 +0200 David Hildenbrand wrote: > Setup the 4.1 compatibility model so we can add new features to the > LATEST model. Basically a nop for now from an outside view. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 ++ >

Re: [Qemu-devel] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ

2019-08-13 Thread Cédric Le Goater
On 13/08/2019 18:46, Peter Maydell wrote: > On Tue, 13 Aug 2019 at 17:44, Cédric Le Goater wrote: >> >> If an IRQ is allocated and not configured, such as a MSI requested by >> a PCI driver, it can be saved in its default state and possibly later >> on restored using the same state. If not

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 17:23, Max Reitz wrote: > On 13.08.19 16:14, Vladimir Sementsov-Ogievskiy wrote: >> 12.08.2019 19:37, Vladimir Sementsov-Ogievskiy wrote: >>> 12.08.2019 19:11, Max Reitz wrote: On 12.08.19 17:47, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 18:10, Max Reitz wrote: >> On

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Max Reitz
On 13.08.19 11:34, Kevin Wolf wrote: > Am 12.08.2019 um 21:46 hat Max Reitz geschrieben: >> On 12.08.19 20:11, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> I'm not sure, is it a bug or a feature, but using qcow2 under raw is >>> broken. It should be either fixed like I propose (by Max's

Re: [Qemu-devel] [PATCH 4/6] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest

2019-08-13 Thread Eric Blake
On 8/13/19 4:30 AM, Thomas Huth wrote: > The generic libqtest library functions should not use functions that > require the global_qtest variable. > > Signed-off-by: Thomas Huth > --- > tests/libqtest.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Eric Blake

[Qemu-devel] [PULL 07/29] trace: Do not include qom/cpu.h into generated trace.h

2019-08-13 Thread Markus Armbruster
docs/devel/tracing.txt explains "since many source files include trace.h, [the generated trace.h use] a minimum of types and other header files included to keep the namespace clean and compile times and dependencies down." Commit 4815185902 "trace: Add per-vCPU tracing states for events with the

[Qemu-devel] [PULL 02/29] Include generated QAPI headers less

2019-08-13 Thread Markus Armbruster
Some of the generated qapi-types-MODULE.h are included all over the place. Changing a QAPI type can trigger massive recompiling. Top scorers recompile more than 1000 out of some 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h): 6300 qapi/qapi-builtin-types.h

[Qemu-devel] [PULL 06/29] trace: Eliminate use of TARGET_FMT_plx

2019-08-13 Thread Markus Armbruster
hw/tpm/trace-events uses TARGET_FMT_plx formats with uint64_t arguments. That's wrong, TARGET_FMT_plx takes hwaddr. Since hwaddr happens to be uint64_t, it works anyway. Messed up in commit ec427498da5, v2.12.0. Clean up by replacing TARGET_FMT_plx with its macro expansion.

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Max Reitz
On 13.08.19 17:22, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 18:03, Max Reitz wrote: >> On 13.08.19 16:56, Vladimir Sementsov-Ogievskiy wrote: >>> 13.08.2019 17:43, Max Reitz wrote: On 13.08.19 13:04, Kevin Wolf wrote: > Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 19:30, Max Reitz wrote: > On 13.08.19 17:32, Vladimir Sementsov-Ogievskiy wrote: >> 13.08.2019 18:02, Max Reitz wrote: >>> On 13.08.19 17:00, Vladimir Sementsov-Ogievskiy wrote: 13.08.2019 17:57, Max Reitz wrote: > On 13.08.19 16:39, Vladimir Sementsov-Ogievskiy wrote: >>

[Qemu-devel] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ

2019-08-13 Thread Cédric Le Goater
If an IRQ is allocated and not configured, such as a MSI requested by a PCI driver, it can be saved in its default state and possibly later on restored using the same state. If not initially MASKED, KVM will try to find a matching priority/target tuple for the interrupt and fail to restore the VM

Re: [Qemu-devel] [PATCH] ppc: Add support for 'mffsl' instruction

2019-08-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1565710319-1026-1-git-send-email...@us.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] ppc: Add support for 'mffsl' instruction Message-id:

Re: [Qemu-devel] [FOR 4.1 PATCH] riscv: roms: Fix make rules for building sifive_u bios

2019-08-13 Thread Alistair Francis
On Tue, Aug 13, 2019 at 6:00 AM Peter Maydell wrote: > > On Mon, 12 Aug 2019 at 09:38, Peter Maydell wrote: > > > > On Sun, 11 Aug 2019 at 08:17, Bin Meng wrote: > > > > > > Hi Palmer, > > > > > > On Tue, Aug 6, 2019 at 1:04 AM Alistair Francis > > > wrote: > > > > > > > > On Fri, Aug 2, 2019

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Eric Blake
On 8/13/19 9:31 AM, Max Reitz wrote: > On 13.08.19 13:51, Kevin Wolf wrote: > > [...] > >> Hm... This is a mess. :-) > > Just out of curiosity: Why? > > Aren’t there only two things we really need from the block_status > infrastructure? > > (1) Whether something is allocated in the given

Re: [Qemu-devel] [PATCH v9 09/11] numa: Extend the CLI to provide memory latency and bandwidth information

2019-08-13 Thread Eric Blake
On 8/9/19 1:57 AM, Tao wrote: > From: Liu Jingqi > > Add -numa hmat-lb option to provide System Locality Latency and > Bandwidth Information. These memory attributes help to build > System Locality Latency and Bandwidth Information Structure(s) > in ACPI Heterogeneous Memory Attribute Table

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-13 Thread Laszlo Ersek
On 08/13/19 18:09, Laszlo Ersek wrote: > On 08/13/19 16:16, Laszlo Ersek wrote: >> (06) Host CPU: (SMM) Save 38000, Update 38000 -- fill simple SMM >> rebase code. >> >> (07) Host CPU: (SMM) Send message to New CPU to Enable SMI. > > Aha, so this is the SMM-only register you mention in step

Re: [Qemu-devel] [PATCH-4.2 v2 5/5] target/riscv: Fix Floating Point register names

2019-08-13 Thread Alistair Francis
On Mon, Aug 12, 2019 at 4:08 PM Palmer Dabbelt wrote: > > On Tue, 30 Jul 2019 16:35:34 PDT (-0700), Alistair Francis wrote: > > From: Atish Patra > > > > As per the RISC-V spec, Floating Point registers are named as f0..f31 > > so lets fix the register names accordingly. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 10/14] target/i386: sev: add support to load incoming encrypted page

2019-08-13 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > The sev_load_incoming_page() provide the implementation to read the > incoming guest private pages from the socket and load it into the guest > memory. The routines uses the RECEIVE_START command to create the > incoming encryption context on the

Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp()

2019-08-13 Thread Thomas Huth
On 8/13/19 5:20 PM, Eric Blake wrote: > On 8/13/19 4:30 AM, Thomas Huth wrote: >> No test is using hmp() anymore, and since this function uses the disliked >> global_qtest variable, we should also make sure that nobody adds new code >> with this function again. qtest_hmp() should be used instead.

Re: [Qemu-devel] [PATCH 3/3] vpc: Do not return RAW from block_status

2019-08-13 Thread Max Reitz
On 13.08.19 12:38, Kevin Wolf wrote: > Am 12.08.2019 um 17:56 hat Max Reitz geschrieben: >> On 12.08.19 17:33, Vladimir Sementsov-Ogievskiy wrote: >>> 25.07.2019 18:55, Max Reitz wrote: vpc is not really a passthrough driver, even when using the fixed subformat (where host and guest

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Max Reitz
On 13.08.19 16:56, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 17:43, Max Reitz wrote: >> On 13.08.19 13:04, Kevin Wolf wrote: >>> Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to returned file.

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Max Reitz
On 13.08.19 17:03, Kevin Wolf wrote: > Am 13.08.2019 um 16:53 hat Max Reitz geschrieben: >> On 13.08.19 16:46, Vladimir Sementsov-Ogievskiy wrote: >>> 13.08.2019 17:31, Max Reitz wrote: On 13.08.19 13:51, Kevin Wolf wrote: [...] > Hm... This is a mess. :-) Just

Re: [Qemu-devel] [PATCH-for-4.2 v1 6/6] s390x/mmu: Factor out storage key handling

2019-08-13 Thread Cornelia Huck
On Mon, 12 Aug 2019 13:27:37 +0200 David Hildenbrand wrote: > Factor it out, add a comment how it all works, and also use it in the > REAL MMU. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 114 +++--- > 1 file changed, 69

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 18:03, Max Reitz wrote: > On 13.08.19 16:56, Vladimir Sementsov-Ogievskiy wrote: >> 13.08.2019 17:43, Max Reitz wrote: >>> On 13.08.19 13:04, Kevin Wolf wrote: Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > BDRV_BLOCK_RAW makes generic

[Qemu-devel] [PULL 20/29] Include qemu/main-loop.h less

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). It includes block/aio.h, which in turn includes qemu/event_notifier.h, qemu/notify.h, qemu/processor.h, qemu/qsp.h,

[Qemu-devel] [PULL 25/29] numa: Move remaining NUMA declarations from sysemu.h to numa.h

2019-08-13 Thread Markus Armbruster
Commit e35704ba9c "numa: Move NUMA declarations from sysemu.h to numa.h" left a few NUMA-related macros behind. Move them now. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eduardo Habkost Message-Id:

[Qemu-devel] [PULL 23/29] numa: Don't include hw/boards.h into sysemu/numa.h

2019-08-13 Thread Markus Armbruster
sysemu/numa.h includes hw/boards.h just for the CPUArchId typedef, at the cost of pulling in more than two dozen extra headers indirectly. I could move the typedef from hw/boards.h to qemu/typedefs.h. But it's used in just two headers: boards.h and numa.h. I could move it to another header both

[Qemu-devel] [PULL 28/29] sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing sysemu/sysemu.h triggers a recompile of some 1800 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h, down from 5400 due to the previous commit). Several headers include sysemu/sysemu.h just to get typedef

Re: [Qemu-devel] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ

2019-08-13 Thread Peter Maydell
On Tue, 13 Aug 2019 at 17:44, Cédric Le Goater wrote: > > If an IRQ is allocated and not configured, such as a MSI requested by > a PCI driver, it can be saved in its default state and possibly later > on restored using the same state. If not initially MASKED, KVM will > try to find a matching

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Max Reitz
On 13.08.19 16:14, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 19:37, Vladimir Sementsov-Ogievskiy wrote: >> 12.08.2019 19:11, Max Reitz wrote: >>> On 12.08.19 17:47, Vladimir Sementsov-Ogievskiy wrote: 12.08.2019 18:10, Max Reitz wrote: > On 10.08.19 21:31, Vladimir

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Max Reitz
On 13.08.19 13:51, Kevin Wolf wrote: [...] > Hm... This is a mess. :-) Just out of curiosity: Why? Aren’t there only two things we really need from the block_status infrastructure? (1) Whether something is allocated in the given layer of the backing chain, (2) Whether we know that a given

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Max Reitz
On 13.08.19 17:00, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 17:57, Max Reitz wrote: >> On 13.08.19 16:39, Vladimir Sementsov-Ogievskiy wrote: >>> 13.08.2019 17:23, Max Reitz wrote: On 13.08.19 16:14, Vladimir Sementsov-Ogievskiy wrote: > 12.08.2019 19:37, Vladimir

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Kevin Wolf
Am 13.08.2019 um 16:53 hat Max Reitz geschrieben: > On 13.08.19 16:46, Vladimir Sementsov-Ogievskiy wrote: > > 13.08.2019 17:31, Max Reitz wrote: > >> On 13.08.19 13:51, Kevin Wolf wrote: > >> > >> [...] > >> > >>> Hm... This is a mess. :-) > >> > >> Just out of curiosity: Why? > >> > >> Aren’t

Re: [Qemu-devel] [PATCH 1/6] tests/libqos: Make generic virtio code independent from global_qtest

2019-08-13 Thread Eric Blake
On 8/13/19 4:30 AM, Thomas Huth wrote: > The libqos library functions should never depend on global_qtest, > since these functions might be used in tests that track multiple > test states. Pass around a pointer to the QTestState instead. Thanks for picking up on my initial RFC along these lines a

Re: [Qemu-devel] [PATCH] riscv: hmp: Add a command to show virtual memory mappings

2019-08-13 Thread Palmer Dabbelt
On Wed, 31 Jul 2019 05:49:15 PDT (-0700), bmeng...@gmail.com wrote: This adds 'info mem' command for RISC-V, to show virtual memory mappings that aids debugging. Rather than showing every valid PTE, the command compacts the output by merging all contiguous physical address mappings into one

[Qemu-devel] [PULL 19/29] Include qemu/queue.h slightly less

2019-08-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-20-arm...@redhat.com> --- include/exec/cpu-defs.h | 1 - include/hw/xen/xen_common.h | 1 - include/net/can_emu.h | 1 + include/net/filter.h

[Qemu-devel] [PULL 08/29] Include sysemu/reset.h a lot less

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing sysemu/reset.h triggers a recompile of some 2600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). The main culprit is hw/hw.h, which supposedly includes it for convenience. Include sysemu/reset.h only where it's

[Qemu-devel] [PULL 11/29] typedefs: Separate incomplete types and function types

2019-08-13 Thread Markus Armbruster
While there, drop the obsolete file comment. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-12-arm...@redhat.com> Reviewed-by: Alex Bennée --- include/qemu/typedefs.h | 12 1 file changed,

[Qemu-devel] [PULL 22/29] Include hw/boards.h a bit less

2019-08-13 Thread Markus Armbruster
hw/boards.h pulls in almost 60 headers. The less we include it into headers, the better. As a first step, drop superfluous inclusions, and downgrade some more to what's actually needed. Gets rid of just one inclusion into a header. Cc: Eduardo Habkost Cc: Marcel Apfelbaum Signed-off-by:

[Qemu-devel] [PULL 16/29] Include exec/memory.h slightly less

2019-08-13 Thread Markus Armbruster
Drop unnecessary inclusions from headers. Downgrade a few more to exec/hwaddr.h. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-17-arm...@redhat.com> --- hw/audio/lm4549.h | 1 +

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Kevin Wolf
Am 13.08.2019 um 17:54 hat Vladimir Sementsov-Ogievskiy geschrieben: > 13.08.2019 18:41, Kevin Wolf wrote: > > Am 13.08.2019 um 16:43 hat Max Reitz geschrieben: > >> On 13.08.19 13:04, Kevin Wolf wrote: > >>> Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: >

Re: [Qemu-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-13 Thread Laszlo Ersek
On 08/13/19 16:16, Laszlo Ersek wrote: > Yingwen and Jiewen suggested the following process. > > Legend: > > - "New CPU": CPU being hot-added > - "Host CPU": existing CPU > - (Flash):code running from flash > - (SMM): code running from SMRAM > > Steps: > > (01) New CPU: (Flash) enter

Re: [Qemu-devel] [PATCH-for-4.2 v1 9/9] s390x/cpumodel: Add new TCG features to QEMU cpu model

2019-08-13 Thread Cornelia Huck
On Mon, 5 Aug 2019 17:29:47 +0200 David Hildenbrand wrote: > We now implement a bunch of new facilities we can properly indicate. > > ESOP-1/ESOP-2 handling is discussed in the PoP Chafter 3-15 > ("Suppression on Protection"). The "Basic suppression-on-protection (SOP) > facility" is a core

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 19:08, Kevin Wolf wrote: > Am 13.08.2019 um 17:54 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 13.08.2019 18:41, Kevin Wolf wrote: >>> Am 13.08.2019 um 16:43 hat Max Reitz geschrieben: On 13.08.19 13:04, Kevin Wolf wrote: > Am 12.08.2019 um 20:11 hat Vladimir

Re: [Qemu-devel] [PATCH v3 6/7] block/backup: teach backup_cow_with_bounce_buffer to copy more at once

2019-08-13 Thread Max Reitz
On 13.08.19 18:45, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 19:30, Max Reitz wrote: >> On 13.08.19 17:32, Vladimir Sementsov-Ogievskiy wrote: >>> 13.08.2019 18:02, Max Reitz wrote: On 13.08.19 17:00, Vladimir Sementsov-Ogievskiy wrote: > 13.08.2019 17:57, Max Reitz wrote: >>

Re: [Qemu-devel] [PATCH] usb: reword -usb command-line option and mention xHCI

2019-08-13 Thread Thomas Huth
On 8/13/19 3:30 PM, Stefan Hajnoczi wrote: > The -usb section of the man page is not very clear on what exactly -usb > does and fails to mention xHCI as a modern alternative (-device > nec-usb-xhci). > > Signed-off-by: Stefan Hajnoczi > --- > qemu-options.hx | 7 +-- > 1 file changed, 5

Re: [Qemu-devel] [PULL 0/2] ppc-for-4.1 queue 20190813

2019-08-13 Thread David Gibson
ad66012b2cfb2035003c37eef: > > > > > > display/bochs: fix pcie support (2019-08-12 16:36:41 +0100) > > > > > > are available in the Git repository at: > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190813 > > &g

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

2019-08-13 Thread David Gibson
On Tue, Aug 13, 2019 at 01:00:24PM +0530, Aravinda Prasad wrote: > > > On Monday 12 August 2019 03:38 PM, David Gibson wrote: > > On Mon, Aug 05, 2019 at 02:14:39PM +0530, Aravinda Prasad wrote: > >> Alexey/David, > >> > >> With the SLOF changes, QEMU cannot resize the RTAS blob. Resizing is >

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Max Reitz
On 13.08.19 15:21, Kevin Wolf wrote: > Am 13.08.2019 um 14:01 hat Kevin Wolf geschrieben: >> Am 13.08.2019 um 13:28 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 13.08.2019 14:04, Kevin Wolf wrote: Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > BDRV_BLOCK_RAW

Re: [Qemu-devel] [PATCH 0/2] deal with BDRV_BLOCK_RAW

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 17:31, Max Reitz wrote: > On 13.08.19 13:51, Kevin Wolf wrote: > > [...] > >> Hm... This is a mess. :-) > > Just out of curiosity: Why? > > Aren’t there only two things we really need from the block_status > infrastructure? > > (1) Whether something is allocated in the given layer

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 17:43, Max Reitz wrote: > On 13.08.19 13:04, Kevin Wolf wrote: >> Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to >>> returned file. But is it correct behavior at all? If returned file >>>

Re: [Qemu-devel] [PATCH 3/6] tests/libqtest: Remove unused function hmp()

2019-08-13 Thread Eric Blake
On 8/13/19 4:30 AM, Thomas Huth wrote: > No test is using hmp() anymore, and since this function uses the disliked > global_qtest variable, we should also make sure that nobody adds new code > with this function again. qtest_hmp() should be used instead. > > Signed-off-by: Thomas Huth > --- >

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Kevin Wolf
Am 13.08.2019 um 16:43 hat Max Reitz geschrieben: > On 13.08.19 13:04, Kevin Wolf wrote: > > Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to > >> returned file. But is it correct behavior at all? If

[Qemu-devel] [PULL 18/29] Include hw/hw.h exactly where needed

2019-08-13 Thread Markus Armbruster
In my "build everything" tree, changing hw/hw.h triggers a recompile of some 2600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). The previous commits have left only the declaration of hw_error() in hw/hw.h. This permits dropping most of its inclusions.

[Qemu-devel] [PULL 24/29] Include sysemu/hostmem.h less

2019-08-13 Thread Markus Armbruster
Move the HostMemoryBackend typedef from sysemu/hostmem.h to qemu/typedefs.h. This renders a few inclusions of sysemu/hostmem.h superfluous; drop them. Cc: Eduardo Habkost Cc: Igor Mammedov Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eduardo Habkost

[Qemu-devel] [PULL 10/29] ide: Include hw/ide/internal a bit less outside hw/ide/

2019-08-13 Thread Markus Armbruster
According to hw/ide/internal's file comment, only files in hw/ide/ are supposed to include it. Drag reality slightly closer to supposition. Three includes outside hw/ide remain: hw/arm/sbsa-ref.c, include/hw/ide/pci.h, and include/hw/misc/macio/macio.h. Turns out board code needs ide-internal.h

[Qemu-devel] [PULL 29/29] sysemu: Split sysemu/runstate.h off sysemu/sysemu.h

2019-08-13 Thread Markus Armbruster
sysemu/sysemu.h is a rather unfocused dumping ground for stuff related to the system-emulator. Evidence: * It's included widely: in my "build everything" tree, changing sysemu/sysemu.h still triggers a recompile of some 1100 out of 6600 objects (not counting tests and objects that don't

Re: [Qemu-devel] [PATCH 1/2] block/raw-format: switch to BDRV_BLOCK_DATA with BDRV_BLOCK_RECURSE

2019-08-13 Thread Vladimir Sementsov-Ogievskiy
13.08.2019 18:41, Kevin Wolf wrote: > Am 13.08.2019 um 16:43 hat Max Reitz geschrieben: >> On 13.08.19 13:04, Kevin Wolf wrote: >>> Am 12.08.2019 um 20:11 hat Vladimir Sementsov-Ogievskiy geschrieben: BDRV_BLOCK_RAW makes generic bdrv_co_block_status to fallthrough to returned file. But

[Qemu-devel] [PATCH-for-4.2 v9 03/12] hw/acpi: Add ACPI Generic Event Device Support

2019-08-13 Thread Shameer Kolothum
From: Samuel Ortiz The ACPI Generic Event Device (GED) is a hardware-reduced specific device[ACPI v6.1 Section 5.6.9] that handles all platform events, including the hotplug ones. This patch generates the AML code that defines GEDs. Platforms need to specify their own GED Event bitmap to

Re: [Qemu-devel] [PATCH v2 2/4] block/qcow2: refactor qcow2_co_preadv_part

2019-08-13 Thread Max Reitz
On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > Further patch will run partial requests of iterations of > qcow2_co_preadv in parallel for performance reasons. To prepare for > this, separate part which may be parallelized into separate function > (qcow2_co_preadv_task). > > While being

Re: [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS

2019-08-13 Thread Max Reitz
On 26.06.19 14:39, Sam Eiderman wrote: > Add an interface to provide direct logical CHS values for boot devices. > We will use this interface in the next commits. > > Reviewed-by: Karl Heubaum > Reviewed-by: Arbel Moshe > Signed-off-by: Sam Eiderman > --- > bootdevice.c| 55 >

Re: [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface

2019-08-13 Thread Max Reitz
On 26.06.19 14:39, Sam Eiderman wrote: > v1: > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries (consistent values being reported from BIOS INT13 > AH=08) will most likely break under QEMU/SeaBIOS if

Re: [Qemu-devel] [PATCH v2 1/4] block: introduce aio task pool

2019-08-13 Thread Max Reitz
On 30.07.19 16:18, Vladimir Sementsov-Ogievskiy wrote: > Common interface for aio task loops. To be used for improving > performance of synchronous io loops in qcow2, block-stream, > copy-on-read, and may be other places. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Looks good to me

[Qemu-devel] [PATCH-for-4.2 v9 01/12] hw/acpi: Make ACPI IO address space configurable

2019-08-13 Thread Shameer Kolothum
This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. We are making changes so that MMIO region can be accommodated and board can pass the base address into the aml build function. Also move few MEMORY_* definitions to header so that

[Qemu-devel] [PATCH-for-4.2 v9 02/12] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-08-13 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH-for-4.2 v9 06/12] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-08-13 Thread Shameer Kolothum
This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. With this, both hot and cold plug of device memory is enabled now for Guest with ACPI boot. Memory cold plug support with Guest DT boot is not yet supported.

[Qemu-devel] [PATCH-for-4.2 v9 04/12] hw/arm/virt: Add memory hotplug framework

2019-08-13 Thread Shameer Kolothum
From: Eric Auger This patch adds the memory hot-plug/hot-unplug infrastructure in machvirt. The device memory is not yet exposed to the Guest either through DT or ACPI and hence both cold/hot plug of memory is explicitly disabled for now. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee

Re: [Qemu-devel] [QEMU] [PATCH v5 5/8] bootdevice: Gather LCHS from all relevant devices

2019-08-13 Thread Max Reitz
On 26.06.19 14:39, Sam Eiderman wrote: > Relevant devices are: > * ide-hd (and ide-cd, ide-drive) > * scsi-hd (and scsi-cd, scsi-disk, scsi-block) > * virtio-blk-pci > > We do not call del_boot_device_lchs() for ide-* since we don't need to - > IDE block devices do not support

Re: [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd

2019-08-13 Thread Max Reitz
On 26.06.19 14:39, Sam Eiderman wrote: > We will need to add LCHS removal logic to scsi-hd's unrealize() in the > next commit. > > Reviewed-by: Karl Heubaum > Reviewed-by: Arbel Moshe > Signed-off-by: Sam Eiderman > --- > hw/scsi/scsi-bus.c | 15 +++ > include/hw/scsi/scsi.h |

Re: [Qemu-devel] [PATCH v9 01/11] hw/arm: simplify arm_load_dtb

2019-08-13 Thread Alistair Francis
On Fri, Aug 9, 2019 at 12:01 AM Tao wrote: > > From: Tao Xu > > In struct arm_boot_info, kernel_filename, initrd_filename and > kernel_cmdline are copied from from MachineState. This patch add > MachineState as a parameter into arm_load_dtb() and move the copy chunk > of kernel_filename,

Re: [Qemu-devel] [RFC PATCH v2 04/17] fuzz: Skip modules that were already initialized

2019-08-13 Thread Oleinik, Alexander
On Fri, 2019-08-09 at 10:04 +0100, Stefan Hajnoczi wrote: > On Mon, Aug 05, 2019 at 07:11:05AM +, Oleinik, Alexander wrote: > > Signed-off-by: Alexander Oleinik > > --- > > util/module.c | 7 +++ > > 1 file changed, 7 insertions(+) > > Why is this necessary? Existing callers only

[Qemu-devel] [PATCH-for-4.2 v9 09/12] hw/arm: Use GED for system_powerdown event

2019-08-13 Thread Shameer Kolothum
For machines 4.2 or higher with ACPI boot use GED for system_powerdown event instead of GPIO. Guest boot with DT still uses GPIO. Signed-off-by: Shameer Kolothum --- v8 --> v9 -Re-arranged patches 8 & 9 from v8 based on Igor's comments. v7 --> v8 -Retained gpio based system_powerdown support

[Qemu-devel] [PATCH-for-4.2 v9 12/12] tests: Add bios tests to arm/virt

2019-08-13 Thread Shameer Kolothum
This adds numamem and memhp tests for arm/virt platform Signed-off-by: Shameer Kolothum --- tests/bios-tables-test-allowed-diff.h | 1 + tests/bios-tables-test.c | 49 +++ 2 files changed, 50 insertions(+) diff --git a/tests/bios-tables-test-allowed-diff.h

[Qemu-devel] [PATCH-for-4.2 v9 05/12] hw/arm/virt: Add 4.2 machine type

2019-08-13 Thread Shameer Kolothum
This is in preparation to create ACPI GED device as we need to disable it for <4.2 for migration to work. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ include/hw/boards.h | 3 +++ 3 files changed, 14

[Qemu-devel] [ANNOUNCE] QEMU 4.1.0-rc5 is now available

2019-08-13 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 4.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.1.0-rc5.tar.xz

Re: [Qemu-devel] [PATCH v2] Add git-publish profile for security bugs

2019-08-13 Thread John Snow
On 8/13/19 5:07 AM, Gerd Hoffmann wrote: > Simplifies sending security patches to all people listed in > https://wiki.qemu.org/SecurityProcess. Should also make it > harder to send a copy to the mailing list by accident. > > Signed-off-by: Gerd Hoffmann > --- > .gitpublish | 12

[Qemu-devel] [PATCH-for-4.2 v9 00/12] ARM virt: ACPI memory hotplug support

2019-08-13 Thread Shameer Kolothum
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the

[Qemu-devel] [PATCH-for-4.2 v9 10/12] docs/specs: Add ACPI GED documentation

2019-08-13 Thread Shameer Kolothum
Documents basic concepts of ACPI Generic Event device(GED) and interface between QEMU and the ACPI BIOS. Signed-off-by: Shameer Kolothum --- docs/specs/acpi_hw_reduced_hotplug.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644

[Qemu-devel] [PATCH-for-4.2 v9 08/12] hw/arm: Factor out powerdown notifier from GPIO

2019-08-13 Thread Shameer Kolothum
This is in preparation of using GED device for system_powerdown event. Make the powerdown notifier registration independent of create_gpio() fn. Signed-off-by: Shameer Kolothum --- hw/arm/virt.c | 12 include/hw/arm/virt.h | 1 + 2 files changed, 5 insertions(+), 8

Re: [Qemu-devel] [PATCH v3 11/14] migration: add support to migrate page encryption bitmap

2019-08-13 Thread Dr. David Alan Gilbert
* Singh, Brijesh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, the hypervisor maintains a page > encryption bitmap which is referred by hypervisor during migratoin to check > if page is private or shared. The bitmap is built during the VM bootup and > must be migrated to the

  1   2   3   >