[Qemu-devel] [PATCH 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-06 Thread Maxim Levitsky
Commit 8ac0f15f335 accidently broke the COW of non changed areas of newly allocated clusters, when the write spans multiple clusters, and needs COW both prior and after the write. This results in 'after' COW area beeing encrypted with wrong sector address, which render it corrupted. Bugzilla:

Re: [Qemu-devel] [PATCH 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Maxim Levitsky
On Fri, 2019-09-06 at 13:00 -0500, Eric Blake wrote: > On 9/6/19 12:31 PM, Maxim Levitsky wrote: > > This commit tries to clarify few function arguments, > > and add comments describing the encrypt/decrypt interface > > > > Signed-off-by: Maxim Levitsky > > --- > > block/qcow2-cluster.c | 8

Re: [Qemu-devel] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

2019-09-06 Thread Dr. David Alan Gilbert
* Brad Campbell (lists2...@fnarfbargle.com) wrote: > On 2/9/19 6:23 pm, Brad Campbell wrote: > > > > > Here is the holdup : > > > > 11725@1567416625.003504:qxl_ring_command_check 0 native > > 11725@1567416625.102653:qxl_io_write 0 native addr=0 (QXL_IO_NOTIFY_CMD) > > val=0 size=1 async=0 > >

[Qemu-devel] [RFC 2 PATCH 13/16] machine: Add new epyc property in PCMachineState

2019-09-06 Thread Moger, Babu
Adds new epyc property in PCMachineState and also in MachineState. This property will be used to initialize the mode specific handlers to generate apic ids. Signed-off-by: Babu Moger --- hw/i386/pc.c | 23 +++ include/hw/boards.h |2 ++ include/hw/i386/pc.h |

[Qemu-devel] [RFC 2 PATCH 14/16] hw/i386: Introduce epyc mode function handlers

2019-09-06 Thread Moger, Babu
Introduce following handlers for new epyc mode. x86_apicid_from_cpu_idx_epyc: Generate apicid from cpu index. x86_topo_ids_from_apicid_epyc: Generate topo ids from apic id. x86_apicid_from_topo_ids_epyci: Generate apicid from topo ids. Signed-off-by: Babu Moger --- hw/i386/pc.c |5 + 1

Re: [Qemu-devel] [RFC 2 PATCH 06/16] hw/core: Add core complex id in X86CPU topology

2019-09-06 Thread Eric Blake
On 9/6/19 2:12 PM, Moger, Babu wrote: > Introduce cpu core complex id(ccx_id) in x86CPU topology. > Each CCX can have upto 4 cores and share same L3 cache. > This information is required to build the topology in > new apyc mode. > > Signed-off-by: Babu Moger > --- > +++ b/qapi/machine.json > @@

Re: [Qemu-devel] [PATCH 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

2019-09-06 Thread Maxim Levitsky
On Fri, 2019-09-06 at 14:17 -0500, Eric Blake wrote: > On 9/6/19 12:32 PM, Maxim Levitsky wrote: > > This fixes subltle corruption introduced by luks threaded encryption > > subtle I usually put the commit messages to a spellchecker, but this time I forgot to do this. I will try not to in the

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add test for bz #1745922

2019-09-06 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/263 | 75 ++ tests/qemu-iotests/263.out | 19 ++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100755 tests/qemu-iotests/263 create mode 100644

Re: [Qemu-devel] [PATCH] linux-user: drop redundant handling of environment variables

2019-09-06 Thread Laurent Vivier
Le 06/09/2019 à 18:57, Max Filippov a écrit : > QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to > do it again in main. > > Signed-off-by: Max Filippov > --- > linux-user/main.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/linux-user/main.c

Re: [Qemu-devel] [RFC PATCH 03/20] vl: Add "sgx-epc" option to expose SGX EPC sections to guest

2019-09-06 Thread Larry Dewey
I was playing with the new objects, etc, and found if the user specifies -sgx-epc, and a memory device, but does not specify -cpu host, +sgx, the vm runs without any warnings, while obviously not doing anything to the memory. Perhaps some warnings if not everything which is required is provided?

[Qemu-devel] IOTEST 162

2019-09-06 Thread Maxim Levitsky
Hi! I just had a very fun rabbit hole dive, and I want to share it with you. I notice for some time that iotest 162 fails with that: -qemu-img: Could not open 'json:{"driver": "nbd", "host": 42}': Failed to connect socket: Invalid argument +qemu-img: Could not open 'json:{"driver": "nbd",

Re: [Qemu-devel] [PATCH 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Eric Blake
On 9/6/19 12:31 PM, Maxim Levitsky wrote: > This commit tries to clarify few function arguments, > and add comments describing the encrypt/decrypt interface > > Signed-off-by: Maxim Levitsky > --- > block/qcow2-cluster.c | 8 +++ > block/qcow2-threads.c | 53

Re: [Qemu-devel] [PATCH 0/2] Adding some setsockopt() options

2019-09-06 Thread mailer
Hi Shu-Chun Weng via Qemu-devel! We received your email, but were unable to deliver it because it contains content which has been blacklisted by the list admin. Please remove your application/pkcs7-signature attachments and send again. You are also advised to configure your email client to send

[Qemu-devel] [RFC 2 PATCH 12/16] hw/i386: Introduce apic_id_from_topo_ids handler in PCMachineState

2019-09-06 Thread Moger, Babu
Add function pointer apic_id_from_topo_ids in PCMachineState. Initialize with correct handler based on the mode selected. Also rename the handler apicid_from_topo_ids to x86_apicid_from_topo_ids for consistency. x86_apicid_from_topo_ids will be the default handler. Signed-off-by: Babu Moger ---

[Qemu-devel] [RFC 2 PATCH 08/16] i386: Cleanup and use the new epyc mode topology functions

2019-09-06 Thread Moger, Babu
Use the new epyc mode functions and delete the unused code. Signed-off-by: Babu Moger --- target/i386/cpu.c | 171 +++-- 1 file changed, 48 insertions(+), 123 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

[Qemu-devel] [RFC 2 PATCH 09/16] hw/i386: Introduce initialize_topo_info function

2019-09-06 Thread Moger, Babu
Introduce initialize_topo_info to initialize X86CPUTopoInfo data structure to build the topology. No functional change. Signed-off-by: Babu Moger --- hw/i386/pc.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

[Qemu-devel] [RFC 2 PATCH 06/16] hw/core: Add core complex id in X86CPU topology

2019-09-06 Thread Moger, Babu
Introduce cpu core complex id(ccx_id) in x86CPU topology. Each CCX can have upto 4 cores and share same L3 cache. This information is required to build the topology in new apyc mode. Signed-off-by: Babu Moger --- hw/core/machine-hmp-cmds.c |3 +++ hw/core/machine.c | 13

[Qemu-devel] [PATCH v4 1/4] target/arm: handle M-profile semihosting at translate time

2019-09-06 Thread Alex Bennée
We do this for other semihosting calls so we might as well do it for M-profile as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree v4 - use !IS_USER --- target/arm/m_helper.c | 18

[Qemu-devel] [PATCH v4 4/4] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2019-09-06 Thread Alex Bennée
From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/atomic_template.h

[Qemu-devel] [PATCH v4 2/4] target/arm: handle A-profile semihosting at translate time

2019-09-06 Thread Alex Bennée
As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree, merge T32 & A32 commits - dropped r-b due to changes v4 - !IS_USER and !arm_dc_feature(s,

Re: [Qemu-devel] [PATCH 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Eric Blake
On 9/6/19 1:55 PM, Maxim Levitsky wrote: >>> +/* >>> + * qcow2_co_encrypt() >>> + * >>> + * Encrypts a sector size aligned contiguous area >>> + * >>> + * @host_cluster_offset - on disk offset of the cluster in which >>> + *the buffer resides >>> + * >>> + * @guest_offset

Re: [Qemu-devel] [PATCH v1 18/42] tests/docker: move our mips64 cross compile to Buster

2019-09-06 Thread Aleksandar Markovic
04.09.2019. 23.59, "Alex Bennée" је написао/ла: > > Now Buster is released we can stop relying on the movable feast that > is Sid for our cross-compiler for building tests. > > Signed-off-by: Alex Bennée > --- Reviewed-by: Aleksandar Markovic > tests/docker/Makefile.include

[Qemu-devel] [RFC 2 PATCH 11/16] Introduce-topo_ids_from_apicid-handler

2019-09-06 Thread Moger, Babu
hw/i386: Introduce topo_ids_from_apicid handler PCMachineState Add function pointer topo_ids_from_apicid in PCMachineState. Initialize with correct handler based on mode selected. x86_apicid_from_cpu_idx will be the default handler. Signed-off-by: Babu Moger --- hw/i386/pc.c | 13

[Qemu-devel] [RFC 2 PATCH 10/16] hw/i386: Introduce apicid_from_cpu_idx in PCMachineState

2019-09-06 Thread Moger, Babu
Add function pointers in PCMachineState to handle apic id specific functionalities. This will be used to initialize with correct handlers based on mode selected. x86_apicid_from_cpu_idx will be default handler. Signed-off-by: Babu Moger --- hw/i386/pc.c |5 -

Re: [Qemu-devel] [PATCH v6 1/4] block: Add zoned device model property

2019-09-06 Thread Stefano Garzarella
On Fri, Sep 06, 2019 at 04:17:12PM +, Dmitry Fomichev wrote: > On Fri, 2019-09-06 at 10:11 +0200, Stefano Garzarella wrote: > > On Wed, Sep 04, 2019 at 05:00:57PM -0400, Dmitry Fomichev wrote: > > > This commit adds Zoned Device Model (as defined in T10 ZBC and > > > T13 ZAC standards) as a

Re: [Qemu-devel] [PATCH v8 01/32] riscv: hw: Remove duplicated "hw/hw.h" inclusion

2019-09-06 Thread Alistair Francis
On Fri, Sep 6, 2019 at 9:20 AM Bin Meng wrote: > > Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly > added "hw/hw.h" to sifive_prci.c and sifive_test.c. > > Another inclusion of "hw/hw.h" was later added via > commit 650d103d3ea9 ("Include hw/hw.h exactly where needed"), that >

[Qemu-devel] [PATCH 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

2019-09-06 Thread Maxim Levitsky
This fixes subltle corruption introduced by luks threaded encryption in commit 8ac0f15f335 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922 The corruption happens when we do * write to two or more unallocated clusters at once * write doesn't fully cover nether first nor last

Re: [Qemu-devel] [PATCH 0/2] Adding some setsockopt() options

2019-09-06 Thread Shu-Chun Weng via Qemu-devel
Ping. Patchwork links: http://patchwork.ozlabs.org/patch/1151884/ http://patchwork.ozlabs.org/patch/1151883/ On Thu, Aug 22, 2019 at 4:14 PM Shu-Chun Weng wrote: > Shu-Chun Weng (2): > linux-user: add missing UDP and IPv6 setsockopt options > linux-user: time stamping options for

Re: [Qemu-devel] [PATCH] linux-user: hijack open() for thread directories

2019-09-06 Thread Shu-Chun Weng via Qemu-devel
Ping. Any comments on this? Patchwork: http://patchwork.ozlabs.org/patch/1151167/ On Wed, Aug 21, 2019 at 1:19 PM Shu-Chun Weng wrote: > Besides /proc/self|, files under /proc/thread-self and > /proc/self|/task/ also expose host information to the guest > program. This patch adds them to the

Re: [Qemu-devel] [PATCH v4 13/54] plugin: add user-facing API

2019-09-06 Thread Alex Bennée
Aaron Lindsay OS writes: > One thing I would find useful is the ability to access register values > during an execution-time callback. I think the easiest way to do that > generically would be to expose them via the gdb functionality (like > Pavel's earlier patchset did [1]), though that

[Qemu-devel] [PATCH v2 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-06 Thread Maxim Levitsky
Commit 8ac0f15f335 accidently broke the COW of non changed areas of newly allocated clusters, when the write spans multiple clusters, and needs COW both prior and after the write. This results in 'after' COW area being encrypted with wrong sector address, which render it corrupted. Bugzilla:

[Qemu-devel] [PATCH v2 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Maxim Levitsky
This commit tries to clarify few function arguments, and add comments describing the encrypt/decrypt interface Signed-off-by: Maxim Levitsky --- block/qcow2-cluster.c | 10 +++ block/qcow2-threads.c | 61 ++- 2 files changed, 53 insertions(+), 18

[Qemu-devel] [PATCH v2 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

2019-09-06 Thread Maxim Levitsky
This fixes subtle corruption introduced by luks threaded encryption in commit 8ac0f15f335 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922 The corruption happens when we do a write that * writes to two or more unallocated clusters at once * doesn't fully cover the first sector

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2019-09-06 Thread Rafael David Tinoco
Alright, I couldn't reproduce this yet, I'm running same test case in a 24 cores box and causing lots of context switches and CPU migrations in parallel (trying to exhaust the logic). Will let this running for sometime to check. Unfortunately this can be related QEMU AIO BH locking/primitives

[Qemu-devel] [RFC 2 PATCH 16/16] hw/core: Fix up the machine_set_cpu_numa_node for epyc

2019-09-06 Thread Moger, Babu
Current topology id match will not work for epyc mode when setting the node id. In epyc mode, ids like smt_id, thread_id, core_id, ccx_id, socket_id can be same for more than one CPUs with across two numa nodes. For example, we can have two CPUs with following ids on two different node. 1.

Re: [Qemu-devel] [PATCH v4 00/54] plugins for TCG

2019-09-06 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Hi, >> >> This is the latest iteration of the plugins series. The main changes >> from the last version are: >> >> - dropped passing of haddr to plugins >> >> This makes the code for handling the plugins less invasive in the >> softmmu

Re: [Qemu-devel] [PATCH 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-06 Thread Maxim Levitsky
On Fri, 2019-09-06 at 20:31 +0300, Maxim Levitsky wrote: > Commit 8ac0f15f335 accidently broke the COW of non changed areas > of newly allocated clusters, when the write spans multiple clusters, > and needs COW both prior and after the write. > This results in 'after' COW area beeing encrypted

Re: [Qemu-devel] [PATCH 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

2019-09-06 Thread Eric Blake
On 9/6/19 12:32 PM, Maxim Levitsky wrote: > This fixes subltle corruption introduced by luks threaded encryption subtle > in commit 8ac0f15f335 > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922 > > The corruption happens when we do >* write to two or more unallocated

[Qemu-devel] [PATCH 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-06 Thread Maxim Levitsky
This commit tries to clarify few function arguments, and add comments describing the encrypt/decrypt interface Signed-off-by: Maxim Levitsky --- block/qcow2-cluster.c | 8 +++ block/qcow2-threads.c | 53 ++- 2 files changed, 46 insertions(+), 15

[Qemu-devel] [RFC 2 PATCH 00/16] APIC ID fixes for AMD EPYC CPU models

2019-09-06 Thread Moger, Babu
These series fixes the problems encoding APIC ID for AMD EPYC cpu models. https://bugzilla.redhat.com/show_bug.cgi?id=1728166 This is the second pass to give an idea of the changes required to address the issue. First pass is availabe at https://patchwork.kernel.org/cover/11069785/ Currently,

[Qemu-devel] [RFC 2 PATCH 01/16] numa: Split the numa functionality

2019-09-06 Thread Moger, Babu
To support new epyc mode, we need to know the number of numa nodes in advance to generate apic id correctly. So, split the numa initialization into two. The function parse_numa initializes numa_info and updates nb_numa_nodes. And then parse_numa_node does the numa node initialization.

[Qemu-devel] [RFC 2 PATCH 02/16] hw/i386: Rename X86CPUTopoInfo structure to X86CPUTopoIDs

2019-09-06 Thread Moger, Babu
Rename few data structures related to X86 topology. X86CPUTopoIDs will have individual arch ids. Next patch introduces X86CPUTopoInfo which will have all topology information(like cores, threads etc..). Adds node_id and ccx_id. This will be required to support new epyc mode mode. There is no

Re: [Qemu-devel] [RFC 2 PATCH 06/16] hw/core: Add core complex id in X86CPU topology

2019-09-06 Thread Moger, Babu
On 9/6/19 2:20 PM, Eric Blake wrote: > On 9/6/19 2:12 PM, Moger, Babu wrote: >> Introduce cpu core complex id(ccx_id) in x86CPU topology. >> Each CCX can have upto 4 cores and share same L3 cache. >> This information is required to build the topology in >> new apyc mode. >> >> Signed-off-by:

[Qemu-devel] [PATCH v4 3/4] target/arm: remove run time semihosting checks

2019-09-06 Thread Alex Bennée
Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups v5 - move CONFIG_TCG ifdefs

Re: [Qemu-devel] [PATCH v6 1/4] block: Add zoned device model property

2019-09-06 Thread Dmitry Fomichev
On Fri, 2019-09-06 at 23:10 +0200, Stefano Garzarella wrote: > On Fri, Sep 06, 2019 at 04:17:12PM +, Dmitry Fomichev wrote: > > On Fri, 2019-09-06 at 10:11 +0200, Stefano Garzarella wrote: > > > On Wed, Sep 04, 2019 at 05:00:57PM -0400, Dmitry Fomichev wrote: > > > > This commit adds Zoned

Re: [Qemu-devel] [PATCH] linux-user: hijack open() for thread directories

2019-09-06 Thread mailer
Hi Shu-Chun Weng via Qemu-devel! We received your email, but were unable to deliver it because it contains content which has been blacklisted by the list admin. Please remove your application/pkcs7-signature attachments and send again. You are also advised to configure your email client to send

[Qemu-devel] [RFC 2 PATCH 05/16] hw/i386: Simplify topology Offset/width Calculation

2019-09-06 Thread Moger, Babu
Some parameters are unnecessarily passed for offset/width calculation. Remove those parameters from function prototypes. No functional change. Signed-off-by: Babu Moger --- include/hw/i386/topology.h | 45 ++-- target/i386/cpu.c | 12

[Qemu-devel] [RFC 2 PATCH 15/16] i386: Fix pkg_id offset for epyc mode

2019-09-06 Thread Moger, Babu
Signed-off-by: Babu Moger --- target/i386/cpu.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index f25491a029..f8b1fc5c07 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4094,9 +4094,10 @@ void

[Qemu-devel] [PATCH v4 0/4] semihosting at translate time fixes

2019-09-06 Thread Alex Bennée
Hi Peter, Hopefully this is the final version of the semihosting at translate time patches. I've applied Richard's IS_USER changes and gated the SVN for !M profile. Alex Bennée (3): target/arm: handle M-profile semihosting at translate time target/arm: handle A-profile semihosting at

[Qemu-devel] [PATCH v3 3/5] s390: vfio_pci: Use a PCI Group structure

2019-09-06 Thread Matthew Rosato
From: Pierre Morel We use a S390PCIGroup structure to hold the information related to zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host. Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 42

[Qemu-devel] [PATCH v3 1/5] vfio: vfio_iommu_type1: linux header place holder

2019-09-06 Thread Matthew Rosato
From: Pierre Morel This should be copied from Linux kernel UAPI includes. The version used here is Linux 5.3.0 We define a new device region in vfio.h to be able to get the ZPCI CLP information by reading this region from userland. We create a new file, vfio_zdev.h to define the structure of

[Qemu-devel] [PATCH v3 2/5] s390: PCI: Creation a header dedicated to PCI CLP

2019-09-06 Thread Matthew Rosato
From: Pierre Morel To have a clean separation between s390-pci-bus.h and s390-pci-inst.h headers we export the PCI CLP instructions in a dedicated header. Signed-off-by: Pierre Morel Reviewed-by: Collin Walling --- hw/s390x/s390-pci-bus.h | 1 + hw/s390x/s390-pci-clp.h | 211

[Qemu-devel] [PATCH v3 5/5] s390: vfio_pci: Get zPCI function info from host

2019-09-06 Thread Matthew Rosato
From: Pierre Morel We use the VFIO_REGION_SUBTYPE_ZDEV_CLP subregion of PCI_VENDOR_ID_IBM to retrieve the CLP information the kernel exports. To be compatible with previous kernel versions we fall back on previous predefined values, same as the emulation values, when the region is not found or

Re: [Qemu-devel] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

2019-09-06 Thread Brad Campbell
On 7/9/19 03:03, Dr. David Alan Gilbert wrote: * Brad Campbell (lists2...@fnarfbargle.com) wrote: On 2/9/19 6:23 pm, Brad Campbell wrote: Here is the holdup : 11725@1567416625.003504:qxl_ring_command_check 0 native 11725@1567416625.102653:qxl_io_write 0 native addr=0 (QXL_IO_NOTIFY_CMD)

[Qemu-devel] [PATCH v3 0/5] Retrieving zPCI specific info from QEMU

2019-09-06 Thread Matthew Rosato
Note: These patches by Pierre got lost in the ether a few months back as he has been unavailable to carry them forward. I've made changes based upon comments received on the kernel part of his last version. This patch implement the QEMU part to retrieve ZPCI specific information from the host.

[Qemu-devel] [PATCH v3 4/5] s390: vfio_pci: Use a PCI Function structure

2019-09-06 Thread Matthew Rosato
From: Pierre Morel We use a ClpRspQueryPci structure to hold the information related to zPCI Function. This allows us to be ready to support different zPCI functions and to retrieve the zPCI function information from the host. Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 22

Re: [Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI support

2019-09-06 Thread Laurent Vivier
Le 26/08/2019 à 21:58, Max Filippov a écrit : > Xtensa binaries built for call0 ABI don't rotate register window on > function calls and returns. Invocation of signal handlers from the > kernel is therefore different in windowed and call0 ABIs. > There's currently no way to determine xtensa ELF

Re: [Qemu-devel] [PATCH v2 0/5] fixed up semihosting fixups

2019-09-06 Thread Peter Maydell
On Wed, 4 Sep 2019 at 12:22, Alex Bennée wrote: > > Hi Peter, > > Here is version 2 of the ARM semi-hosting cleanup patches. The re-base > had failed due to a change in the gen_exception_internal_insn API > which now takes the PC instead of offset from pc_next. There is also > the a minor

Re: [Qemu-devel] [PATCH v6 7/8] linux-user: Add support for FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling > formatting of a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h| 3 +++ >

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-06 Thread Daniel P . Berrangé
On Fri, Sep 06, 2019 at 11:29:26AM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 05, 2019 at 06:40:21PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > It is likely that virtiofsd will need to support "management commands" for > > > reconfiguring it at

Re: [Qemu-devel] [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-09-06 Thread Geert Uytterhoeven
On Tue, Jul 9, 2019 at 4:59 PM Bartosz Golaszewski wrote: > pon., 8 lip 2019 o 12:24 Geert Uytterhoeven napisał(a): > > On Mon, Jul 8, 2019 at 11:45 AM Bartosz Golaszewski > > wrote: > > > pt., 5 lip 2019 o 18:05 Geert Uytterhoeven > > > napisał(a): > > > > +static int

[Qemu-devel] [PATCH] tests/Makefile: Do not print the name of the check-block.sh shell script

2019-09-06 Thread Thomas Huth
The check script is already printing out which iotest is currently running, so printing out the name of the check-block.sh shell script looks superfluous here. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-06 Thread Johannes Berg
From: Johannes Berg Signed-off-by: Johannes Berg --- contrib/libvhost-user/libvhost-user.c | 61 +++ contrib/libvhost-user/libvhost-user.h | 3 ++ 2 files changed, 56 insertions(+), 8 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c

Re: [Qemu-devel] [PATCH v2 05/13] qcrypto-luks: simplify masterkey and masterkey length

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:55PM +0300, Maxim Levitsky wrote: > Let the caller allocate masterkey > Always use master key len from the header > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 44 +--- > 1 file changed, 21 insertions(+), 23

Re: [Qemu-devel] [PATCH v2 07/13] qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKS

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:57PM +0300, Maxim Levitsky wrote: > Prior to that patch, the parsed encryptio settings ^^encryption > were alrady stored into the QCryptoBlockLUKS but not ^^already > used anywhere but in qcrypto_block_luks_get_info > >

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-06 Thread Peter Maydell
On Tue, 3 Sep 2019 at 09:40, Auger Eric wrote: > I guess arm_cpu_kvm_set_irq attempting to inject IRQ/FIQ into KVM is > used with userspace GIC emulation, which is not supported along with > GICv3. But anyway, I guess it does not hurt to set vcpu_index2 in > arm_cpu_kvm_set_irq? Having now got

Re: [Qemu-devel] [RFC 3/3] virt: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256

2019-09-06 Thread Peter Maydell
On Tue, 27 Aug 2019 at 17:06, Eric Auger wrote: > > Host kernel within [4.18, 5.3] report an erroneous KVM_MAX_VCPUS=512 > for ARM. The actual capability to instantiate more than 256 vcpus > was fixed in 5.4 with the upgrade of the KVM_IRQ_LINE ABI to support > vcpu id encoded on 12 bits instead

Re: [Qemu-devel] [RFC 3/3] virtiofsd: add virtiofsctl command-line management tool

2019-09-06 Thread Stefan Hajnoczi
On Fri, Sep 06, 2019 at 12:03:15AM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 5, 2019 at 9:13 PM Dr. David Alan Gilbert > wrote: > > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > virtiofsctl can control a running virtiofsd process: > > > > > > usage: ./virtiofsctl COMMAND

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-06 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Thu, Sep 05, 2019 at 06:40:21PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > It is likely that virtiofsd will need to support "management commands" for > > > reconfiguring it at runtime. The first

Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands > for controlling error reporting of a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h| 2 ++ >

Re: [Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-06 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Sep 06, 2019 at 11:23:28AM +0100, Stefan Hajnoczi wrote: > > On Thu, Sep 05, 2019 at 06:27:32PM +0100, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > Introduce a DBus server thread that runs

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-06 Thread Thomas Huth
On 05/09/2019 14.07, Greg Kurz wrote: > On Thu, 5 Sep 2019 13:33:46 +0200 > Thomas Huth wrote: > >> So far we were not testing virtio-9p in Travis yet, since we forgot to >> install libcap-devel. Do it now to get some more test coverage. >> >> Signed-off-by: Thomas Huth >> --- > > Acked-by:

Re: [Qemu-devel] [PULL 0/4] Docs patches

2019-09-06 Thread Daniel P . Berrangé
On Thu, Sep 05, 2019 at 04:34:33PM +0100, Peter Maydell wrote: > On Thu, 5 Sep 2019 at 14:45, Daniel P. Berrangé wrote: > > > > The following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: > > > > Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into > >

Re: [Qemu-devel] [PATCH v6 1/8] linux-user: Add support for semtimedop() syscall

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Add support for semtimedop() emulation. It is based on invocation > of safe_semtimedop(). > > Conversion is left out of safe_semtimedop(), since other safe_xxx() > usually don't contain similar conversions. > >

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Hello, Chris Heinze, le mar. 03 sept. 2019 17:02:15 +0200, a ecrit: > on the guest: > root@guest:~# tcpdump -ni eth0 port 19003 > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes >

Re: [Qemu-devel] [PATCH 10/14] hw/arm/raspi: Define various blocks base addresses

2019-09-06 Thread Philippe Mathieu-Daudé
On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote: > The Raspberry firmware is closed-source. While running it, it > accesses various I/O registers. Logging these accesses as UNIMP > (unimplemented) help to understand what the firmware is doing > (ideally we want it able to boot a Linux kernel). >

Re: [Qemu-devel] [PATCH v6 6/8] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls

2019-09-06 Thread Laurent Vivier
Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls are misc commands > for controlling a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h | 4 >

Re: [Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 06:27:32PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > Introduce a DBus server thread that runs alongside the other virtiofsd > > threads. It processes changes to the /org/qemu/virtiofsd object which > > can be accessed at the

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 06:40:21PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > It is likely that virtiofsd will need to support "management commands" for > > reconfiguring it at runtime. The first use case was proposed by Eryu Guan > > for > >

Re: [Qemu-devel] [RFC Patch] xen/pt: Emulate FLR capability

2019-09-06 Thread Roger Pau Monné
On Fri, Sep 06, 2019 at 05:01:09PM +0800, Chao Gao wrote: > On Thu, Aug 29, 2019 at 12:21:11PM +0200, Roger Pau Monné wrote: > >On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote: > >> Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's > >> perspective, assigned

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-06 Thread Daniel P . Berrangé
On Thu, Sep 05, 2019 at 04:21:33PM +0100, Stefan Hajnoczi wrote: > It is likely that virtiofsd will need to support "management commands" for > reconfiguring it at runtime. The first use case was proposed by Eryu Guan for > getting/setting the current log level. > > I promised to try out DBus as

Re: [Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-06 Thread Daniel P . Berrangé
On Fri, Sep 06, 2019 at 11:23:28AM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 05, 2019 at 06:27:32PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > Introduce a DBus server thread that runs alongside the other virtiofsd > > > threads. It processes

[Qemu-devel] [qemu-web RFC PATCH] Update to Jekyll 4.0

2019-09-06 Thread Thomas Huth
- Update versions in Gemfile - "has_key?" has to be renamed to "key?" in category_archive_plugin.rb - Add .jekyll-cache to .gitignore file Signed-off-by: Thomas Huth --- .gitignore | 1 + Gemfile | 15 +++

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Chris Heinze, le ven. 06 sept. 2019 12:54:24 +0200, a ecrit: > i'm not aware of any (canonical) parameters to set a max size for received > packets Ah, right. > i found no way to configure slirp (in qemu) itself except for the DEFINEs in > the if.h. Yes, that's where it is to be configured

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-06 Thread Thomas Huth
On 05/09/2019 14.18, Greg Kurz wrote: > On Thu, 5 Sep 2019 14:07:01 +0200 > Greg Kurz wrote: > >> On Thu, 5 Sep 2019 13:33:46 +0200 >> Thomas Huth wrote: >> >>> So far we were not testing virtio-9p in Travis yet, since we forgot to >>> install libcap-devel. Do it now to get some more test

Re: [Qemu-devel] [PATCH v2 06/13] qcrypto-block: pass keyslot index rather that pointer to the keyslot

2019-09-06 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:56PM +0300, Maxim Levitsky wrote: > Another minor refactoring > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/crypto/block-luks.c b/crypto/block-luks.c > index

Re: [Qemu-devel] [PATCH v2 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child()

2019-09-06 Thread Peter Maydell
On Fri, 23 Aug 2019 at 15:33, Philippe Mathieu-Daudé wrote: > > First we use ARM_CPU_TYPE_NAME() when we should. > > Then is follow up of [1]: > > This series looks at Eduardo suggestions from [2] > and Thomas commit aff39be0ed97 to replace various > object_initialize + qdev_set_parent_bus

Re: [Qemu-devel] [PATCH v1 00/42] current testing/next queue (podman, docker, ci)

2019-09-06 Thread Alex Bennée
Alex Bennée writes: > Hi All, > > > Please review ;-) The following still need review: unreviewed - 3bf0fc78ddf - Alex Bennée: configure: check if --no-pie is supported first unreviewed - 91debbbd08e - Alex Bennée: tests/docker: add more images to PARTIAL_IMAGES when not on x86_64

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Chris Heinze
hi, On 9/6/19 11:59 AM, Samuel Thibault wrote: [...] >> 16:49:39.430959 IP 10.0.2.2.33294 > 10.0.2.15.19003: UDP, bad length 9000 > >> 1472 > > Just to be sure: did you configure your guest mru to 9000 ? Does the > emulated network hardware card support jumbo frames? hm! all interfaces (host

Re: [Qemu-devel] [PATCH 22/36] cputlb: Fold TLB_RECHECK into TLB_INVALID_MASK

2019-09-06 Thread Peter Maydell
On Tue, 3 Sep 2019 at 17:09, Richard Henderson wrote: > > We had two different mechanisms to force a recheck of the tlb. > > Before TLB_RECHECK was introduced, we had a PAGE_WRITE_INV bit > that would immediate set TLB_INVALID_MASK, which automatically > means that a second check of the tlb entry

Re: [Qemu-devel] [RFC 2/3] virtiofsd: add DBus server to handle log level changes

2019-09-06 Thread Daniel P . Berrangé
On Fri, Sep 06, 2019 at 12:12:23PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Fri, Sep 06, 2019 at 11:23:28AM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 05, 2019 at 06:27:32PM +0100, Dr. David Alan Gilbert wrote: > > > > * Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-06 Thread Alex Bennée
Thomas Huth writes: > On 05/09/2019 14.07, Greg Kurz wrote: >> On Thu, 5 Sep 2019 13:33:46 +0200 >> Thomas Huth wrote: >> >>> So far we were not testing virtio-9p in Travis yet, since we forgot to >>> install libcap-devel. Do it now to get some more test coverage. >>> >>> Signed-off-by:

[Qemu-devel] [PATCH v8 23/32] riscv: sifive_u: Add PRCI block to the SoC

2019-09-06 Thread Bin Meng
Add PRCI mmio base address and size mappings to sifive_u machine, and generate the corresponding device tree node. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - create sifive_u_prci block directly in the

[Qemu-devel] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

2019-09-06 Thread Bin Meng
It is not useful if we only have one management CPU. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - use management cpu count + 1 for the min_cpus Changes in v2: -

[Qemu-devel] [PATCH v8 07/32] riscv: hw: Change to use qemu_log_mask(LOG_GUEST_ERROR, ...) instead

2019-09-06 Thread Bin Meng
Replace the call to hw_error() with qemu_log_mask(LOG_GUEST_ERROR,...) in various sifive models. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - new patch to change to use qemu_log_mask(LOG_GUEST_ERROR,...)

[Qemu-devel] [PATCH v8 14/32] riscv: sifive_e: Drop sifive_mmio_emulate()

2019-09-06 Thread Bin Meng
Use create_unimplemented_device() instead. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: - select UNIMP in sifive_e Kconfig due to applied commit "hw/misc: Add a config switch for the "unimplemented" device" in latest qemu/master Changes in v7: None Changes in

[Qemu-devel] [PATCH v8 16/32] riscv: hart: Extract hart realize to a separate routine

2019-09-06 Thread Bin Meng
Currently riscv_harts_realize() creates all harts based on the same cpu type given in the hart array property. With current implementation it can only create homogeneous harts. Exact the hart realize to a separate routine in preparation for supporting multiple hart arrays. Note the file header

[Qemu-devel] [PATCH v8 19/32] riscv: sifive_u: Update hart configuration to reflect the real FU540 SoC

2019-09-06 Thread Bin Meng
The FU540-C000 includes a 64-bit E51 RISC-V core and four 64-bit U54 RISC-V cores. Currently the sifive_u machine only populates 4 U54 cores. Update the max cpu number to 5 to reflect the real hardware, by creating 2 CPU clusters as containers for RISC-V hart arrays to populate heterogeneous

[Qemu-devel] [PATCH v8 24/32] riscv: sifive_u: Reference PRCI clocks in UART and ethernet nodes

2019-09-06 Thread Bin Meng
Now that we have added a PRCI node, update existing UART and ethernet nodes to reference PRCI as their clock sources, to keep in sync with the Linux kernel device tree. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes

[Qemu-devel] [PATCH v8 08/32] riscv: hw: Remove the unnecessary include of target/riscv/cpu.h

2019-09-06 Thread Bin Meng
The inclusion of "target/riscv/cpu.h" is unnecessary in various sifive model drivers. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: - new patch to remove the unnecessary include of target/riscv/cpu.h

<    1   2   3   >