Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 11, 2019 at 06:04:23PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Eric Blake
On 9/11/19 11:42 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's > g_auto infrastrcture (and thus whatever the compilers hooks are) to > release it on all exits of the block. > > Note this macro has a

Re: [Qemu-devel] [PATCH] Makefile: Remove generated files when doing 'distclean'

2019-09-11 Thread John Snow
On 9/11/19 12:29 PM, Thomas Huth wrote: > When running "make distclean" we currently leave a lot of generated > files in the build directory. Fix that. > > Signed-off-by: Thomas Huth Nice, Reviewed-by: John Snow > --- > Makefile | 6 +++--- > tests/Makefile.include | 12

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 9/11/19 12:40 PM, Eric Blake wrote: > > >> + > >> +#define RCU_READ_LOCK_AUTO g_auto(rcu_read_auto_t) \ > >> +_rcu_read_auto = 'x'; \ > > > > I'm a bit lost at where _rcu_read_auto is declared. (I could understand > > if an earlier macro had

Re: [Qemu-devel] [RFC v2 1/2] docs: vhost-user: add in-band kick/call messages

2019-09-11 Thread Johannes Berg
On Wed, 2019-09-11 at 20:15 +0100, Dr. David Alan Gilbert wrote: > > Extend the protocol slightly, so that a message can be used for kick > > and call instead, if VHOST_USER_PROTOCOL_F_IN_BAND_NOTIFICATIONS is > > negotiated. This in itself doesn't guarantee synchronisation, but both > > sides

Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock

2019-09-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190911164202.31136-1-dgilb...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock Message-id:

Re: [Qemu-devel] [PATCH v2 22/28] s390x/tcg: NC: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > We can process a maximum of 256 bytes, crossing two pages. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 01/17] RISC-V: add vfp field in CPURISCVState

2019-09-11 Thread Richard Henderson
On 9/11/19 10:51 AM, Chih-Min Chao wrote: > Could the VLEN be configurable in cpu initialization but not fixed in > compilation phase ? > Take the integer element as example and the difference should be the > stride of vfp.vreg[x] isn't continuous Do you really want an unbounded amount of

Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-09-11 Thread Rafael David Tinoco
> Zhengui's theory that notify_me doesn't work properly on ARM is more > promising, but he couldn't provide a clear explanation of why he thought > notify_me is involved. In particular, I would have expected notify_me to > be wrong if the qemu_poll_ns call came from aio_ctx_dispatch, for example:

Re: [Qemu-devel] [PATCH v2 19/28] s390x/tcg: MVCLU: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > The last remaining bit is padding with two bytes. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +static void access_memmove_idx(CPUS390XState *env, vaddr dest, vaddr src, > + int size, int dest_idx, int src_idx, > + uintptr_t ra) > +{ > +S390Access srca = access_prepare_idx(env, src,

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 4:33 PM, Eric Blake wrote: > I tried to test this patch, but even with it applied, I still got an > aio-context crasher by attempting an nbd-server-start, nbd-server-add, > nbd-server-stop (intentionally skipping the nbd-server-remove step) on a > domain using iothreads, with a

Re: [Qemu-devel] [Qemu-block] [PATCH] block/create: Do not abort if a block driver is not available

2019-09-11 Thread John Snow
On 9/11/19 6:08 PM, Philippe Mathieu-Daudé wrote: > The 'blockdev-create' QMP command was introduced as experimental > feature in commit b0292b851b8, using the assert() debug call. > It got promoted to 'stable' command in 3fb588a0f2c, but the > assert call was not removed. > > Some block

Re: [Qemu-devel] [PATCH 0/3] Automatic RCU read unlock

2019-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 11, 2019 at 05:41:59PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > This patch uses glib's g_auto mechanism to automatically free > > rcu_read_lock's at the end of the block. Given that

Re: [Qemu-devel] [PATCH 2/3] migration: Use automatic rcu_read unlock in ram.c

2019-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 11, 2019 at 05:42:01PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Use the automatic read unlocker in migration/ram.c; > > only for the cases where the unlock is at the end of the function.

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 9/11/19 11:56 AM, Daniel P. Berrangé wrote: > > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilbert (git) > > wrote: > >> From: "Dr. David Alan Gilbert" > >> > >> RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's > >

Re: [Qemu-devel] [PATCH v2 16/28] s390x/tcg: Fault-safe memmove

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > Replace fast_memmove() variants by access_memmove() variants, that > first try to probe access to all affected pages (maximum is two pages). > > In MVCOS, simply always call access_memmove_as() and drop the TODO > about LAP. LAP is already handled in

Re: [Qemu-devel] [PATCH v2 04/17] RISC-V: add vector extension configure instruction

2019-09-11 Thread Richard Henderson
> +void VECTOR_HELPER(vsetvl)(CPURISCVState *env, uint32_t rs1, uint32_t rs2, > +uint32_t rd) > +{ > +int sew, max_sew, vlmax, vl; > + > +if (rs2 == 0) { > +vector_vtype_set_ill(env); > +riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC()); > +return; >

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Daniel P . Berrangé
On Wed, Sep 11, 2019 at 06:04:23PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > RCU_READ_LOCK_AUTO takes the

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2019-09-11 Thread Rafael David Tinoco
** Also affects: qemu (Ubuntu Ff-series) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Eoan) Importance: Medium Assignee: Rafael David Tinoco (rafaeldtinoco) Status: In

Re: [Qemu-devel] [PATCH v2 17/28] s390x/tcg: MVCS/MVCP: Use access_memmove_idx()

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > As we are moving between address spaces, we can use access_memmove_idx() > without checking for destructive overlaps (especially of real storage > locations): > "Each storage operand is processed left to right. The > storage-operand-consistency

Re: [Qemu-devel] [PATCH v2 21/28] s390x/tcg: XC: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > We can process a maximum of 256 bytes, crossing two pages. While at it, > increment the length once. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 9/11/19 11:42 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's > > g_auto infrastrcture (and thus whatever the compilers hooks are) to > > release it on

[Qemu-devel] [PATCH v2 1/5] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's g_auto infrastructure (and thus whatever the compiler's hooks are) to release it on all exits of the block. Signed-off-by: Dr. David Alan Gilbert --- include/qemu/rcu.h | 18 ++ 1

[Qemu-devel] [PATCH v2 3/5] migration: Use automatic rcu_read unlock in rdma.c

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use the automatic read unlocker in migration/rdma.c. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 57 ++-- 1 file changed, 11 insertions(+), 46 deletions(-) diff --git a/migration/rdma.c

[Qemu-devel] [PATCH v2 0/5] Automatic RCU read unlock

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This patch uses glib's g_auto mechanism to automatically free rcu_read_lock's at the end of the block. Given that humans have a habit of forgetting an error path somewhere it's best to leave it to the compiler. (Note I've found the actual cause of my deadlock

[Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Error path missing an unlock. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/ram.c b/migration/ram.c index 1bb82acfe0..977172ea7e 100644 --- a/migration/ram.c +++ b/migration/ram.c @@

Re: [Qemu-devel] [PATCH v2 25/28] s390x/tcg: MVZ: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > We can process a maximum of 256 bytes, crossing two pages. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 24/28] s390x/tcg: MVN: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > We can process a maximum of 256 bytes, crossing two pages. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

[Qemu-devel] [Bug 1843651] [NEW] m68k fpu bug

2019-09-11 Thread Pierre Muller
Public bug reported: On gcc123 cfarm machine, I was testing m68k executables generated by Free Pascal Compiler. muller@gcc123:~/pas/check$ cat inf.pp function get_double(x : double):double; begin get_double:=x; end; var y : double; py : pbyte; i : byte; begin y:=1.0/0.0;

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 11, 2019 at 06:10:28PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Wed, Sep 11, 2019 at 06:04:23PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrangé

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-11 Thread Laszlo Ersek
On 09/10/19 17:58, Igor Mammedov wrote: > On Mon, 9 Sep 2019 21:15:44 +0200 > Laszlo Ersek wrote: [...] > It looks like fwcfg smi feature negotiation isn't reusable in this case. > I'd prefer not to add another device just for another SMI feature > negotiation/activation. I thought it could be

Re: [Qemu-devel] [PATCH v2] util/hbitmap: strict hbitmap_reset

2019-09-11 Thread John Snow
On 9/11/19 11:13 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.08.2019 19:27, John Snow wrote: >> >> >> On 8/6/19 12:19 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 06.08.2019 19:09, Max Reitz wrote: On 06.08.19 17:26, Vladimir Sementsov-Ogievskiy wrote: > hbitmap_reset has an unobvious

Re: [Qemu-devel] [PATCH V2 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

2019-09-11 Thread Dr. David Alan Gilbert
* Wei Yang (richard.weiy...@gmail.com) wrote: > From: Wei Yang > > In add_to_iovec(), qemu_fflush() will be called if iovec is full. If > this happens, buf_index is reset. Currently, this is not checked and > buf_index would always been adjust with buf size. > > This is not harmful, but will

[Qemu-devel] [PATCH v2 4/5] rcu: Use automatic rc_read unlock in core memory/exec code

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Only in the cases where nothing else interesting happens after the unlock. Signed-off-by: Dr. David Alan Gilbert --- exec.c | 46 + include/exec/ram_addr.h | 8 ++- memory.c| 15

[Qemu-devel] [PATCH v2 2/5] migration: Use automatic rcu_read unlock in ram.c

2019-09-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use the automatic read unlocker in migration/ram.c; only for the cases where the unlock is at the end of the function. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-)

Re: [Qemu-devel] [PATCH v6 4/8] linux-user/syscall: Introduce target_sockaddr_nl

2019-09-11 Thread Philippe Mathieu-Daudé
On Mon, Sep 9, 2019 at 4:23 PM Laurent Vivier wrote: > Le 08/09/2019 à 08:15, Philippe Mathieu-Daudé a écrit : > > Signed-off-by: Philippe Mathieu-Daudé > > Tested-By: Guido Günther > > --- > > linux-user/syscall.c | 6 -- > > linux-user/syscall_defs.h | 7 +++ > > 2 files

Re: [Qemu-devel] [PATCH v2 27/28] s390x/tcg: MVO: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > Each operand can have a maximum length of 16. Make sure to prepare all > reads/writes before writing. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 26 ++ > 1 file changed, 14 insertions(+), 12

[Qemu-devel] [PATCH] block/create: Do not abort if a block driver is not available

2019-09-11 Thread Philippe Mathieu-Daudé
The 'blockdev-create' QMP command was introduced as experimental feature in commit b0292b851b8, using the assert() debug call. It got promoted to 'stable' command in 3fb588a0f2c, but the assert call was not removed. Some block drivers are optional, and bdrv_find_format() might return a NULL

[Qemu-devel] issue related to boot aix 7.1 when I try to use qemu ppc64

2019-09-11 Thread Muolo Vincenzo (S.I.)
Hi to all I try to use ( into VM debian 10 running into VMWARE virtualization environment ) qemu ppc64 version to simulate an AIX 7.1 TL04 OS root@vkvm-acmm:/AIX# qemu-system-ppc64 -version QEMU emulator version 3.1.0 (Debian 1:3.1+dfsg-8+deb10u2) Copyright (c) 2003-2018 Fabrice Bellard

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Eric Blake
On 9/11/19 11:56 AM, Daniel P. Berrangé wrote: > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's spurious double space >> g_auto infrastrcture (and thus

Re: [Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +srca2 = access_prepare(env, dest, l, MMU_DATA_LOAD, ra); > +desta = access_prepare(env, dest, l, MMU_DATA_STORE, ra); We should find a way to perform this in one step. RWM isn't uncommon... That said, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 03/17] RISC-V: support vector extension csr

2019-09-11 Thread Richard Henderson
On 9/11/19 2:25 AM, liuzhiwei wrote: > @@ -873,7 +925,12 @@ static riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = { > [CSR_FFLAGS] = { fs, read_fflags, write_fflags > }, > [CSR_FRM] = { fs, read_frm, write_frm > }, >

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Sep 11, 2019 at 05:42:00PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > RCU_READ_LOCK_AUTO takes the rcu_read_lock and then uses glib's > > g_auto infrastrcture (and thus whatever the compilers

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Daniel P . Berrangé
On Wed, Sep 11, 2019 at 06:10:28PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Sep 11, 2019 at 06:04:23PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Wed, Sep 11, 2019 at 05:42:00PM

Re: [Qemu-devel] [PATCH 1/3] rcu: Add automatically released rcu_read_lock variant

2019-09-11 Thread Eric Blake
On 9/11/19 12:40 PM, Eric Blake wrote: >> + >> +#define RCU_READ_LOCK_AUTO g_auto(rcu_read_auto_t) \ >> +_rcu_read_auto = 'x'; \ > > I'm a bit lost at where _rcu_read_auto is declared. (I could understand > if an earlier macro had created that typedef via concatenating _ with >

Re: [Qemu-devel] [RFC v2 1/2] docs: vhost-user: add in-band kick/call messages

2019-09-11 Thread Dr. David Alan Gilbert
* Johannes Berg (johan...@sipsolutions.net) wrote: > From: Johannes Berg > > For good reason, vhost-user is currently built asynchronously, that > way better performance can be obtained. However, for certain use > cases such as simulation, this is problematic. > > Consider an event-based

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 12:21 PM, Eric Blake wrote: > On 9/11/19 11:15 AM, Sergio Lopez wrote: >> On creation, the export's AioContext is set to the same one as the >> BlockBackend, while the AioContext in the client QIOChannel is left >> untouched. >> >> As a result, when using data-plane,

Re: [Qemu-devel] [PATCH v2 23/28] s390x/tcg: MVCIN: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > We can process a maximum of 256 bytes, crossing two pages. Calculate the > accessed range upfront - src is accessed right-to-left. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 14 +++--- > 1 file changed, 11

Re: [Qemu-devel] [PATCH 0/3] proper locking on bitmap add/remove paths

2019-09-11 Thread John Snow
On 9/11/19 10:09 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.09.2019 23:37, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20190910162724.79574-1-vsement...@virtuozzo.com/ >> >> >> >> Hi, >> >> This series failed the docker-quick@centos7 build test. Please find the

Re: [Qemu-devel] [PATCH] block/create: Do not abort if a block driver is not available

2019-09-11 Thread Eric Blake
On 9/11/19 5:08 PM, Philippe Mathieu-Daudé wrote: > The 'blockdev-create' QMP command was introduced as experimental > feature in commit b0292b851b8, using the assert() debug call. > It got promoted to 'stable' command in 3fb588a0f2c, but the > assert call was not removed. > > Some block drivers

Re: [Qemu-devel] [PATCH v2 01/17] RISC-V: add vfp field in CPURISCVState

2019-09-11 Thread Richard Henderson
On 9/11/19 2:25 AM, liuzhiwei wrote: > uint64_t fpr[32]; /* assume both F and D extensions */ > + > +/* vector coprocessor state. */ > +struct { > +union VECTOR { > +float64 f64[VUNIT(64)]; > +float32 f32[VUNIT(32)]; > +float16

Re: [Qemu-devel] [PATCH] nbd/server: attach client channel to the export's AioContext

2019-09-11 Thread Eric Blake
On 9/11/19 11:15 AM, Sergio Lopez wrote: > On creation, the export's AioContext is set to the same one as the > BlockBackend, while the AioContext in the client QIOChannel is left > untouched. > > As a result, when using data-plane, nbd_client_receive_next_request() > schedules coroutines in the

Re: [Qemu-devel] [PATCH v2 18/28] s390x/tcg: MVC: Fault-safe handling on destructive overlaps

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +static S390Access access_prepare(CPUS390XState *env, vaddr vaddr, int size, > + MMUAccessType access_type, uintptr_t ra) > +{ > +int mmu_idx = cpu_mmu_index(env, false); > + > +return access_prepare_idx(env,

Re: [Qemu-devel] [PATCH v2 26/28] s390x/tcg: MVST: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +/* > + * Our access should not exceed single pages, as we must not report > access > + * exceptions exceeding the actually copied range (which we don't know at > + * this point). We might over-indicate watchpoints within the pages > +

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Stop overwriting compressed clusters one by one

2019-09-11 Thread John Snow
On 9/11/19 11:16 AM, Alberto Garcia wrote: > handle_alloc() tries to find as many contiguous clusters that need > copy-on-write as possible in order to allocate all of them at the same > time. > > However, compressed clusters are only overwritten one by one, so let's > say that we have an

[Qemu-devel] [PATCH v4 4/4] iotests: use python logging for iotests.log()

2019-09-11 Thread John Snow
We can turn logging on/off globally instead of per-function. Remove use_log from run_job, and use python logging to turn on diffable output when we run through a script entry point. iotest 245 changes output order due to buffering reasons. Signed-off-by: John Snow --- tests/qemu-iotests/030

[Qemu-devel] [PATCH v4 2/4] iotest 258: use script_main

2019-09-11 Thread John Snow
Since this one is nicely factored to use a single entry point, use script_main to run the tests. Signed-off-by: John Snow --- tests/qemu-iotests/258 | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/258 b/tests/qemu-iotests/258 index

[Qemu-devel] [PATCH] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-11 Thread Paul A. Clarke
From: "Paul A. Clarke" ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. This patch adds support for 'mffscrn' and 'mffscrni' instructions. 'mffscrn' and 'mffscrni' are identical to 'mffsl', except

Re: [Qemu-devel] [PATCH 6/7] spapr: Stop providing RTAS blob

2019-09-11 Thread Alexey Kardashevskiy
On 11/09/2019 19:16, Greg Kurz wrote: > On Wed, 11 Sep 2019 14:04:51 +1000 > David Gibson wrote: > >> From: Alexey Kardashevskiy >> >> SLOF implements one itself so let's remove it from QEMU. It is one less >> image and simpler setup as the RTAS blob never stays in its initial place >>

[Qemu-devel] [Bug 1843151] Re: Regression: QEMU 4.1.0 qxl and KMS resoluiton only 4x10

2019-09-11 Thread James Harvey
Comparing the spice debug logs, where I see this with QEMU 4.0.0 without the bug: (remote-viewer:19270): GSpice-DEBUG: 00:05:21.201: channel-display.c:1979 display-2:0: received new monitors config from guest: n: 1/4 (remote-viewer:19270): GSpice-DEBUG: 00:05:21.201: channel-display.c:1997

[Qemu-devel] [Bug 1843151] Re: Regression: QEMU 4.1.0 qxl and KMS resoluiton only 4x10

2019-09-11 Thread James Harvey
Finding a minimal case did shed some light on this. Using QEMU's native graphics window, this works fine: $ /usr/bin/qemu-system-x86_64 \ -m 1G \ -blockdev raw,node-name=install_iso,read-only=on,file.driver=file,file.filename=/mnt/losable/ISOs/archlinux-2019.09.01-x86_64.iso \ -device

[Qemu-devel] [Bug 1843151] Re: Regression: QEMU 4.1.0 qxl and KMS resoluiton only 4x10

2019-09-11 Thread James Harvey
Sorry, in comment #2 for the native graphics window command line, I copied from the wrong trial. The argument for QXL should have been included, because that works with a native graphics window: (...bootindex=0) \ -vga qxl -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH v2 4/4] hw/ppc/pnv: fix checkpatch.pl coding style warnings

2019-09-11 Thread David Gibson
On Wed, Sep 11, 2019 at 07:59:25PM +0530, Balamuruhan S wrote: > There were few trailing comments after `/*` instead in > new line and line more than 80 character, these fixes are > trivial and doesn't change any logic in code. > > Signed-off-by: Balamuruhan S This makes sense independent of

[Qemu-devel] [PATCH v4 0/4] iotests: use python logging

2019-09-11 Thread John Snow
This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the

[Qemu-devel] [PATCH v11 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-09-11 Thread Tao Xu
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[Qemu-devel] [PATCH v11 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-09-11 Thread Tao Xu
This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related to the Memory Proximity Domain. The software is expected to

[Qemu-devel] [PATCH v11 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-09-11 Thread Tao Xu
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory proximity

Re: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build

2019-09-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190912014442.5757-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build Message-id:

[Qemu-devel] [PATCH v11 07/11] numa: Extend CLI to provide memory side cache information

2019-09-11 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Reviewed-by: Daniel Black Signed-off-by: Liu Jingqi Signed-off-by: Tao

[Qemu-devel] [PATCH] docker: add sanitizers back to clang build

2019-09-11 Thread John Snow
Fedora23 is but a distant twinkle. The sanitizer works again, and even if not, we have --enable-sanitizers now. --- The problem is that I do see some ASAN warnings: TESTcheck-qtest-aarch64: tests/device-introspect-test Direct leak of 2272 byte(s) in 48 object(s) allocated from: #0

[Qemu-devel] [PATCH] migration: fix one typo in comment of function migration_total_bytes()

2019-09-11 Thread Wei Yang
Signed-off-by: Wei Yang --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index fbdabd34d9..cae3e894ad 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3023,7 +3023,7 @@ static MigThrError

Re: [Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc()

2019-09-11 Thread Wei Yang
On Fri, Aug 23, 2019 at 09:07:50AM +0800, Wei Yang wrote: >On Thu, Aug 22, 2019 at 12:24:32PM +0200, Paolo Bonzini wrote: >>On 21/03/19 09:25, Wei Yang wrote: >>> PHYS_MAP_NODE_NIL is assigned to PhysPageEntry.ptr in case this is not a >>> leaf entry, while map->nodes_nb range in [0,

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-09-11 Thread Alexey Kardashevskiy
The following changes since commit 0d0b906ae20d763db0f07fc74aef2c355b8474c7: spapr: Render full FDT on ibm,client-architecture-support (2019-09-11 16:22:29 +1000) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20190911 for you to fetch changes up

[Qemu-devel] [PATCH v4] target-arm: Make the counter tick relative to cntfrq

2019-09-11 Thread Andrew Jeffery
Allow machines to configure CNTFRQ via a property if the ARM core supports the generic timer. This is necessary on e.g. the ASPEED AST2600 SoC where the generic timer clock is run at 800MHz or above. The default value for CNTFRQ remains at 62.50MHz (based on GTIMER_SCALE). CNTFRQ is a

Re: [Qemu-devel] Valgrind confused by queue macros

2019-09-11 Thread John Snow
On 9/10/19 9:27 AM, Mark Syms wrote: > Hi, > > While trying to track down an issue in using qemu 4.1 with some development > features we needed/wanted to run valgrind on it to find a memory error. > Unfortunately the form of the queue macros seems to really confuse valgrind > and cause it

[Qemu-devel] [PATCH v11 04/11] tests: Add test for QAPI builtin type time

2019-09-11 Thread Tao Xu
Add tests for time input such as zero, around limit of precision, signed upper limit, actual upper limit, beyond limits, time suffixes, and etc. Signed-off-by: Tao Xu --- No changes in v11. New patch in v10. --- tests/test-keyval.c| 125 +

[Qemu-devel] [PATCH v11 11/11] tests/bios-tables-test: add test cases for ACPI HMAT

2019-09-11 Thread Tao Xu
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for Heterogeneous Memory with boot option '-numa node'. Add test cases on PC and Q35 machines with 2 numa nodes. Because HMAT is generated when system enable numa, the following tables need to be added for this test:

[Qemu-devel] [PATCH v4 3/4] iotests: specify protocol support via initialization info

2019-09-11 Thread John Snow
Switch from verify_protocols to any one of: iotests.main, iotests.script_main, iotests.script_initialize. Signed-off-by: John Snow --- tests/qemu-iotests/207 | 4 ++-- tests/qemu-iotests/210 | 4 ++-- tests/qemu-iotests/211 | 4 ++-- tests/qemu-iotests/212 | 4 ++-- tests/qemu-iotests/213 | 4

[Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-11 Thread John Snow
Like script_main, but doesn't require a single point of entry. Replace all existing initialization sections with this drop-in replacement. This brings debug support to all existing script-style iotests. Note: supported_oses=['linux'] was omitted, as it is a default argument. Signed-off-by: John

Re: [Qemu-devel] issue related to boot aix 7.1 when I try to use qemu ppc64

2019-09-11 Thread da...@gibson.dropbear.id.au
On Wed, Sep 11, 2019 at 03:58:14PM +, Muolo Vincenzo (S.I.) wrote: > Hi to all > > I try to use ( into VM debian 10 running into VMWARE virtualization > environment ) qemu ppc64 version to simulate an AIX 7.1 TL04 OS > > > root@vkvm-acmm:/AIX# qemu-system-ppc64 -version > QEMU emulator

Re: [Qemu-devel] [PATCH 5/7] spapr: Do not put empty properties for -kernel/-initrd/-append

2019-09-11 Thread Alexey Kardashevskiy
On 11/09/2019 18:46, Greg Kurz wrote: > On Wed, 11 Sep 2019 14:04:50 +1000 > David Gibson wrote: > >> From: Alexey Kardashevskiy >> >> We are going to use spapr_build_fdt() for the boot time FDT and as an >> update for SLOF during handling of H_CAS. SLOF will apply all properties >> from the

[Qemu-devel] [PATCH v11 03/11] qapi: Add builtin type time

2019-09-11 Thread Tao Xu
Add optional builtin type time, fallback is uint64. This type use qemu_strtotime_ps() for pre-converting time suffix to numbers. Signed-off-by: Tao Xu --- No changes in v11. New patch in v10. --- include/qapi/visitor-impl.h | 4 include/qapi/visitor.h | 9 +

[Qemu-devel] [PATCH v11 08/11] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-09-11 Thread Tao Xu
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and

[Qemu-devel] [PATCH v11 01/11] util/cutils: Add qemu_strtotime_ps()

2019-09-11 Thread Tao Xu
To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Signed-off-by: Tao Xu --- No changes in v11. New patch in v10. --- include/qemu/cutils.h | 1 + util/cutils.c

[Qemu-devel] [PATCH v11 02/11] tests/cutils: Add test for qemu_strtotime_ps()

2019-09-11 Thread Tao Xu
Test the input of basic, time suffixes, float, invaild, trailing and overflow. Signed-off-by: Tao Xu --- No changes in v11. New patch in v10. --- tests/test-cutils.c | 199 1 file changed, 199 insertions(+) diff --git a/tests/test-cutils.c

[Qemu-devel] [PATCH v11 06/11] numa: Extend CLI to provide memory latency and bandwidth information

2019-09-11 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Signed-off-by: Liu Jingqi

[Qemu-devel] [PATCH v11 10/11] hmat acpi: Build Memory Side Cache Information Structure(s)

2019-09-11 Thread Tao Xu
From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device forms the memory side cache. The software could use this information to effectively place the data in memory to maximize the

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Max Reitz
On 10.09.19 16:52, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> If the driver does not implement bdrv_get_allocated_file_size(), we >> should fall back to cumulating the allocated size of all non-COW >> children instead of just bs->file. >> >> Suggested-by: Vladimir

Re: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id:

[Qemu-devel] [PATCH v2 03/17] RISC-V: support vector extension csr

2019-09-11 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/cpu_bits.h | 15 target/riscv/csr.c | 65 ++--- 2 files changed, 76 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index

[Qemu-devel] [PATCH v2 13/17] RISC-V: add vector extension float instruction part1, add/sub/mul/div

2019-09-11 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 37 + target/riscv/insn32.decode | 37 + target/riscv/insn_trans/trans_rvv.inc.c | 37 + target/riscv/vector_helper.c| 2645 +++ 4 files changed,

[Qemu-devel] [PATCH v2 14/17] RISC-V: add vector extension float instructions part2, sqrt/cmp/cvt/others

2019-09-11 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 40 + target/riscv/insn32.decode | 40 + target/riscv/insn_trans/trans_rvv.inc.c | 54 + target/riscv/vector_helper.c| 2962 +++ 4 files changed,

[Qemu-devel] [PULL v2 02/15] linux-user: Add AT_HWCAP2 for aarch64-linux-user

2019-09-11 Thread Laurent Vivier
From: Richard Henderson Add the HWCAP2_* bits from kernel version v5.3-rc3. Enable the bits corresponding to ARMv8.5-CondM and ARMv8.5-FRINT. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20190809171156.3476-1-richard.hender...@linaro.org> Signed-off-by: Laurent

[Qemu-devel] [PULL v2 13/15] linux-user: Add support for FDFLUSH ioctl

2019-09-11 Thread Laurent Vivier
From: Yunqiang Su FDFLUSH is used for flushing buffers of floppy drives. Support in QEMU is needed because some of Debian packages use this ioctl while running post-build tests. One such example is 'tar' package. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic Reviewed-by:

[Qemu-devel] [PULL v2 03/15] linux-user: erroneous fd_trans_unregister call

2019-09-11 Thread Laurent Vivier
From: Shu-Chun Weng timer_getoverrun returns the "overrun count" for the timer, which is not a file descriptor and thus should not call fd_trans_unregister on it. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier Message-Id: <20190819185348.221825-1-...@google.com> Signed-off-by:

[Qemu-devel] [PULL v2 11/15] linux-user: Add support for RNDRESEEDCRNG ioctl

2019-09-11 Thread Laurent Vivier
From: Aleksandar Markovic RNDRESEEDCRNG is a newer ioctl (added in kernel 4.17), and an "ifdef" guard is used for that reason in this patch. Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1567601968-26946-3-git-send-email-aleksandar.marko...@rt-rk.com>

[Qemu-devel] [PULL v2 10/15] linux-user: drop redundant handling of environment variables

2019-09-11 Thread Laurent Vivier
From: Max Filippov QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to do it again in main. Signed-off-by: Max Filippov Reviewed-by: Laurent Vivier Message-Id: <20190906165736.5612-1-jcmvb...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/main.c | 7 --- 1

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-11 Thread Kevin Wolf
Am 11.09.2019 um 08:20 hat Max Reitz geschrieben: > On 10.09.19 16:52, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> If the driver does not implement bdrv_get_allocated_file_size(), we > >> should fall back to cumulating the allocated size of all non-COW > >>

[Qemu-devel] [PULL v2 08/15] linux-user: Support gdb 'qOffsets' query for ELF

2019-09-11 Thread Laurent Vivier
From: Josh Kunz This is needed to support debugging PIE ELF binaries running under QEMU user mode. Currently, `code_offset` and `data_offset` remain unset for all ELF binaries, so GDB is unable to correctly locate the position of the binary's text and data. The fields `code_offset`, and

  1   2   3   4   >