[PATCH] paaudio: add missing break

2019-10-22 Thread Gerd Hoffmann
CID 1406449 Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index df541a72d3a9..55a91f898073 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -385,6 +385,7 @@ static pa_stream *qpa_simple_new (

[PATCH 1/3] migration/multifd: fix nullptr access in terminating multifd threads

2019-10-22 Thread cenjiahui
From: Jiahui Cen One multifd channel will shutdown all the other multifd's IOChannel when it fails to receive an IOChannel. In this senario, if some multifds had not received its IOChannel yet, it would try to shutdown its IOChannel which could cause nullptr access at qio_channel_shutdown. Here

[PATCH 2/3] migration/multifd: fix destroyed mutex access in terminating multifd threads

2019-10-22 Thread cenjiahui
From: Jiahui Cen One multifd will lock all the other multifds' IOChannel mutex to inform them to quit by setting p->quit or shutting down p->c. In this senario, if some multifds had already been terminated and multifd_load_cleanup/multifd_save_cleanup had destroyed their mutex, it could cause

Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment

2019-10-22 Thread maozy
ping... On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote: Cc'ing qemu-trivial@ On 8/11/18 13:21, Mao Zhongyi wrote: Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé ---   hw/pci/pci_bridge.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] net: add tulip (dec21143) driver

2019-10-22 Thread Jason Wang
On 2019/10/22 下午8:02, Peter Maydell wrote: On Tue, 22 Oct 2019 at 04:30, Jason Wang wrote: On 2019/10/20 上午1:38, Sven Schnelle wrote: This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian

[PATCH 3/3] migration/multifd: fix potential wrong acception order of IOChannel

2019-10-22 Thread cenjiahui
From: Jiahui Cen Multifd assumes the migration thread IOChannel is always established before the multifd IOChannels, but this assumption will be broken in many situations like network packet loss. For example: Step1: Source (migration thread IOChannel) --SYN--> Destination Step2: Source

Re: [PATCH v4 0/3] some fix in tests/migration

2019-10-22 Thread maozy
Hi, patch2 has been merged into the master by Laurent Vivier. patch3 is still not reviewed. So ping... Thanks, Mao On 10/5/19 1:32 AM, Mao Zhongyi wrote: This patchset mainly fixes memory leak, typo and return value of stress function in stress test. v4-v3: p1: - remove redundant g_malloc

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Eric Blake
On 10/22/19 9:28 PM, Zhenyu Ye wrote: I will change the name argument to ENUM, such as, { 'enum': 'IothreadPollProperty', 'data': [ 'max-ns', 'grow', 'shrink' ] } ok, I will correct it, such as, { 'command': 'set-iothread-poll-param', 'data': {'iothread-id': 'str',

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Zhenyu Ye
On 2019/10/23 4:40, Eric Blake wrote: > On 10/22/19 3:12 AM, yezhenyu (A) wrote: >> Since qemu2.9, QEMU added three AioContext poll parameters to struct >> IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are >> used to control iothread polling time. >> >> However, there isn't

[PULL 3/3] iotests: test nbd reconnect

2019-10-22 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20191009084158.15614-4-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake ---

[PULL 2/3] block/nbd: nbd reconnect

2019-10-22 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Implement reconnect. To achieve this: 1. add new modes: connecting-wait: means, that reconnecting is in progress, and there were small number of reconnect attempts, so all requests are waiting for the connection. connecting-nowait: reconnecting

[PULL 1/3] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-10-22 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Introduce a function to gracefully wake a coroutine sleeping in qemu_co_sleep_ns(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Message-Id: <20191009084158.15614-2-vsement...@virtuozzo.com> Signed-off-by: Eric

[PULL 0/3] NBD patches for 2019-10-22

2019-10-22 Thread Eric Blake
The following changes since commit f9bec781379dd7ccf9d01b4b6a79a9ec82c192e5: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191022' into staging (2019-10-22 13:45:09 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-10-22

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Tao Xu
On 10/23/2019 9:13 AM, Eric Blake wrote: On 10/20/19 6:11 AM, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. I haven't yet reviewed the patch itself,

Re: [PATCH v13 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-10-22 Thread Tao Xu
On 10/22/2019 7:22 PM, Markus Armbruster wrote: I just stumbled over this series. It touches the QAPI visitors and even the generator, without cc'ing its maintainers. Such changes require review. There's precious little time until the soft freeze now. I'll try, but no promises. Please cc me

Re: [PATCH v10 3/3] iotests: test nbd reconnect

2019-10-22 Thread Eric Blake
On 10/9/19 3:41 AM, Vladimir Sementsov-Ogievskiy wrote: Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264| 95 +++ tests/qemu-iotests/264.out|

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Eric Blake
On 10/20/19 6:11 AM, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. I haven't yet reviewed the patch itself, but my off-hand observation: picosecond

Re: [PATCH v13 01/12] util/cutils: Add qemu_strtotime_ps()

2019-10-22 Thread Eduardo Habkost
Hi, First of all, sorry for not reviewing this earlier. I thought other people were already looking at the first 4 patches. On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ps" for picosecond, "ns" for

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-10-22 Thread Eric Blake
-20190911..qemu-slof-20191022 git commit ? git -C roms/SLOF shortlog qemu-slof-20190911..qemu-slof-20191022 \ | git commit -F - You can get something similar with less typing as: git sumodule summary | git commit -F - After export MYDIFF=$(git -C roms/SLOF shortlog qemu-slof-20190911..qemu

Re: [PATCH] enable translating statx syscalls on more arches

2019-10-22 Thread Andrew Kelley
bump On 10/16/19 5:01 PM, Andrew Kelley wrote: > Signed-off-by: Andrew Kelley > --- > linux-user/aarch64/syscall_nr.h | 13 ++ > linux-user/arm/syscall_nr.h | 38 > linux-user/i386/syscall_nr.h| 43 >

Re: [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2019-10-22 Thread Alexey Kardashevskiy
19-10-16 12:01:41 >> +1100) >> >> are available in the Git repository at: >> >>    g...@github.com:aik/qemu.git tags/qemu-slof-20191022 >> >> for you to fetch changes up to 8e59d05f71ae783e12a8eb7eb582e0a86ba3d6dc: &g

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-22 Thread Laszlo Ersek (Red Hat)
In reply to : > Is it possible that we're talking about some kind of miscompilation > here, maybe because gcc-9.2.0 is just that tiny bit too spanking > current? I'm riding the trailing edge here (gcc-4.8 in RHEL7) :) [...] -- You

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-22 Thread Michael Weiser
Please ignore the stuff about (!is_zero_cow(bs, m) || true) being optimized out. Of course it isn't. And corruption still occurs with that way of calling only is_zero_cow(). Dunno what I did there. It seems to be even later than I thought. The rest of my testing holds true though. -- You

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-10-22 Thread Michael Weiser
> I tried to reproduce the problem locally, on the same commit, with the > steps you described, but I wasn't lucky. I tried keeping the image on my > home directory (XFS), on tmpfs, and finally on a newly created ext4 > filesystem on a spare LVM volume, but the image just wouldn't break even >

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-22 Thread Eduardo Habkost
On Sun, Oct 20, 2019 at 04:38:06PM +0200, Philippe Mathieu-Daudé wrote: > Ping? Sorry, missed this. queued on machine-next. Pull request will be submitted today or tomorrow. > > On Fri, Oct 11, 2019 at 5:23 PM Igor Mammedov wrote: > > On Thu, 10 Oct 2019 19:35:03 +0200 > > Igor Mammedov

Re: [PATCH v4 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

2019-10-22 Thread Eduardo Habkost
On Mon, Oct 21, 2019 at 06:02:28AM +, Kang, Luwei wrote: > > > > > f9f4cd1..097c953 100644 > > > > > --- a/target/i386/kvm.c > > > > > +++ b/target/i386/kvm.c > > > > > @@ -1811,6 +1811,25 @@ static int kvm_put_msrs(X86CPU *cpu, int level) > > > > > kvm_msr_entry_add(cpu,

[PATCH] target/riscv: PMP violation due to wrong size parameter

2019-10-22 Thread Dayeol Lee
riscv_cpu_tlb_fill() uses the `size` parameter to check PMP violation using pmp_hart_has_privs(). However, if the size is unknown (=0), the ending address will be `addr - 1` as it is `addr + size - 1` in `pmp_hart_has_privs()`. This always causes a false PMP violation on the starting address of

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

2019-10-22 Thread Rod Smith
I managed to check the PPA version just now, and it's working fine. Thanks for the quick fix! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1848556 Title: qemu-img check failing on remote image in

Re: [PATCH for 4.2 v1 00/19] testing/next before softfreeze

2019-10-22 Thread Alex Bennée
Alex Bennée writes: > Hi, > > This is the current status of testing/next. I dropped the Travis arm64 > build due to stability concerns. As far as I can tell Thomas' latest > iotest updates are working fine. If there are any other patches worth > considering before the softfreeze now is the

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Alex Bennée
Thomas Huth writes: > On 22/10/2019 15.48, Alex Bennée wrote: >> >> Max Reitz writes: >> >>> On 22.10.19 15:11, Alex Bennée wrote: Thomas Huth writes: > As discussed here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html > > and

[PATCH v3 2/6] hppa: Add support for LASI chip with i82596 NIC

2019-10-22 Thread Sven Schnelle
From: Helge Deller LASI is a built-in multi-I/O chip which supports serial, parallel, network (Intel i82596 Apricot), sound and other functionalities. LASI has been used in many HP PARISC machines. This patch adds the necessary parts to allow Linux and HP-UX to detect LASI and the network card.

[PATCH v3 4/6] hppa: add emulation of LASI PS2 controllers

2019-10-22 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/hppa/Kconfig| 1 + hw/hppa/lasi.c | 10 +- hw/input/Kconfig | 3 + hw/input/Makefile.objs | 1 + hw/input/lasips2.c | 289 + hw/input/ps2.c | 5 +

[PATCH v3 5/6] hppa: Add emulation of Artist graphics

2019-10-22 Thread Sven Schnelle
This adds emulation of Artist graphics good enough to get a Text console on both Linux and HP-UX. The X11 server from HP-UX also works. Signed-off-by: Sven Schnelle --- hw/display/Kconfig |3 + hw/display/Makefile.objs |1 + hw/display/artist.c | 1336

[PATCH v3 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2019-10-22 Thread Sven Schnelle
From: Helge Deller The tests of the dino chip with the Online-diagnostics CD ("ODE DINOTEST") now succeeds. Additionally add some qemu trace events. Signed-off-by: Helge Deller Signed-off-by: Sven Schnelle Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/hppa/dino.c

[PATCH v3 0/6] HPPA: i82596, PS/2 and graphics emulation

2019-10-22 Thread Sven Schnelle
Hi, these series adds quite a lot to the HPPA emulation in QEMU: i82596 emulation from Helge, PS/2 and Artist graphics emulation. See https://parisc.wiki.kernel.org/index.php/Qemu for a few screenshots of QEMU running a X11/CDE session in HP-UX. Changes in v3: - use BIT() macro in

[PATCH v3 3/6] ps2: accept 'Set Key Make and Break' commands

2019-10-22 Thread Sven Schnelle
HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Eric Blake
On 10/22/19 3:12 AM, yezhenyu (A) wrote: Since qemu2.9, QEMU added three AioContext poll parameters to struct IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are used to control iothread polling time. However, there isn't properly hmp commands to adjust them when the VM is

Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')

2019-10-22 Thread Aleksandar Markovic
On Tuesday, October 8, 2019, Thomas Huth wrote: > When running "make distclean" we currently leave a lot of generated > files in the build directory. These should be completely removed. > Some of the generated files are removed in the "clean" target (which > is a prerequisite for the "distclean"

Re: [PATCH v5 5/7] ppc: Reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Greg Kurz
On Tue, 22 Oct 2019 18:38:10 +0200 Cédric Le Goater wrote: > On the sPAPR machine and PowerNV machine, the interrupt presenters are > created by a machine handler at the core level and are reset > independently. This is not consistent and it raises issues when it > comes to handle hot-plugged

Re: [PATCH 00/10] image-fuzzer: Port to Python 3

2019-10-22 Thread Eduardo Habkost
On Thu, Oct 17, 2019 at 06:29:27PM -0300, Eduardo Habkost wrote: > On Thu, Oct 17, 2019 at 05:11:29PM -0400, John Snow wrote: > > > > > > On 10/16/19 3:24 PM, Eduardo Habkost wrote: > > > This series ports image-fuzzer to Python 3. > > > > > > Eduardo Habkost (10): > > > image-fuzzer: Open

Re: [PATCH V3 2/2] target/i386/kvm: Add Hyper-V direct tlb flush support

2019-10-22 Thread Roman Kagan
On Tue, Oct 22, 2019 at 07:04:11PM +0200, Paolo Bonzini wrote: > On 16/10/19 15:07, lantianyu1...@gmail.com wrote: Somehow this patch never got through to me so I'll reply here. > > From: Tianyu Lan > > > > Hyper-V direct tlb flush targets KVM on Hyper-V guest. > > Enable direct TLB flush for

Re: [PATCH] aspeed: Add an AST2600 eval board

2019-10-22 Thread Cédric Le Goater
On 22/10/2019 19:20, Peter Maydell wrote: > On Tue, 22 Oct 2019 at 18:16, Cédric Le Goater wrote: >> Is it time for me to install an OSX system for dev and tests or is there >> a way to reproduce the issue ? no errors spotted in valgrind. > > I dunno. You could have a look to see if you can

[PATCH v1 18/19] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-22 Thread Alex Bennée
From: Thomas Huth According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be

[PATCH v1 17/19] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-22 Thread Alex Bennée
From: Thomas Huth The next patch is going to add some python-based tests to the "auto" group, and these tests require virtio-blk to work properly. Running iotests without virtio-blk likely does not make too much sense anyway, so instead of adding a check for the availability of virtio-blk to

[PATCH v1 19/19] iotests: Remove 130 from the "auto" group

2019-10-22 Thread Alex Bennée
From: Thomas Huth Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" error with 130 already twice. Looks like this test is a little bit shaky, so for the time being, let's disable it from the "auto" group

[PATCH v1 12/19] tests/vm/netbsd: Disable IPv6

2019-10-22 Thread Alex Bennée
From: Eduardo Habkost Workaround for issues when the host has no IPv6 connectivity. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Message-Id: <20191018181705.17957-4-ehabk...@redhat.com> Signed-off-by: Alex Bennée --- tests/vm/netbsd | 7 +++ 1 file changed, 7 insertions(+)

[PATCH v1 16/19] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-22 Thread Alex Bennée
From: Thomas Huth In the long term, we might want to add test 183 to the "auto" group (but it still fails occasionally, so we cannot do that yet). However, when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it currently always fails with an "Timeout waiting for return

[PATCH v1 08/19] travis.yml: bump Xcode 10 to latest dot release

2019-10-22 Thread Alex Bennée
As 10.3 is available lets use it. I don't know what Apple's deprecation policy is for Xcode because it requires an AppleID to find out. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[PATCH v1 10/19] tests/vm: netbsd autoinstall, using serial console

2019-10-22 Thread Alex Bennée
From: Gerd Hoffmann Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Install to disk, using the serial console. Create qemu user, configure ssh login. Install packages needed for qemu builds. Signed-off-by: Gerd Hoffmann

[PATCH v1 15/19] iotests: Test 041 only works on certain systems

2019-10-22 Thread Alex Bennée
From: Thomas Huth 041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth Message-Id: <20191022072135.11188-3-th...@redhat.com> --- tests/qemu-iotests/041 | 3 ++-

[PATCH v1 09/19] cirrus.yml: add latest Xcode build target

2019-10-22 Thread Alex Bennée
CirrusCI provides a mojave-xcode alias for the latest Xcode available. Let's use it to make sure we track the latest releases. Signed-off-by: Alex Bennée --- .cirrus.yml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 4b042c0e12c..59146a89c83

[PATCH v1 13/19] travis.yml: cache the clang sanitizer build

2019-10-22 Thread Alex Bennée
Hopefully we'll see the same benefits as the other builds. Signed-off-by: Alex Bennée --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index da6a2063fca..c43597f1331 100644 --- a/.travis.yml +++ b/.travis.yml @@ -189,6 +189,7 @@ matrix: - env:

[PATCH v1 14/19] iotests: remove 'linux' from default supported platforms

2019-10-22 Thread Alex Bennée
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH v1 11/19] tests/vm: Let subclasses disable IPv6

2019-10-22 Thread Alex Bennée
From: Eduardo Habkost The mechanism will be used to work around issues related to IPv6 on the netbsd image builder. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191018181705.17957-3-ehabk...@redhat.com> Signed-off-by: Alex Bennée

[PATCH v1 05/19] travis.yml: Fix the ccache lines

2019-10-22 Thread Alex Bennée
From: Thomas Huth The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to abort if ccache is not available. Use an if-statement instead to fix this problem. Signed-off-by: Thomas Huth

[PATCH v1 04/19] travis.yml: Use newer version of libgnutls and libpng

2019-10-22 Thread Alex Bennée
From: Thomas Huth libgnutls-dev and libpng12-dev are not available in newer versions of Ubuntu anymore, so installing these packages fails e.g. in the new arm64 containers on Travis. Let's use newer versions of these packages by default instead. (The old versions still get tested in the "gcc-9"

[PATCH v1 06/19] travis.yml: Test the release tarball

2019-10-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Add a job to generate the release tarball and build/install few QEMU targets from it. Ideally we should build the 'efi' target from the 'roms' directory, but it is too time consuming. This job is only triggered when a tag starting with 'v' is pushed, which is the

[PATCH for 4.2 v1 00/19] testing/next before softfreeze

2019-10-22 Thread Alex Bennée
Hi, This is the current status of testing/next. I dropped the Travis arm64 build due to stability concerns. As far as I can tell Thomas' latest iotest updates are working fine. If there are any other patches worth considering before the softfreeze now is the time to shout. Alex Bennée (5):

[PATCH v1 07/19] cirrus.yml: reduce scope of MacOS build

2019-10-22 Thread Alex Bennée
The MacOS build can time out on Cirrus running to almost an hour. Reduce the scope to the historical MacOS architectures much the same way we do on Travis. Signed-off-by: Alex Bennée --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml

[PATCH v1 02/19] travis.yml: Add libvdeplug-dev to compile-test net/vde.c

2019-10-22 Thread Alex Bennée
From: Thomas Huth This library is needed to compile the VDE network backend. Signed-off-by: Thomas Huth Message-Id: <20191009170701.14756-2-th...@redhat.com> --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 7d90b87540f..7be2a9949f5 100644 ---

[PATCH v1 01/19] travis.yml: reduce scope of the --enable-debug build

2019-10-22 Thread Alex Bennée
Adding debug makes things run a bit slower so lets not hammer all the targets. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- v2 - drop superfluous --enable-debug-tcg in configure string --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH v1 03/19] travis.yml: Use libsdl2 instead of libsdl1.2, and install libsdl2-image

2019-10-22 Thread Alex Bennée
From: Thomas Huth We've removed support for SDL 1.2 quite a while ago already, so let's use SDL 2 now in Travis to get test coverage for SDL again. And while we're at it, also add libsdl2-image-dev which can be used by QEMU nowadays, too. Signed-off-by: Thomas Huth Message-Id:

Re: [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-10-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191022111738.20803-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v14 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Type: series Message-id:

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 15.48, Alex Bennée wrote: > > Max Reitz writes: > >> On 22.10.19 15:11, Alex Bennée wrote: >>> >>> Thomas Huth writes: >>> As discussed here: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html and here:

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-22 Thread Thomas Huth
On 22/10/2019 17.48, Stefan Hajnoczi wrote: > On Mon, Oct 21, 2019 at 02:15:53PM +0200, Thomas Huth wrote: >> On 19/10/2019 08.38, Stefan Hajnoczi wrote: >>> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device >>> Initialization", configuration space and virtqueues cannot be accessed >>>

Re: Missing PVR setting capability

2019-10-22 Thread Thomas Huth
On 22/10/2019 18.24, Wayne Li wrote: > If I run "lsmod | grep kvm" nothing shows up but if I just do a "find . > -name "kvm"" I get the following: [...] > ./sys/devices/virtual/misc/kvm > ./sys/class/misc/kvm > ./sys/kernel/debug/kvm > ./sys/module/kvm > > I guess this shows my OS does have KVM

Re: [PATCH] Semihost SYS_READC implementation

2019-10-22 Thread Keith Packard
Paolo Bonzini writes: Thanks so much for looking at this patch. > I'm a bit confused, why is it not using semihosting_get_chardev? That > would be > > -chardev stdio,id=semihost > -semihosting-config on,chardev=semihost Because I didn't realize the semihosting code already had a

Re: [PATCH 5/5] aspeed/i2c: Add trace events

2019-10-22 Thread Philippe Mathieu-Daudé
Hi Cédric, Sorry for the late reply. On 10/17/19 1:52 PM, Cédric Le Goater wrote: Hello Philippe, On 17/10/2019 12:22, Philippe Mathieu-Daudé wrote: Hi Cédric, On 10/16/19 10:50 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater ---   hw/i2c/aspeed_i2c.c | 93

Re: [PATCH v2 23/28] smbus-eeprom: remove PROP_PTR

2019-10-22 Thread Marc-André Lureau
Hi On Tue, Oct 22, 2019 at 7:19 PM Peter Maydell wrote: > > On Tue, 22 Oct 2019 at 17:24, Marc-André Lureau > wrote: > > > > Instead, set the initial data field directly. > > > > (the initial data is an array of 256 bytes. As I don't know if it may > > change over time, I keep the pointer to

Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

2019-10-22 Thread Laszlo Ersek
(I've been dropped from the address list, not sure why) On 10/22/19 19:17, Christophe de Dinechin wrote: > > Laszlo Ersek writes: > >> On 10/10/19 15:31, Laszlo Ersek wrote: >>> 2nd round: >>> >>> On 10/09/19 15:22, Igor Mammedov wrote: QEMU returns 0, in case of erro or invalid value in

Re: [PATCH 3/5] aspeed: Add a DRAM memory region at the SoC level

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/16/19 10:50 AM, Cédric Le Goater wrote: Currently, we link the DRAM memory region to the FMC model (for DMAs) through a property alias at the SoC level. The I2C model will need a similar region for DMA support, add a DRAM region property at the SoC level for both model to use.

Re: [PATCH 0/5] hw/i386/pc: Extract pc_gsi_create() and pc_i8259_create()

2019-10-22 Thread Philippe Mathieu-Daudé
On 10/22/19 6:55 PM, Paolo Bonzini wrote: On 18/10/19 15:59, Philippe Mathieu-Daudé wrote: These are few patches extracted from the previous too big series: hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html Dropped

Re: [PATCH] aspeed: Add an AST2600 eval board

2019-10-22 Thread Cédric Le Goater
On 22/10/2019 18:43, Peter Maydell wrote: > On Thu, 17 Oct 2019 at 14:54, Peter Maydell wrote: >> >> On Thu, 17 Oct 2019 at 07:33, Joel Stanley wrote: >>> >>> On Wed, 16 Oct 2019 at 09:08, Cédric Le Goater wrote: Define the board with 1 GiB of RAM but some boards can have up to 2

Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

2019-10-22 Thread Christophe de Dinechin
Stefan Hajnoczi writes: [...] > +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t > addr) > +{ > +uint16_t val = qtest_readw(qts, addr); > + > +if (d->features & (1ull << VIRTIO_F_VERSION_1) && qtest_big_endian(qts)) > { For my education, I was wondering why

[PATCH v5 7/7] spapr/xive: Set the OS CAM line at reset

2019-10-22 Thread Cédric Le Goater
When a Virtual Processor is scheduled to run on a HW thread, the hypervisor pushes its identifier in the OS CAM line. When running with kernel_irqchip=off, QEMU needs to emulate the same behavior. Set the OS CAM line when the interrupt presenter of the sPAPR core is reset. This will also cover

Re: [PATCH v2 23/28] smbus-eeprom: remove PROP_PTR

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 17:24, Marc-André Lureau wrote: > > Instead, set the initial data field directly. > > (the initial data is an array of 256 bytes. As I don't know if it may > change over time, I keep the pointer to original buffer as is, but it > might be worth to consider to copy it

Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

2019-10-22 Thread Christophe de Dinechin
Laszlo Ersek writes: > On 10/10/19 15:31, Laszlo Ersek wrote: >> 2nd round: >> >> On 10/09/19 15:22, Igor Mammedov wrote: >>> QEMU returns 0, in case of erro or invalid value in 'Command field', >>> make spec match reality, i.e. >> >> AHA! so this is exactly where you meant to list the

Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 3 +++ > include/hw/char/serial.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 0ae52ec60c..4748a2b023 100644 >

[PATCH v5 6/7] ppc/pnv: Fix naming of routines realizing the CPUs

2019-10-22 Thread Cédric Le Goater
The 'vcpu' suffix is inherited from the sPAPR machine. Use better names for PowerNV. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- hw/ppc/pnv_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c index

Re: [PATCH V3 2/2] target/i386/kvm: Add Hyper-V direct tlb flush support

2019-10-22 Thread Paolo Bonzini
On 16/10/19 15:07, lantianyu1...@gmail.com wrote: > From: Tianyu Lan > > Hyper-V direct tlb flush targets KVM on Hyper-V guest. > Enable direct TLB flush for its guests meaning that TLB > flush hypercalls are handled by Level 0 hypervisor (Hyper-V) > bypassing KVM in Level 1. Due to the

Re: [PATCH 0/5] hw/i386/pc: Extract pc_gsi_create() and pc_i8259_create()

2019-10-22 Thread Paolo Bonzini
On 18/10/19 15:59, Philippe Mathieu-Daudé wrote: > These are few patches extracted from the previous too big series: > hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html > > Dropped "Move kvm_i8259_init() declaration

Re: [PATCH 0/4] mc146818rtc: Allow call object_initialize(MC146818_RTC) instead of rtc_init()

2019-10-22 Thread Paolo Bonzini
On 18/10/19 15:35, Philippe Mathieu-Daudé wrote: > Four RTC146818 patches extracted from a bigger series: > "hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge" > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg03685.html > > This step is required to be able to create a

Re: [PATCH] aspeed: Add an AST2600 eval board

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 18:16, Cédric Le Goater wrote: > Is it time for me to install an OSX system for dev and tests or is there > a way to reproduce the issue ? no errors spotted in valgrind. I dunno. You could have a look to see if you can repro it with the travis builds. I would investigate

Re: [PATCH] aspeed: Add an AST2600 eval board

2019-10-22 Thread Peter Maydell
On Thu, 17 Oct 2019 at 14:54, Peter Maydell wrote: > > On Thu, 17 Oct 2019 at 07:33, Joel Stanley wrote: > > > > On Wed, 16 Oct 2019 at 09:08, Cédric Le Goater wrote: > > > > > > Define the board with 1 GiB of RAM but some boards can have up to 2 > > > GiB. > > > > > > Signed-off-by: Cédric Le

Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 17:42, Marc-André Lureau wrote: > > Hi > > On Tue, Oct 22, 2019 at 6:32 PM Peter Maydell > wrote: > > > > On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau > > wrote: > > Devices shouldn't have properties to set their MMIO base > > address -- instead the memory-mapped

Re: Missing PVR setting capability

2019-10-22 Thread Wayne Li
And yes that is correct it has the e6500 core using PowerPC. On Tue, Oct 22, 2019 at 11:24 AM Wayne Li wrote: > If I run "lsmod | grep kvm" nothing shows up but if I just do a "find . > -name "kvm"" I get the following: > > ./usr/src/kernel/Documentation/virtual/kvm >

[PATCH v2 28/28] Remove QDEV_PROP_PTR

2019-10-22 Thread Marc-André Lureau
No longer used in the tree. The comment about user_creatable is still quite relevant, but there is already a similar comment in qdev-core.h. Reviewed-by: Peter Maydell Signed-off-by: Marc-André Lureau --- hw/core/qdev-properties.c| 18 -- include/hw/qdev-properties.h | 22

Re: [PATCH RESEND v6 0/2] x86: Enable user wait instructions

2019-10-22 Thread Paolo Bonzini
On 11/10/19 09:41, Tao Xu wrote: > UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. > > UMONITOR arms address monitoring hardware using an address. A store > to an address within the specified address range triggers the > monitoring hardware to wake up the processor waiting in

Re: [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386

2019-10-22 Thread Paolo Bonzini
On 17/10/19 18:26, Philippe Mathieu-Daudé wrote: > Commit a6c7040fb09 restricted the rtc-reset-reinjection command > to the I386 target. > Restrict the "qapi/qapi-commands-misc-target.h" header to it too. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/mc146818rtc.c | 2 +- > 1 file

[PATCH v2 27/28] qdev: remove PROP_MEMORY_REGION

2019-10-22 Thread Marc-André Lureau
PROP_MEMORY_REGION was a derivative of PROP_PTR, added in commit ed03d749f3f513b8fb0287757cfda2cb6825f063 (qdev: add MemoryRegion property) and thankfully no longer needed since commit 3eff40dbf44896a8180c86c84dbdefb2eb173fbe (hw/misc: Remove mmio_interface device). Signed-off-by: Marc-André

[PATCH v2 26/28] omap-gpio: remove PROP_PTR

2019-10-22 Thread Marc-André Lureau
Since clocks are not QOM objects, replace PROP_PTR of clocks with setters methods. Move/adapt the existing TODO comment about a clock framework. Reviewed-by: Peter Maydell Signed-off-by: Marc-André Lureau --- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 13 +++--

Re: Missing PVR setting capability

2019-10-22 Thread Wayne Li
If I run "lsmod | grep kvm" nothing shows up but if I just do a "find . -name "kvm"" I get the following: ./usr/src/kernel/Documentation/virtual/kvm ./usr/src/kernel/arch/arm/kvm ./usr/src/kernel/arch/arm64/kvm ./usr/src/kernel/arch/mips/kvm ./usr/src/kernel/arch/powerpc/kvm

[PATCH v5 0/7] ppc: reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Cédric Le Goater
Hello, On the sPAPR machine and PowerNV machine, the interrupt presenters are created by a machine handler at the core level and are reseted independently. This is not consistent and it raises issues when it comes to handle hot-plugged CPUs. In that case, the presenters are not reseted. This is

[PULL v3 00/18] target-arm queue

2019-10-22 Thread Peter Maydell
Changes v2->v3: dropped the aspeed new board patch as it fails in tests/qom-test on OSX (intermittently). thanks -- PMM The following changes since commit f9bec781379dd7ccf9d01b4b6a79a9ec82c192e5: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191022' into staging (2019-10-22

[PATCH v5 2/7] spapr_cpu_core: Implement DeviceClass::reset

2019-10-22 Thread Cédric Le Goater
From: Greg Kurz Since vCPUs aren't plugged into a bus, we manually register a reset handler for each vCPU. We also call this handler at realize time to ensure hot plugged vCPUs are reset before being exposed to the guest. This results in vCPUs being reset twice at machine reset. It doesn't break

[PATCH v5 4/7] ppc/pnv: Add a PnvChip pointer to PnvCore

2019-10-22 Thread Cédric Le Goater
We will use it to reset the interrupt presenter from the CPU reset handler. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- include/hw/ppc/pnv_core.h | 3 +++ hw/ppc/pnv_core.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc/pnv_core.h

[PATCH v5 3/7] ppc/pnv: Introduce a PnvCore reset handler

2019-10-22 Thread Cédric Le Goater
in which individual CPUs are reset. It will ease the introduction of future change reseting the interrupt presenter from the CPU reset handler. Signed-off-by: Cédric Le Goater Reviewed-by: Greg Kurz --- hw/ppc/pnv_core.c | 19 +++ 1 file changed, 15 insertions(+), 4

Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Marc-André Lureau
Hi On Tue, Oct 22, 2019 at 6:32 PM Peter Maydell wrote: > > On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau > wrote: > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 3 +++ > > include/hw/char/serial.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff

[PATCH v5 5/7] ppc: Reset the interrupt presenter from the CPU reset handler

2019-10-22 Thread Cédric Le Goater
On the sPAPR machine and PowerNV machine, the interrupt presenters are created by a machine handler at the core level and are reset independently. This is not consistent and it raises issues when it comes to handle hot-plugged CPUs. In that case, the presenters are not reset. This is less of an

[PATCH v2 19/28] leon3: use qemu_irq framework instead of callback as property

2019-10-22 Thread Marc-André Lureau
"set_pin_in" property is used to define a callback mechanism where the device says "call the callback function, passing it an opaque cookie and a 32-bit value". We already have a generic mechanism for doing that, which is the qemu_irq. So we should just use that. Signed-off-by: Marc-André Lureau

  1   2   3   4   5   >