[PULL 004/108] virtiofsd: Add fuse_lowlevel.c

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" fuse_lowlevel is one of the largest files from the library and does most of the work. Add it separately to keep the diff sizes small. Again this is from upstream fuse-3.8.0 Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr.

[PULL 19/20] hw/char/exynos4210_uart: Add receive DMA support

2020-01-23 Thread Peter Maydell
From: Guenter Roeck To support receive DMA, we need to inform the DMA controller if receive data is available. Otherwise the DMA controller keeps requesting data, causing receive errors. Implement this using an interrupt line. The instantiating code then needs to connect the interrupt with the

[PULL 20/20] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330

2020-01-23 Thread Peter Maydell
From: Guenter Roeck The Exynos4210 serial driver uses an interrupt line to signal if receive data is available. Connect that interrupt with the DMA controller's 'peripheral busy' gpio pin to stop the DMA if there is no more receive data available. Without this patch, receive DMA runs wild and

Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error

2020-01-23 Thread Peter Maydell
On Tue, 21 Jan 2020 at 21:38, Philippe Mathieu-Daudé wrote: > > Missed in 870c034da0b, hopefully reported by Coverity. > > Fixes: Coverity CID 1412793 (Incorrect expression) > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/stm32f4xx_syscfg.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PULL 20/59] target/i386: kvm: initialize microcode revision from KVM

2020-01-23 Thread Paolo Bonzini
KVM can return the host microcode revision as a feature MSR. Use it as the default value for -cpu host. Signed-off-by: Paolo Bonzini Message-Id: <1579544504-3616-4-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 4 target/i386/kvm.c | 5 + 2

[PULL 23/59] hw/ppc/spapr_rtas: Use local MachineState variable

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since we have the MachineState already available locally, use it instead of the global current_machine. Reviewed-by: Greg Kurz Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200121110349.25842-2-phi...@redhat.com> Signed-off-by: Paolo

[PULL 03/59] pvpanic: introduce crashloaded for pvpanic

2020-01-23 Thread Paolo Bonzini
From: zhenwei pi Add bit 1 for pvpanic. This bit means that guest hits a panic, but guest wants to handle error by itself. Typical case: Linux guest runs kdump in panic. It will help us to separate the abnormal reboot from normal operation. Signed-off-by: zhenwei pi Message-Id:

[PULL 48/59] object: return self in object_ref()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau This allow for simpler assignment with ref: foo = object_ref(bar) Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200110153039.1379601-19-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 3 ++-

[PULL 32/59] qdev: remove duplicated qdev_property_add_static() doc

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau The function is already documented in the header. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-3-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[PULL 07/59] hw/display/tcx: Add missing fall through comments

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get: hw/display/tcx.c: In function ‘tcx_dac_writel’: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror=implicit-fallthrough=] 453 | s->dac_index =

[PULL 10/59] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We don't need to explicit these obvious switch fall through comments. Stay consistent with the rest of the codebase. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by:

[PULL 42/59] object: rename link "child" to "target"

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau A child property is a different kind of property. Let's use "target" for the link target. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-14-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 4 ++-- qom/object.c

[PULL 18/59] target/i386: kvm: initialize feature MSRs very early

2020-01-23 Thread Paolo Bonzini
Some read-only MSRs affect the behavior of ioctls such as KVM_SET_NESTED_STATE. We can initialize them once and for all right after the CPU is realized, since they will never be modified by the guest. Reported-by: Qingua Cheng Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Message-Id:

[PULL 09/59] hw/net/imx_fec: Rewrite fall through comments

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/net/imx_fec.c: In function ‘imx_eth_write’: hw/net/imx_fec.c:906:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 906 | if

[PULL 27/59] qom/object: Display more helpful message when a parent is missing

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé QEMU object model is scarse in documentation. Some calls are recursive, and it might be hard to figure out even trivial issues. We can avoid developers to waste time in a debugging session by displaying a simple error message. This commit is also similar to

[PULL 43/59] object: add direct link flag

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Allow the link property to hold the pointer to the target, instead of indirectly through another variable. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-15-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 3

[PULL 32/59] qdev: remove duplicated qdev_property_add_static() doc

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau The function is already documented in the header. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-3-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 10 -- 1 file changed, 10 deletions(-) diff --git

Re: [PATCH 2/2] virtio-balloon: Reject qmp_balloon during hot-unplug

2020-01-23 Thread Julia Suvorova
On Thu, Jan 16, 2020 at 1:36 PM David Hildenbrand wrote: > > On 15.01.20 23:40, Julia Suvorova wrote: > > Hot-unplug takes some time due to communication with the guest. > > Do not change the device while freeing up resources. > > > > Signed-off-by: Julia Suvorova > > --- > > balloon.c

Re: [PATCH 1/3] qemu-nbd: Convert invocation documentation to rST

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 12:43, Eric Blake wrote: > > On 1/16/20 8:15 AM, Peter Maydell wrote: > > The qemu-nbd documentation is currently in qemu-nbd.texi in Texinfo > > format, which we present to the user as: > > * a qemu-nbd manpage > > * a section of the main qemu-doc HTML documentation >

[PULL 57/59] target/i386: Add the 'model-id' for Skylake -v3 CPU models

2020-01-23 Thread Paolo Bonzini
From: Kashyap Chamarthy This fixes a confusion in the help output. (Although, if you squint long enough at the '-cpu help' output, you _do_ notice that "Skylake-Client-noTSX-IBRS" is an alias of "Skylake-Client-v3"; similarly for Skylake-Server-v3.) Without this patch: $ qemu-system-x86

RE: question about handling MSI-X by VFIO

2020-01-23 Thread Thanos Makatos
> > I'm passing through a virtual PCI device to a QEMU guest via VFIO/mdev > and I > > notice that MSI-X interrupts are disabled in the device (MSIXCAP.MXC.MXE > is > > zero) and the BARs containing the table and PBA (4 and 5 in my case) are > never > > accessed. However, whenever I fire an MSI-X

[PULL 22/59] virtio-scsi: convert to new virtio_delete_queue

2020-01-23 Thread Paolo Bonzini
From: Pan Nengyuan Use virtio_delete_queue to make it more clear. Signed-off-by: Pan Nengyuan Reviewed-by: Stefan Hajnoczi Message-Id: <20200117075547.60864-3-pannengy...@huawei.com> Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PULL 33/59] qdev: remove extraneous error

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau All callers use error_abort, and even the function itself calls with error_abort. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-4-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 15 ---

[PULL 05/59] qom/object: Display more helpful message when an interface is missing

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé When adding new devices implementing QOM interfaces, we might forgot to add the Kconfig dependency that pulls the required objects in when building. Since QOM dependencies are resolved at runtime, we don't get any link-time failures, and QEMU aborts while starting:

Re: [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines

2020-01-23 Thread Wainer dos Santos Moschetta
Hi Philippe, That fixes one of the problems I mention in another email thread. I was working on a fix, so putting my hands off it. :) Anyway, see some comments below. On 1/22/20 8:32 PM, Philippe Mathieu-Daudé wrote: Do not remove unavailable machines, this fixes:

[PULL 34/59] qdev: move helper function to monitor/misc

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Move the one-user function to the place it is being used. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200110153039.1379601-5-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 26

[PATCH] Acceptance test: provides to use different transport for migration

2020-01-23 Thread Oksana Vohchana
Along with VM migration via TCP, we can use migration through EXEC and UNIX transport protocol Signed-off-by: Oksana Vohchana --- tests/acceptance/migration.py | 50 --- 1 file changed, 35 insertions(+), 15 deletions(-) diff --git a/tests/acceptance/migration.py

[PULL 14/59] Makefile: Restrict system emulation and tools objects

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Restrict all the system emulation and tools objects with a Makefile IF (CONFIG_SOFTMMU OR CONFIG_TOOLS) check. Using the same description over and over is not very helpful. Use it once, just before the if() block. Reviewed-by: Thomas Huth Signed-off-by: Philippe

[PULL 38/59] qstring: add qstring_free()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Similar to g_string_free(), optionally return the underlying char*. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-10-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 27

[PULL 21/59] virtio-scsi: delete vqs in unrealize to avoid memleaks

2020-01-23 Thread Paolo Bonzini
From: Pan Nengyuan This patch fix memleaks when attaching/detaching virtio-scsi device, the memory leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from: #0 0x7f491f2f2970 (/lib64/libasan.so.5+0xef970) ??:? #1 0x7f491e94649d (/lib64/libglib-2.0.so.0+0x5249d)

[PULL 1/3] Revert "vnc: allow fall back to RAW encoding"

2020-01-23 Thread Gerd Hoffmann
This reverts commit de3f7de7f4e257ce44cdabb90f5f17ee99624557. Remove VNC optimization to reencode framebuffer update as raw if it's smaller than the default encoding. QEMU's implementation was naive and didn't account for the ZLIB z_stream mutating with each compression. Because of the

[PULL 50/59] qdev: move instance properties to class properties

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-21-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/core/qdev.c

[PULL 3/3] ui/console: Display the 'none' backend in '-display help'

2020-01-23 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Commit c388f408b5 added the possibility to list the display backends using '-display help'. Since the 'none' backend is is not implemented as a DisplayChangeListenerOps, it is not registered to the dpys[] array with qemu_display_register(), and is not listed in the

[PULL 0/3] Ui 20200123 patches

2020-01-23 Thread Gerd Hoffmann
The following changes since commit 43d1455cf84283466e5c22a217db5ef4b8197b14: qapi: Fix code generation with Python 3.5 (2020-01-20 12:17:38 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20200123-pull-request for you to fetch changes up

[PULL 03/20] tests/tcg/aarch64: Fix compilation parameters for pauth-%

2020-01-23 Thread Peter Maydell
From: Richard Henderson We were incorrectly requiring ARMv8.4 support for the pauth tests, but Pointer Authentication is an ARMv8.3 extension. Further, hiding the required architecture within asm() is not correct. Correct the architecture version requested, and specify it in the cflags of the

[PULL 000/108] virtiofs queue

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit b7c359c748a2e3ccb97a184b9739feb2cd48de2f: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-01-23 14:38:43 +) are available in the Git repository at:

Re: [PATCH REPOST v3 13/80] arm/imx25_pdk: drop RAM size fixup

2020-01-23 Thread Igor Mammedov
On Thu, 23 Jan 2020 13:39:07 +0100 Andrew Jones wrote: > On Thu, Jan 23, 2020 at 12:37:38PM +0100, Igor Mammedov wrote: > > If user provided non-sense RAM size, board will complain and > > continue running with max RAM size supported. > > Also RAM is going to be allocated by generic code, so it

Re: [PULL 00/17] Linux user for 5.0 patches

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 08:25, Laurent Vivier wrote: > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 > 15:29:25 +) > > are available in the Git

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 1

2020-01-23 Thread Peter Maydell
On Tue, 21 Jan 2020 at 23:41, Palmer Dabbelt wrote: > > The following changes since commit 28b58f19d269633b3d14b6aebf1e92b3cd3ab56e: > > ui/gtk: Get display refresh rate with GDK version 3.22 or later (2020-01-16 > 14:03:45 +) > > are available in the Git repository at: > >

[PATCH v4 20/80] arm/mps2-tz: use memdev for RAM

2020-01-23 Thread Igor Mammedov
memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually

[PULL 011/108] virtiofsd: Fix fuse_daemonize ignored return values

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" QEMU's compiler enables warnings/errors for ignored values and the (void) trick used in the fuse code isn't enough. Turn all the return values into a return value on the function. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Reviewed-by:

[PULL 26/59] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported()

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé KVMState is already accessible via CPUState::kvm_state, use it. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200121110349.25842-5-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- target/arm/kvm.c | 4 +--- 1 file changed,

Re: [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture

2020-01-23 Thread Wainer dos Santos Moschetta
On 1/23/20 9:48 AM, Cornelia Huck wrote: On Wed, 22 Jan 2020 23:32:46 +0100 Philippe Mathieu-Daudé wrote: Running on mainstream KVM architectures, we get: - Aarch64 Timeout. job.log: --- No machine specified, and there is no default Use -machine help to list supported

[PULL 09/59] hw/net/imx_fec: Rewrite fall through comments

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=2: hw/net/imx_fec.c: In function ‘imx_eth_write’: hw/net/imx_fec.c:906:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 906 | if

[PULL 11/59] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We don't need to explicit this obvious switch fall through. Stay consistent with the rest of the codebase. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id:

[PULL 37/59] object: make object_class_property_add* return property

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau This will help calling other ObjectProperty associated functions easily after. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-9-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 24 +---

[PULL 49/59] qdev: rename DeviceClass.props

2020-01-23 Thread Paolo Bonzini
Ensure that conflicts in the future will cause a syntax error. Signed-off-by: Paolo Bonzini --- hw/core/qdev-properties.c | 2 +- hw/core/qdev.c| 8 include/hw/qdev-core.h| 7 ++- qdev-monitor.c| 2 +- qom/qom-qmp-cmds.c| 2 +- 5 files changed,

[PULL 21/59] virtio-scsi: delete vqs in unrealize to avoid memleaks

2020-01-23 Thread Paolo Bonzini
From: Pan Nengyuan This patch fix memleaks when attaching/detaching virtio-scsi device, the memory leak stack is as follow: Direct leak of 21504 byte(s) in 3 object(s) allocated from: #0 0x7f491f2f2970 (/lib64/libasan.so.5+0xef970) ??:? #1 0x7f491e94649d (/lib64/libglib-2.0.so.0+0x5249d)

[PULL 27/59] qom/object: Display more helpful message when a parent is missing

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé QEMU object model is scarse in documentation. Some calls are recursive, and it might be hard to figure out even trivial issues. We can avoid developers to waste time in a debugging session by displaying a simple error message. This commit is also similar to

[PULL 30/59] accel/tcg: Sanitize include path

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Commit af0440ae852 moved the qemu_tcg_configure() function, but introduced extraneous 'include/' in the includes path. As it is not necessary, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Message-Id:

[PULL 08/59] hw/timer/aspeed_timer: Add a fall through comment

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’: hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 283 | if

[PULL 47/59] object: return self in object_ref()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau This allow for simpler assignment with ref: foo = object_ref(bar) Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200110153039.1379601-19-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 3 ++-

[PULL 17/59] hw/core/Makefile: Group generic objects versus system-mode objects

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé To ease review/modifications of this Makefile, group generic objects first, then system-mode specific ones, and finally peripherals (which are only used in system-mode). No logical changes introduced here. Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 03/59] pvpanic: introduce crashloaded for pvpanic

2020-01-23 Thread Paolo Bonzini
From: zhenwei pi Add bit 1 for pvpanic. This bit means that guest hits a panic, but guest wants to handle error by itself. Typical case: Linux guest runs kdump in panic. It will help us to separate the abnormal reboot from normal operation. Signed-off-by: zhenwei pi Message-Id:

[PULL 20/59] target/i386: kvm: initialize microcode revision from KVM

2020-01-23 Thread Paolo Bonzini
KVM can return the host microcode revision as a feature MSR. Use it as the default value for -cpu host. Signed-off-by: Paolo Bonzini Message-Id: <1579544504-3616-4-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 4 target/i386/kvm.c | 5 + 2

[PULL 52/59] vl: print default value in object help

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-23-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object_interfaces.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c

Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}()

2020-01-23 Thread Paolo Bonzini
On 23/01/20 12:39, Marc-André Lureau wrote: > Hi > > On Thu, Jan 23, 2020 at 3:29 PM Paolo Bonzini wrote: >> >> This patch caught my attention because of the typo in the function, but > > Ah! a french "défaut". I suspected that. :) >> I also noticed that get_default is never set to anything

[PULL 29/59] accel: Replace current_machine->accelerator by current_accel() wrapper

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We actually want to access the accelerator, not the machine, so use the current_accel() wrapper instead. Suggested-by: Paolo Bonzini Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200121110349.25842-10-phi...@redhat.com>

Re: [PATCH 2/2] virtio-balloon: Reject qmp_balloon during hot-unplug

2020-01-23 Thread David Hildenbrand
On 23.01.20 15:08, Julia Suvorova wrote: > On Thu, Jan 16, 2020 at 1:36 PM David Hildenbrand wrote: >> >> On 15.01.20 23:40, Julia Suvorova wrote: >>> Hot-unplug takes some time due to communication with the guest. >>> Do not change the device while freeing up resources. >>> >>> Signed-off-by:

[PULL 45/59] object: add object_class_property_add_link()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-17-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 9 + qom/object.c | 46 +- 2 files changed, 54

[PULL 005/108] virtiofsd: Add passthrough_ll

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" passthrough_ll is one of the examples in the upstream fuse project and is the main part of our daemon here. It passes through requests from fuse to the underlying filesystem, using syscalls as directly as possible. >From libfuse fuse-3.8.0 Signed-off-by: Dr.

[PULL 00/20] target-arm queue

2020-01-23 Thread Peter Maydell
-arm.git tags/pull-target-arm-20200123 for you to fetch changes up to 53c75ad8e72dc3a5102de7ed21e4990969cb0a19: hw/arm/exynos4210: Connect serial port DMA busy signals with pl330 (2020-01-23 15:22:42 +) target-arm queue: * fix

[PULL 16/20] hw/char/exynos4210_uart: Convert to support tracing

2020-01-23 Thread Peter Maydell
From: Guenter Roeck Replace debug code with tracing to aid debugging. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck Message-id: 20200123052540.6132-5-li...@roeck-us.net Signed-off-by: Peter Maydell --- hw/char/exynos4210_uart.c | 96 ---

Re: [PULL 000/111] virtiofs queue

2020-01-23 Thread Dr. David Alan Gilbert
t; > Merge remote-tracking branch > > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 > > 15:29:25 +) > > > > are available in the Git repository at: > > > > g...@gitlab.com:dagrh/qemu.git tags/pull-virtiofs-

[PULL 017/108] virtiofsd: add -o source=PATH to help output

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi The -o source=PATH option will be used by most command-line invocations. Let's document it! Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 1 + 1 file changed, 1 insertion(+)

Re: [PULL 000/111] virtiofs queue

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 15:31, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Thu, 23 Jan 2020 at 12:54, Dr. David Alan Gilbert (git) > > wrote: > > > docs/tools/conf.py| 16 + > > > docs/tools/index.rst |

Re: [PATCH v3 2/2] MAINTAINERS: Add an entry for the Siemens SX1 (OMAP310) machines

2020-01-23 Thread Peter Maydell
On Mon, 20 Jan 2020 at 19:00, Philippe Mathieu-Daudé wrote: > > Add the Siemens SX1 (OMAP310) cellphones with the other ARM machines. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

[PULL 50/59] qdev: move instance properties to class properties

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-21-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/hw/core/qdev.c

[PULL 28/59] accel: Introduce the current_accel() wrapper

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The accel/ code only accesses the MachineState::accel field. As we simply want to access the accelerator, not the machine, add a current_accel() wrapper. Suggested-by: Paolo Bonzini Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 00/59] Misc patches for 2020-01-23

2020-01-23 Thread Paolo Bonzini
The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[PULL 13/59] Makefile: Clarify all the codebase requires qom/ objects

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé QEMU user-mode also requires the qom/ objects, it is not only used by "system emulation and qemu-img". As we will use a big if() block, move it upper in the "Common libraries for tools and emulators" section. Reviewed-by: Thomas Huth Signed-off-by: Philippe

[PULL 08/59] hw/timer/aspeed_timer: Add a fall through comment

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’: hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 283 | if

[PULL 41/59] object: check strong flag with

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau The following patch is going to introduce more flags. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-13-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 55/59] qapi/qmp: add ObjectPropertyInfo.default-value

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Report the default value associated with a property. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-26-marcandre.lur...@redhat.com> [Report it as type "any", not string. - Paolo] Signed-off-by: Paolo Bonzini --- qapi/qom.json | 7 ++-

[PULL 25/59] hw/ppc/spapr_rtas: Remove local variable

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We only access this variable in the RTAS_SYSPARM_SPLPAR_CHARACTERISTICS case. Use it in place and remove the local declaration. Suggested-by: Greg Kurz Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200121110349.25842-4-phi...@redhat.com> Signed-off-by:

[PULL 24/59] hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We received a SpaprMachineState argument. Since SpaprMachineState inherits of MachineState, use it instead of calling qdev_get_machine. Reviewed-by: Greg Kurz Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 30/59] accel/tcg: Sanitize include path

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Commit af0440ae852 moved the qemu_tcg_configure() function, but introduced extraneous 'include/' in the includes path. As it is not necessary, remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Message-Id:

[PULL 02/59] cpu: Use cpu_class_set_parent_reset()

2020-01-23 Thread Paolo Bonzini
From: Greg Kurz Convert all targets to use cpu_class_set_parent_reset() with the following coccinelle script: @@ type CPUParentClass; CPUParentClass *pcc; CPUClass *cc; identifier parent_fn; identifier child_fn; @@ +cpu_class_set_parent_reset(cc, child_fn, >parent_fn); -pcc->parent_fn =

[PULL 2/3] vnc: prioritize ZRLE compression over ZLIB

2020-01-23 Thread Gerd Hoffmann
From: Cameron Esfahani In my investigation, ZRLE always compresses better than ZLIB so prioritize ZRLE over ZLIB, even if the client hints that ZLIB is preferred. zlib buffer is always reset in zrle_compress_data(), so using offset to calculate next_out and avail_out is useless. Signed-off-by:

[PULL 37/59] object: add object_property_get_defaut()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau The new callback will be used in following "object: add object_property_set_defaut_{bool,str,int,uint}()" and "vl: print default value in object help" patches. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-8-marcandre.lur...@redhat.com>

[PULL 42/59] object: check strong flag with

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau The following patch is going to introduce more flags. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-13-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 51/59] qdev: register properties as class properties

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Use class properties facilities to add properties to the class during device_class_set_props(). qdev_property_add_static() must be adapted as PropertyInfo now operates with classes (and not instances), so we must set_default_value() on the ObjectProperty, before calling

[PULL 46/59] object: add object_class_property_add_link()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-17-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 9 + qom/object.c | 46 +- 2 files changed, 54

[PULL 19/59] target/i386: add a ucode-rev property

2020-01-23 Thread Paolo Bonzini
Add the property and plumb it in TCG and HVF (the latter of which tried to support returning a constant value but used the wrong MSR). Signed-off-by: Paolo Bonzini Message-Id: <1579544504-3616-3-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 10

[PULL 59/59] tests: fix test-qga on macosx

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Fix Unix socket connection & skip commands that are not implemented. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 +- tests/test-qga.c | 25 ++--- 2 files changed, 19 insertions(+), 8

[PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

2020-01-23 Thread Paolo Bonzini
The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[PULL 06/59] audio/audio: Add missing fall through comment

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get: audio/audio.c: In function ‘audio_pcm_init_info’: audio/audio.c:306:14: error: this statement may fall through [-Werror=implicit-fallthrough=] 306 | sign = 1; |

[RFC 2/2] virtio-rng: add a control queue

2020-01-23 Thread Laurent Vivier
When the linux kernel wants to switch to another device it needs to be able to flush the on-fly requests. Signed-off-by: Laurent Vivier --- hw/core/machine.c | 1 + hw/virtio/trace-events | 6 ++ hw/virtio/virtio-rng.c | 81

[PULL 35/59] object: avoid extra class property key duplication

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Like object properties, no need to duplicate property name, as it is owned already by ObjectProperty value. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-6-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- qom/object.c | 6 +++--- 1

[PULL 05/20] tests/tcg/aarch64: Add pauth-4

2020-01-23 Thread Peter Maydell
From: Richard Henderson Perform the set of operations and test described in LP 1859713. Suggested-by: Adrien GRASSEIN Signed-off-by: Richard Henderson Message-id: 20200116230809.19078-5-richard.hender...@linaro.org [PMM: fixed hard-coded tabs] Signed-off-by: Peter Maydell ---

[PULL 56/59] qdev: use object_property_help()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Use the common function introduced earlier, and report default value. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-27-marcandre.lur...@redhat.com> [Sort the properties, following what is done for -object ...,help. - Paolo] Signed-off-by: Paolo

Re: [PATCH REPOST v3 00/80] refactor main RAM allocation to use hostmem backend

2020-01-23 Thread Laurent Vivier
Le 23/01/2020 à 12:37, Igor Mammedov a écrit : > > v3: > - due to libvirt not being ready, postpone till 5.1 > * [PATCH v2 82/86] numa: forbid '-numa node, mem' for 5.0 and newer > machine types > and depended >[PATCH v2 86/86] numa: remove deprecated implicit RAM

[PULL 12/20] hw/misc/stm32f4xx_syscfg: Fix copy/paste error

2020-01-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé Missed in 870c034da0b, hopefully reported by Coverity. Fixes: Coverity CID 1412793 (Incorrect expression) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-id:

[PULL 28/59] accel: Introduce the current_accel() wrapper

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The accel/ code only accesses the MachineState::accel field. As we simply want to access the accelerator, not the machine, add a current_accel() wrapper. Suggested-by: Paolo Bonzini Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH REPOST v3] target/arm/arch_dump: Add SVE notes

2020-01-23 Thread Peter Maydell
On Mon, 20 Jan 2020 at 10:18, Andrew Jones wrote: > > When dumping a guest with dump-guest-memory also dump the SVE > registers if they are in use. > > Signed-off-by: Andrew Jones > Reviewed-by: Richard Henderson > --- > include/elf.h | 2 + > target/arm/arch_dump.c | 124

Re: [PATCH v3 0/8] Fix Exynos4210 DMA support

2020-01-23 Thread Guenter Roeck
On Thu, Jan 23, 2020 at 03:20:48PM +, Peter Maydell wrote: > On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > > > Commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") > > introduced DMA support for Exynos4210. Unfortunately, it never really > > worked. DMA

[PULL 39/59] object: add object_property_set_default

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Add a default value to ObjectProperty and an implementation of ObjectPropertyInit that uses it. This will make it easier to show the default in help messages. Also provide convenience functions object_property_set_default_{bool, str, int, uint}(). Signed-off-by:

Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > Replace debug logging code with tracing. > > Reviewed-by: Peter Maydell > Signed-off-by: Guenter Roeck This turns out not to compile on OSX, which is a bit stricter about format strings: These two: > +pl330_dmald(uint32_t chan, uint32_t

Re: [qemu-web PATCH] Add "Security Process" information to the main website

2020-01-23 Thread Paolo Bonzini
On 23/01/20 14:59, Thomas Huth wrote: > Anyway, it looks more trustworthy if we present the "Security Process" > information in the static website instead. Thus this patch adds the > information from the wiki to the Jekyll-based website now. Fair enough; here are some edits so that we can improve

[PULL 02/20] target/arm: Fix PAuth sbox functions

2020-01-23 Thread Peter Maydell
From: Vincent Dehors In the PAC computation, sbox was applied over wrong bits. As this is a 4-bit sbox, bit index should be incremented by 4 instead of 16. Test vector from QARMA paper (https://eprint.iacr.org/2016/444.pdf) was used to verify one computation of the pauth_computepac() function

<    1   2   3   4   5   6   7   8   >