Re: [PATCH REPOST v3 79/80] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-23 Thread Thomas Huth
On 23/01/2020 12.38, Igor Mammedov wrote: > Use GString to pass argument to make_cli() so that it would be easy > to dynamically change test case arguments from main(). The follow up > patch will use it to change RAM size options depending on target. > > While at it cleanup 'cli' freeing, using

[PULL 09/20] docs: Create stub system manual

2020-01-23 Thread Peter Maydell
We want a user-facing manual which contains system emulation documentation. Create an empty one which we can populate. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Acked-by: Stefan Hajnoczi Message-id: 20200116141511.16849-3-peter.mayd...@linaro.org --- Makefile | 10

Re: [PULL v2 00/17] virtio, pc: fixes, features

2020-01-23 Thread Peter Maydell
On Wed, 22 Jan 2020 at 06:49, Michael S. Tsirkin wrote: > > Changes from v1: > - add a missing expected file > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging

[RFC 0/2] virtio-rng: add a control queue

2020-01-23 Thread Laurent Vivier
The kernel needs sometime to be able to cancel an ongoing command. For instance, if the virtio-rng device uses the egd backend and this backend doesn't provide data, the buffer provided by the kernel is kept as long as it is needed. On the kernel side, a read blocks until the buffer returns from

[PULL 13/20] dma/pl330: Convert to support tracing

2020-01-23 Thread Peter Maydell
From: Guenter Roeck Replace debug logging code with tracing. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck Message-id: 20200123052540.6132-2-li...@roeck-us.net Signed-off-by: Peter Maydell --- hw/dma/pl330.c | 88 -

[PULL 17/20] hw/char/exynos4210_uart: Implement post_load function

2020-01-23 Thread Peter Maydell
From: Guenter Roeck After restoring a VM, serial parameters need to be updated to reflect restored register values. Implement a post_load function to handle this situation. Reviewed-by: Peter Maydell Signed-off-by: Guenter Roeck Message-id: 20200123052540.6132-6-li...@roeck-us.net

[PULL 012/108] virtiofsd: Fix common header and define for QEMU builds

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" All of the fuse files include config.h and define GNU_SOURCE where we don't have either under our build - remove them. Fixup path to the kernel's fuse.h in the QEMUs world. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture

2020-01-23 Thread Cornelia Huck
On Thu, 23 Jan 2020 11:36:55 -0200 Wainer dos Santos Moschetta wrote: > On 1/23/20 9:48 AM, Cornelia Huck wrote: > > On Wed, 22 Jan 2020 23:32:46 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> Running on mainstream KVM architectures, we get: > >> > >> - Aarch64 > >> > >>Timeout. > >> >

[PULL 018/108] virtiofsd: Open vhost connection instead of mounting

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When run with vhost-user options we conect to the QEMU instead via a socket. Start this off by creating the socket. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Reviewed-by: Misono Tomohiro Signed-off-by: Dr. David Alan Gilbert ---

[PULL 43/59] object: rename link "child" to "target"

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau A child property is a different kind of property. Let's use "target" for the link target. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-14-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 4 ++-- qom/object.c

[PULL 19/59] target/i386: add a ucode-rev property

2020-01-23 Thread Paolo Bonzini
Add the property and plumb it in TCG and HVF (the latter of which tried to support returning a constant value but used the wrong MSR). Signed-off-by: Paolo Bonzini Message-Id: <1579544504-3616-3-git-send-email-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 10

[PULL 45/59] object: express const link with link property

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Let's not mix child property and link property callbacks, as this is confusing, use LinkProperty with DIRECT flag to hold the target pointer. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-16-marcandre.lur...@redhat.com> Signed-off-by: Paolo

[PATCH v8 06/11] hw/core/qdev: handle parent bus change regarding resettable

2020-01-23 Thread Damien Hedde
In qdev_set_parent_bus(), when changing the parent bus of a realized device, if the source and destination buses are not in the same reset state, some adaptations are required. This patch adds needed call to resettable_change_parent() to make sure a device reset state stays coherent with its

[PULL 47/59] object: release all props

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Class properties may have to release resources when the object is destroyed. Let's use the existing release() callback for that, but class properties must not release ObjectProperty, as it can be shared by various instances. Signed-off-by: Marc-André Lureau Message-Id:

[PATCH v8 10/11] vl: replace deprecated qbus_reset_all registration

2020-01-23 Thread Damien Hedde
Replace deprecated qbus_reset_all by resettable_cold_reset_fn for the sysbus reset registration. Apart for the raspi machines, this does not impact the behavior because: + at this point resettable just calls the old reset methods of devices and buses in the same order as qdev/qbus. + resettable

[PULL 38/59] object: make object_class_property_add* return property

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau This will help calling other ObjectProperty associated functions easily after. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-9-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 24 +---

Re: [PATCH REPOST v3 20/80] arm/mps2-tz: use memdev for RAM

2020-01-23 Thread Igor Mammedov
On Thu, 23 Jan 2020 13:59:09 +0100 Andrew Jones wrote: > On Thu, Jan 23, 2020 at 12:37:45PM +0100, Igor Mammedov wrote: > > memory_region_allocate_system_memory() API is going away, so > > replace it with memdev allocated MemoryRegion. The later is > > initialized by generic code, so board only

[PULL 02/59] cpu: Use cpu_class_set_parent_reset()

2020-01-23 Thread Paolo Bonzini
From: Greg Kurz Convert all targets to use cpu_class_set_parent_reset() with the following coccinelle script: @@ type CPUParentClass; CPUParentClass *pcc; CPUClass *cc; identifier parent_fn; identifier child_fn; @@ +cpu_class_set_parent_reset(cc, child_fn, >parent_fn); -pcc->parent_fn =

[PULL 04/59] pvpanic: implement crashloaded event handling

2020-01-23 Thread Paolo Bonzini
From: zhenwei pi Handle bit 1 write, then post event to monitor. Suggested by Paolo, declear a new event, using GUEST_PANICKED could cause upper layers to react by shutting down or rebooting the guest. In advance for extention, add GuestPanicInformation in event message. Signed-off-by:

[PULL 58/59] build-sys: clean up flags included in the linker command line

2020-01-23 Thread Paolo Bonzini
Some of the CFLAGS that are discovered during configure, for example compiler warnings, are being included on the linker command line because QEMU_CFLAGS is added to it. Other flags, such as the -m32, appear twice because they are included in both QEMU_CFLAGS and LDFLAGS. All this leads to

[PULL 31/59] object: add extra sanity checks

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Type system checked that children class_size >= parent class_size, but not instances. Fix that. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200110153039.1379601-2-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini ---

[PULL 26/59] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported()

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé KVMState is already accessible via CPUState::kvm_state, use it. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200121110349.25842-5-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- target/arm/kvm.c | 4 +--- 1 file changed,

[PULL 40/59] object: add object_property_set_defaut_{bool, str, int, uint}()

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-11-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 37 ++ qom/object.c | 56

[PULL 44/59] object: express const link with link property

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Let's not mix child property and link property callbacks, as this is confusing, use LinkProperty with DIRECT flag to hold the target pointer. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-16-marcandre.lur...@redhat.com> Signed-off-by: Paolo

[PULL 12/59] configure: Do not build libfdt if not required

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We only require libfdt for system emulation, in a small set of architecture: 4077 # fdt support is mandatory for at least some target architectures, 4078 # so insist on it if we're building those system emulators. 4079 fdt_required=no 4080 for target in

[PULL 44/59] object: add direct link flag

2020-01-23 Thread Paolo Bonzini
From: Marc-André Lureau Allow the link property to hold the pointer to the target, instead of indirectly through another variable. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-15-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- include/qom/object.h | 3

[PULL 07/59] hw/display/tcx: Add missing fall through comments

2020-01-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get: hw/display/tcx.c: In function ‘tcx_dac_writel’: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror=implicit-fallthrough=] 453 | s->dac_index =

Re: [PATCH v3 0/8] Fix Exynos4210 DMA support

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 05:25, Guenter Roeck wrote: > > Commit 59520dc65e ("hw/arm/exynos4210: Add DMA support for the Exynos4210") > introduced DMA support for Exynos4210. Unfortunately, it never really > worked. DMA interrupt line and polarity was wrong, and the serial port > needs extra code to

[PULL 53/59] qom: simplify qmp_device_list_properties()

2020-01-23 Thread Paolo Bonzini
All qdev properties are object properties, no need for make_device_property_info() helper. Signed-off-by: Marc-André Lureau Message-Id: <20200110153039.1379601-24-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- qom/qom-qmp-cmds.c | 52

[PULL 07/20] hw/arm: Use helper function to trigger hotplug handler plug

2020-01-23 Thread Peter Maydell
From: Keqian Zhu We can use existing helper function to trigger hotplug handler plug, which makes code clearer. Reviewed-by: Igor Mammedov Signed-off-by: Keqian Zhu Message-id: 20200120012755.44581-3-zhukeqi...@huawei.com Signed-off-by: Peter Maydell --- hw/arm/virt.c | 6 +++--- 1 file

[PULL v2 00/20] target-arm queue

2020-01-23 Thread Peter Maydell
) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200123-1 for you to fetch changes up to 3efba2eac3f2ac1f84f75465597f361626a6d0d5: hw/arm/exynos4210: Connect serial port DMA busy signals with pl330 (2020-01-23 15:34:05 +

[PULL 06/20] hw/acpi: Remove extra indent in ACPI GED hotplug cb

2020-01-23 Thread Peter Maydell
From: Keqian Zhu There is extra indent in ACPI GED hotplug cb that should be deleted. Reviewed-by: Igor Mammedov Signed-off-by: Keqian Zhu Message-id: 20200120012755.44581-2-zhukeqi...@huawei.com Signed-off-by: Peter Maydell --- hw/acpi/generic_event_device.c | 2 +- 1 file changed, 1

Re: [PATCH REPOST v3 20/80] arm/mps2-tz: use memdev for RAM

2020-01-23 Thread Andrew Jones
On Thu, Jan 23, 2020 at 02:39:48PM +0100, Igor Mammedov wrote: > On Thu, 23 Jan 2020 13:59:09 +0100 > Andrew Jones wrote: > > > On Thu, Jan 23, 2020 at 12:37:45PM +0100, Igor Mammedov wrote: > > > memory_region_allocate_system_memory() API is going away, so > > > replace it with memdev allocated

[PULL 10/20] qemu-block-drivers: Convert to rST

2020-01-23 Thread Peter Maydell
The qemu-block-drivers documentation is currently in docs/qemu-block-drivers.texi in Texinfo format, which we present to the user as: * a qemu-block-drivers manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a

[PULL 18/20] hw/char/exynos4210_uart: Implement Rx FIFO level triggers and timeouts

2020-01-23 Thread Peter Maydell
From: Guenter Roeck The driver already implements a receive FIFO, but it does not handle receive FIFO trigger levels and timeout. Implement the missing functionality. Signed-off-by: Guenter Roeck Message-id: 20200123052540.6132-7-li...@roeck-us.net Signed-off-by: Peter Maydell Reviewed-by:

Re: [PULL 000/111] virtiofs queue

2020-01-23 Thread Peter Maydell
On Thu, 23 Jan 2020 at 16:02, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > I think the case would be better if the > > doc you were adding was the virtiofsd manpage, which doesn't > > seem to exist yet). > > Yes it does, see 'virtiofsd: add man page'

[PULL 021/108] virtiofsd: get/set features callbacks

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the get/set features callbacks. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git

[PULL 013/108] virtiofsd: Trim out compatibility code

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" virtiofsd only supports major=7, minor>=31; trim out a lot of old compatibility code. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 330

Re: [PATCH REPOST v3 65/80] ppc/{ppc440_bamboo, sam460ex}: use memdev for RAM

2020-01-23 Thread BALATON Zoltan
On Thu, 23 Jan 2020, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using

[PULL 036/108] virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointers

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Do not expose lo_inode pointers to clients. Signed-off-by: Stefan Hajnoczi Reviewed-by: Masayoshi Mizuma Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 144 --- 1 file changed, 114 insertions(+), 30 deletions(-)

[PULL 024/108] virtiofsd: Start reading commands from queue

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Pop queue elements off queues, copy the data from them and pass that to fuse. Note: 'out' in a VuVirtqElement is from QEMU 'in' in libfuse is into the daemon So we read from the out iov's to get a fuse_in_header When we get a kick we've got to read

[PATCH v4 81/80] m68k/q800: use memdev for RAM

2020-01-23 Thread Igor Mammedov
Switch to using generic main RAM allocation. To do this set MachineClass::default_ram_id to m68k_mac.ram and use MachineState::ram instead of manually initializing RAM memory region. Signed-off-by: Igor Mammedov --- CC: laur...@vivier.eu --- hw/m68k/q800.c | 6 ++ 1 file changed, 2

Re: [PULL 000/111] virtiofs queue

2020-01-23 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 23 Jan 2020 at 16:02, Dr. David Alan Gilbert > wrote: > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > > I think the case would be better if the > > > doc you were adding was the virtiofsd manpage, which doesn't > > > seem

Re: [PATCH REPOST v3 79/80] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-23 Thread BALATON Zoltan
On Thu, 23 Jan 2020, Igor Mammedov wrote: Use GString to pass argument to make_cli() so that it would be easy to dynamically change test case arguments from main(). The follow up patch will use it to change RAM size options depending on target. While at it cleanup 'cli' freeing, using

[PULL 11/20] target/arm/arch_dump: Add SVE notes

2020-01-23 Thread Peter Maydell
From: Andrew Jones When dumping a guest with dump-guest-memory also dump the SVE registers if they are in use. Signed-off-by: Andrew Jones Reviewed-by: Richard Henderson Message-id: 20200120101832.18781-1-drjo...@redhat.com [PMM: fixed checkpatch nits] Signed-off-by: Peter Maydell ---

[PULL 15/20] hw/arm/exynos4210: Fix DMA initialization

2020-01-23 Thread Peter Maydell
From: Guenter Roeck First parameter to exynos4210_get_irq() is not the SPI port number, but the interrupt group number. Interrupt groups are 20 for mdma and 21 for pdma. Interrupts are not inverted. Controllers support 32 events (pdma) or 31 events (mdma). Events must all be routed to a single

[PULL 076/108] virtiofsd: support nanosecond resolution for file timestamp

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Jiufei Xue Define HAVE_STRUCT_STAT_ST_ATIM to 1 if `st_atim' is member of `struct stat' which means support nanosecond resolution for the file timestamp fields. Signed-off-by: Jiufei Xue Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- configure

[PULL 031/108] virtiofsd: add vhost-user.json file

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Install a vhost-user.json file describing virtiofsd. This allows libvirt and other management tools to enumerate vhost-user backend programs. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- .gitignore

Re: [PATCH v29 00/22] Add RX archtecture support

2020-01-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200123132525.80891-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200123132525.80891-1-ys...@users.sourceforge.jp Subject: [PATCH v29 00/22] Add

[PULL 081/108] virtiofsd: Prevent multiply running with same vhost_user_socket

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Masayoshi Mizuma virtiofsd can run multiply even if the vhost_user_socket is same path. ]# ./virtiofsd -o vhost_user_socket=/tmp/vhostqemu -o source=/tmp/share & [1] 244965 virtio_session_mount: Waiting for vhost-user socket connection... ]# ./virtiofsd -o

[PULL 035/108] virtiofsd: passthrough_ll: add lo_map for ino/fh indirection

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi A layer of indirection is needed because passthrough_ll cannot expose pointers or file descriptor numbers to untrusted clients. Malicious clients could send invalid pointers or file descriptors in order to crash or exploit the file system daemon. lo_map provides an

[PULL 053/108] virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Caller can set FUSE_WRITE_KILL_PRIV in write_flags. Parse it and pass it to the filesystem. Signed-off-by: Vivek Goyal Reviewed-by: Misono Tomohiro Reviewed-by: Sergio Lopez Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_common.h | 6 +-

[PULL 104/108] virtiofsd: add --thread-pool-size=NUM option

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Add an option to control the size of the thread pool. Requests are now processed in parallel by default. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert ---

[PULL 010/108] virtiofsd: Remove unused enum fuse_buf_copy_flags

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Xiao Yang Signed-off-by: Xiao Yang Reviewed-by: Stefan Hajnoczi Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/buffer.c | 7 +++-- tools/virtiofsd/fuse_common.h| 46 +--- tools/virtiofsd/fuse_lowlevel.c | 13 -

[PULL 073/108] virtiofsd: passthrough_ll: clean up cache related options

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Miklos Szeredi - Rename "cache=never" to "cache=none" to match 9p's similar option. - Rename CACHE_NORMAL constant to CACHE_AUTO to match the "cache=auto" option. Signed-off-by: Miklos Szeredi Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by:

[PULL 057/108] virtiofsd: fix libfuse information leaks

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Some FUSE message replies contain padding fields that are not initialized by libfuse. This is fine in traditional FUSE applications because the kernel is trusted. virtiofsd does not trust the guest and must not expose uninitialized memory. Use C struct initializers to

[PULL 059/108] virtiofsd: print log only when priority is high enough

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Eryu Guan Introduce "-o log_level=" command line option to specify current log level (priority), valid values are "debug info warn err", e.g. ./virtiofsd -o log_level=debug ... So only log priority higher than "debug" will be printed to stderr/syslog. And the default level is info.

[PULL 025/108] virtiofsd: Send replies to messages

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Route fuse out messages back through the same queue elements that had the command that triggered the request. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 4

[PULL 069/108] virtiofsd: passthrough_ll: control readdirplus

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Miklos Szeredi Signed-off-by: Miklos Szeredi Reviewed-by: Misono Tomohiro Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/helper.c | 4 tools/virtiofsd/passthrough_ll.c | 7 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

[PULL 078/108] virtiofsd: cleanup allocated resource in se

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Liu Bo This cleans up unfreed resources in se on quiting, including se->virtio_dev, se->vu_socket_path, se->vu_socketfd. Signed-off-by: Liu Bo Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 7 +++

[Bug 1859656] Re: [2.6] Unable to reboot s390x KVM machine after initial deploy

2020-01-23 Thread Lee Trager
The S390X KVM boot driver in MAAS really hasn't changed since it was committed in 2018[1]. I doubt changing the version of MAAS will show it working. I would try using older versions of qemu. [1] https://git.launchpad.net/maas/log/src/provisioningserver/boot/s390x.py -- You received this bug

[PULL 034/108] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal We need to create files in the caller's context. Otherwise after creating a file, the caller might not be able to do file operations on that file. Changed effective uid/gid to caller's uid/gid, create file and then switch back to uid/gid 0. Use syscall(setresuid, ...)

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 1

2020-01-23 Thread Palmer Dabbelt
On Thu, 23 Jan 2020 06:38:07 PST (-0800), Peter Maydell wrote: On Tue, 21 Jan 2020 at 23:41, Palmer Dabbelt wrote: The following changes since commit 28b58f19d269633b3d14b6aebf1e92b3cd3ab56e: ui/gtk: Get display refresh rate with GDK version 3.22 or later (2020-01-16 14:03:45 +) are

qemu-img convert vs writing another copy tool

2020-01-23 Thread Richard W.M. Jones
I guess some people are aware that virt-v2v, which is a tool which converts guests from VMware to run on KVM, and some other OpenStack-OpenStack migration tools we have, use "qemu-img convert" to copy the data around. Historically we've had bugs here. The most recent was discussed in the thread

[PULL 049/108] virtiofsd: sandbox mount namespace

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Use a mount namespace with the shared directory tree mounted at "/" and no other mounts. This prevents symlink escape attacks because symlink targets are resolved only against the shared directory and cannot go outside it. Signed-off-by: Stefan Hajnoczi Signed-off-by:

[PATCH] qemu_set_log_filename: filename argument may be NULL

2020-01-23 Thread salvador
From: Salvador Fandino NULL is a valid log filename used to indicate we want to use stderr but qemu_set_log_filename (which is called by bsd-user/main.c) was not handling it correctly. That also made redundant a couple of NULL checks in calling code which have been removed. Signed-off-by:

[PULL 050/108] virtiofsd: move to an empty network namespace

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi If the process is compromised there should be no network access. Use an empty network namespace to sandbox networking. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 14

[PULL 067/108] virtiofsd: passthrough_ll: add renameat2 support

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Miklos Szeredi Signed-off-by: Miklos Szeredi Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index 98114a3f4a..18d69abcbc 100644

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-23 Thread Philippe Mathieu-Daudé
On 1/23/20 12:28 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote: Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall

Re: [PULL 000/108] virtiofs queue

2020-01-23 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit b7c359c748a2e3ccb97a184b9739feb2cd48de2f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging > (2020-01-23

[PULL 096/108] virtiofsd: Reset O_DIRECT flag during file open

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal If an application wants to do direct IO and opens a file with O_DIRECT in guest, that does not necessarily mean that we need to bypass page cache on host as well. So reset this flag on host. If somebody needs to bypass page cache on host as well (and it is safe to do so), we

[PULL 106/108] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Xiao Yang lo_copy_file_range() passes -errno to fuse_reply_err() and then fuse_reply_err() changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() catches the wrong errno.(i.e. reports "fuse: bad error value: ..."). Make fuse_send_reply_iov_nofree() accept the correct

Re: [PATCH rc1 18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config

2020-01-23 Thread Philippe Mathieu-Daudé
On 1/23/20 6:04 AM, Thomas Huth wrote: On 23/01/2020 01.03, Richard Henderson wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200120220107.17825-13-f4...@amsat.org> Signed-off-by: Richard Henderson --- hw/avr/Kconfig | 5 + 1 file changed, 5

Re: Making QEMU easier for management tools and applications

2020-01-23 Thread Daniel P . Berrangé
On Thu, Jan 23, 2020 at 12:58:45PM -0500, John Snow wrote: > Yes, I agree: Scrap and start over. > > What SHOULD the syntax look like, though? Clearly the idea of qmp-shell > is that it offers a convenient way to enter the top-level keys of the > arguments dict. This works absolutely fine right

Re: [PATCH] iscsi: Don't access non-existent scsi_lba_status_descriptor

2020-01-23 Thread John Snow
On 1/23/20 12:05 PM, Kevin Wolf wrote: > In iscsi_co_block_status(), we may have received num_descriptors == 0 > from the iscsi server. Therefore, we can't unconditionally access > lbas->descriptors[0]. Add the missing check. > > Signed-off-by: Kevin Wolf > --- > block/iscsi.c | 2 +- > 1

Re: Making QEMU easier for management tools and applications

2020-01-23 Thread John Snow
On 1/23/20 2:01 PM, Daniel P. Berrangé wrote: > On Thu, Jan 23, 2020 at 12:58:45PM -0500, John Snow wrote: >> Yes, I agree: Scrap and start over. >> >> What SHOULD the syntax look like, though? Clearly the idea of qmp-shell >> is that it offers a convenient way to enter the top-level keys of

Re: [PATCH] iscsi: Don't access non-existent scsi_lba_status_descriptor

2020-01-23 Thread Felipe Franciosi
> On Jan 23, 2020, at 5:05 PM, Kevin Wolf wrote: > > In iscsi_co_block_status(), we may have received num_descriptors == 0 > from the iscsi server. Therefore, we can't unconditionally access > lbas->descriptors[0]. Add the missing check. > > Signed-off-by: Kevin Wolf > --- > block/iscsi.c |

Re: [PATCH] iscsi: Don't access non-existent scsi_lba_status_descriptor

2020-01-23 Thread Felipe Franciosi
> On Jan 23, 2020, at 8:37 PM, John Snow wrote: > > > > On 1/23/20 12:05 PM, Kevin Wolf wrote: >> In iscsi_co_block_status(), we may have received num_descriptors == 0 >> from the iscsi server. Therefore, we can't unconditionally access >> lbas->descriptors[0]. Add the missing check. >> >>

Re: [PATCH] iscsi: Don't access non-existent scsi_lba_status_descriptor

2020-01-23 Thread Philippe Mathieu-Daudé
On 1/23/20 6:05 PM, Kevin Wolf wrote: In iscsi_co_block_status(), we may have received num_descriptors == 0 from the iscsi server. Therefore, we can't unconditionally access lbas->descriptors[0]. Add the missing check. Signed-off-by: Kevin Wolf --- block/iscsi.c | 2 +- 1 file changed, 1

Re: Maintainers, please add Message-Id: when merging patches

2020-01-23 Thread Laszlo Ersek
On 01/23/20 18:18, Kevin Wolf wrote: > Am 22.01.2020 um 13:28 hat Kevin Wolf geschrieben: >> Am 22.01.2020 um 13:02 hat Stefan Hajnoczi geschrieben: >>> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag. >>> Hooray! >>> >>> Message-Id: references the patch email that a commit

Re: [PATCH] iscsi: Cap block count from GET LBA STATUS (CVE-2020-1711)

2020-01-23 Thread Felipe Franciosi
Hi, > On Jan 23, 2020, at 5:46 PM, Philippe Mathieu-Daudé wrote: > > On 1/23/20 1:44 PM, Felipe Franciosi wrote: >> When querying an iSCSI server for the provisioning status of blocks (via >> GET LBA STATUS), Qemu only validates that the response descriptor zero's >> LBA matches the one

Re: [PATCH] tests/boot-serial-test: Allow the HPPA machine to shudown

2020-01-23 Thread Philippe Mathieu-Daudé
On 1/23/20 7:29 PM, Philippe Mathieu-Daudé wrote: On 1/23/20 5:39 AM, Thomas Huth wrote: On 23/01/2020 01.36, Philippe Mathieu-Daudé wrote: The boot-serial test uses SeaBIOS on HPPA, and expects to read the "SeaBIOS wants SYSTEM HALT" string, see [*]:   122 void __VISIBLE __noreturn hlt(void)

Re: [PATCH v3 2/4] tests/acceptance: boot_linux_console: Add boot Linux with kvm tests

2020-01-23 Thread Wainer dos Santos Moschetta
On 1/22/20 7:02 AM, Andrew Jones wrote: On Tue, Jan 21, 2020 at 10:27:51PM -0300, Wainer dos Santos Moschetta wrote: +def test_aarch64_virt_kvm(self): +""" +:avocado: tags=arch:aarch64 +:avocado: tags=machine:virt +:avocado: tags=accel:kvm +""" +

Re: [PULL 000/111] virtiofs queue

2020-01-23 Thread Peter Maydell
00121' into staging (2020-01-21 > 15:29:25 +) > > are available in the Git repository at: > > g...@gitlab.com:dagrh/qemu.git tags/pull-virtiofs-20200123 > > for you to fetch changes up to 87509325f70c78a28683f9460699915ea3300091: > > virtiofsd: add s

Re: [PATCH v22 3/9] ACPI: Build related register address fields via hardware error fw_cfg blob

2020-01-23 Thread Igor Mammedov
On Wed, 8 Jan 2020 19:32:17 +0800 Dongjiu Geng wrote: > This patch builds error_block_address and read_ack_register fields > in hardware errors table , the error_block_address points to Generic > Error Status Block(GESB) via bios_linker. The max size for one GESB > is 0x1000 in bytes, For more

[PULL 041/108] virtiofsd: Plumb fuse_bufvec through to do_write_buf

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Let fuse_session_process_buf_int take a fuse_bufvec * instead of a fuse_buf; and then through to do_write_buf - where in the best case it can pass that straight through to op.write_buf without copying (other than skipping a header). Signed-off-by: Dr. David Alan

[PULL 01/20] target/arm: add PMU feature to cortex-r5 and cortex-r5f

2020-01-23 Thread Peter Maydell
From: Clement Deschamps The PMU is not optional on cortex-r5 and cortex-r5f (see the "Features" chapter of the Technical Reference Manual). Signed-off-by: Clement Deschamps Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200114105918.2366370-1-clement.descha...@greensocs.com Signed-off-by:

[PULL 058/108] virtiofsd: add --syslog command-line option

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Sometimes collecting output from stderr is inconvenient or does not fit within the overall logging architecture. Add syslog(3) support for cases where stderr cannot be used. Signed-off-by: Stefan Hajnoczi dgilbert: Reworked as a logging function Signed-off-by: Dr. David

[PULL 022/108] virtiofsd: Start queue threads

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Start a thread for each queue when we get notified it's been started. Signed-off-by: Dr. David Alan Gilbert fix by: Signed-off-by: Jun Piao Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert ---

[PULL 023/108] virtiofsd: Poll kick_fd for queue

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In the queue thread poll the kick_fd we're passed. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 40 ++- 1 file changed, 39

Re: [PATCH REPOST v3] target/arm/arch_dump: Add SVE notes

2020-01-23 Thread Andrew Jones
On Thu, Jan 23, 2020 at 02:53:42PM +, Peter Maydell wrote: > On Mon, 20 Jan 2020 at 10:18, Andrew Jones wrote: > > > > When dumping a guest with dump-guest-memory also dump the SVE > > registers if they are in use. > > > > Signed-off-by: Andrew Jones > > Reviewed-by: Richard Henderson > >

[PULL 064/108] virtiofsd: Kill threads when queues are stopped

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Kill the threads we've started when the queues get stopped. Signed-off-by: Dr. David Alan Gilbert With improvements by: Signed-off-by: Eryu Guan Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 51

[PATCH v2 1/2] docs: Fix typo in qemu-nbd -P replacement

2020-01-23 Thread Eric Blake
The suggested replacement for the deprecated 'qemu-nbd -P' referw to 'file.backing.opt' instead of 'file.file.opt'; using the example verbatim results in: qemu-nbd: Failed to blk_new_open 'driver=raw,offset=1m,size=100m,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file4': A

[PULL 028/108] virtiofsd: Fast path for virtio read

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Readv the data straight into the guests buffer. Signed-off-by: Dr. David Alan Gilbert With fix by: Signed-off-by: Eryu Guan Reviewed-by: Masayoshi Mizuma Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 5 +

[PULL 065/108] vhost-user: Print unexpected slave message types

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When we receive an unexpected message type on the slave fd, print the type. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost-user.c | 2 +- 1

[PULL 046/108] virtiofsd: prevent ".." escape in lo_do_lookup()

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virtiofsd/passthrough_ll.c

[PULL 055/108] virtiofsd: Drop CAP_FSETID if client asked for it

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal If client requested killing setuid/setgid bits on file being written, drop CAP_FSETID capability so that setuid/setgid bits are cleared upon write automatically. pjdfstest chown/12.t needs this. Signed-off-by: Vivek Goyal dgilbert: reworked for libcap-ng Reviewed-by:

[PULL 066/108] contrib/libvhost-user: Protect slave fd with mutex

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In future patches we'll be performing commands on the slave-fd driven by commands on queues, since those queues will be driven by individual threads we need to make sure they don't attempt to use the slave-fd for multiple commands in parallel. Signed-off-by: Dr.

Re: 5.0 release schedule proposal

2020-01-23 Thread Peter Maydell
On Mon, 6 Jan 2020 at 15:29, Peter Maydell wrote: > > Here's a suggested set of dates for the 5.0 release: > > 2020-03-17 softfreeze > 2020-03-24 hardfreeze/rc0 > 2020-03-31 rc1 > 2020-04-07 rc2 > 2020-04-14 rc3 > 2020-04-21 release, or rc4 > 2020-04-28 release if we needed rc4 > > (I'm at a

[PULL 099/108] virtiofsd: add definition of fuse_buf_writev()

2020-01-23 Thread Dr. David Alan Gilbert (git)
From: piaojun Define fuse_buf_writev() which use pwritev and writev to improve io bandwidth. Especially, the src bufs with 0 size should be skipped as their mems are not *block_size* aligned which will cause writev failed in direct io mode. Signed-off-by: Jun Piao Suggested-by: Stefan Hajnoczi

<    1   2   3   4   5   6   7   8   >