Re: [PATCH 2/7] target/ppc: Introduce a relocation bool in ppc_radix64_handle_mmu_fault()

2020-03-30 Thread Greg Kurz
On Mon, 30 Mar 2020 11:49:41 +0200 Cédric Le Goater wrote: > It will ease the introduction of new routines for partition-scoped > Radix translation. > > Signed-off-by: Suraj Jitindar Singh > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > target/ppc/mmu-radix64.c | 5 +++--

Re: [RFC PATCH] crypto/secret: support fetching secrets from Linux keyring

2020-03-30 Thread Daniel P . Berrangé
On Sat, Mar 28, 2020 at 02:40:14PM +0300, Alexey Krasikov wrote: > Add the ability for the secret object to obtain secret data from the > Linux in-kernel key managment and retention facility, as an extra option > to the existing ones: reading from a file or passing directly as a > string. > > The

Re: [PATCH v9 00/14] iotests: use python logging

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the

Re: [PATCH-for-5.0?] decodetree: Use Python3 floor division operator

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 13:14, Philippe Mathieu-Daudé wrote: > > This script started using Python2, where the 'classic' division > operator returns the floor result. In commit 3d004a371 we started > to use Python3, where the division operator returns the float > result ('true division'). > To keep

[PATCH for-5.0] hw/ppc/ppc440_uc.c: Remove incorrect iothread locking from dcr_write_pcie()

2020-03-30 Thread Peter Maydell
In dcr_write_pcie() we take the iothread lock around a call to pcie_host_mmcfg_udpate(). This is an incorrect attempt to deal with the bug fixed in commit 235352ee6e73d7716, where we were not taking the iothread lock before calling device dcr read/write functions. (It's not sufficient locking,

Re: [PATCH v9 10/14] iotests: add hmp helper with logging

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > Just a mild cleanup while I was here. > > Although we now have universal qmp logging on or off, many existing > callers to hmp functions don't expect that output to be logged, which > causes quite a few changes in the test output. > > For now, just offer a

Re: [PATCH] i386: hvf: Reset IRQ inhibition after moving RIP

2020-03-30 Thread Paolo Bonzini
On 28/03/20 18:44, Roman Bolshakov wrote: > The sequence of instructions exposes an issue: > sti > hlt > > Interrupts cannot be delivered to hvf after hlt instruction cpu because > HF_INHIBIT_IRQ_MASK is set just before hlt is handled and never reset > after moving instruction pointer beyond

Re: [kvm-unit-tests PATCH v7 13/13] arm/arm64: ITS: pending table migration test

2020-03-30 Thread Auger Eric
Hi Zenghui, On 3/30/20 2:06 PM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> Add two new migration tests. One testing the migration of >> a topology where collection were unmapped. The second test >> checks the migration of the pending table. >> >> Signed-off-by:

Re: [PATCH v9 09/14] iotests: limit line length to 79 chars

2020-03-30 Thread Max Reitz
On 30.03.20 14:31, Max Reitz wrote: > On 25.03.20 00:20, John Snow wrote: >> 79 is the PEP8 recommendation. This recommendation works well for >> reading patch diffs in TUI email clients. >> >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/iotests.py | 64

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Mar 23, 2020 at 6:41 PM Kevin Wolf wrote: >> >> Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben: >> > Kevin Wolf writes: >> > >> > > This moves the QMP dispatcher to a coroutine and runs all QMP command >> > > handlers that declare

Re: [PATCH v9 09/14] iotests: limit line length to 79 chars

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > 79 is the PEP8 recommendation. This recommendation works well for > reading patch diffs in TUI email clients. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 64 +++ > tests/qemu-iotests/pylintrc | 6

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This moves the QMP dispatcher to a coroutine and runs all QMP command >> > handlers that declare 'coroutine': true in coroutine context so they >> > can avoid blocking the main loop

Re: [PATCH v9 08/14] iotests: touch up log function signature

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > Representing nested, recursive data structures in mypy is notoriously > difficult; the best we can reliably do right now is denote the atom > types as "Any" while describing the general shape of the data. > > Regardless, this fully annotates the log()

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Zenghui Yu
Hi Drew, On 2020/3/30 17:11, Andrew Jones wrote: On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: Hi Zenghui, On 3/30/20 10:30 AM, Zenghui Yu wrote: [...] Otherwise I think we will end-up with memory corruption when writing the command queue.  But it seems that everything just

Re: [PULL 0/1] Linux user for 5.0 patches

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 11:31, Laurent Vivier wrote: > > The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging > (2020-03-26 20:55:54 +) > > are available in the

[PATCH-for-5.0?] decodetree: Use Python3 floor division operator

2020-03-30 Thread Philippe Mathieu-Daudé
This script started using Python2, where the 'classic' division operator returns the floor result. In commit 3d004a371 we started to use Python3, where the division operator returns the float result ('true division'). To keep the same behavior, use the 'floor division' operator "//" which returns

Re: [PATCH v9 06/14] iotests: alphabetize standard imports

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > I had to fix a merge conflict, so do this tiny harmless thing while I'm > here. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Max Reitz

Re: [PATCH v9 07/14] iotests: drop pre-Python 3.4 compatibility code

2020-03-30 Thread Max Reitz
On 25.03.20 00:20, John Snow wrote: > We no longer need to accommodate 3.4, drop this code. > (The lines were > 79 chars and it stood out.) > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) I did say I wouldn’t

Re: [PATCH 3/3] migration: move the units of migrate parameters from milliseconds to ms.

2020-03-30 Thread Juan Quintela
Mao Zhongyi wrote: > Signed-off-by: Mao Zhongyi > Suggested-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela I don't really care one way or another. But I agree that consistence is good.

Re: [PATCH 2/3] monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed()

2020-03-30 Thread Juan Quintela
Mao Zhongyi wrote: > Signed-off-by: Mao Zhongyi Reviewed-by: Juan Quintela

Re: [kvm-unit-tests PATCH v7 13/13] arm/arm64: ITS: pending table migration test

2020-03-30 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: Add two new migration tests. One testing the migration of a topology where collection were unmapped. The second test checks the migration of the pending table. Signed-off-by: Eric Auger [...] @@ -659,6 +678,15 @@ static int

Re: [PATCH 1/3] migration/migration: improve error reporting for migrate parameters

2020-03-30 Thread Juan Quintela
Mao Zhongyi wrote: > use QERR_INVALID_PARAMETER_VALUE instead of > "Parameter '%s' expects" for consistency. I agree with the idea. > Signed-off-by: Mao Zhongyi > --- > migration/migration.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH v2] migration: fix bad indentation in error_report()

2020-03-30 Thread Juan Quintela
Mao Zhongyi wrote: > bad indentation conflicts with CODING_STYLE doc. > > Signed-off-by: Mao Zhongyi Reviewed-by: Juan Quintela

Re: [PULL 0/1] Linux user for 5.0 patches

2020-03-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200330102945.2388294-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/1] Linux user for 5.0 patches Message-id: 20200330102945.2388294-1-laur...@vivier.eu Type:

Re: [PATCH] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-03-30 Thread Alex Bennée
Richard Henderson writes: > All other calls to normalize*Subnormal detect zero input before > the call -- this is the only outlier. This case can happen with > +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of > the correct sign. > > Reported-by: Coverity (CID 1421991) >

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

2020-03-30 Thread Philippe Mathieu-Daudé
Hi David, On 3/25/20 4:15 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 3/25/20 3:10 PM, Oksana Voshchana wrote: Hi Philippe Thanks for the review I have some comments On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé mailto:phi...@redhat.com>>

Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-03-30 Thread Auger Eric
On 3/30/20 6:24 AM, Liu Yi L wrote: > This patch modifies pci_setup_iommu() to set PCIIOMMUOps > instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to > get an address space for a PCI device in vendor specific > way. The PCIIOMMUOps still offers this functionality. But > using PCIIOMMUOps

Re: [PATCH v4 1/2] virtio-blk: delete vqs on the error path in realize()

2020-03-30 Thread Pankaj Gupta
Reviewed-by: Pankaj Gupta

Re: [kvm-unit-tests PATCH v7 12/13] arm/arm64: ITS: migration tests

2020-03-30 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: This test maps LPIs (populates the device table, the collection table, interrupt translation tables, configuration table), migrates and make sure the translation is correct on the destination. Signed-off-by: Eric Auger --- v4 -> v5: - move stub

Re: [PATCH 3/7] target/ppc: Assert if HV mode is set when running under a pseries machine

2020-03-30 Thread Greg Kurz
On Mon, 30 Mar 2020 11:49:42 +0200 Cédric Le Goater wrote: > Signed-off-by: Suraj Jitindar Singh > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > target/ppc/mmu-radix64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/ppc/mmu-radix64.c

Re: [PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5

2020-03-30 Thread Greg Kurz
On Mon, 30 Mar 2020 11:49:40 +0200 Cédric Le Goater wrote: > From: Suraj Jitindar Singh > > According to the ISA the root page directory size of a radix tree for > either process- or partition-scoped translation must be >= 5. > > Thus add this to the list of conditions checked when validating

Re: [kvm-unit-tests PATCH v7 10/13] arm/arm64: ITS: INT functional tests

2020-03-30 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: Triggers LPIs through the INT command. the test checks the LPI hits the right CPU and triggers the right LPI intid, ie. the translation is correct. Updates to the config table also are tested, along with inv and invall commands. Signed-off-by:

Re: [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs

2020-03-30 Thread Auger Eric
Hi Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memory (SVM) on > Intel platforms allows address space sharing between device DMA and > applications. SVA can reduce programming complexity and enhance security. > > This QEMU series is intended

[PULL 1/1] linux-user: Support futex_time64

2020-03-30 Thread Laurent Vivier
From: Alistair Francis Add support for host and target futex_time64. If futex_time64 exists on the host we try that first before falling back to the standard futex syscall. Signed-off-by: Alistair Francis Message-Id: [lv: define sys_futex() if __NR_futex is defined (fix bug on 32bit host),

[PULL 0/1] Linux user for 5.0 patches

2020-03-30 Thread Laurent Vivier
The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-26 20:55:54 +) are available in the Git repository at: git://github.com/vivier/qemu.git

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Auger Eric
Hi Drew, On 3/30/20 12:19 PM, Andrew Jones wrote: > On Mon, Mar 30, 2020 at 11:56:00AM +0200, Auger Eric wrote: >> Hi, >> >> On 3/30/20 11:11 AM, Andrew Jones wrote: >>> On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: Hi Zenghui, On 3/30/20 10:30 AM, Zenghui Yu wrote:

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Andrew Jones
On Mon, Mar 30, 2020 at 11:56:00AM +0200, Auger Eric wrote: > Hi, > > On 3/30/20 11:11 AM, Andrew Jones wrote: > > On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: > >> Hi Zenghui, > >> > >> On 3/30/20 10:30 AM, Zenghui Yu wrote: > >>> Hi Eric, > >>> > >>> On 2020/3/20 17:24, Eric

Re: [PATCH v4] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-30 Thread Max Reitz
On 27.03.20 19:59, Alberto Garcia wrote: > A discard request deallocates the selected clusters so they read back > as zeroes. This is done by clearing the cluster offset field and > setting QCOW_OFLAG_ZERO in the L2 entry. > > This flag is however only supported when qcow_version >= 3. In older >

Re: [kvm-unit-tests PATCH v7 09/13] arm/arm64: ITS: Commands

2020-03-30 Thread Auger Eric
Hi Zenghui, On 3/30/20 11:22 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> Implement main ITS commands. The code is largely inherited from >> the ITS driver. >> >> Signed-off-by: Eric Auger > > [...] > >> +/* ITS COMMANDS */ >> + >> +static void

RE: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info

2020-03-30 Thread Kang, Luwei
> -Original Message- > From: Kang, Luwei > Sent: Tuesday, February 25, 2020 5:38 AM > To: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com > Cc: qemu-devel@nongnu.org; Strong, Beeman ; > Kang, Luwei > Subject: [PATCH v1 0/3] Remove the limitation of Intel PT CPUID info > > The

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Auger Eric
Hi, On 3/30/20 11:11 AM, Andrew Jones wrote: > On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: >> Hi Zenghui, >> >> On 3/30/20 10:30 AM, Zenghui Yu wrote: >>> Hi Eric, >>> >>> On 2020/3/20 17:24, Eric Auger wrote: +static void its_cmd_queue_init(void) +{ +    unsigned

[PATCH v11 1/4] qcow2: introduce compression type feature

2020-03-30 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus

[PATCH v11 0/4] qcow2: Implement zstd cluster compression method

2020-03-30 Thread Denis Plotnikov
v11: * 03: the loops don't need "do{}while" form anymore and the they were buggy (missed "do" in the beginning) replace them with usual "while(){}" loops [Vladimir] v10: * 03: fix zstd (de)compressed loops for multi-frame cases [Vladimir] v9: * 01: fix error

[PATCH v11 4/4] iotests: 287: add qcow2 compression type test

2020-03-30 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

[PATCH v11 2/4] qcow2: rework the cluster compression routine

2020-03-30 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71

[PATCH v11 3/4] qcow2: add zstd cluster compression

2020-03-30 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and

[PATCH 6/7] target/ppc: Extend ppc_radix64_check_prot() with a 'partition_scoped' bool

2020-03-30 Thread Cédric Le Goater
This prepares ground for partition-scoped Radix translation. Signed-off-by: Suraj Jitindar Singh Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c

[PATCH 3/7] target/ppc: Assert if HV mode is set when running under a pseries machine

2020-03-30 Thread Cédric Le Goater
Signed-off-by: Suraj Jitindar Singh Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c index f6007e956569..d2422d1c54c9 100644 --- a/target/ppc/mmu-radix64.c +++

[PATCH 5/7] target/ppc: Rework ppc_radix64_walk_tree() for partition-scoped translation

2020-03-30 Thread Cédric Le Goater
The ppc_radix64_walk_tree() routine walks through the nested radix tables to look for a PTE. Split it two and introduce a new routine ppc_radix64_next_level() which we will use for partition-scoped Radix translation when translating the process tree addresses. Signed-off-by: Suraj Jitindar Singh

[PATCH 7/7] target/ppc: Add support for Radix partition-scoped translation

2020-03-30 Thread Cédric Le Goater
The Radix tree translation model currently supports process-scoped translation for the PowerNV machine (Hypervisor mode) and for the pSeries machine (Guest mode). Guests running under an emulated Hypervisor (PowerNV machine) require a new type of Radix translation, called partition-scoped, which

[PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5

2020-03-30 Thread Cédric Le Goater
From: Suraj Jitindar Singh According to the ISA the root page directory size of a radix tree for either process- or partition-scoped translation must be >= 5. Thus add this to the list of conditions checked when validating the partition table entry in validate_pate(); Signed-off-by: Suraj

[PATCH 0/7] target/ppc: Add support for Radix partition-scoped translation

2020-03-30 Thread Cédric Le Goater
Hello, The Radix tree translation model currently supports process-scoped translation for the PowerNV machine (Hypervisor mode) and for the pSeries machine (Guest mode). Guests running under an emulated Hypervisor (PowerNV machine) require a new type of Radix translation, called partition-scoped,

[PATCH 2/7] target/ppc: Introduce a relocation bool in ppc_radix64_handle_mmu_fault()

2020-03-30 Thread Cédric Le Goater
It will ease the introduction of new routines for partition-scoped Radix translation. Signed-off-by: Suraj Jitindar Singh Signed-off-by: Cédric Le Goater --- target/ppc/mmu-radix64.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/ppc/mmu-radix64.c

[PATCH 4/7] target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation

2020-03-30 Thread Cédric Le Goater
This is moving code under a new ppc_radix64_xlate() routine shared by the MMU Radix page fault handler and the get_phys_page_debug PPC callback. The difference being that get_phys_page_debug does not generate exceptions. The specific part of process-scoped Radix translation is moved under

Re: [PULL 00/13] Net patches

2020-03-30 Thread Jason Wang
On 2020/3/27 下午7:36, Peter Maydell wrote: On Fri, 27 Mar 2020 at 11:14, Jason Wang wrote: The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-26 20:55:54

Re: [PATCH v2 03/22] vfio: check VFIO_TYPE1_NESTING_IOMMU support

2020-03-30 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > VFIO needs to check VFIO_TYPE1_NESTING_IOMMU support with Kernel before > further using it. e.g. requires to check IOMMU UAPI version. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Eric Auger > Cc: Yi Sun > Cc: David Gibson > Cc: Alex

Re: [PATCH for-5.0 v3 4/7] configure: Always detect -no-pie toolchain support

2020-03-30 Thread Alex Bennée
Richard Henderson writes: > The CFLAGS_NOPIE and LDFLAGS_NOPIE variables are used > in pc-bios/optionrom/Makefile, which has nothing to do > with the PIE setting of the main qemu executables. > > This overrides any operating system default to build > all executables as PIE, which is important

Re: [kvm-unit-tests PATCH v7 09/13] arm/arm64: ITS: Commands

2020-03-30 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: Implement main ITS commands. The code is largely inherited from the ITS driver. Signed-off-by: Eric Auger [...] +/* ITS COMMANDS */ + +static void its_encode_cmd(struct its_cmd_block *cmd, u8 cmd_nr) +{ + cmd->raw_cmd[0] &= ~0xffUL; +

Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code

2020-03-30 Thread Stefan Hajnoczi
On Wed, Mar 25, 2020 at 08:20:49PM +0100, Philippe Mathieu-Daudé wrote: > On Wed, Mar 25, 2020 at 8:18 PM Philippe Mathieu-Daudé > wrote: > > > > This series is inspired of Peter fix: > > "hw/arm/xlnx-zynqmp.c: fix some error-handling code" > >

Re: [kvm-unit-tests PATCH v7 08/13] arm/arm64: ITS: Device and collection Initialization

2020-03-30 Thread Andrew Jones
On Wed, Mar 25, 2020 at 10:20:43PM +0100, Auger Eric wrote: > Hi Zenghui, > > On 3/25/20 9:10 AM, Zenghui Yu wrote: > > Hi Eric, > > > > On 2020/3/20 17:24, Eric Auger wrote: > >> Introduce an helper functions to register > >> - a new device, characterized by its device id and the > >>    max

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Andrew Jones
On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: > Hi Zenghui, > > On 3/30/20 10:30 AM, Zenghui Yu wrote: > > Hi Eric, > > > > On 2020/3/20 17:24, Eric Auger wrote: > >> +static void its_cmd_queue_init(void) > >> +{ > >> +    unsigned long order = get_order(SZ_64K >> PAGE_SHIFT); > >>

Re: AIO_WAIT_WHILE questions

2020-03-30 Thread Stefan Hajnoczi
On Mon, Mar 30, 2020 at 10:09:45AM +0200, Markus Armbruster wrote: > Cc'ing people based on output of "scripts/get_maintainer.pl -f > include/block/aio-wait.h". > > Dietmar Maurer writes: > > > Hi all, > > > > I have a question about AIO_WAIT_WHILE. The docs inside the code say: > > > > * The

Re: [PATCH] target/arm: fix incorrect current EL bug in aarch32 exception emulation

2020-03-30 Thread Changbin Du
Hi, Peter, Could you take this fix as high priority? This bug has made qemu-system-arm broken. On Sat, Mar 28, 2020 at 10:02:32PM +0800, Changbin Du wrote: > The arm_current_el() should be invoked after mode switching. Otherwise, we > get a wrong current EL value, since current EL is also

Re: [PATCH v4 0/2] Replaced locks with lock guard macros

2020-03-30 Thread Peter Maydell
On Mon, 30 Mar 2020 at 06:54, Daniel Brodsky wrote: > Using `#pragma clang diagnostic ignored > "-Wtautological-type-limit-compare"` suppresses the errors (on Clang > 9). I could go and drop that in for the problem areas? There's only a > few so it wouldn't be a major change. I'm thinking of

Re: [PATCH v4 1/2] virtio-blk: delete vqs on the error path in realize()

2020-03-30 Thread Stefan Hajnoczi
On Sat, Mar 28, 2020 at 08:57:04AM +0800, Pan Nengyuan wrote: > virtio_vqs forgot to free on the error path in realize(). Fix that. > > The asan stack: > Direct leak of 14336 byte(s) in 1 object(s) allocated from: > #0 0x7f58b93fd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) >

Re: [PATCH v8 00/74] per-CPU locks

2020-03-30 Thread Stefan Hajnoczi
On Fri, Mar 27, 2020 at 11:59:37AM +0100, Philippe Mathieu-Daudé wrote: > On 3/27/20 6:14 AM, Emilio G. Cota wrote: > > (Apologies if I missed some Cc's; I was not Cc'ed in patch 0 > > so I'm blindly crafting a reply.) > > > > On Thu, Mar 26, 2020 at 15:30:43 -0400, Robert Foley wrote: > > >

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Auger Eric
Hi Zenghui, On 3/30/20 10:30 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> +static void its_cmd_queue_init(void) >> +{ >> +    unsigned long order = get_order(SZ_64K >> PAGE_SHIFT); >> +    u64 cbaser; >> + >> +    its_data.cmd_base = (void

Re: [PATCH v3 00/10] ARM virt: Add NVDIMM support

2020-03-30 Thread David Hildenbrand
On 30.03.20 10:44, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Michael S. Tsirkin [mailto:m...@redhat.com] >> Sent: 29 March 2020 11:46 >> To: Shameerali Kolothum Thodi >> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; >> eric.au...@redhat.com;

RE: [PATCH v3 00/10] ARM virt: Add NVDIMM support

2020-03-30 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: 29 March 2020 11:46 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com;

Re: [PATCH] qtest: add tulip test case

2020-03-30 Thread Li Qiang
Jason Wang 于2020年3月30日周一 下午3:25写道: > > On 2020/3/28 上午12:11, Li Qiang wrote: > > The tulip networking card emulation has an OOB issue in > > 'tulip_copy_tx_buffers' when the guest provide malformed descriptor. > > This test will trigger a ASAN heap overflow crash. > > > Hi Qiang: > > Thanks for

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: +static void its_cmd_queue_init(void) +{ + unsigned long order = get_order(SZ_64K >> PAGE_SHIFT); + u64 cbaser; + + its_data.cmd_base = (void *)virt_to_phys(alloc_pages(order)); Shouldn't the cmd_base (and the cmd_write) be set

[PATCH] riscv: Fix Stage2 SV32 page table walk

2020-03-30 Thread Anup Patel
As-per RISC-V H-Extension v0.5 draft, the Stage2 SV32 page table has 12bits of VPN[1] and 10bits of VPN[0]. The additional 2bits in VPN[1] is required to handle the 34bit intermediate physical address coming from Stage1 SV32 page table. The 12bits of VPN[1] implies that Stage2 SV32 level-0 page

Re: [PATCH v2] migration: use "" instead of (null) for tls-authz

2020-03-30 Thread maozy
Hi Markus, On 3/30/20 3:18 PM, Markus Armbruster wrote: "Dr. David Alan Gilbert" writes: * Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: run: (qemu) info migrate_parameters announce-initial: 50 ms ... announce-max: 550 ms multifd-compression: none xbzrle-cache-size: 4194304

Re: AIO_WAIT_WHILE questions

2020-03-30 Thread Markus Armbruster
Cc'ing people based on output of "scripts/get_maintainer.pl -f include/block/aio-wait.h". Dietmar Maurer writes: > Hi all, > > I have a question about AIO_WAIT_WHILE. The docs inside the code say: > > * The caller's thread must be the IOThread that owns @ctx or the main loop > * thread (with

[PATCH v10 1/4] qcow2: introduce compression type feature

2020-03-30 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus

[PATCH v10 3/4] qcow2: add zstd cluster compression

2020-03-30 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and

[PATCH v10 0/4] qcow2: Implement zstd cluster compression method

2020-03-30 Thread Denis Plotnikov
v10: * 03: fix zstd (de)compressed loops for multi-frame cases [Vladimir] v9: * 01: fix error checking and reporting in qcow2_amend compression type part [Vladimir] * 03: replace asserts with -EIO in qcow2_zstd_decompression [Vladimir, Alberto] * 03: reword/amend/add

[PATCH v10 4/4] iotests: 287: add qcow2 compression type test

2020-03-30 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

[PATCH v10 2/4] qcow2: rework the cluster compression routine

2020-03-30 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71

Re: [PATCH] qemu: Do not include file if not exists

2020-03-30 Thread Markus Armbruster
Cc'ing maintainers. Oleksiy, this looks like a respin of your patch. Since it is buried in the original thread, our patch processing automation won't pick it up, and humans may well miss it, too. Next time, start a new thread, with proper [PATCH v2] versioning in the subject, and cc: the

Re: [PATCH] qtest: add tulip test case

2020-03-30 Thread Jason Wang
On 2020/3/28 上午12:11, Li Qiang wrote: The tulip networking card emulation has an OOB issue in 'tulip_copy_tx_buffers' when the guest provide malformed descriptor. This test will trigger a ASAN heap overflow crash. Hi Qiang: Thanks for the qtest patch. Few nitpicks, see above.

Re: [PATCH v4 2/2] virtio-iommu: avoid memleak in the unrealize

2020-03-30 Thread Stefano Garzarella
On Sat, Mar 28, 2020 at 08:57:05AM +0800, Pan Nengyuan wrote: > req_vq/event_vq forgot to free in unrealize. Fix that. > And also do clean 's->as_by_busptr' hash table in unrealize to fix another > leak. > > Signed-off-by: Pan Nengyuan > Acked-by: Eric Auger > --- > Cc: Eric Auger > Cc:

Re: [PATCH v2] migration: use "" instead of (null) for tls-authz

2020-03-30 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: >> run: >> (qemu) info migrate_parameters >> announce-initial: 50 ms >> ... >> announce-max: 550 ms >> multifd-compression: none >> xbzrle-cache-size: 4194304 >> max-postcopy-bandwidth: 0 >> tls-authz:

RE: [PATCH v1 02/22] header file update VFIO/IOMMU vSVA APIs

2020-03-30 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > Sent: Monday, March 30, 2020 12:33 AM > To: Liu, Yi L ; qemu-devel@nongnu.org; > Subject: Re: [PATCH v1 02/22] header file update VFIO/IOMMU vSVA APIs > > Hi Yi, > > On 3/22/20 1:35 PM, Liu Yi L wrote: > > The kernel uapi/linux/iommu.h header file includes the

Re: [PATCH] hw/vfio: let readonly flag take effect for mmaped regions

2020-03-30 Thread Yan Zhao
On Mon, Mar 30, 2020 at 09:35:27AM +0800, Yan Zhao wrote: > On Sat, Mar 28, 2020 at 01:25:37AM +0800, Alex Williamson wrote: > > On Fri, 27 Mar 2020 11:19:34 + > > yan.y.z...@intel.com wrote: > > > > > From: Yan Zhao > > > > > > currently, vfio regions without VFIO_REGION_INFO_FLAG_WRITE

<    1   2   3   4