> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>>>
>>> o if there's a need to disable
>>> just one of these, commit log needs to do a better job
On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
> >
> > o if there's a need to disable
> > just one of these, commit log needs to do a better job documenting the
> > usecase.
>
> The use case is simple. With this
On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
> >
> > On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
> >>
> >>
> >>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
> >>>
> >>> o if there's a
The next commits will put it to use.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-3-arm...@redhat.com>
---
util/qemu-option.c | 102 +
1 file changed, 56 insertions(+), 46
The following changes since commit fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6:
Update version for v5.0.0 release (2020-04-28 17:46:57 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-misc-2020-04-29
for you to fetch changes up to
When opts_parse() sets @invalidp to true, qemu_opts_parse_noisily()
uses has_help_option() to decide whether to print help. This parses
the input string a second time.
Easy to avoid: replace @invalidp by @help_wanted.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-4-arm...@redhat.com>
---
tests/test-qemu-opts.c | 4 ++--
util/qemu-option.c | 27 +++
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git
has_help_option() uses its own parser. It's inconsistent with
qemu_opts_parse(), as demonstrated by test-qemu-opts case
/qemu-opts/has_help_option. Fix by reusing the common parser.
Signed-off-by: Markus Armbruster
Message-Id: <20200415074927.19897-5-arm...@redhat.com>
Reviewed-by: Eric Blake
The Error ** argument must be NULL, _abort, _fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
qmp_guest_suspend_disk() and
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-8-arm...@redhat.com>
---
qemu-img.c | 59 +-
1 file changed, 23 insertions(+), 36 deletions(-)
diff --git a/qemu-img.c
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> For example, how about hot-plugging a bridge which doesn't
> support hotplug itself?
So now for every device we want to hot plug, we will add a new bridge? Sounds
not a scalable and elegant idea.
> Would that happen to make
We are going to use aio-task-pool API, so tasks will be handled in
parallel. We need therefore separate allocated task on each iteration.
Introduce this logic now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 18 +++---
1 file changed,
On 4/29/2020 12:22 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option
needs to match the alignment requirement of the device dax.
It must be larger than or equal to the 'align' of device dax.
Signed-off-by: Jingqi Liu
We are going to use aio-task-pool API, so we'll need state pointer in
BlockCopyTask anyway. Add it now and use where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 28 +++-
1 file changed, 15 insertions(+), 13
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 583
Run block_copy iterations in parallel in aio tasks.
Changes:
- BlockCopyTask becomes aio task structure. Add zeroes field to pass
it to block_copy_do_copy
- add call state - it's a state of one call of block_copy(), shared
between parallel tasks. For now used only to keep information
We are going to use aio-task-pool API and extend in-flight request
structure to be a successor of AioTask, so rename things appropriately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 98 +++---
1 file changed, 48 insertions(+), 50
Hi all!
v3:
01: drop extra line "+s->in_flight_bytes -= task->bytes - new_bytes;"
02: add Max's r-b
03: rebased on 01 fix (dropped line not updated now). keep Max's r-b
04: more refactoring:
don't require offset argument of block_copy_task_create being dirty,
use
Philippe Mathieu-Daudé writes:
> Running the coccinelle script produced:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
> --keep-comments --smpl-spacing --dir .
> HANDLING:
> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
> On Apr 29, 2020,
Queued.
Queued.
Improve
$ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB
DIMM/bank supported
qemu-system-ppc: Possible valid RAM size: 2048
to
qemu-system-ppc: at most 1 bank of 2048, 1024, 512, 256, 128, 64, 32 MiB
each
The Error ** argument must be NULL, _abort, _fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
qio_channel_socket_close()
fdctrl_realize_common() rejects fallback=auto. Used by devices
"isa-fdc", "sysbus-fdc", "SUNW,fdtwo". The error handling is broken:
$ qemu-system-x86_64 -nodefaults -device isa-fdc,fallback=auto,driveA=fd0
-drive if=none,id=fd0
**
is_valid_option_list()'s purpose is ensuring qemu-img.c's can safely
join multiple parameter strings separated by ',' like this:
g_strdup_printf("%s,%s", params1, params2);
How it does that is anything but obvious. A close reading of the code
reveals that it fails exactly when its
Philippe Mathieu-Daudé writes:
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h \
> --include-headers --keep-comments --in-place \
> --sp-file \
> scripts/coccinelle/use-error_abort-in-instance_init.cocci
>
> Reviewed-by:
On Tue, Apr 28, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote:
>
> MIDR_EL1 a 64-bit system register with the top 32-bit being RES0.
>
> This fixes when compiling with -Werror=conversion:
>
> target/arm/cpu64.c: In function ‘aarch64_max_initfn’:
> target/arm/cpu64.c:628:21: error: conversion
On Tue, 28 Apr 2020 18:34:18 +0200
Markus Armbruster wrote:
> chassis_from_bus() uses object_property_get_uint() to get property
> "chassis_nr" of the bridge device. Failure would be a programming
> error. Pass _abort, and simplify its callers.
>
> Cc: David Gibson
> Cc: qemu-...@nongnu.org
On 4/29/2020 12:23 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
Add a pair of configure options --{enable,disable}-libdaxctl to control
whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility
library for managing the device dax subsystem.
QEMU uses mmap(2) to maps
+Peter for crediting his advice.
On 4/29/20 7:59 AM, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 4/24/20 9:20 PM, Markus Armbruster wrote:
The Error ** argument must be NULL, _abort, _fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind
Queued.
qemu-img create, convert, amend, and measure use accumulate_options()
to merge multiple -o options. This is broken for -o "":
$ qemu-img create -f qcow2 -o backing_file=a -o "" -o
backing_fmt=raw,size=1M new.qcow2
qemu-img: warning: Could not verify backing image. This may become an
Philippe Mathieu-Daudé writes:
> Fixes the following coccinelle warnings:
>
> $ spatch --sp-file --verbose-parsing ... \
> scripts/coccinelle/remove_local_err.cocci
> ...
> SUSPICIOUS: a \ character appears outside of a #define at
> ./target/ppc/translate_init.inc.c:5213
[...]
>
Instead of just relying on the comment "Called only on full-dirty
region" in block_copy_task_create() let's move initial dirty area
search directly to block_copy_task_create(). Let's also use effective
bdrv_dirty_bitmap_next_dirty_area instead of looping through all
non-dirty clusters.
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> o if there's a need to disable
> just one of these, commit log needs to do a better job documenting the
> usecase.
The use case is simple. With this feature admins will be able to do what they
were forced to do from Windows
On Tue, 28 Apr 2020 16:13:05 -0400
Stefan Berger wrote:
> On 4/28/20 6:38 AM, Cornelia Huck wrote:
> > On Mon, 27 Apr 2020 16:31:43 +0200
> > Eric Auger wrote:
> >
> >> Instead of using a compat in the mach-virt machine to force
> >> PPI off for all virt machines (PPI not supported by the
>
Markus Armbruster writes:
> The Error ** argument must be NULL, _abort, _fatal, or a
> pointer to a variable containing NULL. Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no longer points to NULL for the second
Patchew URL:
https://patchew.org/QEMU/20200429061054.348b23c0...@aeryn.lan.ktmba/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] audio/jack: add JACK client audiodev
Message-id: 20200429061054.348b23c0...@aeryn.lan.ktmba
Hi Christian,
On 4/28/20 8:31 PM, Christian Borntraeger wrote:
We need some little help in the code to reduce the valgrind noise.
- some designated initializers for the cpu model features and subfunctions
^ This could go as trivial patch while we discuss the rest.
- mark memory as defined
Markus Armbruster writes:
> ... the comment next to qos_set_machines_devices_available() wonders.
> Yup, there is!
Queued.
Requesting 32 or 64 MiB of RAM with the sam460ex machine type produces
a useless warning:
qemu-system-ppc: warning: Memory size is too small for SDRAM type,
adjusting type
This is because sam460ex_init() asks spd_data_generate() for DDR2,
which is impossible, so spd_data_generate() corrects
The two turn out to be inconsistent for "a,b,,help". Test case
marked /* BUG */.
Signed-off-by: Markus Armbruster
Message-Id: <20200415074927.19897-2-arm...@redhat.com>
Reviewed-by: Eric Blake
---
tests/test-qemu-opts.c | 44 ++
1 file changed, 44
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-6-arm...@redhat.com>
---
tests/test-qemu-opts.c | 36 +---
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/tests/test-qemu-opts.c
Signed-off-by: Markus Armbruster
Message-Id: <20200424071142.3525-4-arm...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qtest/libqos/qos_external.h | 2 --
tests/qtest/libqos/qos_external.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git
The conversion of xen_pt_initfn() to xen_pt_realize() blindly replaced
XEN_PT_ERR() by error_setg(). Several error conditions that did not
fail xen_pt_initfn() now fail xen_pt_realize(). Unsurprisingly, the
cleanup on these errors looks highly suspicious.
Revert the inappropriate replacements.
From: Masahiro Yamada
The second argument 'id' is a pointer. Pass NULL rather than 0.
Signed-off-by: Masahiro Yamada
Message-Id: <20200427005704.2475782-1-masahi...@kernel.org>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
softmmu/vl.c | 10 +-
1 file changed,
From: Philippe Mathieu-Daudé
Fixes the following coccinelle warnings:
$ spatch --sp-file --verbose-parsing ... \
scripts/coccinelle/remove_local_err.cocci
...
SUSPICIOUS: a \ character appears outside of a #define at
./target/ppc/translate_init.inc.c:5213
SUSPICIOUS: a \
The Error ** argument must be NULL, _abort, _fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
virt_machine_device_plug_cb()
spd_data_generate() splits @ram_size bytes into @nbanks RAM banks of
1 << sz_log2 MiB each, like this:
size = ram_size >> 20; /* work in terms of megabytes */
[...]
nbanks = 1;
while (sz_log2 > max_log2 && nbanks < 8) {
sz_log2--;
nbanks++;
}
Each iteration
Right now, all users of bdrv_make_empty() call the BlockDriver method
directly. That is not only bad style, it is also wrong, unless the
caller has a BdrvChild with a WRITE or WRITE_UNCHANGED permission.
(WRITE_UNCHANGED suffices, because callers generally use this function
to clear a node with a
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
---
block/replication.c | 6 ++
block/vvfat.c | 4 +---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index da013c2041..cc6a40d577 100644
---
The _STA method dates back to the days where we had a static DSDT. The
device is listed in the DSDT table unconditionally and the _STA method
checks a bit in the isa bridge pci config space to figure whenever a
given is isa device is present or not, then evaluates to 0x0f (present)
or 0x00
On Wed, Apr 29, 2020 at 02:47:33PM +0200, Miklos Szeredi wrote:
> While it's not possible to escape the proc filesystem through
> lo->proc_self_fd, it is possible to escape to the root of the proc
> filesystem itself through "../..".
Hi Miklos,
So this attack will work with some form of
On Wed, 29 Apr 2020 at 15:33, Dino Papararo wrote:
>
> Hi Alex,
> maybe a pseudo code can show better what I mean
>
> if (ppc_fpu_instruction == USE_FPSCR) /* instruction have dot '.' so FPSCR
> will be updated and we need have care about it */
> soft_decode (ppc_fpu_instruction)
> else
On 4/29/20 9:11 AM, Max Reitz wrote:
Right now, all users of bdrv_make_empty() call the BlockDriver method
directly. That is not only bad style, it is also wrong, unless the
caller has a BdrvChild with a WRITE or WRITE_UNCHANGED permission.
(WRITE_UNCHANGED suffices, because callers generally
* Stefan Hajnoczi (stefa...@redhat.com) wrote:
> On Wed, Apr 29, 2020 at 02:47:33PM +0200, Miklos Szeredi wrote:
> > While it's not possible to escape the proc filesystem through
> > lo->proc_self_fd, it is possible to escape to the root of the proc
> > filesystem itself through "../..".
> >
> >
Instead of just relying on the comment "Called only on full-dirty
region" in block_copy_task_create() let's move initial dirty area
search directly to block_copy_task_create(). Let's also use effective
bdrv_dirty_bitmap_next_dirty_area instead of looping through all
non-dirty clusters.
罗勇刚(Yonggang Luo) writes:
> On Wed, Apr 29, 2020 at 7:57 PM Alex Bennée wrote:
>
>>
>> Dino Papararo writes:
>>
>> > Hello,
>> > about handling of PPC fpu exceptions and Hard Floats support we could
>> consider a different approach for different instructions.
>> > i.e. not all fpu
Hi, this series is 30 days old and didn't attract any replies. As the
5.0 release has just shipped, it may be re-appropriate to resubmit this
series for inclusion in the next release.
On 3/22/20 5:11 AM, Eyal Moscovici wrote:
> Hi,
>
> The following series adds two parameters to qemu-img map:
>
On 4/21/20 5:42 AM, Philippe Mathieu-Daudé wrote:
> QEMU Python scripts have been moved in commit 8f8fd9edba4 ("Introduce
> Python module structure"). Use the same sys.path modification used
> in the referenced commit to be able to use these scripts again.
>
> Signed-off-by: Philippe
Le 29/04/2020 à 11:26, Alex Bennée a écrit :
>
> Laurent Vivier writes:
>
>> Le 28/04/2020 à 20:43, Alex Bennée a écrit :
>>>
>>> KONRAD Frederic writes:
>>>
The MC68881 say about infinities (3.2.4):
"*For the extended precision format, the most significant bit of the
On Wed, Apr 29, 2020 at 04:47:19PM +0200, Miklos Szeredi wrote:
> On Wed, Apr 29, 2020 at 4:36 PM Vivek Goyal wrote:
> >
> > On Wed, Apr 29, 2020 at 02:47:33PM +0200, Miklos Szeredi wrote:
> > > While it's not possible to escape the proc filesystem through
> > > lo->proc_self_fd, it is possible
* Peter Xu (pet...@redhat.com) wrote:
> This RFC series starts from the fact that we will sync dirty bitmap when
> removing a memslot for KVM. IIUC that was majorly to maintain the dirty
> bitmap
> even across a system reboot.
>
> This series wants to move that sync from kvm memslot removal to
The _STA method dates back to the days where we had a static DSDT. The
device is listed in the DSDT table unconditionally and the _STA method
checks a bit in the isa bridge pci config space to figure whenever a
given is isa device is present or not, then evaluates to 0x0f (present)
or 0x00
Add and use RTC_ISA_BASE define instead of hardcoding 0x70.
Signed-off-by: Gerd Hoffmann
---
include/hw/rtc/mc146818rtc.h | 1 +
hw/rtc/mc146818rtc.c | 5 ++---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h
Also add isa_aml_build() function which walks all isa devices.
This allows to move aml builder code to isa devices.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
include/hw/isa/isa.h | 2 ++
hw/i386/acpi-build.c | 1 +
hw/isa/isa-bus.c | 15 +++
3 files changed,
Also use a single io range instead of two,
following what real hardware does.
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-build.c | 17 -
hw/rtc/mc146818rtc.c | 20
2 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/hw/i386/acpi-build.c
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote:
We are generally moving to int64_t for both offset and bytes parameters
on all io paths. Convert tracked requests now.
As mentioned elsewhere in the thread, this states 'what' but not 'why';
adding a bit more of the 'why' can be useful
On Wed, Apr 29, 2020 at 05:28:25PM +0200, Markus Armbruster wrote:
> Is there any sane use for configuring backends via any of the default
> mechanisms?
>
> I'm aware of one, but it's outdated: -global isa-fdc.driveA=... Use
> -device floppy instead.
>
> I'd love to deprecate -global wholesale,
Hi!
Just a fun case of (invalid) usage of qemu-system command line.
Someone tried -nic model=rocker, and qemu does this:
Unexpected error in object_property_find() at
/build/qemu/git/qom/object.c:1029:
qemu-system-x86_64: Property '.mac' not found
Aborted
This happens after this commit:
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Max Reitz (mre...@redhat.com) wrote:
> > Currently, setup_mounts() bind-mounts the shared directory without
> > MS_REC. This makes all submounts disappear.
> >
> > Pass MS_REC so that the guest can see submounts again.
>
> Thanks!
>
> >
On 2020-04-29 22:59, Eric Blake wrote:
On 4/29/20 12:53 AM, Geoffrey McRae wrote:
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
The flake8 program is a standard tool used by Python projects for
validating many commonly recommended style rules. It would be desirable
for QEMU to come into alignment with normal Python coding style best
practices.
QEMU currently violates a huge number of the style rules, so we can't
blindly
On Wed, Apr 29, 2020 at 03:57:20PM +0100, Dr. David Alan Gilbert wrote:
> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> > * Max Reitz (mre...@redhat.com) wrote:
> > > Currently, setup_mounts() bind-mounts the shared directory without
> > > MS_REC. This makes all submounts disappear.
> >
On Fri, 24 Apr 2020 14:44:48 -0400
Eduardo Habkost wrote:
> On Fri, Apr 24, 2020 at 03:23:56PM +, Ani Sinha wrote:
> >
> >
> > > On Apr 22, 2020, at 4:15 PM, Ani Sinha wrote:
> > >
> > >
> > >
> > >> On Apr 21, 2020, at 8:32 PM, Daniel P. Berrangé
> > >> wrote:
> > >>
> > >> On
> If the Hypervisor sets the V* interrupts why does it then want to
> receive the interrupt itself?
I don't think this is a question of whether there is a use case for it
or not (I agree with you, of the top of my head I don't see why would
you forward v* interrupts to the hypervisor). However,
Hi all,
as you are probably aware I haven't been paying attention to dirty
bitmap work very much for the past month.
Around KVM Forum, we had a giant thread dedicated to discussing the
problems with dirty bitmap migration, which in a nutshell, are that it
migrates using the node name with no
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-build.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a8b790021974..98b3fd1cdb14 100644
--- a/hw/i386/acpi-build.c
Also adds support for multiple LPT devices.
Signed-off-by: Gerd Hoffmann
---
hw/char/parallel.c | 32
hw/i386/acpi-build.c | 23 ---
2 files changed, 32 insertions(+), 23 deletions(-)
diff --git a/hw/char/parallel.c b/hw/char/parallel.c
Add 5.1 machine types for arm/i440fx/q35/s390x/spapr.
Acked-by: David Gibson
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Cornelia Huck
---
v1->v2: rebased on top of "virt: Set tpm-tis-device ppi property to off by
default" to avoid breakage on arm
---
hw/arm/virt.c |
On Wed, Apr 29, 2020 at 4:36 PM Vivek Goyal wrote:
>
> On Wed, Apr 29, 2020 at 02:47:33PM +0200, Miklos Szeredi wrote:
> > While it's not possible to escape the proc filesystem through
> > lo->proc_self_fd, it is possible to escape to the root of the proc
> > filesystem itself through "../..".
>
On 4/21/20 5:42 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> scripts/qmp/qom-get | 2 +-
> scripts/qmp/qom-list | 2 +-
> scripts/qmp/qom-set | 2 +-
> scripts/qmp/qom-tree | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
On 4/29/20 8:02 AM, Vladimir Sementsov-Ogievskiy wrote:
+ /*
+ * The compressed stream from the input buffer may consist of
more
+ * than one zstd frame.
Can it?
If not, we must require it in the specification.
Actually, now that you mention it, it would make sense anyway to
Signed-off-by: Gerd Hoffmann
---
hw/block/fdc.c | 83
hw/i386/acpi-build.c | 83
stubs/cmos.c | 7
stubs/Makefile.objs | 1 +
4 files changed, 91 insertions(+), 83 deletions(-)
create
Two callers of BlockDriver.bdrv_make_empty() remain that should not call
this method directly. Both do not have access to a BdrvChild, but they
can use a BlockBackend, so we add this function that lets them use it.
Signed-off-by: Max Reitz
---
include/sysemu/block-backend.h | 2 ++
[meta-comment]
On 4/29/20 4:35 AM, Yan Zhao wrote:
On Wed, Apr 29, 2020 at 04:22:01PM +0800, Dr. David Alan Gilbert wrote:
[...]
This patchset introduces a migration_version attribute under sysfs
of VFIO
Mediated devices.
Hmm, several pages with up to 16 levels of quoting, with editors
Needed when moving aml builder code to devices.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/acpi/aml-build-stub.c | 79
hw/acpi/Makefile.objs| 4 +-
2 files changed, 81 insertions(+), 2 deletions(-)
create mode 100644
On 3/22/20 4:11 AM, Eyal Moscovici wrote:
The mapping operation of large disks especially ones stored over a
long chain of QCOW2 files can take a long time to finish.
Additionally when mapping fails there was no way recover by
restarting the mapping from the failed location.
The new options,
On Wed, Apr 29, 2020 at 5:00 PM Vivek Goyal wrote:
>
> On Wed, Apr 29, 2020 at 04:47:19PM +0200, Miklos Szeredi wrote:
> > On Wed, Apr 29, 2020 at 4:36 PM Vivek Goyal wrote:
> > >
> > > On Wed, Apr 29, 2020 at 02:47:33PM +0200, Miklos Szeredi wrote:
> > > > While it's not possible to escape the
Here's how we represent QOM properties:
struct ObjectProperty
{
gchar *name;
[...]
ObjectPropertyAccessor *get;
ObjectPropertyAccessor *set;
ObjectPropertyInit *init;
void *opaque;
QObject *defval;
};
= The setter =
A ->set()
Run block_copy iterations in parallel in aio tasks.
Changes:
- BlockCopyTask becomes aio task structure. Add zeroes field to pass
it to block_copy_do_copy
- add call state - it's a state of one call of block_copy(), shared
between parallel tasks. For now used only to keep information
On 4/28/20 9:24 PM, no-re...@patchew.org wrote:
Patchew URL: https://patchew.org/QEMU/20200428202905.770727-1-ebl...@redhat.com/
/tmp/qemu-test/src/block/parallels.c: In function 'parallels_co_writev':
/tmp/qemu-test/src/block/parallels.c:218:12: error: 'ret' may be used
uninitialized in
The code uses the isa_serial_io array to figure what the device uid is.
Side effect is that acpi antries are not limited to port 1+2 any more,
we'll also get entries for ports 3+4.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/char/serial-isa.c | 32
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
include/hw/acpi/aml-build.h | 1 -
include/qemu/typedefs.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 0f4ed53d7fbf..1539fe066714 100644
---
Add helper function to add fw_cfg device,
also move code to hw/i386/fw_cfg.c.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/fw_cfg.h | 1 +
hw/i386/acpi-build.c | 24 +---
hw/i386/fw_cfg.c | 28
3 files
On 29.04.20 16:11, Max Reitz wrote:
> bdrv_commit() already has a BlockBackend pointing to the BDS that we
> want to empty, it just has the wrong permissions.
>
> qemu-img commit has no BlockBackend pointing to the old backing file
> yet, but introducing one is simple.
>
> After this commit,
bdrv_commit() already has a BlockBackend pointing to the BDS that we
want to empty, it just has the wrong permissions.
qemu-img commit has no BlockBackend pointing to the old backing file
yet, but introducing one is simple.
After this commit, bdrv_make_empty() is the only remaining caller of
On Wed, Apr 29, 2020 at 02:26:07PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > This RFC series starts from the fact that we will sync dirty bitmap when
> > removing a memslot for KVM. IIUC that was majorly to maintain the dirty
> > bitmap
> > even across a
Hi Alex,
maybe a pseudo code can show better what I mean
if (ppc_fpu_instruction == USE_FPSCR) /* instruction have dot '.' so FPSCR will
be updated and we need have care about it */
soft_decode (ppc_fpu_instruction)
else /* instruction have not dot '.' and FPSCR will be never updated
1 - 100 of 406 matches
Mail list logo
