The L2 bitmap needs to be updated after each write to indicate what
new subclusters are now allocated. This needs to happen even if the
cluster was already allocated and the L2 entry was otherwise valid.
In some cases however a write operation doesn't need change the L2
bitmap (because all
handle_alloc() creates a QCowL2Meta structure in order to update the
image metadata and perform the necessary copy-on-write operations.
This patch moves that code to a separate function so it can be used
from other places.
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
---
For a given offset, return the subcluster number within its cluster
(i.e. with 32 subclusters per cluster it returns a number between 0
and 31).
Signed-off-by: Alberto Garcia
Reviewed-by: Max Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 5 +
1 file changed, 5
This function will be used by the qcow2 code to check if an image has
subclusters or not.
At the moment this simply returns false. Once all patches needed for
subcluster support are ready then QEMU will be able to create and
read images with subclusters and this function will return the actual
On Thu, Apr 30, 2020 at 9:26 AM Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> Some stream clients stream an endless stream of data while
> other clients stream data in packets. Stream interfaces
> usually have a way to signal the end of a packet or the
> last beat of a transfer.
>
>
On 05/05/20 17:29, Markus Armbruster wrote:
> qom/object.c provides object_property_get_TYPE() and
> object_property_set_TYPE() for a number of common types. These are
> all convenience wrappers around object_property_get_qobject() and
> object_property_set_qobject().
>
> Except for
On Thu, Apr 30, 2020 at 9:29 AM Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> Add DMA memory-region property to externally control what
> address-space this DMA operates on.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
>
On Thu, Apr 30, 2020 at 9:28 AM Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> Remove unncessary cast, buf is already uint8_t *.
> No functional change.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/net/xilinx_axienet.c | 2 +-
> 1 file
On Thu, Apr 30, 2020 at 9:26 AM Edgar E. Iglesias
wrote:
>
> From: "Edgar E. Iglesias"
>
> Split the shared stream_class_init function to assign
> stream->push with better type-safety.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
>
On 05/05/20 17:29, Markus Armbruster wrote:
> Reuse object_property_get_str(). Switches from the string to the
> qobject visitor under the hood.
>
> Signed-off-by: Markus Armbruster
> ---
> qom/object.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git
On 05/05/20 18:03, Markus Armbruster wrote:
>> That's a good one, and especially a safe one, since it matches
>> qdev_device_add. It has the disadvantage of having to touch all
>> qdev_create() calls.
>
> Also, it moves onboard devices from /machine/unattached/ to
> /machine/peripheral-anon/.
On Tue, 5 May 2020 at 16:44, Eric Auger wrote:
>
> Those patches bring MMIO TPM TIS ACPI support in machvirt.
> The first patch moves the TPM2 ACPI table generation code
> in the generic code. Then the table is added if the TPM2
> sysbus device is dynamically instantiated in machvirt.
> Also the
On 5/5/20 10:44 AM, Eric Auger wrote:
We plan to build the tpm2 table on ARM too. In order to reuse the
generation code, let's move build_tpm2() to aml-build.c.
No change in the implementation.
Signed-off-by: Eric Auger
Reviewed-by: Stefan Berger
---
include/hw/acpi/aml-build.h | 2
On 5/5/20 10:44 AM, Eric Auger wrote:
Add a TPM2 ACPI table if a TPM2.0 sysbus device has been
dynamically instantiated.
Signed-off-by: Eric Auger
Reviewed-by: Stefan Berger
---
v1 -> v2:
- reuse generic build_tpm2() and alloc log area externally
- call tpm_find() once in build_tpm2()
Paolo Bonzini writes:
> On 04/05/20 16:38, Markus Armbruster wrote:
>> makes no progreess because OBJECT(dev)->parent is still null, and
>> therefore object_unparent() does nothing.
>>
>> Possible culprit: qdev_try_create() calls qdev_set_parent_bus(), which
>> adds the device to the bus, but
On 5/5/20 5:29 PM, Markus Armbruster wrote:
Same story as for object_property_add(): the only way
object_property_del() can fail is when the property with this name
does not exist. Since our property names are all hardcoded, failure
is a programming error, and the appropriate way to handle it
On 5/5/20 5:29 PM, Markus Armbruster wrote:
Reuse object_property_get_str(). Switches from the string to the
qobject visitor under the hood.
Signed-off-by: Markus Armbruster
---
qom/object.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/qom/object.c
On 5/4/20 11:46 AM, Philippe Mathieu-Daudé wrote:
In nvme_create_queue_pair() we create a page list using
qemu_blockalign(), then map it with qemu_vfio_dma_map():
q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE);
r = qemu_vfio_dma_map(s->vfio, q->prp_list_pages,
On 05/05/2020, Igor Mammedov wrote:
I dont know what were the original intentions of the original patch
authors (at this point I simply rebased it, and to be honest I did not
need this patch to get where I was going to, but it was part of the
original patchset).
But I'm willing to do any
On Mon, 4 May 2020 at 22:21, Eric Blake wrote:
>
> Happy Star Wars Day! May the Fourth be with you as you apply this...
>
> The following changes since commit 5375af3cd7b8adcc10c18d8083b7be63976c9645:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2020-05-04
On 5/5/20 2:35 AM, Kevin Wolf wrote:
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben:
qcow has no space in the metadata to store a backing format, and there
are existing qcow images backed both by raw or by other formats
(usually qcow) images, reliant on probing to tell the difference.
While
The "bcm2835-peripherals" device's .instance_init() method
bcm2835_peripherals_init() attempts to make two memory regions QOM
children of the device. This is futile, because memory_region_init()
already did. The errors are ignored (a later commit will change
that). Drop the useless calls.
Cc:
isa_superio_realize() attempts to make isa-parallel and isa-serial QOM
children, but this does not work, because it calls
object_property_add_child() after realizing with qdev_init_nofail().
Realizing a device without a parent gives it one: it gets put into the
"/machine/unattached/" orphanage.
object_property_set_description() and
object_class_property_set_description() fail only when property @name
is not found.
There are 85 calls of object_property_set_description() and
object_class_property_set_description(). None of them can fail:
* 84 immediately follow the creation of the
Several functions can't fail anymore: ich9_pm_add_properties(),
device_add_bootindex_property(), ppc_compat_add_property(),
spapr_caps_add_properties(), PropertyInfo.create(). Drop their @errp
parameter.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
qom/object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 07762cc331..3d65658059 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -614,7 +614,7 @@
On Tue, May 05, 2020 at 04:23:59PM +0100, Stefan Hajnoczi wrote:
> On Mon, May 04, 2020 at 04:07:22PM +0200, Marc-André Lureau wrote:
> > Hi
> >
> > On Fri, May 1, 2020 at 8:29 PM Colin Walters wrote:
> > >
> > > I'd like to make use of virtiofs as part of our tooling in
> > >
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't
Some object_property_add_FOO() return the newly added property, some
don't. Clean that up.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
include/qom/object.h | 50 ++---
qom/object.c | 250 ++-
2
chassis_from_bus() uses object_property_get_uint() to get property
"chassis_nr" of the bridge device. Failure would be a programming
error. Pass _abort, and simplify its callers.
Cc: David Gibson
Cc: qemu-...@nongnu.org
Signed-off-by: Markus Armbruster
Acked-by: David Gibson
Reviewed-by:
Includes one actual bug fix for s390x.
v2:
* Rebased, conflicts in PATCH 07+14 resolved
* New "[PATCH v2 04/18] qom: Simplify object_property_get_enum()"
* Old "[PATCH 04/17] qom: Change object_property_get_uint16List() to
match its doc" replaced by new "[PATCH v2 05/18] qom: Drop convenience
Same story as for object_property_add(): the only way
object_property_del() can fail is when the property with this name
does not exist. Since our property names are all hardcoded, failure
is a programming error, and the appropriate way to handle it is
passing _abort. Most callers do that, the
Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and
s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is
"pcc-cmac-eaes-256". The former is obviously a pasto.
Impact:
* s390_feat_bitmap_to_ascii() misidentifies S390_FEAT_PCC_CMAC_AES_256
as "pcc-cmac-eaes-256". Affects QMP commands
qom/object.c provides object_property_get_TYPE() and
object_property_set_TYPE() for a number of common types. These are
all convenience wrappers around object_property_get_qobject() and
object_property_set_qobject().
Except for object_property_get_uint16List(), which is unusual in two ways:
*
Both qdev_connect_gpio_out_named() and device_set_realized() put
objects without a parent into the "/machine/unattached/" orphanage.
qdev_connect_gpio_out_named() needs a lengthy comment to explain how
it works. It exploits that object_property_add_child() can fail only
when we got a parent
The tests' "qemu-dummy" device has only class properties. Turn one of
them into an instance property. test_dummy_class_iterator() expects
one fewer property than test_dummy_iterator(). Rewrite
test_dummy_prop_iterator() to take expected properties as argument.
Signed-off-by: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Paolo Bonzini
---
qom/object.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index be700e831f..5511649502 100644
--- a/qom/object.c
+++ b/qom/object.c
@@
Reuse object_property_get_str(). Switches from the string to the
qobject visitor under the hood.
Signed-off-by: Markus Armbruster
---
qom/object.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 3d65658059..b374af302c 100644
---
Uses of gchar * in qom/object.h:
* ObjectProperty member @name
Functions that take a property name argument all use char *. Change
the member to match.
* ObjectProperty member @type
Functions that take a property type argument or return it all use
char *. Change the member to match.
QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().
Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init(). For the concrete subtypes, it duly gets run
twice. The second run fails, but the error
Hello!
Unfortunately the bug has apparently reappeared. I have a Windows 10 running in
a VM, which after my today's "apt upgrade" goes into pause mode after a few
seconds of running time.
Tail output of my /var/log/libvirt/qemu/win10.log
char device redirected to /dev/pts/1 (label charserial0)
Philippe Mathieu-Daudé writes:
> On 4/28/20 6:34 PM, Markus Armbruster wrote:
>> Both qdev_connect_gpio_out_named() and device_set_realized() put
>> objects without a parent into the "/machine/unattached/" orphanage.
>>
>> qdev_connect_gpio_out_named() needs a lengthy comment to explain how
>>
On Mon, May 04, 2020 at 04:07:22PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Fri, May 1, 2020 at 8:29 PM Colin Walters wrote:
> >
> > I'd like to make use of virtiofs as part of our tooling in
> > https://github.com/coreos/coreos-assembler
> > Most of the code runs as non-root today; qemu also
David Hildenbrand writes:
> [...]
>
>> 1 "msa4-base": true,
>> 1 "pcc-cmac-aes-256": false,
>> 1 "pcc-cmac-eaes-256": false,
>>
>> The grouping and masking you described appears to apply to
>>
On Tue, 5 May 2020 15:43:02 +0200
Gerd Hoffmann wrote:
> ... in case we are using ACPI.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
> ---
> hw/i386/microvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
>
On Tue, 5 May 2020 15:43:01 +0200
Gerd Hoffmann wrote:
> $subject says all. Can be disabled using the usual -no-acpi switch.
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/i386/acpi-microvm.h| 6 ++
> include/hw/i386/microvm.h | 8 ++
> hw/i386/acpi-microvm.c| 198
On Mon, May 04, 2020 at 04:05:18PM -0400, John Snow wrote:
> Hi!
>
> It keeps coming up in review or in bugs that it would be nice to ship
> certain python scripts or modules outside of QEMU for easy consumption
> as dev tooling, light debugging SDKs, or other various tasks. We keep
> avoiding
The test deb has been pushed to
https://launchpad.net/~ikepanhc/+archive/ubuntu/lp1805256
40 run with patch mentioned in #43 and all passed.
Thanks.
** Changed in: kunpeng920
Status: Incomplete => Triaged
** Changed in: kunpeng920
Assignee: (unassigned) => Ike Panhc (ikepanhc)
**
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 677
On Tue, 5 May 2020 15:43:00 +0200
Gerd Hoffmann wrote:
> Uses TYPE_ACPI_GED as QOM parent for code reuse.
> Add registers for sleep states and reset.
> Add powerdown notifier for power button events.
registers aren't x86 specific per spec,
can we put these registers into TYPE_ACPI_GED
and
On Thu, Apr 30, 2020 at 06:24:36PM +0200, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add support for fragmented packets from the DMA.
In v2 I'll add a check in the tx-path for packets larger than c_txmem...
Cheers,
Edgar
>
> Signed-off-by: Edgar E. Iglesias
> ---
>
On Mon, 4 May 2020 at 17:02, Laurent Vivier wrote:
>
> The following changes since commit 2ef486e76d64436be90f7359a3071fb2a56ce835:
>
> Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into s=
> taging (2020-05-03 14:12:56 +0100)
>
> are available in the Git repository at:
>
[...]
> 1 "msa4-base": true,
> 1 "pcc-cmac-aes-256": false,
> 1 "pcc-cmac-eaes-256": false,
>
> The grouping and masking you described appears to apply to
> query-cpu-model-expansion with type "static". With type
We plan to build the tpm2 table on ARM too. In order to reuse the
generation code, let's move build_tpm2() to aml-build.c.
No change in the implementation.
Signed-off-by: Eric Auger
---
include/hw/acpi/aml-build.h | 2 ++
hw/acpi/aml-build.c | 30 ++
Those patches bring MMIO TPM TIS ACPI support in machvirt.
The first patch moves the TPM2 ACPI table generation code
in the generic code. Then the table is added if the TPM2
sysbus device is dynamically instantiated in machvirt.
Also the TPM2 device object is described in the DSDT.
Many thanks to
In case it is dynamically instantiated, add the TPM 2.0 device object
under the DSDT table in the ACPI namespace. Its HID is MSFT0101
while its current resource settings (CRS) property is initialized
with the guest physical address and MMIO size of the device.
Signed-off-by: Eric Auger
Add a TPM2 ACPI table if a TPM2.0 sysbus device has been
dynamically instantiated.
Signed-off-by: Eric Auger
---
v1 -> v2:
- reuse generic build_tpm2() and alloc log area externally
- call tpm_find() once in build_tpm2()
---
include/sysemu/tpm.h | 2 ++
hw/acpi/aml-build.c | 5
On 4/28/20 6:34 PM, Markus Armbruster wrote:
Both qdev_connect_gpio_out_named() and device_set_realized() put
objects without a parent into the "/machine/unattached/" orphanage.
qdev_connect_gpio_out_named() needs a lengthy comment to explain how
it works. It exploits that
On Tue, 5 May 2020 15:42:59 +0200
Gerd Hoffmann wrote:
> Add fields to struct AcpiFadtData and update build_fadt() to properly
> generate sleep register entries.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
> ---
> include/hw/acpi/acpi-defs.h | 2 ++
> hw/acpi/aml-build.c
On Tue, 5 May 2020 15:42:58 +0200
Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
patch probably isn't needed, see my comment on 9/13
> ---
> hw/i386/acpi-common.h | 19 +++
> hw/i386/acpi-build.c | 18 --
> 2 files changed, 19 insertions(+), 18
Drop superfluous parenthesis around VMPortReadFunc typedef
(added in d67f679d99, missed to remove when moved in e595112985).
Suggested-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/vmport.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, 5 May 2020 15:42:57 +0200
Gerd Hoffmann wrote:
the same question like with FACS, why legacy data are needed for with reduced
profile?
it mostly initializes data for fixed-hw model.
I'd preffer if you drop FACS and use minimal FADT like build_fadt_rev5() does
without pulling along a
David Hildenbrand writes:
> On 02.05.20 08:26, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 30.04.20 20:22, Markus Armbruster wrote:
David Hildenbrand writes:
> On 28.04.20 18:34, Markus Armbruster wrote:
>> Both
On 5/4/20 11:09 PM, Philippe Mathieu-Daudé wrote:
>> @@ -7111,7 +7121,7 @@ static void disas_simd_zip_trn
>> }
>> tcg_resl = tcg_const_i64(0);
>> - tcg_resh = tcg_const_i64(0);
>> + tcg_resh = is_q ? tcg_const_i64(0) : NULL;
>> tcg_res = tcg_temp_new_i64();
>> for
Calling bdrv_getlength() to get the pre-truncate file size will not
really work on block devices, because they have always the same length,
and trying to write beyond it will fail with a rather cryptic error
message.
Instead, we should use qcow2_get_last_cluster() and bdrv_getlength()
only as a
On [2020 Apr 30] Thu 18:24:36, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add support for fragmented packets from the DMA.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Francisco Iglesias
> ---
> hw/net/xilinx_axienet.c | 31 ---
> 1 file
On [2020 Apr 30] Thu 18:24:35, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Some stream clients stream an endless stream of data while
> other clients stream data in packets. Stream interfaces
> usually have a way to signal the end of a packet or the
> last beat of a transfer.
>
>
On 5/5/20 3:42 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-common.h | 3 ++-
hw/i386/acpi-build.c | 2 +-
hw/i386/acpi-common.c | 26 +++---
3 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/hw/i386/acpi-common.h
From: "Edgar E. Iglesias"
Calling access_el3_aa32ns() works for AArch32 only cores
but it does not handle 32-bit EL2 on top of 64-bit EL3
for mixed 32/64-bit cores.
Merge access_el3_aa32ns_aa64any() into access_el3_aa32ns()
and only use the latter.
Fixes: 68e9c2fe65 ("target-arm: Add
From: "Edgar E. Iglesias"
Hi,
Laurent reported hitting the assert in access_el3_aa32ns()
when accessing 32-bit versions of some of the virtualization
regs when EL3 is 64-bit.
I think we got this wrong back then and it seems to me like
we should merge access_el3_aa32ns and
On Tue, 5 May 2020 15:42:56 +0200
Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
why do you need FACS with reduced profile?
> ---
> hw/i386/acpi-common.h | 1 +
> hw/i386/acpi-build.c | 11 +--
> hw/i386/acpi-common.c | 7 +++
> 3 files changed, 9 insertions(+), 10
On 5/5/20 4:04 PM, Michael S. Tsirkin wrote:
On Tue, May 05, 2020 at 03:42:52PM +0200, Gerd Hoffmann wrote:
I know that not supporting ACPI in microvm is intentional. If you still
don't want ACPI this is perfectly fine, you can use the usual -no-acpi
switch to toggle ACPI support.
These are
On Tue, 5 May 2020 at 15:04, Richard Henderson
wrote:
>
> On 5/5/20 2:49 AM, Peter Maydell wrote:
> > On Mon, 4 May 2020 at 17:03, Richard Henderson
> > wrote:
> >>
> >> On 5/4/20 2:43 AM, Peter Maydell wrote:
> >>> I've reviewed patch 13, but I still don't understand why you've
> >>> made the
On 5/4/20 5:44 PM, Kirti Wankhede wrote:
Added amount of bytes transferred to the target VM by all VFIO devices
Signed-off-by: Kirti Wankhede
---
Reviewing just the UI:
+++ b/qapi/migration.json
@@ -144,6 +144,18 @@
'active', 'postcopy-active', 'postcopy-paused',
On Tue, 5 May 2020 15:42:55 +0200
Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
> ---
> hw/i386/acpi-common.h | 3 ++-
> hw/i386/acpi-build.c | 2 +-
> hw/i386/acpi-common.c | 26 +++---
> 3 files changed, 18 insertions(+), 13
On Tue, May 05, 2020 at 03:42:52PM +0200, Gerd Hoffmann wrote:
> I know that not supporting ACPI in microvm is intentional. If you still
> don't want ACPI this is perfectly fine, you can use the usual -no-acpi
> switch to toggle ACPI support.
>
> These are the advantages you are going to loose
On Tue, 5 May 2020 15:42:54 +0200
Gerd Hoffmann wrote:
maybe add here that's it's going to be reused by microvm, hence the movement
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
> ---
> hw/i386/acpi-common.h | 14
> hw/i386/acpi-build.c | 126
On 5/5/20 3:38 AM, Peter Maydell wrote:
> This doesn't apply on master any more as a result of the
> first lump of decodetree stuff going in. Also patch 2
> doesn't seem to compile:
>
> /home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/translate.c: In
> function ‘gen_gvec_srshr’:
>
On 5/5/20 2:49 AM, Peter Maydell wrote:
> On Mon, 4 May 2020 at 17:03, Richard Henderson
> wrote:
>>
>> On 5/4/20 2:43 AM, Peter Maydell wrote:
>>> I've reviewed patch 13, but I still don't understand why you've
>>> made the size-related changes in patch 4, so I've continued
>>> our conversation
On 5/5/20 1:46 AM, Kevin Wolf wrote:
055 uses the backup block job to create a compressed backup of an
$IMGFMT image with both qcow2 and vmdk targets. However, cluster
allocation in vmdk is very slow because it flushes the image file after
each L2 update.
There is no reason why we need this
> -Original Message-
> From: Markus Armbruster
> Sent: 05 May 2020 11:19
> To: qemu-devel@nongnu.org
> Cc: Stefano Stabellini ; Anthony Perard
> ; Paul
> Durrant ; Gerd Hoffmann ;
> xen-de...@lists.xenproject.org
> Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add
>
Add some basic info how to use 3270 devices.
Signed-off-by: Cornelia Huck
---
docs/system/s390x/3270.rst | 32
docs/system/target-s390x.rst | 1 +
2 files changed, 33 insertions(+)
create mode 100644 docs/system/s390x/3270.rst
diff --git
The documentation for the s390x system emulation target still has quite
a bit of room for improvement, so I started adding some device documentation.
I'm not quite happy with the long command/output lines in the 3270 and
vfio-ccw sections, but don't know how to make that more readable.
On 5/5/20 3:31 PM, Daniel P. Berrangé wrote:
On Tue, May 05, 2020 at 03:15:18PM +0200, Philippe Mathieu-Daudé wrote:
+Alex & Daniel who keep track on CI stuff.
On 4/29/20 9:44 PM, Daniele Buono wrote:
LLVM supports SafeStack instrumentation to protect against stack buffer
overflows, since
On 5/5/20 1:38 PM, Gerd Hoffmann wrote:
The code uses the isa_serial_io array to figure what the device uid is.
Side effect is that acpi antries are not limited to port 1+2 any more,
we'll also get entries for ports 3+4.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
On Tue, 5 May 2020 15:42:53 +0200
Gerd Hoffmann wrote:
> Remove PCMachineState dependency from build_madt().
> Pass AcpiDeviceIf as separate argument instead of
> depending on PCMachineState->acpi_dev.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor
Hi Gerd,
On 5/5/20 3:42 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-common.h | 19 +++
hw/i386/acpi-build.c | 18 --
2 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/hw/i386/acpi-common.h b/hw/i386/acpi-common.h
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-common.h | 5 -
hw/i386/acpi-build.c | 43 +--
hw/i386/acpi-common.c | 43 +++
3 files changed, 48 insertions(+), 43 deletions(-)
diff --git
Add some hints about "devno" rules.
Signed-off-by: Cornelia Huck
---
docs/system/s390x/css.rst| 64
docs/system/target-s390x.rst | 1 +
2 files changed, 65 insertions(+)
create mode 100644 docs/system/s390x/css.rst
diff --git
Add a basic example for passing a dasd via vfio-ccw.
Signed-off-by: Cornelia Huck
---
docs/system/s390x/vfio-ccw.rst | 58 ++
docs/system/target-s390x.rst | 1 +
2 files changed, 59 insertions(+)
create mode 100644 docs/system/s390x/vfio-ccw.rst
diff --git
On 5/5/20 3:42 PM, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-common.h | 1 +
hw/i386/acpi-build.c | 11 +--
hw/i386/acpi-common.c | 7 +++
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git
... in case we are using ACPI.
Signed-off-by: Gerd Hoffmann
---
hw/i386/microvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index 6ba2d9d3f028..a3708fdf1e39 100644
--- a/hw/i386/microvm.c
+++ b/hw/i386/microvm.c
@@ -369,7 +369,8
Uses TYPE_ACPI_GED as QOM parent for code reuse.
Add registers for sleep states and reset.
Add powerdown notifier for power button events.
Set AcpiDeviceIfClass->madt_cpu.
Signed-off-by: Gerd Hoffmann
---
include/hw/acpi/generic_event_device.h | 10 +++
hw/i386/generic_event_device_x86.c |
Makes x86 linux kernel find virtio-mmio devices automatically.
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-microvm.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c
index ce5ab86d642c..4d91ac9360ce
Signed-off-by: Gerd Hoffmann
---
include/hw/i386/microvm.h | 2 +-
hw/i386/acpi-microvm.c| 6 +++---
hw/i386/microvm.c | 11 +++
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h
index
$subject says all. Can be disabled using the usual -no-acpi switch.
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-microvm.h| 6 ++
include/hw/i386/microvm.h | 8 ++
hw/i386/acpi-microvm.c| 198 ++
hw/i386/microvm.c | 22 +
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-common.h | 3 ++-
hw/i386/acpi-build.c | 2 +-
hw/i386/acpi-common.c | 26 +++---
3 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/hw/i386/acpi-common.h b/hw/i386/acpi-common.h
index c30e461f1854..9cac18dddf5b
With ACPI enabled and IO-APIC being properly declared in the ACPI tables
we can use interrupt lines 16-23 for virtio and avoid shared interrupts.
With acpi disabled we continue to use lines 8-15.
Signed-off-by: Gerd Hoffmann
---
hw/i386/microvm.c | 2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-common.h | 1 +
hw/i386/acpi-build.c | 11 +--
hw/i386/acpi-common.c | 7 +++
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-common.h b/hw/i386/acpi-common.h
index 9cac18dddf5b..583c320bbe7d 100644
---
I know that not supporting ACPI in microvm is intentional. If you still
don't want ACPI this is perfectly fine, you can use the usual -no-acpi
switch to toggle ACPI support.
These are the advantages you are going to loose then:
(1) virtio-mmio device discovery without command line hacks
101 - 200 of 385 matches
Mail list logo
