On Jul 30 00:29, Minwoo Im wrote:
> Klaus,
>
Hi Minwoo,
Thanks for the reviews and welcome to the party! :)
> On 20-07-20 13:37:36, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Remove the has_sg member from NvmeRequest since it's redundant.
> >
> > Also, make sure the request iov is
* Alex Williamson (alex.william...@redhat.com) wrote:
> On Mon, 27 Jul 2020 15:24:40 +0800
> Yan Zhao wrote:
>
> > > > As you indicate, the vendor driver is responsible for checking version
> > > > information embedded within the migration stream. Therefore a
> > > > migration should fail early
On Wed, 29 Jul 2020 at 21:29, Paolo Bonzini wrote:
> I was not referring to github pull requests, but rather to a maintainer
> pull request. This is also sent to the mailing list. There is no
> QEMU-specific documentation since maintainers are generally experienced
> enough to have observed how
Resending series recently posted on mailing list related to nvme device
extension with couple of fixes after review.
This patch series does following:
- Fixes problem where CMBS bit was not set in controller capabilities
register, so support for CMB was not correctly advertised to guest.
On 29/07/20 09:39, Markus Armbruster wrote:
> Taking a step back, I disagree with the notion that assertions should be
> avoided just because we have an Error **. A programming error doesn't
> become less wrong, and continuing when the program is in disorder
> doesn't become any safer when you
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Tue, Jul 28, 2020 at 11:27:09AM +0800, Hogan Wang wrote:
> > The i440fx and q35 machines integrate i440FX or MCH PCI device by default.
> > Refer to i440FX and ICH9-LPC spcifications, there are some reserved
> > configuration registers can used to
On Jul 30 01:00, Minwoo Im wrote:
> On 20-07-20 13:37:42, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add 'mdts' device parameter to control the Maximum Data Transfer Size of
> > the controller and check that it is respected.
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Maxim
On Jul 30 01:10, Minwoo Im wrote:
> On 20-07-20 13:37:47, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Keep a copy of the raw nvme command in the NvmeRequest and remove the
> > now redundant NvmeCmd parameter.
> >
> > Signed-off-by: Klaus Jensen
>
> I would really have suggested this
Map signal numbers in fcntl F_SETSIG and F_GETSIG.
Signed-off-by: Timothy E Baldwin
---
linux-user/syscall.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 945fc25279..8456bad109 100644
--- a/linux-user/syscall.c
On Jul 27 11:59, Andrzej Jakowski wrote:
> On 7/27/20 2:06 AM, Klaus Jensen wrote:
> > On Jul 23 09:03, Andrzej Jakowski wrote:
> >> So far it was not possible to have CMB and PMR emulated on the same
> >> device, because BAR2 was used exclusively either of PMR or CMB. This
> >> patch places CMB
On 7/29/20 3:05 PM, Sunil Muthuswamy wrote:
Adding Peter Maydell as well.
-Original Message-
From: Sunil Muthuswamy
Sent: Tuesday, July 28, 2020 12:20 PM
To: Paolo Bonzini
Cc: qemu-devel@nongnu.org
Subject: qemu repo lockdown message for a WHPX PR
Hey Paolo,
Following your
So far it was not possible to have CMB and PMR emulated on the same
device, because BAR2 was used exclusively either of PMR or CMB. This
patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors.
Signed-off-by: Andrzej Jakowski
---
hw/block/nvme.c | 124
This patch sets CMBS bit in controller capabilities register when user
configures NVMe driver with CMB support, so capabilites are correctly
reported to guest OS.
Signed-off-by: Andrzej Jakowski
Reviewed-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 1 +
On Jul 29 15:01, Andrzej Jakowski wrote:
> So far it was not possible to have CMB and PMR emulated on the same
> device, because BAR2 was used exclusively either of PMR or CMB. This
> patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors.
>
> Signed-off-by: Andrzej Jakowski
>
On Jul 29 16:57, Maxim Levitsky wrote:
> On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
> > use them in nvme_map_prp.
> >
> > This fixes a bug where in the case of a CMB transfer, the
On Wed, 2020-07-29 at 13:44 +0200, Klaus Jensen wrote:
> On Jul 29 13:24, Maxim Levitsky wrote:
> > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Add support for the Get Log Page command and basic implementations of
> > > the mandatory Error
On Jul 29 20:35, Maxim Levitsky wrote:
> On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Refactor the nvme_dma_{read,write}_prp functions into a common function
> > taking a DMADirection parameter.
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Maxim
On Jul 29 21:31, Maxim Levitsky wrote:
> On Thu, 2020-07-30 at 00:52 +0900, Minwoo Im wrote:
> > Klaus,
> >
> > On 20-07-20 13:37:39, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Introduce the nvme_map helper to remove some noise in the main nvme_rw
> > > function.
> > >
> > >
On 7/22/20 2:15 AM, frank.ch...@sifive.com wrote:
> +static void
> +vext_ldst_whole(void *vd, target_ulong base, CPURISCVState *env, uint32_t
> desc,
> +vext_ldst_elem_fn *ldst_elem, uint32_t esz, uintptr_t ra,
> +MMUAccessType access_type)
> +{
> +uint32_t i,
```
(gdb) thread apply all bt
Thread 5 (LWP 211759):
#0 0x7ff56a9988d8 in g_str_hash ()
#1 0x7ff56a997a0c in g_hash_table_lookup ()
#2 0x7ff56a6c528f in type_table_lookup (name=0x7ff56ac9a9dd "virtio-bus")
at qom/object.c:84
#3 type_get_by_name (name=0x7ff56ac9a9dd "virtio-bus")
On 7/20/20 4:37 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
> use them in nvme_map_prp.
>
> This fixes a bug where in the case of a CMB transfer, the device would
> map to the buffer with a wrong length.
>
> Fixes:
On Jul 29 13:40, Andrzej Jakowski wrote:
> On 7/20/20 4:37 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
> > use them in nvme_map_prp.
> >
> > This fixes a bug where in the case of a CMB transfer, the device would
>
On Jul 29 14:51, Andrzej Jakowski wrote:
> On 7/29/20 2:24 PM, Klaus Jensen wrote:
> > On Jul 29 13:40, Andrzej Jakowski wrote:
> >> On 7/20/20 4:37 AM, Klaus Jensen wrote:
> >>> From: Klaus Jensen
> >>>
> >>> Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
> >>> use them in
pci_dma_rw currently always returns 0, regardless
of the result of dma_memory_rw. Adjusted to return
the correct value.
Signed-off-by: Emanuele Giuseppe Esposito
---
include/hw/pci/pci.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h
On Thu, 16 Jul 2020 08:31:43 -0700
Thanos Makatos wrote:
> This patch introduces the VFIO-over-socket protocol specification, which
> is designed to allow devices to be emulated outside QEMU, in a separate
> process. VFIO-over-socket reuses the existing VFIO defines, structs and
> concepts.
>
>
On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Always destroy the request qsg/iov at the end of request use.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 48 +---
> 1 file changed, 17 insertions(+), 31
On 7/27/20 11:46 PM, Helge Deller wrote:
> The hppa_hardware.h file is shared with SeaBIOS. Sync it.
>
> Signed-off-by: Helge Deller
> ---
> hw/hppa/hppa_hardware.h | 6 ++
> hw/hppa/lasi.c | 2 --
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git
The various schemas included in QEMU use a JSON-based format which
is, however, strictly speaking not valid JSON.
As a consequence, when vim tries to apply syntax highlight rules
for JSON (as guessed from the file name), the result is an unreadable
mess which mostly consist of red markers
On Jul 29 20:47, Maxim Levitsky wrote:
> On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Move clearing of the structure from "clear before use" to "clear
> > after use".
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/block/nvme.c | 7 ++-
> > 1
Adding Peter Maydell as well.
> -Original Message-
> From: Sunil Muthuswamy
> Sent: Tuesday, July 28, 2020 12:20 PM
> To: Paolo Bonzini
> Cc: qemu-devel@nongnu.org
> Subject: qemu repo lockdown message for a WHPX PR
>
> Hey Paolo,
>
> Following your suggestion of creating PRs for WHPX
Here's what I get with 5.1.0-rc2
```
(gdb) thread apply all bt
Thread 5 (LWP 23730):
#0 0x7f9ae6040ebb in ioctl ()
#1 0x7f9ae57cf98b in kvm_vcpu_ioctl (cpu=cpu@entry=0x57539ea0,
type=type@entry=44672) at /root/qemu/accel/kvm/kvm-all.c:2631
#2 0x7f9ae57cfac5 in kvm_cpu_exec
Igor,
Sorry. Few more questions.
> -Original Message-
> From: Igor Mammedov
> Sent: Wednesday, July 29, 2020 9:12 AM
> To: Moger, Babu
> Cc: pbonz...@redhat.com; r...@twiddle.net; qemu-devel@nongnu.org;
> ehabk...@redhat.com
> Subject: Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids
From: Klaus Jensen
Instead of passing around the NvmeNamespace and the NvmeCmd, add them as
members in the NvmeRequest structure.
Signed-off-by: Klaus Jensen
Reviewed-by: Minwoo Im
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 187 ++--
Right now we create lock/pid file in /usr/local/var/... and unprivliged
user does not have access to create files there.
So create this file in per user cache dir as queried as specified
by environment variable XDG_RUNTIME_DIR.
Note: "su $USER" does not update XDG_RUNTIME_DIR and it still points
From: Klaus Jensen
Since nvme_map_prp always operate on the request-scoped qsg/iovs, just
pass a single pointer to the NvmeRequest instead of two for each of the
qsg and iov.
Suggested-by: Minwoo Im
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 11 +++
1 file changed, 7
From: Klaus Jensen
Make sure the request iov is destroyed before reuse; fixing a memory
leak.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index a9d9a2912655..8f8257e06eed 100644
--- a/hw/block/nvme.c
From: Klaus Jensen
Refactor the nvme_dma_{read,write}_prp functions into a common function
taking a DMADirection parameter.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
Reviewed-by: Minwoo Im
---
hw/block/nvme.c | 91 +
1 file
On Wed, 29 Jul 2020 12:28:46 +0100
Sean Mooney wrote:
> On Wed, 2020-07-29 at 16:05 +0800, Yan Zhao wrote:
> > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote:
> > > On Mon, 27 Jul 2020 15:24:40 +0800
> > > Yan Zhao wrote:
> > >
> > > > > > As you indicate, the vendor
The --disable-git-update configure param sets git_update=no, but
some later checks only look for the .git dir. This changes the
--enable-git-update to set git_update=yes but also fail if it
does not find a .git dir. Then all the later checks for the .git
dir can just be changed to a check for
On Jul 30 01:15, Minwoo Im wrote:
> On 20-07-20 13:37:48, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Since clean up of the request qsg/iov is now always done post-use, there
> > is no need to use a stack-allocated qsg/iov in nvme_dma_prp.
> >
> > Signed-off-by: Klaus Jensen
> >
From: Klaus Jensen
Before this patch the device already supported PRP lists in the CMB, but
it did not check for the validity of it nor announced the support in the
Identify Controller data structure LISTS field.
If some of the PRPs in a PRP list are in the CMB, then ALL entries must
be there.
From: Klaus Jensen
Always destroy the request qsg/iov at the end of request use.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 52 -
1 file changed, 21 insertions(+), 31 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index
From: Klaus Jensen
Remove the has_sg member from NvmeRequest since it's redundant.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 7 ++-
hw/block/nvme.h | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index
From: Klaus Jensen
Add 'mdts' device parameter to control the Maximum Data Transfer Size of
the controller and check that it is respected.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
Reviewed-by: Minwoo Im
---
hw/block/nvme.c | 30 +-
On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Keep a copy of the raw nvme command in the NvmeRequest and remove the
> now redundant NvmeCmd parameter.
Shouldn't you clear the req->cmd in nvme_req_clear too for consistency?
Other than that looks OK, but I might
On Wed, 2020-07-29 at 15:48 +0200, Klaus Jensen wrote:
> On Jul 29 16:17, Maxim Levitsky wrote:
> > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Since the device does not have any persistent state storage, no
> > > features are "saveable" and
On Jul 29 21:45, Maxim Levitsky wrote:
> On Wed, 2020-07-29 at 15:37 +0200, Klaus Jensen wrote:
> > On Jul 29 13:43, Maxim Levitsky wrote:
> > > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > > +DEFINE_PROP_UINT8("aerl", NvmeCtrl, params.aerl, 3),
> > > So this is number of AERs
On 28/07/20 21:19, Sunil Muthuswamy wrote:
> Hey Paolo,
>
> Following your suggestion of creating PRs for WHPX changes, I tried creating
> a PR https://github.com/qemu/qemu/pull/95
>
> But, I am getting repo-lockdown message. What do I need to do differently?
Hi,
I was not referring to github
From: Klaus Jensen
The QSG isn't always initialized, so accounting could be wrong. Issue a
call to blk_acct_start instead with the size taken from the QSG or IOV
depending on the kind of I/O.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
Reviewed-by: Minwoo Im
---
hw/block/nvme.c
From: Klaus Jensen
Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
use them in nvme_map_prp.
This fixes a bug where in the case of a CMB transfer, the device would
map to the buffer with a wrong length.
Fixes: b2b2b67a00574 ("nvme: Add support for Read Data and Write Data
From: Klaus Jensen
This is preparatory to subsequent patches that change how QSGs/IOVs are
handled. It is important that the qsg and iov members of the NvmeRequest
are initially zeroed.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 2 +-
1 file changed, 1
From: Klaus Jensen
Introduce the nvme_map helper to remove some noise in the main nvme_rw
function.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
On Thu, 2020-07-30 at 00:52 +0900, Minwoo Im wrote:
> Klaus,
>
> On 20-07-20 13:37:39, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Introduce the nvme_map helper to remove some noise in the main nvme_rw
> > function.
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Maxim Levitsky
>
On Wed, 2020-07-29 at 15:37 +0200, Klaus Jensen wrote:
> On Jul 29 13:43, Maxim Levitsky wrote:
> > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Add support for the Asynchronous Event Request command. Required for
> > > compliance with NVMe revision
On 7/29/20 2:10 PM, Peter Maydell wrote:
In commit 176d2cda0dee9f4 we added the @die-id field
to the CpuInstanceProperties struct, but in the process
accidentally removed the newline between the doc-comment
lines for @core-id and @thread-id.
Put the newline back in; this fixes a misformatting
On Wed, 2020-07-15 at 18:01 +0300, Maxim Levitsky wrote:
> Hi!
>
> This is a patch series that is a result of my discussion with Paulo on
> how to correctly fix the root cause of the BZ #1812399.
>
> The root cause of this bug is the fact that IO thread is running mostly
> unlocked versus main
From: Klaus Jensen
Since clean up of the request qsg/iov is now always done post-use, there
is no need to use a stack-allocated qsg/iov in nvme_dma_prp.
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 41
From: Klaus Jensen
Hoist bounds checking into its own function and check for wrap-around.
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
Reviewed-by: Minwoo Im
---
hw/block/nvme.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git
From: Klaus Jensen
Add tracing to nvme_map_prp.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 2 ++
hw/block/trace-events | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 571635ebe9f9..952afbb05175 100644
--- a/hw/block/nvme.c
+++
From: Klaus Jensen
This series consists of patches that refactors dma read/write and adds a
number of address mapping helper functions.
v2:
* hw/block/nvme: add mapping helpers
- Add an assert in case of out of bounds array access. (Maxim)
* hw/block/nvme: remove redundant has_sg
In commit 176d2cda0dee9f4 we added the @die-id field
to the CpuInstanceProperties struct, but in the process
accidentally removed the newline between the doc-comment
lines for @core-id and @thread-id.
Put the newline back in; this fixes a misformatting in the
generated HTML QMP reference manual.
On 7/29/20 9:10 PM, Peter Maydell wrote:
> In commit 176d2cda0dee9f4 we added the @die-id field
> to the CpuInstanceProperties struct, but in the process
> accidentally removed the newline between the doc-comment
> lines for @core-id and @thread-id.
>
> Put the newline back in; this fixes a
On Jul 29 21:25, Maxim Levitsky wrote:
> On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Keep a copy of the raw nvme command in the NvmeRequest and remove the
> > now redundant NvmeCmd parameter.
>
> Shouldn't you clear the req->cmd in nvme_req_clear too
No, I am trying to submit a pull request as suggested by Paolo in this post:
https://patchwork.ozlabs.org/project/qemu-devel/patch/sn4pr2101mb08804d23439166e81ff151f7c0...@sn4pr2101mb0880.namprd21.prod.outlook.com/#2373829
> -Original Message-
> From: Eric Blake
> Sent: Wednesday, July
On 7/29/20 2:24 PM, Klaus Jensen wrote:
> On Jul 29 13:40, Andrzej Jakowski wrote:
>> On 7/20/20 4:37 AM, Klaus Jensen wrote:
>>> From: Klaus Jensen
>>>
>>> Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and
>>> use them in nvme_map_prp.
>>>
>>> This fixes a bug where in the
We need /proc/self/fd descriptor even in sandbox=NONE mode.
Signed-off-by: Vivek Goyal
---
tools/virtiofsd/passthrough_ll.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index
While running as unpriviliged user setup_capabilities() fails for me.
So we are doing some operation which requires priviliges. For now
simply skip it in sandbox=NONE mode.
Signed-off-by: Vivek Goyal
---
tools/virtiofsd/passthrough_ll.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
In sandbox=NONE mode, lo->source points to the directory which is being
exported. We have not done any chroot()/pivot_root(). So open lo->source.
Signed-off-by: Vivek Goyal
---
tools/virtiofsd/passthrough_ll.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
At startup if we are running as non-root user, then internall set
unpriviliged mode set. Also add a notion of sandbox NONE and set
that internally in unprivileged mode. setting up namespaces and
chroot() fails when one does not have privileges.
Signed-off-by: Vivek Goyal
---
From: Klaus Jensen
The NVM Express specification generally uses 'zeroes' and not 'zeros',
so let us align with it.
Cc: Fam Zheng
Signed-off-by: Klaus Jensen
Reviewed-by: Minwoo Im
Reviewed-by: Maxim Levitsky
---
block/nvme.c | 4 ++--
hw/block/nvme.c | 8
Hi,
Daniel Berrange mentioned that having a unpriviliged mode in virtiofsd
might be useful for certain use cases. Hence I decided to give it
a try.
This is RFC patch series to allow running virtiofsd as unpriviliged
user. This is still work in progress. I am posting it to get
some early
On Jul 29 21:18, Maxim Levitsky wrote:
> On Mon, 2020-07-20 at 13:37 +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Always destroy the request qsg/iov at the end of request use.
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/block/nvme.c | 48
On Jul 30 00:49, Minwoo Im wrote:
> Klaus,
>
> On 20-07-20 13:37:38, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Pass along the NvmeRequest in various functions since it is very useful
> > for tracing.
>
> One doubt here.
> This patch has put NvmeRequest argument to the nvme_map_prp()
On Wed, Jul 29, 2020 at 01:12:55PM -0600, Alex Williamson wrote:
> On Wed, 29 Jul 2020 12:28:46 +0100
> Sean Mooney wrote:
>
> > On Wed, 2020-07-29 at 16:05 +0800, Yan Zhao wrote:
> > > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote:
> > > > On Mon, 27 Jul 2020 15:24:40 +0800
Thanks for the information.
It could be fixed by this commit upstream.
a48aaf882b100b30111b5c7c75e1d9e83fe76cfd ("virtio-pci: fix wrong index in
virtio_pci_queue_enabled")
Please try.
Thanks
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
> At the end of live migration, QEMU uses msync() to flush the data to
> the backend storage. When the backend file is a character device dax,
> the pages explicitly avoid the page cache. It will return failure from
> msync().
> The following warning is output.
>
> "warning: qemu_ram_msync:
> On Tue, Jul 28, 2020 at 11:27:09AM +0800, Hogan Wang wrote:
> > The i440fx and q35 machines integrate i440FX or MCH PCI device by default.
> > Refer to i440FX and ICH9-LPC spcifications, there are some reserved
> > configuration registers can used to save/restore PCIHostState.config_reg.
> >
How about something like:
"A new feature, VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS, has been
added to the vhost-user protocol which, when negotiated, changes the
way QEMU transmit memory regions to backend devices. Instead of
sending all regions in a single VHOST_USER_SET_MEM_TABLE message, QEMU
On 29/07/2020 13.42, Viktor Mihajlovski wrote:
>
>
> On 7/28/20 8:37 PM, Thomas Huth wrote:
>> If the user did not specify a "bootindex" property, the s390-ccw bios
>> tries to find a bootable device on its own. Unfortunately, it alwasy
>> stops at the very first device that it can find, no
> -Original Message-
> From: Qemu-devel On
> Behalf Of Klaus Jensen
> Sent: Thursday, July 30, 2020 3:29 AM
> To: Minwoo Im
> Cc: Kevin Wolf ; qemu-bl...@nongnu.org; Klaus Jensen
> ; qemu-devel@nongnu.org; Max Reitz ;
> Keith Busch
> Subject: Re: [PATCH 04/16] hw/block/nvme: remove
This likely affects other, less popular host architectures as well.
Less common host architectures under linux get QEMU_VMALLOC_ALIGN (from
which VIRTIO_MEM_MIN_BLOCK_SIZE is derived) define to a variable of
type uintptr, which isn't compatible with the format specifier used to
print a user
On Wed, Jul 29, 2020 at 12:28:46PM +0100, Sean Mooney wrote:
> On Wed, 2020-07-29 at 16:05 +0800, Yan Zhao wrote:
> > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote:
> > > On Mon, 27 Jul 2020 15:24:40 +0800
> > > Yan Zhao wrote:
> > >
> > > > > > As you indicate, the vendor
Hi. This is my first time trying to contribute to qemu. This patch
works correctly for architectures with the same bit-width, for example
32bit arm host and i386 user binary. Here is an example with the sg_simple2
executable from https://github.com/hreinecke/sg3_utils
32-bit ARM native:
strace
This patch implements functionalities of following ioctls:
SG_GET_VERSION_NUM - Returns SG driver version number
The sg version numbers are of the form "x.y.z" and the single number given
by the SG_GET_VERSION_NUM ioctl() is calculated by
(x * 1 + y * 100 + z).
SG_IO - Permits
At the end of live migration, QEMU uses msync() to flush the data to
the backend storage. When the backend file is a character device dax,
the pages explicitly avoid the page cache. It will return failure from msync().
The following warning is output.
"warning: qemu_ram_msync: failed to sync
Thanos is on vacation. My comments embedded.
JJ
> On Jul 29, 2020, at 5:48 AM, Stefan Hajnoczi wrote:
>
> On Wed, Jul 22, 2020 at 11:42:26AM +, Thanos Makatos wrote:
diff --git a/docs/devel/vfio-over-socket.rst
On Wed, Jul 29, 2020 at 09:57:56AM -0300, Daniel Henrique Barboza wrote:
> This patch adds a new documentation file, ppc-spapr-numa.rst,
> informing what developers and user can expect of the NUMA distance
> support for the pseries machine, up to QEMU 5.1.
>
> In the (hopefully soon) future, when
On Tue, Jul 28, 2020 at 09:56:36PM -0300, Thiago Jung Bauermann wrote:
>
> Thiago Jung Bauermann writes:
>
> > The ARM code has a start-powered-off property in ARMCPU, which is a
> > subclass of CPUState. This property causes arm_cpu_reset() to set
> > CPUState::halted to 1, signalling that the
The i440fx and q35 machines integrate i440FX or MCH PCI device by default.
Refer to i440FX and ICH9-LPC spcifications, there are some reserved
configuration registers can used to save/restore PCIHostState.config_reg.
It's nasty but friendly to old ones.
Reproducer steps:
step 1. Make
When I compile qemu with such as:
git clone https://git.qemu.org/git/qemu.git
cd qemu
git submodule init
git submodule update --recursive
./configure
make
There is error log:
/home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
When I compile qemu with such as:
git clone https://git.qemu.org/git/qemu.git
cd qemu
git submodule init
git submodule update --recursive
./configure
make
There is error log:
/home/LiKaige/qemu/hw/virtio/virtio-mem.c: In function
‘virtio_mem_set_block_size’:
Paolo Bonzini writes:
> On 28/07/20 09:44, Markus Armbruster wrote:
>>> -assert(!DEVICE_GET_CLASS(dev)->bus_type);
>>> +} else if (DEVICE_GET_CLASS(dev)->bus_type) {
>>> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'",
>>> +
On 28.07.20 11:46, Cornelia Huck wrote:
> Add 5.2 machine types for arm/i440fx/q35/s390x/spapr.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/arm/virt.c | 9 -
> hw/core/machine.c | 3 +++
> hw/i386/pc.c | 3 +++
> hw/i386/pc_piix.c | 14
On Tue, Jul 28, 2020 at 03:29:34PM +0200, Greg Kurz wrote:
> We have a dedicated error API for hints. Use it instead of embedding
> the hint in the error message, as recommanded in the "qapi/error.h"
> header file.
>
> While here, have cap_fwnmi_apply(), which already uses
> error_append_hint(),
Hi
On Wed, Jul 29, 2020 at 7:16 AM Raphael Norwitz
wrote:
>
> Hi mst,
>
> Looking at the current changelog
> https://wiki.qemu.org/ChangeLog/5.1#virtio, I don't see any mention of
> the VHOST_USER_PROTOCOL_F_CONFIG_MEM_SLOTS protocol feature. It is a
> user visible change so shouldn't we add a
Paolo Bonzini writes:
> On 28/07/20 09:19, Markus Armbruster wrote:
>>> the composition tree generally mirrors things that are born and die
>>> at the same time, and creating children is generally reserved to the
>>> object itself.
>>
>> Yes. Notable exceptions: containers /machine/peripheral,
On Tue, Jul 28, 2020 at 3:13 PM Vivek Goyal wrote:
> On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote:
> > On Tue, Jul 28, 2020 at 3:07 AM misono.tomoh...@fujitsu.com <
> > misono.tomoh...@fujitsu.com> wrote:
> >
> > > > Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix a missing cpu_to conversion by moving conversion to just before
> returning instead.
>
> Signed-off-by: Klaus Jensen
> Suggested-by: Philippe Mathieu-Daudé
> ---
> hw/block/nvme.c | 6 +++---
> 1 file
On Tue, Jul 28, 2020 at 09:50:39AM -0500, Eric Blake wrote:
> On 7/28/20 9:32 AM, Kashyap Chamarthy wrote:
[...]
> > [1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html
> > -- equivalent to "-drive if=ide,id=disk0."
> >
> > Signed-off-by: Kashyap Chamarthy
> >
On Wed, 29 Jul 2020 10:57:58 +0200
David Hildenbrand wrote:
> On 28.07.20 09:10, Cornelia Huck wrote:
> > However, I think we really need a central place for definitions that
> > are not just a Linux/QEMU interface, but can potentially also be used
> > by other hypervisors/guests. Nothing as
1 - 100 of 248 matches
Mail list logo
