Re: [PATCH 2/2] nbd: disable signals and forking on Windows builds

2020-08-24 Thread Thomas Huth
On 24/08/2020 19.02, Daniel P. Berrangé wrote: Disabling these parts are sufficient to get the qemu-nbd program compiling in a Windows build. Maybe add: "This also enables compilation of qemu-nbd on macOS again (which got disabled by accident during the conversion to the meson build system)"

Re: [PATCH] configure: default to PIE disabled on Windows platforms

2020-08-24 Thread Thomas Huth
On 24/08/2020 18.31, Daniel P. Berrangé wrote: If Windows EXE files are built with -pie/-fpie they will fail to launch. Historically QEMU defaulted to disabling PIE for Windows, but this setting was accidentally lost when the configure summary text was removed in commit

[PATCH] usb: fix setup_len init (CVE-2020-14364)

2020-08-24 Thread Gerd Hoffmann
Store calculated setup_len in a local variable, verify it, and only write it to the struct (USBDevice->setup_len) in case it passed the sanity checks. This prevents other code (do_token_{in,out} functions specifically) from working with invalid USBDevice->setup_len values and overrunning the

Re: [PATCH] usb: fix setup_len init (CVE-2020-14364)

2020-08-24 Thread Li Qiang
Gerd Hoffmann 于2020年8月25日周二 下午1:37写道: > > Store calculated setup_len in a local variable, verify it, and only > write it to the struct (USBDevice->setup_len) in case it passed the > sanity checks. > > This prevents other code (do_token_{in,out} functions specifically) > from working with invalid

Re: [PATCH 6/6] virtio-vga: Use typedef name for instance_size

2020-08-24 Thread Gerd Hoffmann
On Mon, Aug 24, 2020 at 05:59:36PM -0400, Eduardo Habkost wrote: > This makes the code consistent with the rest of QOM code in QEMU, > and will make automated conversion to type declaration macros > simpler. > > Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann

Re: Contributor wanting to get started with simple contributions

2020-08-24 Thread Thomas Huth
On 25/08/2020 04.26, Rohit Shinde wrote: Hey John, I sent this email a couple of weeks ago to the qemu mailing list since I didn't really know who to approach. Hi Rohit, The qemu-devel mailing list is very high traffic. So I'm sorry, but you might need to be a little bit more specific

Re: [PATCH v2 08/21] aspeed/sdhci: Fix reset sequence

2020-08-24 Thread Joel Stanley
On Wed, 19 Aug 2020 at 10:10, Cédric Le Goater wrote: > > BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until > the bit is cleared by HW. > > Use the number of supported slots to define the default value of this > register (The AST2600 eMMC Controller only has one). Fix the

Re: [PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile

2020-08-24 Thread Paolo Bonzini
I think it should just add build_by_default: false with a comment explaining why. Paolo Il lun 24 ago 2020, 07:23 Gerd Hoffmann ha scritto: > > --- a/pc-bios/meson.build > > +++ b/pc-bios/meson.build > > @@ -25,3 +25,4 @@ if 'DECOMPRESS_EDK2_BLOBS' in config_host > > endif > > > >

[PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

2020-08-24 Thread Chuan Zheng
Implement get_sample_page_period() and set_sample_page_period() to sleep specific time between sample actions. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/migration/dirtyrate.c

[PATCH v5 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h

2020-08-24 Thread Chuan Zheng
RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure, move the existing definition up into migration/ram.h Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 1 + migration/ram.c | 11 +-- migration/ram.h | 10 ++ 3 files changed, 12 insertions(+), 10

[PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-24 Thread Chuan Zheng
Compare page hash results for recorded sampled page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index

[PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-24 Thread Chuan Zheng
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be called Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 45 + qapi/migration.json | 44 2 files changed, 89 insertions(+)

[PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-24 Thread Chuan Zheng
Record hash results for each sampled page, crc32 is taken to calculate hash results for each sampled 4K-page. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 136 ++ migration/dirtyrate.h | 15 ++ 2 files

[PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-08-24 Thread Chuan Zheng
Add trace_calls to make it easier to debug Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 7 +++ migration/trace-events | 8 2 files changed, 15 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 08c46d3..3513ef3 100644 ---

[PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-24 Thread Chuan Zheng
Implement calculate_dirtyrate() function. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index

[PATCH v5 00/12] *** A Method for evaluating dirty page rate ***

2020-08-24 Thread Chuan Zheng
v4 -> v5: fix git apply failed due to meson-build add review-by for patches in v3 v3 -> v4: use crc32 to get hash result instead of md5 add DirtyRateStatus to denote calculation status add some trace_calls to make it easier to debug fix some comments accroding to review

[PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

2020-08-24 Thread Thomas Huth
The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. We've got to exclude some build targets here to make sure that the job finishes in time again. The targets that are excluded should not hurt much, since e.g. all the code from i386-softmmu is covered again by x86_64-softmmu.

[PULL 24/27] target/arm: Replace A64 get_fpstatus_ptr() with generic fpstatus_ptr()

2020-08-24 Thread Peter Maydell
We currently have two versions of get_fpstatus_ptr(), which both take an effectively boolean argument: * the one for A64 takes "bool is_f16" to distinguish fp16 from other ops * the one for A32/T32 takes "int neon" to distinguish Neon from other ops This is confusing, and to implement

[PULL 19/27] target/arm: Convert T32 coprocessor insns to decodetree

2020-08-24 Thread Peter Maydell
Convert the T32 coprocessor instructions to decodetree. As with the A32 conversion, this corrects an underdecoding where we did not check that MRRC/MCRR [24:21] were 0b0010 and so treated some kinds of LDC/STC and MRRC/MCRR rather than UNDEFing them. Signed-off-by: Peter Maydell Reviewed-by:

[PULL 25/27] target/arm: Make A32/T32 use new fpstatus_ptr() API

2020-08-24 Thread Peter Maydell
Make A32/T32 code use the new fpstatus_ptr() API: get_fpstatus_ptr(0) -> fpstatus_ptr(FPST_FPCR) get_fpstatus_ptr(1) -> fpstatus_ptr(FPST_STD) Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Message-id: 20200806104453.30393-3-peter.mayd...@linaro.org ---

[PULL 22/27] target/arm/translate.c: Delete/amend incorrect comments

2020-08-24 Thread Peter Maydell
In arm_tr_init_disas_context() we have a FIXME comment that suggests "cpu_M0 can probably be the same as cpu_V0". This isn't in fact possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(), and that function is called in various places where cpu_M0 contains a live value (i.e. between

[RFC v5 0/3] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-24 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line:

[RFC v5 1/3] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-08-24 Thread Eugenio Pérez
Previous name didn't reflect the iommu operation. Signed-off-by: Eugenio Pérez --- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/i386/intel_iommu.c | 4 ++-- include/exec/memory.h | 6 +++--- softmmu/memory.c | 6 +++--- 5 files changed, 10 insertions(+), 10 deletions(-)

[RFC v5 2/3] memory: Skip bad range assertion if notifier is DEVIOTLB type

2020-08-24 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in

[RFC v5 3/3] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-08-24 Thread Eugenio Pérez
This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1374.81Mbit/s to 1845Mbit/s (37%) * TCP_RR: From 6559.36 trans/s to 7916.29/s (21%) * UDP_RR: From 6705.39 trans/s to 8199.39/s (22%) * UDP_STREAM: No change observed (not significant 0.1% improvement) Signed-off-by:

meson: problems building under msys2/mingw-w64 native

2020-08-24 Thread Mark Cave-Ayland
Hi Paolo, Yesterday I updated my msys2/mingw-w64 Windows 10 build environment for QEMU to the latest git to see if I could get the meson build to work, and found a couple of issues: 1) Unable to launch build/ninjatool at the end of configure At the very end of configure after the build

[PATCH v7 4/4] block: apply COR-filter to block-stream jobs

2020-08-24 Thread Andrey Shinkevich
This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the block-stream job, what will reduce the disk overuse. The COR-filter insertion incurs changes in the iotests

Re: [PATCH] meson: drop keymaps symlink

2020-08-24 Thread Klaus Jensen
On Aug 24 09:40, Gerd Hoffmann wrote: > We are building the keymaps by default now. Drop the keymaps symlink > so the generated files are actually written to the build tree not the > source tree. > > Signed-off-by: Gerd Hoffmann > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v2 6/7] tests/qtest/vhost-user-test: add migrate_reconnect test

2020-08-24 Thread Dima Stepanov
Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov --- tests/qtest/vhost-user-test.c | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v2 3/7] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-08-24 Thread Dima Stepanov
For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initialize device, its command

[PULL 03/27] hw/arm/smmu-common: Add IOTLB helpers

2020-08-24 Thread Peter Maydell
From: Eric Auger Add two helpers: one to lookup for a given IOTLB entry and one to insert a new entry. We also move the tracing there. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Message-id: 20200728150815.11446-3-eric.au...@redhat.com Signed-off-by: Peter Maydell ---

[PULL 05/27] hw/arm/smmu: Introduce SMMUTLBEntry for PTW and IOTLB value

2020-08-24 Thread Peter Maydell
From: Eric Auger Introduce a specialized SMMUTLBEntry to store the result of the PTW and cache in the IOTLB. This structure extends the generic IOMMUTLBEntry struct with the level of the entry and the granule size. Those latter will be useful when implementing range invalidation.

[PULL 13/27] docs/system/arm: Document the Xilinx Versal Virt board

2020-08-24 Thread Peter Maydell
From: "Edgar E. Iglesias" Document the Xilinx Versal Virt board. Signed-off-by: Edgar E. Iglesias Message-id: 20200803164749.301971-2-edgar.igles...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/xlnx-versal-virt.rst | 176 +++

[PULL 07/27] hw/arm/smmuv3: Introduce smmuv3_s1_range_inval() helper

2020-08-24 Thread Peter Maydell
From: Eric Auger Let's introduce an helper for S1 IOVA range invalidation. This will be used for NH_VA and NH_VAA commands. It decodes the same fields, trace, calls the UNMAP notifiers and invalidate the corresponding IOTLB entries. At the moment, we do not support 3.2 range invalidation yet.

[PULL 04/27] hw/arm/smmu: Introduce smmu_get_iotlb_key()

2020-08-24 Thread Peter Maydell
From: Eric Auger Introduce the smmu_get_iotlb_key() helper and the SMMU_IOTLB_ASID() macro. Also move smmu_get_iotlb_key and smmu_iotlb_key_hash in the IOTLB related code section. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Message-id: 20200728150815.11446-4-eric.au...@redhat.com

[PULL 02/27] hw/arm/smmu-common: Factorize some code in smmu_ptw_64()

2020-08-24 Thread Peter Maydell
From: Eric Auger Page and block PTE decoding can share some code. Let's first handle table PTE and factorize some code shared by page and block PTEs. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Message-id: 20200728150815.11446-2-eric.au...@redhat.com Signed-off-by: Peter Maydell ---

[PULL v1 8/8] microblaze: petalogix-s3adsp1800: Add device-tree source

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a device-tree source for petalogix-s3adsp1800 and recompile the DTB. This also removes the unused mpmc node which causes compilation warnings. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Signed-off-by: Edgar E. Iglesias ---

[PULL v1 7/8] microblaze: petalogix-ml605: Add device-tree source

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a device-tree source for petalogix-ml605 and recompile the DTB. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- pc-bios/petalogix-ml605.dtb | Bin 9982 -> 9882 bytes pc-bios/petalogix-ml605.dts | 350

[PULL v1 6/8] target/microblaze: mbar: Trap sleeps from user-space

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Trap mbar-sleeps from user-space. Reviewed-by: Richard Henderson Reported-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/microblaze/translate.c

[PATCH] qemu-io-cmds: Simplify help_oneline

2020-08-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" help_oneline is declared and starts as: static void help_oneline(const char *cmd, const cmdinfo_t *ct) { if (cmd) { printf("%s ", cmd); } else { printf("%s ", ct->name); if (ct->altname) { printf("(or %s)

[REPORT] [GSoC - TCG Continuous Benchmarking] [#9] Measuring QEMU Performance in System Mode

2020-08-24 Thread Ahmed Karaman
Greetings, The final report of the TCG Continuous Benchmarking series introduces basic performance measurements for QEMU system mode emulation. The latest version of Debian 15.0 is used for testing and comparing the emulation performance on five targets (aarch64, arm, mips, mipsel, and x86_64).

[PATCH v4 1/6] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-24 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will insert SMI upcall into

[PATCH] usb-host: workaround libusb bug

2020-08-24 Thread Gerd Hoffmann
libusb_get_device_speed() does not work for libusb_wrap_sys_device() devices in v1.0.23. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1871090 Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-)

[PATCH v2] virtiofsd: Add -o allow_direct_io|no_allow_direct_io options

2020-08-24 Thread Jiachen Zhang
Due to the commit 65da4539803373ec4eec97ffc49ee90083e56efd, the O_DIRECT open flag of guest applications will be discarded by virtiofsd. While this behavior makes it consistent with the virtio-9p scheme when guest applications use direct I/O, we no longer have any chance to bypass the host page

Re: [PATCH v7 4/4] block: apply COR-filter to block-stream jobs

2020-08-24 Thread Vladimir Sementsov-Ogievskiy
24.08.2020 11:31, Andrey Shinkevich wrote: This patch completes the series with the COR-filter insertion for block-stream operations. Adding the filter makes it possible for copied regions to be discarded in backing files during the block-stream job, what will reduce the disk overuse. The

Re: [PULL 00/40] ppc-for-5.2 queue 20200818

2020-08-24 Thread Peter Maydell
On Mon, 24 Aug 2020 at 00:21, David Gibson wrote: > > On Sun, Aug 23, 2020 at 02:54:26PM +0100, Peter Maydell wrote: > > Hi -- it looks like you've updated the tag but I haven't seen > > a new cover letter. Do you want me to apply it? > > Um.. I've updated the branch, but the tag should still be

Re: [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page

2020-08-24 Thread Dr. David Alan Gilbert
* Zheng Chuan (zhengch...@huawei.com) wrote: > > > On 2020/8/21 20:39, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >> On Fri, Aug 21, 2020 at 08:22:06PM +0800, Zheng Chuan wrote: > >>> > >>> > >>> On 2020/8/21 1:55, Dr. David Alan Gilbert wrote: > *

[PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-24 Thread Chuan Zheng
add DirtyRateStatus to denote calculating status. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 22 ++ qapi/migration.json | 17 + 2 files changed, 39 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 366f4e9..91987c5

[PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-24 Thread Chuan Zheng
Add dirtyrate statistics to record/update dirtyrate info. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 29 + migration/dirtyrate.h | 10 ++ 2 files changed, 39 insertions(+) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index

[PATCH v5 01/12] migration/dirtyrate: setup up query-dirtyrate framwork

2020-08-24 Thread Chuan Zheng
Add get_dirtyrate_thread() functions to setup query-dirtyrate framework. Signed-off-by: Chuan Zheng Signed-off-by: YanYing Zhuang --- migration/dirtyrate.c | 39 +++ migration/dirtyrate.h | 32 migration/meson.build | 1 + 3

[PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-24 Thread Chuan Zheng
Add RamlockDirtyInfo to store sampled page info of each ramblock. Signed-off-by: Chuan Zheng --- migration/dirtyrate.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h index 33669b7..7da 100644 --- a/migration/dirtyrate.h

[PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-24 Thread Chuan Zheng
In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE which is set as 128M. Signed-off-by: Chuan Zheng --- migration/dirtyrate.c | 24 migration/dirtyrate.h | 10 ++ 2 files changed, 34 insertions(+) diff --git a/migration/dirtyrate.c

Re: [External] Re: [PATCH] virtiofsd: add -o allow_directio|no_directio option

2020-08-24 Thread Daniel P . Berrangé
On Sat, Aug 22, 2020 at 01:51:04AM +0800, 张佳辰 wrote: > On Fri, Aug 21, 2020 at 7:58 PM Daniel P. Berrangé > wrote: > > > On Fri, Aug 21, 2020 at 11:41:26AM +0800, Jiachen Zhang wrote: > > > Due to the commit 65da4539803373ec4eec97ffc49ee90083e56efd, the O_DIRECT > > > open flag of guest

[PULL 17/27] target/arm: Tidy up disas_arm_insn()

2020-08-24 Thread Peter Maydell
The only thing left in the "legacy decoder" is the handling of disas_xscale_insn(), and we can simplify the code. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200803111849.13368-5-peter.mayd...@linaro.org --- target/arm/translate.c | 26 +-

[PULL 14/27] target/arm: Pull handling of XScale insns out of disas_coproc_insn()

2020-08-24 Thread Peter Maydell
At the moment we check for XScale/iwMMXt insns inside disas_coproc_insn(): for CPUs with ARM_FEATURE_XSCALE all copro insns with cp 0 or 1 are handled specially. This works, but is an odd place for this check, because disas_coproc_insn() is called from both the Arm and Thumb decoders but the

[PULL 27/27] target/arm: Use correct FPST for VCMLA, VCADD on fp16

2020-08-24 Thread Peter Maydell
When we implemented the VCMLA and VCADD insns we put in the code to handle fp16, but left it using the standard fp status flags. Correct them to use FPST_STD_F16 for fp16 operations. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Message-id:

[PULL 12/27] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation

2020-08-24 Thread Peter Maydell
From: Eric Auger Expose the RIL bit so that the guest driver uses range invalidation. Although RIL is a 3.2 features, We let the AIDR advertise SMMUv3.1 support as v3.x implementation is allowed to implement features from v3.(x+1). Signed-off-by: Eric Auger Reviewed-by: Peter Maydell

[PULL 09/27] hw/arm/smmuv3: Fix IIDR offset

2020-08-24 Thread Peter Maydell
From: Eric Auger The SMMU IIDR register is at 0x018 offset. Fixes: 10a83cb9887 ("hw/arm/smmuv3: Skeleton") Signed-off-by: Eric Auger Reviewed-by: Peter Maydell Message-id: 20200728150815.11446-9-eric.au...@redhat.com Signed-off-by: Peter Maydell --- hw/arm/smmuv3-internal.h | 2 +- 1 file

[PULL 00/27] target-arm queue

2020-08-24 Thread Peter Maydell
16:34:43 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200824 for you to fetch changes up to b34aa5129e9c3aff890b4f4bcc84962e94185629: target/arm: Use correct FPST for VCMLA, VCADD on fp16 (2020-08-24 10:15:12 +0100

[PULL 01/27] hw/cpu/a9mpcore: Verify the machine use Cortex-A9 cores

2020-08-24 Thread Peter Maydell
From: Philippe Mathieu-Daudé The 'Cortex-A9MPCore internal peripheral' block can only be used with Cortex A5 and A9 cores. As we don't model the A5 yet, simply check the machine cpu core is a Cortex A9. If not return an error. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

[PULL v1 4/8] target/microblaze: swx: Use atomic_cmpxchg

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use atomic_cmpxchg to implement the atomic cmpxchg sequence. Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)

Re: [External] Re: [PATCH] virtiofsd: add -o allow_directio|no_directio option

2020-08-24 Thread Jiachen Zhang
On Mon, Aug 24, 2020 at 5:39 PM Daniel P. Berrangé wrote: > On Sat, Aug 22, 2020 at 01:51:04AM +0800, 张佳辰 wrote: > > On Fri, Aug 21, 2020 at 7:58 PM Daniel P. Berrangé > > wrote: > > > > > On Fri, Aug 21, 2020 at 11:41:26AM +0800, Jiachen Zhang wrote: > > > > Due to the commit

[PULL v1 0/8] Xilinx queue 2020-08-14

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 8367a77c4d3f6e1e60890f5510304feb2c621611: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.2-pull-request' into staging (2020-08-23 16:34:43 +0100) are available in the Git repository at:

[PULL v1 3/8] target/microblaze: mbar: Add support for data-access barriers

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for data-access barriers. Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/microblaze/translate.c

Re: Suspicious QOM types without instance/class size

2020-08-24 Thread Cornelia Huck
On Fri, 21 Aug 2020 17:01:49 -0400 Eduardo Habkost wrote: > On Fri, Aug 21, 2020 at 11:43:35AM +0200, Cornelia Huck wrote: > > On Thu, 20 Aug 2020 17:55:29 -0400 > > Eduardo Habkost wrote: > > > > > While trying to convert TypeInfo declarations to the new > > > OBJECT_DECLARE* macros, I've

Re: ANNOUNCE: build system conversion to Meson has landed

2020-08-24 Thread Laszlo Ersek
On 08/21/20 16:59, Paolo Bonzini wrote: > On 21/08/20 16:50, Laszlo Ersek wrote: >> On 08/21/20 15:49, Peter Maydell wrote: >> >>> https://wiki.qemu.org/Features/Meson/Next has a summary of changes >>> and is worth a quick scan through. >> >> I'd like to propose a wording clarification: >> >> """

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-24 Thread David Gibson
On Fri, Aug 21, 2020 at 09:47:47AM -0300, Daniel Henrique Barboza wrote: > > > On 8/21/20 5:55 AM, Igor Mammedov wrote: > > On Thu, 20 Aug 2020 12:51:03 -0400 > > Eduardo Habkost wrote: > > > > > On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: > > > > On Wed, Aug 19, 2020 at

[PATCH v7 2/4] copy-on-read: add filter append/drop functions

2020-08-24 Thread Andrey Shinkevich
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 104

[PATCH v7 3/4] qapi: add filter-node-name to block-stream

2020-08-24 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c | 4 +++-

Re: [PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-24 Thread Andrey Shinkevich
On 24.08.2020 11:20, Vladimir Sementsov-Ogievskiy wrote: 23.08.2020 22:28, Andrey Shinkevich wrote: On 19.08.2020 13:46, Vladimir Sementsov-Ogievskiy wrote: 19.08.2020 00:24, Andrey Shinkevich wrote: The patch completes the series with the COR-filter insertion to any block-stream operation.

[PULL 08/27] hw/arm/smmuv3: Get prepared for range invalidation

2020-08-24 Thread Peter Maydell
From: Eric Auger Enhance the smmu_iotlb_inv_iova() helper with range invalidation. This uses the new fields passed in the NH_VA and NH_VAA commands: the size of the range, the level and the granule. As NH_VA and NH_VAA both use those fields, their decoding and handling is factorized in a new

[PULL 06/27] hw/arm/smmu-common: Manage IOTLB block entries

2020-08-24 Thread Peter Maydell
From: Eric Auger At the moment each entry in the IOTLB corresponds to a page sized mapping (4K, 16K or 64K), even if the page belongs to a mapped block. In case of block mapping this unefficiently consumes IOTLB entries. Change the value of the entry so that it reflects the actual mapping it

[PULL 15/27] target/arm: Separate decode from handling of coproc insns

2020-08-24 Thread Peter Maydell
As a prelude to making coproc insns use decodetree, split out the part of disas_coproc_insn() which does instruction decoding from the part which does the actual work, and make do_coproc_insn() handle the UNDEF-on-bad-permissions and similar cases itself rather than returning 1 to eventually

[PULL 18/27] target/arm: Do M-profile NOCP checks early and via decodetree

2020-08-24 Thread Peter Maydell
For M-profile CPUs, the architecture specifies that the NOCP exception when a coprocessor is not present or disabled should cover the entire wide range of coprocessor-space encodings, and should take precedence over UNDEF exceptions. (This is the opposite of A-profile, where checking for a

Re: [PATCH V7 for-5.2] hw/mips: Add Loongson-3 machine support (with KVM)

2020-08-24 Thread Huacai Chen
Hi, Aleksandar, On Sat, Aug 22, 2020 at 7:59 PM Aleksandar Markovic wrote: > > > > On Friday, August 7, 2020, Huacai Chen wrote: >> >> Add Loongson-3 based machine support, it use liointc as the interrupt >> controler and use GPEX as the pci controller. Currently it can only work >> with KVM,

Re: [PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-24 Thread Vladimir Sementsov-Ogievskiy
23.08.2020 22:28, Andrey Shinkevich wrote: On 19.08.2020 13:46, Vladimir Sementsov-Ogievskiy wrote: 19.08.2020 00:24, Andrey Shinkevich wrote: The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030. The test case

[PATCH v2 5/7] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-08-24 Thread Dima Stepanov
Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov --- tests/qtest/vhost-user-test.c | 140 +- 1 file changed, 138 insertions(+), 2 deletions(-)

[PATCH v2 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-08-24 Thread Dima Stepanov
vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This error will lead to

[PATCH v2 2/7] vhost: check queue state in the vhost_dev_set_log routine

2020-08-24 Thread Dima Stepanov
If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queue_get_desc_addr()

[PATCH v2 0/7] vhost-user-blk: fix the migration issue and enhance qtests

2020-08-24 Thread Dima Stepanov
v1 -> v2: - add comments to connected/started fields in the header file - move the "s->started" logic from the vhost_user_blk_disconnect routine to the vhost_user_blk_stop routine Reference e-mail threads: - https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg01509.html -

[PULL v1 5/8] configure: microblaze: Enable mttcg

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 67832e3bab..b8f5b81a67 100755 --- a/configure +++ b/configure @@ -7782,6 +7782,7 @@ case "$target_name" in

[PULL v1 1/8] target/microblaze: mbar: Transfer dc->rd to mbar_imm

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Transfer dc->rd to mbar_imm to improve the readability when comparing to the specs. No functional change. Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 6 -- 1 file changed, 4

[PULL v1 2/8] target/microblaze: mbar: Move LOG_DIS to before sleep

2020-08-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Move LOG_DIS log to before sleeping handling so that it logs for sleep instructions aswell. Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PULL 26/27] target/arm: Implement FPST_STD_F16 fpstatus

2020-08-24 Thread Peter Maydell
Architecturally, Neon FP16 operations use the "standard FPSCR" like all other Neon operations. However, this is defined in the Arm ARM pseudocode as "a fixed value, except that FZ16 (and AHP) follow the FPSCR bits". In QEMU, the softfloat float_status doesn't include separate flush-to-zero for

[PULL 23/27] target/arm: Delete unused ARM_FEATURE_CRC

2020-08-24 Thread Peter Maydell
In commit 962fcbf2efe57231a9f5df we converted the uses of the ARM_FEATURE_CRC bit to use the aa32_crc32 isar_feature test instead. However we forgot to remove the now-unused definition of the feature name in the enum. Delete it now. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson

[Bug 1892684] [NEW] curl and wget segfaults when link has redirects

2020-08-24 Thread Roman Melnikov
Public bug reported: Hello, I've been using qemu-user-static with aarch64 docker images and faced the problem using binares from the following release: https://github.com/multiarch/qemu-user-static/releases/tag/v5.0.0-2. curl and wget fails with segmentation fault when trying to fetch

[PATCH] meson: drop keymaps symlink

2020-08-24 Thread Gerd Hoffmann
We are building the keymaps by default now. Drop the keymaps symlink so the generated files are actually written to the build tree not the source tree. Signed-off-by: Gerd Hoffmann --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[PATCH V8 for-5.2] hw/mips: Add Loongson-3 machine support (with KVM)

2020-08-24 Thread Huacai Chen
Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can only work with KVM, but we will add TCG support in future. As the machine model is not based on any exiting physical hardware, the name of the machine is

[PATCH V2 for-5.2] hw/null-machine: Add the kvm_type() hook for MIPS

2020-08-24 Thread Huacai Chen
MIPS has two types of KVM: TE & VZ, and TE is the default type. Now, libvirt uses a null-machine to detect the kvm capability. In the MIPS case, it will return "KVM not supported" on a VZ platform by default. So, add the kvm_type() hook to the null-machine. This seems not a very good solution,

[PATCH v7 0/4] Apply COR-filter to the block-stream permanently

2020-08-24 Thread Andrey Shinkevich
Note: this series is based on the another one "block: Deal with filters" by Max Reitz that could be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu child-access-functions-v6 v7: 01: A complete reversion of

[PATCH v7 1/4] copy-on-read: Support preadv/pwritev_part functions

2020-08-24 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+),

[PATCH v2 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-08-24 Thread Dima Stepanov
Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov --- tests/qtest/libqos/virtio-blk.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH v2 7/7] tests/qtest/vhost-user-test: enable the reconnect tests

2020-08-24 Thread Dima Stepanov
For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off-by: Dima Stepanov

[PATCH] target/riscv: raise exception to HS-mode at get_physical_address

2020-08-24 Thread Yifei Jiang
VS-stage translation at get_physical_address needs to translate pte address by G-stage translation. But the G-stage translation error can not be distinguished from VS-stage translation error in riscv_cpu_tlb_fill. On migration, destination needs to rebuild pte, and this G-stage translation error

Re: [PATCH 2/3] block: add logging facility for long standing IO requests

2020-08-24 Thread Denis V. Lunev
On 8/20/20 11:03 AM, David Edmondson wrote: > On Monday, 2020-08-10 at 13:14:46 +03, Denis V. Lunev wrote: > >> +strftime(buf, sizeof(buf), "%m-%d %H:%M:%S", > "%F %T" would include the year, which can be useful. ok > >> + localtime_r(_time_host_s, )); >> + >> +bs =

meson.build files are missing copyright/license headers

2020-08-24 Thread Peter Maydell
It looks like the new meson.build files are missing the usual copyright-and-license header comment. Could somebody add them, please? scripts/ninjatool.py does have a copyright line but is missing the license statement. thanks -- PMM

[PULL 11/27] hw/arm/smmuv3: Support HAD and advertise SMMUv3.1 support

2020-08-24 Thread Peter Maydell
From: Eric Auger HAD is a mandatory features with SMMUv3.1 if S1P is set, which is our case. Other 3.1 mandatory features come with S2P which we don't have. So let's support HAD and advertise SMMUv3.1 support in AIDR. HAD support allows the CD to disable hierarchical attributes, ie. if the

[PULL 16/27] target/arm: Convert A32 coprocessor insns to decodetree

2020-08-24 Thread Peter Maydell
Convert the A32 coprocessor instructions to decodetree. Note that this corrects an underdecoding: for the 64-bit access case (MRRC/MCRR) we did not check that bits [24:21] were 0b0010, so we would incorrectly treat LDC/STC as MRRC/MCRR rather than UNDEFing them. The decodetree versions of these

[PULL 21/27] target/arm: Delete unused VFP_DREG macros

2020-08-24 Thread Peter Maydell
As part of the Neon decodetree conversion we removed all the uses of the VFP_DREG macros, but forgot to remove the macro definitions. Do so now. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-id: 20200803124848.18295-1-peter.mayd...@linaro.org

[PULL 20/27] target/arm: Remove ARCH macro

2020-08-24 Thread Peter Maydell
The ARCH() macro was used a lot in the legacy decoder, but there are now just two uses of it left. Since a macro which expands out to a goto is liable to be confusing when reading code, replace the last two uses with a simple open-coded qeuivalent. Signed-off-by: Peter Maydell Reviewed-by:

  1   2   3   4   >