Re: [PATCH 14/25] hw/arm/mps2-tz: Create and connect ARMSSE Clocks

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create and connect the two clocks needed by the ARMSSE. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/arm/mps2-tz.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/hw/arm/mps2-tz.c

Re: [PATCH 13/25] hw/arm/mps2: Create and connect SYSCLK Clock

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create a fixed-frequency Clock object to be the SYSCLK, and wire it > up to the devices that require it. > > Signed-off-by: Peter Maydell Reviewed-by: Luc Michel > --- > hw/arm/mps2.c | 9 + > 1 file changed, 9 insertions(+) > > diff

Re: [PATCH v4 01/16] block: refactor bdrv_check_request: add errp

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > It's better to pass _abort than just assert that result is 0: on > crash, we'll immediately see the reason in the backtrace. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block_int.h| 2 +- >

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 18:58, Max Reitz wrote: > On 22.01.21 17:38, Laszlo Ersek wrote: >> (1) With SIGUSR2 permanently dedicated to "coroutine-sigaltstack.c", the >> comment on the qemu_init_main_loop() declaration, in >> "include/qemu/main-loop.h", also needs to be updated. SIGUSR2 is no >> longer a "free

Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-22 Thread Keith Busch
On Fri, Jan 22, 2021 at 09:07:34PM +0900, Minwoo Im wrote: > index b525fca14103..3dedefb8ebba 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -4435,6 +4435,9 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice > *pci_dev) > strpadcpy((char *)id->mn, sizeof(id->mn), "QEMU NVMe

Re: [PATCH v4 16/16] block/io: use int64_t bytes in copy_range

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 19:19, Eric Blake wrote: > On 1/22/21 11:58 AM, Max Reitz wrote: > +    if (!self) { +    /* + * This SIGUSR2 came from an external source, not from + * qemu_coroutine_new(), so perform the default action. + */ +   

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 19:05, Max Reitz wrote: > On 22.01.21 18:09, Laszlo Ersek wrote: >> On 01/22/21 11:20, Max Reitz wrote: >>> Modifying signal handlers is a process-global operation.  When two >>> threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, >>> they may interfere with each

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 18:58, Max Reitz wrote: > On 22.01.21 17:38, Laszlo Ersek wrote: >> On 01/22/21 11:20, Max Reitz wrote: >>> Modifying signal handlers is a process-global operation.  When two >>> threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, >>> they may interfere with each

[PATCH v2 8/8] configure: bump the minimum gdb version for check-tcg to 9.1

2021-01-22 Thread Alex Bennée
For SVE, currently the bulk of the GDB TCG tests, we need at least GDB 9.1 to support the "ieee_half" data type we report. This only affects when GDB tests are run; users can still use lower versions of gdb as long as they aren't talking to an SVE enabled model. The work around is to either get a

[PATCH v2 3/8] tests/docker: make _copy_with_mkdir accept missing files

2021-01-22 Thread Alex Bennée
Depending on the linker/ldd setup we might get a file with no path. Typically this is the psuedo library linux-vdso.so which doesn't actually exist on the disk. Rather than try and catch these distro specific edge cases just shout about it and try and continue. Signed-off-by: Alex Bennée

Re: [RFC PATCH 13/27] vhost: Send buffers to device

2021-01-22 Thread Eugenio Perez Martin
On Thu, Dec 10, 2020 at 12:55 PM Stefan Hajnoczi wrote: > > On Wed, Dec 09, 2020 at 07:41:23PM +0100, Eugenio Perez Martin wrote: > > On Tue, Dec 8, 2020 at 9:16 AM Stefan Hajnoczi wrote: > > > On Fri, Nov 20, 2020 at 07:50:51PM +0100, Eugenio Pérez wrote: > > > > +while (true) { > > > >

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Eric Blake
On 1/22/21 11:58 AM, Max Reitz wrote: >>> +    if (!self) { >>> +    /* >>> + * This SIGUSR2 came from an external source, not from >>> + * qemu_coroutine_new(), so perform the default action. >>> + */ >>> +    exit(0); >>> +    } >> >> (2) exit() is generally

[PATCH v2 1/8] tests/docker: Fix _get_so_libs() for docker-binfmt-image

2021-01-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé Fix a variable rename mistake from commit 5e33f7fead5: Traceback (most recent call last): File "./tests/docker/docker.py", line 710, in sys.exit(main()) File "./tests/docker/docker.py", line 706, in main return args.cmdobj.run(args, argv)

[PATCH v2 7/8] configure: make version_ge more tolerant of shady version input

2021-01-22 Thread Alex Bennée
When checking GDB versions we have to tolerate all sorts of random distro extensions to the version string. While we already attempt to do some of that before we call version_ge is makes sense to try and regularise the first input by stripping extraneous -'s. While we at it convert the old-style

[PATCH v2 5/8] tests/docker: alias docker-help target for consistency

2021-01-22 Thread Alex Bennée
We have a bunch of -help targets so this will save some cognitive dissonance. Keep the original for those with muscle memory. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include

[PATCH v2 6/8] tests/docker: add a docker-exec-copy-test

2021-01-22 Thread Alex Bennée
This provides test machinery for checking the QEMU copying logic works properly. It takes considerably less time to run than starting a debootstrap only for it to fail later. I considered adding a remove command to docker.py but figured that might be gold plating given the relative size of the

[PATCH v2 0/8] testing/next (docker, binfmt, gdb version)

2021-01-22 Thread Alex Bennée
Hi, The testing updates keep on rolling. This expands on the last version by adding some more handling of weird gdb version numbers and bumping the minimum requirement again. The following need review: - configure: bump the minimum gdb version for check-tcg to 9.1 - configure: make version_ge

[PATCH v2 4/8] tests/docker: preserve original name when copying libs

2021-01-22 Thread Alex Bennée
While it is important we chase down the symlinks to copy the correct data we can confuse the kernel by renaming the interpreter to what is in the binary. Extend _copy_with_mkdir to preserve the original name of the file when asked. Fixes: 5e33f7fead ("tests/docker: better handle symlinked libs")

[PATCH v2 2/8] tests/docker: Fix typo in help message

2021-01-22 Thread Alex Bennée
From: Philippe Mathieu-Daudé To have the variable properly passed, we need to set it, ie. NOUSER=1. Fix the message displayed by 'make docker'. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210119052120.522069-1-f4...@amsat.org> ---

Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing

2021-01-22 Thread Eric Blake
On 1/22/21 11:58 AM, Philippe Mathieu-Daudé wrote: >> +#include "qemu/osdep.h" >> +#include "insn.h" >> + >> +extern void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words, >> +target_ulong pc); >> +extern void snprint_a_pkt_debug(GString *buf, Packet

Re: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-01-22 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/20/21 4:28 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/arch.h | 35 ++ > target/hexagon/arch.c | 294 > ++ > 2 files changed, 329 insertions(+) > create mode 100644 target/hexagon/arch.h

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Max Reitz
On 22.01.21 18:09, Laszlo Ersek wrote: On 01/22/21 11:20, Max Reitz wrote: Modifying signal handlers is a process-global operation. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler

[PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

2021-01-22 Thread Cornelia Huck
The pvrdma code relies on the pvrdma_ring.h kernel header for some basic ring buffer handling. The content of that header isn't very exciting, but contains some (q)atomic_*() invocations that (a) cause manual massaging when doing a headers update, and (b) are an indication that we probably should

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Max Reitz
On 22.01.21 17:38, Laszlo Ersek wrote: On 01/22/21 11:20, Max Reitz wrote: Modifying signal handlers is a process-global operation. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler

Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:28 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > Reviewed-by: Philippe Mathieu-Daudé ' ;) > --- > target/hexagon/printinsn.h | 28 + > target/hexagon/printinsn.c | 146 > + > 2 files changed, 174 insertions(+) >

[PULL 5/8] scsi/utils: Add INVALID_PARAM_VALUE sense code definition

2021-01-22 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210120153522.1173897-3-phi...@redhat.com> Signed-off-by: Gerd Hoffmann --- include/scsi/utils.h | 2 ++ scsi/utils.c | 5 + 2 files changed, 7 insertions(+) diff --git

[PULL 2/8] hw/usb: Fix bad printf format specifiers

2021-01-22 Thread Gerd Hoffmann
From: Alex Chen We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen Message-id: 20201119025751.45750-1-alex.c...@huawei.com Signed-off-by: Gerd Hoffmann --- hw/usb/ccid-card-passthru.c | 2 +-

[PULL 7/8] usb: add pcap support.

2021-01-22 Thread Gerd Hoffmann
Log all traffic of a specific usb device to a pcap file for later inspection. File format is compatible with linux usb monitor. Usage: qemu -device usb-${somedevice},pcap=file.pcap wireshark file.pcap Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH v7 12/35] Hexagon (target/hexagon) instruction attributes

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:28 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/attribs.h | 30 ++ > target/hexagon/attribs_def.h | 95 > > 2 files changed, 125 insertions(+) > create mode 100644

[PULL 0/8] Usb 20210122 patches

2021-01-22 Thread Gerd Hoffmann
The following changes since commit 0e32462630687a18039464511bd0447ada5709c3: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-= request' into staging (2021-01-22 10:35:55 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20210122

[PULL 3/8] hw/usb: Convert to qdev_realize()

2021-01-22 Thread Gerd Hoffmann
From: Markus Armbruster Device code shouldn't mess with QOM property "realized" since we have proper interfaces (merge commit 6675a653). Commit 8ddab8dd3d "usb/hcd-xhci: Split pci wrapper for xhci base model" and commit f00ff136ee "usb: hcd-xhci-sysbus: Attach xhci to sysbus device"

[PULL 8/8] usb-host: map LIBUSB_SPEED_SUPER_PLUS to USB_SPEED_SUPER

2021-01-22 Thread Gerd Hoffmann
Handle host superspeedplus (usb 3.1+) devices like superspeed (usb 3.0) devices. That is enough to get them handled properly by xhci. They show up as superspeed devices inside the guest, but should be able to actually run at higher speeds. Reported-by: Angel Pagan Tested-by: Angel Pagan

[PULL 6/8] hw/usb/dev-uas: Report command additional adb length as unsupported

2021-01-22 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé We are not ready to handle additional CDB data. If a guest sends a packet with such additional data, report the command parameter as not supported. Specify a size (of 1 byte) for the add_cdb member we are not using, to fix the following warning:

[PULL 4/8] hw/usb/hcd-xhci: Fix extraneous format-truncation error on 32-bit hosts

2021-01-22 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé For some reason the assert() added in commit ccb799313a5 ("hw/usb: avoid format truncation warning when formatting port name") does not fix when building with GCC 10. KISS and expand the buffer by 4 bytes to silent the following error when using GCC 10.2.1 on Fedora

[PULL 1/8] hw/usb/host-libusb.c: fix build with kernel < 5.0

2021-01-22 Thread Gerd Hoffmann
From: Fabrice Fontaine USBDEVFS_GET_SPEED is used since version 5.2.0 and https://gitlab.com/qemu-project/qemu/-/commit/202d69a715a4b1824dcd7ec1683d027ed2bae6d3 resulting in the following build failure with kernel < 5.0: ../hw/usb/host-libusb.c: In function 'usb_host_open':

Re: [PATCH v7 08/35] Hexagon (target/hexagon) GDB Stub

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:28 AM, Taylor Simpson wrote: > GDB register read and write routines > > Signed-off-by: Taylor Simpson > Reviewed-by: Richard Henderson > Reviewed-by: Philippe Mathieu-Daudé ' in email... No need to respin of course!

Re: [PATCH v7 06/35] Hexagon (target/hexagon) register names

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 4:28 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > Reviewed-by: Richard Henderson > --- > target/hexagon/hex_regs.h | 83 > +++ > 1 file changed, 83 insertions(+) > create mode 100644 target/hexagon/hex_regs.h Reviewed-by:

Re: hexagon sysemu - library loading path feature

2021-01-22 Thread Philippe Mathieu-Daudé
Cc'ing Laurent and Alex. On 12/17/20 6:14 AM, Brian Cain wrote: > My team is working on sysemu support for Hexagon. We've made some good > progress so far and we'll work on upstreaming after Taylor’s hexagon > linux-user patch series lands. > > The only use case we have focused on with sysemu

Re: [PATCH] spapr: Adjust firmware path of PCI devices

2021-01-22 Thread Daniel Henrique Barboza
On 1/22/21 2:01 PM, Greg Kurz wrote: It is currently not possible to perform a strict boot from USB storage: $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ -boot strict=on \ -device qemu-xhci \ -device usb-storage,drive=disk,bootindex=0 \

Re: [PATCH v4 15/16] block/io: support int64_t bytes in read/write wrappers

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH] 9pfs: Convert reclaim list to QSLIST

2021-01-22 Thread Christian Schoenebeck
On Freitag, 22. Januar 2021 15:35:14 CET Greg Kurz wrote: > Use QSLIST instead of open-coding for a slightly improved readability. > > No behavioral change. > > Signed-off-by: Greg Kurz In general LGTM, so: Reviewed-by: Christian Schoenebeck Some comments below. > --- > hw/9pfs/9p.c | 17

[PATCH] spapr: Adjust firmware path of PCI devices

2021-01-22 Thread Greg Kurz
It is currently not possible to perform a strict boot from USB storage: $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ -boot strict=on \ -device qemu-xhci \ -device usb-storage,drive=disk,bootindex=0 \ -blockdev

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 11:20, Max Reitz wrote: > Modifying signal handlers is a process-global operation. When two > threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, > they may interfere with each other: One of them may revert the SIGUSR2 > handler back to the default between the other

Re: [PATCH v4 14/16] block/io: support int64_t bytes in bdrv_co_p{read,write}v_part()

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH v4 13/16] block/io: support int64_t bytes in bdrv_aligned_preadv()

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

[PATCH] i386: Add the support for AMD EPYC 3rd generation processors

2021-01-22 Thread Babu Moger
Adds the support for AMD 3rd generation processors. The model display for the new processor will be EPYC-Milan. Adds the following new feature bits on top of the feature bits from the first and second generation EPYC models. pcid: Process context identifiers support ibrs: Indirect Branch

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-22 Thread Cornelia Huck
On Thu, 21 Jan 2021 13:06:24 -0500 Matthew Rosato wrote: > On 1/21/21 12:50 PM, Cornelia Huck wrote: > > On Thu, 21 Jan 2021 15:54:22 +0100 > > Niklas Schnelle wrote: > > > >> On 1/21/21 3:46 PM, Pierre Morel wrote: > >>> > >>> > >>> On 1/21/21 2:37 PM, Niklas Schnelle wrote: > >

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Laszlo Ersek
On 01/22/21 11:20, Max Reitz wrote: > Modifying signal handlers is a process-global operation. When two > threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, > they may interfere with each other: One of them may revert the SIGUSR2 > handler back to the default between the other

Re: [PATCH v4 12/16] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH v4 11/16] block/io: support int64_t bytes in bdrv_aligned_pwritev()

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH] gitlab-ci.yml: Use the whole tree as artifacts to speed up the CI

2021-01-22 Thread Thomas Huth
On 22/01/2021 11.18, Daniel P. Berrangé wrote: On Fri, Jan 22, 2021 at 11:07:22AM +0100, Thomas Huth wrote: Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules

Re: [PATCH v4 10/16] block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes()

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Kevin Wolf
Am 22.01.2021 um 17:08 hat Eric Blake geschrieben: > On 1/22/21 5:27 AM, Kevin Wolf wrote: > > Am 20.01.2021 um 21:52 hat Eric Blake geschrieben: > >> On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> Hi all! > >>> > >>> These series has 3 goals: > >>> > >>> - get rid of group file

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > These series has 3 goals: > > - get rid of group file (to forget about rebase and in-list conflicts) > - introduce human-readable names for tests > - rewrite check into python > > v7: > - fix wording and

[Bug 1912777] Re: KVM_EXIT_MMIO has increased in Qemu4.0.0 when compared to Qemu 2.11.0

2021-01-22 Thread Thomas Huth
Can you provide a link to the test case that you used? Otherwise, can you try to bisect the problem? Can you please also try with the latest version of QEMU? v4.0 is rather old already. ** Information type changed from Public Security to Public ** Changed in: qemu Status: New =>

Re: [PATCH v7 00/11] Rework iotests/check

2021-01-22 Thread Eric Blake
On 1/22/21 5:27 AM, Kevin Wolf wrote: > Am 20.01.2021 um 21:52 hat Eric Blake geschrieben: >> On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> These series has 3 goals: >>> >>> - get rid of group file (to forget about rebase and in-list conflicts) >>> - introduce

Re: [PATCH v7 10/11] iotests: rewrite check into python

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Just use classes introduced in previous three commits. Behavior > difference is described in these three commits. > > Drop group file, as it becomes unused. > > Drop common.env: now check is in python, and for tests we use

Re: [PATCH v4 09/16] block/io: use int64_t bytes in driver wrappers

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary

2021-01-22 Thread Philippe Mathieu-Daudé
On 1/20/21 6:35 PM, Paolo Bonzini wrote: > On 20/01/21 18:02, Philippe Mathieu-Daudé wrote: >>> >>> For patch 1, which files are not compiled with the patch that were >>> compiled without? >> softfloat. > > Really?  I see this: > > specific_ss.add(when: 'CONFIG_TCG', if_true: files( >  

[Bug 1912777] Re: KVM_EXIT_MMIO has increased in Qemu4.0.0 when compared to Qemu 2.11.0

2021-01-22 Thread ANIMESH KUMAR SINHA
** Information type changed from Private Security to Public Security ** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912777 Title:

[Bug 1912790] Re: qemu-aarch64-static segfaults python3

2021-01-22 Thread Philippe Mathieu-Daudé
** Tags added: linux-user tcg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912790 Title: qemu-aarch64-static segfaults python3 Status in QEMU: New Bug description: qemu-aarch64-static is

Re: [PATCH] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-22 Thread Vivek Goyal
On Thu, Jan 21, 2021 at 02:48:03PM +, Daniel P. Berrangé wrote: > On Thu, Jan 21, 2021 at 02:44:29PM +, Stefan Hajnoczi wrote: > > A well-behaved FUSE client does not attempt to open special files with > > FUSE_OPEN because they are handled on the client side (e.g. device nodes > > are

Re: [PATCHv8 1/3] hw: gpio: implement gpio-pwr driver for qemu reset/poweroff

2021-01-22 Thread Peter Maydell
On Wed, 20 Jan 2021 at 09:27, Maxim Uvarov wrote: > > Implement gpio-pwr driver to allow reboot and poweroff machine. > This is simple driver with just 2 gpios lines. Current use case > is to reboot and poweroff virt machine in secure mode. Secure > pl066 gpio chip is needed for that. > >

Re: [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

2021-01-22 Thread Peter Maydell
On Wed, 20 Jan 2021 at 09:27, Maxim Uvarov wrote: > > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). Connect it > with gpio-pwr driver. > > Signed-off-by: Maxim Uvarov A nit, which I raise only because you'll need a respin anyway: > +/*

Re: [PATCH 05/25] keyval: simplify keyval_parse_one

2021-01-22 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/01/21 14:48, Markus Armbruster wrote: >>--nbd .key= >> master: Invalid parameter '..key' >> your patch: same >> Likweise. >>If I omit the '=', your patch's message changes to >>No implicit parameter name for value

Re: [PATCH] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-22 Thread Vivek Goyal
On Thu, Jan 21, 2021 at 02:44:29PM +, Stefan Hajnoczi wrote: > A well-behaved FUSE client does not attempt to open special files with > FUSE_OPEN because they are handled on the client side (e.g. device nodes > are handled by client-side device drivers). > > The check to prevent virtiofsd

Re: [PATCH 11/25] hw/arm/armsse: Wire up clocks

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > Create two input clocks on the ARMSSE devices, one for the normal > MAINCLK, and one for the 32KHz S32KCLK, and wire these up to the > appropriate devices. The old property-based clock frequency setting > will remain in place until conversion is

Re: [PATCH 12/25] hw/arm/mps2: Inline CMSDK_APB_TIMER creation

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > The old-style convenience function cmsdk_apb_timer_create() for > creating CMSDK_APB_TIMER objects is used in only two places in > mps2.c. Most of the rest of the code in that file uses the new > "initialize in place" coding style. > > We want to

Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 15:19, Edgar E. Iglesias wrote: > > On Fri, Jan 22, 2021 at 01:21:53PM +, Peter Maydell wrote: > > Just noticed this wasn't cc'd to the Xilinx folks. Would one > > of you like to review it? > > Looks good to me but we need to also update the test cases in >

Re: [Qemu-devel] [PATCH v2 07/11] chardev: Let IOReadHandler use unsigned type

2021-01-22 Thread Richard Purdie
On Fri, 2021-01-22 at 14:55 +0100, Philippe Mathieu-Daudé wrote: > Hi Prasad, Richard. > > On 1/22/21 12:52 PM, P J P wrote: > > +-- On Fri, 22 Jan 2021, Richard Purdie wrote --+ > > > If so can anyone point me at that change? > > > > > > I ask since CVE-2018-18438 is marked as affecting all

Re: [PATCH 10/25] hw/arm/armsse: Rename "MAINCLK" property to "MAINCLK_FRQ"

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > While we transition the ARMSSE code from integer properties > specifying clock frequencies to Clock objects, we want to have the > device provide both at once. We want the final name of the main > input Clock to be "MAINCLK", following the hardware

Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties

2021-01-22 Thread Edgar E. Iglesias
On Fri, Jan 22, 2021 at 01:21:53PM +, Peter Maydell wrote: > Just noticed this wasn't cc'd to the Xilinx folks. Would one > of you like to review it? Looks good to me but we need to also update the test cases in tests/qtest/xlnx-can-test.c. Cheers, Edgar > > thanks > -- PMM > > On Mon,

Re: [PATCH 09/25] hw/watchdog/cmsdk-apb-watchdog: Add Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > As the first step in converting the CMSDK_APB_TIMER device to the > Clock framework, add a Clock input. For the moment we do nothing > with this clock; we will change the behaviour from using the > wdogclk-frq property to using the Clock once all

Re: [PATCH 08/25] hw/timer/cmsdk-apb-dualtimer: Add Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > As the first step in converting the CMSDK_APB_DUALTIMER device to the > Clock framework, add a Clock input. For the moment we do nothing > with this clock; we will change the behaviour from using the pclk-frq > property to using the Clock once all

Re: [PATCH 1/2] intel_iommu: Support IR-only mode without DMA translation

2021-01-22 Thread David Woodhouse
On Thu, 2020-10-15 at 19:34 +0100, David Woodhouse wrote: > From: David Woodhouse > > By setting none of the SAGAW bits we can indicate to a guest that DMA > translation isn't supported. Tested by booting Windows 10, as well as > Linux guests with the fix at

Re: [PATCH 07/25] hw/timer/cmsdk-apb-timer: Add Clock input

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > As the first step in converting the CMSDK_APB_TIMER device to the > Clock framework, add a Clock input. For the moment we do nothing > with this clock; we will change the behaviour from using the pclk-frq > property to using the Clock once all the

Re: [PULL 0/7] 2021-01-20 fuzzing patches

2021-01-22 Thread Peter Maydell
On Wed, 20 Jan 2021 at 17:45, Alexander Bulekov wrote: > > Hi Peter, > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into staging (2021-01-19 > 15:47:23 +) > > are

[PATCH v3] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-01-22 Thread yaroshchuk2000
From: Vladislav Yaroshchuk For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to add paravirtualization cpuid leaf 0x4010 https://lkml.org/lkml/2008/10/1/246 Leaf 0x4010, Timing Information: EAX: (Virtual) TSC frequency in kHz. EBX: (Virtual) Bus (local apic timer)

Re: [PATCH v7 09/11] iotests: add testrunner.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 17:51, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestRunner class, which will run tests in a new python iotests running framework. There are some differences with current ./check behavior, most significant are: - Consider all tests

Re: [PATCH 05/25] keyval: simplify keyval_parse_one

2021-01-22 Thread Paolo Bonzini
On 22/01/21 14:48, Markus Armbruster wrote: --nbd .key= master: Invalid parameter '..key' your patch: same Likweise. If I omit the '=', your patch's message changes to No implicit parameter name for value 'key..' I consider that worse than

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-22 Thread Eric Blake
On 1/22/21 4:20 AM, Max Reitz wrote: > Modifying signal handlers is a process-global operation. When two > threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, > they may interfere with each other: One of them may revert the SIGUSR2 > handler back to the default between the

Re: [PATCH] pci: add romsize property

2021-01-22 Thread Paolo Bonzini
On 19/01/21 18:20, Laszlo Ersek wrote: I only have superficial comments: - if we're talking uint32_t, I'd kind of prefer UINT32_MAX to (-1), style-wise -- but feel free to ignore - we should print a uint32_t with ("%" PRIu32), not "%d" (again, only pedantry, but PRIu32 is widely used in qemu,

Re: [PATCH v2] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-01-22 Thread Vladislav Yaroshchuk
Hi Cameron, ср, 20 янв. 2021 г. в 01:37, Cameron Esfahani : > > > > On Jan 14, 2021, at 11:47 AM, yaroshchuk2...@gmail.com wrote: > > > > From: Vladislav Yaroshchuk > > > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > > add paravirtualization cpuid leaf 0x4010 >

Re: [PATCH v7 09/11] iotests: add testrunner.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add TestRunner class, which will run tests in a new python iotests > running framework. > > There are some differences with current ./check behavior, most > significant are: > - Consider all tests self-executable, just run

Re: [PATCH v4 08/16] block: use int64_t as bytes type in tracked requests

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > We are generally moving to int64_t for both offset and bytes parameters > on all io paths. > > Main motivation is realization of 64-bit write_zeroes operation for > fast zeroing large disk chunks, up to the whole disk. > > We chose

Re: [PATCH 06/25] tests: convert check-qom-proplist to keyval

2021-01-22 Thread Paolo Bonzini
On 22/01/21 15:14, Markus Armbruster wrote: +dobj = DUMMY_OBJECT(object_resolve_path_component(object_get_objects_root(), + "dev0")); Why does user_creatable_add_opts() return the object on success, null on failure, but

Re: [PATCH v4 07/16] block/io: improve bdrv_check_request: check qiov too

2021-01-22 Thread Eric Blake
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote: > Operations with qiov add more restrictions on bytes, let's cover it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/io.c | 46 +++--- > 1 file changed, 39 insertions(+), 7

Re: [PATCH 06/25] tests: convert check-qom-proplist to keyval

2021-01-22 Thread Paolo Bonzini
On 22/01/21 15:14, Markus Armbruster wrote: ok 2 /qom/proplist/createv Unexpected error in find_list() at ../util/qemu-config.c:24: There is no option group 'object' Hmm, maybe a semantic conflict when I rebased. I'll take a look. +qdict = keyval_parse(params, "qom-type", , ); Why

[PATCH] 9pfs: Convert reclaim list to QSLIST

2021-01-22 Thread Greg Kurz
Use QSLIST instead of open-coding for a slightly improved readability. No behavioral change. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 17 - hw/9pfs/9p.h | 2 +- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

Re: [PATCH v7 08/11] iotests: add testenv.py

2021-01-22 Thread Kevin Wolf
Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add TestEnv class, which will handle test environment in a new python > iotests running framework. > > Difference with current ./check interface: > - -v (verbose) option dropped, as it is unused > > - -xdiff option is

Re: [PATCH] pci: add romsize property

2021-01-22 Thread Michael S. Tsirkin
On Fri, Dec 18, 2020 at 01:27:36PM -0500, Paolo Bonzini wrote: > This property can be useful for distros to set up known-good ROM sizes for > migration purposes. The VM will fail to start if the ROM is too large, > and migration compatibility will not be broken if the ROM is too small. > >

Re: [PATCH 07/25] keyval: introduce keyval_parse_into

2021-01-22 Thread Paolo Bonzini
On 22/01/21 15:22, Markus Armbruster wrote: + * On success, return @dict, now filled with the parsed keys and values. * On failure, store an error through @errp and return NULL. May @dict be modified then? Yes, it can. Good point. Paolo

Re: [PATCH v2] target/i386/hvf: add vmware-cpuid-freq cpu feature

2021-01-22 Thread Vladislav Yaroshchuk
Hi Roman, вт, 19 янв. 2021 г. в 21:01, Roman Bolshakov : > On Thu, Jan 14, 2021 at 10:47:03PM +0300, yaroshchuk2...@gmail.com wrote: > > From: Vladislav Yaroshchuk > > > > For `-accel hvf` cpu_x86_cpuid() is wrapped with hvf_cpu_x86_cpuid() to > > add paravirtualization cpuid leaf 0x4010 >

Re: [PATCH v2] hw/core/resettable: make in-reset state false during exit phase call

2021-01-22 Thread Peter Maydell
On Fri, 22 Jan 2021 at 10:36, Damien Hedde wrote: > > Move the reset count decrement from "just after" to "just before" > calling the exit phase handler. The goal is to make > resettable_is_in_reset() returning false during the handler execution. > > This simplifies reset handling in resettable

[Bug 1912790] [NEW] qemu-aarch64-static segfaults python3

2021-01-22 Thread Santiago Piccinini
Public bug reported: qemu-aarch64-static is segfaulting in a debian build process using debootstrap. ``` Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/bin/qemu-aarch64-static... Reading symbols from

Re: [PATCH 07/25] keyval: introduce keyval_parse_into

2021-01-22 Thread Markus Armbruster
Paolo Bonzini writes: > Allow parsing multiple keyval sequences into the same dictionary. > > Signed-off-by: Paolo Bonzini I trust later patches will make the need for this obvious. I guess we could use qdict_join() instead. Observation, not objection. > --- > include/qemu/option.h | 2 ++

Re: [PATCH v7 09/11] iotests: add testrunner.py

2021-01-22 Thread Vladimir Sementsov-Ogievskiy
22.01.2021 17:11, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestRunner class, which will run tests in a new python iotests running framework. There are some differences with current ./check behavior, most significant are: - Consider all tests

Re: [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > The state struct for the CMSDK APB timer device doesn't follow our > usual naming convention of camelcase -- "CMSDK" and "APB" are both > acronyms, but "TIMER" is not so should not be all-uppercase. > Globally rename the struct to "CMSDKAPBTimer"

Re: [PATCH v2] 9pfs: Improve unreclaim loop

2021-01-22 Thread Greg Kurz
On Fri, 22 Jan 2021 14:09:12 +0100 Christian Schoenebeck wrote: > On Donnerstag, 21. Januar 2021 19:15:10 CET Greg Kurz wrote: > > If a fid was actually re-opened by v9fs_reopen_fid(), we re-traverse the > > fid list from the head in case some other request created a fid that > > needs to be

<    1   2   3   4   >