[PATCH] virtiofsd: Changed allocations of fuse_session to GLib's functions

2021-03-24 Thread Mahmoud Mandour
Replaced the allocation and deallocation of fuse_session structs from calloc() and free() calls to g_try_new0() and g_free(). Signed-off-by: Mahmoud Mandour --- tools/virtiofsd/fuse_lowlevel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine

2021-03-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210324070955.125941-1-j...@jms.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210324070955.125941-1-j...@jms.id.au Subject: [PATCH v4 0/3] hw/misc: Model ASPEED hash and

[PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-24 Thread Viresh Kumar
This adds the vhost-user backend driver to support virtio based I2C devices. vhost-user-i2c --help Signed-off-by: Viresh Kumar --- hw/virtio/vhost-user-i2c.c | 2 +- tools/meson.build| 8 + tools/vhost-user-i2c/50-qemu-i2c.json.in | 5 +

[PATCH 5/5] MAINTAINERS: Add entry for virtio-i2c

2021-03-24 Thread Viresh Kumar
This patch adds entry for virtio-i2c related files in MAINTAINERS. Signed-off-by: Viresh Kumar --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9147e9a429a0..3a80352fc85b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1967,6 +1967,15

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Claudio Fontana
On 3/23/21 11:50 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> After this patch it is possible to build only kvm: >> >> ./configure --disable-tcg --enable-kvm It's possible to build, but tests will fail until all the test-related patches are applied. > > FWIW at this point we

Re: [PATCH] tests/migration: fix parameter of auto-converge migration

2021-03-24 Thread Hyman Huang
在 2021/3/24 13:42, Thomas Huth 写道: On 23/03/2021 20.40, Dr. David Alan Gilbert wrote: * huang...@chinatelecom.cn (huang...@chinatelecom.cn) wrote: From: Hyman Huang(黄勇) when execute the following test command: $ ./guestperf-batch.py --auto-converge \ --auto-converge-step {percent}

Re: [PATCH v2] MAINTAINERS: Fix tests/migration maintainers

2021-03-24 Thread Thomas Huth
On 19/03/2021 09.07, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) when executing the following scripts, it throw error message: $ ./scripts/get_maintainer.pl -f tests/migration/guestperf.py get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do

Re: [PATCH v4 1/4] virtio:add support in configure interrupt

2021-03-24 Thread Jason Wang
在 2021/3/23 上午9:56, Cindy Lu 写道: Add configure notifier support in virtio and related driver When peer is vhost vdpa, setup the configure interrupt function vhost_net_start and release the resource when vhost_net_stop So this patch doesn't complie, please fix. Signed-off-by: Cindy Lu

[PATCH v4 2/3] aspeed: Integrate HACE

2021-03-24 Thread Joel Stanley
Add the hash and crypto engine model to the Aspeed socs. Reviewed-by: Andrew Jeffery Signed-off-by: Joel Stanley --- v3: Rebase on upstream v4: Update integration for soc-specific hace objects --- docs/system/arm/aspeed.rst | 2 +- include/hw/arm/aspeed_soc.h | 3 +++

[PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

2021-03-24 Thread Viresh Kumar
Hello, This is an initial implementation of a generic vhost-user backend for the I2C bus. This is based of the virtio specifications (already merged) for the I2C bus. The kernel virtio I2C driver is still under review, here is the latest version (v10):

[PATCH 2/5] hw/virtio: add vhost-user-i2c-pci boilerplate

2021-03-24 Thread Viresh Kumar
This allows is to instantiate a vhost-user-i2c device as part of a PCI bus. It is mostly boilerplate which looks pretty similar to the vhost-user-fs-pci device. Signed-off-by: Viresh Kumar --- hw/virtio/meson.build | 1 + hw/virtio/vhost-user-i2c-pci.c | 79

[Bug 1909247] Re: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c

2021-03-24 Thread Mark Cave-Ayland
Can you confirm that this is fixed in the v2 of the above patchset? https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg06550.html ATB, Mark. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 09/22] tests/tcg: add HeapInfo checking to semihosting test

2021-03-24 Thread Thomas Huth
On 23/03/2021 17.52, Alex Bennée wrote: Query the SYS_HEAPINFO semicall and do some basic verification of the information via libc calls. Signed-off-by: Alex Bennée Message-Id: <20210320133706.21475-10-alex.ben...@linaro.org> --- v2 - expand test as suggested by Richard ---

Re: [PATCH 13/28] qapi: Enforce event naming rules

2021-03-24 Thread Markus Armbruster
John Snow writes: > On 3/23/21 5:40 AM, Markus Armbruster wrote: >> Event names should be ALL_CAPS with words separated by underscore. >> Enforce this. The only offenders are in tests/. Fix them. Existing >> test event-case covers the new error. >> Signed-off-by: Markus Armbruster >> --- >>

Re: [PATCH v2] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1616567465-153141-1-git-send-email-robert...@linux.intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1616567465-153141-1-git-send-email-robert...@linux.intel.com Subject:

[PATCH v4 1/3] hw: Model ASPEED's Hash and Crypto Engine

2021-03-24 Thread Joel Stanley
The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1, SHA2, RSA and other cryptographic algorithms. This initial model implements a subset of the device's functionality; currently only direct access (non-scatter gather) hashing. Signed-off-by: Joel Stanley --- v3: - rebase on

[PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine

2021-03-24 Thread Joel Stanley
v4: Rebase on Philippe's memory region cleanup series [1] Address feedback from Cédric Rework qtest to run on ast2400, ast2500 and ast2600 v3: Rework qtest to not use libqtest-single.h, rebase to avoid LPC conflicts. v2: Address review from Andrew and Philippe. Adds a qtest. [1]

Re: [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

2021-03-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1616570702.git.viresh.ku...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1616570702.git.viresh.ku...@linaro.org Subject: [PATCH 0/5] virtio: Implement

Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-03-24 Thread Andrey Gruzdev
On 23.03.2021 21:35, Peter Xu wrote: On Tue, Mar 23, 2021 at 08:21:43PM +0300, Andrey Gruzdev wrote: For the long term I think we'd better have a helper: qemu_put_qio_channel_buffer(QEMUFile *file, QIOChannelBuffer *bioc) So as to hide this flush operation, which is tricky. We'll

Re: [PATCH qemu] spapr: Fix typo in the patb_entry comment

2021-03-24 Thread David Gibson
On Wed, Mar 24, 2021 at 03:30:57PM +1100, Alexey Kardashevskiy wrote: > > > On 22/03/2021 16:44, David Gibson wrote: > > On Thu, Feb 25, 2021 at 02:23:35PM +1100, Alexey Kardashevskiy wrote: > > > There is no H_REGISTER_PROCESS_TABLE, it is H_REGISTER_PROC_TBL handler > > > for which is still

Re: [PATCH v2 08/10] tests/acceptance/virtiofs_submounts.py: remove launch_vm()

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 2:32 AM Cleber Rosa wrote: > The LinuxTest class' launch_and_wait() method now behaves the same way > as this test's custom launch_vm(), so let's just use the upper layer > (common) method. > > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-André Lureau > --- >

Re: [PATCH 05/20] qobject: Change qobject_to_json()'s value to GString

2021-03-24 Thread Thomas Huth
On 11/12/2020 18.11, Markus Armbruster wrote: qobject_to_json() and qobject_to_json_pretty() build a GString, then covert it to QString. Just one of the callers actually needs a QString: qemu_rbd_parse_filename(). A few others need a string they can modify: qmp_send_response(), qga's

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-24 Thread Greg KH
On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote: > Hi Greg, > > After your previous reply on this thread we started considering to provide > this interface and framework/functionality through a userspace service > instead of a kernel interface. > The latest iteration on

Re: [PATCH v2 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
24.03.2021 00:22, Paolo Bonzini wrote: On 23/03/21 20:17, Vladimir Sementsov-Ogievskiy wrote: +    unittest.main(argv=argv, +  testRunner=ReproducibleTestRunner, +  verbosity=2 if debug else 1, +  warnings=None if sys.warnoptions else 'ignore')  

Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
24.03.2021 00:20, Paolo Bonzini wrote: On 23/03/21 20:12, Vladimir Sementsov-Ogievskiy wrote: Move the trailing empty line to print_env(), since it always looks better and one caller was not adding it. Seems you've moved this fix from one unrelated commit to another.. And it touches two

Re: [PATCH 05/20] qobject: Change qobject_to_json()'s value to GString

2021-03-24 Thread Markus Armbruster
Thomas Huth writes: > On 11/12/2020 18.11, Markus Armbruster wrote: >> qobject_to_json() and qobject_to_json_pretty() build a GString, then >> covert it to QString. Just one of the callers actually needs a >> QString: qemu_rbd_parse_filename(). A few others need a string they >> can modify:

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-24 Thread Markus Armbruster
Zhang Chen writes: > Add L4_Connection struct for other QMP commands. > Except protocol field is necessary, other fields are optional. > > Signed-off-by: Zhang Chen > --- > qapi/net.json | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/qapi/net.json

Re: [PATCH v4 4/4] virtio-pci: add support for configure interrupt

2021-03-24 Thread Jason Wang
在 2021/3/23 上午9:56, Cindy Lu 写道: Add support for configure interrupt, use kvm_irqfd_assign and set the gsi to kernel. When the configure notifier was eventfd_signal by host kernel, this will finally inject an msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 171

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-24 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Zhang, Chen" writes: >> >> >> -Original Message- >> >> From: Markus Armbruster >> [...] >> >> Naming the argument type L4_Connection is misleading. >> >> >> >> Even naming the match arguments

[PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE

2021-03-24 Thread Joel Stanley
This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests the currently implemented behavior of the hash functionality. The tests are similar, but are cut/pasted instead of broken out into a common function so the assert machinery produces useful output when a test fails.

[PATCH 1/5] hw/virtio: add boilerplate for vhost-user-i2c device

2021-03-24 Thread Viresh Kumar
This creates the QEMU side of the vhost-user-i2c device which connects to the remote daemon. It is based of vhost-user-fs code. Signed-off-by: Viresh Kumar --- hw/virtio/Kconfig | 5 + hw/virtio/meson.build | 1 + hw/virtio/vhost-user-i2c.c

Re: [PATCH v1 0/3] migration: Fixes to the 'background-snapshot' code

2021-03-24 Thread Andrey Gruzdev
On 24.03.2021 01:21, Peter Xu wrote: On Fri, Mar 19, 2021 at 05:52:46PM +0300, Andrey Gruzdev wrote: Changes v0->v1: * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host page size in ram_block_populate_pages() * More elegant implementation of ram_block_populate_pages()

Re: [PATCH v2 06/10] Acceptance Tests: make username/password configurable

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 2:21 AM Cleber Rosa wrote: > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa >

Re: [PATCH v4 2/4] vhost-vdpa: add callback function for configure interrupt

2021-03-24 Thread Jason Wang
在 2021/3/23 上午9:56, Cindy Lu 写道: Add call back function for configure interrupt. Set the notifier's fd to the kernel driver when vdpa start. also set -1 while vdpa stop. then the kernel will release the related resource Signed-off-by: Cindy Lu --- hw/virtio/trace-events| 2 ++

Re: [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE

2021-03-24 Thread Cédric Le Goater
On 3/24/21 8:09 AM, Joel Stanley wrote: > This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests > the currently implemented behavior of the hash functionality. > > The tests are similar, but are cut/pasted instead of broken out into a > common function so the assert machinery

Re: [PATCH v4 1/3] hw: Model ASPEED's Hash and Crypto Engine

2021-03-24 Thread Cédric Le Goater
On 3/24/21 8:09 AM, Joel Stanley wrote: > The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1, > SHA2, RSA and other cryptographic algorithms. > > This initial model implements a subset of the device's functionality; > currently only direct access (non-scatter gather) hashing. >

[PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Robert Hoo
Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), CPUX86State.xmm_regs[] has already been extended to 512bit to support AVX512. Also, other qemu level supports for AVX512 registers are there for years. But in x86_cpu_dump_state(), still only dump XMM registers no matter

Re: [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 2:34 AM Cleber Rosa wrote: > The LinuxTest specifically targets users that need to interact with Linux > guests. So, it makes sense to give a connection by default, and avoid > requiring it as boiler-plate code. > > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-André

[PATCH 4/5] docs: add a man page for vhost-user-i2c

2021-03-24 Thread Viresh Kumar
Basic usage and example invocation. Signed-off-by: Viresh Kumar --- docs/tools/index.rst | 1 + docs/tools/vhost-user-i2c.rst | 75 +++ 2 files changed, 76 insertions(+) create mode 100644 docs/tools/vhost-user-i2c.rst diff --git

[Bug 1909247] Re: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c

2021-03-24 Thread P J P
On Wednesday, 17 March, 2021, 10:26:36 pm IST, Cheolwoo Myung wrote: > Hello PJP, Mauro > > Of course. you can post the details with our reproducers. > I'm glad it helped you. > > Thank you. > - Cheolwoo Myung > 2021년 3월 17일 (수) 오후 10:30, P J P 님이 작성: > >On Monday, 15 March, 2021, 07:54:30

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Marc-André Lureau
Hi On Wed, Mar 24, 2021 at 2:23 AM Cleber Rosa wrote: > For users of the LinuxTest class, let's set up the VM with the port > redirection for SSH, instead of requiring each test to set the same > arguments. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/avocado_qemu/__init__.py | 4

[PATCH v2] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Robert Hoo
Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), CPUX86State.xmm_regs[] has already been extended to 512bit to support AVX512. Also, other qemu level supports for AVX512 registers are there for years. But in x86_cpu_dump_state(), still only dump XMM registers no matter

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-24 Thread Christian Ehrhardt 
@Sadoon - yes, that is the same fix that Laurent pointed to a few hours before. @Frank - the kernel I had before was 5.11.0-11-generic (failing). I've tested "5.11.0-13-generic #14~lp1920784" from your PPA and can confirm that this fixes the issue. Thanks Laurent for identifying the fix and

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-24 Thread Christian Ehrhardt 
And gladly this was only added in >=5.9 and we have Groovy (5.8) and Hirsute (5.11) so only the Hirsute kernel is needed to adapt, but further backports are not needed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition

2021-03-24 Thread Markus Armbruster
Markus Armbruster writes: > "Dr. David Alan Gilbert" writes: [...] >> I think there should also beb >> a separate type that represents an IP address+port, so that what you end >> up with is: >> >> IPFlowSpec >> ID >> Protocol >> Source >>

Re: [PATCH v4 2/3] aspeed: Integrate HACE

2021-03-24 Thread Cédric Le Goater
On 3/24/21 8:09 AM, Joel Stanley wrote: > Add the hash and crypto engine model to the Aspeed socs. > > Reviewed-by: Andrew Jeffery > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater > --- > v3: Rebase on upstream > v4: Update integration for soc-specific hace objects > --- >

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Greg Kurz
On Wed, 24 Mar 2021 00:35:05 +0100 Philippe Mathieu-Daudé wrote: > On 3/24/21 12:00 AM, Greg Kurz wrote: > > Cc'ing David > > > > On Tue, 23 Mar 2021 17:48:36 +0100 > > Thomas Huth wrote: > > > >> > >> In case anyone is interested in fixing those, there are two regressions > >> with > >>

[Bug 1921082] [NEW] VM crash when process broadcast MCE

2021-03-24 Thread Yao Aili
Public bug reported: When i do memory SRAR test for VM, I meet the following issue: My VM has 16 vCPU, I will inject one UE error to memory which is accessed by VM, Then host MCE is raised and SIGBUS is send to VM, and qemu take control. Qemu will check the broadcast attribute by following

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Thomas Huth
On 24/03/2021 00.35, Philippe Mathieu-Daudé wrote: [...] Hmmm does this assert() matches your comment? -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..41cbee77d14 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1130,6 +1130,8 @@ Object *qdev_get_machine(void) {

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Laurent Vivier
Le 24/03/2021 à 10:17, David Hildenbrand a écrit : > On 24.03.21 09:51, Andreas Krebbel wrote: >> The sigreturn SVC is put onto the stack by the emulation code.  Hence >> the address of it should not be subject to guest_base transformation >> when fetching it. >> >> The fix applies h2g to the

Re: [PATCH v2 2/7] ui/vdagent: core infrastructure

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 1:47 PM Gerd Hoffmann wrote: > On Mon, Mar 22, 2021 at 11:27:17AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > +if (vd->msgsize != msg->size + sizeof(*msg)) { > > > > +/* FIXME: handle parse messages splitted into multiple > chunks */ > > > > +

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > For users of the LinuxTest class, let's set up the VM with the port > redirection for SSH, instead of requiring each test to set the same > arguments. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/avocado_qemu/__init__.py | 4 +++- >

Re: [PATCH V4 5/7] net/colo-compare: Move data structure and define to .h file.

2021-03-24 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > Make other modules can reuse COLO code. > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 106 - > net/colo-compare.h | 106 + > 2 files changed, 106

qdev: Regarding lazy ISA bridge creation

2021-03-24 Thread Philippe Mathieu-Daudé
Hi Cédric, I'm trying to understand the comment you added in commit 3495b6b6101 ("ppc/pnv: add a ISA bus"): /* let isa_bus_new() create its own bridge on SysBus otherwise * devices specified on the command line won't find the bus and * will fail to create. */ isa_bus = isa_bus_new(NULL,

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Alex Bennée
Claudio Fontana writes: > On 3/23/21 11:50 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> After this patch it is possible to build only kvm: >>> >>> ./configure --disable-tcg --enable-kvm > > > It's possible to build, but tests will fail until all the test-related > patches are

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Marc-André Lureau
Hi On Wed, Mar 24, 2021 at 2:16 PM Gerd Hoffmann wrote: > Hi, > > > > +if (gd->cbowner[s]) { > > > +/* ignore notifications about our own grabs */ > > > +return; > > > +} > > > + > > > + > > > +switch (event->owner_change.reason) { > > > +case

Re: [PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-24 Thread BALATON Zoltan
On Wed, 24 Mar 2021, David Gibson wrote: On Tue, Mar 23, 2021 at 02:01:27PM +0100, BALATON Zoltan wrote: On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC

[Bug 1920934] Re: Heap-use-after-free in io_writex / cputlb.c results in Linux kernel crashes

2021-03-24 Thread Richard Henderson
This suggests that the rcu_read in iotlb_to_section is not playing well with one of the g_renew calls in softmmu/physmem.c. Not sure which, since the sanitizer dump above doesn't trace back beyond glib itself. -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v2 04/10] Acceptance Tests: move useful ssh methods to base class

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > Both the virtiofs submounts and the linux ssh mips malta tests > contains useful methods related to ssh that deserve to be made > available to other tests. Let's move them to the base LinuxTest nit: strictly speaking they are moved to another

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread David Hildenbrand
On 24.03.21 09:51, Andreas Krebbel wrote: The sigreturn SVC is put onto the stack by the emulation code. Hence the address of it should not be subject to guest_base transformation when fetching it. The fix applies h2g to the address when writing it into the return address register to nullify

Re: [PATCH v2 09/10] Acceptance Tests: add basic documentation on LinuxTest base class

2021-03-24 Thread Auger Eric
Hi, On 3/23/21 11:15 PM, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-André Lureau > Reviewed-by: Willian Rampazzo Reviewed-by: Eric Auger Eric > --- > docs/devel/testing.rst | 25 + > 1 file changed, 25 insertions(+) > > diff --git

Re: [PATCH v2 02/10] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra s/than/then > arguments will not be

Re: [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE

2021-03-24 Thread Thomas Huth
On 24/03/2021 08.21, Cédric Le Goater wrote: On 3/24/21 8:09 AM, Joel Stanley wrote: This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests the currently implemented behavior of the hash functionality. The tests are similar, but are cut/pasted instead of broken out into a

Re: [PATCH v2 10/10] Acceptance Tests: introduce CPU hotplug test

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > Even though there are qtest based tests for hotplugging CPUs (from > which this test took some inspiration from), this one adds checks > from a Linux guest point of view. > > It should also serve as an example for tests that follow a similar >

[PATCH v2 1/2] vhost-user-blk: use different event handlers on initialization

2021-03-24 Thread Denis Plotnikov
It is useful to use different connect/disconnect event handlers on device initialization and operation as seen from the further commit fixing a bug on device initialization. The patch refactor the code to make use of them: we don't rely any more on the VM state for choosing how to cleanup the

[PATCH v2 0/2] vhost-user-blk: fix bug on device disconnection during initialization

2021-03-24 Thread Denis Plotnikov
v2: * split the initial patch into two (Raphael) * rename init to realized (Raphael) * remove unrelated comment (Raphael) When the vhost-user-blk device lose the connection to the daemon during the initialization phase it kills qemu because of the assert in the code. The series fixes the

[PATCH v2 2/2] vhost-user-blk: perform immediate cleanup if disconnect on initialization

2021-03-24 Thread Denis Plotnikov
Commit 4bcad76f4c39 ("vhost-user-blk: delay vhost_user_blk_disconnect") introduced postponing vhost_dev cleanup aiming to eliminate qemu aborts because of connection problems with vhost-blk daemon. However, it introdues a new problem. Now, any communication errors during execution of

[Bug 1910723] Re: NULL pointer dereference issues in am53c974 SCSI host bus adapter

2021-03-24 Thread Mauro Matteo Cascella
I can confirm this is fixed now, thank you Mark. Patchset v2: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg06550.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910723 Title: NULL

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Gerd Hoffmann
Hi, > > +if (gd->cbowner[s]) { > > +/* ignore notifications about our own grabs */ > > +return; > > +} > > + > > + > > +switch (event->owner_change.reason) { > > +case GDK_SETTING_ACTION_NEW: > > +info = qemu_clipboard_info_new(>cbpeer, s); > > +

Re: [PATCH V4 4/7] hmp-commands: Add new HMP command for COLO passthrough

2021-03-24 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > Add hmp_colo_passthrough_add and hmp_colo_passthrough_del make user > can maintain COLO network passthrough list in human monitor. > > Signed-off-by: Zhang Chen > --- > hmp-commands.hx | 26 ++ > include/monitor/hmp.h |

[Bug 1921092] Re: qemu-system-arm multi core debug not working

2021-03-24 Thread Martin Schönstedt
** Description changed: Working with Zephyr RTOS, running a multi core sample on mps2_an521 works fine. Both cpus start. Trying to debug with options -s -S the second core fails to boot. Posted with explanation also at: https://github.com/zephyrproject-rtos/zephyr/issues/33635 + + only

Re: [PULL 0/5] Ui 20210323 patches

2021-03-24 Thread Peter Maydell
On Tue, 23 Mar 2021 at 15:39, Gerd Hoffmann wrote: > > The following changes since commit c95bd5ff1660883d15ad6e0005e4c8571604f51a: > > Merge remote-tracking branch 'remotes/philmd/tags/mips-fixes-20210322' into= > staging (2021-03-22 14:26:13 +) > > are available in the Git repository at:

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Daniel P . Berrangé
On Wed, Mar 24, 2021 at 12:22:42PM +0100, Lukas Straub wrote: > On Tue, 23 Mar 2021 19:09:15 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > > Hello Everyone, > > > These patches remove yank's dependency on qiochannel and always link it

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Lukas Straub
On Wed, 24 Mar 2021 11:36:13 + Daniel P. Berrangé wrote: > On Wed, Mar 24, 2021 at 12:22:42PM +0100, Lukas Straub wrote: > > On Tue, 23 Mar 2021 19:09:15 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > > > Hello Everyone,

[PATCH] qom: Fix default values in help

2021-03-24 Thread Markus Armbruster
Output of default values in device help is broken: $ ./qemu-system-x86_64 -S -display none -monitor stdio QEMU 5.2.50 monitor - type 'help' for more information (qemu) device_add pvpanic,help pvpanic options: events= - (default: (null)) ioport=-

Re: [PATCH v2 06/10] Acceptance Tests: make username/password configurable

2021-03-24 Thread Auger Eric
On 3/23/21 11:15 PM, Cleber Rosa wrote: > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa

Re: [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > The LinuxTest specifically targets users that need to interact with Linux > guests. So, it makes sense to give a connection by default, and avoid > requiring it as boiler-plate code. > > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH v2 08/10] tests/acceptance/virtiofs_submounts.py: remove launch_vm()

2021-03-24 Thread Auger Eric
Hi, On 3/23/21 11:15 PM, Cleber Rosa wrote: > The LinuxTest class' launch_and_wait() method now behaves the same way > as this test's custom launch_vm(), so let's just use the upper layer > (common) method. > > Signed-off-by: Cleber Rosa Reviewed-by: Eric Auger Eric > --- >

Re: [PATCH v4 2/3] aspeed: Integrate HACE

2021-03-24 Thread Philippe Mathieu-Daudé
On 3/24/21 8:09 AM, Joel Stanley wrote: > Add the hash and crypto engine model to the Aspeed socs. > > Reviewed-by: Andrew Jeffery > Signed-off-by: Joel Stanley > --- > v3: Rebase on upstream > v4: Update integration for soc-specific hace objects > --- > docs/system/arm/aspeed.rst | 2 +- >

[Bug 1921092] [NEW] qemu-system-arm multi core debug not working

2021-03-24 Thread Martin Schönstedt
Public bug reported: Working with Zephyr RTOS, running a multi core sample on mps2_an521 works fine. Both cpus start. Trying to debug with options -s -S the second core fails to boot. Posted with explanation also at: https://github.com/zephyrproject-rtos/zephyr/issues/33635 ** Affects: qemu

Re: [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

2021-03-24 Thread Viresh Kumar
On 24-03-21, 00:42, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/cover.1616570702.git.viresh.ku...@linaro.org/ > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Lukas Straub
On Tue, 23 Mar 2021 19:09:15 + Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > Hello Everyone, > > These patches remove yank's dependency on qiochannel and always link it in. > > Please Review. > > It would be useful if the cover letter or

Re: [PATCH] qom: Fix default values in help

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 12:41 PM Markus Armbruster wrote: > Output of default values in device help is broken: > > $ ./qemu-system-x86_64 -S -display none -monitor stdio > QEMU 5.2.50 monitor - type 'help' for more information > (qemu) device_add pvpanic,help > pvpanic options: >

Re: [PATCH v2 03/10] Python: add utility function for retrieving port redirection

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > Slightly different versions for the same utility code are currently > present on different locations. This unifies them all, giving > preference to the version from virtiofs_submounts.py, because of the > last tweaks added to it. > > While at

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > For users of the LinuxTest class, let's set up the VM with the port > redirection for SSH, instead of requiring each test to set the same also sets the network device to virtio-net. This may be worth mentioning here in the commit msg. >

Re: [PATCH v2 01/10] tests/acceptance/virtiofs_submounts.py: add missing accel tag

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > The tag is useful to select tests that depend/use a particular > feature. > > Signed-off-by: Cleber Rosa > Reviewed-by: Wainer dos Santos Moschetta > Reviewed-by: Willian Rampazzo > --- > tests/acceptance/virtiofs_submounts.py | 1 + > 1

Re: [PATCH v4 1/3] hw: Model ASPEED's Hash and Crypto Engine

2021-03-24 Thread Philippe Mathieu-Daudé
On 3/24/21 8:09 AM, Joel Stanley wrote: > The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1, > SHA2, RSA and other cryptographic algorithms. > > This initial model implements a subset of the device's functionality; > currently only direct access (non-scatter gather) hashing. >

Re: [PATCH v2 2/7] ui/vdagent: core infrastructure

2021-03-24 Thread Gerd Hoffmann
On Mon, Mar 22, 2021 at 11:27:17AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +if (vd->msgsize != msg->size + sizeof(*msg)) { > > > +/* FIXME: handle parse messages splitted into multiple chunks */ > > > +fprintf(stderr, "%s: size mismatch: chunk %d, msg %d (+%zd)\n", > > > +

[PATCH] gitignore: Update with some filetypes

2021-03-24 Thread Viresh Kumar
Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 75a4be07240f..eb2553026c5e 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,5 @@ GTAGS *~ *.ast_raw

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Alex Bennée
Alex Bennée writes: > Claudio Fontana writes: > >> On 3/23/21 11:50 PM, Alex Bennée wrote: > Moving up the build chain to the revert I now get: > > ./qemu-system-aarch64 -M virt,gic=host -cpu host -accel kvm -m 2048 > -net none -nographic -kernel >

[PATCH] iotests: Fix typo in iotest 051

2021-03-24 Thread Tao Xu
There is an typo in iotest 051, correct it. Signed-off-by: Tao Xu --- tests/qemu-iotests/051| 2 +- tests/qemu-iotests/051.pc.out | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index f92161d8ef..1595babe82 100755

Re: [PATCH] qom: Fix default values in help

2021-03-24 Thread Thomas Huth
On 24/03/2021 09.41, Markus Armbruster wrote: Output of default values in device help is broken: $ ./qemu-system-x86_64 -S -display none -monitor stdio QEMU 5.2.50 monitor - type 'help' for more information (qemu) device_add pvpanic,help pvpanic options: events=

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Paolo Bonzini
On 24/03/21 00:35, Philippe Mathieu-Daudé wrote: Hmmm does this assert() matches your comment? -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..41cbee77d14 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1130,6 +1130,8 @@ Object *qdev_get_machine(void) {

[Bug 1909247] Re: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c

2021-03-24 Thread Mauro Matteo Cascella
Hello, Thank you all for your comments. Both patches (PJP/comment#8 - Mark/comment#9) seem to properly fix the UAF reported by Alexander in comment #6. However, I'm still able to reproduce the heap-bof from the above hw-esp-oob-issues.zip: ./x86_64-softmmu/qemu-system-x86_64 -m 512 \ -drive

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Thomas Huth
On 24/03/2021 11.10, Thomas Huth wrote: On 24/03/2021 00.35, Philippe Mathieu-Daudé wrote: [...] Hmmm does this assert() matches your comment? -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..41cbee77d14 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1130,6

Re: [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-24 Thread BALATON Zoltan
On Wed, 24 Mar 2021, David Gibson wrote: On Tue, Mar 23, 2021 at 02:31:07PM +0100, BALATON Zoltan wrote: On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: [snip] +static void setup_mem_windows(MV64361State *s, uint32_t val) +{ +

Re: qdev: Regarding lazy ISA bridge creation

2021-03-24 Thread Cédric Le Goater
On 3/24/21 12:13 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > I'm trying to understand the comment you added in commit > 3495b6b6101 ("ppc/pnv: add a ISA bus"): > > /* let isa_bus_new() create its own bridge on SysBus otherwise > * devices specified on the command line won't find the

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-24 Thread Alberto Garcia
On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> static int bdrv_reopen_prepare(BDRVReopenState *reopen_state, >> BlockReopenQueue *queue, >> - Transaction *set_backings_tran, Error >> **errp); >> +

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Laurent Vivier
Le 24/03/2021 à 12:26, Andreas Krebbel a écrit : > On 3/24/21 11:28 AM, Laurent Vivier wrote: >> Le 24/03/2021 à 10:17, David Hildenbrand a écrit : >>> On 24.03.21 09:51, Andreas Krebbel wrote: The sigreturn SVC is put onto the stack by the emulation code.  Hence the address of it should

[PATCH RFC v2 1/6] hw/pci/pci_host: Add iommu property for pci host

2021-03-24 Thread Wang Xingang
From: Xingang Wang The pci host iommu property is useful to check whether the iommu is enabled on the pci root bus. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/pci/pci.c | 18 +- hw/pci/pci_host.c | 2 ++ include/hw/pci/pci.h | 1 +

  1   2   3   4   >