Re: [RFC PATCH v2] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-17 Thread David Gibson
On Sat, May 15, 2021 at 09:21:48AM +0530, Vaibhav Jain wrote: > Thanks for looking into this patch David > > David Gibson writes: > > > On Thu, May 06, 2021 at 08:19:24AM +0530, Vaibhav Jain wrote: > >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for > >> spapr nvdimms. This

Re: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:55PM +0800, Yanan Wang wrote: > We create and initialize a cpuobj for each present cpu in > machvirt_init(). Now we also initialize the cpu member of > structure CPUArchId for each present cpu in the function. > > This will be used to determine whether a cpu is

[PATCH 12/21] block/copy-before-write: bdrv_cbw_append(): replace child at last

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Refactor the function to replace child at last. Thus we don't need to revert it and code is simplified. block-copy state initilization being done before replacing the child doesn't need any drained section. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 33

[PATCH 00/21] block: publish backup-top filter

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Hi all! We have image fleecing scheme to export point-in-time state of active disk (iotest 222): backup(sync=none) ┌───┐ ▼ │ ┌┐

Re: [PATCH updated v2] spapr: Fix EEH capability issue on KVM guest for PCI passthru

2021-05-17 Thread David Gibson
On Fri, May 14, 2021 at 12:03:10PM +1000, Oliver O'Halloran wrote: > On Thu, May 13, 2021 at 2:22 PM David Gibson > wrote: > > > > On Wed, May 05, 2021 at 08:18:27PM +0530, Mahesh Salgaonkar wrote: > > > With upstream kernel, especially after commit 98ba956f6a389 > > > ("powerpc/pseries/eeh:

[PATCH 17/21] block/block-copy: switch to fully set bitmap by default

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
block-copy has a bit inconvenient interface around dirty bitmap: user should get pointer to it and than set by hand. We do need a possibility to share the bitmap with backup job. But default of empty bitmap is strange. Switch to full-set bitmap by default. This way we will not care about setting

Re: [PATCH v2] block: Improve backing file validation

2021-05-17 Thread lizhij...@fujitsu.com
On 12/05/2021 23.10, Kevin Wolf wrote: > Am 11.05.2021 um 10:35 hat Daniel P. Berrangé geschrieben: >> On Tue, May 11, 2021 at 01:55:18PM +0800, Li Zhijian wrote: >>> void bdrv_img_create(const char *filename, const char *fmt, >>>const char *base_filename, const char

[PULL 07/20] hw/block/nvme: rename __nvme_zrm_open

2021-05-17 Thread Klaus Jensen
From: Klaus Jensen Get rid of the (reserved) double underscore use. Rename the "generic" zone open function to nvme_zrm_open_flags() and add a generic `int flags` argument instead which allows more flags to be easily added in the future. There is at least one TP under standardization that would

[PULL 06/20] hw/block/nvme: align with existing style

2021-05-17 Thread Klaus Jensen
From: Gollu Appalanaidu While QEMU coding style prefers lowercase hexadecimals in constants, the NVMe subsystem uses the format from the NVMe specifications in comments, i.e. 'h' suffix instead of '0x' prefix. Fix this up across the code base. Signed-off-by: Gollu Appalanaidu [k.jensen:

[PULL 03/20] hw/block/nvme: consider metadata read aio return value in compare

2021-05-17 Thread Klaus Jensen
From: Gollu Appalanaidu Currently in compare command metadata aio read blk_aio_preadv return value ignored. Consider it and complete the block accounting. Signed-off-by: Gollu Appalanaidu Fixes: 0a384f923f51 ("hw/block/nvme: add compare command") Signed-off-by: Klaus Jensen ---

Re: [PATCH v26 00/20] i386 cleanup PART 2

2021-05-17 Thread Claudio Fontana
On 5/12/21 9:17 AM, Philippe Mathieu-Daudé wrote: > On 5/6/21 11:33 AM, Philippe Mathieu-Daudé wrote: >> On 5/6/21 11:10 AM, Philippe Mathieu-Daudé wrote: >>> On 5/6/21 9:55 AM, Claudio Fontana wrote: On 5/5/21 9:31 PM, Eduardo Habkost wrote: > On Wed, May 05, 2021 at 02:15:29PM +0200,

[PATCH] block/copy-on-read: use bdrv_drop_filter() and drop s->active

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Now, after huge update of block graph permission update algorithm, we don't need this workaround with active state of the filter. Drop it and use new smart bdrv_drop_filter() function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 33 + 1

Re: [PATCH] target/ppc: Implement ISA v3.1 wait variants

2021-05-17 Thread Nicholas Piggin
Excerpts from David Gibson's message of May 17, 2021 3:39 pm: > On Mon, May 17, 2021 at 12:46:51PM +1000, Nicholas Piggin wrote: >> ISA v3.1 adds new variations of wait, specified by the WC field. These >> are not compatible with the wait 0 implementation, because they add >> additional conditions

Re: [PATCH v2 0/4] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci

2021-05-17 Thread Greg Kurz
On Wed, 12 May 2021 17:05:53 +0100 Stefan Hajnoczi wrote: > On Fri, May 07, 2021 at 06:59:01PM +0200, Greg Kurz wrote: > > Now that virtio-scsi-pci and virtio-blk-pci map 1 virtqueue per vCPU, > > a serious slow down may be observed on setups with a big enough number > > of vCPUs. > > > >

[PULL 01/20] hw/block/nvme: remove redundant invalid_lba_range trace

2021-05-17 Thread Klaus Jensen
From: Gollu Appalanaidu Currently pci_nvme_err_invalid_lba_range trace is called individually at each nvme_check_bounds() call site. Move the trace event to nvme_check_bounds() and remove the redundant events. Signed-off-by: Gollu Appalanaidu Reviewed-by: Philippe Mathieu-Daudé [k.jensen:

[PATCH 04/21] qdev: allow setting drive property for realized device

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blockdev-reopen command. So, we want do it with help of qom-set. Intended usage: 1. blockdev-add, creating the filter, which child is at top node A, attached to some guest block

[PATCH 20/21] qapi: publish copy-before-write filter

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 2ea294129e..f8fbcb6416 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json

[PATCH 18/21] block/block-copy: make setting progress optional

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Now block-copy will crash if user don't set progress meter by block_copy_set_progress_meter(). copy-before-write filter will be used in separate of backup job, and it doesn't want any progress meter (for now). So, allow not setting it. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[PATCH 08/21] block/backup: stricter backup_calculate_cluster_size()

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's just error-out, it's simpler and safer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/block/backup.c b/block/backup.c index

[PATCH 10/21] block/copy-before-write: relax permission requirements when no parents

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
We are going to publish copy-before-write filter. So, user should be able to create it with blockdev-add first, specifying both filtered and target children. And then do blockdev-reopen, to actually insert the filter where needed. Currently, filter unshares write permission unconditionally on

[PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment

2021-05-17 Thread Philippe Mathieu-Daudé
The RISCV CPU is migratable since commit f7697f0e629 ("target/riscv: Add basic vmstate description of CPU"), so remove an obsolete comment which is now incorrect. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.c | 1 - 1 file changed, 1 deletion(-)

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:57PM +0800, Yanan Wang wrote: > When building ACPI tables regarding CPUs we should always build > them for the number of possible CPUs, not the number of present > CPUs. So we create gicc nodes in MADT for possible cpus and then > ensure only the present CPUs are

Re: [RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-17 Thread David Gibson
On Sat, May 15, 2021 at 01:07:59PM +0530, Vaibhav Jain wrote: > Add support for H_SCM_PERFORMANCE_STATS described at [1] for > spapr nvdimms. This enables guest to fetch performance stats[2] like > expected life of an nvdimm ('MemLife ') etc and display them to the > user. Linux kernel support for

Re: [PATCH] target/ppc: Implement ISA v3.1 wait variants

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 12:46:51PM +1000, Nicholas Piggin wrote: > ISA v3.1 adds new variations of wait, specified by the WC field. These > are not compatible with the wait 0 implementation, because they add > additional conditions that cause the processor to resume, which can > cause software to

[PATCH 19/21] block/copy-before-write: make public block driver

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Finally, copy-before-write gets own .bdrv_open and .bdrv_close handlers, block_init() call and becomes available through bdrv_open(). To achieve this: - cbw_init gets unused flags argument and becomes cbw_open - block_copy_state_free() call moved to new cbw_close() - in bdrv_cbw_append: -

A bug of Monitor Chardev ?

2021-05-17 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
We find a race during QEMU starting, which would case the QEMU process coredump. | | [1] create MON chardev | qemu_create_early_backends | chardev_init_func |

[PATCH 05/21] block: rename backup-top to copy-before-write

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". While updating comments in 283 iotest, drop and rephrase also things about ".active", as this field is now dropped, and filter

[PATCH 03/21] qdev-properties: PropertyInfo: add realized_set_allowed field

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Add field, so property can declare support for setting the property when device is realized. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/hw/qdev-properties.h | 1 + hw/core/qdev-properties.c| 6 +++--- 2 files changed, 4 insertions(+), 3

Re: [RFC PATCH v3 8/9] hw/arm/virt-acpi-build: Generate PPTT table

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:59PM +0800, Yanan Wang wrote: > From: Andrew Jones > > Add the Processor Properties Topology Table (PPTT) to expose > CPU topology information defined by users to ACPI guests. > > Note, a DT-boot Linux guest with a non-flat CPU topology will > see socket and core

Re: [RFC PATCH v3 1/4] vl.c: Add -smp, clusters=* command line support for ARM cpu

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:32:25PM +0800, Yanan Wang wrote: > In implementations of ARM architecture, at most there could be a > cpu hierarchy like "sockets/dies/clusters/cores/threads" defined. > For example, ARM64 server chip Kunpeng 920 totally has 2 sockets, > 2 NUMA nodes (also means cpu

[PATCH 06/21] block/backup: drop support for copy_range

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
copy_range is not a default behavior since 6a30f663d4c0b3c, and it's now available only though x-perf experimantal argument, so it's OK to drop it. Even when backup is used to copy disk to same filesystem, and filesystem supports zero-copy copy_range, copy_range is probably not what we want for

[PATCH 15/21] block/copy-before-write: cbw_init(): use file child after attaching

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
In the next commit we'll get rid of source argument of cbw_init(). Prepare to it now, to make next commit simpler: move the code block that uses source below attaching the child and use bs->file->bs instead of source variable. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 09:55:31AM +0200, Greg Kurz wrote: > On Mon, 17 May 2021 16:23:56 +1000 > David Gibson wrote: > > > On Sat, May 15, 2021 at 01:07:59PM +0530, Vaibhav Jain wrote: > [...] > > > +rc = (result == MEMTX_OK) ? > > > +scm_perf_check_rr_buffer(perfstats, addr, size,

Re: [RFC PATCH v3 3/9] hw/arm/virt: Add cpu-map to device tree

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:54PM +0800, Yanan Wang wrote: > From: Andrew Jones > > Support device tree CPU topology descriptions. > > In accordance with the Devicetree Specification, the Linux Doc > "arm/cpus.yaml" requires that cpus and cpu nodes in the DT are > present. And we meet the

[PATCH 16/21] block/copy-before-write: cbw_init(): use options

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
One more step closer to .bdrv_open(): use options instead of plain arguments. Move to bdrv_open_child() calls, native for drive open handlers. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 37 - 1 file changed, 20 insertions(+),

Re: making a qdev bus available from a (non-qtree?) device

2021-05-17 Thread Klaus Jensen
On May 13 15:02, Stefan Hajnoczi wrote: On Wed, May 12, 2021 at 02:02:50PM +0200, Markus Armbruster wrote: Klaus Jensen writes: > I can then call `qdev_set_parent_bus()` and set the parent bus to the > bus creates in the nvme-subsys device. This solves the problem since > the namespaces are

Re: [RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-17 Thread Greg Kurz
On Mon, 17 May 2021 16:23:56 +1000 David Gibson wrote: > On Sat, May 15, 2021 at 01:07:59PM +0530, Vaibhav Jain wrote: [...] > > +rc = (result == MEMTX_OK) ? > > +scm_perf_check_rr_buffer(perfstats, addr, size, _stats) : > > +H_PRIVILEGE; > > This is a bit cryptic. Just

Re: [RFC PATCH v3 9/9] hw/arm/virt: Add separate -smp parsing function for ARM machines

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:29:00PM +0800, Yanan Wang wrote: > The cpu hierarchy topology information parsed out from QEMU -smp > command line will be exposed to guest kernel through ACPI and DT > since machine type 6.1, so we will expect more detailed topology > descriptions and will be more

Re: [PATCH v2 08/12] tests/vm: convert centos VM recipe to CentOS 8

2021-05-17 Thread Daniel P . Berrangé
On Fri, May 14, 2021 at 02:31:50PM -0300, Willian Rampazzo wrote: > On Fri, May 14, 2021 at 9:05 AM Daniel P. Berrangé > wrote: > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/vm/centos | 17 - > > 1 file changed, 8 insertions(+), 9 deletions(-) > > > > diff --git

Re: [RFC PATCH v3 2/9] device_tree: Add qemu_fdt_add_path

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:53PM +0800, Yanan Wang wrote: > From: Andrew Jones Hi Yanan, This looks good, but the authorship is no longer correct. You've completely rewritten it, so I think the most I deserve is a Co-developed-by and maybe even just a Suggested-by. When changing the

[PATCH 07/21] block-copy: always set BDRV_REQ_SERIALISING flag

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
It won't hurt in common case, so let's not bother with detecting image fleecing. Also, we want to simplify initialization interface of copy-before-write filter as we are going to make it public. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.h | 2 +-

Re: making a qdev bus available from a (non-qtree?) device

2021-05-17 Thread Klaus Jensen
On May 12 14:02, Markus Armbruster wrote: Klaus Jensen writes: Hi all, I need some help with grok'ing qdev busses. Stefan, Michael - David suggested on IRC that I CC'ed you guys since you might have solved a similar issue with virtio devices. I've tried to study how that works, but I'm not

[PATCH 01/21] block: introduce bdrv_replace_child_bs()

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 ++ block.c | 36 2 files changed, 38 insertions(+) diff --git a/include/block/block.h

[PATCH 02/21] block: introduce blk_replace_bs

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Add function to change bs inside blk. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 1 + block/block-backend.c | 8 2 files changed, 9 insertions(+) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index

[PATCH 11/21] block/copy-before-write: use file child instead of backing

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
We are going to publish copy-before-write filter, and there no public backing-child-based filter in Qemu. No reason to create a precedent, so let's refactor copy-before-write filter instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 40

[PATCH 21/21] itotests/222: add test-case for copy-before-write filter

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
New fleecing method becomes available: copy-before-write filter. Actually we don't need backup job to setup image fleecing. Add test fore new recommended way of image fleecing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/222 | 56 ++---

[PATCH 13/21] block/copy-before-write: introduce cbw_init()

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
Move part of bdrv_cbw_append() to new function cbw_open(). It's an intermediate step for adding noramal .bdrv_open() handler to the filter. With this commit no logic is changed, but we have a function which will be turned into .bdrv_open() handler in future commit. Signed-off-by: Vladimir

Re: [RFC PATCH v3 4/4] hw/arm/virt: Parse -smp cluster parameter in virt_smp_parse

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:32:28PM +0800, Yanan Wang wrote: > There is a separate function virt_smp_parse() in hw/virt/arm.c used > to parse cpu topology for the ARM machines. So add parsing of -smp > cluster parameter in it, then total number of logical cpus will be > calculated like: max_cpus =

[PATCH 09/21] block/backup: move cluster size calculation to block-copy

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
The main consumer of cluster-size is block-copy. Let's calculate it here instead of passing through backup-top. We are going to publish copy-before-write filter soon, so it will be created through options. But we don't want for now to make explicit option for cluster-size, let's continue to

[PATCH 14/21] block/copy-before-write: cbw_init(): rename variables

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
One more step closer to real .bdrv_open() handler: use more usual names for bs being initialized and its state. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-17 Thread Gerd Hoffmann
On Sat, May 15, 2021 at 04:06:23PM +0800, Bibo Mao wrote: > From: maobibo > > pci memory bar size should be aligned with page size, else it will > not be effective memslot when running in kvm mode. > > This patch set qxl pci rom size aligned with page size of host > machine. What is the exact

Re: [RFC PATCH v3 7/9] hw/acpi/aml-build: Add Processor hierarchy node structure

2021-05-17 Thread Andrew Jones
On Sun, May 16, 2021 at 06:28:58PM +0800, Yanan Wang wrote: > Add a generic API to build Processor hierarchy node structure (Type 0), > which is strictly consistent with descriptions in ACPI 6.2: 5.2.29.1. > > This function will be used to build ACPI PPTT table for cpu topology. > >

[PATCH v2 08/26] s390x/tcg: Simplify vfll32() handling

2021-05-17 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 6 +- target/s390x/vec_fpu_helper.c | 21 + 3 files changed, 6 insertions(+), 22 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h

[PATCH v2 06/26] s390x/tcg: Simplify vftci64() handling

2021-05-17 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 7 ++- target/s390x/vec_fpu_helper.c | 29 +++-- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/target/s390x/helper.h

[PATCH v2 26/26] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

2021-05-17 Thread David Hildenbrand
TCG implements everything we need to run basic z14 OS+software. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 4 ++-- target/s390x/gen-features.c | 15 +-- 3 files changed, 14 insertions(+),

[PATCH v2 15/26] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *

2021-05-17 Thread David Hildenbrand
In addition to 32/128bit variants, we also have to support the "Signal-on-QNaN (SQ)" bit. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 12 +++ target/s390x/translate_vx.c.inc | 57 - target/s390x/vec_fpu_helper.c | 64

[PATCH v2 12/26] s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL

2021-05-17 Thread David Hildenbrand
Fortunately, we only need the Doubleword implementation. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.c.inc | 50 + 2 files changed, 52 insertions(+) diff --git

Re: [PATCH 03/21] qdev-properties: PropertyInfo: add realized_set_allowed field

2021-05-17 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 15:40, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: Add field, so property can declare support for setting the property when device is realized. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy ---  

[PATCH v2 24/26] s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)

2021-05-17 Thread David Hildenbrand
For IEEE functions, we can reuse the softfloat implementations. For the other functions, implement it generically for 32bit/64bit/128bit - carefully taking care of all weird special cases according to the tables defined in the PoP. Signed-off-by: David Hildenbrand --- target/s390x/helper.h

Re: [PATCH 1/3] virtiofsd: Find original inode ID of mount points

2021-05-17 Thread Vivek Goyal
On Wed, May 12, 2021 at 02:55:42PM +0200, Max Reitz wrote: > Mount point directories represent two inodes: On one hand, they are a > normal directory on their parent filesystem. On the other, they are the > root node of the filesystem mounted there. Thus, they have two inode > IDs. > > Right

[PATCH 1/5] docs: fix references to docs/devel/tracing.rst

2021-05-17 Thread Stefano Garzarella
Commit e50caf4a5c ("tracing: convert documentation to rST") converted docs/devel/tracing.txt to docs/devel/tracing.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/tracing.txt/tracing.rst/ $(git grep -l docs/devel/tracing.txt)

[PATCH 0/5] docs: fix references to files converted to rST

2021-05-17 Thread Stefano Garzarella
Trivial patches that fix references to old files in docs/ converted to rST. Broken references found running: for f in $(git grep -oh "docs.*txt") do test -f "$f" || echo "$f not exists" done Stefano Garzarella (5): docs: fix references to docs/devel/tracing.rst docs: fix

[PATCH 3/5] docs: fix references to docs/devel/build-system.rst

2021-05-17 Thread Stefano Garzarella
Commit a14f0bf165 ("docs: convert build system documentation to rST") converted docs/devel/build-system.txt to docs/devel/build-system.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/build-system.txt/build-system.rst/ \ $(git

[PATCH 2/5] docs: fix references to docs/devel/atomics.rst

2021-05-17 Thread Stefano Garzarella
Commit 15e8699f00 ("atomics: convert to reStructuredText") converted docs/devel/atomics.txt to docs/devel/atomics.rst. We still have several references to the old file, so let's fix them with the following command: sed -i s/atomics.txt/atomics.rst/ $(git grep -l docs/devel/atomics.txt)

[PULL 02/29] tests/docker: make executable an optional argument to "update"

2021-05-17 Thread Alex Bennée
We're going to extend the abilities of the command shortly. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-4-alex.ben...@linaro.org> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 9f464cb92c..820423d718 100644 ---

Re: [PATCH 0/5] docs: fix references to files converted to rST

2021-05-17 Thread Philippe Mathieu-Daudé
On 5/17/21 5:16 PM, Stefano Garzarella wrote: > Trivial patches that fix references to old files in docs/ converted > to rST. > > Broken references found running: > > for f in $(git grep -oh "docs.*txt") > do > test -f "$f" || echo "$f not exists" > done > > Stefano

[PULL 01/29] tests/docker: fix copying of executable in "update"

2021-05-17 Thread Alex Bennée
We have the same symlink chasing problem when doing an "update" operation. Fix that. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Inspired-by: 5e33f7fead ("tests/docker: better handle symlinked libs") Message-Id: <20210512102051.12134-3-alex.ben...@linaro.org> diff --git

[PULL 09/29] hw/tricore: Add testdevice for tests in tests/tcg/

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Reviewed-by: Alex

[PULL 13/29] tests/tcg/tricore: Add bmerge test

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-8-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-18-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL 04/29] tests/docker: add "fetch" sub-command

2021-05-17 Thread Alex Bennée
This simply wraps up fetching a build from the registry and tagging it as the local build. Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-6-alex.ben...@linaro.org> diff --git a/tests/docker/docker.py b/tests/docker/docker.py index

[PULL 06/29] tests/tcg: Use Hexagon Docker image

2021-05-17 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] [AJB: add container_hosts] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé

[PULL 15/29] tests/tcg/tricore: Add dvstep test

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-10-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-20-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL 11/29] configure: Emit HOST_CC to config-host.mak

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann this is needed by the tricore-tcg-tests as tricore-gcc is not easily available. Thus we rely on the HOST_CC to do the preprocessing of the tricore assembly files. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id:

[PULL 10/29] tests/tcg/tricore: Add build infrastructure

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann this includes the Makefile and linker script to build all the tests. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210305170045.869437-5-kbast...@mail.uni-paderborn.de> Message-Id:

[PULL 20/29] tests/tcg/tricore: Add msub test

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-15-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-25-alex.ben...@linaro.org> diff --git

[PULL 24/29] tests/tcg: don't allow clang as a cross compiler

2021-05-17 Thread Alex Bennée
Currently there are two problems. The first is clang generates a preamble (that is always executed) to stack xmm registers. This causes a ILLOP on the x86_64 softmmu tests as SSE isn't enabled. The second is the inline assembler in test-i386.c breaks clangs compiler and I don't know how to fix

Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory

2021-05-17 Thread Stefano Garzarella
On Mon, May 17, 2021 at 08:32:46PM +0800, Xie Yongji wrote: The symbol address_space_memory are already declared in include/exec/address-spaces.h. So let's add this header file and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h. Signed-off-by: Xie Yongji Reviewed-by:

Re: [PATCH v5 1/1] docs/devel: Add VFIO device migration documentation

2021-05-17 Thread Tarun Gupta (SW-GPU)
Hi Alex, Cornelia, Just wanted to confirm that this patch will be pulled in QEMU 6.1, right? Thanks, Tarun On 4/18/2021 5:52 PM, Tarun Gupta wrote: Document interfaces used for VFIO device migration. Added flow of state changes during live migration with VFIO device. Reviewed-by: Cornelia

Re: [PATCH 08/21] block/backup: stricter backup_calculate_cluster_size()

2021-05-17 Thread Max Reitz
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: No reason to tolerate bdrv_get_info() errors except for ENOTSUP. Let's just error-out, it's simpler and safer. Hm, doesn’t look that much simpler to me. Not sure how much safer it is, because the point was that in the target_does_cow

RE: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-17 Thread Salil Mehta
> From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei@nongnu.org] > On Behalf Of Yanan Wang > Sent: Sunday, May 16, 2021 11:29 AM > To: Peter Maydell ; Andrew Jones > ; Michael S . Tsirkin ; Igor Mammedov > ; Shannon Zhao ; Alistair > Francis ; David Gibson > ; qemu-devel@nongnu.org;

Re: [PULL 00/29] testing and plugin updates

2021-05-17 Thread Alex Bennée
Alex Bennée writes: > The following changes since commit 6005ee07c380cbde44292f5f6c96e7daa70f4f7d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2021-05-16 17:22:46 +0100) > > are available in the Git repository at: > >

Re: [PATCH v12 6/8] arm64: kvm: Expose KVM_ARM_CAP_MTE

2021-05-17 Thread Marc Zyngier
On Mon, 17 May 2021 13:32:37 +0100, Steven Price wrote: > > It's now safe for the VMM to enable MTE in a guest, so expose the > capability to user space. > > Signed-off-by: Steven Price > --- > arch/arm64/kvm/arm.c | 9 + > arch/arm64/kvm/sys_regs.c | 3 +++ > 2 files changed, 12

Re: [PATCH v12 8/8] KVM: arm64: Document MTE capability and ioctl

2021-05-17 Thread Marc Zyngier
On Mon, 17 May 2021 13:32:39 +0100, Steven Price wrote: > > A new capability (KVM_CAP_ARM_MTE) identifies that the kernel supports > granting a guest access to the tags, and provides a mechanism for the > VMM to enable it. > > A new ioctl (KVM_ARM_MTE_COPY_TAGS) provides a simple way for a VMM

Re: [PATCH v3 3/8] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c

2021-05-17 Thread John Snow
On 5/17/21 1:49 PM, Philippe Mathieu-Daudé wrote: Some machines use floppy controllers via the SysBus interface, and don't need to pull in all the ISA code. Extract the ISA specific code to a new unit: fdc-isa.c, and add a new Kconfig symbol: "FDC_ISA". Reviewed-by: John Snow Acked-by: Mark

[PULL 02/59] linux-user: strace now handles unshare syscall args correctly

2021-05-17 Thread Laurent Vivier
From: Matus Kysel Syscall unshare did not have custom print function for strace, but it's argument is same as flags in clone syscall, so it can be easily implemented. Also updated missing flags from clone_flags. Signed-off-by: Matus Kysel Reviewed-by: Laurent Vivier Message-Id:

[PULL 10/59] linux-user: Pass CPUArchState to do_sigaltstack

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Now that we have exactly one call, it's easy to pass in env instead of passing in the sp value. Use target_save_altstack, which required env. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-4-richard.hender...@linaro.org> Signed-off-by: Laurent

[PULL 29/59] linux-user/sparc: Add 64-bit support to fpu save/restore

2021-05-17 Thread Laurent Vivier
From: Richard Henderson The shape of the kernel's __siginfo_fpu_t is dependent on the cpu type, not the abi. Which is weird, but there ya go. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-23-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 23/59] linux-user/sparc: Split out save_reg_win

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-17-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PULL 32/59] tests/tcg/sparc64: Re-enable linux-test

2021-05-17 Thread Laurent Vivier
From: Richard Henderson It passes now that we support signals properly. Signed-off-by: Richard Henderson Message-Id: <20210426025334.1168495-26-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- tests/tcg/sparc64/Makefile.target | 7 +-- 1 file changed, 1 insertion(+), 6

[PULL 34/59] linux-user/s390x: Use uint16_t for signal retcode

2021-05-17 Thread Laurent Vivier
From: Richard Henderson Using the right type simplifies the frame setup. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 9 - 1 file

[PATCH v4 9/9] docs: update the documentation about schema configuration

2021-05-17 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Tested-by: John Snow --- docs/devel/qapi-code-gen.txt | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt

Re: [Qemu-devel] [PATCH 7/7] target/xtensa: move non-HELPER functions to helper.c

2021-05-17 Thread Max Filippov
On Mon, May 17, 2021 at 9:54 AM Philippe Mathieu-Daudé wrote: > > On 5/17/21 5:35 PM, Max Filippov wrote: > > On Mon, May 17, 2021 at 8:25 AM Max Filippov wrote: > >> > >> On Mon, May 17, 2021 at 6:10 AM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> On 5/17/21 2:11 PM, Max Filippov wrote: >

[PULL 17/29] tests/tcg/tricore: Add fmul test

2021-05-17 Thread Alex Bennée
From: Bastian Koppelmann Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20210305170045.869437-12-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-22-alex.ben...@linaro.org> diff --git

Re: [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h

2021-05-17 Thread Lucas Mateus Martins Araujo e Castro
On 17/05/2021 00:58, David Gibson wrote: On Thu, May 13, 2021 at 06:44:01PM -0500, Richard Henderson wrote: 65;6401;1c> On 5/13/21 9:03 AM, Lucas Mateus Martins Araujo e Castro wrote: tlb_set_page is called by many ppc_hash64_handle_mmu_fault, ppc_radix64_handle_mmu_fault and

Re: [PULL 00/29] testing and plugin updates

2021-05-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210517161022.13984-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210517161022.13984-1-alex.ben...@linaro.org Subject: [PULL 00/29] testing and

Re: [PATCH 1/3] virtiofsd: Find original inode ID of mount points

2021-05-17 Thread Max Reitz
On 17.05.21 16:57, Vivek Goyal wrote: On Wed, May 12, 2021 at 02:55:42PM +0200, Max Reitz wrote: Mount point directories represent two inodes: On one hand, they are a normal directory on their parent filesystem. On the other, they are the root node of the filesystem mounted there. Thus, they

Re: [RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick

2021-05-17 Thread Eugenio Perez Martin
On Tue, Mar 16, 2021 at 9:07 AM Jason Wang wrote: > > > 在 2021/3/16 上午3:48, Eugenio Pérez 写道: > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-shadow-virtqueue.c | 11 ++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git

Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment

2021-05-17 Thread Richard Henderson
On 5/17/21 2:08 AM, Philippe Mathieu-Daudé wrote: The RISCV CPU is migratable since commit f7697f0e629 ("target/riscv: Add basic vmstate description of CPU"), so remove an obsolete comment which is now incorrect. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v3 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

2021-05-17 Thread Philippe Mathieu-Daudé
Series fully reviewed. Hi, The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine). This series clean that by extracting each device in its own file, adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.

[PATCH v3 1/8] hw/block/fdc: Replace disabled fprintf() by trace event

2021-05-17 Thread Philippe Mathieu-Daudé
Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c| 7 +-- hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index

  1   2   3   4   5   6   7   >