[RFC PATCH 5/7] target/i386: Introduce AMD X86XSaveArea sub-union

2021-05-20 Thread David Edmondson
AMD stores the pkru_state at a different offset to Intel. Signed-off-by: David Edmondson --- target/i386/cpu.h | 17 +++-- target/i386/kvm/kvm.c | 3 ++- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index

[PATCH 0/1] virtio: disable partitions scanning for no partitions block

2021-05-20 Thread Yury Kamenev
Some virtio blocks definitely have no partitions and should not be scanned. Yury Kamenev (1): virtio: disable partitions scanning for no partitions block hw/block/virtio-blk.c | 4 include/hw/virtio/virtio-blk.h | 1 +

Re: [PATCH v12 3/8] arm64: mte: Sync tags for pages where PTE is untagged

2021-05-20 Thread Steven Price
On 20/05/2021 13:25, Catalin Marinas wrote: > On Thu, May 20, 2021 at 12:55:21PM +0100, Steven Price wrote: >> On 19/05/2021 19:06, Catalin Marinas wrote: >>> On Mon, May 17, 2021 at 01:32:34PM +0100, Steven Price wrote: A KVM guest could store tags in a page even if the VMM hasn't mapped

Re: [PATCH 24/24] target/ppc: Restrict ppc_cpu_tlb_fill to TCG

2021-05-20 Thread Bruno Piazera Larsen
On 18/05/2021 17:11, Richard Henderson wrote: This function is used by TCGCPUOps, and is thus TCG specific. Signed-off-by: Richard Henderson --- target/ppc/mmu_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index

Re: [RFC PATCH v4 0/7] Use ACPI PCI hot-plug for Q35

2021-05-20 Thread Igor Mammedov
On Thu, 13 May 2021 08:26:35 +0200 Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > This way maintainers

[RFC PATCH 1/7] target/i386: Declare constants for XSAVE offsets

2021-05-20 Thread David Edmondson
Declare and use manifest constants for the XSAVE state component offsets. Signed-off-by: David Edmondson --- target/i386/cpu.h | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index e6836393f7..1fb732f366

[PATCH 7/9] target/arm: Make FPSCR.LTPSIZE writable for MVE

2021-05-20 Thread Peter Maydell
The M-profile FPSCR has an LTPSIZE field, but if MVE is not implemented it is read-only and always reads as 4; this is how QEMU currently handles it. Make the field writable when MVE is implemented. We can safely add the field to the MVE migration struct because currently no CPUs enable MVE and

[PATCH 3/9] target/arm: Move fpsp/fpdp isar check into callers of do_vfp_2op_sp/dp

2021-05-20 Thread Peter Maydell
The do_vfp_2op_sp() and do_vfp_2op_dp() functions currently check whether floating point is supported via the aa32_fpdp_v2 and aa32_fpsp_v2 isar checks. For v8.1M MVE support, the VMOV_reg trans functions (but not any of the others) need to update this to also allow the insn if MVE is

[PATCH 9/9] target/arm: Allow board models to specify initial NS VTOR

2021-05-20 Thread Peter Maydell
Currently we allow board models to specify the initial value of the Secure VTOR register, using an init-svtor property on the TYPE_ARMV7M object which is plumbed through to the CPU. Allow board models to also specify the initial value of the Non-secure VTOR via a similar init-nsvtor property.

[PATCH 5/9] target/arm: Fix return values in fp_sysreg_checks()

2021-05-20 Thread Peter Maydell
The fp_sysreg_checks() function is supposed to be returning an FPSysRegCheckResult, which is an enum with three possible values. However, three places in the function "return false" (a hangover from a previous iteration of the design where the function just returned a bool). Make these return

Re: [PATCH v2 6/7] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: By adding acquire/release pairs, we ensure that .ret and .error_is_read fields are written by block_copy_dirty_clusters before .finished is true. As I already said, please, can we live with one mutex for now? finished, ret, error_is_read,

[RFC PATCH v2] gitlab: add special rule for the hexagon container

2021-05-20 Thread Alex Bennée
The hexagon container is always manually built but of course not everyone will be building it themselves and pushing to their registries. We still need to create a "local" registry copy for the actual gitlab tests to run. We don't build it in this case, just pull it across from the upstream

[PATCH 8/9] target/arm: Enable FPSCR.QC bit for MVE

2021-05-20 Thread Peter Maydell
MVE has an FPSCR.QC bit similar to the A-profile Neon one; when MVE is implemented make the bit writeable. Signed-off-by: Peter Maydell --- target/arm/vfp_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index

Re: [PATCH v2] hw/arm/smmuv3: Another range invalidation fix

2021-05-20 Thread Peter Maydell
On Mon, 10 May 2021 at 13:48, Eric Auger wrote: > > 6d9cd115b9 ("hw/arm/smmuv3: Enforce invalidation on a power of two range") > failed to completely fix misalignment issues with range > invalidation. For instance invalidations patterns like "invalidate 32 > 4kB pages starting from 0xff395000 are

Re: [PATCH 0/9] target/arm: MVE preliminaries

2021-05-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210520152840.24453-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210520152840.24453-1-peter.mayd...@linaro.org Subject: [PATCH 0/9] target/arm:

Re: [PATCH V3 00/22] Live Update [reboot]

2021-05-20 Thread Dr. David Alan Gilbert
Hi Steven, I'd like to split the discussion into reboot and restart, so I can make sure I understand them individually. So reboot mode; Can you explain which parts of this series are needed for reboot mode; I've managed to do a kexec based reboot on qemu with the current qemu - albeit with no

Re: [PULL 00/59] Linux user for 6.1 patches

2021-05-20 Thread Philippe Mathieu-Daudé
On 5/18/21 7:30 AM, Laurent Vivier wrote: > The following changes since commit 6d34aa9969ff85ca6eaeb4dc1988a4d4e13e7d79: > > Merge remote-tracking branch 'remotes/marcandre/tags/rtd-pull-request' into > staging (2021-05-14 17:20:08 +0100) > > are available in the Git repository at: > >

Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-05-20 Thread Steven Price
On 20/05/2021 13:05, Catalin Marinas wrote: > On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: >> diff --git a/arch/arm64/include/uapi/asm/kvm.h >> b/arch/arm64/include/uapi/asm/kvm.h >> index 24223adae150..b3edde68bc3e 100644 >> --- a/arch/arm64/include/uapi/asm/kvm.h >> +++

Re: latest GOOD state of series i386 cleanup, arm cleanup, s390 cleanup

2021-05-20 Thread Alex Bennée
Claudio Fontana writes: > On 5/18/21 4:02 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> On 5/17/21 11:53 AM, Claudio Fontana wrote: Hello all, due to my inactivity for a few weeks coupled likely with the upstream processes around qemu-6.0 now the series:

Re: [PULL 42/46] softfloat: Move div_floats to softfloat-parts.c.inc

2021-05-20 Thread Richard Henderson
On 5/20/21 8:40 AM, Peter Maydell wrote: On Sun, 16 May 2021 at 13:38, Richard Henderson wrote: Rename to parts$N_div. Implement float128_div with FloatParts128. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- +static bool frac64_div(FloatParts64 *a, FloatParts64 *b) +{ +

Re: [RFC PATCH v4 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-05-20 Thread Igor Mammedov
On Thu, 13 May 2021 08:26:39 +0200 Julia Suvorova wrote: > Instead of changing the hot-plug type in _OSC register, do not > set the 'Hot-Plug Capable' flag. This way guest will choose ACPI > hot-plug if it is preferred and leave the option to use SHPC with > pcie-pci-bridge. > > The ability to

Re: [RFC PATCH v4 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

2021-05-20 Thread Igor Mammedov
On Thu, 13 May 2021 08:26:40 +0200 Julia Suvorova wrote: > All DSDT Q35 tables will be modified because ACPI hot-plug is enabled > by default. > > Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ > 1 file

Re: [PULL 00/26] Misc patches for 2021-05-20

2021-05-20 Thread Peter Maydell
On Thu, 20 May 2021 at 14:26, Peter Maydell wrote: > > On Thu, 20 May 2021 at 09:31, Paolo Bonzini wrote: > > > > The following changes since commit 15e147b3c778f9f4c08c79b99747b848b6e2117b: > > > > Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' > > into staging

[PATCH v2 02/33] block: comment graph-modifying function not updating permissions

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index 384413c578..8aabfb03ec 100644 --- a/block.c +++ b/block.c @@ -2762,6 +2762,8 @@ static TransactionActionDrv bdrv_attach_child_common_drv = { /* *

[PATCH v2 00/33] block: publish backup-top filter

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
Hi all! v2: 01-02: new 03: don't bother with supporting empty child: we should never have such at this point 05: add comment 06: keep checking conflict with global add realized_set_allowed to qdev_prop_drive_iothread 07: improve cbw_cbw() name improve commit message 10: rebased on

[PATCH v2 01/33] block: rename bdrv_replace_child to bdrv_replace_child_tran

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
We have bdrv_replace_child() wrapper on bdrv_replace_child_noperm(). But bdrv_replace_child() doesn't update permissions. It's rather strange, as normally it's expected that foo() should call foo_noperm() and update permissions. Let's rename and add comment. Signed-off-by: Vladimir

[PATCH v2 10/33] block/backup: move cluster size calculation to block-copy

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
The main consumer of cluster-size is block-copy. Let's calculate it here instead of passing through backup-top. We are going to publish copy-before-write filter soon, so it will be created through options. But we don't want for now to make explicit option for cluster-size, let's continue to

[PATCH v2 03/33] block: introduce bdrv_replace_child_bs()

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 ++ block.c | 31 +++ 2 files changed, 33 insertions(+) diff --git a/include/block/block.h b/include/block/block.h

[PATCH v2 22/33] qapi: publish copy-before-write filter

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 2ea294129e..8c4801a13d 100644 --- a/qapi/block-core.json +++

[PATCH v2 27/33] iotests/222: constantly use single quotes for strings

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
The file use both single and double quotes for strings. Let's be consistent. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/222 | 68 +- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/tests/qemu-iotests/222

[PATCH v2 31/33] iotests/image-fleecing: rename tgt_node

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
Actually target of backup(sync=None) is not a final backup target: image fleecing is intended to be used with external tool, which will copy data from fleecing node to some real backup target. Also, we are going to add a test case for "push backup with fleecing", where instead of exporting

Re: [PATCH 1/6] qapi/parser.py: remove unused check_args_section arguments

2021-05-20 Thread Markus Armbruster
John Snow writes: > (Addresses a pylint warning.) > > Signed-off-by: John Snow > --- > scripts/qapi/parser.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py > index 06167ed3e0a..b3a468504fc 100644 > ---

<    1   2   3   4