Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de) wrote: >> On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: >>> * Michael S. Tsirkin (m...@redhat.com) wrote: On Fri, May 21, 2021 at 11:17:19AM +0200, Siddharth Chandrasekaran wrote: > After a

Re: [PATCH 1/3] hw/usb/Kconfig: Introduce USB_CHIPIDEA symbol

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:09, Philippe Mathieu-Daudé wrote: > > Currently the TYPE_CHIPIDEA model is only built when the IMX > machines are built. Since it is not specific to IMX, add its > symbol to allow other machines to use it. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

[PATCH] arm: Consistently use "Cortex-Axx", not "Cortex Axx"

2021-05-27 Thread Peter Maydell
The official punctuation for Arm CPU names uses a hyphen, like "Cortex-A9". We mostly follow this, but in a few places usage without the hyphen has crept in. Fix those so we consistently use the same way of writing the CPU name. This commit was created with: git grep -z -l 'Cortex ' | xargs -0

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Peter Maydell
On Thu, 27 May 2021 at 11:37, Hamza Mahfooz wrote: > > > > On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell > wrote: > > If we do want to change from sigprocmask() to pthread_sigmask(), we > > should be consistent about doing that, not just change this call > > only.) > On that note, do

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846816 Title: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel"" Status

Re: [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:54PM +0200, Emanuele Giuseppe Esposito wrote: > -static BlockCopyTask *find_conflicting_task(BlockCopyState *s, > -int64_t offset, int64_t bytes) > +/* Called with lock held */ s/lock/tasks_lock/ signature.asc

Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-05-27 Thread Catalin Marinas
On Thu, May 27, 2021 at 08:50:30AM +0100, Steven Price wrote: > On 24/05/2021 19:11, Catalin Marinas wrote: > > I had some (random) thoughts on how to make things simpler, maybe. I > > think most of these races would have been solved if we required PROT_MTE > > in the VMM but this has an impact on

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 1:36 PM, Claudio Fontana wrote: > On 5/27/21 12:53 PM, Claudio Fontana wrote: >> On 5/27/21 11:48 AM, Claudio Fontana wrote: >>> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan Gilbert

Re: [PATCH v3] target/riscv: fix VS interrupts forwarding to HS

2021-05-27 Thread LIU Zhiwei
On 5/26/21 7:50 PM, Jose Martins wrote: Hello Zhiwei, thank you for reviewing the patch. I'll split the patch in a series as you suggest. But first can you help me understand what the problems are with riscv_cpu_local_irq_pending? I think there are two errors in riscv_cpu_local_irq_pending.

Re: [PATCH v8 07/19] hvf: Split out common code on vcpu init and destroy

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:41PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 03/19] hvf: Move cpu functions into common directory

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:37PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 06/19] hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:40PM +0200, Alexander Graf wrote: > The ARM version of Hypervisor.framework no longer defines these two > types, so let's just revert to standard ones. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 6 +++--- > 1 file changed, 3

Re: [PATCH v8 11/19] hvf: Introduce hvf vcpu struct

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:45PM +0200, Alexander Graf wrote: > We will need more than a single field for hvf going forward. To keep > the global vcpu struct uncluttered, let's allocate a special hvf vcpu > struct, similar to how hax does it. > > Signed-off-by: Alexander Graf > Reviewed-by:

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Peter Maydell
On Mon, 24 May 2021 at 03:48, Hamza Mahfooz wrote: > > Use pthread_sigmask instead of sigprocmask inside process_pending_signals > to ensure that race conditions aren't possible. > > Signed-off-by: Hamza Mahfooz > --- > linux-user/signal.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v8 14/19] arm/hvf: Add a WFI handler

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:48PM +0200, Alexander Graf wrote: > From: Peter Collingbourne > > Sleep on WFI until the VTIMER is due but allow ourselves to be woken > up on IPI. > > In this implementation IPI is blocked on the CPU thread at startup and > pselect() is used to atomically unblock

Re: [PATCH v8 19/19] hvf: arm: Handle Windows 10 SMC call

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:53PM +0200, Alexander Graf wrote: > Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives > in the trusted application call number space, but its purpose is unknown. > > In our current SMC implementation, we inject a UDEF for unknown SMC calls, >

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

2021-05-27 Thread Greg Kurz
The only AIX version that _might_ run with QEMU is 7.2. Older ones don't have virtio AFAIK. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1846816 Title: Booting error on AIX 6.1 "Illegal Trap

Re: [PATCH 4/5] monitor: removed cpustats command

2021-05-27 Thread Bruno Piazera Larsen
On 27/05/2021 05:30, Greg Kurz wrote: On Thu, 27 May 2021 09:09:55 +0100 "Dr. David Alan Gilbert" wrote: * Greg Kurz (gr...@kaod.org) wrote: On Wed, 26 May 2021 17:21:03 -0300 "Bruno Larsen (billionai)" wrote: Since ppc was the last architecture to collect these statistics and it is

Re: [PATCH 0/5] stop collection of instruction usage statistics

2021-05-27 Thread Alex Bennée
"Bruno Larsen (billionai)" writes: > Based-on: <20210525115355.8254-1-bruno.lar...@eldorado.org.br> > > The functionality of counting how many instructions were being executed and > being able to show it through the monitor, although neat, was only > supported by ppc, and now that it is

Re: [PATCH 3/3] hw/arm/Kconfig: Add missing dependency IMX_USBPHY -> FSL_IMX6UL

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:10, Philippe Mathieu-Daudé wrote: > > We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX > USB Phy support") and had the FSL_IMX6 machine select it, however > this machine did not use the IMX_USBPHY until commit 49cd55789bb > ("hw/arm/fsl-imx6: Wire up

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >> On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: >>> * Claudio Fontana (cfont...@suse.de) wrote: On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin

Re: [PATCH v8 09/19] hvf: Make synchronize functions static

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:43PM +0200, Alexander Graf wrote: > The hvf accel synchronize functions are only used as input for local > callback functions, so we can make them static. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 6 +++--- > accel/hvf/hvf-accel-ops.h |

Re: [PATCH v4 04/15] qemu-iotests: add option to attach gdbserver

2021-05-27 Thread Emanuele Giuseppe Esposito
On 26/05/2021 21:15, Vladimir Sementsov-Ogievskiy wrote: 20.05.2021 10:52, Emanuele Giuseppe Esposito wrote: Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the

Re: [PATCH 0/5] linux-user changes to run docker

2021-05-27 Thread Alex Bennée
Takashi Yamamoto writes: > On Tue, May 25, 2021 at 8:22 AM Takashi Yamamoto > wrote: >> >> On Tue, May 25, 2021 at 2:49 AM Alex Bennée wrote: >> > >> > >> > YAMAMOTO Takashi writes: >> > >> > > These patches, along with a few more hacks [1] I didn't include >> > > in this patchset, allowed

Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-27 Thread Bruno Piazera Larsen
On 27/05/2021 01:35, David Gibson wrote: On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote: On Wed, May 26, 2021 at 05:21:01PM -0300, Bruno Larsen (billionai) wrote: This function requires surce code modification to be useful, which means it probably is not used often, and the move

Re: [PATCH v8 02/19] hvf: Move vcpu thread functions into common directory

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:36PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 05/19] hvf: Make hvf_set_phys_mem() static

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:39PM +0200, Alexander Graf wrote: > The hvf_set_phys_mem() function is only called within the same file. > Make it static. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 2 +- > include/sysemu/hvf_int.h | 1 - > 2 files changed, 1

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell wrote: If we do want to change from sigprocmask() to pthread_sigmask(), we should be consistent about doing that, not just change this call only.) On that note, do you think it would worthwhile to have a Coccinelle script replace all

Re: [PATCH v8 16/19] hvf: arm: Implement PSCI handling

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:50PM +0200, Alexander Graf wrote: > We need to handle PSCI calls. Most of the TCG code works for us, > but we can simplify it to only handle aa64 mode and we need to > handle SUSPEND differently. > > This patch takes the TCG code as template and duplicates it in HVF.

Re: [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:51PM +0200, Emanuele Giuseppe Esposito wrote: > } else { > /* > * We enable copy-range, but keep small copy_size, until first > * successful copy_range (look at block_copy_do_copy). > */ Is this comment still correct? It

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > > > On Wed, 26 May 2021 16:40:35

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > > On Wed, 26 May 2021 16:40:35 -0400 > > > Peter Xu wrote: > > > > > > > On Wed, May 26, 2021 at

[Bug 1929710] Re: virDomainGetBlockJobInfo fails during swap_volume as disk '$disk' not found in domain

2021-05-27 Thread Lee Yarwood
I've added the QEMU project directly to this bug to see if anyone can help us understand what the underlying block job failure is within QEMU and why it then appears to remove the entire device from the instance causing libvirt and Nova to fallover. ** Description changed: Description

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > >> On Fri, May 21, 2021 at 11:17:19AM +0200, Siddharth Chandrasekaran wrote: > >>> After a rebase to QEMU master, I am having trouble booting windows

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > On Wed, May 26, 2021 at 11:21:03PM +0200, Lukas Straub wrote: > > On Wed, 26 May 2021 16:40:35 -0400 > > Peter Xu wrote: > > > > > On Wed, May 26, 2021 at 05:05:40PM -0300, Leonardo Bras wrote: > > > > After yank feature was introduced,

[PATCH 1/1] target/riscv: Fix vsip vsie CSR ops in M and HS mode

2021-05-27 Thread LIU Zhiwei
When V=1, instructions that normally read or modify a supervisor CSR shall instead access the corresponding VS CSR. And the VS CSRs can be accessed as themselves from M-mode or HS-mode. In M and HS mode, VSIP or VSIE should be written normally instead of shift by 1. Signed-off-by: LIU Zhiwei

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > > * Claudio Fontana (cfont...@suse.de) wrote: > >> On 5/26/21 9:30 PM, Dr. David Alan Gilbert wrote: > >>> * Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, May 21, 2021 at

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-27 Thread Kevin Wolf
Am 24.05.2021 um 12:12 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > As reported by Programmingkid, command > > qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive > file=fat:rw:fat-type=16:"",id=fat16,format=raw,if=none > > crashes. > > I tested it with qemu-system-x86_64

Re: [PATCH v8 13/19] hvf: Add Apple Silicon support

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:47PM +0200, Alexander Graf wrote: > With Apple Silicon available to the masses, it's a good time to add support > for driving its virtualization extensions from QEMU. > > This patch adds all necessary architecture specific code to get basic VMs > working. It's still

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:45:26 AM +0100, Peter Maydell wrote: What issue are we trying to fix by making this change ? I suppose that it wouldn't fix any issues in the current state of affairs, maybe it is something to reconsider if glibc ever changes such that, sigprocmask is no longer

Re: [PATCH v2 0/7] block-copy: protect block-copy internal structures

2021-05-27 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:07:50PM +0200, Emanuele Giuseppe Esposito wrote: > This serie of patches aims to reduce the usage of the global > AioContexlock in block-copy, by introducing smaller granularity > locks thus on making the block layer thread safe. > > This serie depends on Paolo's

Re: [PATCH] vfio: Fix unregister SaveVMHandler in vfio_migration_finalize

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 2:31 PM, Kunkun Jiang wrote: > In the vfio_migration_init(), the SaveVMHandler is registered for > VFIO device. But it lacks the operation of 'unregister'. It will > lead to 'Segmentation fault (core dumped)' in > qemu_savevm_state_setup(), if performing live migration after a > VFIO

Re: [PULL 00/19] gitlab-ci patches for 2021-05-26

2021-05-27 Thread Peter Maydell
On Wed, 26 May 2021 at 22:27, Philippe Mathieu-Daudé wrote: > > The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20210526-pull-request' into staging (2021-05-26 > 15:27:20 +0100) > > are available in the

Re: [PATCH v3 1/3] hw/arm/boot: Abort if set_kernel_args() fails

2021-05-27 Thread Peter Maydell
On Thu, 20 May 2021 at 06:15, Philippe Mathieu-Daudé wrote: > > If a address_space_write() call fails while calling > set_kernel_args(), the guest kernel will boot using > crap data. Avoid that by aborting if this ever occurs. > > Signed-off-by: Philippe Mathieu-Daudé > @@ -786,10 +811,16 @@

Re: [PATCH v8 04/19] hvf: Move hvf internal definitions into common header

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:38PM +0200, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's start moving common > code out

Re: [PATCH v8 10/19] hvf: Remove hvf-accel-ops.h

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:44PM +0200, Alexander Graf wrote: > We can move the definition of hvf_vcpu_exec() into our internal > hvf header, obsoleting the need for hvf-accel-ops.h. > > Signed-off-by: Alexander Graf > --- > accel/hvf/hvf-accel-ops.c | 2 -- > accel/hvf/hvf-accel-ops.h | 17

Re: [PATCH v8 08/19] hvf: Use cpu_synchronize_state()

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:42PM +0200, Alexander Graf wrote: > There is no reason to call the hvf specific hvf_cpu_synchronize_state() > when we can just use the generic cpu_synchronize_state() instead. This > allows us to have less dependency on internal function definitions and > allows us to

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 12:53 PM, Claudio Fontana wrote: > On 5/27/21 11:48 AM, Claudio Fontana wrote: >> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: >>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de)

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Siddharth Chandrasekaran
On Thu, May 27, 2021 at 01:36:37PM +0200, Claudio Fontana wrote: > Just to check whether this is actually the issue we are talking about, > Sid et al, could you try this? > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index c496bfa1c2..810c46281b 100644 > --- a/target/i386/cpu.c >

[PATCH] vfio: Fix unregister SaveVMHandler in vfio_migration_finalize

2021-05-27 Thread Kunkun Jiang
In the vfio_migration_init(), the SaveVMHandler is registered for VFIO device. But it lacks the operation of 'unregister'. It will lead to 'Segmentation fault (core dumped)' in qemu_savevm_state_setup(), if performing live migration after a VFIO device is hot deleted. Fixes: 7c2f5f75f94 (vfio:

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 5/27/21 12:53 PM, Claudio Fontana wrote: > > On 5/27/21 11:48 AM, Claudio Fontana wrote: > >> On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: > >>> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > On 5/27/21 10:31 AM, Dr. David Alan

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Daniel P . Berrangé
On Thu, May 27, 2021 at 09:09:09AM -0400, Peter Xu wrote: > On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > > > On Wed, May 26, 2021 at

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > > > On Wed, May 26, 2021 at

Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-27 Thread Greg Kurz
On Thu, 27 May 2021 10:22:50 -0300 Bruno Piazera Larsen wrote: > > On 27/05/2021 01:35, David Gibson wrote: > > On Thu, May 27, 2021 at 11:20:01AM +1000, David Gibson wrote: > >> On Wed, May 26, 2021 at 05:21:01PM -0300, Bruno Larsen (billionai) wrote: > >>> This function requires surce code

Re: [PATCH] arm: Consistently use "Cortex-Axx", not "Cortex Axx"

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 11:51 AM, Peter Maydell wrote: > The official punctuation for Arm CPU names uses a hyphen, like > "Cortex-A9". We mostly follow this, but in a few places usage > without the hyphen has crept in. Fix those so we consistently > use the same way of writing the CPU name. > > This commit

Re: [PATCH v8 12/19] hvf: Simplify post reset/init/loadvm hooks

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:46PM +0200, Alexander Graf wrote: > The hooks we have that call us after reset, init and loadvm really all > just want to say "The reference of all register state is in the QEMU > vcpu struct, please push it". > > We already have a working pushing mechanism though

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-27 Thread BALATON Zoltan
On Thu, 27 May 2021, David Gibson wrote: On Tue, May 25, 2021 at 12:08:45PM +0200, BALATON Zoltan wrote: On Tue, 25 May 2021, David Gibson wrote: On Mon, May 24, 2021 at 12:55:07PM +0200, BALATON Zoltan wrote: On Mon, 24 May 2021, David Gibson wrote: On Sun, May 23, 2021 at 07:09:26PM +0200,

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Peter Xu
On Thu, May 27, 2021 at 02:17:55PM +0100, Daniel P. Berrangé wrote: > On Thu, May 27, 2021 at 09:09:09AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 01:37:42PM +0100, Daniel P. Berrangé wrote: > > > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > > > On Thu, May 27, 2021 at

Re: [PATCH 2/3] hw/arm/Kconfig: Add missing dependency ZYNQ -> USB_CHIPIDEA

2021-05-27 Thread Peter Maydell
On Wed, 19 May 2021 at 21:09, Philippe Mathieu-Daudé wrote: > > When using a binary built using --without-default-devices we get: > > $ qemu-system-arm -M xilinx-zynq-a9 > ** > ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != > NULL) > Bail out!

Re: [PATCH v8 15/19] hvf: arm: Implement -cpu host

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:49PM +0200, Alexander Graf wrote: > Now that we have working system register sync, we push more target CPU > properties into the virtual machine. That might be useful in some > situations, but is not the typical case that users want. > > So let's add a -cpu host

Re: Windows fails to boot after rebase to QEMU master

2021-05-27 Thread Claudio Fontana
On 5/27/21 11:48 AM, Claudio Fontana wrote: > On 5/27/21 11:15 AM, Dr. David Alan Gilbert wrote: >> * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: >>> On 5/27/21 10:31 AM, Dr. David Alan Gilbert wrote: * Claudio Fontana (cfont...@suse.de) wrote: > On 5/26/21 9:30 PM, Dr. David Alan

Re: [PATCH v8 18/19] arm: Enable Windows 10 trusted SMCCC boot call

2021-05-27 Thread Sergio Lopez
On Wed, May 19, 2021 at 10:22:52PM +0200, Alexander Graf wrote: > Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives > in the trusted application call number space, but its purpose is unknown. > > In our current SMC implementation, we inject a UDEF for unknown SMC calls, >

Re: [PULL v2 00/28] Misc patches for 2021-05-24

2021-05-27 Thread Peter Maydell
On Wed, 26 May 2021 at 17:51, Paolo Bonzini wrote: > > The following changes since commit 92f8c6fef13b31ba222c4d20ad8afd2b79c4c28e: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210525' into staging (2021-05-25 > 16:17:06 +0100) > > are available in the Git

Re: [PATCH 1/1] tests/acceptance: change armbian archive to a faster host

2021-05-27 Thread Willian Rampazzo
On Wed, May 26, 2021 at 8:41 PM Cleber Rosa wrote: > > On Wed, May 26, 2021 at 05:56:01PM -0300, Willian Rampazzo wrote: > > The current host for the image > > Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz > > (archive.armbian.com) is extremely slow in the last couple of weeks, > >

[PULL 00/23] Vga 20210527 patches

2021-05-27 Thread Gerd Hoffmann
The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: Merge remote-tracking branch 'remotes/kraxel/tags/input-20210526-pull-request' into staging (2021-05-26 15:27:20 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20210527-pull

[PULL 08/23] vhost-user-gpu: abstract vg_cleanup_mapping_iov

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang Currently in vhost-user-gpu, we free resource directly in the cleanup case of resource. If we change the cleanup logic we need to change several places, also abstruct a 'vg_create_mapping_iov' can be symmetry with the 'vg_create_mapping_iov'. This is like what virtio-gpu does, no

[PULL 15/23] virtio-gpu: Refactor virtio_gpu_set_scanout

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy Store the meta-data associated with a FB in a new object (struct virtio_gpu_framebuffer) and pass the object to set_scanout. Also move code in set_scanout into a do_set_scanout function. This will be helpful when adding set_scanout_blob API. Based-on-patch-by: Gerd

[Bug 1892963] Re: Heap-use-after-free in put_dwords through ehci_flush_qh

2021-05-27 Thread Thomas Huth
I can still reproduce this issue when compiling the current version of QEMU with Clang + asan. Marking as "Confirmed". ** Tags added: fuzzer usb ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Virtio-fs] [PATCH 1/3] virtiofsd: Find original inode ID of mount points

2021-05-27 Thread Max Reitz
On 26.05.21 20:50, Vivek Goyal wrote: On Wed, May 26, 2021 at 02:13:24PM -0400, Vivek Goyal wrote: On Wed, May 12, 2021 at 02:55:42PM +0200, Max Reitz wrote: Mount point directories represent two inodes: On one hand, they are a normal directory on their parent filesystem. On the other, they

Re: [PATCH 1/3] block: consistently use bdrv_is_read_only()

2021-05-27 Thread Kevin Wolf
Am 26.05.2021 um 23:15 hat Vladimir Sementsov-Ogievskiy geschrieben: > It's better to use accessor function instead of bs->read_only directly. > In some places use bdrv_is_writable() instead of > checking both BDRV_O_RDWR set and BDRV_O_INACTIVE not set. > > In bdrv_open_common() it's a bit

Re: [PATCH 1/1] yank: Unregister function when using TLS migration

2021-05-27 Thread Lukas Straub
On Thu, 27 May 2021 13:37:42 +0100 Daniel P. Berrangé wrote: > On Thu, May 27, 2021 at 08:23:52AM -0400, Peter Xu wrote: > > On Thu, May 27, 2021 at 09:46:54AM +0100, Daniel P. Berrangé wrote: > > > On Wed, May 26, 2021 at 05:58:58PM -0400, Peter Xu wrote: > > > > On Wed, May 26, 2021 at

Re: [PATCH 3/3] block: drop BlockBackendRootState::read_only

2021-05-27 Thread Vladimir Sementsov-Ogievskiy
27.05.2021 17:46, Kevin Wolf wrote: Am 26.05.2021 um 23:15 hat Vladimir Sementsov-Ogievskiy geschrieben: Instead of keeping additional boolean field, let's store the information in BDRV_O_RDWR bit of BlockBackendRootState::open_flags. Signed-off-by: Vladimir Sementsov-Ogievskiy diff --git

Re: [PATCH v2 2/6] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-05-27 Thread Kevin Wolf
Am 24.05.2021 um 18:36 hat Paolo Bonzini geschrieben: > bs->sg is only true for character devices, but block devices can also > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET > returns bytes in an int for /dev/sgN devices, and sectors in a short > for block devices, so account

Re: [PATCH v7 09/31] python: create qemu packages

2021-05-27 Thread Cleber Rosa
On Tue, May 25, 2021 at 08:24:32PM -0400, John Snow wrote: > move python/qemu/*.py to python/qemu/[machine, qmp, utils]/*.py and > update import directives across the tree. > > This is done to create a PEP420 namespace package, in which we may > create subpackages. To do this, the namespace

[PATCH v4] target/ppc: overhauled and moved logic of storing fpscr

2021-05-27 Thread Bruno Larsen (billionai)
Followed the suggested overhaul to store_fpscr logic, and moved it to cpu.c where it can be accessed in !TCG builds. The overhaul was suggested because storing a value to fpscr should never raise an exception, so we could remove all the mess that happened with POWERPC_EXCP_FP. We also moved

Re: [PATCH v3 09/26] DAX: virtio-fs: Add vhost-user slave commands for mapping

2021-05-27 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Apr 28, 2021 at 12:00:43PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c > > index dd0a02aa99..169a146e72 100644 > > --- a/hw/virtio/vhost-user-fs.c > > +++

Re: [PATCH v1 1/6] tests/tcg: add a multiarch signals test to stress test signal delivery

2021-05-27 Thread Richard Henderson
On 5/27/21 9:03 AM, Alex Bennée wrote: This adds a simple signal test that combines the POSIX timer_create with signal delivery across multiple threads. The aim is to provide a bit more of a stress test to flush out signal handling issues for easily than the occasional random crash we sometimes

[PATCH 2/3] 9pfs: capture root stat

2021-05-27 Thread Christian Schoenebeck
We already capture the QID of the exported 9p root path, i.e. to prevent client access outside the defined, exported filesystem's tree. This is currently checked by comparing the root QID with another FID's QID. The problem with the latter is that resolving a QID of any given 9p path can only be

[PULL 18/23] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy This API allows Qemu to register the blob allocated by the Guest as a new resource and map its backing storage. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210526231429.1045476-10-vivek.kasire...@intel.com>

[PULL 17/23] virtio-gpu: Add initial definitions for blob resources

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy Add the property bit, configuration flag and other relevant macros and definitions associated with this feature. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210526231429.1045476-9-vivek.kasire...@intel.com>

[PULL 12/23] virtio-gpu: Add udmabuf helpers

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy Add helper functions to create a dmabuf for a resource and mmap it. Also, introduce the fields blob and blob_size so that these helpers can start to use them but the full picture will emerge only after adding create_blob API in patch 8 of this series. To be able to create

[Bug 1892966] Re: Null-pointer dereference in blk_bs through ide_cancel_dma_sync

2021-05-27 Thread Thomas Huth
This problem does not trigger anymore for me with the current version of QEMU. Could you please check whether you can still reproduce it somehow with the latest version? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[PULL v2 08/18] gitlab: Extract default build/test jobs templates

2021-05-27 Thread Philippe Mathieu-Daudé
To be able to reuse the mainstream build/test jobs templates, extract them into a new file (buildtest-template.yml). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo Message-Id: <20210519185504.2198573-8-f4...@amsat.org> [thuth: Keep the "acceptance_test_job_template" name

Re: [PULL 00/19] gitlab-ci patches for 2021-05-26

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/27/21 3:56 PM, Peter Maydell wrote: > On Wed, 26 May 2021 at 22:27, Philippe Mathieu-Daudé wrote: >> >> The following changes since commit 2ab2dad01f6dc3667c0d53d2b1ba46b511031207: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/input-20210526-pull-request' into staging

RE: [PATCH 0/5] stop collection of instruction usage statistics

2021-05-27 Thread Luis Fernando Fujita Pires
From: Alex Bennée > Ahh OK. If you wanted to you could probably re-create that information using > the howvec plugin (see contrib/plugins/howvec) if the decode tables where > added for PPC. Interesting. I hadn't looked at the plugin mechanism before. In this hypothetical case, if we wanted to

[Bug 1929710] Re: virDomainGetBlockJobInfo fails during swap_volume as disk '$disk' not found in domain

2021-05-27 Thread melanie witt
Just a note that the QEMU project is moving their bug tracking to gitlab [1] and will automatically migrate launchpad bugs, but it might be more expedient to open an issue on their gitlab tracker. [1] https://bugs.launchpad.net/qemu/+bug/1914282/comments/3 -- You received this bug notification

Re: [PATCH 0/9] accel/tcg: Add tlb_flush interface for a range of pages

2021-05-27 Thread Philippe Mathieu-Daudé
On 5/25/21 4:32 PM, Peter Maydell wrote: > On Sun, 9 May 2021 at 16:20, Philippe Mathieu-Daudé wrote: >> >> Hi Richard, >> >> I tried to make sense of the multiple changes in your patch >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg805595.html >> by splitting it in multiple trivial

[PATCH v1 3/6] tests/tcg/configure.sh: tweak quoting of target_compiler

2021-05-27 Thread Alex Bennée
If you configure the host compiler with a multi-command stanza like: --cc="ccache gcc" then the configure.sh machinery falls over with confusion. Work around this by ensuring we correctly quote so where we need a complete evaluation we get it. Of course the has() check needs single variable so

[PATCH v1 2/6] meson.build: fix cosmetics of compiler display

2021-05-27 Thread Alex Bennée
If you specify something like --cc="ccache gcc" on your configure line the summary output misses the rest of the cmd_array. Do some string joining to make it complete. Signed-off-by: Alex Bennée Tested-by: Thomas Huth --- meson.build | 8 1 file changed, 4 insertions(+), 4

[PATCH 0/2] Improve the fallocate() EINVAL in handle_aiocb_write_zeroes()

2021-05-27 Thread Thomas Huth
On buggy file systems, fallocate() can return EINVAL for unaligned accesses. Improve the situation by ignoring this for PUNCH_HOLE, too (but we also print out an error message in this case now, since PUNCH_HOLE should really never return EINVAL according to the man page). The second patch reworks

Re: [PATCH v1 2/6] meson.build: fix cosmetics of compiler display

2021-05-27 Thread Richard Henderson
On 5/27/21 9:03 AM, Alex Bennée wrote: If you specify something like --cc="ccache gcc" on your configure line the summary output misses the rest of the cmd_array. Do some string joining to make it complete. Signed-off-by: Alex Bennée Tested-by: Thomas Huth --- meson.build | 8 1

Re: [PATCH v1 6/6] tests/acceptance: tag various arm tests as TCG only

2021-05-27 Thread Richard Henderson
On 5/27/21 9:03 AM, Alex Bennée wrote: We should never be trying to run most of these models under a KVM environment. Signed-off-by: Alex Bennée --- tests/acceptance/boot_linux_console.py | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PULL 06/23] vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing' (CVE-2021-3544)

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang If 'virgl_renderer_resource_attach_iov' failed, the 'res_iovs' will be leaked. Fixes: CVE-2021-3544 Reported-by: Li Qiang virtio-gpu fix: 33243031da ("virtio-gpu-3d: fix memory leak in resource attach backing") Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau

[PULL 01/23] vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info (CVE-2021-3545)

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang Otherwise some of the 'resp' will be leaked to guest. Fixes: CVE-2021-3545 Reported-by: Li Qiang virtio-gpu fix: 42a8dadc74 ("virtio-gpu: fix information leak in getting capset info dispatch") Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau Message-Id:

[PULL 02/23] vhost-user-gpu: fix resource leak in 'vg_resource_create_2d' (CVE-2021-3544)

2021-05-27 Thread Gerd Hoffmann
From: Li Qiang Call 'vugbm_buffer_destroy' in error path to avoid resource leak. Fixes: CVE-2021-3544 Reported-by: Li Qiang Reviewed-by: Prasad J Pandit Signed-off-by: Li Qiang Reviewed-by: Marc-André Lureau Message-Id: <20210516030403.107723-3-liq...@163.com> Signed-off-by: Gerd Hoffmann

[PULL 16/23] virtio-gpu: Refactor virtio_gpu_create_mapping_iov

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy Instead of passing the attach_backing object to extract nr_entries and offset, explicitly pass these as arguments to this function. This will be helpful when adding create_blob API. Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id:

[PULL 10/23] ui: Get the fd associated with udmabuf driver

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy Try to open the udmabuf dev node for the first time or return the fd if the device was previously opened. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210526231429.1045476-2-vivek.kasire...@intel.com> [ kraxel: fixup

RE: [PATCH 0/5] stop collection of instruction usage statistics

2021-05-27 Thread Luis Fernando Fujita Pires
From: Alex Bennée > I have no particular comment to make about the PPC stuff but with the common > translator loop we have hooks across all converted front ends to identify the > start of each instruction. It's needed for the TCG plugin instrumentation and > we > could in theory use it for more

[PULL 19/23] ui/pixman: Add qemu_pixman_to_drm_format()

2021-05-27 Thread Gerd Hoffmann
From: Vivek Kasireddy This new function to get the drm_format associated with a pixman format will be useful while creating a dmabuf. Based-on-patch-by: Gerd Hoffmann Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Message-Id: <20210526231429.1045476-11-vivek.kasire...@intel.com>

Re: [PATCH 3/3] block: drop BlockBackendRootState::read_only

2021-05-27 Thread Kevin Wolf
Am 26.05.2021 um 23:15 hat Vladimir Sementsov-Ogievskiy geschrieben: > Instead of keeping additional boolean field, let's store the > information in BDRV_O_RDWR bit of BlockBackendRootState::open_flags. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > diff --git a/blockdev.c b/blockdev.c >

  1   2   3   4   >