Re: [PATCH] configure / meson: Move the GBM handling to meson.build

2021-07-13 Thread Paolo Bonzini
On 13/07/21 13:15, Thomas Huth wrote: The GBM library detection does not need to be in the configure script, since it does not have any user-facing options (there are no --enable-gbm or --disable-gbm switches). Let's move it to meson.build instead, so we don't have to clutter config-host.mak

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-13 Thread Stefan Hajnoczi
On Mon, Jul 12, 2021 at 10:41:46AM +0200, Emanuele Giuseppe Esposito wrote: > > > On 08/07/2021 15:04, Stefan Hajnoczi wrote: > > On Thu, Jul 08, 2021 at 01:32:12PM +0200, Paolo Bonzini wrote: > > > On 08/07/21 12:36, Stefan Hajnoczi wrote: > > > > > What is very clear from this patch is that it

[PATCH for-6.2 09/34] target/arm: Factor out mve_eci_mask()

2021-07-13 Thread Peter Maydell
In some situations we need a mask telling us which parts of the vector correspond to beats that are not being executed because of ECI, separately from the combined "which bytes are predicated away" mask. Factor this mask calculation out of mve_element_mask() into its own function. Signed-off-by:

[PATCH for-6.2 11/34] target/arm: Implement MVE VMULL (polynomial)

2021-07-13 Thread Peter Maydell
Implement the MVE VMULL (polynomial) insn. Unlike Neon, this comes in two flavours: 8x8->16 and a 16x16->32. Also unlike Neon, the inputs are in either the low or the high half of each double-width element. The assembler for this insn indicates the size with "P8" or "P16", encoded into bit 28

[PATCH for-6.2 13/34] target/arm: Factor out gen_vpst()

2021-07-13 Thread Peter Maydell
Factor out the "generate code to update VPR.MASK01/MASK23" part of trans_VPST(); we are going to want to reuse it for the VPT insns. Signed-off-by: Peter Maydell --- target/arm/translate-mve.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git

[PATCH for-6.2 08/34] target/arm: Fix VPT advance when ECI is non-zero

2021-07-13 Thread Peter Maydell
We were not paying attention to the ECI state when advancing the VPT state. Architecturally, VPT state advance happens for every beat (see the pseudocode VPTAdvance()), so on every beat the 4 bits of VPR.P0 corresponding to the current beat are inverted if required, and at the end of beats 1 and

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-13 Thread Markus Armbruster
Brijesh Singh writes: > To launch the SEV-SNP guest, a user can specify up to 8 parameters. > Passing all parameters through command line can be difficult. To simplify > the launch parameter passing, introduce a .ini-like config file that can be > used for passing the parameters to the launch

Re: [PATCH V5 20/25] chardev: cpr framework

2021-07-13 Thread Steven Sistare
On 7/12/2021 3:49 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jul 12, 2021 at 11:20 PM Steven Sistare > wrote: > > On 7/8/2021 12:03 PM, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 7, 2021 at 9:37 PM Steve Sistare

[PULL v2 4/4] fuzz: add an instrumentation filter

2021-07-13 Thread Alexander Bulekov
By default, -fsanitize=fuzzer instruments all code with coverage information. However, this means that libfuzzer will track coverage over hundreds of source files that are unrelated to virtual-devices. This means that libfuzzer will optimize inputs for coverage observed in timer code, memory APIs

Re: [PATCH v6 5/6] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-13 Thread Michael S. Tsirkin
On Tue, Jul 13, 2021 at 09:59:31AM +0200, Igor Mammedov wrote: > On Tue, 13 Jul 2021 02:42:04 +0200 > Julia Suvorova wrote: > > > Q35 has three different types of PCI devices hot-plug: PCIe Native, > > SHPC Native and ACPI hot-plug. This patch changes the default choice > > for cold-plugged

[PULL 4/6] migration: Don't do migrate cleanup if during postcopy resume

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Below process could crash qemu with postcopy recovery: 1. (hmp) migrate -d .. 2. (hmp) migrate_start_postcopy 3. [network down, postcopy paused] 4. (hmp) migrate -r $WRONG_PORT when try the recover on an invalid $WRONG_PORT, cleanup_bh will be cleared 5. (hmp)

[PULL 5/6] migration: Clear error at entry of migrate_fd_connect()

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Peter Xu For each "migrate" command, remember to clear the s->error before going on. For one reason, when there's a new error it'll be still remembered; see migrate_set_error() who only sets the error if error==NULL. Meanwhile if a failed migration completes (e.g., postcopy recovered and

[PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-07-13 Thread Andrew Melnychenko
Libvirt usually launches qemu with strict permissions. To enable eBPF RSS steering, qemu-ebpf-rss-helper was added. Added property "ebpf_rss_fds" for "virtio-net" that allows to initialize eBPF RSS context with passed program & maps fds. Added qemu-ebpf-rss-helper - simple helper that loads eBPF

[PATCH 2/5] virtio-net: Added property to load eBPF RSS with fds.

2021-07-13 Thread Andrew Melnychenko
eBPF RSS program and maps now may be passed during initialization. Initially was implemented for libvirt to launch qemu without permissions. Signed-off-by: Andrew Melnychenko --- hw/net/virtio-net.c| 77 -- include/hw/virtio/virtio-net.h | 1 + 2

[PATCH 3/5] qmp: Added the helper stamp check.

2021-07-13 Thread Andrew Melnychenko
Added function to check the stamp in the helper. eBPF helper should have a special symbol that generates during build. QEMU checks the helper and determinates that it fits, so the helper will produce proper output. Signed-off-by: Andrew Melnychenko --- meson.build | 10 +

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Eric Blake
On Tue, Jul 13, 2021 at 08:01:34AM -0500, Eric Blake wrote: > > > @@ -973,7 +973,6 @@ static int nbd_negotiate_meta_queries(NBDClient > > > *client, > > > { > > > int ret; > > > g_autofree char *export_name = NULL; > > > -g_autofree bool *bitmaps = NULL; > > >

[PATCH for-6.2 00/34] target/arm: Third slice of MVE implementation

2021-07-13 Thread Peter Maydell
This patchseries provides the third slice of the MVE implementation. In this series: * fixes for minor bugs in a couple of the insns already upstream * all the remaining integer instructions * the remaining loads and stores (scatter-gather and interleaving) This is obviously for-6.2 material,

[PATCH for-6.2 02/34] target/arm: Print MVE VPR in CPU dumps

2021-07-13 Thread Peter Maydell
Include the MVE VPR register value in the CPU dumps produced by arm_cpu_dump_state() if we are printing FPU information. This makes it easier to interpret debug logs when predication is active. Signed-off-by: Peter Maydell --- target/arm/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH for-6.2 21/34] target/arm: Implement MVE VABAV

2021-07-13 Thread Peter Maydell
Implement the MVE VABAV insn, which computes absolute differences between elements of two vectors and accumulates the result into a general purpose register. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 7 +++ target/arm/mve.decode | 6 ++ target/arm/mve_helper.c

[PATCH for-6.2 28/34] target/arm: Implement MVE VMAXA, VMINA

2021-07-13 Thread Peter Maydell
Implement the MVE VMAXA and VMINA insns, which take the absolute value of the signed elements in the input vector and then accumulate the unsigned max or min into the destination vector. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 4

[PATCH for-6.2 27/34] target/arm: Implement MVE VQABS, VQNEG

2021-07-13 Thread Peter Maydell
Implement the MVE 1-operand saturating operations VQABS and VQNEG. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 37 + target/arm/translate-mve.c | 2 ++ 4 files

[PULL 06/12] linux-user/mips: Move errno definitions to 'target_errno_defs.h'

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Suggested-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210708170550.1846343-7-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/mips/target_errno_defs.h | 215

[PULL 10/12] linux-user: update syscall_nr.h to Linux v5.13

2021-07-13 Thread Laurent Vivier
Automatically generated using scripts/gensyscalls.sh Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson Message-Id: <20210708215756.268805-2-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- linux-user/aarch64/syscall_nr.h | 8 +++- linux-user/hexagon/syscall_nr.h | 12

[PULL 09/12] fd-trans: Fix race condition on reallocation of the translation table.

2021-07-13 Thread Laurent Vivier
From: Owen Anderson The mapping from file-descriptors to translator functions is not guarded on realloc which may cause invalid function pointers to be read from a previously deallocated mapping. Signed-off-by: Owen Anderson Reviewed-by: Laurent Vivier Message-Id:

[PATCH v2 0/3] docs: document cubieboard, emcraft-sf2, highbank, midway

2021-07-13 Thread Peter Maydell
This patchset adds documentation of the four board models cubieboard, emcraft-sf2, highbank and midway. The documentation here is rather skeletal, being based on a quick read of sources, cover letter from original patch submission, etc. People interested in these machines are encouraged to

Re: [PATCH 0/7] docs: State QEMU version and license in all HTML footers

2021-07-13 Thread Peter Maydell
On Mon, 5 Jul 2021 at 10:55, Peter Maydell wrote: > > This patchset is an effort to fix something up which I promised > Markus I would do after we got the initial conversion to Sphinx > done. The old QAPI reference documentation noted the documentation > license in the texinfo source (but not in

Re: [PATCH] hw/nvme: fix mmio read

2021-07-13 Thread Klaus Jensen
On Jul 13 12:34, Klaus Jensen wrote: > On Jul 13 11:31, Peter Maydell wrote: > > On Tue, 13 Jul 2021 at 11:19, Klaus Jensen wrote: > > > > > > On Jul 13 11:07, Peter Maydell wrote: > > > > Looking at the surrounding code, I notice that we guard this "read size > > > > bytes > > > > from >bar +

[PULL v2 2/4] fuzz: adjust timeout to allow for longer inputs

2021-07-13 Thread Alexander Bulekov
Using a custom timeout is useful to continue fuzzing complex devices, even after we run into some slow code-path. However, simply adding a fixed timeout to each input effectively caps the maximum input length/number of operations at some artificial value. There are two major problems with this: 1.

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-13 Thread Vladimir Sementsov-Ogievskiy
13.07.2021 16:10, Stefan Hajnoczi wrote: On Mon, Jul 12, 2021 at 10:41:46AM +0200, Emanuele Giuseppe Esposito wrote: On 08/07/2021 15:04, Stefan Hajnoczi wrote: On Thu, Jul 08, 2021 at 01:32:12PM +0200, Paolo Bonzini wrote: On 08/07/21 12:36, Stefan Hajnoczi wrote: What is very clear from

[PULL 6/6] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Peter Xu Taking the mutex every time for each dirty bit to clear is too slow, especially we'll take/release even if the dirty bit is cleared. So far it's only used to sync with special cases with qemu_guest_free_page_hint() against migration thread, nothing really that serious yet. Let's

[PULL 3/6] migration: Release return path early for paused postcopy

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Peter Xu When postcopy pause triggered, we rely on the migration thread to cleanup the to_dst_file handle, and the return path thread to cleanup the from_dst_file handle (which is stored in the local variable "rp"). Within the process, from_dst_file cleanup (qemu_fclose) is postponed

Re: [PATCH] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-07-13 Thread Qiang Liu
On Tue, Jul 13, 2021 at 6:24 PM Philippe Mathieu-Daudé wrote: > > On 7/13/21 12:20 PM, Philippe Mathieu-Daudé wrote: > > On 7/13/21 5:14 AM, Qiang Liu wrote: > >> xlnx_dp_read allows an out-of-bounds read at its default branch because > >> of an improper index. > >> > >> According to > >>

Re: [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

2021-07-13 Thread Laurent Vivier
Le 12/07/2021 à 23:29, jonathan.albrecht a écrit : > On 2021-07-12 4:02 pm, Laurent Vivier wrote: >> Le 09/07/2021 à 18:04, Jonathan Albrecht a écrit : >>> qemu-s390x signals with SIGILL on compare-and-trap instructions. This >>> breaks OpenJDK which expects SIGFPE in its implementation of

[PATCH for-6.2 05/34] target/arm: Fix mask handling for MVE narrowing operations

2021-07-13 Thread Peter Maydell
In the MVE helpers for the narrowing operations (DO_VSHRN and DO_VSHRN_SAT) we were using the wrong bits of the predicate mask for the 'top' versions of the insn. This is because the loop works over the double-sized input elements and shifts the predicate mask by that many bits each time, but

[PATCH for-6.2 03/34] target/arm: Fix MVE VSLI by 0 and VSRI by

2021-07-13 Thread Peter Maydell
In the MVE shift-and-insert insns, we special case VSLI by 0 and VSRI by , both of which mean "no shift". However we incorrectly implemented these as "don't update the destination", which works only if Qd == Qm. When Qd != Qm this kind of shift must update Qd, honouring the predicate mask.

[PATCH for-6.2 16/34] target/arm: Implement MVE VPSEL

2021-07-13 Thread Peter Maydell
Implement the MVE VPSEL insn, which sets each byte of the destination vector Qd to the byte from either Qn or Qm depending on the value of the corresponding bit in VPR.P0. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 2 ++ target/arm/mve.decode | 7 +--

[PATCH for-6.2 23/34] target/arm: Rename MVEGenDualAccOpFn to MVEGenLongDualAccOpFn

2021-07-13 Thread Peter Maydell
The MVEGenDualAccOpFn is a bit misnamed, since it is used for the "long dual accumulate" operations that use a 64-bit accumulator. Rename it to MVEGenLongDualAccOpFn so we can use the former name for the 32-bit accumulator insns. Signed-off-by: Peter Maydell --- target/arm/translate-mve.c | 16

[PATCH for-6.2 12/34] target/arm: Implement MVE incrementing/decrementing dup insns

2021-07-13 Thread Peter Maydell
Implement the MVE incrementing/decrementing dup insns VIDUP, VDDUP, VIWDUP and VDWDUP. These fill the elements of a vector with successively incrementing values, starting at the offset specified in a general purpose register. The final value of the offset is written back to this register. The

[PATCH for-6.2 25/34] target/arm: Implement MVE VMLA

2021-07-13 Thread Peter Maydell
Implement the MVE VMLA insn, which multiplies a vector by a scalar and accumulates into another vector. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 6 ++ target/arm/translate-mve.c | 2 ++ 4 files

Re: [PATCH v2] meson: fix condition for io_uring stubs

2021-07-13 Thread Daniel P . Berrangé
On Mon, Jul 12, 2021 at 05:18:10PM +0200, Paolo Bonzini wrote: > CONFIG_LINUX_IO_URING is not included in config-host.mak and therefore is > not usable in "when" clauses. Check the availability of the library, > which matches the condition for the non-stubbed version block/io_uring.c. > > At

[PATCH v2 3/3] docs: Add skeletal documentation of highbank and midway

2021-07-13 Thread Peter Maydell
Add skeletal documentation for the highbank and midway machines. Signed-off-by: Peter Maydell --- docs/system/arm/highbank.rst | 19 +++ docs/system/target-arm.rst | 1 + MAINTAINERS | 1 + 3 files changed, 21 insertions(+) create mode 100644

Re: usb-host device not working

2021-07-13 Thread Programmingkid
> On Jul 13, 2021, at 10:49 AM, Programmingkid > wrote: > > I have been having problems with using host USB devices lately. I use to be > able to use host USB devices but can't currently. After doing some git > bisecting I found it was this patch that causes this issue: > > commit

Re: [PULL 0/3] Fuzzing Patches

2021-07-13 Thread Alexander Bulekov
On 210713 0148, Alexander Bulekov wrote: > Hello Paolo, > > The following changes since commit 711c0418c8c1ce3a24346f058b001c4c5a2f0f81: > > Merge remote-tracking branch 'remotes/philmd/tags/mips-20210702' into > staging (2021-07-04 14:04:12 +0100) > > are available in the Git repository at:

[PULL 2/6] migration: failover: emit a warning when the card is not fully unplugged

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Laurent Vivier When the migration fails or is canceled we wait the end of the unplug operation to be able to plug it back. But if the unplug operation is never finished we stop to wait and QEMU emits a warning to inform the user. Based-on: 20210629155007.629086-1-lviv...@redhat.com

Re: [PATCH v6 0/6] hmp,qmp: Add some commands to introspect virtio devices

2021-07-13 Thread Michael S. Tsirkin
On Mon, Jul 12, 2021 at 06:35:31AM -0400, Jonah Palmer wrote: > This series introduces new QMP/HMP commands to dump the status of a > virtio device at different levels. > > [Jonah: Rebasing previous patchset from March for Qemu 6.1 > (here: >

[PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-07-13 Thread Andrew Melnychenko
New qmp command to query ebpf helper. It's crucial that qemu and helper are in sync and in touch. Technically helper should pass eBPF fds that qemu may accept. And different qemu's builds may have different eBPF programs and helpers. Qemu returns helper that should "fit" to virtio-net.

[PATCH 4/5] ebpf_rss_helper: Added helper for eBPF RSS.

2021-07-13 Thread Andrew Melnychenko
Helper program. Loads eBPF RSS program and maps and passes them through unix socket. Libvirt may launch this helper and pass eBPF fds to qemu virtio-net. Also, libbpf dependency now exclusively for Linux. Libbpf is used for eBPF RSS steering, which is supported only by Linux TAP. There is no

Re: [PULL 0/6] Tracing patches

2021-07-13 Thread Peter Maydell
On Mon, 12 Jul 2021 at 17:50, Stefan Hajnoczi wrote: > > The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' > into staging (2021-07-12 11:02:39 +0100) > > are available in the Git repository

[PATCH for-6.2 29/34] target/arm: Implement MVE VMOV to/from 2 general-purpose registers

2021-07-13 Thread Peter Maydell
Implement the MVE VMOV forms that move data between 2 general-purpose registers and 2 32-bit lanes in a vector register. Signed-off-by: Peter Maydell --- target/arm/translate-a32.h | 1 + target/arm/mve.decode | 4 ++ target/arm/translate-mve.c | 85 ++

[PULL 07/12] linux-user: Simplify host <-> target errno conversion using macros

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Convert the host_to_target_errno_table[] array to a switch case to allow compiler optimizations (such noticing the identity function when host and guest errnos match). Extract the errnos list as to a new includible unit, using a generic macro. Remove the code related

[PULL 03/12] linux-user: Extract target errno to 'target_errno_defs.h'

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We want to access the target errno indepently of the rest of the linux-user code. Move the header containing the generic errno definitions ('errno_defs.h') to 'generic/target_errno_defs.h', create a new 'target_errno_defs.h' in each target which itself includes

Re: [RFC PATCH 0/6] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-13 Thread Brijesh Singh
On 7/13/21 3:05 AM, Dov Murik wrote:> Particularly confusing is the `policy` attribute which is only relevant for SEV / SEV-ES, while there's a new `snp.policy` attribute for SNP... Maybe the irrelevant attributes should not be added to the tree when not in SNP. The policy fields are also

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Richard Henderson
On 7/13/21 6:14 AM, Eric Blake wrote: Hmm; in glib 2.68.2 (on Fedora 34), g_autofree does NOT include an attribute unused. Thus, does this silence the compiler? (Even cooler would be making the comment a link to an actual bug in the clang database, but I couldn't quickly find one) diff --git

Re: [PATCH 08/11] linux-user/syscall: Remove unused variable from execve

2021-07-13 Thread Laurent Vivier
Le 12/07/2021 à 23:55, Richard Henderson a écrit : > From clang-13: > linux-user/syscall.c:8503:17: error: variable 'total_size' set but not used \ > [-Werror,-Wunused-but-set-variable] > > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 3 --- > 1 file

[PATCH v2 1/3] docs: Add skeletal documentation of cubieboard

2021-07-13 Thread Peter Maydell
Add skeletal documentation of the cubieboard machine. Signed-off-by: Peter Maydell --- docs/system/arm/cubieboard.rst | 16 docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 18 insertions(+) create mode 100644

Re: [Virtio-fs] [PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table

2021-07-13 Thread Max Reitz
So I’m coming back to this after three weeks (well, PTO), and this again turns into a bit of a pain, actually. I don’t think it’s anything serious, but I had thought we had found something that would make us both happy because it wouldn’t be too ugly, and now it’s turning ugly again...  So

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-13 Thread Cole Robinson
On 7/13/21 10:43 AM, Richard Henderson wrote: > On 7/12/21 5:37 PM, Richard Henderson wrote: >> On 7/12/21 2:30 PM, Cole Robinson wrote: >>> On 7/12/21 11:59 AM, Richard Henderson wrote: The first two patches are not strictly required, but they were useful in tracking down the root

Re: VFIO/vfio-user: specify NVMe namespace to boot from

2021-07-13 Thread Stefan Hajnoczi
On Mon, Jul 12, 2021 at 01:24:07PM +, Thanos Makatos wrote: > We're working on implementing a virtual NVMe controller based on SPDK and a > multiprocess-qemu branch that uses the vfio-user. We're facing a problem > where the existing API doesn't allow us to tell QEMU from which NVMe >

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-13 Thread Stefan Hajnoczi
On Mon, Jul 12, 2021 at 10:42:47AM +0200, Emanuele Giuseppe Esposito wrote: > On 08/07/2021 15:09, Stefan Hajnoczi wrote: > > On Wed, Jul 07, 2021 at 06:58:07PM +0200, Emanuele Giuseppe Esposito wrote: > > > This is a continuation on the work to reduce (and possibly get rid of) > > > the usage of

Re: [RFC PATCH 2/6] job: _locked functions and public job_lock/unlock for next patch

2021-07-13 Thread Stefan Hajnoczi
On Mon, Jul 12, 2021 at 10:43:07AM +0200, Emanuele Giuseppe Esposito wrote: > > > On 08/07/2021 12:50, Stefan Hajnoczi wrote: > > On Wed, Jul 07, 2021 at 06:58:09PM +0200, Emanuele Giuseppe Esposito wrote: > > > diff --git a/job.c b/job.c > > > index 872bbebb01..96fb8e9730 100644 > > > ---

[PATCH for-6.2 07/34] target/arm: Fix calculation of LTP mask when LR is 0

2021-07-13 Thread Peter Maydell
In mve_element_mask(), we calculate a mask for tail predication which should have a number of 1 bits based on the value of LR. However, our MAKE_64BIT_MASK() macro has undefined behaviour when passed a zero length. Special case this to give the all-zeroes mask we require. Signed-off-by: Peter

[PATCH for-6.2 19/34] target/arm: Move 'x' and 'a' bit definitions into vmlaldav formats

2021-07-13 Thread Peter Maydell
All the users of the vmlaldav formats have an 'x bit in bit 12 and an 'a' bit in bit 5; move these to the format rather than specifying them in each insn pattern. Signed-off-by: Peter Maydell --- Not sure why I didn't write it this way in the first place; when I came to implement VMLADAV I

[PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts

2021-07-13 Thread Peter Maydell
In do_sqrshl48_d() and do_uqrshl48_d() we got some of the edge cases wrong and failed to saturate correctly: (1) In do_sqrshl48_d() we used the same code that do_shrshl_bhs() does to obtain the saturated most-negative and most-positive 48-bit signed values for the large-shift-left case. This

[PATCH for-6.2 24/34] target/arm: Implement MVE VMLADAV and VMLSLDAV

2021-07-13 Thread Peter Maydell
Implement the MVE VMLADAV and VMLSLDAV insns. Like the VMLALDAV and VMLSLDAV insns already implemented, these accumulate multiplied vector elements; but they accumulate a 32-bit result rather than a 64-bit one. Note that these encodings overlap with what would be RdaHi=0b111 for VMLALDAV,

[PATCH for-6.2 14/34] target/arm: Implement MVE integer vector comparisons

2021-07-13 Thread Peter Maydell
Implement the MVE integer vector comparison instructions. These are "VCMP (vector)" encodings T1, T2 and T3, and "VPT (vector)" encodings T1, T2 and T3. These insns compare corresponding elements in each vector, and update the VPR.P0 predicate bits with the results of the comparison. VPT also

[PATCH for-6.2 31/34] target/arm: Implement MVE VCTP

2021-07-13 Thread Peter Maydell
Implement the MVE VCTP insn, which sets the VPR.P0 predicate bits so as to predicate any element at index Rn or greater is predicated. As with VPNOT, this insn itself is predicable and subject to beatwise execution. The calculation of the mask is the same as is used to determine ltpmask in

[PATCH for-6.2 33/34] target/arm: Implement MVE scatter-gather immediate forms

2021-07-13 Thread Peter Maydell
Implement the MVE VLDR/VSTR insns which do scatter-gather using base addresses from Qm plus or minus an immediate offset (possibly with writeback). Note that writeback is not predicated but it does have to honour ECI state, so we have to add an eci_mask check to the VSTR_SG macros (the VLDR_SG

[PATCH for-6.2 26/34] target/arm: Implement MVE saturating doubling multiply accumulates

2021-07-13 Thread Peter Maydell
Implement the MVE saturating doubling multiply accumulate insns VQDMLAH, VQRDMLAH, VQDMLASH and VQRDMLASH. These perform a multiply, double, add the accumulator shifted by the element size, possibly round, saturate to twice the element size, then take the high half of the result. The *MLAH insns

[PATCH for-6.2 32/34] target/arm: Implement MVE scatter-gather insns

2021-07-13 Thread Peter Maydell
Implement the MVE gather-loads and scatter-stores which form the address by adding a base value from a scalar register to an offset in each element of a vector. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 32 + target/arm/mve.decode | 12

[PULL 00/12] Linux user for 6.1 patches

2021-07-13 Thread Laurent Vivier
-pull-request for you to fetch changes up to 2fa4ad3f9000c385f71237984fdd1eefe2a91900: linux-user: update syscall.tbl to Linux v5.13 (2021-07-13 13:59:59 +0200) Linux-user pull request 20210713 Update headers to linux v5.13 cleanup

Re: [PULL 00/22] Crypto and more patches

2021-07-13 Thread Peter Maydell
On Tue, 13 Jul 2021 at 14:45, Daniel P. Berrangé wrote: > Can you confirm what version of gnutls and nettle you have installed > and what distro this is Debian GNU/Linux 11 (bullseye) libgnutls28-dev:ppc64 3.7.1-5 libgnutls30:ppc64 3.7.1-5 nettle-dev:ppc64

Re: [PATCH 0/3] Atomic cleanup + clang-12 build fix

2021-07-13 Thread Richard Henderson
On 7/12/21 5:37 PM, Richard Henderson wrote: On 7/12/21 2:30 PM, Cole Robinson wrote: On 7/12/21 11:59 AM, Richard Henderson wrote: The first two patches are not strictly required, but they were useful in tracking down the root problem here. I understand the logic behind the clang-12 warning,

[PULL v2 0/4] Fuzzing Patches

2021-07-13 Thread Alexander Bulekov
Hello Paolo, The following changes since commit 711c0418c8c1ce3a24346f058b001c4c5a2f0f81: Merge remote-tracking branch 'remotes/philmd/tags/mips-20210702' into staging (2021-07-04 14:04:12 +0100) are available in the Git repository at: https://gitlab.com/a1xndr/qemu

[PULL v2 1/4] fuzz: fix sparse memory access in the DMA callback

2021-07-13 Thread Alexander Bulekov
The code mistakenly relied on address_space_translate to store the length remaining until the next memory-region. We care about this because when there is RAM or sparse-memory neighboring on an MMIO region, we should only write up to the border, to prevent inadvertently invoking MMIO handlers

Re: [PULL v2 0/4] NBD patches for soft freeze, 2021-07-09

2021-07-13 Thread Peter Maydell
On Mon, 12 Jul 2021 at 18:52, Eric Blake wrote: > > The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' > into staging (2021-07-12 11:02:39 +0100) > > are available in the Git repository at: >

[PULL v2 3/4] fuzz: make object-name matching case-insensitive

2021-07-13 Thread Alexander Bulekov
We have some configs for devices such as the AC97 and ES1370 that were not matching memory-regions correctly, because the configs provided lowercase names. To resolve these problems and prevent them from occurring again in the future, convert both the pattern and names to lower-case, prior to

Re: [PATCH v4 00/10] tests: Add test cases for TPM 1.2 ACPI tables

2021-07-13 Thread Michael S. Tsirkin
On Mon, Jul 12, 2021 at 04:47:26PM -0400, Stefan Berger wrote: > This series of patches adds test case for TPM 1.2 ACPI tables. Acked-by: Michael S. Tsirkin Pls feel free to merge through tpm tree. > Stefan > > v4: > - Added patch 10 that checks for availability of a TPM device model >

[PULL 1/6] migration/rdma: prevent from double free the same mr

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: Li Zhijian backtrace: '0x75f44ec2 in __ibv_dereg_mr_1_1 (mr=0x7fff1007d390) at /home/lizhijian/rdma-core/libibverbs/verbs.c:478 478 void *addr = mr->addr; (gdb) bt #0 0x75f44ec2 in __ibv_dereg_mr_1_1 (mr=0x7fff1007d390) at

[PULL 0/6] migration queue

2021-07-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 708f50199b59476ec4b45ebcdf171550086d6292: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-07-09-v2' into staging (2021-07-13 14:32:20 +0100) are available in the Git repository at:

Re: [PATCH v3 0/8] dp8393x: fixes and improvements

2021-07-13 Thread Finn Thain
On Mon, 12 Jul 2021, Finn Thain wrote: > On Sun, 11 Jul 2021, Philippe Mathieu-Daudé wrote: > > > > > > If I'm right that the big_endian flag should go away, commit > > > b1600ff195 ("hw/mips/jazz: specify correct endian for dp8393x > > > device") has already taken mainline in the wrong

Re: [PATCH v2 1/3] hw: aspeed_gpio: Fix memory size

2021-07-13 Thread Rashmica Gupta
On Tue, 2021-07-13 at 16:28 +0930, Joel Stanley wrote: > The macro used to calculate the maximum memory size of the MMIO > region > had a mistake, causing all GPIO models to create a mapping of 0x9D8. > The intent was to have it be 0x9D8 - 0x800. > > This extra size doesn't matter on ast2400 and

[PATCH 3/4] configure: Fix the default setting of the "xen" feature

2021-07-13 Thread Thomas Huth
The "xen" variable should either contain "enabled", "disabled" or nothing (for auto detection). But when the user currently runs the configure script with --without-default-features, it gets set to "no" instead. This does not work as expected, the feature will still be enabled if the Xen headers

Re: [PULL 04/15] RISC-V: Copy the fdt in dram instead of ROM

2021-07-13 Thread Peter Maydell
On Tue, 14 Jul 2020 at 01:44, Alistair Francis wrote: > > From: Atish Patra > > Currently, the fdt is copied to the ROM after the reset vector. The firmware > has to copy it to DRAM. Instead of this, directly copy the device tree to a > pre-computed dram address. The device tree load address

Re: [PATCH 01/11] nbd/server: Remove unused variable

2021-07-13 Thread Eric Blake
On Tue, Jul 13, 2021 at 12:27:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 13.07.2021 00:55, Richard Henderson wrote: > > From clang-13: > > nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ > > [-Werror,-Wunused-but-set-variable] > > > > +++ b/nbd/server.c > > @@

[PATCH for-6.2 10/34] target/arm: Fix VLDRB/H/W for predicated elements

2021-07-13 Thread Peter Maydell
For vector loads, predicated elements are zeroed, instead of retaining their previous values (as happens for most data processing operations). This means we need to distinguish "beat not executed due to ECI" (don't touch destination element) from "beat executed but predicated out" (zero

[PATCH for-6.2 17/34] target/arm: Implement MVE VMLAS

2021-07-13 Thread Peter Maydell
Implement the MVE VMLAS insn, which multiplies a vector by a vector and adds a scalar. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 31 +++ target/arm/translate-mve.c | 2

[PATCH for-6.2 22/34] target/arm: Implement MVE narrowing moves

2021-07-13 Thread Peter Maydell
Implement the MVE narrowing move insns VMOVN, VQMOVN and VQMOVUN. These take a double-width input, narrow it (possibly saturating) and store the result to either the top or bottom half of the output element. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 20 ++

[PATCH for-6.2 20/34] target/arm: Implement MVE integer min/max across vector

2021-07-13 Thread Peter Maydell
Implement the MVE integer min/max across vector insns VMAXV, VMINV, VMAXAV and VMINAV, which find the maximum from the vector elements and a general purpose register, and store the maximum back into the general purpose register. These insns overlap with VRMLALDAVH (they use what would be

[PULL 02/12] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé We want to have one generic target_errno.h (API to access target errno), and will add target errno definitions in target_errno_defs.h. The sparc target already have its errnos in an header, simply rename it. Reviewed-by: Laurent Vivier Reviewed-by: Richard

[PULL 04/12] linux-user/alpha: Move errno definitions to 'target_errno_defs.h'

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210708170550.1846343-5-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/target_errno_defs.h | 198 +++

Re: [PULL 00/22] Crypto and more patches

2021-07-13 Thread Daniel P . Berrangé
On Tue, Jul 13, 2021 at 10:25:44AM +0100, Peter Maydell wrote: > On Mon, 12 Jul 2021 at 14:23, Daniel P. Berrangé wrote: > > > > The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: > > > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' > >

[PULL 01/12] linux-user/syscall: Fix RF-kill errno (typo in ERFKILL)

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Affected targets: alpha, hppa, mips/64, sparc Fixes: fe8ed7d5794 ("linux-user: Handle ERFKILL and EHWPOISON") Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210708170550.1846343-2-f4...@amsat.org>

[PULL 05/12] linux-user/hppa: Move errno definitions to 'target_errno_defs.h'

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210708170550.1846343-6-f4...@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/hppa/target_errno_defs.h | 214

[PULL 08/12] linux-user/syscall: Remove ERRNO_TABLE_SIZE check

2021-07-13 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Now than target_to_host_errno() always return an errno, we can remove the unused and arbitrary ERRNO_TABLE_SIZE definition. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson

Re: [RFC PATCH 0/6] Add AMD Secure Nested Paging (SEV-SNP) support

2021-07-13 Thread Brijesh Singh
On 7/13/21 3:31 AM, Dr. David Alan Gilbert wrote: adding it to QMP as well (unles sit's purely for debug and may change). We have query-sev QMP, I will extend to add a new 'snp: bool' field. thanks

[PATCH v2 2/3] docs: Add skeletal documentation of the emcraft-sf2

2021-07-13 Thread Peter Maydell
Add skeletal documentation of the emcraft-sf2 machine. Signed-off-by: Peter Maydell --- docs/system/arm/emcraft-sf2.rst | 15 +++ docs/system/target-arm.rst | 1 + MAINTAINERS | 1 + 3 files changed, 17 insertions(+) create mode 100644

usb-host device not working

2021-07-13 Thread Programmingkid
I have been having problems with using host USB devices lately. I use to be able to use host USB devices but can't currently. After doing some git bisecting I found it was this patch that causes this issue: commit 627302afb2f85cdd4b59595361876487aef19b7a (refs/bisect/bad) Author: Gerd Hoffmann

Re: [PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)

2021-07-13 Thread Peter Maydell
On Sat, 10 Jul 2021 at 00:07, Richard Henderson wrote: > > This one patch fixes boot_linux_console test_arm_virt. > > It does not fix all of the failures. The next one on the > list is test_arm_emcraft_sf2, where the cpu boots fine but > the net device doesn't work correctly. Applied to

Re: [PATCH 0/4] Fixes for the --without-default-features configure switch

2021-07-13 Thread Cole Robinson
On 7/13/21 5:31 AM, Thomas Huth wrote: > Many features do not get properly disabled when the user runs the > configure script with --without-default-features. Let's fix that now. > > Thomas Huth (4): > configure: Fix --without-default-features propagation to meson > configure: Allow vnc to

Re: usb-host device not working

2021-07-13 Thread Programmingkid
> On Jul 13, 2021, at 10:54 AM, Daniel P. Berrangé wrote: > > On Tue, Jul 13, 2021 at 10:49:12AM -0400, Programmingkid wrote: >> I have been having problems with using host USB devices lately. I use to be >> able to use host USB devices but can't currently. After doing some git >> bisecting

  1   2   3   4   >