The NUMA information in PCMachineState is copied from MachineState.
We get this information uniformly from struct NumaState in MachineState.
Signed-off-by: Jingqi Liu
---
hw/i386/acpi-build.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c
Hello,
On 8/3/21 1:22 AM, Lindsay Ryan wrote:
> Hi Cedric,
> Thanks for replying.
> I think I want to go down the PowerNV Power 9
> Which I will need the OpenPower firmware.
> Looks like the webpage for downloading prebuild witherspoon and skiboot is
> down/dead. Hasn't been working for me for
Hi,
This is new version (v4) of the series [1] that I have posted to introduce
some fixes and improvement for SMP parsing.
[1]
https://lore.kernel.org/qemu-devel/20210728034848.75228-1-wangyana...@huawei.com/
Most of this series is about the SMP parsers:
maxcpus is now uniformly used to
Now that all the possible topology parameters are integrated in struct
CpuTopology, tweak the order of topology members to be "cpus/sockets/
dies/cores/threads/maxcpus" for readability and consistency. We also
tweak the comment by adding explanation of dies parameter.
Reviewed-by: Pankaj Gupta
In the real SMP hardware topology world, it's much more likely that
we have high cores-per-socket counts and few sockets totally. While
the current preference of sockets over cores in smp parsing results
in a virtual cpu topology with low cores-per-sockets counts and a
large number of sockets,
We are currently using maxcpus to calculate the omitted sockets
but using cpus to calculate the omitted cores/threads. This makes
cmdlines like:
-smp cpus=8,maxcpus=16
-smp cpus=8,cores=4,maxcpus=16
-smp cpus=8,threads=2,maxcpus=16
work fine but the ones like:
-smp
From: padmakar
This patch contains the implementation of certain commands
of nvme-mi specification.The MI commands are useful to
manage/configure/monitor the device.Eventhough the MI commands
can be sent via the inband NVMe-MI send/recieve commands, the idea
here is to emulate the sideband
On Tue, Aug 03, 2021 at 04:05:26PM +0800, Yanan Wang wrote:
> We are going to introduce an unit test for the parser smp_parse()
> in hw/core/machine.c, but now machine.c is only built in softmmu.
>
> In order to solve the build dependency on the smp parsing code and
> avoid building unrelated
On Tue, Aug 03, 2021 at 04:05:27PM +0800, Yanan Wang wrote:
> Add a QEMU unit test for the parsing of given SMP configuration.
> Since all the parsing logic is in generic function smp_parse(),
> this test passes different SMP configurations to the function
> and compare the parsing result with
On Fri, Jul 23, 2021 at 02:28:24PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> "chr_option_parsed" is only implemented by the "mux" chardev, we can
> specialize the code there to avoid the needless generic class method.
>
> Signed-off-by: Marc-André Lureau
> ---
>
On Tue, 3 Aug 2021 at 00:55, Philippe Mathieu-Daudé wrote:
>
> OSS-Fuzz found sending illegal addresses when querying the write
> protection bits triggers the assertion added in commit 84816fb63e5
> ("hw/sd/sdcard: Assert if accessing an illegal group"):
>
>
We are going to introduce an unit test for the parser smp_parse()
in hw/core/machine.c, but now machine.c is only built in softmmu.
In order to solve the build dependency on the smp parsing code and
avoid building unrelated stuff for the unit tests, move the related
code from machine.c into a new
Add 6.2 machine types for arm/i440fx/q35/s390x/spapr.
Reviewed-by: Pankaj Gupta
Reviewed-by: Cornelia Huck
Reviewed-by: Andrew Jones
Acked-by: David Gibson
Signed-off-by: Yanan Wang
---
hw/arm/virt.c | 9 -
hw/core/machine.c | 3 +++
hw/i386/pc.c
We have two requirements for a valid SMP configuration:
the product of "sockets * cores * threads" must represent all the
possible cpus, i.e., max_cpus, and then must include the initially
present cpus, i.e., smp_cpus.
So we only need to ensure 1) "sockets * cores * threads == maxcpus"
at first
Currently the only difference between smp_parse and pc_smp_parse
is the support of dies parameter and the related error reporting.
With some arch compat variables like "bool dies_supported", we can
make smp_parse generic enough for all arches and the PC specific
one can be removed.
Making
在 2021/8/3 下午1:51, Chao Gao 写道:
On Tue, Aug 03, 2021 at 12:43:58PM +0800, Jason Wang wrote:
在 2021/8/3 下午12:29, Chao Gao 写道:
Ping. Could someone help to review this patch?
Thanks
Chao
On Wed, Jul 21, 2021 at 03:54:02PM +0800, Chao Gao wrote:
If guest enables IOMMU_PLATFORM for virtio-net,
On Tue, 3 Aug 2021 at 01:37, ishii.shuuic...@fujitsu.com
wrote:
>
> > I'm afraid this isn't the way a v2 patchseries should be structured.
> > The idea is that a v2 series should be complete in itself, not based on
> > whatever v1
> > was. So when you make the changes requested in review of v1,
Paolo Bonzini writes:
[...]
> This series is a sort of FYI; since the only way to debug the model file
> is to upload it to scan.coverity.com, these changes are all already live.
When I mess with Coverity, I test with my locally installed version
first. Version skew and lack of the web
On Fri, 30 Jul 2021 04:40:45 -0300
Leonardo Bras wrote:
> From source host viewpoint, losing a connection during migration will
> cause the sockets to get stuck in sendmsg() syscall, waiting for
> the receiving side to reply.
>
> In migration, yank works by shutting-down the migration
On Tue, Aug 3, 2021 at 8:36 AM Michael Roth wrote:
> libstdc++ is required for the qga-vss.dll that provides fsfreeze
> functionality. Currently it is not provided by the MSI installer,
> resulting in fsfreeze being disabled in guest environments where it has
> not been installed by other means.
Currently we directly calculate the omitted cpus based on the given
incomplete collection of parameters. This makes some cmdlines like:
-smp maxcpus=16
-smp sockets=2,maxcpus=16
-smp sockets=2,dies=2,maxcpus=16
-smp sockets=2,cores=4,maxcpus=16
not work. We should probably set the value of
Add a QEMU unit test for the parsing of given SMP configuration.
Since all the parsing logic is in generic function smp_parse(),
this test passes different SMP configurations to the function
and compare the parsing result with what is expected.
In the test, all possible collections of the
On 7/22/21 7:42 PM, Pierre Morel wrote:
Interception of the PTF instruction depending on the new
KVM_CAP_S390_CPU_TOPOLOGY KVM extension.
Signed-off-by: Pierre Morel
---
hw/s390x/s390-virtio-ccw.c | 45 ++
include/hw/s390x/s390-virtio-ccw.h | 7 +
To pave the way for the functional improvement in later patches,
make some refactor/cleanup for the smp parsers, including using
local maxcpus instead of ms->smp.max_cpus in the calculation,
defaulting dies to 0 initially like other members, cleanup the
sanity check for dies.
No functional change
Hi
On Tue, Aug 3, 2021 at 12:55 AM Peter Maydell
wrote:
> On Mon, 2 Aug 2021 at 19:58, Marc-André Lureau
> wrote:
> >
> > Hi Peter
> >
> > On Sun, Aug 1, 2021 at 4:10 PM Peter Maydell
> wrote:
> >>
> >> On Wed, 28 Jul 2021 at 16:47, Marc-André Lureau
> >> wrote:
> >> > I wish my previous
On Fri, Jul 23, 2021 at 02:28:23PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The "serial" chardev calls qemu_chr_open_fd() with the same fd. This
> may lead to double-close as each QIOChannel owns the fd.
>
> Instead, share the reference to the same QIOChannel.
>
Put both sanity-check of the input SMP configuration and sanity-check
of the output SMP configuration uniformly in the generic parser. Then
machine_set_smp() will become cleaner, also all the invalid scenarios
can be tested only by calling the parser.
Signed-off-by: Yanan Wang
---
Now we have a common structure SMPCompatProps used to store information
about SMP compatibility stuff, so we can also move smp_prefer_sockets
there for cleaner code.
No functional change intended.
Reviewed-by: Andrew Jones
Acked-by: David Gibson
Signed-off-by: Yanan Wang
---
hw/arm/virt.c
Now we have a generic smp parser for all arches, and there will
not be any other arch specific ones, so let's remove the callback
from MachineClass and call the parser directly.
Reviewed-by: Andrew Jones
Signed-off-by: Yanan Wang
---
hw/core/machine.c | 3 +--
include/hw/boards.h | 5 -
On Tue, 3 Aug 2021 04:18:42 -0300
Leonardo Bras Soares Passos wrote:
> Hello Lukas,
>
> On Tue, Aug 3, 2021 at 3:42 AM Lukas Straub wrote:
> > Hi,
> > There is an easier explanation: I forgot the send side of multifd
> > altogether (I thought it was covered by migration_channel_connect()).
> >
On Fri, Jul 23, 2021 at 02:28:22PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The "file" chardev may call qemu_chr_open_fd() with fd_in=-1. This may
> cause invalid system calls, as the QIOChannel is assumed to be properly
> initialized later on.
>
> Signed-off-by:
Hi Alex,
We found that the msix_load() will cost 40~50ms if the VF has 60+ interrupts,
the following code cost too much for each interrupt:
msix_load:
for (vector = 0; vector < 60; vector++)
msix_handle_mask_update
vfio_msix_vector_do_use
vfio_add_kvm_msi_virq
Hello Lukas,
On Tue, Aug 3, 2021 at 3:42 AM Lukas Straub wrote:
> Hi,
> There is an easier explanation: I forgot the send side of multifd
> altogether (I thought it was covered by migration_channel_connect()).
> So yank won't actually shutdown() the multifd sockets on the send side.
If I could
In the sanity-check of smp_cpus and max_cpus against mc in function
machine_set_smp(), we are now using ms->smp.max_cpus for the check
but using current_machine->smp.max_cpus in the error message.
Tweak this by uniformly using the local ms.
Reviewed-by: Cornelia Huck
Reviewed-by: Pankaj Gupta
On Tue, Aug 03, 2021 at 04:05:14PM +0800, Yanan Wang wrote:
> To pave the way for the functional improvement in later patches,
> make some refactor/cleanup for the smp parsers, including using
> local maxcpus instead of ms->smp.max_cpus in the calculation,
> defaulting dies to 0 initially like
On Tue, Aug 03, 2021 at 04:05:25PM +0800, Yanan Wang wrote:
> Put both sanity-check of the input SMP configuration and sanity-check
> of the output SMP configuration uniformly in the generic parser. Then
> machine_set_smp() will become cleaner, also all the invalid scenarios
> can be tested only
On Fri, Jul 23, 2021 at 02:28:25PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> include/chardev/char.h | 33 +
> 1 file changed, 33 insertions(+)
>
> diff --git a/include/chardev/char.h
On Tue, 3 Aug 2021 at 00:55, Philippe Mathieu-Daudé wrote:
>
> Per the 'Physical Layer Simplified Specification Version 3.01',
> Table 4-22: 'Block Oriented Write Protection Commands'
>
> SEND_WRITE_PROT (CMD30)
>
> If the card provides write protection features, this command asks
> the
Hello Dave,
> > diff --git a/migration/multifd.c b/migration/multifd.c
> > index 377da78f5b..744a180dfe 100644
> > --- a/migration/multifd.c
> > +++ b/migration/multifd.c
> > @@ -1040,6 +1040,17 @@ void multifd_recv_sync_main(void)
> >
Hi
On Tue, Aug 3, 2021 at 1:54 AM Stefan Berger wrote:
> Use QMP to check whether a given TPM device model is available and if it
> is not the case then do not register the tests that require it.
>
> Signed-off-by: Stefan Berger
>
lgtm
Reviewed-by: Marc-André Lureau
---
>
On Mon, Jul 05 2021, Ilya Leoshkevich wrote:
> qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it
> should be a pointer to the instruction following the illegal
> instruction, but at the moment it is a pointer to the illegal
> instruction itself. This breaks OpenJDK, which
On Tue, 3 Aug 2021 at 09:30, Marc-André Lureau
wrote:
> On Tue, Aug 3, 2021 at 12:55 AM Peter Maydell
> wrote:
>> This one is still here:
>>
>> subprojects/libslirp/libslirp.so.0.3.1.p/src_arp_table.c.o: In
>> function `arp_table_add':
>>
On 8/3/21 6:13 AM, Richard Henderson wrote:
> While we may have had some thought of allowing system-mode
> to return from this hook, we have no guests that require this.
>
> Signed-off-by: Richard Henderson
> ---
> include/hw/core/tcg-cpu-ops.h | 3 ++-
> target/alpha/cpu.h | 4
Markus Armbruster writes:
> Markus Armbruster writes:
>
> [...]
>
>>> Avoiding the redundant pair of parenthesis takes another special case.
>>> Let's do it.
>>
>> Looks like PATCH 07 does it. Avoiding the temporary change would be
>> nice, but isn't required.
>
> Make that PATCH 08.
Scratch
On 03.08.21 06:14, Richard Henderson wrote:
The helper_*_mmu functions were the only thing available
when this code was written. This could have been adjusted
when we added cpu_*_mmuidx_ra, but now we can most easily
use the newest set of interfaces.
Cc: qemu-s3...@nongnu.org
Reviewed-by:
On 05/07/2021 10.40, Philippe Mathieu-Daudé wrote:
Our infrastructure can handle fragmented packets up to
NET_MAX_FRAG_SG_LIST (64) pieces. This hard limit has
been proven enough in production for years. If it is
reached, it is likely an evil crafted packet. Discard it.
Include the qtest
Hi
On Tue, Aug 3, 2021 at 1:09 PM Peter Maydell
wrote:
> On Tue, 3 Aug 2021 at 09:30, Marc-André Lureau
> wrote:
> > On Tue, Aug 3, 2021 at 12:55 AM Peter Maydell
> wrote:
> >> This one is still here:
> >>
> >> subprojects/libslirp/libslirp.so.0.3.1.p/src_arp_table.c.o: In
> >> function
On Tue, 3 Aug 2021 at 10:08, Peter Maydell wrote:
> Are you testing by starting with a before-the-libslirp-merge
> change QEMU, doing a build, then updating to the libslirp
> changes, and then doing a 'make' without reconfigure or
> 'make clean' ? I suspect this is perhaps to do with it being
>
This doesn't exist in BSD world and doesn't seem to be needed by
either.
Signed-off-by: Alex Bennée
Cc: Warner Losh
---
tests/tcg/multiarch/sha1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c
index 87bfbcdf52..0081bd7657 100644
---
Hi
On Tue, Aug 3, 2021 at 1:50 PM Peter Maydell
wrote:
> On Tue, 3 Aug 2021 at 10:08, Peter Maydell
> wrote:
> > Are you testing by starting with a before-the-libslirp-merge
> > change QEMU, doing a build, then updating to the libslirp
> > changes, and then doing a 'make' without reconfigure
From: Marc-André Lureau
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1984721
Signed-off-by: Marc-André Lureau
---
chardev/char.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index d959eec522..f59a61774b 100644
It looks like 'make check-acceptance' creates directories in
build/clang/tests/results which are huge and which it never
cleans up. For example one of my build directories (configured
just for arm targets) has over 350 'job-[timestamp]' directories,
many of which are 2.5GB or more in size.
I
One more thing...
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Replace the simple list sugar form with a recursive structure that will
> accept other operators in the following commits (all, any or not).
>
> Signed-off-by: Marc-André Lureau
> ---
[...]
> diff --git
On 8/3/21 11:33 AM, Thomas Huth wrote:
> On 05/07/2021 10.40, Philippe Mathieu-Daudé wrote:
>> Our infrastructure can handle fragmented packets up to
>> NET_MAX_FRAG_SG_LIST (64) pieces. This hard limit has
>> been proven enough in production for years. If it is
>> reached, it is likely an evil
Markus Armbruster writes:
[...]
>> Avoiding the redundant pair of parenthesis takes another special case.
>> Let's do it.
>
> Looks like PATCH 07 does it. Avoiding the temporary change would be
> nice, but isn't required.
Make that PATCH 08.
Markus Armbruster writes:
> marcandre.lur...@redhat.com writes:
>
>> From: Marc-André Lureau
>>
>> Instead of building prepocessor conditions from a list of string, use
>> the result generated from QAPISchemaIfCond.cgen() and hide the
>> implementation details.
>>
>> Signed-off-by: Marc-André
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > migration-test hung again during 'make check'.
>
> ccing in Peter Xu
I've not managed to reproduce this here; I've had the migration tests
running in a loop for the last day just running
Ping ...
On Thu, 29 Jul 2021, Ani Sinha wrote:
> ping ...
>
> On Tue, 27 Jul 2021, Ani Sinha wrote:
>
> > acpi_pcihp_reset() call from ich9/pm_reset() passes an unconditional truth
> > value
> > as the second argument. Added a commnet here to explain the reason why the
> > argument is being
On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell wrote:
>
> It looks like 'make check-acceptance' creates directories in
> build/clang/tests/results which are huge and which it never
> cleans up. For example one of my build directories (configured
> just for arm targets) has over 350
On 8/3/21 6:14 AM, Richard Henderson wrote:
> The helper_*_mmu functions were the only thing available
> when this code was written. This could have been adjusted
> when we added cpu_*_mmuidx_ra, but now we can most easily
> use the newest set of interfaces.
>
> Cc: Mark Cave-Ayland
>
On 8/3/21 6:13 AM, Richard Henderson wrote:
> We shouldn't be ignoring SIGBUS for user-only.
>
> Move our existing TCGCPUOps hook out from CONFIG_SOFTMMU.
> Move the wrapper, cpu_unaligned_access, to cpu-exec-common.c.
>
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/internal.h
Le 03/08/2021 à 10:13, Cornelia Huck a écrit :
> On Mon, Jul 05 2021, Ilya Leoshkevich wrote:
>
>> qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it
>> should be a pointer to the instruction following the illegal
>> instruction, but at the moment it is a pointer to the illegal
There are not many cases you would want to do this but one is if you
want to use a test friendly compiler like gcc instead of a system
compiler like clang. Either way we should honour the users choice if
they have made it.
Signed-off-by: Alex Bennée
Cc: Warner Losh
---
configure | 7 +--
1
Hi Warner,
Here are some hacks I made to nominally get the check-tcg system
working on the BSD user builds. The first step was installing GCC as
we skip clang for x86 builds due to inline assembly issues:
../src/configure --disable-system --enable-user \
--python=/usr/local/bin/python3.7
Not all of the multiarch tests are pure POSIX so elide over those
tests on a non-Linux system. This allows for at least some of the
tests to be nominally usable by *BSD user builds.
Signed-off-by: Alex Bennée
Cc: Warner Losh
---
tests/tcg/multiarch/Makefile.target | 6 +-
ping ...
On Thu, 29 Jul 2021, Ani Sinha wrote:
>
>
> On Thu, 29 Jul 2021, Ani Sinha wrote:
>
> >
> >
> > On Wed, 28 Jul 2021, Michael S. Tsirkin wrote:
> >
> > > On Mon, Jul 26, 2021 at 10:27:43PM +0530, Ani Sinha wrote:
> > > > All existing code using acpi_get_i386_pci_host() checks for a
02.08.2021 13:23, Max Reitz wrote:
On 27.07.21 17:47, Vladimir Sementsov-Ogievskiy wrote:
27.07.2021 18:39, Max Reitz wrote:
On 27.07.21 15:04, Vladimir Sementsov-Ogievskiy wrote:
26.07.2021 17:46, Max Reitz wrote:
Most callers of job_is_cancelled() actually want to know whether the job
is
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Replace the simple list sugar form with a recursive structure that will
> accept other operators in the following commits (all, any or not).
>
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi/common.py
On Tue, 3 Aug 2021 at 13:58, Cleber Rosa wrote:
>
> On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell wrote:
> >
> > It looks like 'make check-acceptance' creates directories in
> > build/clang/tests/results which are huge and which it never
> > cleans up. For example one of my build directories
On Tue, Jul 27, 2021 at 10:15:46AM +0530, Ani Sinha wrote:
> acpi_pcihp_reset() call from ich9/pm_reset() passes an unconditional truth
> value
> as the second argument. Added a commnet here to explain the reason why the
> argument is being passed unconditionally.
>
> Signed-off-by: Ani Sinha
>
Am 26.07.2021 um 16:46 hat Max Reitz geschrieben:
> Most callers of job_is_cancelled() actually want to know whether the job
> is on its way to immediate termination. For example, we refuse to pause
> jobs that are cancelled; but this only makes sense for jobs that are
> really actually
Am 26.07.2021 um 16:46 hat Max Reitz geschrieben:
> We must check whether the job is force-cancelled early in our main loop,
> most importantly before any `continue` statement. For example, we used
> to have `continue`s before our current checking location that are
> triggered by `mirror_flush()`
On 03/08/2021 16:04, Michael S. Tsirkin wrote:
> On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote:
>> The intend of failover is to allow to migrate a VM with a VFIO
>> networking card without disrupting the network operation by switching
>> to a virtio-net device during the
On Fri, Jul 30, 2021 at 11:38 AM Thomas Huth wrote:
>
> Both jobs are testing more or less the same thing (building QEMU with
> features disabled), so we are wasting precious CI cycles here by doing
> this twice. Merge the jobs by using --without-default-features by default
> and just adding some
On Tue, 3 Aug 2021 at 15:14, Axel Heider wrote:
>
> Signed-off-by: Axel Heider
> ---
> qemu-options.hx | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index e3f256fa72..ed91246114 100644
> ---
Signed-off-by: Mahmoud Mandour
---
docs/devel/tcg-plugins.rst | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 7e54f12837..863828809d 100644
--- a/docs/devel/tcg-plugins.rst
+++
On Tue, 3 Aug 2021 at 15:29, Leif Lindholm wrote:
>
> On Mon, Jul 26, 2021 at 17:33:51 +0100, Peter Maydell wrote:
> > If the user provides both a BIOS/firmware image and also a guest
> > kernel filename, arm_setup_firmware_boot() will pass the
> > kernel image to the firmware via the fw_cfg
Richard Henderson writes:
> We shouldn't be ignoring SIGBUS for user-only.
>
> Move our existing TCGCPUOps hook out from CONFIG_SOFTMMU.
> Move the wrapper, cpu_unaligned_access, to cpu-exec-common.c.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
From: mohit kapoor
Subject: [RFC PATCH : v3 2/2] Implementation of nvme-mi plugin in nvme-cli
The enclosed patch contains the implementation of a new
nvme mi(Management Interface) plugin. By adding the mi plugin into the
nvme-cli application, users have the ability to test the mi commands,
libstdc++ is required for the qga-vss.dll that provides fsfreeze
functionality. Currently it is not provided by the MSI installer,
resulting in fsfreeze being disabled in guest environments where it has
not been installed by other means.
In the future this would be better handled via gcc-cpp
From: Gerd Hoffmann
This is what I find on my Fedora 34 mingw install.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Michael Roth
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index
From: Kostiantyn Kostiuk
The g_regex_match function creates match_info even if it
returns FALSE. So we should always call g_match_info_free.
A better solution is using g_autoptr for match_info variable.
Signed-off-by: Kostiantyn Kostiuk
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Philippe
From: Basil Salman
In ga_get_win_product_name() a handle to Registry key was open but not
closed.
In this patch the handle is closed as part of the free routine.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1929144
Signed-off-by: Basil Salman
Signed-off-by: Basil Salman
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Change the 'if' condition strings to be C-agnostic and be simple
> identifiers.
This is less general, and that's okay, we're doing it for a purpose.
But the commit message should mention / explain all this.
> Signed-off-by:
On 210803 0155, Philippe Mathieu-Daudé wrote:
> Fix an assertion reported by OSS-Fuzz, add corresponding qtest.
>
> The change is (now) simple enough for the next rc.
>
> Since v1:
> - Simplified/corrected following Peter's suggestion
>
> Philippe Mathieu-Daudé (2):
> hw/sd/sdcard: Document
From f780b0ee2ee36c562ab814915fff0e7217b25e63 Mon Sep 17 00:00:00 2001
From: Jianxian Wen
Date: Tue, 3 Aug 2021 09:44:35 +0800
Subject: [PATCH] hw/dma/pl330: Add memory region to replace default
address_space_memory
PL330 needs a memory region which can connect with SMMU translate IOMMU region
On Tue, Aug 3, 2021, 5:02 AM Alex Bennée wrote:
> This doesn't exist in BSD world and doesn't seem to be needed by
> either.
>
Sys/endian.h is common. FreeBSD has endian.h, but others don't.
Signed-off-by: Alex Bennée
> Cc: Warner Losh
>
Acked by: Warner Losh
> ---
>
Am 26.07.2021 um 16:46 hat Max Reitz geschrieben:
> Callers should be able to specify whether they want job_cancel_sync() to
> force-cancel the job or not.
>
> In fact, almost all invocations do not care about consistency of the
> result and just want the job to terminate as soon as possible, so
On Tue, 3 Aug 2021 16:43:07 +0800
"Longpeng (Mike, Cloud Infrastructure Service Product Dept.)"
wrote:
> Hi Alex,
>
> We found that the msix_load() will cost 40~50ms if the VF has 60+ interrupts,
> the following code cost too much for each interrupt:
>
> msix_load:
> for (vector = 0; vector
From: Marc-André Lureau
Switch from stable-4.2 branch to upstream v4.6.1 release + fixes.
## [Unreleased]
### Fixed
- Haiku fixes. !98 !99
- Fix a minor DHCP regression introduced in 4.6.0. !97
## [4.6.1] - 2021-06-18
### Fixed
- Fix DHCP regression introduced in 4.6.0. !95
## [4.6.0]
On Tue, Aug 3, 2021 at 7:55 AM Warner Losh wrote:
>
>
> On Tue, Aug 3, 2021, 5:02 AM Alex Bennée wrote:
>
>> This doesn't exist in BSD world and doesn't seem to be needed by
>> either.
>>
>
> Sys/endian.h is common. FreeBSD has endian.h, but others don't.
>
> Signed-off-by: Alex Bennée
>> Cc:
Quoting Daniel P. Berrangé (2021-07-26 05:13:41)
> We are currently in the final lead up to shipping the 6.1.0 release
>
> AFAICT from git tags, the latest stable release was 5.0.1 in Sep 2020
>
>https://gitlab.com/qemu-project/qemu/-/tags
>
> There have been many patches sent to
When bdrv_pad_request() fails in bdrv_co_preadv_part(), bs->in_flight
has been increased, but is never decreased again. This leads to a hang
when trying to drain the block node.
This bug was observed with Windows guests which issue a request that
fully uses IOV_MAX during installation, so that
The following changes since commit 7f1cab9c628a798ae2607940993771e6300e9e00:
Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into
staging (2021-08-02 17:21:50 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you
On Mon, Jul 19, 2021 at 05:21:38PM +0300, Denis Plotnikov wrote:
> On vhost-user-blk migration, qemu normally sends a number of commands
> to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
> Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and
>
Hello,
This series introduce multicore cache modelling in contrib/plugins/cache.c
Multi-core cache modelling is handled such that for full-system
emulation, a private L1 cache is maintained to each core available to
the system. For multi-threaded userspace emulation, a static number of
cores is
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/unit/test-qmp-cmds.c | 1 +
> scripts/qapi/common.py | 4 ++--
> scripts/qapi/expr.py| 6 +++---
> tests/qapi-schema/bad-if.err
Hi Peter,
Sorry for the late submission. These patches affect only the w32 build of
qemu-ga. A number of these patches I've had queued for some time, but a bug
in the MSI installer that was just fixed was blocking testing. Now that that
is working again I am hoping to get these in along with a
From: Basil Salman
On the current error path of build_guest_fsinfo(), a non existent handle
is passed to CloseHandle().
This patch adds initialization of hLocalDiskHandle to
INVALID_HANDLE_VALUE, and checks for handle validity before the handle
is closed.
Signed-off-by: Basil Salman
From: Basil Salman
Currently Requester freeze times out after 10 seconds, while
the default timeout for Writer Freeze is 60 seconds. according to
VSS Documentation [1].
[1]:
https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-backup-under-vss
Buglink:
1 - 100 of 218 matches
Mail list logo
