Re: [PATCH 1/3] escc: checkpatch fixes

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 11:04, Mark Cave-Ayland wrote: > > Signed-off-by: Mark Cave-Ayland > --- > hw/char/escc.c | 160 + > 1 file changed, 96 insertions(+), 64 deletions(-) Reviewed-by: Peter Maydell You might want to fix this existing typo:

[PATCH 1/3] escc: checkpatch fixes

2021-08-29 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/char/escc.c | 160 + 1 file changed, 96 insertions(+), 64 deletions(-) diff --git a/hw/char/escc.c b/hw/char/escc.c index 52e7978287..63e0f15dfa 100644 --- a/hw/char/escc.c +++ b/hw/char/escc.c @@ -230,20

[PATCH 3/3] escc: fix STATUS_SYNC bit in R_STATUS register

2021-08-29 Thread Mark Cave-Ayland
After an SDLC "Enter hunt" command has been sent the STATUS_SYNC bit should remain high until the flag byte has been detected. Whilst the ESCC device doesn't yet implement SDLC mode, without this change the active low STATUS_SYNC is constantly asserted causing the MacOS OpenTransport extension

Re: [PATCH 0/3] escc: fix R_STATUS when SDLC mode is enabled

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 11:05, Mark Cave-Ayland wrote: > > Here is another small set of ESCC fixes from my attempts to boot MacOS on the > q800 > machine. > > When MacOS loads the OpenTransport extension on boot it attempts to enable > SDLC mode on the ESCC. QEMU's emulation doesn't support SDLC

[Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2021-08-29 Thread Bruno Haible
My last comment ("The issue seems to be fixed, even without the symlink for /usr/-linux-gnu/etc/ld.so.cache.") was incorrect. When this symlink is set, the program accesses /etc/ld.so.cache after accessing /usr/-linux-gnu/etc/ld.so.cache. In some cases, it works, in some cases it doesn't —

Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 11:18, Mark Cave-Ayland wrote: > What I don't understand is that the binary is installed by default in QEMU's > sharedir > so everything works out of the box with "make install". Do you have some kind > of > custom installer which is doing something different? John has

Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

2021-08-29 Thread Programmingkid
> On Aug 29, 2021, at 8:17 AM, Peter Maydell wrote: > > On Sun, 29 Aug 2021 at 11:18, Mark Cave-Ayland > wrote: >> What I don't understand is that the binary is installed by default in QEMU's >> sharedir >> so everything works out of the box with "make install". Do you have some >> kind of

Re: QEMU-KVM offers OPAL firmware interface? OpenBSD guest support?

2021-08-29 Thread Joseph
> runs Linux powernv bare metal on Power9 hardware. Each VM is a > KVM-QEMU instance. > > > If you want to also run OpenBSD inside a VM, then OpenBSD must > > > implement proper support to be able to run in the paravirtualized > > > PAPR environment provided by KVM-QEMU on POWER. The OpenBSD

[PATCH 2/3] escc: fix R_STATUS channel reset value

2021-08-29 Thread Mark Cave-Ayland
According to the "Z80X30 Register Reset Values" table in the ESCC datasheet bits 2 and 6 are set whilst bits 0 and 1 are cleared during channel reset. All other bits should be left unaltered. Signed-off-by: Mark Cave-Ayland --- hw/char/escc.c | 9 - 1 file changed, 4 insertions(+), 5

Re: QEMU-KVM offers OPAL firmware interface? OpenBSD guest support?

2021-08-29 Thread Joseph
Hi Mark, Cédric, Greg at the openbsd-ppc ML, It is great to talk to you. Thank you for taking on the conversation. Right, OpenBSD implements powernv meaning it runs on bare metal on Power9, that is great. What I wanted to ask about with this thread is: To have the same utility of Power9 as of

Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

2021-08-29 Thread Mark Cave-Ayland
On 27/08/2021 19:14, John Arbuckle wrote: I was having a problem with missing video resolutions in my Mac OS 9 VM. When I ran QEMU it gave no indication as to why these resolutions were missing. I found out that the OpenFirmware VGA driver was not being loaded. To prevent anyone from going

[PATCH 0/3] escc: fix R_STATUS when SDLC mode is enabled

2021-08-29 Thread Mark Cave-Ayland
Here is another small set of ESCC fixes from my attempts to boot MacOS on the q800 machine. When MacOS loads the OpenTransport extension on boot it attempts to enable SDLC mode on the ESCC. QEMU's emulation doesn't support SDLC mode, but without these fixes the active low STATUS_SYNC bit in

Re: [PATCH 3/3] escc: fix STATUS_SYNC bit in R_STATUS register

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 11:04, Mark Cave-Ayland wrote: > > After an SDLC "Enter hunt" command has been sent the STATUS_SYNC bit should > remain > high until the flag byte has been detected. Whilst the ESCC device doesn't yet > implement SDLC mode, without this change the active low STATUS_SYNC is

Re: [PATCH 2/3] escc: fix R_STATUS channel reset value

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 11:07, Mark Cave-Ayland wrote: > > According to the "Z80X30 Register Reset Values" table in the ESCC datasheet > bits 2 and 6 are set whilst bits 0 and 1 are cleared during channel reset. > All other bits should be left unaltered. > > Signed-off-by: Mark Cave-Ayland > ---

[PATCH 2/3] configure: Remove options that can be handled via meson_options.txt instead

2021-08-29 Thread Thomas Huth
These trivial options can now be handled via the new generic code that parses meson_options.txt Signed-off-by: Thomas Huth --- configure | 316 +- meson_options.txt | 2 +- 2 files changed, 5 insertions(+), 313 deletions(-) diff --git

[PATCH 1/3] configure: Add the possibility to read options from meson_options.txt

2021-08-29 Thread Thomas Huth
To avoid double maintenance between the configure script and meson_options.txt, add some simple logic in the configure script to read the options from meson_options.txt. Signed-off-by: Thomas Huth --- configure | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff

[PATCH 0/3] Use meson_options.txt in the configure script

2021-08-29 Thread Thomas Huth
It's cumbersome to maintain the build options twice, one time in the configure script and one time in meson_options.txt. Thus let's add some logic to the configure script to look at the meson_options.txt file instead of handling every option twice. Thomas Huth (3): configure: Add the

[Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2021-08-29 Thread Thomas Huth
Since there is some unclear information in here (which version is working? which is not?), could you please open a new ticket on gitlab instead, with a proper description what is not working with which version? -- You received this bug notification because you are a member of qemu- devel-ml,

[PATCH 3/3] configure: Get help text from meson_options.txt

2021-08-29 Thread Thomas Huth
It's cumbersome to maintain the option help texts twice, once in the "configure" script and once in meson_options.txt. So let's add some logic to the configure script to read most of the help texts from meson_options.txt. Signed-off-by: Thomas Huth --- configure | 89

[PATCH v10 2/7] [RISCV_PM] Add CSR defines for RISC-V PM extension

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/cpu_bits.h | 96 + 1 file changed, 96 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 7330ff5a19..140178d23c 100644 --- a/target/riscv/cpu_bits.h +++

[PATCH v10 1/7] [RISCV_PM] Add J-extension into RISC-V

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index bf1c899c00..451a1637a1 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h

[PATCH v10 3/7] [RISCV_PM] Support CSRs required for RISC-V PM extension except for the h-mode

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo --- target/riscv/cpu.c | 6 + target/riscv/cpu.h | 11 ++ target/riscv/csr.c | 276 + 3 files changed, 293 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 991a6bb760..4178eecbec 100644 ---

[PATCH v10 6/7] [RISCV_PM] Implement address masking functions required for RISC-V Pointer Masking extension

2021-08-29 Thread Alexey Baturo
From: Anatoly Parshintsev Signed-off-by: Anatoly Parshintsev Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 20 target/riscv/translate.c | 36 ++-- 2 files changed, 54 insertions(+), 2

[PATCH v10 0/7] RISC-V Pointer Masking implementation

2021-08-29 Thread Alexey Baturo
v10: Hi folks, For this iteration I fixes some minor things Alistair mentioned in review and splitted one of patches into two: one with preliminary CSR numbers(unfortunately there're still no final ones) and another with actual CSR implementation. As for not raising the exception on writing

[PATCH v10 5/7] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/insn_trans/trans_rva.c.inc | 3 +++ target/riscv/insn_trans/trans_rvd.c.inc | 2 ++ target/riscv/insn_trans/trans_rvf.c.inc | 2 ++ target/riscv/insn_trans/trans_rvi.c.inc | 2 ++

applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments

2021-08-29 Thread Reinoud Zandijk
Hi :) Have these patches been applied? How can I easily check it without manually checking if they are there in a git pullup? Am I notified normally when patches are applied? With regards, Reinoud On Sun, Jul 18, 2021 at 03:46:48PM +0200, Reinoud Zandijk wrote: > This patchset fixes small NVMM

Re: applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments

2021-08-29 Thread Peter Maydell
On Sun, 29 Aug 2021 at 17:06, Reinoud Zandijk wrote: > > Hi :) > > Have these patches been applied? How can I easily check it without manually > checking if they are there in a git pullup? Am I notified normally when > patches are applied? Generally when a submaintainer picks up a patchset

Re: Testing a microcontroller emulation by loading the binary on incomplete Flash emulation

2021-08-29 Thread Gautam Bhat
> Just create a minimal machine with some RAM in it, and use > the generic-loader to load the test binary into the RAM, then. > > -- PMM I should be using the -bios switch for loading the bare metal firmware, correct? -Gautam.

Re: [PATCH] nvdimm: release the correct device list

2021-08-29 Thread lizhij...@fujitsu.com
ping On 03/08/2021 12:00, Li, Zhijian wrote: > ping > > Any body could help to review/queue this patch ? > > > > On 2021/6/29 22:05, Igor Mammedov wrote: >> On Thu, 24 Jun 2021 19:04:15 +0800 >> Li Zhijian wrote: >> >>> Signed-off-by: Li Zhijian >> Reviewed-by: Igor Mammedov >> >>> --- >>>  

Re: [PATCH v3 01/19] target/loongarch: Add README

2021-08-29 Thread Song Gao
Hi, Peter. On 08/27/2021 11:06 PM, Peter Xu wrote: > On Fri, Aug 27, 2021 at 03:14:36PM +0800, Song Gao wrote: >> +The following versions of the LoongArch core are supported >> +core: 3A5000 >> + >>

[PATCH v10 4/7] [RISCV_PM] Print new PM CSRs in QEMU logs

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 4178eecbec..ab8c81cb5e 100644 --- a/target/riscv/cpu.c

[PATCH v10 7/7] [RISCV_PM] Allow experimental J-ext to be turned on

2021-08-29 Thread Alexey Baturo
Signed-off-by: Alexey Baturo Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ab8c81cb5e..fde96c21f2 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -583,6 +583,7 @@ static void

Re: [PATCH 0/3] Use meson_options.txt in the configure script

2021-08-29 Thread Marc-André Lureau
Hi Thomas On Sun, Aug 29, 2021 at 9:32 PM Thomas Huth wrote: > It's cumbersome to maintain the build options twice, one time in the > configure script and one time in meson_options.txt. Thus let's add some > logic to the configure script to look at the meson_options.txt file > instead of

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-29 Thread Yuri Benditovich
On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster wrote: > > Andrew Melnichenko writes: > > > Hi, > > > >> The helper may or may not be installed at the path compiled into QEMU. > >> > > Yes, so the helper will not be called - QEMU will try to initiate eBPF RSS > > or use "in-qemu" RSS. > > My

Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper

2021-08-29 Thread Peter Maydell
On Thu, 5 Aug 2021 at 21:34, johannst wrote: > > Dear all, > > in my opinion the `type` argument in the kvm ioctl wrappers should be of > type unsigned. Please correct me if I am wrong. (Ccing Eric as our resident POSIX expert.) > Due to the same reason as explained in the comment on the >

Re: [PATCH v12 0/6] support dirtyrate at the granualrity of vcpu

2021-08-29 Thread Hyman
ping - hi, what would you think about this patchset ? :) 在 2021/6/30 0:01, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) v12 - adjust the order of calculating dirty rate let memory_global_dirty_log_sync before calculating as v11 version description. v11 - rebase on master - call

RE: [PATCH v2 0/4] target/arm/cpu: Introduce sve_vq_supported bitmap

2021-08-29 Thread ishii.shuuic...@fujitsu.com
> FYI, Andrew's patches are now upstream so you'll be able to base your next > revision of your patches directly on upstream master when you're ready to > send it > out. Thanks for the comment. The reason I applied it locally was because I wanted to check the fixes before the Andrew’s patches

Re: Testing a microcontroller emulation by loading the binary on incomplete Flash emulation

2021-08-29 Thread Philippe Mathieu-Daudé
Le dim. 29 août 2021 23:34, Gautam Bhat a écrit : > > Just create a minimal machine with some RAM in it, and use > > the generic-loader to load the test binary into the RAM, then. > > > > -- PMM > > I should be using the -bios switch for loading the bare metal firmware, > correct? > No:

Re: [PATCH RFC v2 04/16] vfio-user: connect vfio proxy to remote server

2021-08-29 Thread John Johnson
> On Aug 24, 2021, at 7:15 AM, Stefan Hajnoczi wrote: > > On Mon, Aug 16, 2021 at 09:42:37AM -0700, Elena Ufimtseva wrote: >> @@ -3361,13 +3362,35 @@ static void vfio_user_pci_realize(PCIDevice *pdev, >> Error **errp) >> VFIOUserPCIDevice *udev = VFIO_USER_PCI(pdev); >> VFIOPCIDevice

Re: [PATCH RFC v2 06/16] vfio-user: negotiate version with remote server

2021-08-29 Thread John Johnson
> On Aug 24, 2021, at 8:59 AM, Stefan Hajnoczi wrote: > > On Mon, Aug 16, 2021 at 09:42:39AM -0700, Elena Ufimtseva wrote: >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index 7005d9f891..eae33e746f 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -3397,6 +3397,12 @@ static void

Re: [PATCH RFC v2 05/16] vfio-user: define VFIO Proxy and communication functions

2021-08-29 Thread John Johnson
> On Aug 24, 2021, at 8:14 AM, Stefan Hajnoczi wrote: > > On Mon, Aug 16, 2021 at 09:42:38AM -0700, Elena Ufimtseva wrote: >> @@ -62,5 +65,10 @@ typedef struct VFIOProxy { >> >> VFIOProxy *vfio_user_connect_dev(SocketAddress *addr, Error **errp); >> void vfio_user_disconnect(VFIOProxy

[PATCH v0] kvm: unsigned datatype in ioctl wrapper

2021-08-29 Thread Johannes Stoelp
From: johannst Ping. https://patchew.org/QEMU/20210805193950.514357-1-johannes.sto...@gmail.com/ https://lore.kernel.org/qemu-devel/20210805193950.514357-1-johannes.sto...@gmail.com/ Thanks and best, Johannes

Re: [PATCH RFC v2 07/16] vfio-user: get device info

2021-08-29 Thread John Johnson
> On Aug 24, 2021, at 9:04 AM, Stefan Hajnoczi wrote: > > On Mon, Aug 16, 2021 at 09:42:40AM -0700, Elena Ufimtseva wrote: >> +int vfio_user_get_info(VFIODevice *vbasedev) >> +{ >> +VFIOUserDeviceInfo msg; >> + >> +memset(, 0, sizeof(msg)); >> +vfio_user_request_msg(,

Re: [PATCH v6 04/14] target/riscv: Remove the W-form instructions from Zbs

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:05 AM Philipp Tomsich wrote: > > Zbs 1.0.0 (just as the 0.93 draft-B before) does no provide for W-form > instructions for Zbs (single-bit instructions). Remove them. > > Note that these instructions had already been removed for the 0.93 > version of the draft-B

Re: [PATCH v6 07/14] target/riscv: Add instructions of the Zbc-extension

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:08 AM Philipp Tomsich wrote: > > The following instructions are part of Zbc: > - clmul > - clmulh > - clmulr > > Note that these instructions were already defined in the pre-0.93 and > the 0.93 draft-B proposals, but had not been omitted in the earlier > addition of

Re: [PATCH 0/3] Use meson_options.txt in the configure script

2021-08-29 Thread Thomas Huth
On 29/08/2021 23.22, Marc-André Lureau wrote: Hi Thomas On Sun, Aug 29, 2021 at 9:32 PM Thomas Huth > wrote: It's cumbersome to maintain the build options twice, one time in the configure script and one time in meson_options.txt. Thus let's add some logic

Re: [PATCH v6 08/14] target/riscv: Reassign instructions to the Zbb-extension

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:11 AM Philipp Tomsich wrote: > > This reassigns the instructions that are part of Zbb into it, with the > notable exceptions of the instructions (rev8, zext.w and orc.b) that > changed due to gorci, grevi and pack not being part of Zb[abcs]. > > Signed-off-by: Philipp

Re: [PATCH v6 01/14] target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:01 AM Philipp Tomsich wrote: > > The bitmanipulation ISA extensions will be ratified as individual > small extension packages instead of a large B-extension. The first > new instructions through the door (these have completed public review) > are Zb[abcs]. > > This adds

RE: [PATCH v2 0/4] target/arm/cpu: Introduce sve_vq_supported bitmap

2021-08-29 Thread ishii.shuuic...@fujitsu.com
Thanks for the comments. We're sorry for the time it took you due to our lack of understanding. > As I've stated a few different times, the sve-max-vq property is of marginal > use, as > it only works for CPU models that support all vector lengths, including > non-power-of-2 lengths. This is

Re: [PATCH v6 05/14] target/riscv: Remove shift-one instructions (proposed Zbo in pre-0.93 draft-B)

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:13 AM Philipp Tomsich wrote: > > The Zb[abcs] ratification package does not include the proposed > shift-one instructions. There currently is no clear plan to whether > these (or variants of them) will be ratified as Zbo (or a different > extension) or what the timeframe

Re: [PATCH v6 06/14] target/riscv: Reassign instructions to the Zbs-extension

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:05 AM Philipp Tomsich wrote: > > The following instructions are part of Zbs: > - b{set,clr,ext,inv} > - b{set,clr,ext,inv}i > > Signed-off-by: Philipp Tomsich > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > > (no changes since v3)

Re: [PATCH v6 11/14] target/riscv: Add rev8 instruction, removing grev/grevi

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:13 AM Philipp Tomsich wrote: > > The 1.0.0 version of Zbb does not contain grev/grevi. Instead, a > rev8 instruction (equivalent to the rev8 pseudo-instruction built on > grevi from pre-0.93 draft-B) is available. > > This commit adds the new rev8 instruction and

Re: [PATCH v5 23/24] target/riscv: Tidy trans_rvh.c.inc

2021-08-29 Thread Alistair Francis
On Tue, Aug 24, 2021 at 6:07 AM Richard Henderson wrote: > > Exit early if check_access fails. > Split out do_hlv, do_hsv, do_hlvx subroutines. > Use dest_gpr, get_gpr in the new subroutines. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alistair

Re: [PATCH v6 12/14] target/riscv: Add zext.h instructions to Zbb, removing pack/packu/packh

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:14 AM Philipp Tomsich wrote: > > The 1.0.0 version of Zbb does not contain pack/packu/packh. However, a > zext.h instruction is provided (built on pack/packh from pre-0.93 > draft-B) is available. > > This commit adds zext.h and removes the pack* instructions. > > Note

Re: [PATCH v6 13/14] target/riscv: Remove RVB (replaced by Zb[abcs]

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:16 AM Philipp Tomsich wrote: > > With everything classified as Zb[abcs] and pre-0.93 draft-B > instructions that are not part of Zb[abcs] removed, we can remove the > remaining support code for RVB. > > Note that RVB has been retired for good and misa.B will neither mean

Re: [PATCH v6 02/14] target/riscv: Reassign instructions to the Zba-extension

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:07 AM Philipp Tomsich wrote: > > The following instructions are part of Zba: > - add.uw (RV64 only) > - sh[123]add (RV32 and RV64) > - sh[123]add.uw (RV64-only) > - slli.uw (RV64-only) > > Signed-off-by: Philipp Tomsich > Reviewed-by: Richard Henderson

Re: [PATCH v6 03/14] target/riscv: slli.uw is only a valid encoding if shamt first in 64 bits

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:09 AM Philipp Tomsich wrote: > > For RV64, the shamt field in slli.uw is 6 bits wide. While the encoding > space currently reserves a wider shamt-field (for use is a future RV128 > ISA), setting the additional bit to 1 will not map to slli.uw for RV64 > and needs to be

Re: [PATCH v5 24/24] target/riscv: Use {get,dest}_gpr for RVV

2021-08-29 Thread Alistair Francis
On Tue, Aug 24, 2021 at 6:13 AM Richard Henderson wrote: > > Remove gen_get_gpr, as the function becomes unused. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c| 13 ++--- > target/riscv/insn_trans/trans_rvv.c.inc

Re: [PATCH v6 09/14] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:18 AM Philipp Tomsich wrote: > > The 1.0.0 version of Zbb does not contain gorc/gorci. Instead, a > orc.b instruction (equivalent to the orc.b pseudo-instruction built on > gorci from pre-0.93 draft-B) is available, mainly targeting > string-processing workloads. > >

Re: [PATCH v6 10/14] target/riscv: Add a REQUIRE_32BIT macro

2021-08-29 Thread Alistair Francis
On Thu, Aug 26, 2021 at 3:15 AM Philipp Tomsich wrote: > > With the changes to Zb[abcs], there's some encodings that are > different in RV64 and RV32 (e.g., for rev8 and zext.h). For these, > we'll need a helper macro allowing us to select on RV32, as well. > > Signed-off-by: Philipp Tomsich >