[PULL v2 13/25] test-qobject-output-visitor: Wean off UserDefListUnion

2021-09-27 Thread Markus Armbruster
The test_visitor_out_list_union_FOO() use simple union UserDefListUnion to cover lists of builtin types. Rewrite as test_visitor_out_list_struct(), using struct ArrayStruct and a lot less code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id:

[PULL v2 12/25] test-qobject-input-visitor: Wean off UserDefListUnion

2021-09-27 Thread Markus Armbruster
The test_visitor_in_list_union_FOO() use simple union UserDefListUnion to cover lists of builtin types. Rewrite as test_visitor_in_list_struct(), using struct ArrayStruct and a lot less code. test_visitor_in_fail_union_list() uses UserDefListUnion to cover "variant members don't match the

[PULL v2 01/25] qapi: Tidy up unusual line breaks

2021-09-27 Thread Markus Armbruster
Break lines between members instead of within members. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <20210917143134.412106-2-arm...@redhat.com> --- docs/devel/qapi-code-gen.rst| 12 +-- tests/qapi-schema/doc-good.json | 4 ++--

Re: [PATCH v3 25/27] linux-user/sparc: Implement setup_sigtramp

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > Create and record the two signal trampolines. > Use them when the guest does not use SA_RESTORER. > > Cc: Mark Cave-Ayland > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 17/27] linux-user/nios2: Map a real kuser page

2021-09-27 Thread Richard Henderson
On 9/27/21 9:26 AM, Peter Maydell wrote: +/* + * If the mmap doesn't give us exactly page 1, there's nothing + * we can do, and it's unlikely that the program will be able + * to continue. FIXME: Error out now? + */ +assert(pg == TARGET_PAGE_SIZE); Shouldn't we be

Re: [PULL 0/5] Trivial branch for 6.2 patches

2021-09-27 Thread Peter Maydell
information (2021-09-27 10:57:21 +0200) > > ---- > Trivial patches pull request 20210927 > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.2 for any user-visible changes. -- PMM

Re: [PATCH v3 16/27] linux-user/nios2: Properly emulate EXCP_TRAP

2021-09-27 Thread Richard Henderson
On 9/27/21 9:23 AM, Peter Maydell wrote: Loading the insn and fishing out the imm5 field is about 2 lines of code, isn't it? It's how we handle similar cases for other targets. And we actively get it wrong, e.g. mips. So I have patches to move that code *out* of linux-user. We have macros in

Re: [External] Re: [RFC v7] virtio/vsock: add two more queues for datagram types

2021-09-27 Thread Stefano Garzarella
On Fri, Sep 24, 2021 at 03:27:30PM -0700, Jiang Wang . wrote: On Thu, Sep 23, 2021 at 2:18 AM Stefano Garzarella wrote: [...] > >To explain it, I think the event queue number does not matter for the >vhost and qemu. The vhost-vsock kernel module does not allocate any >data structure for the

Re: [PATCH 08/16] acceptance/tests/vnc.py: use explicit syntax for enabling passwords

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:54, Cleber Rosa wrote: > This matches the command line on 82a17d1d67, where the "on" or "off" > should be explicitly given. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/vnc.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 12/16] tests/acceptance/boot_xen.py: removed unused import

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:55, Cleber Rosa wrote: > Just a clean up for an unused import. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/boot_xen.py | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hostmem: change default prealloc threads number

2021-09-27 Thread David Hildenbrand
On 27.09.21 15:19, Nan Wang wrote: From: "wangnan.light" the default number of prealloc threads is 1, for huge memory backend file, single thread touch page is really slow. We can adjust thread number by prealloc-threads property, but if the default value updated to MachineState::smp::cpus may

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Simon Glass
Hi Peter, On Mon, 27 Sept 2021 at 02:48, Peter Maydell wrote: > > On Sun, 26 Sept 2021 at 19:55, Simon Glass wrote: > > In the case of U-Boot at least, it uses the devicetree for > > configuration (it is a boot loader, so there is no user space to > > provide configuration). So the current

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 12:27, Kevin Wolf wrote: > > Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > > > We want to switch both from QemuOpts to the keyval parser in the future, > > > which results in some incompatibilities,

Re: [PATCH v2 1/2] hw/dma: sifive_pdma: Fix Control.claim bit detection

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 09:21, Bin Meng wrote: > At present the codes detect whether the DMA channel is claimed by: > > claimed = !!s->chan[ch].control & CONTROL_CLAIM; > > As ! has higher precedence over & (bitwise and), this is essentially > > claimed = (!!s->chan[ch].control) & CONTROL_CLAIM; > >

[PULL v2 17/25] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, rewrite TestIfUnion to be

Re: [PATCH v3 18/27] linux-user/nios2: Fixes for signal frame setup

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 17:59, Richard Henderson wrote: > > Do not confuse host and guest addresses. Lock and unlock > the target_rt_sigframe structure in setup_rt_sigframe. > > Since rt_setup_ucontext always returns 0, drop the return > value entirely. This eliminates the only write to the err

[PATCH v3 3/3] bios-tables-test: Generate reference table for virt/DBG2

2021-09-27 Thread Eric Auger
Add the DBG2 table generated with tests/data/acpi/rebuild-expected-aml.sh Signed-off-by: Eric Auger --- Tested by comparing the content with the table generated by EDK2 along with the SBSA-REF machine (code generated by DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c). I

[PATCH v2 1/2] modules: introduces module_needs directive

2021-09-27 Thread Jose R. Ziviani
module_needs is a new directive that shoule be used with module_obj whenever that module depends on the Kconfig to be enabled. When the module is enabled in Kconfig, we are sure that all of its dependencies will be enabled as well, and that the program will be able to load that module without any

[PATCH v2] hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19

2021-09-27 Thread Xuzhou Cheng
From: Xuzhou Cheng The Linux spi-imx driver does not work on QEMU. The reason is that the state of m25p80 loops in STATE_READING_DATA state after receiving RDSR command, the new command is ignored. Before sending a new command, CS line should be pulled high to make the state of m25p80 back to

Re: [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:55, Cleber Rosa wrote: > The arch and machine tags apply to all tests, so let's define them > only once. IIRC this was not the case at the beginning with Avocado 65.0 at least, right? If so, maybe mention since when it is possible? > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:55, Cleber Rosa wrote: > The NetBSD-7.1.2-prep.iso is no longer available on the CDN, but it's > still available in the archive. > > Let's update its location so that users without the file on cache can > still fetch it and run the test. > > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH v1 1/1] hw/riscv: shakti_c: Mark as not user creatable

2021-09-27 Thread Philippe Mathieu-Daudé
Hi Alistair, On 9/27/21 09:13, Alistair Francis wrote: > From: Alistair Francis > > Mark the shakti_c machine as not user creatable as it uses serial_hd. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/639 > Signed-off-by: Alistair Francis > --- > hw/riscv/shakti_c.c | 2 ++ > 1

Re: [PULL v2 00/25] QAPI patches patches for 2021-09-25

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 14:06, Markus Armbruster wrote: > > The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into > staging (2021-09-24 13:21:18 -0400) > > are available in the Git repository at:

[PULL v2 05/25] qapi: Convert simple union TpmTypeOptions to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 18/25] test-clone-visitor: Wean off __org.qemu_x-Union1

2021-09-27 Thread Markus Armbruster
test_clone_complex3() uses simple union __org.qemu_x-Union1 to cover arrays. Use UserDefOneList instead. Unions are still covered by test_clone_complex1(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20210917143134.412106-19-arm...@redhat.com> ---

RE: [question] VFIO Device Migration: The vCPU may be paused during vfio device DMA in iommu nested stage mode && vSVA

2021-09-27 Thread Tian, Kevin
> From: Kunkun Jiang > Sent: Monday, September 27, 2021 8:30 PM > > Hi Kevin: > > On 2021/9/24 14:47, Tian, Kevin wrote: > >> From: Kunkun Jiang > >> Sent: Friday, September 24, 2021 2:19 PM > >> > >> Hi all, > >> > >> I encountered a problem in vfio device migration test. The > >> vCPU may be

[PULL v2 08/25] qapi: Convert simple union SocketAddressLegacy to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

Re: [PATCH] linux-user/syscall: add support for CLONE_PIDFD

2021-09-27 Thread Peter Maydell
On Tue, 21 Sept 2021 at 19:50, Andreas Schwab wrote: > > Add basic support for CLONE_PIDFD, only fork-like clone without additional > flags. This is enough to make Qt/forkfd working. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 52

Re: [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones

2021-09-27 Thread Jag Raman
> On Sep 26, 2021, at 4:19 PM, Philippe Mathieu-Daudé wrote: > > QEMU doesn't distinct network devices per link layer (Ethernet, > Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network > devices. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jagannathan Raman > --- >

Re: [PATCH 0/6] avocado_qemu: small fixes and tweaks

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/20/21 22:49, Willian Rampazzo wrote: > Standardize the super() calls according to PEP3135; fix import order based on > isort; fix and tweak the ssh `connect` method; explicitly return None on > `pick_default_qemu_bin` function to avoid linters R1710; and fix inheritance > order on `LinuxTest`

Re: [PATCH 15/16] tests/acceptance/ppc_prep_40p.py: clean up unused import

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:55, Cleber Rosa wrote: > Just a removal of an unused imported symbol. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/ppc_prep_40p.py | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2] nbd/server: Add --selinux-label option

2021-09-27 Thread Vladimir Sementsov-Ogievskiy
24.09.2021 22:23, Eric Blake wrote: Ping On Wed, Aug 25, 2021 at 02:35:04PM -0500, Eric Blake wrote: On Fri, Jul 23, 2021 at 05:38:06PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote: Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben:

[PULL v2 06/25] qapi: Convert simple union MemoryDeviceInfo to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 19/25] tests/qapi-schema: Drop simple union __org.qemu_x-Union1

2021-09-27 Thread Markus Armbruster
Replace simple union __org.qemu_x-Union1 with flat union __org.qemu_x-Union2, except drop it from __org.qemu_x-command, because there it's only used to pull it into QMP. Now drop the unused -Union1, and rename -Union2 to -Union. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake

[PULL v2 10/25] qapi: Convert simple union TransactionAction to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PULL v2 00/25] QAPI patches patches for 2021-09-25

2021-09-27 Thread Markus Armbruster
The following changes since commit 11a11998460ed84d9a127c025f50f7234e5a483f: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210921' into staging (2021-09-24 13:21:18 -0400) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2021-09-25-v2 for

[PULL v2 21/25] qapi: Drop simple unions

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. The previous commits eliminated simple union from the

[PULL v2 03/25] qapi: Convert simple union KeyValue to flat one

2021-09-27 Thread Markus Armbruster
Simple unions predate flat unions. Having both complicates the QAPI schema language and the QAPI generator. We haven't been using simple unions in new code for a long time, because they are less flexible and somewhat awkward on the wire. To prepare for their removal, convert simple union

[PATCH v3 0/3] hw/arm/virt_acpi_build: Generate DBG2 table

2021-09-27 Thread Eric Auger
This series generates the ACPI DBG2 table along with machvirt. It applies on top of Igor's [PATCH v4 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables The DBG2 specification can be found at

Re: [PATCH v2 1/2] hw/dma: sifive_pdma: Fix Control.claim bit detection

2021-09-27 Thread Bin Meng
Hi Philippe, On Mon, Sep 27, 2021 at 8:56 PM Philippe Mathieu-Daudé wrote: > > On 9/27/21 09:21, Bin Meng wrote: > > At present the codes detect whether the DMA channel is claimed by: > > > > claimed = !!s->chan[ch].control & CONTROL_CLAIM; > > > > As ! has higher precedence over & (bitwise

[PATCH v2 2/2] modules: generates per-target modinfo

2021-09-27 Thread Jose R. Ziviani
This patch changes the way modinfo is generated and built. Today we have only modinfo.c being genereated and linked to all targets, now it generates (and link) one modinfo per target. It also makes use of the module_need to add modules that makes sense for the selected target. Signed-off-by:

Re: gitlab-ci: amd64-opensuse-leap-container job failing

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 15:47, Daniel P. Berrangé wrote: > On Mon, Sep 27, 2021 at 09:35:22AM +0100, Daniel P. Berrangé wrote: >> On Sun, Sep 26, 2021 at 07:23:56PM +0200, Philippe Mathieu-Daudé wrote: >>> Hi, >>> >>> FYI the OpenSUSE job is failing since few days, i.e.: >>>

Re: [PATCH 02/16] Acceptance Tests: improve check-acceptance description

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:54, Cleber Rosa wrote: > The "check-acceptance" make rule won't necessarily run *all* available > tests, because it employs a filter based on the currently configured > targets. This change in the description of the rule makes that > behavior extra clear. > > Signed-off-by: Cleber

Re: [PATCH 4/6] avocado_qemu: tweak ssh connect method

2021-09-27 Thread Willian Rampazzo
On Mon, Sep 27, 2021 at 11:12 AM Philippe Mathieu-Daudé wrote: > > On 9/20/21 22:49, Willian Rampazzo wrote: > > The current implementation will crash if the connection fails as the > > `time` module is not imported. This fixes the import problem and tweaks > > the connection to wait

Re: Need to merge - QEMU patch for booting eMMC image for AST2600 machine

2021-09-27 Thread Shitalkumar Gandhi
Yes, I have raised this.

[PATCH 1/1] virtio-gpu: CONTEXT_INIT feature

2021-09-27 Thread Antonio Caggiano
Create virgl renderer context with flags using context_id when valid. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-base.c| 2 ++ hw/display/virtio-gpu-virgl.c | 10 -- include/hw/virtio/virtio-gpu-bswap.h| 2 +-

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Simon Glass
Hi Peter, On Mon, 27 Sept 2021 at 09:46, Peter Maydell wrote: > > On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: > > On Mon, 27 Sept 2021 at 02:48, Peter Maydell > > wrote: > > > So what is missing in the QEMU-provided DTB that it needs? > > > > Quite a lot. Here are some examples: > > > >

[PATCH 0/2] 9pfs: iounit cleanup

2021-09-27 Thread Christian Schoenebeck
Two pure refactoring code cleanup patches regarding iounit calculation, no behaviour change. Christian Schoenebeck (2): 9pfs: deduplicate iounit code 9pfs: simplify blksize_to_iounit() hw/9pfs/9p.c | 41 +++-- 1 file changed, 19 insertions(+), 22

[PATCH 2/2] 9pfs: simplify blksize_to_iounit()

2021-09-27 Thread Christian Schoenebeck
Use QEMU_ALIGN_DOWN() macro to reduce code and to make it more human readable. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

[PATCH v4 1/6] tests/acceptance: Extract QemuBaseTest from Test

2021-09-27 Thread Philippe Mathieu-Daudé
The Avocado Test::fetch_asset() is handy to download artifacts before running tests. The current class is named Test but only tests system emulation. As we want to test user emulation, refactor the common code as QemuBaseTest. Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v4 0/6] tests/acceptance: Add bFLT loader linux-user test

2021-09-27 Thread Philippe Mathieu-Daudé
Since v3: - rebased - addressed Wainer review comments from v2 - rename avocado_qemu.Test -> QemuSystemTest Since v2: - rebased tests/acceptance/avocado_qemu/__init__.py patches - extract has_cmd() from virtiofs_submounts.py - check cpio availability with has_cmd() Philippe Mathieu-Daudé (6):

Re: [PATCH v3 1/7] qemu: Split machine_ppc.py acceptance tests

2021-09-27 Thread Cédric Le Goater
On 9/27/21 18:44, Philippe Mathieu-Daudé wrote: Hi David, On 9/27/21 06:48, David Gibson wrote: machine_ppc.py contains tests for 3 different ppc based machine types. It is listed in MAINTAINERS along with the PPC TCG cpu code. That's not really accurate though, since it's really more about

Re: [PATCH v3 1/7] qemu: Split machine_ppc.py acceptance tests

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 18:53, Cédric Le Goater wrote: > On 9/27/21 18:44, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 9/27/21 06:48, David Gibson wrote: >>> machine_ppc.py contains tests for 3 different ppc based machine >>> types.  It >>> is listed in MAINTAINERS along with the PPC TCG cpu code. 

Re: [PATCH v2] tests/acceptance: Test powernv machines

2021-09-27 Thread Philippe Mathieu-Daudé
On 8/17/21 11:30, Cédric Le Goater wrote: > Fetch the OpenPOWER images to boot the powernv8 and powernv9 machines > with a simple PCI layout. > > Cc: Cleber Rosa > Cc: Philippe Mathieu-Daudé > Cc: Wainer dos Santos Moschetta > Signed-off-by: Cédric Le Goater > --- > > Since v2: > > -

Re: [PATCH v2] tests/acceptance: Test powernv machines

2021-09-27 Thread Cédric Le Goater
On 9/27/21 19:21, Philippe Mathieu-Daudé wrote: On 8/17/21 11:30, Cédric Le Goater wrote: Fetch the OpenPOWER images to boot the powernv8 and powernv9 machines with a simple PCI layout. Cc: Cleber Rosa Cc: Philippe Mathieu-Daudé Cc: Wainer dos Santos Moschetta Signed-off-by: Cédric Le

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Kevin Townsend
Hi Peter, Thanks for the updated review. On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: > I thought we'd agreed to implement the whole of the auto-increment > logic, not just for specific registers ? > The problem I have here is ... how many bytes are we willing to buffer? There's no

Re: [PATCH 2/2] 9pfs: simplify blksize_to_iounit()

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/27/21 17:50, Christian Schoenebeck wrote: > Use QEMU_ALIGN_DOWN() macro to reduce code and to make it > more human readable. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Christian Schoenebeck > --- > hw/9pfs/9p.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 2/2] 9pfs: simplify blksize_to_iounit()

2021-09-27 Thread Greg Kurz
On Mon, 27 Sep 2021 17:50:36 +0200 Christian Schoenebeck wrote: > Use QEMU_ALIGN_DOWN() macro to reduce code and to make it > more human readable. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Christian Schoenebeck > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.c | 3 +-- > 1 file

[PATCH v4 5/6] tests/acceptance: Add bFLT loader linux-user test

2021-09-27 Thread Philippe Mathieu-Daudé
Add a very quick test that runs a busybox binary in bFLT format: $ AVOCADO_ALLOW_UNTRUSTED_CODE=1 \ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py JOB ID : db94d5960ce564c50904d666a7e259148c27e88f JOB LOG:

[PATCH v4 2/6] tests/acceptance: Make pick_default_qemu_bin() more generic

2021-09-27 Thread Philippe Mathieu-Daudé
Make pick_default_qemu_bin() generic to find qemu-system or qemu-user binaries. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Peter Maydell
On Tue, 21 Sept 2021 at 10:41, Kevin Townsend wrote: > > This commit adds emulation of the magnetometer on the LSM303DLHC. > It allows the magnetometer's X, Y and Z outputs to be set via the > mag-x, mag-y and mag-z properties, as well as the 12-bit > temperature output via the temperature

Re: [PATCH v3 0/5] More record/replay acceptance tests

2021-09-27 Thread Philippe Mathieu-Daudé
On 7/27/21 10:45, Pavel Dovgalyuk wrote: > The following series adds new record/replay tests to the acceptance group. > > The provided tests perform kernel boot and disk image boot scenarios. > For all of them recording and replaying phases are executed. > Tests were borrowed from existing

[PATCH v4 4/6] tests/acceptance: Share useful helpers from virtiofs_submounts test

2021-09-27 Thread Philippe Mathieu-Daudé
Move the useful has_cmd()/has_cmds() helpers from the virtiofs test to the avocado_qemu public class. Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 57 ++ tests/acceptance/virtiofs_submounts.py

Re: [PATCH v3 0/3] tests/Makefile: improvements on make check-acceptance

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/23/21 18:11, Willian Rampazzo wrote: > Improve the documentation about how to run a single test within a file > or all the tests from a file using the standalone avocado command. > > Add a way to run tests based on tags using the `make check-acceptance` > command. > > Add a way to run

Re: [PATCH] Acceptance tests: add myself as a reviewer for the acceptance tests.

2021-09-27 Thread Philippe Mathieu-Daudé
On 8/9/21 21:29, Willian Rampazzo wrote: > Signed-off-by: Willian Rampazzo > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 37b1a8e442..3f8ad63165 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3422,6 +3422,7 @@ W:

Re: [PATCH v3 1/7] qemu: Split machine_ppc.py acceptance tests

2021-09-27 Thread Philippe Mathieu-Daudé
Hi David, On 9/27/21 06:48, David Gibson wrote: > machine_ppc.py contains tests for 3 different ppc based machine types. It > is listed in MAINTAINERS along with the PPC TCG cpu code. That's not > really accurate though, since it's really more about testing those machines > than the CPUs. > >

Re: [PATCH 1/2] 9pfs: deduplicate iounit code

2021-09-27 Thread Christian Schoenebeck
On Montag, 27. September 2021 18:27:59 CEST Greg Kurz wrote: > On Mon, 27 Sep 2021 17:45:00 +0200 > > Christian Schoenebeck wrote: > > Remove redundant code that translates host fileystem's block > > size into 9p client (guest side) block size. > > > > Signed-off-by: Christian Schoenebeck > >

Re: [RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-09-27 Thread Cédric Le Goater
On 9/24/21 19:13, Greg Kurz wrote: On Fri, 24 Sep 2021 16:58:00 +0200 Cédric Le Goater wrote: [ ... ] The changes only impact KVM support since we are deferring the IRQ initialization at the KVM level. What we have to be careful about is not accessing an ESB page of an interrupt that would

[PULL 01/21] tests/acceptance: add replay kernel test for s390x

2021-09-27 Thread Philippe Mathieu-Daudé
From: Pavel Dovgalyuk This patch adds record/replay test which boots Linux kernel on s390x platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Willian Rampazzo Acked-by: Thomas Huth [PMD: Drop default '-smp 1' as suggested

[PULL 02/21] tests/acceptance: add replay kernel test for openrisc

2021-09-27 Thread Philippe Mathieu-Daudé
From: Pavel Dovgalyuk This patch adds record/replay test which boots Linux kernel on openrisc platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 19/21] tests/acceptance/boot_xen.py: removed unused import

2021-09-27 Thread Philippe Mathieu-Daudé
From: Cleber Rosa Just a clean up for an unused import. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210924185506.2542588-13-cr...@redhat.com> --- tests/acceptance/boot_xen.py | 1 - 1 file changed, 1 deletion(-) diff

[PULL 15/21] tests/Makefile: add AVOCADO_TESTS option to make check-acceptance

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Add the possibility of running all the tests from a single file, or multiple files, running a single test within a file or multiple tests within multiple files using `make check-acceptance` and the AVOCADO_TESTS environment variable. Suggested-by: Daniel P. Berrangé

[PULL 18/21] acceptance/tests/vnc.py: use explicit syntax for enabling passwords

2021-09-27 Thread Philippe Mathieu-Daudé
From: Cleber Rosa This matches the command line on 82a17d1d67, where the "on" or "off" should be explicitly given. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210924185506.2542588-9-cr...@redhat.com> ---

[PATCH 1/2] 9pfs: deduplicate iounit code

2021-09-27 Thread Christian Schoenebeck
Remove redundant code that translates host fileystem's block size into 9p client (guest side) block size. Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/hw/9pfs/9p.c

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 17:04, Simon Glass wrote: > On Mon, 27 Sept 2021 at 09:46, Peter Maydell wrote: > > My take is that this is u-boot doing weird custom things with > > the DTB that aren't "describe the hardware". You should be able > > to boot u-boot by putting those custom DTB extra

Re: [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements

2021-09-27 Thread Philippe Mathieu-Daudé
On 9/24/21 20:54, Cleber Rosa wrote: > This is a collection of patches for the Acceptance Tests to leverage > some of the features of Avocado 91.0. With the Avocado version bump > by itself, there would be a change in the default "test runner" > implementation that Avocado uses, from the one

QAPI sync meeting

2021-09-27 Thread John Snow
Hiya, I'd like to propose that at least the three of us arrange a time to have a meeting where we discuss our plans and ideas for QAPI going forward, including rust, python, and golang extensions to the QAPI generator, what we hope to accomplish with those projects, and so on. What I am hoping

[PULL 00/21] Integration testing patches for 2021-09-27

2021-09-27 Thread Philippe Mathieu-Daudé
-testing-20210927 for you to fetch changes up to 6fdd5530d12c5b21cc05e7f44db95f6544bc3c17: tests/acceptance/ppc_prep_40p.py: clean up unused import (2021-09-27 18:55:46 +0200) Integration testing patches - More Linux kernel record

[PULL 06/21] Acceptance tests: add myself as a reviewer for the acceptance tests

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Signed-off-by: Willian Rampazzo Acked-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210809192907.42138-1-willi...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PULL 12/21] avocado_qemu: fix inheritance order on LinuxTest class

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Class hierarchy on Python is defined from right to left. Although the current code is not harmful, let's fix it to avoid problems in the future. Signed-off-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 10/21] avocado_qemu: tweak ssh connect method

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo The current implementation will crash if the connection fails as the `time` module is not imported. Fix the import problem. While here, tweaks the connection to wait progressively when the connection fails. Signed-off-by: Willian Rampazzo [PMD: Reworded description]

[PULL 05/21] tests/acceptance: Linux boot test for record/replay

2021-09-27 Thread Philippe Mathieu-Daudé
From: Pavel Dovgalyuk This patch adds a test for record/replay, which boots Linux image from the disk and interacts with the network. The idea and code of this test is borrowed from boot_linux.py This test includes only x86_64 platform. Other platforms and machines will be added later after

[PULL 13/21] tests/Makefile: allow control over tags during check-acceptance

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Although it is possible to run a specific test using the avocado command-line, a user may want to use a specific tag while running the ``make check-acceptance`` during the development or debugging. This allows using the AVOCADO_TAGS environment variable where the user

[PULL 21/21] tests/acceptance/ppc_prep_40p.py: clean up unused import

2021-09-27 Thread Philippe Mathieu-Daudé
From: Cleber Rosa Just a removal of an unused imported symbol. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210924185506.2542588-16-cr...@redhat.com> --- tests/acceptance/ppc_prep_40p.py | 1 - 1 file changed, 1

[PATCH v5] Prevent vhost-user-blk-test hang

2021-09-27 Thread Raphael Norwitz
In the vhost-user-blk-test, as of now there is nothing stoping vhost-user-blk in QEMU writing to the socket right after forking off the storage daemon before it has a chance to come up properly, leaving the test hanging forever. This intermittently hanging test has caused QEMU automation failures

Re: [External] Re: [PATCH] hostmem: change default prealloc threads number

2021-09-27 Thread Nan Wang
On 2021/9/27 11:16, David Hildenbrand wrote: On 27.09.21 15:19, Nan Wang wrote: From: "wangnan.light" the default number of prealloc threads is 1, for huge memory backend file, single thread touch page is really slow. We can adjust thread number by prealloc-threads property, but if the

[PULL v2 00/22] Integration testing patches for 2021-09-27

2021-09-27 Thread Philippe Mathieu-Daudé
-testing-20210927 for you to fetch changes up to 4c5fc0c5fc496c147adb15536e4ac808feccf2cf: tests/acceptance: Test powernv machines (2021-09-27 19:21:37 +0200) Integration testing patches - More Linux kernel record/replay tests (Pavel

Re: [PATCH 1/2] 9pfs: deduplicate iounit code

2021-09-27 Thread Greg Kurz
On Mon, 27 Sep 2021 18:50:12 +0200 Christian Schoenebeck wrote: > On Montag, 27. September 2021 18:27:59 CEST Greg Kurz wrote: > > On Mon, 27 Sep 2021 17:45:00 +0200 > > > > Christian Schoenebeck wrote: > > > Remove redundant code that translates host fileystem's block > > > size into 9p

Re: [PULL 00/21] Integration testing patches for 2021-09-27

2021-09-27 Thread Philippe Mathieu-Daudé
ailable in the Git repository at: > > https://github.com/philmd/qemu.git tags/integration-testing-20210927 > > for you to fetch changes up to 6fdd5530d12c5b21cc05e7f44db95f6544bc3c17: > > tests/acceptance/ppc_prep_40p.py: clean up unused

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 18:47, Kevin Townsend wrote: > > Hi Peter, > > Thanks for the updated review. > > On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: >> >> I thought we'd agreed to implement the whole of the auto-increment >> logic, not just for specific registers ? > > > The problem I

[PATCH v4 6/6] tests/acceptance: Rename avocado_qemu.Test -> QemuSystemTest

2021-09-27 Thread Philippe Mathieu-Daudé
To run user-mode emulation tests, we introduced the avocado_qemu.QemuUserTest which inherits from avocado_qemu.QemuBaseTest. System-mode emulation tests are based on the avocado_qemu.Test class, which also inherits avocado_qemu.QemuBaseTest. To avoid confusion, rename it as

[PATCH v4 3/6] tests/acceptance: Introduce QemuUserTest base class

2021-09-27 Thread Philippe Mathieu-Daudé
Similarly to the 'System' Test base class with methods for testing system emulation, the QemuUserTest class contains methods useful to test user-mode emulation. Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 18

[PULL 07/21] Acceptance Tests: add standard clean up at test tearDown()

2021-09-27 Thread Philippe Mathieu-Daudé
From: Cleber Rosa The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation. But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own tearDown()

[PULL 03/21] tests/acceptance: add replay kernel test for nios2

2021-09-27 Thread Philippe Mathieu-Daudé
From: Pavel Dovgalyuk This patch adds record/replay test which boots Linux kernel on nios2 platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH v3 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-09-27 Thread Daniel P . Berrangé
On Wed, Aug 25, 2021 at 07:35:37AM +, Dov Murik wrote: > Add the sev_add_kernel_loader_hashes function to calculate the hashes of > the kernel/initrd/cmdline and fill a designated OVMF encrypted hash > table area. For this to work, OVMF must support an encrypted area to > place the data which

[PULL 09/21] avocado_qemu: fix import module based on isort

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Signed-off-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210920204932.94132-4-willi...@redhat.com> --- tests/acceptance/avocado_qemu/__init__.py | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git

[PULL 14/21] docs/devel/testing: add instruction to run a single acceptance test

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo Add instructions to the Acceptance tests section about running a single test file or a test within the test file. Signed-off-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 04/21] tests/acceptance: add replay kernel test for alpha

2021-09-27 Thread Philippe Mathieu-Daudé
From: Pavel Dovgalyuk This patch adds record/replay test which boots Linux kernel on alpha platform. The test uses kernel binaries taken from boot_linux_console test. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 08/21] avocado_qemu: standardize super() call following PEP3135

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo PEP3135 states when calling super(), there is no need to use arguments. This changes the calls on avocado_qemu to standardize according to PEP3135 and avoid warnings from linters. Signed-off-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 11/21] avocado_qemu: explicitly return None to avoid R1710

2021-09-27 Thread Philippe Mathieu-Daudé
From: Willian Rampazzo The linter is complaining the `pick_default_qemu_bin` is not explicitly returning None. Fix it to explicitly return None and avoid R1710 inconsistent-return-statements. Signed-off-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé Message-Id:

<    1   2   3   4   >