Strange qemu6 regression cauing disabled usb controller.

2021-09-30 Thread Remy Noel
Hello, I'm encountering a nagging issue with usbredir and a windows guest, but although I did pinpoint the commit that caused the issue, I have a hard time understanding it. The issue occurs when a two usbredir devices are added to a guest windows vm. When the second device is added, the

[PATCH] gdbstub: Switch to the thread receiving a signal

2021-09-30 Thread Pavel Labath
Respond with Txxthread:; instead of a plain Sxx to indicate which thread received the signal. Otherwise, the debugger will associate it with the main one. Also automatically select this thread, as that is what gdb expects. Signed-off-by: Pavel Labath --- gdbstub.c

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-09-30 Thread Christian Schoenebeck
On Mittwoch, 29. September 2021 19:48:38 CEST Daniel P. Berrangé wrote: > On Wed, Sep 29, 2021 at 07:32:39PM +0200, Christian Schoenebeck wrote: > > On Dienstag, 28. September 2021 18:41:17 CEST Daniel P. Berrangé wrote: > > > On Tue, Sep 28, 2021 at 06:23:23PM +0200, Christian Schoenebeck wrote:

[PATCH v3 08/19] qapi: introduce x-query-profile QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info profile" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command

[PATCH 7/7] docs: reorganize testing.rst

2021-09-30 Thread Paolo Bonzini
Clean up the heading levels to use === --- ~~~ ^^^ '''. Reorganize the outline for the Avocado part, and always include headings for the class names. Signed-off-by: Paolo Bonzini --- docs/devel/testing.rst | 146 + 1 file changed, 76 insertions(+), 70

[PATCH v3 14/19] qapi: introduce x-query-cmma QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info cmma" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

Re: [PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-09-30 Thread Christian Schoenebeck
On Donnerstag, 30. September 2021 16:01:38 CEST Daniel P. Berrangé wrote: > On Thu, Sep 30, 2021 at 03:55:36PM +0200, Christian Schoenebeck wrote: > > On Donnerstag, 30. September 2021 15:31:10 CEST Daniel P. Berrangé wrote: > > > On Thu, Sep 30, 2021 at 03:20:19PM +0200, Christian Schoenebeck

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 03:47:46PM +0100, Peter Maydell wrote: > On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > > > Signed-off-by: Paolo Bonzini > > > --- a/docs/devel/ci.rst > > +++ b/docs/devel/ci.rst > > @@ -8,6 +8,6 @@ found at:: > > > > https://wiki.qemu.org/Testing/CI > > > >

Re: [PATCH 0/3] KVM: qemu patches for few KVM features I developed

2021-09-30 Thread Maxim Levitsky
On Tue, 2021-09-14 at 18:52 +0300, Maxim Levitsky wrote: > These patches implement the qemu side logic to support > the KVM features I developed recently. > > First two patches are for features that are already accepted > upstream, and I already posted them on the qemu mailing list once. > > And

[PATCH v3 02/19] docs/devel: tweak headings in monitor command docs

2021-09-30 Thread Daniel P . Berrangé
The new headings reflect the intended structure of the document and will better suit additions that follow. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- docs/devel/writing-monitor-commands.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 05/19] docs/devel: document expectations for HMP commands in the future

2021-09-30 Thread Daniel P . Berrangé
We no longer wish to have commands implemented in HMP only. All commands should start with a QMP implementation and the HMP merely be a shim around this. To reduce the burden of implementing QMP commands where there is low expectation of machine usage, requirements for QAPI modelling are relaxed

[PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

2021-09-30 Thread Daniel P . Berrangé
Traditionally we have required that newly added QMP commands will model any returned data using fine grained QAPI types. This is good for commands that are intended to be consumed by machines, where clear data representation is very important. Commands that don't satisfy this have generally been

[PATCH v3 04/19] docs/devel: add example of command returning unstructured text

2021-09-30 Thread Daniel P . Berrangé
This illustrates how to add a QMP command returning unstructured text, following the guidelines added in the previous patch. The example uses a simplified version of 'info roms'. Signed-off-by: Daniel P. Berrangé --- docs/devel/writing-monitor-commands.rst | 87 - 1 file

[PATCH v3 15/19] hmp: synchronize cpu state for lapic info

2021-09-30 Thread Daniel P . Berrangé
From: Dongli Zhang While the default "info lapic" always synchronizes cpu state ... mon_get_cpu() -> mon_get_cpu_sync(mon, true) -> cpu_synchronize_state(cpu) -> ioctl KVM_GET_LAPIC (taking KVM as example) ... the cpu state is not synchronized when the apic-id is available as

[PATCH v3 06/19] monitor: remove 'info ioapic' HMP command

2021-09-30 Thread Daniel P . Berrangé
This command was turned into a no-op four years ago in commit 0c8465440d50c18a7bb13d0a866748f0593e193a Author: Peter Xu Date: Fri Dec 29 15:31:04 2017 +0800 hmp: obsolete "info ioapic" Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hmp-commands-info.hx

[PATCH 1/7] docs: name included files ".rst.inc"

2021-09-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/{ci-definitions.rst => ci-definitions.rst.inc} | 0 docs/devel/{ci-jobs.rst => ci-jobs.rst.inc} | 0 docs/devel/{ci-runners.rst => ci-runners.rst.inc} | 0 docs/devel/ci.rst | 6 +++--- 4

Moving QEMU downloads to GitLab Releases?

2021-09-30 Thread Stefan Hajnoczi
Hi Mike, QEMU downloads are currently hosted on qemu.org's Apache web server. Paolo and I were discussing ways to reduce qemu.org network traffic to save money and eventually turn off the qemu.org server since there is no full-time sysadmin for it. I'd like to discuss moving QEMU downloads to

Re: [PULL 00/20] NBD patches through 2021-09-27

2021-09-30 Thread Richard Henderson
On 9/30/21 4:45 AM, Richard W.M. Jones wrote: PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig ../configure --extra-cflags=-m32 --disable-vhost-user Not --extra-cflags, use --cpu=i386. r~

Re: [PATCH 1/1] hw: aspeed_gpio: Fix pin I/O type declarations

2021-09-30 Thread Rashmica Gupta
On Thu, 2021-09-30 at 00:45 +, Peter Delevoryas wrote: > > > On Sep 28, 2021, at 3:53 AM, Damien Hedde > > wrote: > > > > > > > > On 9/28/21 05:24, p...@fb.com wrote: > > > From: Peter Delevoryas > > > Some of the pin declarations in the Aspeed GPIO module were > > > incorrect, > > >

[PATCH v3 01/19] docs/devel: rename file for writing monitor commands

2021-09-30 Thread Daniel P . Berrangé
The file already covers writing HMP commands, in addition to the QMP commands, so it deserves a more general name. Signed-off-by: Daniel P. Berrangé --- docs/devel/index.rst| 2 +- ...riting-qmp-commands.rst => writing-monitor-commands.rst} | 6 +++--- 2

[PATCH v3 12/19] qapi: introduce x-query-ramblock QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info ramblock" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command

[PATCH v3 13/19] qapi: introduce x-query-skeys QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info skeys" command. It is being added with an "x-" prefix because this QMP command is intended as an adhoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command is

[PATCH 2/7] docs: move notes inside the body of the document

2021-09-30 Thread Paolo Bonzini
Make all documents start with a heading. Signed-off-by: Paolo Bonzini --- docs/devel/multi-process.rst | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/devel/multi-process.rst b/docs/devel/multi-process.rst index 69699329d6..e5758a79ab 100644 ---

[PATCH v3 19/19] qapi: introduce x-query-opcount QMP command

2021-09-30 Thread Daniel P . Berrangé
This is a counterpart to the HMP "info opcount" command. It is being added with an "x-" prefix because this QMP command is intended as an ad hoc debugging tool and will thus not be modelled in QAPI as fully structured data, nor will it have long term guaranteed stability. The existing HMP command

[PATCH 0/7] Cleanup sectioning in a few doc files

2021-09-30 Thread Paolo Bonzini
Patch 1 is more or less unrelated and is just a cleanup for file names; the others clean up the section headers for various doc files and fix a few cases in which related documentation is scattered through the file. Paolo Bonzini (7): docs: name included files ".rst.inc" docs: move notes

[PULL 05/22] hw/nvram: Introduce Xilinx ZynqMP eFuse device

2021-09-30 Thread Peter Maydell
From: Tong Ho This implements the Xilinx ZynqMP eFuse, an one-time field-programmable non-volatile storage device. There is only one such device in the Xilinx ZynqMP product family. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias

[PULL 04/22] hw/nvram: Introduce Xilinx Versal eFuse device

2021-09-30 Thread Peter Maydell
From: Tong Ho This implements the Xilinx Versal eFuse, an one-time field-programmable non-volatile storage device. There is only one such device in the Xilinx Versal product family. This device has two separate mmio interfaces, a controller and a flatten readback. The controller provides

[PULL 00/22] target-arm queue

2021-09-30 Thread Peter Maydell
://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210930 for you to fetch changes up to 1f4b2ec701b9d73d3fa7bb90c8b4376bc7d3c42b: hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19 (2021-09-30 13:44:13 +0100

[PULL 06/22] hw/nvram: Introduce Xilinx battery-backed ram

2021-09-30 Thread Peter Maydell
From: Tong Ho This device is present in Versal and ZynqMP product families to store a 256-bit encryption key. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Signed-off-by: Sai Pavan Boddu Signed-off-by: Tong Ho Message-id:

[PULL 13/22] target/arm: Fix coding style issues in gdbstub code in helper.c

2021-09-30 Thread Peter Maydell
We're going to move this code to a different file; fix the coding style first so checkpatch doesn't complain. This includes deleting the spurious 'break' statements after returns in the vfp_gdb_get_reg() function. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 17/22] ipack: Rename ipack_bus_new_inplace() to ipack_bus_init()

2021-09-30 Thread Peter Maydell
Rename ipack_bus_new_inplace() to ipack_bus_init(), to bring it in to line with a "_init for in-place init, _new for allocate-and-return" convention. Drop the 'name' argument, because the only caller does not pass in a name. If a future caller does need to specify the bus name, we should create

[PULL 16/22] scsi: Replace scsi_bus_new() with scsi_bus_init(), scsi_bus_init_named()

2021-09-30 Thread Peter Maydell
The function scsi_bus_new() creates a new SCSI bus; callers can either pass in a name argument to specify the name of the new bus, or they can pass in NULL to allow the bus to be given an automatically generated unique name. Almost all callers want to use the autogenerated name; the only

[PULL 20/22] qbus: Rename qbus_create() to qbus_new()

2021-09-30 Thread Peter Maydell
Rename the "allocate and return" qbus creation function to qbus_new(), to bring it into line with our _init vs _new convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Corey Minyard Message-id:

[PATCH 00/13] virtiofsd: Support notification queue and

2021-09-30 Thread Vivek Goyal
Hi, Here are the patches to support notification queue and blocking posix locks. One of the biggest change since las time has been creation of custom thread pool for handling locking requests. Thanks to Ioannis for doing most of the work on custom thread pool. I have posted corresponding kernel

Re: [PATCH 3/7] docs: put "make" information together in build-system.rst

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > docs/devel/build-system.rst | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst > index

[PATCH 07/13] virtiofsd: Release file locks using F_UNLCK

2021-09-30 Thread Vivek Goyal
We are emulating posix locks for guest using open file description locks in virtiofsd. When any of the fd is closed in guest, we find associated OFD lock fd (if there is one) and close it to release all the locks. Assumption here is that there is no other thread using lo_inode_plock structure or

Re: [PATCH v3 08/13] qapi/parser: Introduce NullSection

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 5:35 AM Markus Armbruster wrote: > John Snow writes: > > > Here's the weird bit. QAPIDoc generally expects -- virtually everywhere > > -- that it will always have a current section. The sole exception to > > this is in the case that end_comment() is called, which leaves

Re: [PATCH v3 09/13] qapi/parser: add import cycle workaround

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 5:45 AM Markus Armbruster wrote: > John Snow writes: > > > There is a cycle that exists in the QAPI generator: [schema -> expr -> > > "There is" or "there will be once we add strong type hints"? > > "There exists in my mind-palace a cycle where, ..." (Will adjust the

Re: [PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 4:47 AM Markus Armbruster wrote: > John Snow writes: > > > True, we do not check the validity of this symbol -- but we don't check > > the validity of definition names during parse, either -- that happens > > later, during the expr check. I don't want to introduce a

[PATCH 0/3] arm_gicv3: Support multiple redistributor regions

2021-09-30 Thread Peter Maydell
Our GICv3 QOM interface includes an array property redist-region-count which allows board models to specify that the registributor registers are not in a single contiguous range, but split into multiple pieces. We implemented this for KVM, but currently the TCG GICv3 model insists that there is

[PATCH 3/3] hw/intc/arm_gicv3: Support multiple redistributor regions

2021-09-30 Thread Peter Maydell
Our GICv3 QOM interface includes an array property redist-region-count which allows board models to specify that the registributor registers are not in a single contiguous range, but split into multiple pieces. We implemented this for KVM, but currently the TCG GICv3 model insists that there is

[PULL 01/22] allwinner-h3: Switch to SMC as PSCI conduit

2021-09-30 Thread Peter Maydell
From: Alexander Graf The Allwinner H3 SoC uses Cortex-A7 cores which support virtualization. However, today we are configuring QEMU to use HVC as PSCI conduit. That means HVC calls get trapped into QEMU instead of the guest's own emulated CPU and thus break the guest's ability to execute

[PULL 07/22] hw/arm: xlnx-versal-virt: Add Xilinx BBRAM device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Versal Battery-Backed RAM (BBRAM) The command argument: -drive if=pflash,index=0,... Can be used to optionally connect the bbram to a backend storage, such that field-programmed values in one invocation can be made available to next invocation. The

[PULL 14/22] target/arm: Move gdbstub related code out of helper.c

2021-09-30 Thread Peter Maydell
Currently helper.c includes some code which is part of the arm target's gdbstub support. This code has a better home: in gdbstub.c and gdbstub64.c. Move it there. Because aarch64_fpu_gdb_get_reg() and aarch64_fpu_gdb_set_reg() move into gdbstub64.c, this means that they're now compiled only for

[PULL 22/22] hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19

2021-09-30 Thread Peter Maydell
From: Xuzhou Cheng The Linux spi-imx driver does not work on QEMU. The reason is that the state of m25p80 loops in STATE_READING_DATA state after receiving RDSR command, the new command is ignored. Before sending a new command, CS line should be pulled high to make the state of m25p80 back to

[PATCH 09/13] virtiofsd: Specify size of notification buffer using config space

2021-09-30 Thread Vivek Goyal
Daemon specifies size of notification buffer needed and that should be done using config space. Only ->notify_buf_size value of config space comes from daemon. Rest of it is filled by qemu device emulation code. Signed-off-by: Vivek Goyal Signed-off-by: Ioannis Angelakopoulos ---

Re: [RFC PATCH 1/1] hw: aspeed_adc: Add initial Aspeed ADC support

2021-09-30 Thread Peter Delevoryas
> On Sep 29, 2021, at 11:22 PM, Cédric Le Goater wrote: > > Hello Peter, > > If you run ./scripts/get_maintainer.pl on the patch, it will build > the list of persons and mailing list to send to. Oh, sorry about that, I’ll cc everyone properly when I resubmit this. > > On 9/30/21 02:42,

[PATCH 02/13] virtiofsd: fuse.h header file changes for lock notification

2021-09-30 Thread Vivek Goyal
This change comes from fuse.h kernel header file udpate. Hence keeping it in a separate patch. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/fuse.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/fuse.h

[PATCH 0/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard Henderson
The meson + pkg-config probing issues came up wrt a recent NBD pull request at the same time as I am trying to reproduce a gitlab-ci failure with fedora-i386-cross, and ran into something apparently related. r~ Richard Henderson (2): tests/docker: Remove fedora-i386-cross from

[PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-09-30 Thread Richard Henderson
The image was upgraded to a full image in ee381b7fe146. This makes it possible to use docker-test@image syntax with this container. Cc: Thomas Huth Cc: Alex Bennée Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard Henderson
By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, we were still including the 64-bit packages. Install pcre-devel.i686 to fill a missing glib2 dependency. By using --extra-cflags instead of --cpu, we incorrectly use the wrong probing during meson. Cc: Alex Bennée Cc: Paolo Bonzini Cc:

Re: [PATCH v3 05/13] qapi/parser: improve detection of '@symbol:' preface

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 4:42 AM Markus Armbruster wrote: > John Snow writes: > > > Leading and trailing whitespace are now discarded, addressing the FIXME > > comment. A new error is raised to detect this accidental case. > > > > Parsing for args sections is left alone here; the 'name' variable

Re: Strange qemu6 regression cauing disabled usb controller.

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 03:48:44PM +0200, Remy Noel wrote: > Hello, > > I'm encountering a nagging issue with usbredir and a windows guest, but > although I did pinpoint the commit that caused the issue, I have a hard time > understanding it. > > The issue occurs when a two usbredir devices

[PULL 10/22] hw/arm: xlnx-zcu102: Add Xilinx eFUSE device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for ZynqMP eFUSE one-time field-programmable bit array. The command argument: -drive if=pflash,index=3,... Can be used to optionally connect the bit array to a backend storage, such that field-programmed values in one invocation can be made available to next

[PATCH 2/3] hw/intc/arm_gicv3: Set GICR_TYPER.Last correctly when nb_redist_regions > 1

2021-09-30 Thread Peter Maydell
The 'Last' bit in the GICR_TYPER GICv3 redistributor register is supposed to be set to 1 if this is the last redistributor in a series of contiguous redistributor pages. Currently we set Last only for the redistributor for CPU (num_cpu - 1). This only works if there is a single redistributor

[PULL 03/22] hw/nvram: Introduce Xilinx eFuse QOM

2021-09-30 Thread Peter Maydell
From: Tong Ho This introduces the QOM for Xilinx eFuse, an one-time field-programmable storage bit array. The actual mmio interface to the array varies by device families and will be provided in different change-sets. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu

[PULL 11/22] docs/system/arm: xlnx-versal-virt: BBRAM and eFUSE Usage

2021-09-30 Thread Peter Maydell
From: Tong Ho Add BBRAM and eFUSE usage to the Xilinx Versal Virt board document. Signed-off-by: Tong Ho Message-id: 20210917052400.1249094-10-tong...@xilinx.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/xlnx-versal-virt.rst | 49

[PULL 19/22] qbus: Rename qbus_create_inplace() to qbus_init()

2021-09-30 Thread Peter Maydell
Rename qbus_create_inplace() to qbus_init(); this is more in line with our usual naming convention for functions that in-place initialize objects. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-id:

[PATCH 01/13] virtio_fs.h: Add notification queue feature bit

2021-09-30 Thread Vivek Goyal
This change will ultimately come from kernel as kernel header file update when kernel patches get merged. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/virtio_fs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/standard-headers/linux/virtio_fs.h

[PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-09-30 Thread Vivek Goyal
Add helpers to create/cleanup virtuqueues and use those helpers. I will need to reconfigure queues in later patches and using helpers will allow reusing the code. Signed-off-by: Vivek Goyal --- hw/virtio/vhost-user-fs.c | 87 +++ 1 file changed, 52

Re: [PULL v2 00/19] NBD patches through 2021-09-27

2021-09-30 Thread Peter Maydell
On Wed, 29 Sept 2021 at 22:13, Eric Blake wrote: > > The following changes since commit 6b54a31bf7b403672a798b6443b1930ae6c74dea: > > Merge remote-tracking branch > 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2021-09-28 > 13:07:32 +0100) > > are available in the Git

Re: [PATCH 6/7] docs: move gcov section at the end of testing.rst

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > gcov testing applies to all tests, not just make check. Move it > out of the make check section. > > Signed-off-by: Paolo Bonzini > --- > docs/devel/testing.rst | 38 +++--- > 1 file changed, 19

[PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Joe Tanen
CLOCK_MONOTONIC_RAW provides an unadjusted system clock on some platforms, which is closer in spirit to providing a guest with a raw hardware clock than CLOCK_MONOTONIC. Using CLOCK_MONOTONIC_RAW also works around a current issue in OSX where CLOCK_MONOTONIC has been observed to go backwards.

[PATCH 08/13] virtiofsd: Create a notification queue

2021-09-30 Thread Vivek Goyal
Add a notification queue which will be used to send async notifications for file lock availability. Signed-off-by: Vivek Goyal Signed-off-by: Ioannis Angelakopoulos --- hw/virtio/vhost-user-fs-pci.c | 4 +- hw/virtio/vhost-user-fs.c | 62 +--

Re: [PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 17:04, Joe Tanen wrote: > > CLOCK_MONOTONIC_RAW provides an unadjusted system clock on some platforms, > which is closer in spirit to providing a guest with a raw hardware clock than > CLOCK_MONOTONIC. > > Using CLOCK_MONOTONIC_RAW also works around a current issue in OSX

Re: [PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 12:36:36PM -0400, Richard Henderson wrote: > By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, > we were still including the 64-bit packages. Install > pcre-devel.i686 to fill a missing glib2 dependency. > > By using --extra-cflags instead of --cpu, we incorrectly >

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 02:00:11PM -0300, Willian Rampazzo wrote: > On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy > wrote: > > > > 9/30/21 11:47, Richard W.M. Jones wrote: > > > Under SELinux, Unix domain sockets have two labels. One is on the > > > disk and can be set with

[PULL 08/22] hw/arm: xlnx-versal-virt: Add Xilinx eFUSE device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Versal eFUSE one-time field-programmable bit array. The command argument: -drive if=pflash,index=1,... Can be used to optionally connect the bit array to a backend storage, such that field-programmed values in one invocation can be made available to next

Re: [RFC PATCH 1/1] hw: aspeed_adc: Add initial Aspeed ADC support

2021-09-30 Thread Cédric Le Goater
FYI, these series was sent by Andrew in 2017 and I have been keeping it alive since in the aspeed-x.y branches : * memory: Support unaligned accesses on aligned-only models https://github.com/legoater/qemu/commit/1960ba6bde27b91edb5336985a9210260a4c8938 That was requested by Phil I

Re: [PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 12:36:36PM -0400, Richard Henderson wrote: > By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, > we were still including the 64-bit packages. Install > pcre-devel.i686 to fill a missing glib2 dependency. > > By using --extra-cflags instead of --cpu, we incorrectly >

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 15:51, Daniel P. Berrangé wrote: > > On Thu, Sep 30, 2021 at 03:47:46PM +0100, Peter Maydell wrote: > > On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > > > > > Signed-off-by: Paolo Bonzini > > > > > --- a/docs/devel/ci.rst > > > +++ b/docs/devel/ci.rst > > > @@

[PATCH 1/3] hw/intc/arm_gicv3: Move checking of redist-region-count to arm_gicv3_common_realize

2021-09-30 Thread Peter Maydell
The GICv3 devices have an array property redist-region-count. Currently we check this for errors (bad values) in gicv3_init_irqs_and_mmio(), just before we use it. Move this error checking to the arm_gicv3_common_realize() function, where we sanity-check all of the other base-class properties.

[PULL 02/22] arm: tcg: Adhere to SMCCC 1.3 section 5.2

2021-09-30 Thread Peter Maydell
From: Alexander Graf The SMCCC 1.3 spec section 5.2 says The Unknown SMC Function Identifier is a sign-extended value of (-1) that is returned in the R0, W0 or X0 registers. An implementation must return this error code when it receives: * An SMC or HVC call with an unknown Function

[PULL 09/22] hw/arm: xlnx-zcu102: Add Xilinx BBRAM device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Xilinx ZynqMP Battery-Backed RAM (BBRAM) The command argument: -drive if=pflash,index=2,... Can be used to optionally connect the bbram to a backend storage, such that field-programmed values in one invocation can be made available to next invocation.

Re: Strange qemu6 regression cauing disabled usb controller.

2021-09-30 Thread Remy Noel
On Thu, Sep 30, 2021 at 04:05:52PM +0100, Daniel P. Berrangé wrote: On Thu, Sep 30, 2021 at 03:48:44PM +0200, Remy Noel wrote: Co-incidentally we've just had another bug report filed today that suggests 7bed89958bfbf40df9ca681cefbdca63abdde39d as a buggy commit causing deadlock in QEMU

[PULL 12/22] configs: Don't include 32-bit-only GDB XML in aarch64 linux configs

2021-09-30 Thread Peter Maydell
The aarch64-linux QEMU usermode binaries can never run 32-bit code, so they do not need to include the GDB XML for it. (arm_cpu_register_gdb_regs_for_features() will not use these XML files if the CPU has ARM_FEATURE_AARCH64, so we will not advertise to gdb that we have them.) Signed-off-by:

[PULL 18/22] pci: Rename pci_root_bus_new_inplace() to pci_root_bus_init()

2021-09-30 Thread Peter Maydell
Rename the pci_root_bus_new_inplace() function to pci_root_bus_init(); this brings the bus type in to line with a "_init for in-place init, _new for allocate-and-return" convention. To do this we need to rename the implementation-internal function that was using the pci_root_bus_init() name to

[PULL 15/22] target/arm: Don't put FPEXC and FPSID in org.gnu.gdb.arm.vfp XML

2021-09-30 Thread Peter Maydell
Currently we send VFP XML which includes D0..D15 or D0..D31, plus FPSID, FPSCR and FPEXC. The upstream GDB tolerates this, but its definition of this XML feature does not include FPSID or FPEXC. In particular, for M-profile cores there are no FPSID or FPEXC registers, so advertising those is

[PATCH 11/13] virtiofsd: Shutdown notification queue in the end

2021-09-30 Thread Vivek Goyal
So far we did not have the notion of cross queue traffic. That is, we get request on a queue and send back response on same queue. So if a request be being processed and at the same time a stop queue request comes in, we wait for all pending requests to finish and then queue is stopped and

[PATCH 10/13] virtiofsd: Custom threadpool for remote blocking posix locks requests

2021-09-30 Thread Vivek Goyal
Add a new custom threadpool using posix threads that specifically service locking requests. In the case of a fcntl(SETLKW) request, if the guest is waiting for a lock or locks and issues a hard-reboot through SYSRQ then virtiofsd unblocks the blocked threads by sending a signal to them and waking

[PATCH 05/13] virtiofsd: Add a helper to stop all queues

2021-09-30 Thread Vivek Goyal
Use a helper to stop all the queues. Later in the patch series I am planning to use this helper at one more place later in the patch series. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue

2021-09-30 Thread Vivek Goyal
We have open coded logic to take locks and push element on virtqueue at three places. Add a helper and use it everywhere. Code is easier to read and less number of lines of code. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 45 ++- 1 file

Re: [PULL 00/44] ppc-for-6.2 queue 20210930

2021-09-30 Thread Peter Maydell
are available in the Git repository at: > > https://gitlab.com/dgibson/qemu.git tags/ppc-for-6.2-20210930 > > for you to fetch changes up to 85d887be82905aa81b5d3d6c483ff0fa9958382b: > > MAINTAINERS: Demote sPAPR from "Supported

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Willian Rampazzo
On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: > > 9/30/21 11:47, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (called

Re: [PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 12:36:35PM -0400, Richard Henderson wrote: > The image was upgraded to a full image in ee381b7fe146. > This makes it possible to use docker-test@image syntax > with this container. > > Cc: Thomas Huth > Cc: Alex Bennée > Signed-off-by: Richard Henderson > --- >

[PULL 21/22] ide: Rename ide_bus_new() to ide_bus_init()

2021-09-30 Thread Peter Maydell
The function ide_bus_new() does an in-place initialization. Rename it to ide_bus_init() to follow our _init vs _new convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Corey Minyard Reviewed-by: John Snow Acked-by: John

[PATCH 03/13] virtiofsd: Remove unused virtio_fs_config definition

2021-09-30 Thread Vivek Goyal
"struct virtio_fs_config" definition seems to be unused in fuse_virtio.c. Remove it. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 8f4fd165b9..da7b6a76bf

[PATCH 12/13] virtiofsd: Implement blocking posix locks

2021-09-30 Thread Vivek Goyal
As of now we don't support fcntl(F_SETLKW) and if we see one, we return -EOPNOTSUPP. Change that by accepting these requests and returning a reply immediately asking caller to wait. Once lock is available, send a notification to the waiter indicating lock is available. In response to lock

Re: [PATCH 2/7] docs: move notes inside the body of the document

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > Make all documents start with a heading. > > Signed-off-by: Paolo Bonzini > --- > docs/devel/multi-process.rst | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/docs/devel/multi-process.rst

[PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list

2021-09-30 Thread Vivek Goyal
g_usleep() calls nanosleep() and that now seems to call clock_nanosleep() syscall. Now these patches are making use of g_usleep(). So add clock_nanosleep() to list of allowed syscalls. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+)

Re: Moving QEMU downloads to GitLab Releases?

2021-09-30 Thread Eldon Stegall
Hello! I'd be happy to help with this. I'm mostly a consumer of QEMU, but greatly appreciate all the work this community has done, and was able to contribute a little by helping with QEMU advent this past year. I would be happy to help streamline some of this activities if that would be welcome,

[PATCH] failover: allow to pause the VM during the migration

2021-09-30 Thread Laurent Vivier
If we want to save a snapshot of a VM to a file, we used to follow the following steps: 1- stop the VM: (qemu) stop 2- migrate the VM to a file: (qemu) migrate "exec:cat > snapshot" 3- resume the VM: (qemu) cont After that we can restore the snapshot with: qemu-system-x86_64 ...

[PATCH 3/3] virtio-iommu: Support bypass domain

2021-09-30 Thread Jean-Philippe Brucker
The driver can create a bypass domain by passing the VIRTIO_IOMMU_ATTACH_F_BYPASS flag on the ATTACH request. Bypass domains perform slightly better than domains with identity mappings since they skip translation. Signed-off-by: Jean-Philippe Brucker --- hw/virtio/virtio-iommu.c | 32

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Vladimir Sementsov-Ogievskiy
9/30/21 21:37, Richard W.M. Jones wrote: On Thu, Sep 30, 2021 at 02:00:11PM -0300, Willian Rampazzo wrote: On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: 9/30/21 11:47, Richard W.M. Jones wrote: Under SELinux, Unix domain sockets have two labels. One is on the disk and

Re: [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update

2021-09-30 Thread Reinoud Zandijk
On Mon, Sep 27, 2021 at 05:26:43PM +0200, Philippe Mathieu-Daudé wrote: > On 9/24/21 20:55, Cleber Rosa wrote: > > The NetBSD-7.1.2-prep.iso is no longer available on the CDN, but it's > > still available in the archive. > > > > Let's update its location so that users without the file on cache

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Eric Blake
On Wed, Sep 29, 2021 at 01:30:50AM -0400, ~farzon wrote: > From: Farzon Lotfi Food for thought: your git/mail configuration used one address for the envelope (name '~farzon' as user 'farzon@') and another as the patch author (name 'Farzon Lotfi' as user 'hi@'). Since you own your domain (with

[PATCH v4 00/13] qapi: static typing conversion, pt5b

2021-09-30 Thread John Snow
Hello darkness my old friend; This is part five (b), and focuses on QAPIDoc in parser.py. GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b CI: https://gitlab.com/jsnow/qemu/-/pipelines/380464863 Note: intentional trailing whitespace in a QAPI schema test causes a

[PATCH v4 08/13] qapi/parser: add import cycle workaround

2021-09-30 Thread John Snow
Adding static types causes a cycle in the QAPI generator: [schema -> expr -> parser -> schema]. It exists because the QAPIDoc class needs the names of types defined by the schema module, but the schema module needs to import both expr.py/parser.py to do its actual parsing. Ultimately, the

[PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG

2021-09-30 Thread Jean-Philippe Brucker
Replace the VIRTIO_IOMMU_F_BYPASS feature with VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch global bypass on and off. Add a boot-bypass option, which defaults to 'on' to be in line with other vIOMMUs and to allow running firmware/bootloader that are unaware of the

Re: [PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Joe Tanen
Peter, Thanks for the quick response. I've informally socialized the issue and will update this thread when I get more information. That aside, I'd find using CLOCK_MONOTONIC_RAW valuable if, e.g., I wanted test an NTP daemon inside of a guest and didn't want the host providing an

<    1   2   3   >