+ Paolo
On 1/11/2022 3:35 PM, Xiaoyao Li wrote:
Both pc and microvm have pit property individually. Let's just make it
the property of common x86 base machine type.
Signed-off-by: Xiaoyao Li
---
hw/i386/microvm.c | 27 +--
hw/i386/pc.c | 24
Add a test for each shift instruction in order to to prevent
regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 1 +
tests/tcg/s390x/shift.c | 258
2 files changed, 259 insertions(+)
create mode 100644
An overflow occurs for SLAG when at least one shifted bit is not equal
to sign bit. Therefore, we need to check that `shift + 1` bits are
neither all 0s nor all 1s. The current code checks only `shift` bits,
missing some overflows.
Fixes: cbe24bfa91d2 ("target-s390: Convert SHIFT, ROTATE SINGLE")
On Wed, Jan 12, 2022 at 12:14:15AM +0300, Vladislav Yaroshchuk wrote:
> macOS provides networking API for VMs called 'vmnet.framework':
> https://developer.apple.com/documentation/vmnet
>
> We can provide its support as the new QEMU network backends which
> represent three different
Signed-off-by: John G Johnson
Signed-off-by: Elena Ufimtseva
Signed-off-by: Jagannathan Raman
---
hw/vfio/user-protocol.h | 18 +
hw/vfio/migration.c | 30 +--
hw/vfio/pci.c | 7 +++
hw/vfio/user.c | 54
On Tue, Jan 11, 2022 at 07:42:59PM +0100, Philippe Mathieu-Daudé wrote:
> Since v2:
> - Split meson patch restricting fw_cfg (Richard)
> - Reorder pci_dma_map() docstring (Peter, Richard)
> - Move QEMUSGList in previous patch (David)
> - Have dma_buf_read/dma_buf_write return dma_addr_t (Peter)
>
在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
wrote:
>
> On Mon, 10 Jan 2022 at 03:40, Jason Wang
wrote:
> >
> > The following changes since commit
ср, 12 янв. 2022 г., 8:39 AM Jason Wang :
>
> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
> >
> >
> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
> >
> > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
> > wrote:
> > >
> > > On Mon, 10 Jan 2022 at 03:40, Jason Wang
> > wrote:
On 2022/1/12 1:55, Philippe Mathieu-Daudé wrote:
Fix typo in 'make check-help' output.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index
A device of USB video class usually uses larger desc structure, so
use larger buffer to avoid failure. (dev-video.c is ready)
This is an unlikely code path:
1, during guest startup, guest tries to probe device.
2, run 'lsusb' command in guest(or other similar commands).
Reviewed-by: Daniel P.
On Wednesday, January 12, 2022 10:51 AM, Zeng, Guang wrote:
> To: Tian, Kevin ; Zhong, Yang ;
> qemu-devel@nongnu.org
> Cc: pbonz...@redhat.com; Christopherson,, Sean ;
> jing2@linux.intel.com; Wang, Wei W
> Subject: Re: [RFC PATCH 6/7] x86: Use new XSAVE ioctls handling
>
> On 1/11/2022
On 10:19 Tue 11 Jan , Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Luc Michel
> ---
ping
https://lore.kernel.org/qemu-devel/20211224072511.63894-1-mkfss...@mkfssion.com
+ Paolo
On 1/11/2022 3:35 PM, Xiaoyao Li wrote:
Legacy PIC (8259) cannot be supported for TDX guests since TDX module
doesn't allow directly interrupt injection. Using posted interrupts
for the PIC is not a viable option as the guest BIOS/kernel will not
do EOI for PIC IRQs, i.e. will leave
On 2022/1/12 1:26, Peter Maydell wrote:
Fix a comment in qdev-core.h where we incorrectly referred
to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.
Signed-off-by: Peter Maydell
---
include/hw/qdev-core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Jan 12, 2022 at 1:18 AM Anup Patel wrote:
>
>
> On Mon, Jan 10, 2022 at 6:38 PM Frank Chang
> wrote:
> >
> > Anup Patel 於 2021年12月30日 週四 下午8:38寫道：
> >>
> >> From: Anup Patel
> >>
> >> The AIA spec defines programmable 8-bit priority for each local
> interrupt
> >> at M-level, S-level
David Hildenbrand noticed that sign bit index for SLDA is wrong: since
SLDA operates on 64-bit values, it should be 63, not 31.
Fixes: a79ba3398a0a ("target-s390: Convert SHIFT DOUBLE")
Signed-off-by: Ilya Leoshkevich
---
target/s390x/tcg/insn-data.def | 2 +-
1 file changed, 1 insertion(+), 1
v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html
v1 -> v2: Fix cc_calc_sla_32().
Fix cc_calc_sla_64().
Fix SLDA sign bit index.
Inline help_l2_shift().
Fix wout_r1_D32().
Add all shift instructions to the test.
Add ability to do async operations during memory transactions
Signed-off-by: Jagannathan Raman
Signed-off-by: Elena Ufimtseva
Signed-off-by: John G Johnson
---
hw/vfio/user-protocol.h | 32 +++
include/hw/vfio/vfio-common.h | 9 +-
hw/vfio/common.c | 63 +---
On 1/11/2022 10:30 AM, Tian, Kevin wrote:
From: Zeng, Guang
Sent: Monday, January 10, 2022 5:47 PM
On 1/10/2022 4:40 PM, Tian, Kevin wrote:
From: Zhong, Yang
Sent: Friday, January 7, 2022 5:32 PM
From: Jing Liu
Extended feature has large state while current
kvm_xsave only allows 4KB. Use
On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote:
>
> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
> >
> >
> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
> >
> > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
> > wrote:
> > >
> > > On Mon, 10 Jan 2022 at 03:40, Jason
On Tue, 2022-01-11 at 15:22 +0100, David Hildenbrand wrote:
> On 10.01.22 19:59, Ilya Leoshkevich wrote:
> > Both 32- and 64-bit shifts use lowest 6 address bits. The current
> > code
> > special-cases 32-bit shifts to use only 5 bits, which is not
> > correct.
> >
>
> I assume for 32-bit
According to PoP, both 32- and 64-bit shifts use lowest 6 address
bits. The current code special-cases 32-bit shifts to use only 5 bits,
which is not correct. For example, shifting by 32 bits currently
preserves the initial value, however, it's supposed zero it out
instead.
Fix by merging sh32
On Mon, Jan 10, 2022 at 02:09:59PM +0100, Philippe Mathieu-Daudé wrote:
> When building on macOS 12 we get:
>
> audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is
> deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations]
>
On Wed, Jan 12, 2022 at 3:10 PM Roman Bolshakov wrote:
>
> On Wed, Jan 12, 2022 at 01:39:28PM +0800, Jason Wang wrote:
> >
> > 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
> > >
> > >
> > > вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
> > >
> > > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
>
SRDA uses r1_D32 for binding the first operand and s64 for setting CC.
cout_s64() relies on o->out being the shift result, however,
wout_r1_D32() clobbers it.
Fix by using a temporary.
Fixes: a79ba3398a0a ("target-s390: Convert SHIFT DOUBLE")
Signed-off-by: Ilya Leoshkevich
---
On Wed, Jan 12, 2022 at 2:19 PM Vladislav Yaroshchuk
wrote:
>
>
>
> ср, 12 янв. 2022 г., 8:39 AM Jason Wang :
>>
>>
>> 在 2022/1/12 上午6:02, Vladislav Yaroshchuk 写道:
>> >
>> >
>> > вт, 11 янв. 2022 г., 5:10 AM Jason Wang :
>> >
>> > On Tue, Jan 11, 2022 at 12:49 AM Peter Maydell
>> >
On Tue, Dec 14, 2021 at 2:33 AM Eric DeVolder wrote:
>
> Ani, an inline response below.
> Thanks!
> eric
>
> On 12/10/21 08:09, Ani Sinha wrote:
> > On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder
> > wrote:
> >>
> >> Ani, inline responses below. eric
> >>
> >> On 12/9/21 00:29, Ani Sinha wrote:
>From: "Cédric Le Goater" c...@kaod.org
>To: "ma...@locati.it" ma...@locati.it, bala...@eik.bme.hu
>Cc: faro...@linux.ibm.com, qemu-devel@nongnu.org, qemu-...@nongnu.org,
>danielhb...@gmail.com
>Date: Mon, 10 Jan 2022 09:04:39 +0100
>Subject: Re: [PATCH] target/ppc: Fix e6500 boot
>
>Hello Mario,
On 1/11/22 09:45, Troy Lee wrote:
v3:
- Remove unrelated changes to SPI2 address
- Remove controller irq line
v2: Rebase to mainline QEMU
Signed-off-by: Troy Lee
Reviewed-by: Cédric Le Goater
You should consider updating the documentation :
Le 11/01/2022 à 09:29, Peter Maydell a écrit :
The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
on the code added in commit f5ef0e518d03 where we use a
shifted expression in a boolean context:
../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a
boolean
On 01/10/22 13:09, Xiaoyao Li wrote:
> On 1/10/2022 7:01 PM, Gerd Hoffmann wrote:
If you go without pflash, then you likely will not have a
standards-conformant UEFI variable store. (Unless you reimplement
the variable arch protocols in edk2 on top of something else than
the
On Tue, 11 Jan 2022 at 07:01, Laurent Vivier wrote:
>
> Le 10/01/2022 à 20:17, Peter Maydell a écrit :
> > The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
> > on the code added in commit f5ef0e518d03 where we use a
> > shifted expression in a boolean context:
> >
> >
The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
on the code added in commit f5ef0e518d03 where we use a
shifted expression in a boolean context:
../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a
boolean always evaluates to true
On 1/10/22 19:15, Fabiano Rosas wrote:
This is the first series of the exception model-specific changes. I
intend to keep this same structure for the rest of the exception
models.
== preparation ==
First few patches are cleanups specific to this model. This comes
first because I'm using some
On Tue, Jan 11, 2022 at 11:27:58AM +0800, Yanan Wang wrote:
> The pointer assignment "const char *p = path;" in function
> qemu_fdt_add_path is unnecessary. Let's remove it and just
> use the "path" passed in. No functional change.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Yanan Wang
Hi Akihiko
On Tue, Jan 11, 2022 at 7:30 AM Akihiko Odaki wrote:
>
> Hi,
>
> I found this brings an inconsistency and a flaw to scanout semantics and
> think the inconsistency should be fixed or this should be reverted
> before the next release comes up.
>
> The inconsistency is in the handling
Coroutine pool size was 64 from long ago, and the basis was organized in the
commit message in c740ad92.
At that time, virtio-blk queue-size and num-queue were not configuable, and
equivalent values were 128 and 1.
Coroutine pool size 64 was fine then.
Later queue-size and num-queue got
Resending patch with fixing atomic access method to use qatomic_read().
We encountered random disk IO performance drop since qemu-5.0.0, and this patch
fixes it.
Commit message in c740ad92 implied to adjust coroutine pool size adaptively, so
I tried to implement this.
Could you review this
On 1/11/22 09:45, Troy Lee wrote:
This series of patch introduce a dummy implemenation of aspeed i3c
model, and it provide just enough information for guest machine.
However, the driver probing is still failed, but it will not cause
kernel panic.
v3:
- Remove unused AspeedI3CClass
- Refine
Am 10.01.22 um 15:18 schrieb Stefano Garzarella:
> On Mon, Jan 10, 2022 at 12:41:54PM +0100, Peter Lieven wrote:
>> librbd had a bug until early 2022 that affected all versions of ceph that
>> supported fast-diff. This bug results in reporting of incorrect offsets
>> if the offset parameter to
Hello Troy,
+
+memory_region_init_io(>iomem, OBJECT(s), _i3c_ops, s,
+TYPE_ASPEED_I3C, ASPEED_I3C_NR_REGS << 2);
+
+sysbus_init_mmio(sbd, >iomem);
I would add a container region containing all the regions :
memory_region_init(>iomem_container, OBJECT(s),
On Tue, 11 Jan 2022 at 07:09, Zhang Chen wrote:
>
> To record screencast, AVAssetWriter APIs were called for each
> cocoa_update call.
>
> Commands for start/stop recording were added to View menu.
This seems a bit of an odd feature -- why doesn't the OS just
permit screen recording of any
Aspeed 2600 SDK enables I3C support by default. The I3C driver will try
to reset the device controller and setup through device address table
register. This dummy model response these register with default value
listed on ast2600v10 datasheet chapter 54.2. If the device address
table register
v3:
- Remove unrelated changes to SPI2 address
- Remove controller irq line
v2: Rebase to mainline QEMU
Signed-off-by: Troy Lee
---
hw/arm/aspeed_ast2600.c | 16
include/hw/arm/aspeed_soc.h | 3 +++
2 files changed, 19 insertions(+)
diff --git a/hw/arm/aspeed_ast2600.c
This series of patch introduce a dummy implemenation of aspeed i3c
model, and it provide just enough information for guest machine.
However, the driver probing is still failed, but it will not cause
kernel panic.
v3:
- Remove unused AspeedI3CClass
- Refine memory region
- Refine register reset
-
Hi Jean, Michael,
On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> Replace the VIRTIO_IOMMU_F_BYPASS feature with
> VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch
> global bypass on and off.
>
> Add a boot-bypass option, which defaults to 'on' to be in line with
>
On 1/11/22 09:45, Troy Lee wrote:
Aspeed 2600 SDK enables I3C support by default. The I3C driver will try
to reset the device controller and setup through device address table
register. This dummy model response these register with default value
listed on ast2600v10 datasheet chapter 54.2. If
On 1/11/22 06:56, Cédric Le Goater wrote:
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
This patch introduces pnv-phb4 user creatable devices that are created
in a similar manner as pnv-phb3 devices, allowing the user to interact
with the PHBs directly instead of creating PCI Express
Hi Jean,
On 1/11/22 11:13 AM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote:
>> Hi Jean, Michael,
>>
>> On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
>>> Replace the VIRTIO_IOMMU_F_BYPASS feature with
>>> VIRTIO_IOMMU_F_BYPASS_CONFIG,
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> This is now always true, since we require armv6.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Mon, 10 Jan 2022 at 19:20, Philippe Mathieu-Daudé wrote:
>
> On 1/10/22 17:02, Peter Maydell wrote:
> > On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote:
> >>
> >> Hi Richard,
> >>
> >> This is the SD/MMC PR that ought to be sent previously.
> >>
> >> The following changes since
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> +static void tcg_out_test_alignment(TCGContext *s, bool is_ld, TCGReg addrlo,
> + TCGReg addrhi, unsigned a_bits)
> @@ -1709,6 +1778,10 @@ static void
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
> On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
> >
> > A device of USB video class usually uses larger desc structure, so
> > use larger buffer to avoid failure. (dev-video.c is ready)
> >
> > Allocating memory dynamically by
On 1/11/22 8:25 PM, Daniel P. Berrangé wrote:
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
A device of USB video class usually uses larger desc structure, so
use larger buffer to avoid failure. (dev-video.c is ready)
Remove the pages argument. And s/pages/page/
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
--
- Use 1LL instead of casts (philmd)
- Change the whole 1ULL for TARGET_PAGE_SIZE
Signed-off-by: Juan Quintela
---
migration/ram.c | 8
1 file
On Mon, Jan 10, 2022 at 07:43:06PM +, Raphael Norwitz wrote:
> On Mon, Jan 10, 2022 at 04:36:34AM -0500, Michael S. Tsirkin wrote:
> > On Thu, Jan 06, 2022 at 06:47:26AM +, Raphael Norwitz wrote:
> > > Signed-off-by: Raphael Norwitz
> >
> >
> > Raphael any chance you can add a bit more
> On Thu, Jan 06, 2022 at 05:20:57PM +0900, Hiroki Narukawa wrote:
>
> Phil, thanks for notifying me.
>
> > Coroutine pool size was 64 from long ago, and the basis was organized in
> > the commit message in c740ad92.
> >
> > At that time, virtio-blk queue-size and num-queue were not
That is my understanding…
See you there!
Cheers
Mark.
> On 11 Jan 2022, at 11:20, Philippe Mathieu-Daudé wrote:
>
> Hi,
>
> Just checking in, this call is scheduled for today, 3pm CEST, right?
>
> Here is the KVM call calendar:
>
On 1/7/22 01:17, Richard Henderson wrote:
> On 1/4/22 12:54 AM, Philippe Mathieu-Daudé wrote:
>> +if have_system or have_tools
> ...
>> if have_system
>> + stub_ss.add(files('fw_cfg.c'))
>
> Disconnect in tests?
(I assume s/tests/stubs/).
fw_cfg-interface.c exposes the fw_cfg QOM interface,
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> This is now always true, since we require armv6.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
The goto is not needed at all.
Signed-off-by: Juan Quintela
---
migration/ram.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index fa49d22e69..422c6bce28 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1341,12 +1341,11
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
This patch introduces pnv-phb4 user creatable devices that are created
in a similar manner as pnv-phb3 devices, allowing the user to interact
with the PHBs directly instead of creating PCI Express Controllers that
will create a certain amount of
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
Its only callers are inside pnv_phb4.c.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/pci-host/pnv_phb4.c | 52 +-
include/hw/pci-host/pnv_phb4.h | 1 -
On Tue, 11 Jan 2022 at 10:19, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
> Signed-off-by: Dr. David Alan Gilbert
> ---
>
A device of USB video class usually uses larger desc structure, so
use larger buffer to avoid failure. (dev-video.c is ready)
Allocating memory dynamically by g_malloc of the orignal version of
this change, Philippe suggested just using the stack. Test the two
versions of qemu binary, the size of
On Wed, Dec 15, 2021 at 04:31:26PM +0100, Kevin Wolf wrote:
> Am 15.12.2021 um 12:28 hat Stefan Hajnoczi geschrieben:
> > On Tue, Dec 14, 2021 at 03:59:49PM +0100, Kevin Wolf wrote:
> > > Am 14.12.2021 um 15:35 hat Stefan Hajnoczi geschrieben:
> > > > The BlockBackend root child can change when
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Support for unaligned accesses is difficult for pre-v6 hosts.
> While debian still builds for armv4, we cannot use a compile
> time test, so test the architecture at runtime and error out.
>
> Signed-off-by: Richard Henderson
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> We will shortly allow the use of unaligned memory accesses,
> and these require proper alignment. Use get_alignment_bits
> to verify and remove USING_SOFTMMU.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 22
On Mon, 10 Jan 2022 at 21:04, Michael S. Tsirkin wrote:
>
> Changes from v1:
> added tags to commit logs.
>
> The following changes since commit ca745d2277496464b54fd832c15c45d0227325bb:
>
> tests: acpi: Add updated TPM related tables (2022-01-07 19:30:13 -0500)
>
> are available in the Git
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Reserve a register for the guest_base using aarch64 for reference.
> By doing so, we do not have to recompute it for every memory load.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 39
We're missing an unlock in case installing the signal handler failed.
Fortunately, we barely see this error in real life.
Fixes: a960d6642d39 ("util/oslib-posix: Support concurrent os_mem_prealloc()
invocation")
Fixes: CID 1468941
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Pankaj Gupta
Cc:
On Mon, Dec 27, 2021 at 10:27:33PM +0800, zhenwei pi wrote:
> A device of USB video class usually uses larger desc structure, so
> use larger buffer to avoid failure.
>
> Signed-off-by: zhenwei pi
> ---
> hw/usb/desc.c | 15 ---
> hw/usb/desc.h | 1 +
> 2 files changed, 9
For fd-based shared memory, MAP_NORESERVE is only effective for hugetlb,
otherwise it's ignored. Older Linux versions that didn't support
reservation of huge pages ignored MAP_NORESERVE completely.
The first client to mmap a hugetlb fd without MAP_NORESERVE will
trigger reservation of huge pages
On 2022/01/11 17:23, Marc-André Lureau wrote:
Hi Akihiko
On Tue, Jan 11, 2022 at 7:30 AM Akihiko Odaki wrote:
Hi,
I found this brings an inconsistency and a flaw to scanout semantics and
think the inconsistency should be fixed or this should be reverted
before the next release comes up.
We only need last_stage in two places and we are passing it all
around. Just add a field to RAMState that passes it.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
Repeat subject (philmd suggestion)
---
migration/ram.c | 41 ++---
1 file changed,
Hi
Changes since v2:
- rebase
- address comments
- use TARGET_PAGE_SIZE and remove casts
- remove TARGET_PAGE_MASK from compression code.
Nothing else use them. And if offsets are not aligned,
we are in big trouble.
Please, review.
Changes since v1:
- Add reviewed tags for reviewed patches
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
Moving all phb4 properties setup to stk_realize() keeps this logic in
a single place instead of having it scattered between stk_realize() and
pec_realize().
'phb->index' can be retrieved using stack->stack_no and
pnv_phb4_pec_get_phb_id(),
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
The 'stack->phb_regs_mr' PHB4 passthrough XSCOM initialization relies on
'stack->phb' being not NULL. Moving 'stack->phb_regs_mr' region_init()
and add_subregion() to phb4_realize() time is a natural thing to do
since it's strictly PHB related.
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
At this moment, stack->phb is the plain PnvPHB4 device itself instead of
a pointer to the device. This will present a problem when adding user
creatable devices because we can't deal with this struct and the
realize() callback from the user
Hi Eric,
On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote:
> Hi Jean, Michael,
>
> On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> > Replace the VIRTIO_IOMMU_F_BYPASS feature with
> > VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch
> > global bypass on and
From: "Dr. David Alan Gilbert"
Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
Signed-off-by: Dr. David Alan Gilbert
---
hw/core/clock-vmstate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/core/clock-vmstate.c
On 1/11/22 11:49, zhenwei pi wrote:
> A device of USB video class usually uses larger desc structure, so
> use larger buffer to avoid failure. (dev-video.c is ready)
>
> Allocating memory dynamically by g_malloc of the orignal version of
> this change, Philippe suggested just using the stack.
So printing it as %d is wrong. Notice that for the channel id, that
is an uint8_t, but I changed it anyways for consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
---
migration/multifd-zlib.c | 20 ++--
migration/multifd-zstd.c
On Mon, 10 Jan 2022 at 15:01, Paolo Bonzini wrote:
>
> The following changes since commit afe33262585565b64df706c62b4b0f6e0ad30c71:
>
> Merge tag 'pull-riscv-to-apply-20220108' of github.com:alistair23/qemu into
> staging (2022-01-07 22:09:24 -0800)
>
> are available in the Git repository at:
Hi,
Just checking in, this call is scheduled for today, 3pm CEST, right?
Here is the KVM call calendar:
https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ
On 1/6/22 12:23, Daniel P. Berrangé wrote:
> No one objected, so I think we
On Tue, Jan 11, 2022 at 11:20:54AM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Just checking in, this call is scheduled for today, 3pm CEST, right?
>
> Here is the KVM call calendar:
>
On Tue, Jan 11, 2022 at 03:35:27PM +0800, Xiaoyao Li wrote:
> Both pc and microvm have pit property individually. Let's just make it
> the property of common x86 base machine type.
>
> Signed-off-by: Xiaoyao Li
> ---
> hw/i386/microvm.c | 27 +--
> hw/i386/pc.c
On Tue, Jan 11, 2022 at 03:35:28PM +0800, Xiaoyao Li wrote:
> Legacy PIC (8259) cannot be supported for TDX guests since TDX module
> doesn't allow directly interrupt injection. Using posted interrupts
> for the PIC is not a viable option as the guest BIOS/kernel will not
> do EOI for PIC IRQs,
Hi Peter,
On Tue, Jan 11, 2022 at 10:10:16AM +0100, Peter Lieven wrote:
Hi Stefano,
thanks for the feedback. Please note that you also need the other patch
or you will sooner or later run into another assertion as soon as rbd
snapshots are involved.
Yep, I tested with the entire series
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> From armv6, the architecture supports unaligned accesses.
> All we need to do is perform the correct alignment check
> in tcg_out_tlb_read.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 39
Orginal qemu commit hash: de3f5223fa4cf8bfc5e3fe1fd495ddf468edcdf7
In util/fdmon-epoll.c, function fdmon_epoll_update, variable "old_node"
maybe NULL with the condition, while it is directly used in the statement and
may lead to null pointer dereferencen problem.
Variable "r" in the condition is
I've been working on the ITS to add support for the GICv4 functionality.
In the course of that I found a handful of bugs in it and also some
places where the code benefited from refactoring to make it a better
base to put in the GICv4 parts. This patchset is just the bugfixes
and cleanups, because
The bounds check on the number of interrupt IDs is correct, but
doesn't match our convention; change the variable name, initialize it
to the 2^n value rather than (2^n)-1, and use >= instead of > in the
comparison.
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
---
Fix process_mapti() to consistently return CMD_STALL for memory
errors and CMD_CONTINUE for parameter errors, as we claim in the
comments that we do.
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
---
hw/intc/arm_gicv3_its.c | 28
On 1/11/22 17:51, Peter Maydell wrote:
On Tue, 4 Jan 2022 at 07:31, Cédric Le Goater wrote:
Signed-off-by: Cédric Le Goater
Reviewed-by: Richard Henderson
Message-Id: <20211222071002.1568894-1-...@kaod.org>
Signed-off-by: Cédric Le Goater
---
target/ppc/mmu-radix64.c | 55
Reviewed-by: Hao Wu
Signed-off-by: Patrick Venture
---
hw/arm/npcm7xx_boards.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c
index 7d0f3148be..d701e5cc55 100644
--- a/hw/arm/npcm7xx_boards.c
+++
Fix process_mapc() to consistently return CMD_STALL for memory
errors and CMD_CONTINUE for parameter errors, as we claim in the
comments that we do.
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
---
hw/intc/arm_gicv3_its.c | 8 +++-
1 file changed, 3
On Mon, Jan 10, 2022 at 05:56:25PM +, John Levon wrote:
> On Thu, Jan 06, 2022 at 01:35:32PM +, Stefan Hajnoczi wrote:
>
> > > > >> +static void vfu_object_attach_ctx(void *opaque)
> > > > >> +{
> > > > >> +VfuObject *o = opaque;
> > > > >> +GPollFD pfds[1];
> > > > >> +int
On Tue, 11 Jan 2022 at 10:19, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
> Signed-off-by: Dr. David Alan Gilbert
> ---
>
1 - 100 of 308 matches
Mail list logo
