From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
include/qemu/atomic.h| 8 +---
subprojects/libvhost-user/include/compiler.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
create mode 12 subprojects/libvhost-user/include/compiler.h
diff
From: Marc-André Lureau
Suggested-by: Peter Maydell
Signed-off-by: Marc-André Lureau
---
include/{qemu-common.h => qemu/copyright.h} | 0
bsd-user/main.c | 2 +-
linux-user/main.c | 2 +-
qemu-img.c | 2 +-
From: Marc-André Lureau
No need to pass it from configure environment down to wixl. Let simply
set a wixl -D variable. If it needs to be configurable, we should have a
proper option.
Signed-off-by: Marc-André Lureau
---
configure | 4
qga/installer/qemu-ga.wxs | 10
From: Marc-André Lureau
Since the introduction of guest-exec in/out/err redirections in commit
a1853dca74 ("qga: guest-exec simple stdin/stdout/stderr redirection"),
some execution state variables are handled with atomic ops. However,
there are no threads involved in this code (and glib sources
From: Marc-André Lureau
The functions are already covered in check-block-qdict.c.
This will help moving QAPI-related tests in a common subproject.
Signed-off-by: Marc-André Lureau
---
tests/unit/check-qobject.c | 8
1 file changed, 8 deletions(-)
diff --git
Hi Igor,
On 4/20/22 7:50 PM, Igor Mammedov wrote:
On Wed, 20 Apr 2022 18:31:02 +0800
Gavin Shan wrote:
On 4/20/22 4:32 PM, Igor Mammedov wrote:
On Mon, 18 Apr 2022 10:09:18 +0800
Gavin Shan wrote:
Currently, the SMP configuration isn't considered when the CPU
topology is populated. In
* marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote:
> From: Marc-André Lureau
>
> ../migration/ram.c:1292:31: warning: use of bitwise '&' with boolean operands
> [-Wbitwise-instead-of-logical]
>
> Signed-off-by: Marc-André Lureau
Yeh that's the same as:
Hi
On Wed, Apr 20, 2022 at 6:37 PM Thomas Huth wrote:
>
> On 20/04/2022 16.10, Daniel P. Berrangé wrote:
> > On Wed, Apr 20, 2022 at 05:26:00PM +0400, marcandre.lur...@redhat.com wrote:
> >> From: Marc-André Lureau
> >>
> >> According to our configure checks, this is the list of supported
> >>
On Wed, Apr 20, 2022 at 05:25:44PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The old code is kind of wrong. Say it's 1649309843.01 seconds past
> the epoch. Prints "1649309843.1". 9us later, it prints "1649309843.10".
> Should really use %06lu for the
Richard Henderson writes:
> On 4/19/22 02:10, Alex Bennée wrote:
>> We might as well include a reference file for i386/x86_64. I was going
>> to include s390x as well but it's broken hence I raised:
>>https://gitlab.com/qemu-project/qemu/-/issues/979.
>> Signed-off-by: Alex Bennée
>> ---
On Wed, Apr 20, 2022 at 05:25:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> hw/hyperv/syndbg.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
On Wed, Apr 20, 2022 at 05:26:03PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The implementation depends on the OS. (and longer-term goal is to move
> cutils to a common subproject)
Common with what other thing(s) ?
IMHO alot of cutils should just go away in favour
On Wed, Apr 20, 2022 at 05:25:55PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> docs/devel/tracing.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
Hi
On Wed, Apr 20, 2022 at 7:17 PM Daniel P. Berrangé
wrote:
> On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com
> wrote:
> > From: Marc-André Lureau
>
> Could use a commit message explaining why this is a good
> idea.
>
> I see it contains QEMU_COPYRIGHT macro, but it also
CONFIG_XEN_PCI_PASSTHROUGH is just a global configuration option; the selection
of the actual files in hw/xen/meson.build is also conditional on CONFIG_XEN,
so there is no need to put CONFIG_XEN_PCI_PASSTHROUGH in config-target.h.
This inaccuracy was copied over from the configure script in
On Wed, Apr 20, 2022 at 05:26:19PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Mostly for correctness.
>
> Signed-off-by: Marc-André Lureau
> ---
> util/oslib-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With
This is quite a complicated check. I moved all the test programs to
a single file in scripts/, picking the right program with #if and a -D
flag in meson.build's cc.links() invocation.
Signed-off-by: Paolo Bonzini
---
configure| 322 +--
The hash is now generated with a Python script.
Signed-off-by: Paolo Bonzini
---
configure | 23 ---
docs/meson.build | 2 +-
meson.build | 10 +-
meson_options.txt | 2 ++
scripts/meson-buildoptions.py
When using Meson options rather than config-host.h, the "when" clauses
have to be changed to if statements (which is not necessarily great,
though at least it highlights which parts of the build are per-target
and which are not).
Do that before moving vhost logic to meson.build, though for now
* Andrea Bolognani (abolo...@redhat.com) wrote:
> The correct return type is ReplicationStatus, not
> ReplicationResult.
>
> Signed-off-by: Andrea Bolognani
Hmm yes I think that's right.
Reviewed-by: Dr. David Alan Gilbert
> ---
> qapi/migration.json | 2 +-
> 1 file changed, 1
On Wed, Apr 20, 2022 at 05:26:12PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This allows to make sure the test is still built, and gives more
> accurate report details.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/unit/test-qga.c | 7 +++
>
vhost-user-fs is a device and it should be possible to enable/disable
it with --without-default-devices, not --without-default-features.
Compute its default value in Kconfig to obtain the more intuitive
behavior.
In this case the configure options were undocumented, too.
Signed-off-by: Paolo
On 20/04/2022 17.33, Paolo Bonzini wrote:
The file has been removed in commit a8260d3876 ("ui: install logo icons to
$prefix/share/icons", 2019-01-21), do not try to symlink it in the build tree.
Signed-off-by: Paolo Bonzini
---
configure | 1 -
1 file changed, 1 deletion(-)
diff --git
On Wed, Apr 20, 2022 at 7:46 PM Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
>
Reviewed-by: Marc-André Lureau
> ---
> configure | 28
> meson.build | 13 +
> 2 files changed, 13 insertions(+), 28 deletions(-)
>
> diff --git a/configure
On 20/04/2022 17.32, Marc-André Lureau wrote:
Hi
On Wed, Apr 20, 2022 at 7:24 PM Daniel P. Berrangé wrote:
On Wed, Apr 20, 2022 at 06:50:12PM +0400, Marc-André Lureau wrote:
Hi
On Wed, Apr 20, 2022 at 6:46 PM Marc-André Lureau
wrote:
Hi
On Wed, Apr 20, 2022 at 6:37 PM Thomas Huth
From: Frank Chang
This patchset makes ACLINT mtime to be writable as RISC-V privilege
spec defines that mtime is exposed as a memory-mapped machine-mode
read-write register. Also, mtimecmp and mtime should be 32/64-bit memory
accessible registers. ACLINT reset function is also added, which
From: Frank Chang
RISC-V privilege spec defines that:
* In RV32, memory-mapped writes to mtimecmp modify only one 32-bit part
of the register.
* For RV64, naturally aligned 64-bit memory accesses to the mtime and
mtimecmp registers are additionally supported and are atomic.
It's possible
From: Frank Chang
If device's MemoryRegion doesn't have .impl.[min|max]_access_size
declaration, the default access_size_min would be 1 byte and
access_size_max would be 4 bytes (see: softmmu/memory.c).
This will cause a 64-bit memory access to ACLINT to be splitted into
two 32-bit memory
From: Bin Meng
Per PowerISA v2.07 [1], Book III-E, chapter 7.6 "Interrupt definitions"
"When in Internal Debug Mode with MSR.DE=0, then Instruction Complete
and Branch Taken debug events cannot occur, and no DBSR status bits
are set and no subsequent imprecise Debug interrupt will occur."
From: Jim Shu
This commit implements reset function of all ACLINT devices.
ACLINT device reset will clear MTIME and MSIP register to 0.
Depend on RISC-V ACLINT spec v1.0-rc4:
https://github.com/riscv/riscv-aclint/blob/v1.0-rc4/riscv-aclint.adoc
Signed-off-by: Jim Shu
Reviewed-by: Frank Chang
On Tue, Apr 12, 2022 at 9:11 AM Bin Meng wrote:
>
> On Thu, Mar 24, 2022 at 9:48 PM Bin Meng wrote:
> >
> > From: Bin Meng
> >
> > Sync uboot_image.h from upstream U-Boot v2022.01 release [1].
> >
> > [1] https://source.denx.de/u-boot/u-boot/-/blob/v2022.01/include/image.h
> >
> >
On Tue, 19 Apr 2022 13:41:03 +0200
Christian Schoenebeck wrote:
> mknod() on macOS does not support creating sockets, so divert to
> call sequence socket(), bind() and chmod() respectively if S_IFSOCK
> was passed with mode argument.
>
Hmm... thinking again about this one : QEMU on linux calls
On 31/03/2022 09.48, Steven Lee wrote:
This add two addition test cases for accumulative mode under sg enabled.
The input vector was manually craft with "abc" + bit 1 + padding zeros + L.
The padding length depends on algorithm, i.e. SHA512 (1024 bit),
SHA256 (512 bit).
The result was
The fuzz tests are currently scheduled for all targets, but their setup
code limits the run to "i386", so that these tests always show "SKIP"
on other targets. Move it to the right x86 list in meson.build, then
we can drop the architecture check during runtime, too.
Message-Id:
Allow the same set of tests for all MIPS targets, so that "mipsel"
now gets some additional test coverage, too. While we're at it,
simplify the definitions for qtests_mips64 and qtests_mips64el.
Message-Id: <20220414114655.604391-1-th...@redhat.com>
Signed-off-by: Thomas Huth
---
From: Cornelia Huck
Add 7.1 machine types for arm/i440fx/m68k/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
Message-Id: <20220316145521.1224083-1-coh...@redhat.com>
Reviewed-by: Eric Farman
Reviewed-by: Cédric Le Goater
Acked-by: Laurent Vivier
Reviewed-by: Eric Auger
Reviewed-by: Yanan
On Thu, Mar 31, 2022 at 11:08:43AM -0400, Peter Xu wrote:
> Will be reused in postcopy fast load thread.
>
> Reviewed-by: Dr. David Alan Gilbert
> Signed-off-by: Peter Xu
> ---
> migration/ram.c | 2 +-
> migration/ram.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by:
When the PPTT table is built, the CPU topology is re-calculated, but
it's unecessary because the CPU topology has been populated in
virt_possible_cpu_arch_ids() on arm/virt machine.
This reworks build_pptt() to avoid by reusing the existing IDs in
ms->possible_cpus. Currently, the only user of
On Thu, Mar 31, 2022 at 11:08:45AM -0400, Peter Xu wrote:
> Previously migration didn't have an easy way to cleanup the listening
> transport, migrate recovery only allows to execute once. That's done with a
> trick flag in postcopy_recover_triggered.
>
> Now the facility is already there.
>
>
When CPU-to-NUMA association isn't explicitly provided by users,
the default one is given by mc->get_default_cpu_node_id(). However,
the CPU topology isn't fully considered in the default association
and this causes CPU topology broken warnings on booting Linux guest.
For example, the following
On Thu, Mar 31, 2022 at 11:08:57AM -0400, Peter Xu wrote:
> Four tests are added for preempt mode:
>
> - Postcopy default
> - Postcopy tls
> - Postcopy recovery
> - Postcopy tls+recovery
>
> Signed-off-by: Peter Xu
> ---
> tests/qtest/migration-test.c | 49
On Wed, 20 Apr 2022 18:31:02 +0800
Gavin Shan wrote:
> Hi Igor,
>
> On 4/20/22 4:32 PM, Igor Mammedov wrote:
> > On Mon, 18 Apr 2022 10:09:18 +0800
> > Gavin Shan wrote:
> >
> >> Currently, the SMP configuration isn't considered when the CPU
> >> topology is populated. In this case, it's
During a subsystem reset the Topology-Change-Report is cleared.
Let's ask KVM to clear the MTCR in the case of a subsystem reset.
Signed-off-by: Pierre Morel
---
hw/s390x/cpu-topology.c | 6 ++
hw/s390x/s390-virtio-ccw.c | 1 +
target/s390x/cpu-sysemu.c| 7 +++
S390x CPU Topology allows a non uniform repartition of the CPU
inside the topology containers, sockets, books and drawers.
We use numa to place the CPU inside the right topology container
and report the non uniform topology to the guest.
Note that s390x needs CPU0 to belong to the topology and
On Tue, 19 Apr 2022 13:41:03 +0200
Christian Schoenebeck wrote:
> mknod() on macOS does not support creating sockets, so divert to
> call sequence socket(), bind() and chmod() respectively if S_IFSOCK
> was passed with mode argument.
>
> Link:
From: Marc-André Lureau
Hi,
Another batch of cleanup patches, mostly while working on moving the common code
in some future subprojects. (a few patches have been posted and reviewed
earlier)
Marc-André Lureau (41):
qga: use fixed-length for usecs formatting
glib-compat: isolate
From: Marc-André Lureau
Simplify a bit pre-compiler conditions.
For TSAN, QEMU already has CONFIG_TSAN, but it is only set when the
fiber API is present. (I wonder whether supporting TSAN without the
fiber API is really relevant)
Signed-off-by: Marc-André Lureau
---
include/qemu/compiler.h |
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/devel/tracing.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/tracing.rst b/docs/devel/tracing.rst
index ec9a687cfdc9..d288480db11f 100644
--- a/docs/devel/tracing.rst
+++
On 11/04/2022 22:51, Richard Henderson wrote:
On 4/5/22 12:55, Lucas Mateus Castro(alqotel) wrote:
+
+#define DO_VDIV_VMOD(NAME, SZ, DIV,
SIGNED) \
+static void NAME(TCGv_i##SZ t, TCGv_i##SZ a, TCGv_i##SZ
b) \
+{ \
+ /* \
+ * If N/0 the
From: Marc-André Lureau
Move QEMU-specific code to util/osdep.c, so cutils can become a common
subproject.
Signed-off-by: Marc-André Lureau
---
include/qemu/cutils.h | 1 -
include/qemu/osdep.h | 2 ++
util/cutils.c | 16
util/osdep.c | 16
From: Marc-André Lureau
Move the macro and declaration so it can use glib in the following
patch (it already depends on glib anyway for !optimize)
Signed-off-by: Marc-André Lureau
---
include/qemu/compiler.h | 16
include/qemu/osdep.h| 16
2 files
From: Marc-André Lureau
../migration/ram.c:1292:31: warning: use of bitwise '&' with boolean operands
[-Wbitwise-instead-of-logical]
Signed-off-by: Marc-André Lureau
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
On Tue, Apr 19, 2022 at 01:32:42PM +0200, Florian Weimer wrote:
> * Stefan Hajnoczi:
>
> > On Tue, Mar 01, 2022 at 12:54:49PM +0100, Florian Weimer wrote:
> >> > I took a quick look at C++20 coroutines since they are available in
> >> > compilers but the primitives look hard to use even from C++,
From: Marc-André Lureau
Move them where they belong, since the functions are implemented in
block-qdict.c.
Signed-off-by: Marc-André Lureau
---
include/block/qdict.h | 3 +++
include/qapi/qmp/qdict.h | 3 ---
softmmu/vl.c | 1 +
tests/unit/check-qobject.c | 1 +
4 files
On 20/04/2022 15.26, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tests/qtest/fdc-test.c| 2 +-
util/coroutine-ucontext.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/fdc-test.c
Bin Meng writes:
> From: Bin Meng
>
> Per PowerISA v2.07 [1], Book III-E, chapter 7.6 "Interrupt definitions"
Which BookE board are you concerned about? I don't think we have any
BookE ISA v2.07 in QEMU currently.
> "When in Internal Debug Mode with MSR.DE=0, then Instruction Complete
> and
On Wed, Apr 20, 2022 at 05:25:46PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The header is no longer commonly included.
>
> Signed-off-by: Marc-André Lureau
> ---
> scripts/analyze-inclusions | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P.
On 20/04/2022 16.46, Marc-André Lureau wrote:
Hi
On Wed, Apr 20, 2022 at 6:37 PM Thomas Huth wrote:
On 20/04/2022 16.10, Daniel P. Berrangé wrote:
On Wed, Apr 20, 2022 at 05:26:00PM +0400, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
According to our configure checks, this
On 20/04/2022 15.25, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Hi,
Another batch of cleanup patches, mostly while working on moving the common code
in some future subprojects. (a few patches have been posted and reviewed
earlier)
Marc-André Lureau (41):
qga: use
On 20/04/2022 15.26, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
../tests/qtest/fuzz/generic_fuzz.c:746:17: warning: variable 'name' set but not
used [-Wunused-but-set-variable]
Signed-off-by: Marc-André Lureau
---
tests/qtest/fuzz/generic_fuzz.c | 2 --
1 file changed, 2
Richard Henderson writes:
> On 4/19/22 02:10, Alex Bennée wrote:
>> This is a simple transliteration of the float_convs test but this time
>> working with doubles. I'm used it to test the handling of vector
>> registers in gdbstub but wasn't able to find a non-ugly way to
>> automate it.
>>
Hi
On Wed, Apr 20, 2022 at 6:10 PM Daniel P. Berrangé wrote:
>
> On Wed, Apr 20, 2022 at 05:26:00PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > According to our configure checks, this is the list of supported
> > compilers.
> >
> > Signed-off-by: Marc-André
On Wed, Apr 20, 2022 at 05:25:58PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> While at it, replace '%x' with '%u' as suggested by Philippe Mathieu-Daudé.
>
> Also fixes a GCC 12.0.1 -Wformat-overflow false-positive.
>
> Signed-off-by: Marc-André Lureau
>
On Wed, Apr 20, 2022 at 05:25:54PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The latter simply requires glib.h, while the former is not in the
> Windows API (but provided by mingw header & CRT)
>
> Also simplify the expression for 1/10s.
>
> Signed-off-by:
Commit 4e99f4b12c0e dropped simple unions and updated most
documentation accordingly, but in one case we still claim that
there are "two flavors of unions".
Signed-off-by: Andrea Bolognani
---
docs/devel/qapi-code-gen.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This is the last CONFIG_* entry in config-host.mak that had to be
special cased.
Signed-off-by: Paolo Bonzini
---
configure | 6 --
meson.build | 6 ++
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 3 +++
4 files changed, 7
The more interesting bits here are:
* move all remaining dependencies except glib to Meson (glib depends on
https://github.com/mesonbuild/meson/pull/10206/)
* many more options are parsed from introspection data, including
string options
* make all -D options optional on the meson command
On Wed, Apr 20, 2022 at 05:26:20PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> qemu_open_old(O_CREATE) should be replaced with qemu_create() which
> handles Error reporting.
>
> Signed-off-by: Marc-André Lureau
> ---
> util/oslib-posix.c | 3 +--
> 1 file changed,
On 20/04/2022 17.33, Paolo Bonzini wrote:
$debug_info is not needed anywhere except in the final meson invocation,
no need to special case it.
Signed-off-by: Paolo Bonzini
---
configure | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/configure b/configure
Andrea Bolognani (2):
docs: build-platforms: Fix spelling for Homebrew
docs: build-platforms: Clarify stance on minor releases and backports
docs/about/build-platforms.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
2.35.1
On Wed, Apr 20, 2022 at 05:26:18PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Use qemu_write_full() instead of open-coding a write loop.
>
> Signed-off-by: Marc-André Lureau
> ---
> util/compatfd.c | 18 ++
> 1 file changed, 2 insertions(+), 16
Michael,
Let me know if you want me to grab this patch from the ppc tree. I'm
going to send a PR in the next few days.
Thanks,
Daniel
On 4/8/22 10:13, Frederic Barrat wrote:
This patch skips [de]asserting a LSI interrupt if the device doesn't
have any LSI defined. Doing so would trigger an
From: Marc-André Lureau
The function is required by get_relocated_path(), which is used by
qemu-ga and may be generally useful.
Signed-off-by: Marc-André Lureau
---
include/qemu/cutils.h| 7 ++
include/qemu/osdep.h | 8 --
qemu-io.c
From: Marc-André Lureau
The latter simply requires glib.h, while the former is not in the
Windows API (but provided by mingw header & CRT)
Also simplify the expression for 1/10s.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
qga/main.c | 2 +-
1 file changed, 1
From: Marc-André Lureau
Since the introduction of the variable in commit 9dacf32d2cb ("qemu-ga:
Building Windows MSI installation with configure/Makefile"), nothing
makes use of the Mingw_dlls variable in the .wxs file.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
From: Marc-André Lureau
../tests/qtest/fuzz/generic_fuzz.c:746:17: warning: variable 'name' set but not
used [-Wunused-but-set-variable]
Signed-off-by: Marc-André Lureau
---
tests/qtest/fuzz/generic_fuzz.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/qtest/fuzz/generic_fuzz.c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
tests/qtest/fdc-test.c| 2 +-
util/coroutine-ucontext.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/fdc-test.c b/tests/qtest/fdc-test.c
index 4aa72f36431f..0b3c2c0d523f 100644
---
From: Marc-André Lureau
Also fixes a GCC 12.0.1 false-positive:
../hw/arm/digic.c: In function ‘digic_init’:
../hw/arm/digic.c:45:54: error: ‘%d’ directive output may be truncated writing
between 1 and 11 bytes into a region of size 5 [-Werror=format-truncation=]
45 | snprintf(name,
From: Marc-André Lureau
It's not the way it is usually written (see https://clang.llvm.org/).
Signed-off-by: Marc-André Lureau
Reviewed-by: Damien Hedde
Reviewed-by: Philippe Mathieu-Daudé
---
docs/devel/style.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Apr 20, 2022 at 05:26:00PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> According to our configure checks, this is the list of supported
> compilers.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Damien Hedde
> ---
> docs/about/build-platforms.rst |
Hi
On Wed, Apr 20, 2022 at 6:53 PM Thomas Huth wrote:
>
> On 20/04/2022 16.46, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Apr 20, 2022 at 6:37 PM Thomas Huth wrote:
> >>
> >> On 20/04/2022 16.10, Daniel P. Berrangé wrote:
> >>> On Wed, Apr 20, 2022 at 05:26:00PM +0400,
On Wed, Apr 20, 2022 at 05:25:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The solution was discussed with Markus Armbruster during the review:
>
On Wed, Apr 20, 2022 at 02:12:58PM +0200, Klaus Jensen wrote:
> On Apr 20 08:02, Michael S. Tsirkin wrote:
> > On Fri, Mar 18, 2022 at 08:18:07PM +0100, Lukasz Maniak wrote:
> > > Resubmitting v6 as v7 since Patchew got lost with my sophisticated CC of
> > > all maintainers just for the cover
Reviewed-by: Konstantin Kostiuk
On Wed, Apr 20, 2022 at 5:08 PM wrote:
> From: Marc-André Lureau
>
> Since the introduction of the variable in commit 9dacf32d2cb ("qemu-ga:
> Building Windows MSI installation with configure/Makefile"), nothing
> makes use of the Mingw_dlls variable in the
The file has been removed in commit a8260d3876 ("ui: install logo icons to
$prefix/share/icons", 2019-01-21), do not try to symlink it in the build tree.
Signed-off-by: Paolo Bonzini
---
configure | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure b/configure
index
Signed-off-by: Paolo Bonzini
---
configure | 44 ---
crypto/meson.build| 4 +++-
meson.build | 15 +++-
meson_options.txt | 2 ++
scripts/meson-buildoptions.sh | 3 +++
5 files changed, 22
The correct return type is ReplicationStatus, not
ReplicationResult.
Signed-off-by: Andrea Bolognani
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 27d7b28158..409eb086a2 100644
---
Allow using the buildoptions.json file for more options, namely anything
that is not a boolean or multiple-choice.
The mapping between configure and meson is messy for string options,
so allow configure to use to something other than the name in
meson_options.txt. This will come in handy anyway
Use the new support for string option parsing.
Signed-off-by: Paolo Bonzini
---
configure | 14 --
meson.build | 27 ---
meson_options.txt | 4
scripts/meson-buildoptions.sh | 8
4 files
vhost-vsock and vhost-user-vsock are two devices of their own; it should
be possible to enable/disable them with --without-default-devices, not
--without-default-features. Compute their default value in Kconfig to
obtain the more intuitive behavior.
Signed-off-by: Paolo Bonzini
---
configure
On Wed, Apr 20, 2022 at 05:26:16PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Since commit a2ce7dbd917 ("meson: convert tests/qtest to meson"),
> libqtest.h is under libqos/ directory. Let's move the .c along with it.
It is a bit odd for libqtest.h to be under
Signed-off-by: Paolo Bonzini
---
Kconfig.host| 3 ---
backends/meson.build| 8 ++--
hw/net/meson.build | 8 ++--
hw/virtio/Kconfig | 3 ---
hw/virtio/meson.build | 25 -
meson.build | 1 +
net/meson.build | 12
On Wed, Apr 20, 2022 at 05:26:21PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Simplify the function to only return the directory path. Callers are
> adjusted to use the GLib function to build paths, g_build_filename().
>
> Signed-off-by: Marc-André Lureau
> ---
>
On Wed, Apr 20, 2022 at 05:26:07PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Move them where they belong, since the functions are implemented in
> block-qdict.c.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/block/qdict.h | 3 +++
>
On Wed, Apr 20, 2022 at 7:43 PM Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
>
Reviewed-by: Marc-André Lureau
> ---
> configure | 44 ---
> crypto/meson.build| 4 +++-
> meson.build | 15 +++-
On 4/20/22 03:33, Thomas Huth wrote:
The following changes since commit 1be5a765c08cee3a9587c8a8d3fc2ea247b13f9c:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
(2022-04-19 18:22:16 -0700)
are available in the Git repository at:
On Wed, Apr 20, 2022 at 07:32:38PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Apr 20, 2022 at 7:24 PM Daniel P. Berrangé
> wrote:
> >
> > On Wed, Apr 20, 2022 at 06:50:12PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Wed, Apr 20, 2022 at 6:46 PM Marc-André Lureau
> > > wrote:
On Wed, Apr 20, 2022 at 7:55 PM Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
>
lgtm
Reviewed-by: Marc-André Lureau
> ---
> configure | 115 -
> contrib/rdmacm-mux/meson.build | 4 +-
> meson.build| 56
On Wed, Apr 20, 2022 at 06:03:10PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> docs/about/build-platforms.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-
From: Marc-André Lureau
Since it depends on monitor code, and error_vprintf_unless_qmp() is
already there.
This will help to move error-report in a common subproject.
Signed-off-by: Marc-André Lureau
---
include/monitor/monitor.h | 3 +++
include/qemu/error-report.h | 2 --
1 - 100 of 511 matches
Mail list logo
