Re: [PATCH v2 07/16] ppc/pnv: change PnvPHB4 to be a PnvPHB backend

2022-06-07 Thread Cédric Le Goater
On 6/2/22 10:02, Mark Cave-Ayland wrote: On 31/05/2022 22:49, Daniel Henrique Barboza wrote: Change the parent type of the PnvPHB4 device to TYPE_PARENT since the PCI bus is going to be initialized by the PnvPHB parent. Functions that needs to access the bus via a PnvPHB4 object can do so via

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Cédric Le Goater
On 6/3/22 23:00, Daniel Henrique Barboza wrote: On 6/2/22 13:33, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: To enable user creatable PnvPHB devices for powernv9 we'll revert the powernv9 related changes made in 9c10d86fee "ppc/pnv: Remove user-created

Re: [RFC PATCH v8 01/21] virtio-net: Expose ctrl virtqueue logic

2022-06-07 Thread Jason Wang
在 2022/5/20 03:12, Eugenio Pérez 写道: This allows external vhost-net devices to modify the state of the VirtIO device model once vhost-vdpa device has acknowledge the control commands. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio-net.h | 4 ++ hw/net/virtio-net.c|

Re: [RFC PATCH v8 03/21] vdpa: control virtqueue support on shadow virtqueue

2022-06-07 Thread Jason Wang
在 2022/5/20 03:12, Eugenio Pérez 写道: Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like multiqueue. To demonstrate command handling, VIRTIO_NET_F_CTRL_MACADDR and VIRTIO_NET_CTRL_MQ are implemented. If vDPA device is started

Re: [RFC PATCH v8 02/21] vhost: Add custom used buffer callback

2022-06-07 Thread Jason Wang
在 2022/5/20 03:12, Eugenio Pérez 写道: The callback allows SVQ users to know the VirtQueue requests and responses. QEMU can use this to synchronize virtio device model state, allowing to migrate it with minimum changes to the migration code. In the case of networking, this will be used to

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Frederic Barrat
On 03/06/2022 23:00, Daniel Henrique Barboza wrote:   static void pnv_phb4_realize(DeviceState *dev, Error **errp)   {   PnvPHB4 *phb = PNV_PHB4(dev); +    PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); +    PnvChip *chip = pnv_get_chip(pnv, phb->chip_id);   XiveSource *xsrc

Re: [PATCH 36/71] target/arm: Unexport aarch64_add_*_properties

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:17, Richard Henderson wrote: > > These functions are not used outside cpu64.c, > so make them static. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 3 --- > target/arm/cpu64.c | 4 ++-- > 2 files changed, 2 insertions(+), 5 deletions(-) Reviewed-by:

[PATCH 3/7] configure: allow more host/target combos to use the host compiler

2022-06-07 Thread Paolo Bonzini
Do not require a cross-compiler prefix for e.g. i386 on x86_64, or big endian on little endian. Signed-off-by: Paolo Bonzini --- configure | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/configure b/configure index b1aa97e470..28f8c6188b

Re: [PATCH v5 01/45] block: BlockDriver: add .filtered_child_is_backing field

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Unfortunately not all filters use .file child as filtered child. Two exclusions are mirror_top and commit_top. Happily they both are private filters. Bad thing is that this inconsistency is observable through qmp commands query-block /

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Stafford Horne
On Tue, Jun 07, 2022 at 10:42:08AM +0200, Arnd Bergmann wrote: > On Tue, Jun 7, 2022 at 10:11 AM Geert Uytterhoeven > wrote: > > On Sun, Jun 5, 2022 at 9:32 AM Stafford Horne wrote: > > > On Sun, Jun 05, 2022 at 10:58:14AM +0900, Stafford Horne wrote: > > > It might be a good idea to

[PATCH 7/7] tests/tcg: remove -f from Makefile invocation

2022-06-07 Thread Paolo Bonzini
Name the symbolic link "Makefile" and place it in the target subdirectory. Signed-off-by: Paolo Bonzini --- configure | 3 ++- tests/Makefile.include | 7 +++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 9d49ea4c5b..f35847c3cd

Re: [PATCH 39/71] target/arm: Add SVL to TB flags

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:18, Richard Henderson wrote: > > We need SVL separate from VL for RDSVL at al, as well as "et al" > ZA storage loads and stores, which do not require PSTATE.SM. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 12 >

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Arnd Bergmann
On Tue, Jun 7, 2022 at 11:47 AM Stafford Horne wrote: > On Tue, Jun 07, 2022 at 10:42:08AM +0200, Arnd Bergmann wrote: > > Goldfish is a very old platform, as far as I know only the kernel port is > > new. > > I don't know when qemu started shipping goldfish, but changing it now would > >

Re: [PATCH 11/21] test/avocado/machine_aspeed.py: Add an I2C RTC test

2022-06-07 Thread Cédric Le Goater
On 6/7/22 01:16, Joel Stanley wrote: On Mon, 6 Jun 2022 at 15:08, Cédric Le Goater wrote: Add a RTC device on bus 15 and check that the ouput of the hwclock spelling: output command matches the current year. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley ---

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Geert Uytterhoeven
CC arnd On Sun, Jun 5, 2022 at 9:32 AM Stafford Horne wrote: > On Sun, Jun 05, 2022 at 10:58:14AM +0900, Stafford Horne wrote: > > On Fri, Jun 03, 2022 at 09:05:09AM +0200, Geert Uytterhoeven wrote: > > > On Thu, Jun 2, 2022 at 9:59 PM Stafford Horne wrote: > > > > On Thu, Jun 02, 2022 at

RE: [PATCH v3 0/4] xlnx-zcu102: fix the display port.

2022-06-07 Thread Frederic Konrad
> -Original Message- > From: Peter Maydell > Sent: 06 June 2022 11:20 > To: Frederic Konrad > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > edgar.igles...@gmail.com; alist...@alistair23.me; Sai Pavan Boddu > ; Edgar Iglesias ; > fkon...@amd.com > Subject: Re: [PATCH v3 0/4]

Re: [PATCH 32/71] target/arm: Create ARMVQMap

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:21, Richard Henderson wrote: > > Pull the three sve_vq_* values into a structure. > This will be reused for SME. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 03/16] ppc/pnv: add PnvPHB base/proxy device

2022-06-07 Thread Frederic Barrat
On 07/06/2022 08:42, Cédric Le Goater wrote: On 6/2/22 18:16, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: The PnvPHB device is going to be the base device for all other powernv PHBs. It consists of a device that has the same user API as the other PHB, namely

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Arnd Bergmann
On Tue, Jun 7, 2022 at 10:11 AM Geert Uytterhoeven wrote: > On Sun, Jun 5, 2022 at 9:32 AM Stafford Horne wrote: > > On Sun, Jun 05, 2022 at 10:58:14AM +0900, Stafford Horne wrote: > > It might be a good idea to revisit the qemu implementation and make > > sure that the extra byteswap is

Re: [PATCH 31/71] target/arm: Move error for sve%d property to arm_cpu_sve_finalize

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:10, Richard Henderson wrote: > > Keep all of the error messages together. This does mean that > when setting many sve length properties we'll only generate > one error, but we only really need one. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu64.c | 15

[PATCH 0/3] Cavium Octeon MIPS extensions

2022-06-07 Thread Pavel Dovgalyuk
The following series includes emulation of the platform-specific MIPS extension for Cavium Octeon CPUS: - basic Octeon vCPU model - custom instruction decoder for Octeon - implementation of arithmetic and logic instructions --- Pavel Dovgalyuk (3): target/mips: introduce generic Cavium

[PATCH 4/7] configure: move tests/tcg/Makefile.prereqs to root build directory

2022-06-07 Thread Paolo Bonzini
It will not be specific to tests/tcg anymore once it will be possible to build firmware using container-based cross compilers too. Prepare for that already, after all Makefile.prereqs is not _used_ by tests/tcg. Signed-off-by: Paolo Bonzini --- Makefile | 5 - configure

Re: [PATCH 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-06-07 Thread Igor Mammedov
On Mon, 6 Jun 2022 13:11:36 +0200 Julia Suvorova wrote: > On Thu, Jun 2, 2022 at 4:35 PM Igor Mammedov wrote: > > > > On Thu, 2 Jun 2022 16:31:25 +0200 > > Igor Mammedov wrote: > > > > > On Tue, 31 May 2022 14:40:15 +0200 > > > Julia Suvorova wrote: > > > > > > > On Sat, May 28, 2022 at

Re: [PATCH 1/8] hw/cxl: Make the CXL fixed memory window setup a machine parameter.

2022-06-07 Thread Jonathan Cameron via
On Mon, 6 Jun 2022 10:24:43 -0700 Ben Widawsky wrote: > On 22-05-31 09:26:27, Paolo Bonzini wrote: > > On 5/30/22 15:45, Jonathan Cameron via wrote: > > > +object_property_add(obj, "cxl-fmw", "CXLFixedMemoryWindow", > > > +machine_get_cfmw, machine_set_cfmw, > > > +

[PATCH 2/7] build: include pc-bios/ part in the ROMS variable

2022-06-07 Thread Paolo Bonzini
Include the full path in TARGET_DIR, so that messages from sub-Makefiles are clearer. Also, prepare for possibly building firmware outside pc-bios/ from the Makefile, Signed-off-by: Paolo Bonzini --- Makefile | 12 +--- configure | 6 +++--- 2 files changed, 8 insertions(+), 10

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Jason A. Donenfeld
+ Arnd On Sun, Jun 5, 2022 at 10:19 AM Jason A. Donenfeld wrote: > > Hi folks, > > On Sun, Jun 05, 2022 at 04:32:13PM +0900, Stafford Horne wrote: > > Why can't m68k switch to little-endian in qemu and the kernel? The m68k > > virt > > platform is not that old, 1 year? Are there a lot of users

Re: [PATCH v5 03/45] block/blklogwrites: don't care to remove bs->file child on failure

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We don't need to remove bs->file, generic layer takes care of it. No other driver cares to remove bs->file on failure by hand. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/blklogwrites.c | 4 1 file changed, 4 deletions(-)

Re: [PATCH 0/7] More tests/tcg cleanups

2022-06-07 Thread Paolo Bonzini
On 6/7/22 11:40, Paolo Bonzini wrote: Building on the introduction of config-$target.mak Brain fart, or perhaps selective amnesia: building on the removal of Makefile.qemu. Paolo , make tests/tcg a "regular" subdirectory that is entered simply with "make -C", like the ROMs or the plugins.

Re: [PATCH 41/71] target/arm: Add infrastructure for disas_sme

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:41, Richard Henderson wrote: > > This includes the build rules for the decoder, and the > new file for translation, but excludes any instructions. > > Signed-off-by: Richard Henderson > @@ -14814,7 +14814,12 @@ static void > aarch64_tr_translate_insn(DisasContextBase

Re: [PATCH v2 1/1] Fix the coredump when memory backend id conflicts with default_ram_id

2022-06-07 Thread Li Zhang
Thanks Philippe. Hi Igor, Any comments about this patch? On Wed, Jun 1, 2022 at 2:28 PM Philippe Mathieu-Daudé via wrote: > > Cc'ing Igor > > On Fri, May 20, 2022 at 11:56 AM Li Zhang wrote: > > > > When no memory backend is specified in machine options, > > a default memory device will be

Re: [PATCH 34/71] target/arm: Generalize cpu_arm_{get, set}_default_vec_len

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:10, Richard Henderson wrote: > > Rename from cpu_arm_{get,set}_sve_default_vec_len, > and take the pointer to default_vq from opaque. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu64.c | 27 ++- > 1 file changed, 14 insertions(+), 13

Re: [PATCH 33/71] target/arm: Generalize cpu_arm_{get,set}_vq

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:29, Richard Henderson wrote: > > Rename from cpu_arm_{get,set}_sve_vq, and take the > ARMVQMap as the opaque parameter. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 3/3] target/mips: implement Octeon-specific arithmetic instructions

2022-06-07 Thread Pavel Dovgalyuk
This patch implements several Octeon-specific instructions: - BADDU - DMUL - EXTS/EXTS32 - CINS/CINS32 - POP/DPOP - SEQ/SEQI - SNE/SNEI Signed-off-by: Pavel Dovgalyuk --- target/mips/helper.h|1 target/mips/tcg/meson.build |1 target/mips/tcg/octeon.decode

[PATCH 5/7] configure: store container engine in config-host.mak

2022-06-07 Thread Paolo Bonzini
In preparation for removing $(DOCKER_SCRIPT) from the tests/tcg configuration files, have Make use the same container engine that had been probed at configure time. Signed-off-by: Paolo Bonzini --- configure | 11 --- tests/docker/Makefile.include | 2 +- 2 files

Re: [PATCH 04/21] aspeed: i2c: Use reg array instead of individual vars

2022-06-07 Thread Cédric Le Goater
On 6/7/22 01:49, Joel Stanley wrote: On Mon, 6 Jun 2022 at 15:08, Cédric Le Goater wrote: From: Joe Komlodi Using a register array will allow us to represent old-mode and new-mode I2C registers by using the same underlying register array, instead of adding an entire new set of variables to

Re: [PATCH 37/71] target/arm: Add cpu properties for SME

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:33, Richard Henderson wrote: > > Mirror the properties for SVE. The main difference is > that any arbitrary set of powers of 2 may be supported, > and not the stricter constraints that apply to SVE. > > Include a property to control FEAT_SME_FA64, as failing > to

Re: [PATCH] Hexagon (target/hexagon) remove unused encodings

2022-06-07 Thread Philippe Mathieu-Daudé via
On 7/6/22 00:23, Taylor Simpson wrote: Remove encodings guarded by ifdef that is not defined Signed-off-by: Taylor Simpson --- target/hexagon/imported/encode_pp.def | 23 --- 1 file changed, 23 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 40/71] target/arm: Move pred_{full, gvec}_reg_{offset, size} to translate-a64.h

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:21, Richard Henderson wrote: > > We will need these functions in translate-sme.c. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] avocado/boot_linux_console.py: Update ast2600 test

2022-06-07 Thread Philippe Mathieu-Daudé via
On 7/6/22 03:19, Joel Stanley wrote: Update the test_arm_ast2600_debian test to - the latest Debian kernel - use the Rainier machine instead of Tacoma Why can't we keep both? Both of which contains support for more hardware and thus exercises more of the hardware Qemu models. "QEMU"

Re: [PATCH v2 03/16] ppc/pnv: add PnvPHB base/proxy device

2022-06-07 Thread Cédric Le Goater
On 6/2/22 18:16, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: The PnvPHB device is going to be the base device for all other powernv PHBs. It consists of a device that has the same user API as the other PHB, namely being a PCIHostBridge and having chip-id and

Re: [PATCH v2 11/16] ppc/pnv: add pnv-phb-root-port device

2022-06-07 Thread Cédric Le Goater
On 6/2/22 09:06, Mark Cave-Ayland wrote: On 01/06/2022 09:04, Daniel Henrique Barboza wrote: On 6/1/22 02:56, Cédric Le Goater wrote: On 5/31/22 23:49, Daniel Henrique Barboza wrote: We have two very similar root-port devices, pnv-phb3-root-port and pnv-phb4-root-port. Both consist of a

Re: Help: How do I make a machine with 2 separate ARM SoC's?

2022-06-07 Thread Cédric Le Goater
On 6/6/22 19:02, Peter Maydell wrote: On Mon, 6 Jun 2022 at 16:37, Cédric Le Goater wrote: On the CPU topic, I think we will need to change the GIC device to stop using qemu_get_cpu() in the CPU interface init routine and in the GIC realize routine, since this is global to the machine. I am

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Cédric Le Goater
Also, the comment seems wrong to me. The qom parenting doesn't matter when building the device tree. it does. See pnv_dt_xscom() And this is the root cause of many headaches for user-created devices. Could it be done differently ? Thanks, C.

Re: [PATCH] avocado/boot_linux_console.py: Update ast2600 test

2022-06-07 Thread Cédric Le Goater
On 6/7/22 03:19, Joel Stanley wrote: Update the test_arm_ast2600_debian test to - the latest Debian kernel - use the Rainier machine instead of Tacoma Both of which contains support for more hardware and thus exercises more of the hardware Qemu models. Signed-off-by: Joel Stanley

Re: [PATCH v3 10/49] semihosting: Clean up common_semi_flen_cb

2022-06-07 Thread Alex Bennée
Richard Henderson writes: > Do not read from the gdb struct stat buffer if the callback is > reporting an error. Use common_semi_cb to finish returning results. > > Signed-off-by: Richard Henderson > --- > semihosting/arm-compat-semi.c | 20 +++- > 1 file changed, 11

[PATCH 2/3] target/mips: implement Octeon-specific BBIT instructions

2022-06-07 Thread Pavel Dovgalyuk
This patch introduces Octeon-specific decoder and implements check-bit-and-jump instructions. Signed-off-by: Pavel Dovgalyuk --- target/mips/tcg/meson.build|2 + target/mips/tcg/octeon.decode | 14 ++ target/mips/tcg/octeon_translate.c | 53

[PATCH 0/7] More tests/tcg cleanups

2022-06-07 Thread Paolo Bonzini
Building on the introduction of config-$target.mak, make tests/tcg a "regular" subdirectory that is entered simply with "make -C", like the ROMs or the plugins. The next step could be to unify all the sub-make rules; this series stops short of that. Paolo Paolo Bonzini (7): meson: put cross

[PATCH 6/7] tests: simplify Makefile invocation for tests/tcg

2022-06-07 Thread Paolo Bonzini
The tests/tcg Makefile invocation contains the paths to DOCKER_SCRIPT and TARGET. One can just resolve the path to docker.py in configure so that submakes do not need the DOCKER_SCRIPT variable. In order to remove the TARGET variable, create a config-target.mak file in tests/tcg/$TARGET. For

Re: [PATCH] hw/cxl: Fix missing write mask for HDM decoder target list registers

2022-06-07 Thread Jonathan Cameron via
On Mon, 6 Jun 2022 10:39:52 -0700 Ben Widawsky wrote: > On 22-05-31 13:39:53, Jonathan Cameron wrote: > > Without being able to write these registers, no interleaving is possible. > > More refined checks of HDM register state on commit to follow. > > > > Signed-off-by: Jonathan Cameron > > ---

[PATCH] configure: update list of preserved environment variables

2022-06-07 Thread Paolo Bonzini
INSTALL and LIBTOOL are not used anymore, but OBJCFLAGS is new and was not listed. Signed-off-by: Paolo Bonzini --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f35847c3cd..ce81419629 100755 --- a/configure +++ b/configure @@

Re: [PATCH v6 0/8] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-06-07 Thread Chao Peng
On Mon, Jun 06, 2022 at 01:09:50PM -0700, Vishal Annapurve wrote: > > > > Private memory map/unmap and conversion > > --- > > Userspace's map/unmap operations are done by fallocate() ioctl on the > > backing store fd. > > - map: default fallocate() with

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Frederic Barrat
On 07/06/2022 08:35, Cédric Le Goater wrote: Also, the comment seems wrong to me. The qom parenting doesn't matter when building the device tree. it does. See pnv_dt_xscom() Yeah, what I meant is that on P9, there's no "dt_scom" method for the PHB. The PHBs are added by the dt_scom()

[PATCH 1/7] meson: put cross compiler info in a separate section

2022-06-07 Thread Paolo Bonzini
While at it, remove a dead assignment and simply inline the value of the "target" variable, which is used just once. Signed-off-by: Paolo Bonzini --- meson.build | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index

Re: [PATCH] Hexagon (target/hexagon) make VyV operands use a unique temp

2022-06-07 Thread Philippe Mathieu-Daudé via
On 7/6/22 00:23, Taylor Simpson wrote: VyV operand is only used in the vshuff and vdeal instructions. These instructions write to both VyV and VxV operands. In the case where both operands are the same register, we need a separate location for VyV. We use the existing vtmp field in

Re: [PATCH 35/71] target/arm: Move arm_cpu_*_finalize to internals.h

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:12, Richard Henderson wrote: > > Drop the aa32-only inline fallbacks, > and just use a couple of ifdefs. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 1/3] target/mips: introduce generic Cavium Octeon CPU model

2022-06-07 Thread Pavel Dovgalyuk
This patch adds generic Octeon vCPU for providing Octeon-specific instructions. Signed-off-by: Pavel Dovgalyuk --- target/mips/cpu-defs.c.inc | 30 ++ target/mips/mips-defs.h|1 + 2 files changed, 31 insertions(+) diff --git a/target/mips/cpu-defs.c.inc

Re: [PATCH 38/71] target/arm: Introduce sve_vqm1_for_el_sm

2022-06-07 Thread Peter Maydell
On Thu, 2 Jun 2022 at 23:28, Richard Henderson wrote: > > When Streaming SVE mode is enabled, the size is taken from > SMCR_ELx instead of ZCR_ELx. The format is shared, but the > set of vector lengths is not. Further, Streaming SVE does > not require any particular length to be supported. > >

Re: [PATCH 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-06-07 Thread Igor Mammedov
On Mon, 6 Jun 2022 12:52:00 +0200 Julia Suvorova wrote: > On Thu, Jun 2, 2022 at 5:04 PM Igor Mammedov wrote: > > > > On Fri, 27 May 2022 18:56:48 +0200 > > Julia Suvorova wrote: > > > > > Introduce the 64-bit entry point. Since we no longer have a total > > > number of structures, stop

Re: [PATCH v5 02/45] block: introduce bdrv_open_file_child() helper

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Almost all drivers call bdrv_open_child() similarly. Let's create a helper for this. The only not updated driver that call bdrv_open_child() to set bs->file is raw-format, as it sometimes want to have filtered child but don't set

Re: [PATCH 4/5] bios-tables-test: add test for number of cores > 255

2022-06-07 Thread Igor Mammedov
On Mon, 6 Jun 2022 13:38:57 +0200 Julia Suvorova wrote: > On Thu, Jun 2, 2022 at 5:20 PM Igor Mammedov wrote: > > > > On Fri, 27 May 2022 18:56:50 +0200 > > Julia Suvorova wrote: > > > > > The new test is run with a large number of cpus and checks if the > > > core_count field in

Re: [PATCH 13/21] aspeed: Add I2C buses to AST1030 model

2022-06-07 Thread Cédric Le Goater
On 6/7/22 01:18, Joel Stanley wrote: On Mon, 6 Jun 2022 at 15:09, Cédric Le Goater wrote: From: Troy Lee Instantiate the I2C buses in AST1030 model and create two slave device for ast1030-evb. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee [ clg : - adapted

Re: [PATCH v5 06/45] test-bdrv-graph-mod: fix filters to be filters

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: bdrv_pass_through is used as filter, even all node variables has corresponding names. We want to append it, so it should be backing-child-based filter like mirror_top. So, in test_update_perm_tree, first child should be DATA, as we don't

Re: [PATCH v3] hw/nvme: clean up CC register write logic

2022-06-07 Thread Lukasz Maniak
On Tue, Jun 07, 2022 at 01:23:20PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > The SRIOV series exposed an issued with how CC register writes are > handled and how CSTS is set in response to that. Specifically, after > applying the SRIOV series, the controller could end up in a state

Re: [PATCH v6 15/18] job: detect change of aiocontext within job coroutine

2022-06-07 Thread Emanuele Giuseppe Esposito
Am 03/06/2022 um 18:59 schrieb Kevin Wolf: > Am 14.03.2022 um 14:37 hat Emanuele Giuseppe Esposito geschrieben: >> From: Paolo Bonzini >> >> We want to make sure access of job->aio_context is always done >> under either BQL or job_mutex. The problem is that using >>

Re: [PATCH v6 02/18] job.h: categorize fields in struct Job

2022-06-07 Thread Emanuele Giuseppe Esposito
Am 03/06/2022 um 18:00 schrieb Kevin Wolf: > Am 14.03.2022 um 14:36 hat Emanuele Giuseppe Esposito geschrieben: >> Categorize the fields in struct Job to understand which ones >> need to be protected by the job mutex and which don't. >> >> Signed-off-by: Emanuele Giuseppe Esposito > > I

Re: [PATCH 37/71] target/arm: Add cpu properties for SME

2022-06-07 Thread Richard Henderson
On 6/7/22 02:47, Peter Maydell wrote: +void arm_cpu_sme_finalize(ARMCPU *cpu, Error **errp) +{ +uint32_t vq_map = cpu->sme_vq.map; +uint32_t vq_init = cpu->sme_vq.init; +uint32_t vq_supported = cpu->sme_vq.supported; +uint32_t vq; + +if (vq_map == 0) { +if

Re: [PATCH v5 09/45] Revert "block: Let replace_child_noperm free children"

2022-06-07 Thread Vladimir Sementsov-Ogievskiy
On 6/7/22 17:03, Hanna Reitz wrote: On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We are going to reimplement this behavior (clear bs->file / bs->backing pointers automatically when child->bs is cleared) in a nicer way. This reverts commit b0a9f6fed3d80de610dcd04a7e66f9f30a04174f.

Re: [PATCH v5 04/45] test-bdrv-graph-mod: update test_parallel_perm_update test case

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: test_parallel_perm_update() does two things that we are going to restrict in the near future: 1. It updates bs->file field by hand. bs->file will be managed automatically by generic code (together with bs->children list). Let's

Re: [RFC PATCH v4 11/36] i386/tdx: Initialize TDX before creating TD vcpus

2022-06-07 Thread Gerd Hoffmann
Hi, > > I guess it could be helpful for the discussion when you can outine the > > 'big picture' for tdx initialization. How does kvm accel setup look > > like without TDX, and what additional actions are needed for TDX? What > > ordering requirements and other constrains exist? > > To boot

Re: [PATCH v3 14/49] include/exec: Move gdb open flags to gdbstub.h

2022-06-07 Thread Alex Bennée
Richard Henderson writes: > There were 3 copies of these flags. Place them in the > file with gdb_do_syscall, with which they belong. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 16/35] acpi: ipmi: use AcpiDevAmlIf interface to build IPMI device descriptors

2022-06-07 Thread Michael S. Tsirkin
On Mon, May 16, 2022 at 11:25:51AM -0400, Igor Mammedov wrote: > convert ad-hoc way we use to generate AML for ISA/SMB IPMI devices > to a generic approach (i.e. make devices provide its own AML blobs > like it is done with other ISA devices (ex. KBD)) > > Signed-off-by: Igor Mammedov could not

Re: [PATCH v2] hw/nvme: allow to pass a memory backend object for the CMB

2022-06-07 Thread Wertenbroek Rick
Hi, So it seems the patch is messed up, I forked QEMU applied the patch to the current master. Here it is : https://gitlab.com/rwe-reds/qemu/-/tree/master I rebuilt QEMU to check that everything builds and runs. Sorry for the inconvenience, I don’t know why the patch gets corrupted… Best

[PATCH v3] hw/nvme: clean up CC register write logic

2022-06-07 Thread Klaus Jensen
From: Klaus Jensen The SRIOV series exposed an issued with how CC register writes are handled and how CSTS is set in response to that. Specifically, after applying the SRIOV series, the controller could end up in a state with CC.EN set to '1' but with CSTS.RDY cleared to '0', causing drivers to

Re: ioregionfd with io_uring IORING_OP_URING_CMD

2022-06-07 Thread Elena
On Mon, Jun 06, 2022 at 03:57:47PM +0100, Stefan Hajnoczi wrote: > Hi, > During Elena Afanasova's Outreachy project we discussed whether > ioregionfd should be a custom struct file_operations (anon inode) or a > userspace-provided file (socketpair, UNIX domain socket, etc). > Hello Stefan, >

Re: [PATCH 41/71] target/arm: Add infrastructure for disas_sme

2022-06-07 Thread Richard Henderson
On 6/7/22 03:03, Peter Maydell wrote: On Thu, 2 Jun 2022 at 23:41, Richard Henderson wrote: This includes the build rules for the decoder, and the new file for translation, but excludes any instructions. Signed-off-by: Richard Henderson @@ -14814,7 +14814,12 @@ static void

Re: [PATCH v2] hw/nvme: allow to pass a memory backend object for the CMB

2022-06-07 Thread Wertenbroek Rick
Hello, Sorry about that, I had the same issue with the patch for some reason, I think it is the git send email that messed up the patch (couldn’t directly send via smtp so I created a draft via IMAP before sending). Anyway, below is the patch, it was created on the master branch (commit

Re: [PATCH v5 05/45] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We do add COW child to the node. In future we are going to forbid adding COW child to the node that doesn't support backing. So, fix it here now. Don't worry about setting bs->backing itself: it further commit we'll s/it/in/ update the

Re: [PATCH v2] hw/nvme: clean up CC register write logic

2022-06-07 Thread Łukasz Gieryk
On Fri, Jun 03, 2022 at 10:24:51PM +0200, Klaus Jensen wrote: > On Jun 1 15:28, Lukasz Maniak wrote: > > On Wed, May 25, 2022 at 09:35:24AM +0200, Klaus Jensen wrote: > > > > > > +stl_le_p(>bar.intms, 0); > > > +stl_le_p(>bar.intmc, 0); > > > +stl_le_p(>bar.cc, 0); > > >

Re: [PATCH v6 06/18] jobs: protect jobs with job_lock/unlock

2022-06-07 Thread Emanuele Giuseppe Esposito
Am 03/06/2022 um 18:40 schrieb Kevin Wolf: > Am 14.03.2022 um 14:36 hat Emanuele Giuseppe Esposito geschrieben: >> Introduce the job locking mechanism through the whole job API, >> following the comments in job.h and requirements of job-monitor >> (like the functions in job-qmp.c, assume lock

Re: [PATCH] tcg: Special case split barriers before/after load

2022-06-07 Thread Redha
Hi Richard and Philippe, I was finally able to test the patch. As expected, the fences generated by TCG with your patch are the same ones as in mine. However, I was not able to reproduce the failure with the ahci-test on my ARM system (2x 28-core Thunder X2, 4 threads per core). I ran 500

Re: [PATCH v3 15/49] include/exec: Move gdb_stat and gdb_timeval to gdbstub.h

2022-06-07 Thread Alex Bennée
Richard Henderson writes: > We have two copies of these structures, and require them > in semihosting/ going forward. > > Signed-off-by: Richard Henderson > --- > include/exec/gdbstub.h| 25 + > target/m68k/m68k-semi.c | 30 +++--- >

[PATCH] configure: ignore --make

2022-06-07 Thread Paolo Bonzini
Setting the MAKE variable to a GNU Make executable does not really have any effect: if a non-GNU Make is used, the QEMU Makefile will fail to parse. Just remove everything related to --make and $make as dead code. Signed-off-by: Paolo Bonzini --- configure | 16 +--- 1 file

Re: [PATCH v2 0/8] hw/cxl: Move CXL emulation options and state to machines.

2022-06-07 Thread Jonathan Cameron via
On Mon, 6 Jun 2022 10:33:38 -0700 Ben Widawsky wrote: > On 22-06-01 17:42:27, Jonathan Cameron wrote: > > Changes since v1 (thanks to Paolo Bonzini) > > * Update 'description' of cxl-fmw as suggested to mention it's an array. > > * Add a wrapper cxl_hook_up_pxb_registers() to cxl-host.c as it'll

[PATCH v2] hw/cxl: Fix missing write mask for HDM decoder target list registers

2022-06-07 Thread Jonathan Cameron via
Without being able to write these registers, no interleaving is possible. More refined checks of HDM register state on commit to follow. Signed-off-by: Jonathan Cameron --- v2: (Ben Widawsky) - Correctly set a tighter write mask for the endpoint devices where this register has a different use.

Re: [PATCH v2] hw/cxl: Fix missing write mask for HDM decoder target list registers

2022-06-07 Thread Jonathan Cameron via
On Tue, 7 Jun 2022 11:56:17 +0100 Jonathan Cameron wrote: > Without being able to write these registers, no interleaving is possible. > More refined checks of HDM register state on commit to follow. > > Signed-off-by: Jonathan Cameron +Cc Ben on current address. Which reminds me - Ben, when

Re: [PATCH v3 11/49] semihosting: Clean up common_semi_open_cb

2022-06-07 Thread Alex Bennée
Richard Henderson writes: > Use common_semi_cb to return results instead of calling > set_swi_errno and common_semi_set_ret directly. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v6 05/18] job.h: add _locked duplicates for job API functions called with and without job_mutex

2022-06-07 Thread Emanuele Giuseppe Esposito
Am 03/06/2022 um 18:17 schrieb Kevin Wolf: > Am 14.03.2022 um 14:36 hat Emanuele Giuseppe Esposito geschrieben: >> In preparation to the job_lock/unlock usage, create _locked >> duplicates of some functions, since they will be sometimes called with >> job_mutex held (mostly within job.c), >>

Re: [PATCH v2 03/16] ppc/pnv: add PnvPHB base/proxy device

2022-06-07 Thread Daniel Henrique Barboza
On 6/7/22 05:44, Frederic Barrat wrote: On 07/06/2022 08:42, Cédric Le Goater wrote: On 6/2/22 18:16, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: The PnvPHB device is going to be the base device for all other powernv PHBs. It consists of a device that has

Re: [PATCH v5 08/45] block/snapshot: stress that we fallback to primary child

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Actually what we chose is a primary child. Let's stress it in the code. We are going to drop indirect pointer logic here in future. Actually this commit simplifies the future work: we drop use of indirection in the assertion now.

Re: ioregionfd with io_uring IORING_OP_URING_CMD

2022-06-07 Thread Stefan Hajnoczi
On Tue, 7 Jun 2022 at 14:32, Elena wrote: > On Mon, Jun 06, 2022 at 03:57:47PM +0100, Stefan Hajnoczi wrote: > > The downside is it requires more code than general purpose I/O. In > > addition to ->uring_cmd(), it's also worth implementing struct > > file_operations read/write/poll so traditional

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Arnd Bergmann
On Tue, Jun 7, 2022 at 2:12 PM Stafford Horne wrote: > On Tue, Jun 07, 2022 at 11:43:08AM +0100, Peter Maydell wrote: > > However, in a followup mail from Laurent we see: > > https://lore.kernel.org/lkml/cb884368-0226-e913-80d2-62d2b7b2e...@vivier.eu/ > > The reference document[1] doesn't

Re: [PATCH v5 09/45] Revert "block: Let replace_child_noperm free children"

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: We are going to reimplement this behavior (clear bs->file / bs->backing pointers automatically when child->bs is cleared) in a nicer way. This reverts commit b0a9f6fed3d80de610dcd04a7e66f9f30a04174f. This doesn’t really explain why it’s

Re: [PATCH 39/71] target/arm: Add SVL to TB flags

2022-06-07 Thread Richard Henderson
On 6/7/22 02:58, Peter Maydell wrote: @@ -3292,6 +3292,7 @@ FIELD(TBFLAG_A64, MTE0_ACTIVE, 19, 1) FIELD(TBFLAG_A64, SMEEXC_EL, 20, 2) FIELD(TBFLAG_A64, PSTATE_SM, 22, 1) FIELD(TBFLAG_A64, PSTATE_ZA, 23, 1) +FIELD(TBFLAG_A64, SVL, 24, 4) Given that both SVE and SME start with an 'S',

Re: [PATCH 04/21] aspeed: i2c: Use reg array instead of individual vars

2022-06-07 Thread Cédric Le Goater
On 6/7/22 01:49, Joel Stanley wrote: On Mon, 6 Jun 2022 at 15:08, Cédric Le Goater wrote: From: Joe Komlodi Using a register array will allow us to represent old-mode and new-mode I2C registers by using the same underlying register array, instead of adding an entire new set of variables to

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Peter Maydell
On Tue, 7 Jun 2022 at 11:12, Stafford Horne wrote: > > On Tue, Jun 07, 2022 at 10:42:08AM +0200, Arnd Bergmann wrote: > > Goldfish is a very old platform, as far as I know only the kernel port is > > new. > > I don't know when qemu started shipping goldfish, but changing it now would > > surely

Re: [PATCH v2] hw/nvme: clean up CC register write logic

2022-06-07 Thread Klaus Jensen
On Jun 7 13:06, Łukasz Gieryk wrote: > On Fri, Jun 03, 2022 at 10:24:51PM +0200, Klaus Jensen wrote: > > On Jun 1 15:28, Lukasz Maniak wrote: > > > On Wed, May 25, 2022 at 09:35:24AM +0200, Klaus Jensen wrote: > > > > > > > > +stl_le_p(>bar.intms, 0); > > > > +

Re: [PATCH v5 07/45] block: document connection between child roles and bs->backing/bs->file

2022-06-07 Thread Hanna Reitz
On 30.03.22 23:28, Vladimir Sementsov-Ogievskiy wrote: Make the informal rules formal. In further commit we'll add corresponding assertions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-common.h | 42 1 file changed, 42

Re: [RFC PATCH 3/3] hw/openrisc: Add the OpenRISC virtual machine

2022-06-07 Thread Stafford Horne
On Tue, Jun 07, 2022 at 11:43:08AM +0100, Peter Maydell wrote: > So I don't have a strong view on whether these devices should > be DEVICE_NATIVE_ENDIAN or DEVICE_LITTLE_ENDIAN (except that > my impression is that a DEVICE_LITTLE_ENDIAN device on a > big-endian system is a bit weird, because it

Re: [PATCH 1/3] target/mips: introduce generic Cavium Octeon CPU model

2022-06-07 Thread Richard Henderson
On 6/7/22 01:59, Pavel Dovgalyuk wrote: +{ +/* + * A generic CPU providing MIPS64 Cavium Octeon features. + * PRid is taken from Octeon 68xx CPUs + * FIXME: Eventually this should be replaced by a real CPU model. + */ You should just add the real cpu

Re: [PATCH] MAINTAINERS: change Ben Widawsky's email address

2022-06-07 Thread Jonathan Cameron via
On Tue, 7 Jun 2022 09:26:28 -0700 Ben Widawsky wrote: > ben@widaw...@intel.com will stop working on 2022-06-20, change it to my > personal email address. > > Update .mailmap to handle previously authored commits. > > Signed-off-by: Ben Widawsky With below question addressed, Acked-by:

  1   2   3   4   >