Re: [PATCH v4 0/2] vhost-vdpa: add support for vIOMMU

2022-10-29 Thread Cindy Lu
On Sat, 29 Oct 2022 at 15:57, Michael S. Tsirkin wrote: > > On Thu, Oct 27, 2022 at 03:40:30PM +0800, Cindy Lu wrote: > > These patches are to support vIOMMU in vdpa device > > > > changes in V3 > > 1. Move function vfio_get_xlat_addr to memory.c > > 2. Use the existing memory listener, while the

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

2022-10-29 Thread Michael S. Tsirkin
On Fri, Oct 28, 2022 at 06:02:47PM +0200, Eugenio Pérez wrote: > Some fixes that did not get in time for the last net pull request. Reviewed-by: Michael S. Tsirkin Jason's tree since he has some bits this depends on. > Eugenio Pérez (4): > vhost: Delete useless casting > vhost: convert

Re: [PATCH] block/blkio: Add virtio-blk-vfio-pci BlockDriver

2022-10-29 Thread Alberto Faria
On Fri, Oct 28, 2022 at 2:17 PM Alberto Faria wrote: > libblkio 1.1.0 [1] introduces a virtio-blk-vfio-pci driver, which > accesses a virtio-blk PCI device using VFIO. Add a corresponding > BlockDriver. > > [1] https://gitlab.com/libblkio/libblkio/-/tree/v1.1.0 > > Signed-off-by: Alberto Faria

[PATCH v18 06/10] virtio: add support for configure interrupt

2022-10-29 Thread Cindy Lu
Add the functions to support the configure interrupt in virtio The function virtio_config_guest_notifier_read will notify the guest if there is an configure interrupt. The function virtio_config_set_guest_notifier_fd_handler is to set the fd hander for the notifier Signed-off-by: Cindy Lu ---

[PATCH v18 01/10] virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX

2022-10-29 Thread Cindy Lu
To support configure interrupt for vhost-vdpa Introduce VIRTIO_CONFIG_IRQ_IDX -1 as configure interrupt's queue index, Then we can reuse the functions guest_notifier_mask and guest_notifier_pending. Add the check of queue index in these drivers, if the driver does not support configure interrupt,

[PATCH v18 07/10] vhost: add support for configure interrupt

2022-10-29 Thread Cindy Lu
Add functions to support configure interrupt. The configure interrupt process will start in vhost_dev_start and stop in vhost_dev_stop. Also add the functions to support vhost_config_pending and vhost_config_mask. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 78

[PATCH v18 08/10] virtio-net: add support for configure interrupt

2022-10-29 Thread Cindy Lu
Add functions to support configure interrupt in virtio_net Add the functions to support vhost_net_config_pending and vhost_net_config_mask. Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 9 + hw/net/virtio-net.c | 4 ++-- include/net/vhost_net.h | 2 ++ 3 files changed, 13

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-10-29 Thread Bernhard Beschow
Am 27. Oktober 2022 21:40:01 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Bernhard, > >On 18/10/22 23:01, Bernhard Beschow wrote: >> Will allow e500 boards to access SD cards using just their own devices. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/sd/sdhci.c | 120

Re: [PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-10-29 Thread Bin Meng
Hi Thomas, On Sat, Sep 24, 2022 at 5:20 PM Bin Meng wrote: > > Hi Thomas, > > On Sat, Sep 10, 2022 at 8:32 AM Bin Meng wrote: > > > > On Sat, Sep 10, 2022 at 12:32 AM Thomas Huth wrote: > > > > > > On 08/09/2022 15.28, Bin Meng wrote: > > > > From: Bin Meng > > > > > > > > At present the

Re: [PATCH v2 3/3] vhost_vdpa: move VIRTIO_NET_F_STATUS handling to vhost_net

2022-10-29 Thread Michael S. Tsirkin
On Fri, Oct 28, 2022 at 05:19:17PM +0200, Eugenio Pérez wrote: > Since it is emulated on all vhost backends it makes sense to move it. > > Although this feature can be emulated by qemu it benefits from > information from the device. Ack it as long as the guest ack it. > > Signed-off-by: Eugenio

Re: [PATCH v2 1/2] vhost-user: Refactor vhost acked features saving

2022-10-29 Thread Michael S. Tsirkin
On Sat, Oct 29, 2022 at 01:25:44AM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > Abstract vhost acked features saving into > vhost_user_save_acked_features, export it as util function. > Thanks for the patch! This commit log makes it sound like it's just a refactoring

[PATCH v18 03/10] virtio-pci: decouple the single vector from the interrupt process

2022-10-29 Thread Cindy Lu
To reuse the interrupt process in configure interrupt Need to decouple the single vector from the interrupt process. We add new function kvm_virtio_pci_vector_use_one and _release_one. These functions are used for the single vector, the whole process will finish in the loop with vq number.

[PATCH v18 09/10] virtio-mmio: add support for configure interrupt

2022-10-29 Thread Cindy Lu
Add configure interrupt support in virtio-mmio bus. add function to set configure guest notifier. Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[PATCH v18 05/10] vhost-vdpa: add support for config interrupt

2022-10-29 Thread Cindy Lu
Add new call back function in vhost-vdpa, The function vhost_set_config_call can set the event fd to kernel. This function will be called in the vhost_dev_start and vhost_dev_stop Signed-off-by: Cindy Lu --- hw/virtio/trace-events | 1 + hw/virtio/vhost-vdpa.c | 8 2 files changed, 9

[PATCH v18 10/10] virtio-pci: add support for configure interrupt

2022-10-29 Thread Cindy Lu
Add process to handle the configure interrupt, The function's logic is the same with vq interrupt.Add extra process to check the configure interrupt Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 110 - include/hw/virtio/virtio-pci.h | 4 +- 2

[PATCH v18 04/10] vhost: introduce new VhostOps vhost_set_config_call

2022-10-29 Thread Cindy Lu
This patch introduces new VhostOps vhost_set_config_call. This function allows the qemu to set the config event fd to kernel driver. Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h

Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

2022-10-29 Thread Stefan Weil via
Am 15.09.22 um 10:41 schrieb Richard Henderson: On 9/14/22 16:59, Alex Bennée wrote: We want to migrate from docker.py to building our images directly with docker/podman. Before we get there we need to make sure we don't re-introduce our layered builds so bug out if we see FROM qemu/ in a

Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"

2022-10-29 Thread Alberto Faria
On Sat, Oct 29, 2022 at 7:05 AM Markus Armbruster wrote: > Alberto Faria writes: > > > The nvme-io_uring driver expects a character special file such as > > /dev/ng0n1. Follow the convention of having a "filename" option when a > > regular file is expected, and a "path" option otherwise. > > I

Re: [PATCH v4 5/7] hw/ppc/e500: Implement pflash handling

2022-10-29 Thread Bernhard Beschow
Am 29. Oktober 2022 09:29:33 UTC schrieb Daniel Henrique Barboza : > > >On 10/28/22 19:42, Philippe Mathieu-Daudé wrote: >> On 28/10/22 17:09, Daniel Henrique Barboza wrote: >>> Bernhard, >>> >>> The 32 builds aren't fancying this patch. The issue is down there: >>> >>> On 10/18/22 18:01,

Re: [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps

2022-10-29 Thread Alex Bennée
Richard Henderson writes: > Add a tcg_ops hook to replace the restore_state_to_opc > function call. Because these generic hooks cannot depend > on target-specific types, temporarily, copy the current > target_ulong data[] into uint64_t d64[]. > > Reviewed-by: Claudio Fontana > Signed-off-by:

Re: [PATCH v4 19/19] mac_newworld: Document deprecation

2022-10-29 Thread Mark Cave-Ayland
On 28/10/2022 13:20, BALATON Zoltan wrote: On Fri, 28 Oct 2022, Mark Cave-Ayland wrote: On 25/10/2022 17:44, BALATON Zoltan wrote: Also update PowerMac family docs with some more recent info. Signed-off-by: BALATON Zoltan ---   docs/about/deprecated.rst    |  7 +++  

Re: [PATCH v2 3/3] hw/i386/acpi-build: Resolve north rather than south bridges

2022-10-29 Thread Michael S. Tsirkin
On Fri, Oct 28, 2022 at 10:18:43PM +0530, Ani Sinha wrote: > On Fri, Oct 28, 2022 at 9:45 PM B wrote: > > > > > > > > Am 28. Oktober 2022 10:58:07 UTC schrieb Ani Sinha : > > >On Fri, Oct 28, 2022 at 4:05 PM Bernhard Beschow wrote: > > >> > > >> The code currently assumes Q35 iff ICH9 and i440fx

Re: [PATCH v6 14/19] mac_newworld: Turn CORE99_VIA_CONFIG defines into an enum

2022-10-29 Thread Mark Cave-Ayland
On 28/10/2022 12:56, BALATON Zoltan wrote: This might allow the compiler to check values. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_newworld.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index

Re: [PATCH v6 13/19] mac_{old|new}world: Code style fix adding missing braces to if-s

2022-10-29 Thread Mark Cave-Ayland
On 28/10/2022 12:56, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/ppc/mac_newworld.c | 6 -- hw/ppc/mac_oldworld.c | 9 ++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index 6b2d781dea..37123daa6b

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

2022-10-29 Thread Stefan Weil via
Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a GLIB_BINDIR variable which is the directory where glib and other DLLs reside. This works for both

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-10-29 Thread Bernhard Beschow
Am 29. Oktober 2022 11:33:51 UTC schrieb Bernhard Beschow : >Am 27. Oktober 2022 21:40:01 UTC schrieb "Philippe Mathieu-Daudé" >: >>Hi Bernhard, >> >>On 18/10/22 23:01, Bernhard Beschow wrote: >>> Will allow e500 boards to access SD cards using just their own devices. >>> >>> Signed-off-by:

Re: [PATCH v4 16/19] mac_newworld: Add machine types for different mac99 configs

2022-10-29 Thread Mark Cave-Ayland
On 28/10/2022 13:18, BALATON Zoltan wrote: On Fri, 28 Oct 2022, Mark Cave-Ayland wrote: On 25/10/2022 17:44, BALATON Zoltan wrote: The mac99 machine emulates different machines depending on machine properties or even if it is run as qemu-system-ppc64 or qemu-system-ppc. This is very confusing

Re: [PATCH v4 0/2] vhost-vdpa: add support for vIOMMU

2022-10-29 Thread Michael S. Tsirkin
On Thu, Oct 27, 2022 at 03:40:30PM +0800, Cindy Lu wrote: > These patches are to support vIOMMU in vdpa device > > changes in V3 > 1. Move function vfio_get_xlat_addr to memory.c > 2. Use the existing memory listener, while the MR is > iommu MR then call the function iommu_region_add/ >

Re: [PATCH v5 20/20] mac_{old, new}world: Pass MacOS VGA NDRV in card ROM instead of fw_cfg

2022-10-29 Thread Mark Cave-Ayland
On 28/10/2022 13:32, BALATON Zoltan wrote: On Fri, 28 Oct 2022, Mark Cave-Ayland wrote: On 25/10/2022 22:31, BALATON Zoltan wrote: OpenBIOS cannot run FCode ROMs yet but it can detect NDRV in VGA card ROM and add it to the device tree for MacOS. Pass the NDRV this way instead of via fw_cfg.

[PATCH v18 02/10] virtio-pci: decouple notifier from interrupt process

2022-10-29 Thread Cindy Lu
To reuse the notifier process. We add the virtio_pci_get_notifier to get the notifier and vector. The INPUT for this function is IDX, The OUTPUT is the notifier and the vector Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 88 +++--- 1 file changed, 57

[PATCH v18 00/10] vhost-vdpa: add support for configure interrupt

2022-10-29 Thread Cindy Lu
These patches introduced the support for configure interrupt These codes are tested on x86_64 and aarch64 platforms. the test scenario is based on vp-vdpa/vdpa_sim /virtio net device, with the irqfd and without irqfd. Tested in virtio-pci bus and virtio-mmio bus Change in v2: Add support

Re: [PATCH v18 00/10] vhost-vdpa: add support for configure interrupt

2022-10-29 Thread Michael S. Tsirkin
On Sat, Oct 29, 2022 at 04:27:45PM +0800, Cindy Lu wrote: > These patches introduced the support for configure interrupt > > These codes are tested on x86_64 and aarch64 platforms. > the test scenario is based on vp-vdpa/vdpa_sim /virtio net device, with > the irqfd and without irqfd. Given

Re: [PATCH v10 0/4] cutils: Introduce bundle mechanism

2022-10-29 Thread Stefan Weil via
Am 27.06.22 um 05:57 schrieb Akihiko Odaki: Developers often run QEMU without installing. The bundle mechanism allows to look up files which should be present in installation even in such a situation. It is a general mechanism and can find any files located relative to the installation tree.

Re: [PATCH v6 0/7] hw/arm/virt: Improve address assignment for high memory regions

2022-10-29 Thread Marc Zyngier
On Wed, 26 Oct 2022 01:29:56 +0100, Gavin Shan wrote: > > Hi Peter and Marc, > > On 10/24/22 11:54 AM, Gavin Shan wrote: > > There are three high memory regions, which are VIRT_HIGH_REDIST2, > > VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses > > are floating on highest RAM

Re: [PATCH v5 20/20] mac_{old, new}world: Pass MacOS VGA NDRV in card ROM instead of fw_cfg

2022-10-29 Thread BALATON Zoltan
On Sat, 29 Oct 2022, Mark Cave-Ayland wrote: On 28/10/2022 13:32, BALATON Zoltan wrote: On Fri, 28 Oct 2022, Mark Cave-Ayland wrote: On 25/10/2022 22:31, BALATON Zoltan wrote: OpenBIOS cannot run FCode ROMs yet but it can detect NDRV in VGA card ROM and add it to the device tree for MacOS.

Re: [PATCH 0/7] nsis: gitlab-ci: Improve QEMU Windows installer packaging

2022-10-29 Thread Bin Meng
Hi Thomas, On Wed, Sep 21, 2022 at 8:24 PM Thomas Huth wrote: > > On 21/09/2022 14.18, Bin Meng wrote: > > Hi, > > > > On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote: > >> > >> At present packaging the required DLLs of QEMU executables is a > >> manual process, and error prone. > >> > >> Improve

Re: [PATCH 1/7] scripts/nsis.py: Drop the unnecessary path separator

2022-10-29 Thread Stefan Weil via
Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng There is no need to append a path separator to the destination directory that is passed to "make install". Signed-off-by: Bin Meng --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py

Re: [PATCH 2/7] scripts/nsis.py: Fix destination directory name when invoked on Windows

2022-10-29 Thread Stefan Weil via
Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng "make installer" on Windows fails with the following message: Traceback (most recent call last): File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 89, in main() File

Re: [PATCH v4 5/7] hw/ppc/e500: Implement pflash handling

2022-10-29 Thread Daniel Henrique Barboza
On 10/28/22 19:42, Philippe Mathieu-Daudé wrote: On 28/10/22 17:09, Daniel Henrique Barboza wrote: Bernhard, The 32 builds aren't fancying this patch. The issue is down there: On 10/18/22 18:01, Bernhard Beschow wrote: Allows e500 boards to have their root file system reside on flash

Re: [PATCH v4 16/19] mac_newworld: Add machine types for different mac99 configs

2022-10-29 Thread BALATON Zoltan
On Sat, 29 Oct 2022, Mark Cave-Ayland wrote: On 28/10/2022 13:18, BALATON Zoltan wrote: On Fri, 28 Oct 2022, Mark Cave-Ayland wrote: On 25/10/2022 17:44, BALATON Zoltan wrote: The mac99 machine emulates different machines depending on machine properties or even if it is run as

Re: [PATCH v2 3/4] tests: acpi: aarch64: add topology test for aarch64

2022-10-29 Thread Michael S. Tsirkin
On Thu, Oct 27, 2022 at 11:26:12AM +0800, Yicong Yang wrote: > From: Yicong Yang > > Add test for aarch64's ACPI topology building for all the supported > levels. > > Signed-off-by: Yicong Yang And same comment here. Pls follow the process in bios-tables-test > --- >

Re: [PATCH v2 2/4] tests: virt: update expected ACPI tables for virt test

2022-10-29 Thread Michael S. Tsirkin
On Thu, Oct 27, 2022 at 11:26:11AM +0800, Yicong Yang wrote: > From: Yicong Yang > > Update the ACPI tables according to the acpi aml_build change. > > Signed-off-by: Yicong Yang OK nice but if patch 1 is applied alone that will break make check won't it? And this means the patchset breaks

[PULL v2 63/63] target/ppc: Fix regression in Radix MMU

2022-10-29 Thread Daniel Henrique Barboza
From: Leandro Lupori Commit 47e83d9107 ended up unintentionally changing the control flow of ppc_radix64_process_scoped_xlate(). When guest_visible is false, it must not raise an exception, even if the radix configuration is not valid. This regression prevented Linux boot in a nested

[PULL v2 00/63] ppc queue

2022-10-29 Thread Daniel Henrique Barboza
(2022-10-26 10:53:49 -0400) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20221029 for you to fetch changes up to fb22d743b93b49b73930aff40d3ba9d252f81a56: target/ppc: Fix regression in Radix MMU (2022-10-29 06:34:52 -0300

[PULL v2 62/63] hw/ppc/e500: Implement pflash handling

2022-10-29 Thread Daniel Henrique Barboza
From: Bernhard Beschow Allows e500 boards to have their root file system reside on flash using only builtin devices located in the eLBC memory region. Note that the flash memory area is only created when a -pflash argument is given, and that the size is determined by the given file. The idea is

[PATCH] block/blkio: Tolerate device size changes

2022-10-29 Thread Alberto Faria
Some libblkio drivers may be able to work with regular files (e.g., io_uring) or otherwise resizable devices. Conservatively set BlockDriver::has_variable_length to true to ensure bdrv_nb_sectors() always gives up-to-date results. Also implement BlockDriver::bdrv_co_truncate for the case where no

Re: [PATCH v6 0/7] hw/arm/virt: Improve address assignment for high memory regions

2022-10-29 Thread Gavin Shan
Hi Peter, On 10/29/22 2:06 AM, Peter Maydell wrote: On Wed, 26 Oct 2022 at 01:30, Gavin Shan wrote: On 10/24/22 11:54 AM, Gavin Shan wrote: There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on

Re: [PATCH] block/blkio: Make driver nvme-io_uring take a "path" instead of a "filename"

2022-10-29 Thread Markus Armbruster
Alberto Faria writes: > The nvme-io_uring driver expects a character special file such as > /dev/ng0n1. Follow the convention of having a "filename" option when a > regular file is expected, and a "path" option otherwise. I suspect this is by accident, not by design. Is it desirable? > This

[PATCH v7 7/7] hw/arm/virt: Add properties to disable high memory regions

2022-10-29 Thread Gavin Shan
The 3 high memory regions are usually enabled by default, but they may be not used. For example, VIRT_HIGH_GIC_REDIST2 isn't needed by GICv2. This leads to waste in the PA space. Add properties ("highmem-redists", "highmem-ecam", "highmem-mmio") to allow users selectively disable them if needed.

[PATCH v7 5/7] hw/arm/virt: Improve high memory region address assignment

2022-10-29 Thread Gavin Shan
There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on highest RAM address. However, they can be disabled in several cases. (1) One specific high memory region is likely to be disabled by code by

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-10-29 Thread Philippe Mathieu-Daudé
On 29/10/22 20:28, Bernhard Beschow wrote: Am 29. Oktober 2022 13:04:00 UTC schrieb Bernhard Beschow : Am 29. Oktober 2022 11:33:51 UTC schrieb Bernhard Beschow : Am 27. Oktober 2022 21:40:01 UTC schrieb "Philippe Mathieu-Daudé" : Hi Bernhard, On 18/10/22 23:01, Bernhard Beschow wrote:

Re: [PATCH 1/3] target/mips: Set CP0St_{KX, SX, UX} for Loongson-2F

2022-10-29 Thread Philippe Mathieu-Daudé
On 29/10/22 21:50, Jiaxun Yang wrote: 2022年10月29日 18:44,Philippe Mathieu-Daudé 写道: On 29/10/22 04:00, Jiaxun Yang wrote: As per "Loongson-2F processor user manual", CP0St_{KX, SX, UX} should is not writeable and hardcoded to 1. Without those bits set, kernel is unable to access XKPHYS

Re: [PATCH 2/3] vl: on -loadvm set run state to "restore-vm"

2022-10-29 Thread Joelle van Dyne
On Mon, Aug 22, 2022 at 3:11 AM Daniel P. Berrangé wrote: > > On Fri, Aug 12, 2022 at 06:10:30PM -0700, Joelle van Dyne wrote: > > This allows us to differentiate between a fresh boot and a restore boot. > > > > Signed-off-by: Joelle van Dyne > > --- > > softmmu/runstate.c | 1 + > >

[PATCH v5 0/2] vhost-vdpa: add support for vIOMMU

2022-10-29 Thread Cindy Lu
These patches are to support vIOMMU in vdpa device changes in V3 1. Move function vfio_get_xlat_addr to memory.c 2. Use the existing memory listener, while the MR is iommu MR then call the function iommu_region_add/ iommu_region_del changes in V4 1.make the comments in vfio_get_xlat_addr more

[PATCH v5 1/2] vfio: move function vfio_get_xlat_addr() to memory.c

2022-10-29 Thread Cindy Lu
- Move the function vfio_get_xlat_addr to softmmu/memory.c, and   change the name to memory_get_xlat_addr(). So we can use this   function on other devices, such as vDPA device. - Add a new bool arg in this function, which shows whether the memory is   backed by a discard manager. So the device

[PATCH v5 2/2] vhost-vdpa: add support for vIOMMU

2022-10-29 Thread Cindy Lu
Add support for vIOMMU. add the new function to deal with iommu MR. - during iommu_region_add register a specific IOMMU notifier, and store all notifiers in a list. - during iommu_region_del, compare and delete the IOMMU notifier from the list Verified in vp_vdpa and vdpa_sim_net driver

Re: [PATCH v5 1/2] vfio: move function vfio_get_xlat_addr() to memory.c

2022-10-29 Thread Alex Williamson
On Sun, 30 Oct 2022 12:35:54 +0800 Cindy Lu wrote: > - Move the function vfio_get_xlat_addr to softmmu/memory.c, and >   change the name to memory_get_xlat_addr(). So we can use this >   function on other devices, such as vDPA device. > - Add a new bool arg in this function, which shows whether

Re: [PATCH v2 1/2] vhost-user: Refactor vhost acked features saving

2022-10-29 Thread Hyman Huang
在 2022/10/29 16:28, Michael S. Tsirkin 写道: On Sat, Oct 29, 2022 at 01:25:44AM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Abstract vhost acked features saving into vhost_user_save_acked_features, export it as util function. Thanks for the patch! This commit log makes

Re: [PATCH v6 0/7] hw/arm/virt: Improve address assignment for high memory regions

2022-10-29 Thread Gavin Shan
Hi Marc, On 10/29/22 7:29 PM, Marc Zyngier wrote: On Wed, 26 Oct 2022 01:29:56 +0100, Gavin Shan wrote: On 10/24/22 11:54 AM, Gavin Shan wrote: There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on

Re: [PATCH 7/7] .gitlab-ci.d/windows.yml: Test 'make installer' in the CI

2022-10-29 Thread Bin Meng
On Sun, Oct 30, 2022 at 12:39 AM Stefan Weil wrote: > > Am 08.09.22 um 15:28 schrieb Bin Meng: > > From: Bin Meng > > > > Now that we have supported packaging DLLs automatically, let's add > > the 'make installer' in the CI and publish the generated installer > > file as an artifact. > > > >

[PATCH v7 0/7] hw/arm/virt: Improve address assignment for high memory regions

2022-10-29 Thread Gavin Shan
There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on highest RAM address. However, they can be disabled in several cases. (1) One specific high memory region is disabled by developer by toggling

[PATCH v7 6/7] hw/arm/virt: Add 'compact-highmem' property

2022-10-29 Thread Gavin Shan
After the improvement to high memory region address assignment is applied, the memory layout can be changed, introducing possible migration breakage. For example, VIRT_HIGH_PCIE_MMIO memory region is disabled or enabled when the optimization is applied or not, with the following configuration. The

[PATCH v7 3/7] hw/arm/virt: Introduce variable region_base in virt_set_high_memmap()

2022-10-29 Thread Gavin Shan
This introduces variable 'region_base' for the base address of the specific high memory region. It's the preparatory work to optimize high memory region address assignment. No functional change intended. Signed-off-by: Gavin Shan Reviewed-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by:

[PATCH v7 1/7] hw/arm/virt: Introduce virt_set_high_memmap() helper

2022-10-29 Thread Gavin Shan
This introduces virt_set_high_memmap() helper. The logic of high memory region address assignment is moved to the helper. The intention is to make the subsequent optimization for high memory region address assignment easier. No functional change intended. Signed-off-by: Gavin Shan Reviewed-by:

[PATCH v7 2/7] hw/arm/virt: Rename variable size to region_size in virt_set_high_memmap()

2022-10-29 Thread Gavin Shan
This renames variable 'size' to 'region_size' in virt_set_high_memmap(). Its counterpart ('region_base') will be introduced in next patch. No functional change intended. Signed-off-by: Gavin Shan Reviewed-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by: Marc Zyngier Tested-by: Zhenyu

[PATCH v7 4/7] hw/arm/virt: Introduce virt_get_high_memmap_enabled() helper

2022-10-29 Thread Gavin Shan
This introduces virt_get_high_memmap_enabled() helper, which returns the pointer to vms->highmem_{redists, ecam, mmio}. The pointer will be used in the subsequent patches. No functional change intended. Signed-off-by: Gavin Shan Reviewed-by: Eric Auger Reviewed-by: Cornelia Huck Reviewed-by:

Re: [PATCH 1/3] target/mips: Set CP0St_{KX, SX, UX} for Loongson-2F

2022-10-29 Thread Jiaxun Yang
> 2022年10月30日 00:19,Philippe Mathieu-Daudé 写道: > > On 29/10/22 21:50, Jiaxun Yang wrote: >>> 2022年10月29日 18:44,Philippe Mathieu-Daudé 写道: >>> >>> On 29/10/22 04:00, Jiaxun Yang wrote: As per "Loongson-2F processor user manual", CP0St_{KX, SX, UX} should is not writeable and

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-29 Thread Elliot Nunn
Akihiko, Thanks very much for reviewing my patch. I think that you were right to use the sprite-within-a-window approach, and avoid warping the OS cursor. I tried to compensate for the error that cursor warping causes in the subsequent mouse event, but there is still some error getting through

Re: [PATCH v5 1/2] vfio: move function vfio_get_xlat_addr() to memory.c

2022-10-29 Thread Cindy Lu
On Sun, 30 Oct 2022 at 13:14, Alex Williamson wrote: > > On Sun, 30 Oct 2022 12:35:54 +0800 > Cindy Lu wrote: > > > - Move the function vfio_get_xlat_addr to softmmu/memory.c, and > > change the name to memory_get_xlat_addr(). So we can use this > > function on other devices, such as vDPA

Re: [PATCH 6/7] .gitlab-ci.d/windows.yml: Unify the prerequisite packages

2022-10-29 Thread Stefan Weil via
Am 29.10.22 um 15:06 schrieb Bin Meng: Hi Thomas, On Sat, Sep 24, 2022 at 5:20 PM Bin Meng wrote: Hi Thomas, On Sat, Sep 10, 2022 at 8:32 AM Bin Meng wrote: On Sat, Sep 10, 2022 at 12:32 AM Thomas Huth wrote: On 08/09/2022 15.28, Bin Meng wrote: From: Bin Meng At present the

Re: [PATCH 1/3] target/mips: Set CP0St_{KX, SX, UX} for Loongson-2F

2022-10-29 Thread Jiaxun Yang
> 2022年10月29日 18:44,Philippe Mathieu-Daudé 写道: > > On 29/10/22 04:00, Jiaxun Yang wrote: >> As per "Loongson-2F processor user manual", CP0St_{KX, SX, UX} >> should is not writeable and hardcoded to 1. >> Without those bits set, kernel is unable to access XKPHYS address >> segmant. So just

Re: [PATCH 5/7] block/nfs: Fix 32-bit Windows build

2022-10-29 Thread Stefan Weil via
Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng libnfs.h declares nfs_fstat() as the following for win32: int nfs_fstat(struct nfs_context *nfs, struct nfsfh *nfsfh, struct __stat64 *st); The 'st' parameter should be of type 'struct __stat64'. The codes happen to

Re: [PATCH 7/7] .gitlab-ci.d/windows.yml: Test 'make installer' in the CI

2022-10-29 Thread Stefan Weil via
Am 08.09.22 um 15:28 schrieb Bin Meng: From: Bin Meng Now that we have supported packaging DLLs automatically, let's add the 'make installer' in the CI and publish the generated installer file as an artifact. Increase the job timeout to 90 minutes to accommodate to it. Signed-off-by: Bin

Re: [PATCH v4 6/7] hw/sd/sdhci: Implement Freescale eSDHC device model

2022-10-29 Thread Bernhard Beschow
Am 29. Oktober 2022 13:04:00 UTC schrieb Bernhard Beschow : >Am 29. Oktober 2022 11:33:51 UTC schrieb Bernhard Beschow : >>Am 27. Oktober 2022 21:40:01 UTC schrieb "Philippe Mathieu-Daudé" >>: >>>Hi Bernhard, >>> >>>On 18/10/22 23:01, Bernhard Beschow wrote: Will allow e500 boards to access

How to get Started with Contributions

2022-10-29 Thread 1DS20CS093 Joseph Raj Vishal
Respected Sir/Madam I am Joseph Raj Vishal, a Computer Science undergrad. I have just entered third year at Dayananda Sagar College of Engineering in Bengaluru. I am new to open source contributions but I am well aware of Python, Java, Django, PHP, SQL, Javascript,Kotlin and Android. I would love

Re: [PULL 5/7] io/command: use glib GSpawn, instead of open-coding fork/exec

2022-10-29 Thread Stefan Weil via
Am 12.10.22 um 18:04 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau Simplify qio_channel_command_new_spawn() with GSpawn API. This will allow to build for WIN32 in the following patches. As pointed out by Daniel Berrangé: there is a change in semantics here too. The current

Re: [PATCH v10 0/4] cutils: Introduce bundle mechanism

2022-10-29 Thread Paolo Bonzini
Il sab 29 ott 2022, 10:52 Stefan Weil ha scritto: when I run `wine qemu-system-i386 --version` on Debian GNU Linux stable in the build directory of a cross build which targets Windows, I now get an error: Z:\home\stefan\qemu\bin\ndebug\x86_64-w64-mingw32\qemu-system-i386.exe: --version: Could

Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

2022-10-29 Thread Paolo Bonzini
Il sab 29 ott 2022, 11:38 Stefan Weil ha scritto: > Am 15.09.22 um 10:41 schrieb Richard Henderson: > > On 9/14/22 16:59, Alex Bennée wrote: > >> We want to migrate from docker.py to building our images directly with > >> docker/podman. Before we get there we need to make sure we don't > >>

[PATCH] Fix some typos in documentation and comments

2022-10-29 Thread Stefan Weil via
Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- My focus was fixing typos which are relevant for the generated documentation. codespell finds many more typos in source code, and adding it to the continuous integration checks looks more and more like a good

Re: [PATCH 0/3] libvhost-user: Add format attribute and fix format strings

2022-10-29 Thread Philippe Mathieu-Daudé
On 29/10/22 06:52, Stefan Weil via wrote: Am 22.04.22 um 09:01 schrieb Stefan Weil: At least the 1st two patches could also be applied via qemu-trivial. One of them missed release 7.0, so hopefully the fixes will be included in the next QEMU release. Stefan W. [PATCH 1/3] libvhost-user: Fix

Re: [PATCH v2 29/30] tests/docker: remove FROM qemu/ support from docker.py

2022-10-29 Thread Stefan Weil via
Am 29.10.22 um 21:46 schrieb Paolo Bonzini: Il sab 29 ott 2022, 11:38 Stefan Weil ha scritto: Am 15.09.22 um 10:41 schrieb Richard Henderson: > On 9/14/22 16:59, Alex Bennée wrote: >> We want to migrate from docker.py to building our images directly with >> docker/podman.

Re: [PATCH 2/3] target/mips: Cast offset field of Octeon BBIT to int16_t

2022-10-29 Thread Philippe Mathieu-Daudé
On 29/10/22 04:00, Jiaxun Yang wrote: As per "Cavium Networks OCTEON Plus CN50XX Hardware Reference Manual" offset field is signed 16 bit value. However arg_BBIT.offset is unsigned. We need to cast it as signed to do address calculation. Signed-off-by: Jiaxun Yang ---

Re: [PATCH 1/3] target/mips: Set CP0St_{KX, SX, UX} for Loongson-2F

2022-10-29 Thread Philippe Mathieu-Daudé
On 29/10/22 04:00, Jiaxun Yang wrote: As per "Loongson-2F processor user manual", CP0St_{KX, SX, UX} should is not writeable and hardcoded to 1. Without those bits set, kernel is unable to access XKPHYS address segmant. So just set them up on CPU reset. Signed-off-by: Jiaxun Yang ---