Re: [PATCH 1/2] tests/tcg/i386: Introduce and use reg_t consistently

2023-01-16 Thread Philippe Mathieu-Daudé
On 15/1/23 00:05, Richard Henderson wrote: Define reg_t based on the actual register width. Define the inlines using that type. This will allow input registers to 32-bit insns to be set to 64-bit values on x86-64, which allows testing various edge cases. Signed-off-by: Richard Henderson ---

regarding qapi and qapi-rs

2023-01-16 Thread Yu Zhang
Hi all, I noticed that with each qemu release, the qapi (C version) may introduce some changes, and the qapi-rs (Rust version) also changes correspondingly. However, recently there is no qapi-rs release yet for qemu-7.2. I'd like to know, is the release of the qapi-rs synchronized with the

Re: [PATCH v7 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Avihai Horon
On 16/01/2023 12:55, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai, On 1/15/23 19:35, Avihai Horon wrote: Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-16 Thread Bernhard Beschow
Am 16. Januar 2023 13:02:23 UTC schrieb Markus Armbruster : >Bernhard Beschow writes: > >> Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster >> : >>>Bernhard Beschow writes: >>> When removing the "hw/boards.h" include from hw/acpi/acpi_dev_interface.h, these include

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Peter Maydell
On Fri, 13 Jan 2023 at 22:05, Richard Henderson wrote: > > On 1/13/23 06:04, Fabiano Rosas wrote: > > The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the > > cortex-a57 as default cpu for KVM. > > > > Signed-off-by: Fabiano Rosas > > Ideally there would not be a default at all,

Re: [PATCH 7/7] hw/isa/isa-bus: Remove now unused isa_build_aml()

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 23:27, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- include/hw/isa/isa.h | 1 - hw/isa/isa-bus.c | 10 -- 2 files changed, 11 deletions(-) Possibly squash with previous patch, regardless: Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC v2 02/13] vdpa net: move iova tree creation from init to start

2023-01-16 Thread Eugenio Perez Martin
On Mon, Jan 16, 2023 at 4:05 AM Jason Wang wrote: > > > 在 2023/1/13 15:28, Eugenio Perez Martin 写道: > > On Fri, Jan 13, 2023 at 4:53 AM Jason Wang wrote: > >> On Fri, Jan 13, 2023 at 1:24 AM Eugenio Pérez wrote: > >>> Only create iova_tree if and when it is needed. > >>> > >>> The cleanup keeps

Re: [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 23:27, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/i386/acpi-microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Possibly squash with next patch, regardless: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 55f114ef729f..1f9799d4321e

Re: [PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) -static void at24c_eeprom_init(I2CBus *bus, uint8_t addr, uint32_t rsize) -{ -I2CSlave *i2c_dev = i2c_slave_new("at24c-eeprom",

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c929c61d582a..4ac8ff11a835 100644 --- a/hw/arm/aspeed.c

Re: [PATCH v14 03/11] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-01-16 Thread Nina Schoetterl-Glausch
On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > --- > include/hw/s390x/cpu-topology.h | 3 + > include/hw/s390x/sclp.h

Re: [PATCH 08/11] audio/audio_template: use g_new0() to replace audio_calloc()

2023-01-16 Thread Daniel P . Berrangé
On Sun, Dec 18, 2022 at 06:15:36PM +0100, Volker Rümelin wrote: > Replace audio_calloc() with the equivalent g_new0(). > > With a n_structs argument >= 1, g_new0() never returns NULL. > Also remove the unnecessary NULL checks. > > Signed-off-by: Volker Rümelin > --- > audio/audio_template.h |

Re: [PATCH] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4

2023-01-16 Thread Thomas Huth
On 16/01/2023 09.30, Thomas Huth wrote: The old Haiku VM based on Beta 3 does not work anymore since it fails to install the additional packages now that Beta 4 has been released. Thanks to Alexander von Gluck IV for providing a new image based on Beta 4, we can now upgrade the test image in our

Re: [PATCH v7 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Philippe Mathieu-Daudé
On 13/1/23 18:18, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is using 64 bit to encode the 32 bit addresses from the

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2023 at 2:08 PM Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > I'm not sure how but this is re-breaking the windows build you just fixed: > > In file included from >

Re: [for-8.0 v2 03/11] cryptodev: Introduce cryptodev alg type in QAPI

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:48PM +0800, zhenwei pi wrote: > Introduce cryptodev alg type in cryptodev.json, then apply this to > related codes, and drop 'enum CryptoDevBackendAlgType'. > > There are two options: > 1, { 'enum': 'QCryptodevBackendAlgType', > 'prefix': 'CRYPTODEV_BACKEND_ALG', >

Re: [PATCH 4/4] tests/tcg/multiarch: add vma-pthread.c

2023-01-16 Thread Philippe Mathieu-Daudé
On 13/1/23 18:10, Alex Bennée wrote: Peter Maydell writes: On Sat, 24 Dec 2022 at 15:19, Richard Henderson wrote: From: Ilya Leoshkevich Add a test that locklessly changes and exercises page protection bits from various threads. This helps catch race conditions in the VMA handling.

Re: [PATCH v2 00/14] block: Move more functions to coroutines

2023-01-16 Thread Emanuele Giuseppe Esposito
Am 13/01/2023 um 21:41 schrieb Kevin Wolf: > This series converts some IO_CODE() functions to coroutine_fn because > they access the graph and will need to hold the graph lock in the > future. IO_CODE() functions can be called from iothreads, so taking the > graph lock requires the function to

[PULL 0/4] M68k next patches

2023-01-16 Thread Laurent Vivier
tags/m68k-next-pull-request for you to fetch changes up to 1a282f60a971aa86e3cdd1b7ca000790e43bb310: target/m68k: fix FPSR quotient byte for frem instruction (2023-01-16 09:47:31 +0100) M68K pull request 20230116 fix FPSR quotient

[PULL 1/4] target/m68k: pass quotient directly into make_quotient()

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20230114232959.118224-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 20 +++- 1 file changed, 11

[PULL 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id:

[PULL 3/4] target/m68k: fix FPSR quotient byte for fmod instruction

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland The FPSR quotient byte should be set to the value of the quotient and not the result. Switch from using floatx80_mod() to floatx80_modrem() which returns the quotient as a uint64_t which can be used for the quotient byte. Signed-off-by: Mark Cave-Ayland Reviewed-by:

[PULL 4/4] target/m68k: fix FPSR quotient byte for frem instruction

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland The FPSR quotient byte should be set to the value of the quotient and not the result. Manually calculate the quotient in the frem helper in round to nearest even mode (note this is different from the quotient calculated internally for fmod), and use it to set the quotient

Re: [PATCH v3 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)

2023-01-16 Thread David Hildenbrand
On 13.01.23 16:27, Peter Xu wrote: On Fri, Jan 13, 2023 at 10:20:31AM -0500, Peter Xu wrote: On Fri, Jan 13, 2023 at 02:47:24PM +0100, David Hildenbrand wrote: I'd prefer to not go down that path for now. QEMU_VM_SECTION_START without QEMU_VM_SECTION_PART and QEMU_VM_SECTION_END feels pretty

Re: [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Please add some short commit log explaining how the helper could be useful. Reviewed-by: Cédric Le Goater Thanks, C. --- hw/nvram/eeprom_at24c.c | 10 ++ include/hw/nvram/eeprom_at24c.h | 10

Re: [PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/npcm7xx_boards.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c

Re: [PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/hw/arm/aspeed.c

Re: [for-8.0 v2 07/11] cryptodev-builtin: Detect akcipher capability

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:52PM +0800, zhenwei pi wrote: > Rather than exposing akcipher service/RSA algorithm to virtio crypto > device unconditionally, detect akcipher capability from akcipher > crypto framework. This avoids unsuccessful requests. > > Signed-off-by: zhenwei pi > --- >

Re: [PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/npcm7xx_boards.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

2023-01-16 Thread Kirill A. Shutemov
On Sat, Jan 14, 2023 at 12:37:59AM +, Sean Christopherson wrote: > On Fri, Dec 02, 2022, Chao Peng wrote: > > This patch series implements KVM guest private memory for confidential > > computing scenarios like Intel TDX[1]. If a TDX host accesses > > TDX-protected guest memory, machine check

Re: [RFC PATCH v3 21/28] tests/qtest: Skip tests that depend on TCG when CONFIG_TCG=n

2023-01-16 Thread Fabiano Rosas
Richard Henderson writes: > On 1/13/23 06:04, Fabiano Rosas wrote: >> @@ -373,6 +387,11 @@ static void sve_tests_sve_off(const void *data) >> { >> QTestState *qts; >> >> +if (tcg_disabled()) { >> +g_test_skip("TCG support is disabled in this build"); >> +return; >>

Re: [PATCH v2] hw/net/lan9118: log [read|write]b when mode_16bit is enabled rather than abort

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 04:14, Qiang Liu wrote: This patch replaces hw_error to guest error log for [read|write]b accesses when mode_16bit is enabled. This avoids aborting qemu. Fixes: 1248f8d4cbc3 ("hw/lan9118: Add basic 16-bit mode support.") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1433

Re: [PATCH v2 01/21] hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width'

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 07:40, Markus Armbruster wrote: Peter Maydell writes: On Mon, 9 Jan 2023 at 14:19, Philippe Mathieu-Daudé wrote: On 9/1/23 14:33, BALATON Zoltan wrote: On Mon, 9 Jan 2023, Philippe Mathieu-Daudé wrote: Use the same property name than the TYPE_PFLASH_CFI01 model. Nothing uses

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-16 Thread Bernhard Beschow
Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster : >Bernhard Beschow writes: > >> When removing the "hw/boards.h" include from >> hw/acpi/acpi_dev_interface.h, these include directives must be added to make >> the code compile again. >> >> Signed-off-by: Bernhard Beschow > >You don't

Re: [PATCH 5/7] hw/acpi/acpi_aml_interface: Extract qbus_build_aml()

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 23:27, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- include/hw/acpi/acpi_aml_interface.h | 11 +++ hw/i2c/smbus_ich9.c | 5 + hw/isa/lpc_ich9.c| 5 + hw/isa/piix3.c | 5 + 4 files

Re: [RFC v2 04/13] vdpa: rewind at get_base, not set_base

2023-01-16 Thread Eugenio Perez Martin
On Mon, Jan 16, 2023 at 4:32 AM Jason Wang wrote: > > > 在 2023/1/13 15:40, Eugenio Perez Martin 写道: > > On Fri, Jan 13, 2023 at 5:10 AM Jason Wang wrote: > >> On Fri, Jan 13, 2023 at 1:24 AM Eugenio Pérez wrote: > >>> At this moment it is only possible to migrate to a vdpa device running > >>>

Re: Re: [for-8.0 v2 00/11] Refactor cryptodev

2023-01-16 Thread zhenwei pi
On 12/20/22 23:36, Michael S. Tsirkin wrote: On Tue, Nov 22, 2022 at 10:07:45PM +0800, zhenwei pi wrote: v1 -> v2: - fix coding style and use 'g_strjoin()' instead of 'char services[128]' (suggested by Dr. David Alan Gilbert) - wrapper function 'cryptodev_backend_account' to record

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 13:29, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is using 64 bit to encode the 32 bit addresses from the

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Daniel Henrique Barboza
On 1/16/23 09:37, Philippe Mathieu-Daudé wrote: On 16/1/23 13:29, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is

[PATCH v2 4/8] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"

2023-01-16 Thread Bernhard Beschow
hw/acpi/piix4 has its own header with its structure definition etc. Signed-off-by: Bernhard Beschow --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 4d0d4fdeeb..2e19a55526 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -20,7

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Fabiano Rosas
Richard Henderson writes: > On 1/13/23 06:04, Fabiano Rosas wrote: >> The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the >> cortex-a57 as default cpu for KVM. >> >> Signed-off-by: Fabiano Rosas > > Ideally there would not be a default at all, requiring the command-line >

Re: Call qemu_socketpair() instead of socketpair() when possible

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 05:56, Guoyi Tu wrote: As qemu_socketpair() was introduced in commit 3c63b4e9 ("oslib-posix: Introduce qemu_socketpair()"), it's time to replace the other existing socketpair() calls with qemu_socketpair() if possible Signed-off-by: Guoyi Tu ---  backends/tpm/tpm_emulator.c

Re: [PATCH v5] tests/qtest: netdev: test stream and dgram backends

2023-01-16 Thread Thomas Huth
On 16/01/2023 09.29, Laurent Vivier wrote: ping On 1/5/23 10:37, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v5:    - disable test_stream_fd and  test_dgram_fd on windows as socketpair() is not defined.    - enable

Re: [PATCH] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 09:30, Thomas Huth wrote: The old Haiku VM based on Beta 3 does not work anymore since it fails to install the additional packages now that Beta 4 has been released. Thanks to Alexander von Gluck IV for providing a new image based on Beta 4, we can now upgrade the test image in our

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau I'm not sure how but this is re-breaking the windows build you just fixed: In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/egl.h:46, from

Re: [for-8.0 v2 06/11] cryptodev: Support statistics

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:51PM +0800, zhenwei pi wrote: > Introduce cryptodev statistics in QAPI, and record OPS/Bandwidth for > each crypto device. > > Example of this feature: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { >

Re: [RFC PATCH 4/5] hw/xen: [FIXME] Avoid deadlock in xen_evtchn_set_gsi()

2023-01-16 Thread David Woodhouse
FWIW, with this support in QEMU I've just found and fixed two guest kernel regressions in MSI-X handling under Xen. And having done that, I can get back to frowning at the locking on the qemu side... On Sat, 2023-01-14 at 00:39 +, David Woodhouse wrote: > From: David Woodhouse > >

Re: Re: [for-8.0 v2 00/11] Refactor cryptodev

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 05:53:07PM +0800, zhenwei pi wrote: > On 12/20/22 23:36, Michael S. Tsirkin wrote: > > On Tue, Nov 22, 2022 at 10:07:45PM +0800, zhenwei pi wrote: > > > v1 -> v2: > > > - fix coding style and use 'g_strjoin()' instead of 'char services[128]' > > >(suggested by Dr. David

[PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Daniel Henrique Barboza
Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is using 64 bit to encode the 32 bit addresses from the guest, and load_elf_ram_sym() is sign-extending the

[PATCH v8 1/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

2023-01-16 Thread Daniel Henrique Barboza
The microchip_icicle_kit, sifive_u, spike and virt boards are now doing the same steps when '-kernel' is used: - execute load_kernel() - load init_rd() - write kernel_cmdline Let's fold everything inside riscv_load_kernel() to avoid code repetition. To not change the behavior of boards that

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c929c61d582a..4ac8ff11a835 100644 --- a/hw/arm/aspeed.c

[PATCH v8 0/3] hw/riscv: clear kernel_entry high bits with 32bit CPUs

2023-01-16 Thread Daniel Henrique Barboza
Hi, This version has changes in patch 3 where we're now using extract64() instead of a plain bit mask to return the 32 bit address in translate_fn(). Changes from v7: - patch 2: - added Alistair's r-b - patch 3: - use extract64() to return the 32 bit address v7 link:

[PATCH v8 2/3] hw/riscv/boot.c: make riscv_load_initrd() static

2023-01-16 Thread Daniel Henrique Barboza
The only remaining caller is riscv_load_kernel_and_initrd() which belongs to the same file. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng Reviewed-by: Alistair Francis --- hw/riscv/boot.c | 80

[RFC] virtio-iommu: Take into account possible aliasing in virtio_iommu_mr()

2023-01-16 Thread Eric Auger
When devices are plugged downstream to a pcie to pci bridge, the virtio-iommu driver stills sends virtio-iommu commands using the rid without aliasing (ie. devfn != 0). However only an IOMMU MR matching :00.0 was registered so virtio_iommu_mr fails to identify the memory region matching the ep_id.

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-16 Thread Philippe Mathieu-Daudé
On 15/12/22 16:30, Thomas Huth wrote: We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output of the qom-test. Let's stop printing the properties by default to get to a saner size here. The full output

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 11:17:08AM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jan 16, 2023 at 5:35 AM John Berberian, Jr > wrote: > > > > * Use cmd instead of /bin/sh on Windows. > > > > * Try to auto-detect cmd.exe's path, but default to a hard-coded path. > > > > Note that this will

Re: [PATCH 17/19] e1000e: Remove extra pointer indirection

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 04:59, Akihiko Odaki wrote: e1000e_write_packet_to_guest() passes the reference of variable ba as a pointer to an array, and that pointer indirection is just unnecessary; all functions which uses the passed reference performs no pointer operation on the pointer and they simply

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 10:06:07AM +, Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > I'm not sure how but this is re-breaking the windows build you just fixed: > > In file included from >

Re: [PATCH 7/7] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-01-16 Thread Jonathan Cameron via
Hi Mike, > > +static int ct3d_qmp_uncor_err_to_cxl(CxlUncorErrorType qmp_err) > > +{ > > +switch (qmp_err) { > > +case CXL_UNCOR_ERROR_TYPE_CACHE_DATA_PARITY: > > +return CXL_RAS_UNC_ERR_CACHE_DATA_PARITY; > > +case CXL_UNCOR_ERROR_TYPE_CACHE_ADDRESS_PARITY: > > +

Re: [for-8.0 v2 02/11] cryptodev: Remove 'name' & 'model' fields

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:47PM +0800, zhenwei pi wrote: > We have already used qapi to generate crypto device types, this allows > to convert type to a string 'model', so the 'model' field is not > needed. > > And the 'name' field is not used by any backend driver, drop it. > >

[PATCH v2 2/8] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
The only function ever assigned to AcpiDeviceIfClass::madt_cpu is pc_madt_cpu_entry() which doesn't use the AcpiDeviceIf parameter. Signed-off-by: Bernhard Beschow --- include/hw/acpi/acpi_dev_interface.h | 3 +-- include/hw/i386/pc.h | 6 ++ hw/acpi/acpi-x86-stub.c

[PATCH v2 7/8] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c index d8a444d06c..fec22d85c1 100644 --- a/hw/i386/acpi-microvm.c +++

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-16 Thread Markus Armbruster
Bernhard Beschow writes: > Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster : >>Bernhard Beschow writes: >> >>> When removing the "hw/boards.h" include from >>> hw/acpi/acpi_dev_interface.h, these include directives must be added to make >>> the code compile again. >>> >>>

[PATCH v2 1/8] hw/acpi: Add missing includes

2023-01-16 Thread Bernhard Beschow
When removing the "hw/boards.h" include in hw/acpi/acpi_dev_interface.h, these include directives must be added to make the code compile again. Signed-off-by: Bernhard Beschow --- hw/acpi/hmat.h | 3 ++- hw/acpi/cpu.c| 2 ++ hw/acpi/hmat.c | 1 +

[PATCH v2 8/8] hw/isa/isa-bus: Remove now unused isa_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 - hw/isa/isa-bus.c | 10 -- 2 files changed, 11 deletions(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 6c8a8a92cb..25acd5c34c 100644 --- a/include/hw/isa/isa.h

Re: [RFC PATCH v3 22/28] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI

2023-01-16 Thread Philippe Mathieu-Daudé
On 13/1/23 15:04, Fabiano Rosas wrote: We will soon enable the build without TCG, which does not support many machines, so only run the bcm2835-dma-test when the corresponding machine is present. Signed-off-by: Fabiano Rosas --- tests/qtest/meson.build | 4 ++-- 1 file changed, 2

Re: [PATCH 07/11] audio/audio_template: use g_malloc0() to replace audio_calloc()

2023-01-16 Thread Daniel P . Berrangé
On Sun, Dec 18, 2022 at 06:39:00PM +0100, Volker Rümelin wrote: > Am 18.12.22 um 18:26 schrieb Philippe Mathieu-Daudé: > > On 18/12/22 18:15, Volker Rümelin wrote: > > > Use g_malloc0() as a direct replacement for audio_calloc(). > > > > > > Signed-off-by: Volker Rümelin > > > --- > > >  

Re: [PATCH 4/7] hw/i386/acpi-build: Remove unused attributes

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 23:27, Bernhard Beschow wrote: Ammends commit 3db119da7915 'pc: acpi: switch to AML API composed DSDT'. Signed-off-by: Bernhard Beschow --- hw/i386/acpi-build.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: regarding qapi and qapi-rs

2023-01-16 Thread Alex Bennée
Yu Zhang writes: > Hi all, > > I noticed that with each qemu release, the qapi (C version) may introduce > some changes, and the qapi-rs > (Rust version) also changes correspondingly. However, recently there is no > qapi-rs release yet for qemu-7.2. > I'd like to know, is the release of the

Re: [PATCH v7 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Cédric Le Goater
Hello Avihai, On 1/15/23 19:35, Avihai Horon wrote: Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support VFIO_MIGRATION_STOP_COPY part of the v2 protocol. The two protocols, v1 and v2, will co-exist and in the following

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Jan 16, 2023 at 10:06:07AM +, Alex Bennée wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Signed-off-by: Marc-André Lureau >> >> I'm not sure how but this is re-breaking the windows build you just fixed:

Re: [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 10 ++ include/hw/nvram/eeprom_at24c.h | 10 ++ 2 files changed, 20 insertions(+) create mode 100644 include/hw/nvram/eeprom_at24c.h +void

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Peter Maydell
On Mon, 16 Jan 2023 at 13:45, Fabiano Rosas wrote: > > Richard Henderson writes: > > > On 1/13/23 06:04, Fabiano Rosas wrote: > >> The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the > >> cortex-a57 as default cpu for KVM. > >> > >> Signed-off-by: Fabiano Rosas > > > > Ideally

Re: [PATCH] tests/vm: Update haiku test vm to R1/Beta3

2023-01-16 Thread Thomas Huth
On 14/01/2023 23.47, Alexander von Gluck IV wrote: January 13, 2023 7:30 AM, "Philippe Mathieu-Daudé" wrote: On 13/1/23 12:05, Philippe Mathieu-Daudé wrote: Per https://www.haiku-os.org/guides/daily-tasks/updating-system we can keep the box image in sync with its repo by using: # pkgman add

[QUESTION] About virtio and eventloop

2023-01-16 Thread zhukeqian via
Hi all maintainers and community friends, Recently I am reviewing and learning the virtio and eventloop implementation of latest QEMU, and now I have a questions for help: In general, the IO requests of virtio is popped in iothread/mainloop and may submitted to "async IO Engine"

Re: [PATCH v3] net: stream: add a new option to automatically reconnect

2023-01-16 Thread Laurent Vivier
ping On 1/5/23 14:13, Laurent Vivier wrote: In stream mode, if the server shuts down there is currently no way to reconnect the client to a new server without removing the NIC device and the netdev backend (or to reboot). This patch introduces a reconnect option that specifies a delay to try

Re: [PATCH v5] tests/qtest: netdev: test stream and dgram backends

2023-01-16 Thread Laurent Vivier
ping On 1/5/23 10:37, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v5: - disable test_stream_fd and test_dgram_fd on windows as socketpair() is not defined. - enable test_stream_unix_abstract only on linux as

[PATCH] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4

2023-01-16 Thread Thomas Huth
The old Haiku VM based on Beta 3 does not work anymore since it fails to install the additional packages now that Beta 4 has been released. Thanks to Alexander von Gluck IV for providing a new image based on Beta 4, we can now upgrade the test image in our QEMU CI, too, to get this working again.

答复: [QUESTION] About virtio and eventloop

2023-01-16 Thread zhukeqian via
I found blk_drain() is invoked by virtio_blk_reset(), so only the second question remains :). 发件人: zhukeqian <> 发送时间: 2023年1月16日 16:18 收件人: 'Michael S. Tsirkin' ; 'Stefan Hajnoczi' ; 'Peter Maydell' 抄送: qemu-devel@nongnu.org; Wubin (H) ; Chentao (Boby) ; Wanghaibin (D) ; Zhangbo (Oscar) ;

Re: [PATCH 2/9] audio: remove special audio_calloc function

2023-01-16 Thread Daniel P . Berrangé
On Sun, Jan 15, 2023 at 03:03:29PM +0100, Volker Rümelin wrote: > Am 13.01.23 um 17:21 schrieb Daniel P. Berrangé: > > The audio_calloc function does various checks on the size and > > nmembers parameters to detect various error conditions. There > > are only 5 callers > > > > *

Re: [RFC v2 05/13] vdpa net: add migration blocker if cannot migrate cvq

2023-01-16 Thread Eugenio Perez Martin
On Mon, Jan 16, 2023 at 6:24 AM Michael S. Tsirkin wrote: > > On Mon, Jan 16, 2023 at 11:34:20AM +0800, Jason Wang wrote: > > > > 在 2023/1/13 15:46, Eugenio Perez Martin 写道: > > > On Fri, Jan 13, 2023 at 5:25 AM Jason Wang wrote: > > > > > > > > 在 2023/1/13 01:24, Eugenio Pérez 写道: > > > > > A

Re: [for-8.0 v2 01/11] cryptodev: Introduce cryptodev.json

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:46PM +0800, zhenwei pi wrote: > Introduce QCryptodevBackendType in cryptodev.json, also apply this to > related codes. Then we can drop 'enum CryptoDevBackendOptionsType'. > > Signed-off-by: zhenwei pi > --- > MAINTAINERS | 1 + >

Re: [for-8.0 v2 04/11] cryptodev: Introduce server type in QAPI

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:49PM +0800, zhenwei pi wrote: > Introduce cryptodev service type in cryptodev.json, then apply this > to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx > dependence from QEMU cryptodev. > > Signed-off-by: zhenwei pi > --- > backends/cryptodev-builtin.c

Re: [PATCH] accel/kvm: Specify default IPA size for arm64

2023-01-16 Thread Peter Maydell
On Sat, 14 Jan 2023 at 06:49, Akihiko Odaki wrote: > > On 2023/01/14 14:23, Richard Henderson wrote: > > On 1/8/23 22:22, Akihiko Odaki wrote: > >> libvirt uses "none" machine type to test KVM availability. Before this > >> change, QEMU used to pass 0 as machine type when calling KVM_CREATE_VM. >

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:50PM +0800, zhenwei pi wrote: > Now we have a QMP command to query crypto devices: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { > "service": [ > "akcipher", > "mac", > "hash", >

Re: [PATCH v5 1/4] file-posix: add tracking of the zone write pointers

2023-01-16 Thread Sam Li
Sam Li 于2022年10月27日周四 23:52写道: > > Since Linux doesn't have a user API to issue zone append operations to > zoned devices from user space, the file-posix driver is modified to add > zone append emulation using regular writes. To do this, the file-posix > driver tracks the wp location of all zones

[PATCH v2 3/8] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
This class attribute was always set to pc_madt_cpu_entry(). pc_madt_cpu_entry() is architecture dependent and was assigned to the attribute even in architecture agnostic code such as in hw/acpi/piix4.c and hw/isa/lpc_ich9. Not having to set madt_cpu there resolves the assumption that these device

[PATCH v2 0/8] AML Housekeeping

2023-01-16 Thread Bernhard Beschow
This series resolves the AcpiDeviceIfClass::madt_cpu function pointer. It turns out that it isn't needed and it even frees the ACPI controllers from assigning it an x86 specific function. This is especially interesting for the PIIX4 PM which is also used in MIPS only contexts. Furthermore, the

[PATCH v2 6/8] hw/acpi/acpi_aml_interface: Extract qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/acpi/acpi_aml_interface.h | 3 +++ hw/acpi/acpi_interface.c | 10 ++ hw/i2c/smbus_ich9.c | 5 + hw/isa/lpc_ich9.c| 5 + hw/isa/piix3.c

[PATCH v2 5/8] hw/i386/acpi-build: Remove unused attributes

2023-01-16 Thread Bernhard Beschow
Ammends commit 3db119da7915 'pc: acpi: switch to AML API composed DSDT'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0be3960a37..428328dc2d

[PATCH v8 05/13] migration/qemu-file: Add qemu_file_get_to_fd()

2023-01-16 Thread Avihai Horon
Add new function qemu_file_get_to_fd() that allows reading data from QEMUFile and writing it straight into a given fd. This will be used later in VFIO migration code. Signed-off-by: Avihai Horon Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cédric Le Goater --- migration/qemu-file.h

[PATCH v8 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Avihai Horon
Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support VFIO_MIGRATION_STOP_COPY part of the v2 protocol. The two protocols, v1 and v2, will co-exist and in the following patches v1 protocol code will be removed. There are

[PATCH v8 04/13] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-01-16 Thread Avihai Horon
Currently, if IOMMU of a VFIO container doesn't support dirty page tracking, migration is blocked. This is because a DMA-able VFIO device can dirty RAM pages without updating QEMU about it, thus breaking the migration. However, this doesn't mean that migration can't be done at all. In such case,

[PATCH v8 11/13] vfio/migration: Remove VFIO migration protocol v1

2023-01-16 Thread Avihai Horon
Now that v2 protocol implementation has been added, remove the deprecated v1 implementation. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 5 - hw/vfio/common.c | 19 +- hw/vfio/migration.c | 703

[PATCH v8 08/13] vfio/migration: Rename functions/structs related to v1 protocol

2023-01-16 Thread Avihai Horon
To avoid name collisions, rename functions and structs related to VFIO migration protocol v1. This will allow the two protocols to co-exist when v2 protocol is added, until v1 is removed. No functional changes intended. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater ---

[PATCH v8 07/13] vfio/migration: Move migration v1 logic to vfio_migration_init()

2023-01-16 Thread Avihai Horon
Move vfio_dev_get_region_info() logic from vfio_migration_probe() to vfio_migration_init(). This logic is specific to v1 protocol and moving it will make it easier to add the v2 protocol implementation later. No functional changes intended. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le

[PATCH v8 12/13] vfio: Alphabetize migration section of VFIO trace-events file

2023-01-16 Thread Avihai Horon
Sort the migration section of VFIO trace events file alphabetically and move two misplaced traces to common.c section. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- hw/vfio/trace-events | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH v8 02/13] migration: No save_live_pending() method uses the QEMUFile parameter

2023-01-16 Thread Avihai Horon
From: Juan Quintela So remove it everywhere. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert --- include/migration/register.h | 3 +-- migration/savevm.h | 3 +-- hw/s390x/s390-stattrib.c | 2 +-

  1   2   3   4   >