[RFC PATCH v2 0/1] vfio-user: add live migration to vfio-user protocol specification

2023-08-23 Thread William Henderson
This patch adds live migration to the vfio-user specification. There are a few minor wording changes from v1 of this patch [1]. This is on top of Jag's proposed patch to add the vfio-user specification document to qemu [2]. We would appreciate reviews of that change too if people have the time.

Re: [PATCH qemu 2/2] dump: Only use the makedumpfile flattened format when necessary

2023-08-23 Thread Marc-André Lureau
Hi On Wed, Aug 23, 2023 at 4:31 AM Stephen Brennan wrote: > > Stephen Brennan writes: > > Marc-André Lureau writes: > >> I am a bit reluctant to change the dump format by default. But since the > >> flatten format is more "complicated" than the "normal" format, perhaps we > >> can assume all

Re: [PATCH 2/3] target/s390x: Fix the "ignored match" case in VSTRS

2023-08-23 Thread David Hildenbrand
On 07.08.23 10:10, Ilya Leoshkevich wrote: On Sat, 2023-08-05 at 10:02 +0200, David Hildenbrand wrote: On 05.08.23 01:03, Ilya Leoshkevich wrote: Currently the emulation of VSTRS recognizes partial matches in presence of \0 in the haystack, which, according to PoP, is not correct: If

Re: [PATCH v11 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-08-23 Thread Akihiko Odaki
On 2023/08/23 10:25, Gurchetan Singh wrote: This adds initial support for gfxstream and cross-domain. Both features rely on virtio-gpu blob resources and context types, which are also implemented in this patch. gfxstream has a long and illustrious history in Android graphics

Re: [PATCH] chardev/char-pty: Avoid losing bytes when the other side just (re-)connected

2023-08-23 Thread Amaury Pouly
>> When starting a guest via libvirt with "virsh start --console ...", >> the first second of the console output is missing. This is especially >> annoying on s390x that only has a text console by default and no graphical >> output - if the bios fails to boot here, the information about what went

Re: [PATCH v3 05/14] tcg/ppc: Use ADDPCIS in tcg_out_tb_start

2023-08-23 Thread Jordan Niethe
On Wed, 16 Aug 2023, 5:57 am Richard Henderson, < richard.hender...@linaro.org> wrote: > With ISA v3.0, we can use ADDPCIS instead of BCL+MFLR to load NIP. > > Signed-off-by: Richard Henderson > --- > tcg/ppc/tcg-target.c.inc | 25 ++--- > 1 file changed, 22 insertions(+), 3

Re: [PATCH v2 1/2] hw/misc/i2c-echo: add copyright/license note

2023-08-23 Thread Thomas Huth
On 23/08/2023 11.01, Klaus Jensen wrote: From: Klaus Jensen Add missing copyright and license notice. Also add a short description of the device. Signed-off-by: Klaus Jensen --- hw/misc/i2c-echo.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/i2c-echo.c

[PATCH v2 4/4] vfio-user: Fix config space access byte order

2023-08-23 Thread Mattias Nissler
PCI config space is little-endian, so on a big-endian host we need to perform byte swaps for values as they are passed to and received from the generic PCI config space access machinery. Signed-off-by: Mattias Nissler --- hw/remote/vfio-user-obj.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 2/4] Update subprojects/libvfio-user

2023-08-23 Thread Mattias Nissler
Brings in assorted bug fixes. In particular, "Fix address calculation for message-based DMA" corrects a bug in DMA address calculation which is necessary to get DMA across VFIO-user messages working. Signed-off-by: Mattias Nissler --- subprojects/libvfio-user.wrap | 2 +- 1 file changed, 1

[PATCH v2 0/4] Support message-based DMA in vfio-user server

2023-08-23 Thread Mattias Nissler
This series adds basic support for message-based DMA in qemu's vfio-user server. This is useful for cases where the client does not provide file descriptors for accessing system memory via memory mappings. My motivating use case is to hook up device models as PCIe endpoints to a hardware design.

[PATCH v2 3/4] vfio-user: Message-based DMA support

2023-08-23 Thread Mattias Nissler
Wire up support for DMA for the case where the vfio-user client does not provide mmap()-able file descriptors, but DMA requests must be performed via the VFIO-user protocol. This installs an indirect memory region, which already works for pci_dma_{read,write}, and pci_dma_map works thanks to the

[PATCH v2 1/4] softmmu: Support concurrent bounce buffers

2023-08-23 Thread Mattias Nissler
When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for device models to request mapping of several DMA regions at the same time. Examples include: *

Re: [PATCH 3/3] vfio-user: Message-based DMA support

2023-08-23 Thread Mattias Nissler
On Thu, Jul 20, 2023 at 8:32 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:27AM -0700, Mattias Nissler wrote: > > Wire up support for DMA for the case where the vfio-user client does not > > provide mmap()-able file descriptors, but DMA requests must be performed > > via the

Re: [PATCH 1/3] softmmu: Support concurrent bounce buffers

2023-08-23 Thread Mattias Nissler
On Thu, Jul 20, 2023 at 8:10 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:25AM -0700, Mattias Nissler wrote: > > It is not uncommon for device models to request mapping of several DMA > > regions at the same time. An example is igb (and probably other net > > devices as well) when

Re: [PATCH 2/3] softmmu: Remove DMA unmap notification callback

2023-08-23 Thread Mattias Nissler
On Thu, Jul 20, 2023 at 8:14 PM Stefan Hajnoczi wrote: > > On Tue, Jul 04, 2023 at 01:06:26AM -0700, Mattias Nissler wrote: > > According to old commit messages, this was introduced to retry a DMA > > operation at a later point in case the single bounce buffer is found to > > be busy. This was

[PATCH v4 1/3] hw/i2c: add smbus pec utility function

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Add i2c_smbus_pec() to calculate the SMBus Packet Error Code for a message. Signed-off-by: Klaus Jensen --- hw/i2c/smbus_master.c | 26 ++ include/hw/i2c/smbus_master.h | 2 ++ 2 files changed, 28 insertions(+) diff --git

[PATCH v4 0/3] hw/{i2c,nvme}: mctp endpoint, nvme management interface model

2023-08-23 Thread Klaus Jensen
This adds a generic MCTP endpoint model that other devices may derive from. Also included is a very basic implementation of an NVMe-MI device, supporting only a small subset of the required commands. Since this all relies on i2c target mode, this can currently only be used with an SoC that

[PATCH v4 3/3] hw/nvme: add nvme management interface model

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Add the 'nmi-i2c' device that emulates an NVMe Management Interface controller. Initial support is very basic (Read NMI DS, Configuration Get). This is based on previously posted code by Padmakar Kalghatgi, Arun Kumar Agasar and Saurav Kumar. Signed-off-by: Klaus Jensen

[PATCH v4 2/3] hw/i2c: add mctp core

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Add an abstract MCTP over I2C endpoint model. This implements MCTP control message handling as well as handling the actual I2C transport (packetization). Devices are intended to derive from this and implement the class methods. Parts of this implementation is inspired by

Re: Lost partition tables on ide-hd + ahci drive

2023-08-23 Thread Fiona Ebner
Am 23.08.23 um 10:47 schrieb Fiona Ebner: > Am 17.02.23 um 22:22 schrieb Mike Maslenkin: >> I can not tell anything about dma-reentracy issues, but yes, i would >> start to look at check_cmd() function call sequence. >> The most interesting is why Sector Count = 1. I thought about race >> with IDE

[PATCH v2 2/2] hw/misc/Kconfig: add switch for i2c-echo

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Associate i2c-echo with TEST_DEVICES and add a dependency on I2C. Reviewed-by: Thomas Huth Signed-off-by: Klaus Jensen --- hw/misc/Kconfig | 5 + hw/misc/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/misc/Kconfig

[PATCH v2 1/2] hw/misc/i2c-echo: add copyright/license note

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Add missing copyright and license notice. Also add a short description of the device. Signed-off-by: Klaus Jensen --- hw/misc/i2c-echo.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c index 5705ab5d7349..8ee03cb5632b

[PATCH v2 0/2] hw/misc: small fixes for i2c-echo

2023-08-23 Thread Klaus Jensen
Add missing copyright/license note and add a Kconfig entry. Signed-off-by: Klaus Jensen --- Changes in v2: - Use SPDX for license note (Thomas) - Link to v1: https://lore.kernel.org/r/20230823-i2c-echo-fixes-v1-0-ccc05a602...@samsung.com --- Klaus Jensen (2): hw/misc/i2c-echo: add

Re: [PATCH v3 5/5] target/s390x: AP-passthrough for PV guests

2023-08-23 Thread Michael Mueller
On 18.08.23 13:15, Steffen Eiden wrote: Enabling AP-passthrough(AP-pt) for PV-guest by using the new CPU features for PV-AP-pt of KVM. As usual QEMU first checks which CPU features are available and then sets them if available and selected by user. An additional check is done to verify that

[PATCH v4 12/14] simpletrace: added simplified Analyzer2 class

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal By moving the dynamic argument construction to keyword-arguments, we can remove all of the specialized handling, and streamline it. If a tracing method wants to access these, they can define the kwargs, or ignore it be placing `**kwargs` at the end of the function's arguments

[PATCH v4 06/14] simpletrace: improved error handling on struct unpack

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal A failed call to `read_header` wouldn't be handled the same for the two different code paths (one path would try to use `None` as a list). Changed to raise exception to be handled centrally. This also allows for easier unpacking, as errors has been filtered out. Signed-off-by:

[PATCH v4 01/14] simpletrace: add __all__ to define public interface

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal It was unclear what was the supported public interface. I.e. when refactoring the code, what functions/classes are important to retain. Signed-off-by: Mads Ynddal --- scripts/simpletrace.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/simpletrace.py

[PATCH v4 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items()

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This means the script curerntly doesn't work on Python 3. Signed-off-by: Mads Ynddal --- scripts/analyse-locks-simpletrace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 02/14] simpletrace: annotate magic constants from QEMU code

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal It wasn't clear where the constants and structs came from, so I added comments to help. Signed-off-by: Mads Ynddal --- scripts/simpletrace.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py index b221d9a241..5c230a1b74

[PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal In my work to refactor simpletrace.py, I noticed that there's no maintainer of it, and has the status of "odd fixes". I'm using it from time to time, so I'd like to maintain the script. I've added myself as reviewer under "Tracing" to be informed of changes that might affect

[PATCH v4 10/14] simpletrace: move logic of process into internal function

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal To avoid duplicate code depending on input types and to better handle open/close of log with a context-manager, we move the logic of process into _process. Signed-off-by: Mads Ynddal --- scripts/simpletrace.py | 26 ++ 1 file changed, 18

[PATCH v4 11/14] simpletrace: move event processing to Analyzer class

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Moved event processing to the Analyzer class to separate specific analyzer logic (like caching and function signatures) from the _process function. This allows for new types of Analyzer-based subclasses without changing the core code. Note, that the fn_cache is important for

[PATCH v4 04/14] simpletrace: changed naming of edict and idtoname to improve readability

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Readability is subjective, but I've expanded the naming of the variables and arguments, to help with understanding for new eyes on the code. Signed-off-by: Mads Ynddal Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- scripts/simpletrace.py | 34

[PATCH v4 00/14] simpletrace: refactor and general improvements

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal I wanted to use simpletrace.py for an internal project, so I tried to update and polish the code. Some of the commits resolve specific issues, while some are more subjective. I've tried to divide it into commits so we can discuss the individual changes, and I'm ready to pull

[PATCH v4 07/14] simpletrace: define exception and add handling

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Define `SimpleException` to differentiate our exceptions from generic exceptions (IOError, etc.). Adapted simpletrace to support this and output to stderr. Signed-off-by: Mads Ynddal Reviewed-by: Philippe Mathieu-Daudé --- scripts/simpletrace.py | 22 ++

[PATCH v4 03/14] simpletrace: improve parsing of sys.argv; fix files never closed.

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal The arguments extracted from `sys.argv` named and unpacked to make it clear what the arguments are and what they're used for. The two input files were opened, but never explicitly closed. File usage changed to use `with` statement to take care of this. At the same time,

[PATCH v4 08/14] simpletrace: made Analyzer into context-manager

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Instead of explicitly calling `begin` and `end`, we can change the class to use the context-manager paradigm. This is mostly a styling choice, used in modern Python code. But it also allows for more advanced analyzers to handle exceptions gracefully in the `__exit__` method

[PATCH v4 05/14] simpletrace: update code for Python 3.11

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal The call to `getargspec` was deprecated and in Python 3.11 it has been removed in favor of `getfullargspec`. `getfullargspec` is compatible with QEMU's requirement of at least Python version 3.6. Signed-off-by: Mads Ynddal Reviewed-by: Stefan Hajnoczi ---

[PATCH v4 09/14] simpletrace: refactor to separate responsibilities

2023-08-23 Thread Mads Ynddal
From: Mads Ynddal Moved event_mapping and event_id_to_name down one level in the function call-stack to keep variable instantiation and usage closer (`process` and `run` has no use of the variables; `read_trace_records` does). Instead of passing event_mapping and event_id_to_name to the bottom

Re: [PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

2023-08-23 Thread Thomas Huth
On 23/08/2023 10.14, Klaus Jensen wrote: From: Klaus Jensen Associate i2c-echo with TEST_DEVICES and add a dependency on I2C. Signed-off-by: Klaus Jensen --- hw/misc/Kconfig | 5 + hw/misc/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] hw/misc/i2c-echo: add copyright/license note

2023-08-23 Thread Thomas Huth
On 23/08/2023 10.14, Klaus Jensen wrote: From: Klaus Jensen Add missing copyright and license notice. Also add a short description of the device. Signed-off-by: Klaus Jensen --- hw/misc/i2c-echo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/misc/i2c-echo.c

Re: [PATCH v7 10/12] virtio-sound: implement audio output (TX)

2023-08-23 Thread Manos Pitsidianakis
Hello Philippe, On Wed, 23 Aug 2023 01:17, Philippe Mathieu-Daudé wrote: +trace_virtio_snd_handle_xfer(); Maybe ... <- snip -> ... it is more useful displaying the callback stream index here? trace_virtio_snd_handle_xfer(hdr.stream_id); Certainly, why not. This is an

Re: Lost partition tables on ide-hd + ahci drive

2023-08-23 Thread Fiona Ebner
Am 17.02.23 um 22:22 schrieb Mike Maslenkin: > I can not tell anything about dma-reentracy issues, but yes, i would > start to look at check_cmd() function call sequence. > The most interesting is why Sector Count = 1. I thought about race > with IDE reset where registers initialized with > value

Re: [PATCH] meson: Use subprocess.check_output()

2023-08-23 Thread Thomas Huth
On 23/08/2023 10.42, Thomas Huth wrote: On 23/08/2023 10.36, Michael Tokarev wrote: 23.08.2023 11:33, Thomas Huth wrote: On 12/08/2023 11.11, Akihiko Odaki wrote: subprocess.check_output() is a more concise way to execute a subprocess here. Signed-off-by: Akihiko Odaki --- Based-on:

Re: [PATCH] meson: Use subprocess.check_output()

2023-08-23 Thread Thomas Huth
On 23/08/2023 10.36, Michael Tokarev wrote: 23.08.2023 11:33, Thomas Huth wrote: On 12/08/2023 11.11, Akihiko Odaki wrote: subprocess.check_output() is a more concise way to execute a subprocess here. Signed-off-by: Akihiko Odaki --- Based-on: <20230812061540.5398-1-akihiko.od...@daynix.com>

Re: [PATCH] meson: Use subprocess.check_output()

2023-08-23 Thread Michael Tokarev
23.08.2023 11:33, Thomas Huth wrote: On 12/08/2023 11.11, Akihiko Odaki wrote: subprocess.check_output() is a more concise way to execute a subprocess here. Signed-off-by: Akihiko Odaki --- Based-on: <20230812061540.5398-1-akihiko.od...@daynix.com> ("[PATCH] meson: Fix MESONINTROSPECT

Re: [PATCH] meson: Use subprocess.check_output()

2023-08-23 Thread Thomas Huth
On 12/08/2023 11.11, Akihiko Odaki wrote: subprocess.check_output() is a more concise way to execute a subprocess here. Signed-off-by: Akihiko Odaki --- Based-on: <20230812061540.5398-1-akihiko.od...@daynix.com> ("[PATCH] meson: Fix MESONINTROSPECT parsing") Since that other patch has never

Re: [PATCH 05/24] tcg: spelling fixes

2023-08-23 Thread Alex Bennée
Michael Tokarev writes: > Signed-off-by: Michael Tokarev Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Associate i2c-echo with TEST_DEVICES and add a dependency on I2C. Signed-off-by: Klaus Jensen --- hw/misc/Kconfig | 5 + hw/misc/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig index

[PATCH 0/2] hw/misc: small fixes for i2c-echo

2023-08-23 Thread Klaus Jensen
/meson.build | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) --- base-commit: b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa change-id: 20230823-i2c-echo-fixes-945c0bf059b5 Best regards, -- Klaus Jensen

[PATCH 1/2] hw/misc/i2c-echo: add copyright/license note

2023-08-23 Thread Klaus Jensen
From: Klaus Jensen Add missing copyright and license notice. Also add a short description of the device. Signed-off-by: Klaus Jensen --- hw/misc/i2c-echo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c index 5705ab5d7349..5ae3d0817ead

Re: [PATCH 2/2] hw/intc: Make rtc variable names consistent

2023-08-23 Thread Jason Chien
Thanks for the update. On Tue, Aug 22, 2023 at 1:53 AM Alistair Francis wrote: > On Mon, Aug 21, 2023 at 12:15 PM Jason Chien > wrote: > > > > Ping. > > This has been applied to the RISC-V tree. It will go in after the QEMU > release freeze is over (probably a week or two). > > Alistair > > >

[PATCH] softmmu: Fix dirtylimit memory leak

2023-08-23 Thread alloc . young
From: "alloc.young" Fix memory leak in hmp_info_vcpu_dirty_limit,use g_autoptr handle memory deallocation, alse use g_free to match g_malloc && g_new functions. Signed-off-by: alloc.young --- softmmu/dirtylimit.c | 26 -- 1 file changed, 12 insertions(+), 14

Re: [PATCH v2 18/58] i386/tdx: Validate TD attributes

2023-08-23 Thread Xiaoyao Li
On 8/22/2023 10:42 PM, Daniel P. Berrangé wrote: On Tue, Aug 22, 2023 at 10:30:47PM +0800, Xiaoyao Li wrote: On 8/21/2023 5:16 PM, Daniel P. Berrangé wrote: On Fri, Aug 18, 2023 at 05:50:01AM -0400, Xiaoyao Li wrote: Validate TD attributes with tdx_caps that fixed-0 bits must be zero and

Re: [PATCH v2 02/58] i386: Introduce tdx-guest object

2023-08-23 Thread Xiaoyao Li
On 8/22/2023 2:22 PM, Markus Armbruster wrote: Xiaoyao Li writes: Introduce tdx-guest object which implements the interface of CONFIDENTIAL_GUEST_SUPPORT, and will be used to create TDX VMs (TDs) by qemu -machine ...,confidential-guest-support=tdx0\ -object tdx-guset,id=tdx0

Re: [PATCH v2 03/11] hw/misc: add a toy i2c echo device

2023-08-23 Thread Klaus Jensen
On Aug 22 19:20, Thomas Huth wrote: > On 01/03/2023 17.56, Cédric Le Goater wrote: > > From: Klaus Jensen > > > > Add an example I2C device to demonstrate how a slave may master the bus > > and send data asynchronously to another slave. > > > > The device will echo whatever it is sent to the

[PATCH v2 3/3] gdbstub: replace exit(0) with proper shutdown

2023-08-23 Thread Clément Chigot
This replaces the exit(0) call by a shutdown request, ensuring a proper cleanup of Qemu. Otherwise, some connections could be broken without being correctly flushed. Signed-off-by: Clément Chigot --- gdbstub/gdbstub.c | 3 +-- gdbstub/softmmu.c | 13 + gdbstub/user.c| 2 ++ 3

[PATCH v2 1/3] hw/misc/sifive_test.c: replace exit(0) with proper shutdown

2023-08-23 Thread Clément Chigot
This replaces the exit(0) call by a shutdown request, ensuring a proper cleanup of Qemu. Otherwise, some connections like gdb could be broken without being correctly flushed. Signed-off-by: Clément Chigot Reviewed-by: Alistair Francis --- hw/misc/sifive_test.c | 4 +++- 1 file changed, 3

[PATCH v2 2/3] hw/char: riscv_htif: replace exit(0) with proper shutdown

2023-08-23 Thread Clément Chigot
This replaces the exit(0) call by a shutdown request, ensuring a proper cleanup of Qemu. Otherwise, some connections like gdb could be broken without being correctly flushed. Signed-off-by: Clément Chigot Reviewed-by: Alistair Francis --- hw/char/riscv_htif.c | 12 +++- 1 file changed,

[PATCH v2 0/3] Risc-V/gdb: replace exit(0) with proper shutdown

2023-08-23 Thread Clément Chigot
This serie replaces some of the call to exit(0) in hardware used by Risc-V boards or made when gdb is requested to exit. Otherwise, the gdb connection can be too abruptly disconnected resulting in the last gdb packet "Wxx" being not sent. As qemu_system_shutdown_request doesn't allow to pass the

[PATCH 10/24] riscv: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/riscv/microchip_pfsoc.c| 2 +- hw/riscv/virt.c | 4 ++-- include/hw/riscv/riscv_hart.h | 2 +- target/riscv/cpu.h| 2 +- target/riscv/cpu_bits.h | 4 ++--

[PATCH 16/24] hw/display: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/display/bochs-display.c | 2 +- hw/display/qxl.c | 2 +- hw/display/ssd0303.c | 2 +- hw/display/ssd0323.c | 2 +- hw/display/xlnx_dp.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 20/24] include/: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- include/block/block_int-common.h | 2 +- include/chardev/char-fe.h| 4 ++-- include/crypto/akcipher.h| 2 +- include/crypto/ivgen.h | 4 ++-- include/elf.h| 4 ++-- include/hw/acpi/aml-build.h | 2 +-

[PATCH 18/24] audio: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- audio/mixeng.h| 2 +- hw/audio/fmopl.c | 8 hw/audio/fmopl.h | 2 +- hw/audio/gusemu_hal.c | 4 ++-- hw/audio/intel-hda-defs.h | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/audio/mixeng.h

[PATCH 03/24] ui: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- ui/cocoa.m| 2 +- ui/keymaps.h | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2.c | 2 +- ui/vnc-enc-zrle.c.inc | 2 +- ui/vnc-enc-zywrle.h | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ui/cocoa.m

[PATCH 09/24] ppc: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- host/include/ppc/host/cpuinfo.h | 2 +- hw/ppc/ppc.c| 2 +- hw/ppc/prep_systemio.c | 2 +- hw/ppc/spapr.c | 8 hw/ppc/spapr_hcall.c| 2 +- hw/ppc/spapr_nvdimm.c

[PATCH 22/24] tests/: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- tests/avocado/acpi-bits.py | 4 ++-- tests/avocado/acpi-bits/bits-tests/testacpi.py2 | 4 ++-- tests/decode/err_pattern_group_ident2.decode| 2 +- tests/docker/common.rc | 2 +-

[PATCH 14/24] hw/tpm: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/tpm/tpm_tis.h| 2 +- hw/tpm/tpm_tis_common.c | 2 +- hw/tpm/tpm_tis_i2c.c| 4 ++-- hw/tpm/tpm_tis_isa.c| 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h

[PATCH 15/24] hw/usb hw/ide hw/i2c: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/i2c/pm_smbus.c | 2 +- hw/i2c/pmbus_device.c | 2 +- hw/i2c/smbus_slave.c| 2 +- hw/ide/ahci_internal.h | 4 ++-- hw/ide/cmd646.c | 2 +- hw/ide/core.c | 2 +- hw/usb/ccid-card-emulated.c | 2 +-

[PATCH 13/24] hw/pci: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/pci-bridge/cxl_downstream.c | 2 +- hw/pci-bridge/pci_expander_bridge.c | 2 +- hw/pci-host/bonito.c| 2 +- hw/pci-host/designware.c| 4 ++-- hw/pci-host/dino.c | 2 +- hw/pci-host/gpex-acpi.c | 2

[PATCH 19/24] hw/other: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/acpi/aml-build.c | 6 +++--- hw/acpi/hmat.c | 2 +- hw/acpi/nvdimm.c | 2 +- hw/block/hd-geometry.c | 4 ++-- hw/block/pflash_cfi01.c | 2 +- hw/char/cadence_uart.c | 2 +-

[PATCH 06/24] docs: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- docs/devel/qapi-code-gen.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 7f78183cd4..b0852da97b 100644 --- a/docs/devel/qapi-code-gen.rst +++

[PATCH 12/24] hw/net: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/net/cadence_gem.c | 10 +- hw/net/dp8393x.c | 2 +- hw/net/e1000_regs.h | 2 +- hw/net/e1000x_regs.h | 2 +- hw/net/fsl_etsec/rings.c | 2 +- hw/net/igb_regs.h | 4 ++-- hw/net/mcf_fec.c | 2 +-

[PATCH 23/24] qga/: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qga/channel-posix.c | 2 +- qga/commands-posix-ssh.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 4 ++-- qga/main.c| 2 +- qga/vss-win32/install.cpp | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-)

[PATCH 02/24] bsd-user: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- bsd-user/errno_defs.h| 2 +- bsd-user/freebsd/target_os_siginfo.h | 2 +- bsd-user/freebsd/target_os_stack.h | 4 ++-- bsd-user/freebsd/target_os_user.h| 2 +- bsd-user/qemu.h | 2 +- bsd-user/signal-common.h

[PATCH 24/24] misc/other: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- accel/tcg/tb-maint.c | 2 +- backends/tpm/tpm_ioctl.h | 2 +- chardev/char-socket.c | 6 +++--- chardev/char.c | 2 +- contrib/plugins/cache.c| 2 +- contrib/plugins/lockstep.c | 2 +- crypto/afalg.c | 2 +-

[PATCH 21/24] scripts/: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- scripts/checkpatch.pl | 2 +- scripts/ci/gitlab-pipeline-status | 2 +- scripts/codeconverter/codeconverter/qom_macros.py | 2 +- scripts/oss-fuzz/minimize_qtest_trace.py | 8

[PATCH 11/24] hexagon: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- target/hexagon/README | 2 +- target/hexagon/fma_emu.c| 2 +- target/hexagon/idef-parser/README.rst | 2 +- target/hexagon/idef-parser/idef-parser.h| 2 +- target/hexagon/idef-parser/parser-helpers.c | 6

[PATCH 17/24] xen: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +- include/hw/xen/interface/arch-x86/xen.h| 2 +- include/hw/xen/interface/event_channel.h | 2 +- include/hw/xen/interface/grant_table.h

[PATCH 07/24] i386: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- host/include/i386/host/cpuinfo.h | 2 +- hw/i386/acpi-build.c | 4 ++-- hw/i386/amd_iommu.c | 4 ++-- hw/i386/intel_iommu.c| 4 ++-- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 2 +-

[PATCH 08/24] mips: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- hw/mips/malta.c | 2 +- target/mips/cpu-defs.c.inc | 2 +- target/mips/tcg/msa_helper.c| 12 ++-- target/mips/tcg/mxu_translate.c | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/mips/malta.c

[PATCH 04/24] util: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- util/cpuinfo-aarch64.c | 4 ++-- util/cpuinfo-i386.c| 4 ++-- util/cpuinfo-ppc.c | 2 +- util/main-loop.c | 2 +- util/oslib-posix.c | 2 +- util/qdist.c | 2 +- util/qemu-sockets.c| 2 +- util/rcu.c | 2 +- 8 files

[PATCH 05/24] tcg: spelling fixes

2023-08-23 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- tcg/aarch64/tcg-target.c.inc | 2 +- tcg/arm/tcg-target.c.inc | 4 ++-- tcg/riscv/tcg-target.c.inc | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index

Re: [PATCH v2 00/24] tree-wide spelling fixes

2023-08-23 Thread Michael Tokarev
This is interesting. So, I forgot to remove old, already sent patches from the work dir (usually I remove whole thing but didn't do that now). So I had 2 patch series in the same dir, one old already sent and applied, and one new. And did git send-email series/* - which obviously included

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-23 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 22 Aug 2023 at 16:50, Alex Bennée wrote: >> I've already wasted enough of my time debugging aliased variables in >> deeply nested loops. > > In theory we could try to enable -Wshadow and deal with > all the existing cases of aliasing, which would then > allow us

<    1   2   3