Hi Hanna,
I was thinking about how this could work without SUSPEND/RESUME. What
do you think of the following?
1. The front-end sends VHOST_USER_RESET_DEVICE (or
VHOST_USER_RESET_OWNER, when necessary) when the guest driver resets
the device but not on vhost_dev_start()/vhost_dev_stop().
2.
NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than
NVME_QUEUE_SIZE by 1.
Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist")
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Cc: stefa...@redhat.com
Cc: alex.c...@huawei.com
Cc: euler.ro...@huawei.com
Note, that
Explain Coverity that we are not going to overflow vmsg->fds.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
subprojects/libvhost-user/libvhost-user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
set_time() function doesn't set all the fields, so it's better to
initialize tm structure. And Coverity will be happier about it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/rtc/mc146818rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rtc/mc146818rtc.c
We support only 3- and 4-level page-tables, which is firstly checked in
vtd_decide_config(), then setup in vtd_init(). Than level fields are
checked by vtd_is_level_supported().
So here we can't have level out from 1..4 inclusive range. Let's assert
it. That also explains Coverity that we are not
local_err must be NULL before calling object_property_set_bool(), so we
must clear it on each iteration. Let's also use more convenient
error_reportf_err().
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/pci/pcie_sriov.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff
v2:
01: add explanations, new assert and avoid extra assignment
add CIDs [thx to Paolo]
02: add explanation, improve wording
04,07: s/{0}/{}
06,08: improve wording
Hi! Here are some improvements to handle issues found by Coverity (not
public Coverity site, so there are no CIDs).
Vladimir
Prefer clear assertions instead of [im]possible array overflow.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
util/filemonitor-inotify.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/util/filemonitor-inotify.c b/util/filemonitor-inotify.c
index
For SO_EE_ORIGIN_ZEROCOPY the 32-bit notification range is encoded
as [ee_info, ee_data] inclusively, so ee_info should be less or
equal to ee_data.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
io/channel-socket.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/io/channel-socket.c
Coverity signals that variable as being used uninitialized. And really,
when work with external APIs that's better to zero out the structure,
where we set some fields by hand.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
hw/core/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, 26 Sept 2023 at 20:42, Eric Blake wrote:
>
> On Tue, Sep 26, 2023 at 02:46:44PM +0100, Peter Maydell wrote:
> > On Tue, 26 Sept 2023 at 14:40, Eric Blake wrote:
> > >
> > > On Tue, Sep 26, 2023 at 01:28:01PM +0300, andrey.drobys...@virtuozzo.com
> > > wrote:
> > > > From: Andrey
On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy
wrote:
>
> We support only 3- and 4-level page-tables, which is firstly checked in
> vtd_decide_config(), then setup in vtd_init(). Than level fields are
> checked by vtd_is_level_supported().
>
> So here we can't have level out from
On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy
wrote:
>
> Prefer clear assertions instead of [im]possible array overflow.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> --
Reviewed-by: Peter Maydell
thanks
-- PMM
On Tue, 26 Sept 2023 at 21:16, Vladimir Sementsov-Ogievskiy
wrote:
>
> Coverity signals that variable as being used uninitialized. And really,
> when work with external APIs that's better to zero out the structure,
> where we set some fields by hand.
>
> Signed-off-by: Vladimir
On Tue, 26 Sept 2023 at 21:15, Vladimir Sementsov-Ogievskiy
wrote:
>
> set_time() function doesn't set all the fields, so it's better to
> initialize tm structure. And Coverity will be happier about it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> hw/rtc/mc146818rtc.c | 2 +-
> 1
On 07.09.23 22:29, Daniil Tatianin wrote:
So that we have less magic numbers to deal with. This also allows us to
reuse these in the following commits.
Signed-off-by: Daniil Tatianin
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
I sent this reply to your question on the same day, but it got eaten by
malfunctioning servers, and I noticed only now after another failure
made me dig through my logs. Sorry for the inconvenience!
Chenyi Qiang writes:
> On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote:
>> On Tue, Aug 22, 2023
On 07.09.23 22:29, Daniil Tatianin wrote:
The migration qtest all the way up to this point used to work by sheer
luck relying on the contents of all pages from 1MiB to 100MiB to contain
the same one value in the first byte initially.
This easily breaks if we reduce the amount of RAM for the
Peter Xu writes:
> Quotting from Markus in his replies:
Quoting
Suggest something like "Markus recently wrote:"
> migrate-set-parameters sets migration parameters, and
> query-migrate-parameters gets them. Unsurprisingly, the former's
> argument type MigrateSetParameters is quite close
Peter Xu writes:
> Drop the enum in qapi because it is never used in QMP APIs. Instead making
> it an internal definition for QEMU so that we can decouple it from QAPI,
> and also we can deduplicate the QAPI documentations.
>
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Peter Xu
The
On Tue, Sep 26, 2023 at 11:15:30PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than
> NVME_QUEUE_SIZE by 1.
>
> Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist")
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
From: Eric Blake
Documenting that we should not add new lines to work around SPF
rewrites sounds foreboding; the intent is instead that new lines here
are okay, but indicate a second problem elsewhere in our build process
that we should also consider fixing at the same time, to keep the
section
[add Markus]
On 26.09.23 23:15, Vladimir Sementsov-Ogievskiy wrote:
local_err must be NULL before calling object_property_set_bool(), so we
must clear it on each iteration. Let's also use more convenient
error_reportf_err().
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Warner Losh writes:
> On Tue, Sep 26, 2023 at 8:43 AM Markus Armbruster wrote:
>
>> Brian, Gerd, Jason, Marc-André, Michael, we need your help to enable
>> -Wshadow=local.
>>
>> Paolo, you already took care of several subsystems (thanks!), except you
>> left a few warnings in
Hi Salil,
On 9/26/23 20:04, Salil Mehta wrote:
This shall be used to store user specified topology{socket,cluster,core,thread}
and shall be converted to a unique 'vcpu-id' which is used as slot-index during
hot(un)plug of vCPU.
Note that we don't have 'vcpu-id' property. It's actually the
On Fri, 22 Sept 2023 at 13:21, Cédric Le Goater wrote:
> > +t->start = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
> > +return calculate_time(t, MAX(MAX(t->match[0], t->match[1]), 0));
>
> This MAX(MAX(x, y), 0) looks strange to me. Would you remember where it comes
> from ? Thanks,
That
Hi Salil Mehta:
From: Salil Mehta
Sent: Tuesday, September 26, 2023 12:21 PM
To: 'David Hildenbrand' ; lixianglai
; qemu-devel@nongnu.org
Cc: Salil Mehta ; Xiaojuan Yang
; Song Gao ; Michael S.
Tsirkin ; Igor Mammedov ; Ani Sinha
; Paolo Bonzini ; Richard
Henderson ; Eduardo Habkost
; Marcel
On 9/27/23 04:12, Joel Stanley wrote:
On Fri, 22 Sept 2023 at 13:21, Cédric Le Goater wrote:
+t->start = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
+return calculate_time(t, MAX(MAX(t->match[0], t->match[1]), 0));
This MAX(MAX(x, y), 0) looks strange to me. Would you remember where it
27.09.2023, 00:02, "Peter Xu" :On Thu, Sep 07, 2023 at 10:29:42PM +0300, Daniil Tatianin wrote: This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invariant. We fix
On 19.09.23 13:23, Daniil Tatianin wrote:
So that we have less magic numbers to deal with. This also allows us to
reuse these in the following commits.
Signed-off-by: Daniil Tatianin
Reviewed-by: Peter Xu
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
The virtio_list duplicates information about virtio devices that already
exist in the QOM composition tree. Instead of creating this list of
realized virtio devices, search the QOM composition tree instead.
This patch modifies the QMP command qmp_x_query_virtio to instead
recursively search the
These patches update a few things related to virtio introspection via.
QMP/HMP commands.
1. Remove 'virtio_list' and instead query the QOM composition tree to
find any active & realized virtio devices.
The 'virtio_list' was duplicating information about virtio devices that
was already available
Add new vhost-user protocol feature to vhost-user protocol feature map
and enumeration:
- VHOST_USER_PROTOCOL_F_STATUS
Add new virtio device features for several virtio devices to their
respective feature mappings:
virtio-blk:
- VIRTIO_BLK_F_SECURE_ERASE
virtio-net:
- VIRTIO_NET_F_NOTF_COAL
Move the definition of VhostUserProtocolFeature to
include/hw/virtio/vhost-user.h.
Remove previous definitions in hw/scsi/vhost-user-scsi.c,
hw/virtio/vhost-user.c, and hw/virtio/virtio-qmp.c.
Previously there were 3 separate definitions of this over 3 different
files. Now only 1 definition of
From: gaosong
Fix:
In file included from ../tcg/tcg.c:735:
/home1/gaosong/bugfix/qemu/tcg/loongarch64/tcg-target.c.inc: In function
‘tcg_out_vec_op’:
/home1/gaosong/bugfix/qemu/tcg/loongarch64/tcg-target.c.inc:1855:9: error: a
label can only be part of a statement and a declaration is
From: Marc-André Lureau
Traceback (most recent call last):
File "scripts/analyze-migration.py", line 605, in
dump.read(dump_memory = args.memory)
File "scripts/analyze-migration.py", line 542, in read
section.read()
File "scripts/analyze-migration.py", line 214, in read
raise
On 18/09/2023 22:42, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the
On 18/09/2023 22:42, Markus Armbruster wrote:
> if (local->nb_blocks != nb_dest_blocks) {
> -fprintf(stderr, "ram blocks mismatch (Number of blocks %d vs %d)
> "
> -"Your QEMU command line parameters are probably "
> -"not identical
Am 25.09.23 um 21:53 schrieb John Snow:
> On Thu, Sep 21, 2023 at 12:07 PM Simon Rowe wrote:
>>
>> When an IDE controller is reset, its internal state is being cleared
>> before any outstanding I/O is cancelled. If a response to DMA is
>> received in this window, the aio callback will incorrectly
Le 25/09/2023 à 20:56, Thomas Huth a écrit :
Rename the innermost variables to make the code compile
without warnings when using -Wshadow=local.
Signed-off-by: Thomas Huth
---
hw/m68k/bootinfo.h | 10 --
disas/m68k.c| 8
target/m68k/translate.c | 8
On 25/09/2023 21:34, Peter Xu wrote:
> It's not obvious to many that RDMA migration is in Odd Fixes stage for a
> long time. Add an explicit sub entry for it (besides migration, which
> already covers the rdma files) to be clear on that, meanwhile add Zhijian
> as Reviewer, so Zhijian can see
"Maciej S. Szmigiero" writes:
> On 25.09.2023 13:49, Markus Armbruster wrote:
>> "Maciej S. Szmigiero" writes:
>>
>>> From: "Maciej S. Szmigiero"
>>>
>>> Used by the hv-balloon driver for (optional) guest memory status reports.
>>>
>>> Signed-off-by: Maciej S. Szmigiero
>> [...]
>>
>>>
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
This determines whether the Apple Sound Chip (ASC) is set to enhanced mode
(default) or to original mode. The real Q800 hardware used an EASC chip however
a lot of older software only works with the older ASC chip.
Adding this as a machine
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
Signed-off-by: Mark Cave-Ayland
---
hw/block/swim.c | 14 ++
hw/block/trace-events | 7 +++
2 files changed, 21 insertions(+)
diff --git a/hw/block/swim.c b/hw/block/swim.c
index 333da08ce0..7df36ea139 100644
---
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
The swim chip provides an implementation of both Apple's IWM and ISM floppy disk
controllers. Split the existing implementation into separate register banks for
each controller, whilst also switching the IWM registers from 16-bit to 8-bit
as
On 18/09/2023 22:42, Markus Armbruster wrote:
> When qemu_rdma_wait_comp_channel() receives an event from the
> completion channel, it reports an error "receive cm event while wait
> comp channel,cm event is T", where T is the numeric event type.
> However, the function fails only when T is a
> From: Jason Gunthorpe
> Sent: Thursday, September 21, 2023 2:20 AM
>
> On Wed, Sep 20, 2023 at 12:17:24PM -0600, Alex Williamson wrote:
>
> > > The iommufd design requires one open of the /dev/iommu to be shared
> > > across all the vfios.
> >
> > "requires"? It's certainly of limited value
On 9/26/23 04:14, Jing Liu wrote:
Changes since v2:
- v2: https://www.mail-archive.com/qemu-devel@nongnu.org/msg989852.html
- Use a bool type to test (vdev->nr_vectors < nr + 1). (Alex)
- Revise comments. (Alex)
- Apply Cédric's and Alex's Reviewed-by.
Changes since v1:
- v1:
"Zhijian Li (Fujitsu)" writes:
> On 18/09/2023 22:41, Markus Armbruster wrote:
>> Functions that use an Error **errp parameter to return errors should
>> not also report them to the user, because reporting is the caller's
>> job. When the caller does, the error is reported twice. When it
>>
On 18/09/2023 22:42, Markus Armbruster wrote:
> qemu_rdma_dump_id() dumps RDMA device details to stdout.
>
> rdma_start_outgoing_migration() calls it via qemu_rdma_source_init()
> and qemu_rdma_resolve_host() to show source device details.
> rdma_start_incoming_migration() arranges its call via
On Thu, Sep 21, 2023 at 02:41:54PM +0530, Kishon Vijay Abraham I wrote:
> > PCI Endpoint function driver is implemented using the PCIe Endpoint
> > framework, but it requires physical boards for testing, and it is difficult
> > to test sufficiently. In order to find bugs and hardware-dependent
> >
Hi Laszlo
On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek wrote:
> Has this been queued by someone? Both Gerd and Marc-André are "odd
> fixers", so I'm not sure who should be sending a PR with these patches
> (and I don't see a pending PULL at
>
The original issue I found : After starting a VM which has two ice PFs
and a virtio-iommu device, qemu-kvm and VM guest dmesg throw lots of
duplicate VFIO_MAP_DMA errors
After testing with Eric's build, the original issue is gone and the
Tier1 regression test against ice PF and virtio iommu
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
The A/UX timer calibration loop runs continuously until 2 consecutive iterations
differ by at least 0x492 timer ticks. Modern hosts execute the timer calibration
loop so fast that this situation never occurs causing a hang on boot.
Use a similar
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
According to the Apple Quadra 800 Developer Note document, the Quadra 800 ROM
consists of 2 ROM code sections based at offsets 0x0 and 0x80. A/UX attempts
to access the toolbox ROM at the lower offset during startup, so provide a
memory alias
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
Tests on real Q800 hardware show that the ESCC is addressable at multiple
locations
within the ESCC memory region - at least 0xc000, 0xc020 (as expected by the
MacOS
toolbox ROM) and 0xc040.
All released NetBSD kernels before 10 use the 0xc000
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
Update the IWM/ISM register block decoding to match the description given in the
"SWIM Chip Users Reference". This allows us to validate the device response to
the guest OS which currently only does just enough to indicate that the floppy
drive
Could you add a comment into the commit message why ee_data must be
bigger than ee_info?
On 9/25/23 22:40, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
io/channel-socket.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/io/channel-socket.c
On 18/09/2023 22:42, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the
On 18/09/2023 22:41, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the
"Zhijian Li (Fujitsu)" writes:
> On 18/09/2023 22:41, Markus Armbruster wrote:
>> Functions that use an Error **errp parameter to return errors should
>> not also report them to the user, because reporting is the caller's
>> job. When the caller does, the error is reported twice. When it
>>
> > FRED CPU states are managed in 10 FRED MSRs, in addtion to a few
> > existing CPU registers and MSRs, e.g., the CR4.FRED bit.
> >
> > Add the 10 new FRED MSRs to x86 CPUArchState for live migration support.
> >
>
> IMO, it's better to split this patch into two, one is for FRED MSR access,
>
Fix:
[1839/2601] Compiling C object
libqemu-loongarch64-softmmu.fa.p/hw_loongarch_virt.c.o
../hw/loongarch/virt.c: In function 'loongarch_irq_init':
../hw/loongarch/virt.c:665:14: warning: declaration of 'i' shadows a previous
local [-Wshadow=compatible-local]
for (int i = 0; i <
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
When the NetBSD kernel initialises it can leave the ADB interrupt asserted
depending upon where in the ADB poll cycle the MacOS ADB interrupt handler
is when the NetBSD kernel disables interrupts.
The NetBSD ADB driver uses the ADB interrupt
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
NetBSD switches directly to IDLE state without switching the shift register to
input mode. Duplicate the existing ADB_STATE_IDLE logic in input mode from when
the shift register is in output mode which allows the ADB autopoll handler to
handle
On 18/09/2023 22:42, Markus Armbruster wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job. When the caller does, the error is reported twice. When it
> doesn't (because it recovered from the
Cédric Le Goater writes:
> On 9/23/23 09:13, Markus Armbruster wrote:
>> Cédric Le Goater writes:
>>
>>> On 9/22/23 20:20, Philippe Mathieu-Daudé wrote:
On 22/9/23 17:59, Cédric Le Goater wrote:
> Hello,
>
> Here are cleanups for local variable shadowing warnings in aspeed
Paolo Bonzini writes:
> On 9/25/23 13:03, Markus Armbruster wrote:
>> +David
>> Markus Armbruster writes:
>>
>>> Philippe Mathieu-Daudé writes:
>>>
DEFINE_PROP_DMAADDR() is only used once. Since it doesn't
add much value, simply remove it, along with the header
defining it.
On 26/09/2023 14:41, Markus Armbruster wrote:
> "Zhijian Li (Fujitsu)" writes:
>
>> On 18/09/2023 22:41, Markus Armbruster wrote:
>>> Functions that use an Error **errp parameter to return errors should
>>> not also report them to the user, because reporting is the caller's
>>> job. When the
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
The MacOS toolbox ROM calculates the number of branches that can be executed
per millisecond as part of its timer calibration. Since modern hosts are
considerably quicker than original hardware, the negative counter reaches zero
before the
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit :
NetBSD assumes it can send its first ADB command after sending the ADB_BUSRESET
command in ADB_STATE_NEW without changing the state back to ADB_STATE_IDLE
first as detailed in the ADB protocol.
Add a workaround to detect this condition at the
Hi Tong,
On [2023 Sep 21] Thu 23:50:10, Tong Ho wrote:
> Signed-off-by: Tong Ho
> ---
> tests/qtest/meson.build | 2 +-
> tests/qtest/xlnx-versal-trng-test.c | 490
> 2 files changed, 491 insertions(+), 1 deletion(-)
> create mode 100644
Hi Cédric,
>-Original Message-
>From: Duan, Zhenzhong
>Sent: Thursday, September 21, 2023 6:14 PM
>Subject: RE: [PATCH v1 04/22] vfio/common: Introduce
>vfio_container_add|del_section_window()
>
>Hi Cédric,
>
>>-Original Message-
>>From: Cédric Le Goater
>>Sent: Thursday,
Hi Salil,
On 9/26/23 20:04, Salil Mehta wrote:
Adds various utility functions which might be required to fetch or check the
state of the possible vCPUs. This also introduces concept of *disabled* vCPUs,
which are part of the *possible* vCPUs but are not part of the *present* vCPU.
This state
On Thu, Sep 07, 2023 at 10:29:42PM +0300, Daniil Tatianin wrote:
> This series fixes an issue where the outcome of the migration qtest
> relies on the initial memory contents all being the same across the
> first 100MiB of RAM, which is a very fragile invariant.
>
> We fix this by making sure we
On 26/09/2023 19:52, Markus Armbruster wrote:
> "Zhijian Li (Fujitsu)" writes:
>
>> On 18/09/2023 22:42, Markus Armbruster wrote:
>>> Functions that use an Error **errp parameter to return errors should
>>> not also report them to the user, because reporting is the caller's
>>> job. When the
On Fri, 22 Sept 2023 at 15:59, Cédric Le Goater wrote:
>
> Remove superfluous local 'data' variable and use the one define at the
> top of the routine. This fixes :
>
> ../hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_recv’:
> ../hw/i2c/aspeed_i2c.c:315:17: warning: declaration of ‘data’
"Zhijian Li (Fujitsu)" writes:
> On 26/09/2023 19:52, Markus Armbruster wrote:
>> "Zhijian Li (Fujitsu)" writes:
>>
>>> On 18/09/2023 22:42, Markus Armbruster wrote:
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because
On 19.09.23 13:23, Daniil Tatianin wrote:
The migration qtest all the way up to this point used to work by sheer
luck relying on the contents of all pages from 1MiB to 100MiB to contain
the same one value in the first byte initially.
This easily breaks if we reduce the amount of RAM for the
On Mon, Sep 25, 2023 at 12:28 PM Karim Taha
wrote:
> Upstream the implementation of the following mmap system calls, from the
> qemu-bsd-user fork:
>mmap(2), munmap(2),
>mprotect(2),
>msync(2),
>mlock(2), munlock(2), mlockall(2), munlockall(2), mincore(2),
>madvise(2),
>
On Wed, Sep 27, 2023 at 5:35 AM Daniel Henrique Barboza
wrote:
>
> We'll introduce generic errors that will output a CPU type name via its
> RISCVCPU pointer. Create a helper for that.
>
> Use the helper in tcg_cpu_realizefn() instead of hardcoding the 'host'
> CPU name.
>
> Signed-off-by: Daniel
26.09.2023, 23:41, "Vladimir Sementsov-Ogievskiy" :On 07.09.23 22:29, Daniil Tatianin wrote: The migration qtest all the way up to this point used to work by sheer luck relying on the contents of all pages from 1MiB to 100MiB to contain the same one value in the first byte initially. This easily
27.09.2023, 00:02, "Peter Xu" :On Thu, Sep 07, 2023 at 10:29:42PM +0300, Daniil Tatianin wrote: This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invariant. We fix
On 19.09.23 13:23, Daniil Tatianin wrote:
Same as with the x86 verison of this test, we relied on the contents of
all pages in RAM to be the same across the entire test range, which is
very fragile. Zero the first byte of each page before running the
increment loop to fix this.
Fixes:
On Mon, Sep 25, 2023 at 12:25 PM Karim Taha
wrote:
>
>
> Karim Taha (3):
> bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics,
> and fix RLIM_INFINITY
> bsd-user: Implement get_filename_from_fd.
> bsd-user: Implement execve(2) and fexecve(2) system calls.
>
> Kyle
Hi Salil,
On 9/26/23 20:04, Salil Mehta wrote:
Factor out CPU properties code common for {hot,cold}-plugged CPUs. This allows
code reuse.
Signed-off-by: Salil Mehta
---
hw/arm/virt.c | 220 ++
include/hw/arm/virt.h | 4 +
2 files changed,
On Tue, Nov 22, 2022 at 05:12:59PM +, Anthony PERARD wrote:
> On Mon, Nov 14, 2022 at 08:20:10PM +0100, Marek Marczykowski-Górecki wrote:
> > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> > index 0ec7e52183..269bd26109 100644
> > --- a/hw/xen/xen_pt.c
> > +++ b/hw/xen/xen_pt.c
> > @@ -255,6
Hi Salil Mehta:
Hi Xianglai,
From: xianglai li
Sent: Tuesday, September 26, 2023 10:55 AM
To: qemu-devel@nongnu.org
Cc: Bernhard Beschow ; Salil Mehta
; Salil Mehta ; Xiaojuan
Yang ; Song Gao ; Michael S.
Tsirkin ; Igor Mammedov ; Ani Sinha
; Paolo Bonzini ; Richard
Henderson ; Eduardo
On 26/09/2023 21.25, Fabiano Rosas wrote:
Our linker script for optionroms specifies only the placement of the
.text section, leaving the linker free to place the remaining sections
at arbitrary places in the file.
Since at least binutils 2.39, the .note.gnu.build-id section is now
being placed
[ *REPEAT: Sent patches got held at internal server yesterday* ]
PROLOGUE
To assist in review and set the right expectations from this RFC, please first
read below sections *APPENDED AT THE END* of this cover letter,
1. Important *DISCLAIMER* [Section (X)]
2. Work presented at KVMForum
This shall be used to store user specified topology{socket,cluster,core,thread}
and shall be converted to a unique 'vcpu-id' which is used as slot-index during
hot(un)plug of vCPU.
Co-developed-by: Salil Mehta
Signed-off-by: Salil Mehta
Co-developed-by: Keqian Zhu
Signed-off-by: Keqian Zhu
Adds various utility functions which might be required to fetch or check the
state of the possible vCPUs. This also introduces concept of *disabled* vCPUs,
which are part of the *possible* vCPUs but are not part of the *present* vCPU.
This state shall be used during machine init time to check the
> You're welcome to be the maintainer. I haven't touched it in years.
>
> When you have reviewed future simpletrace.py patches you can either post
> your Reviewed-by and I'll include them in my tracing pull requests, or
> you could send pull requests to the qemu.git maintainer yourself
>
From: Andrey Drobyshev
This fixes authorship of commits 2848289168, 52b10c9c0c as the mailing
list rewrote the "From:" field in the corresponding patches. See commit
3bd2608db7 ("maint: Add .mailmap entries for patches claiming list
authorship") for explanation.
Signed-off-by: Andrey Drobyshev
Hi David,
> From: qemu-devel-bounces+salil.mehta=huawei@nongnu.org bounces+salil.mehta=huawei@nongnu.org> On Behalf Of David Hildenbrand
> Sent: Tuesday, September 12, 2023 8:00 AM
> To: xianglai li ; qemu-devel@nongnu.org
> Cc: Salil Mehta ; Xiaojuan Yang
> ; Song Gao ; Michael S.
>
Hi Xianglai,
> From: lixianglai
> Sent: Friday, September 15, 2023 3:48 AM
> To: David Hildenbrand ; qemu-devel@nongnu.org; Salil
> Mehta
> Cc: Salil Mehta ; Xiaojuan Yang
> ; Song Gao ; Michael S.
> Tsirkin ; Igor Mammedov ; Ani Sinha
> ; Paolo Bonzini ; Richard
> Henderson ; Eduardo Habkost
>
On Tue, Sep 26, 2023 at 10:49:08AM +, Salil Mehta wrote:
> Hi Xianglai,
> FYI. RFC V2 is out and you can now drop the arch agnostic patches from
> your patch-set. Please check the details in the cover letter which one
> you need to pick and rebase from:
>
>
> From: Michael S. Tsirkin
> Sent: Tuesday, September 26, 2023 12:02 PM
> To: Salil Mehta
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean-
> phili...@linaro.org; Jonathan Cameron ;
> lpieral...@kernel.org; peter.mayd...@linaro.org;
> richard.hender...@linaro.org;
On Tue, Sep 26, 2023 at 07:26:40PM +0800, lixianglai wrote:
>
> Hi, Michael S. Tsirkin :
> > On Tue, Sep 26, 2023 at 05:54:26PM +0800, xianglai li wrote:
> > > ACPI GED shall be used to convey to the guest kernel about any cpu
> > > hot-(un)plug
> > > events. Therefore, existing ACPI GED
From: Pierre Morel
Add some basic examples for the definition of cpu topology
in s390x.
Signed-off-by: Pierre Morel
Co-developed-by: Nina Schoetterl-Glausch
Reviewed-by: Thomas Huth
Signed-off-by: Nina Schoetterl-Glausch
---
MAINTAINERS| 2 +
1 - 100 of 400 matches
Mail list logo